[clang] [clang][bytecode] Use std::allocator calls for Descriptor source (PR #123900)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes ... for the dynamic blocks created for operator new calls. This way we get the type of memory allocated right. As a side-effect, the diagnostics now point to the std::allocator calls, which is an improvement

[clang] [mutation analyzer] support mutation analysis for pointee (PR #118593)

2025-01-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/118593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Use std::allocator calls for Descriptor source (PR #123900)

2025-01-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/123900 ... for the dynamic blocks created for operator new calls. This way we get the type of memory allocated right. As a side-effect, the diagnostics now point to the std::allocator calls, which is an improvement.

[clang] [clang][CodeComplete] Use HeuristicResolver to resolve DependentNameTypes (PR #123818)

2025-01-21 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/123818 >From 25fdf43fb182212e859aba806ab32cc25ec466af Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 26 Dec 2024 20:59:06 -0500 Subject: [PATCH 1/3] [clang][CodeComplete] Use HeuristicResolver to resolve

[clang] [llvm] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation (PR #116771)

2025-01-21 Thread via cfe-commits
https://github.com/tangaac updated https://github.com/llvm/llvm-project/pull/116771 >From 8abca09066ae8edcfb322fa01cee4ba678fc5ca4 Mon Sep 17 00:00:00 2001 From: tangaac Date: Tue, 19 Nov 2024 17:43:31 +0800 Subject: [PATCH 1/5] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation

[clang] [llvm] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation (PR #116771)

2025-01-21 Thread via cfe-commits
https://github.com/tangaac deleted https://github.com/llvm/llvm-project/pull/116771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation (PR #116771)

2025-01-21 Thread via cfe-commits
@@ -604,6 +610,109 @@ bool LoongArchExpandAtomicPseudo::expandAtomicCmpXchg( return true; } +bool LoongArchExpandAtomicPseudo::expandAtomicCmpXchg128( +MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI, +MachineBasicBlock::iterator &NextMBBI) { + MachineInstr

[clang] [Clang] SubstituteConstraintExpressionWithoutSatisfaction needs an unevaluated context (PR #123883)

2025-01-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/123883 >From 5427c748811041d0878dc4aec8b7b37c4241af37 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 21 Jan 2025 20:21:20 +0800 Subject: [PATCH 1/3] [Clang] SubstituteConstraintExpressionWithoutSatisfaction ne

[clang] [clang][CodeComplete] Use HeuristicResolver to resolve pointee types (PR #121315)

2025-01-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12151 Here is the r

[clang] [Clang] SubstituteConstraintExpressionWithoutSatisfaction needs an unevaluated context (PR #123883)

2025-01-21 Thread Younan Zhang via cfe-commits
@@ -248,6 +248,25 @@ ExprResult Parser::ParseArrayBoundExpression() { // If we parse the bound of a VLA... we parse a non-constant // constant-expression! Actions.ExprEvalContexts.back().InConditionallyConstantEvaluateContext = true; + // For a VLA type inside an uneval

[clang] [Clang] SubstituteConstraintExpressionWithoutSatisfaction needs an unevaluated context (PR #123883)

2025-01-21 Thread via cfe-commits
@@ -248,6 +248,25 @@ ExprResult Parser::ParseArrayBoundExpression() { // If we parse the bound of a VLA... we parse a non-constant // constant-expression! Actions.ExprEvalContexts.back().InConditionallyConstantEvaluateContext = true; + // For a VLA type inside an uneval

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-21 Thread Scott Constable via cfe-commits
scottconstable wrote: @sirmc @samitolvanen @Darksonn @lvwr @maurer @rcvalle A gentle reminder to please review this PR. https://github.com/llvm/llvm-project/pull/121070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Clang] SubstituteConstraintExpressionWithoutSatisfaction needs an unevaluated context (PR #123883)

2025-01-21 Thread Younan Zhang via cfe-commits
@@ -248,6 +248,25 @@ ExprResult Parser::ParseArrayBoundExpression() { // If we parse the bound of a VLA... we parse a non-constant // constant-expression! Actions.ExprEvalContexts.back().InConditionallyConstantEvaluateContext = true; + // For a VLA type inside an uneval

[clang] [Clang] SubstituteConstraintExpressionWithoutSatisfaction needs an unevaluated context (PR #123883)

2025-01-21 Thread via cfe-commits
@@ -248,6 +248,25 @@ ExprResult Parser::ParseArrayBoundExpression() { // If we parse the bound of a VLA... we parse a non-constant // constant-expression! Actions.ExprEvalContexts.back().InConditionallyConstantEvaluateContext = true; + // For a VLA type inside an uneval

[clang] [llvm] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation (PR #116771)

2025-01-21 Thread via cfe-commits
@@ -604,6 +610,109 @@ bool LoongArchExpandAtomicPseudo::expandAtomicCmpXchg( return true; } +bool LoongArchExpandAtomicPseudo::expandAtomicCmpXchg128( +MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI, +MachineBasicBlock::iterator &NextMBBI) { + MachineInstr

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-21 Thread Tom Honermann via cfe-commits
@@ -18,6 +18,7 @@ #include "clang/AST/StmtObjC.h" #include "clang/AST/StmtOpenACC.h" #include "clang/AST/StmtOpenMP.h" +#include "clang/AST/StmtSYCL.h" tahonermann wrote: Hmm, looks like no reason at all. I'm guessing it was once needed for some X-Macro usage

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-21 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/122379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-21 Thread Tom Honermann via cfe-commits
@@ -480,6 +480,7 @@ following requirements. * Is not a C variadic function. * Is not a coroutine. * Is not defined as deleted or as defaulted. +* Is not defined with a function try block. tahonermann wrote: The SYCL specification isn't relevant here as `sycl_k

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-21 Thread Tom Honermann via cfe-commits
@@ -0,0 +1,94 @@ +//===- StmtSYCL.h - Classes for SYCL kernel calls ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-21 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann commented: > I only saw 1 unresolved, not 2? But I resolved it. Can you point out the > other? The other one was [this one](https://github.com/llvm/llvm-project/pull/122379#discussion_r1910706213); You gave it a thumbs up, so I went ahead and resolved it now.

[clang] [llvm] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation (PR #116771)

2025-01-21 Thread via cfe-commits
https://github.com/tangaac updated https://github.com/llvm/llvm-project/pull/116771 >From 8abca09066ae8edcfb322fa01cee4ba678fc5ca4 Mon Sep 17 00:00:00 2001 From: tangaac Date: Tue, 19 Nov 2024 17:43:31 +0800 Subject: [PATCH 1/4] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation

[clang] Remove references to mips within Android (PR #123856)

2025-01-21 Thread via cfe-commits
https://github.com/pirama-arumuga-nainar approved this pull request. https://github.com/llvm/llvm-project/pull/123856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-21 Thread via cfe-commits
@@ -2290,18 +2290,21 @@ CXXDeductionGuideDecl *CXXDeductionGuideDecl::Create( ASTContext &C, DeclContext *DC, SourceLocation StartLoc, ExplicitSpecifier ES, const DeclarationNameInfo &NameInfo, QualType T, TypeSourceInfo *TInfo, SourceLocation EndLocation, CXXConstr

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-21 Thread via cfe-commits
https://github.com/cor3ntin commented: LGTM modulo nits. Can we observe that through sema/pch tests? https://github.com/llvm/llvm-project/pull/123875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-21 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/123875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PseudoProbe] Support emitting to COFF object (PR #123870)

2025-01-21 Thread Fangrui Song via cfe-commits
@@ -12,7 +12,7 @@ target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" -target triple = "x86_64-unknown-linux-gnu" +target triple = "x86_64-unknown--" MaskRay wrote: Triples with unknown OS default to ELF, so this doesn't really test COFF. You'll ha

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilo (Large Offset Load Store) extension (PR #123881)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-backend-risc-v Author: quic_hchandel (hchandel) Changes This extension adds eight 48 bit load store instructions. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/latest This patch adds assembl

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilo (Large Offset Load Store) extension (PR #123881)

2025-01-21 Thread via cfe-commits
https://github.com/hchandel created https://github.com/llvm/llvm-project/pull/123881 This extension adds eight 48 bit load store instructions. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/latest This patch adds assembler only support. >From 48e15154af7e8

[clang] [llvm] [HIP] Support managed variables using the new driver (PR #123437)

2025-01-21 Thread Matt Arsenault via cfe-commits
@@ -1221,12 +1221,34 @@ void CGNVCUDARuntime::createOffloadingEntries() { ? static_cast(llvm::offloading::OffloadGlobalNormalized) : 0); if (I.Flags.getKind() == DeviceVarFlags::Variable) { - llvm::offloading::emitOffloadingEntry( - M

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2025-01-21 Thread via cfe-commits
@@ -2010,6 +2032,25 @@ class CXXDeductionGuideDecl : public FunctionDecl { /// this is an implicit deduction guide. CXXConstructorDecl *getCorrespondingConstructor() const { return Ctor; } + /// Get the deduction guide from which this deduction guide was generated, + ///

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2025-01-21 Thread via cfe-commits
antangelo wrote: I have split the source deduction guide tracking into #123875, and will continue working on fixing the remaining issues here to land P2582R1 for clang 21. https://github.com/llvm/llvm-project/pull/98788 ___ cfe-commits mailing list c

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: None (antangelo) Changes For deduction guides generated from alias template CTAD, store the deduction guide they were originated from. The source kind is also maintained for future expansion in CTAD from inherited constructors. T

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes For deduction guides generated from alias template CTAD, store the deduction guide they were originated from. The source kind is also maintained for future expansion in CTAD from inherited constructors. This trac

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-21 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/123875 For deduction guides generated from alias template CTAD, store the deduction guide they were originated from. The source kind is also maintained for future expansion in CTAD from inherited constructors. This

[clang] [lld] [Driver] Default enable LoongArch linker relaxation (PR #111488)

2025-01-21 Thread Lu Weining via cfe-commits
https://github.com/SixWeining closed https://github.com/llvm/llvm-project/pull/111488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [Driver] Default enable LoongArch linker relaxation (PR #111488)

2025-01-21 Thread Lu Weining via cfe-commits
SixWeining wrote: I prefer #123587 that defaults to relax disabled. https://github.com/llvm/llvm-project/pull/111488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Support linker relaxation options for LoongArch (PR #123587)

2025-01-21 Thread via cfe-commits
https://github.com/zhaoqi5 updated https://github.com/llvm/llvm-project/pull/123587 >From 8608d84983580afd13a791bece3ca7b05872b36b Mon Sep 17 00:00:00 2001 From: Qi Zhao Date: Mon, 20 Jan 2025 19:09:22 +0800 Subject: [PATCH 1/3] [Clang][Driver] Pass -X and forward --no-relax to linker for Loon

[clang] [Clang][Driver] Support linker relaxation options for LoongArch (PR #123587)

2025-01-21 Thread via cfe-commits
https://github.com/zhaoqi5 updated https://github.com/llvm/llvm-project/pull/123587 >From 8608d84983580afd13a791bece3ca7b05872b36b Mon Sep 17 00:00:00 2001 From: Qi Zhao Date: Mon, 20 Jan 2025 19:09:22 +0800 Subject: [PATCH 1/2] [Clang][Driver] Pass -X and forward --no-relax to linker for Loon

[clang] [Clang][Driver] Support linker relaxation options for LoongArch (PR #123587)

2025-01-21 Thread via cfe-commits
https://github.com/zhaoqi5 edited https://github.com/llvm/llvm-project/pull/123587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Pass -X and forward --no-relax to linker for LoongArch (PR #123587)

2025-01-21 Thread via cfe-commits
https://github.com/zhaoqi5 edited https://github.com/llvm/llvm-project/pull/123587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][SIMD][FIX] Use conservative "omp simd ordered" lowering (PR #123867)

2025-01-21 Thread via cfe-commits
https://github.com/MattPD edited https://github.com/llvm/llvm-project/pull/123867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-reorder-fields] Reorder leading comments (PR #123740)

2025-01-21 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/123740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LoongArch] Support sc.q instruction for 128bit cmpxchg operation (PR #116771)

2025-01-21 Thread Lu Weining via cfe-commits
SixWeining wrote: Add `--verify-machineinstrs` option as the code calls lots of `BuildMI(...)`. https://github.com/llvm/llvm-project/pull/116771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [C++20] [Modules] Make sure vtable are generated for explicit template instantiation definition (PR #123871)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/123719 The reason is, we thought the external explicit template instantiation declaration as the external definition incorrectly. --- Full diff: ht

[clang] [C++20] [Modules] Make sure vtable are generated for explicit template instantiation definition (PR #123871)

2025-01-21 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/123871 Close https://github.com/llvm/llvm-project/issues/123719 The reason is, we thought the external explicit template instantiation declaration as the external definition incorrectly. >From 77cc683b9e0330baf089

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-21 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @petr-polezhaev please update the mail address. We don't like github.reply mail address. https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-21 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Given @kadircet is approved and @petr-polezhaev is marked as `first-time contributor`, I'll merge this by assuming you don't have the commit access. https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-co

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-21 Thread Michael Flanders via cfe-commits
https://github.com/Flandini updated https://github.com/llvm/llvm-project/pull/123003 >From 7e0758d2ead53bd4288989b8b2eda218cd6dc34a Mon Sep 17 00:00:00 2001 From: Michael Flanders Date: Mon, 13 Jan 2025 12:34:50 -0600 Subject: [PATCH 01/15] [analyzer] Add MemSpace trait to program state This t

[clang] [OpenMP][SIMD][FIX] Use conservative "omp simd ordered" lowering (PR #123867)

2025-01-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 07d496538f5543a8eed5e207148e28e358b7cca4 1b603f7182fa7ed14bf0aeeb7a40280c990d25bf --e

[clang] [OpenMP][SIMD][FIX] Use conservative "omp simd ordered" lowering (PR #123867)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matt (MattPD) Changes A proposed fix for #95611 [OpenMP][SIMD] ordered has no effect in a loop SIMD region as of LLVM 18.1.0 Changes: - Implement new lowering behavior: Conservatively serialize "omp simd" loops that have `omp simd order

[clang] [llvm] Reland "[HLSL] Implement the `reflect` HLSL function" (PR #123853)

2025-01-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. I'm only reviewing commit def10ad82c6e527ba5c3aa29b76041dc94acff1d The reasoning for the change\fix makes sense. Although I don't like the commit message. You don't need to amend the commit, but use the github ui to fix up the commit mess

[clang] [OpenMP][SIMD][FIX] Use conservative "omp simd ordered" lowering (PR #123867)

2025-01-21 Thread via cfe-commits
https://github.com/MattPD created https://github.com/llvm/llvm-project/pull/123867 A proposed fix for #95611 [OpenMP][SIMD] ordered has no effect in a loop SIMD region as of LLVM 18.1.0 Changes: - Implement new lowering behavior: Conservatively serialize "omp simd" loops that have `omp simd

[clang] [llvm] Reland "[HLSL] Implement the `reflect` HLSL function" (PR #123853)

2025-01-21 Thread Farzon Lotfi via cfe-commits
farzonl wrote: redundant is not the right word here. Irrelevant or not necessary makes more sense in this context. https://github.com/llvm/llvm-project/pull/123853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-21 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/123394 >From 1d04bfa8e1b138a13acf30c3fc46428d3b260569 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Fri, 17 Jan 2025 12:40:21 -0800 Subject: [PATCH 1/3] [HLSL] Fix global resource initialization Fixes #120636 ---

[clang] [BoundsSafety][Doc] Add BoundsSafetyAdoptionGuide.rst (PR #120674)

2025-01-21 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna updated https://github.com/llvm/llvm-project/pull/120674 >From 390d37d9706472e46a34366bcaa519d34496b888 Mon Sep 17 00:00:00 2001 From: Yeoul Na Date: Fri, 20 Dec 2024 12:20:03 +0900 Subject: [PATCH 1/2] [BoundsSafety][Doc] Add BoundsSafetyAdoptionGuide.rst --- clan

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-21 Thread Yanzuo Liu via cfe-commits
@@ -5321,6 +5321,59 @@ class BuiltinBitCastExpr final } }; +// Represents an unexpanded pack where the list of expressions are +// known. These are used when structured bindings introduce a pack. +class ResolvedUnexpandedPackExpr final +: public Expr, + private llvm

[clang] [NFC] Avoid potential nullptr deref by using castAs<> (PR #123395)

2025-01-21 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang,llvm` at step 7 "test-build-unified-tree-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/17567 Here is t

[clang] [mutation analyzer] support mutation analysis for pointee (PR #118593)

2025-01-21 Thread Julian Schmidt via cfe-commits
@@ -654,6 +716,83 @@ ExprMutationAnalyzer::Analyzer::findFunctionArgMutation(const Expr *Exp) { return nullptr; } +const Stmt * +ExprMutationAnalyzer::Analyzer::findPointeeValueMutation(const Expr *Exp) { + const auto Matches = match( + stmt(forEachDescendant( +

[clang] [mutation analyzer] support mutation analysis for pointee (PR #118593)

2025-01-21 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/118593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove references to mips within Android (PR #123856)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: AdityaK (hiraditya) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/123856.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp (+1-5) ``diff diff --git a/clang/lib/Driver/ToolChain

[clang] Remove references to mips within Android (PR #123856)

2025-01-21 Thread via cfe-commits
https://github.com/hiraditya created https://github.com/llvm/llvm-project/pull/123856 None >From 2a117892d87eb272d2d4b6ae9b81ee480d4f555e Mon Sep 17 00:00:00 2001 From: AdityaK Date: Tue, 21 Jan 2025 16:15:21 -0800 Subject: [PATCH] Remove references to mips within Android --- clang/lib/Drive

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2025-01-21 Thread via cfe-commits
github-actions[bot] wrote: @vtz Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, you

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2025-01-21 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6ab9daf - [clang] Implement #pragma clang section on COFF targets (#112714)

2025-01-21 Thread via cfe-commits
Author: Vinicius Tadeu Zein Date: 2025-01-21T16:12:58-08:00 New Revision: 6ab9dafec807a64a4e940bfaecc815e23454dfe8 URL: https://github.com/llvm/llvm-project/commit/6ab9dafec807a64a4e940bfaecc815e23454dfe8 DIFF: https://github.com/llvm/llvm-project/commit/6ab9dafec807a64a4e940bfaecc815e23454dfe8

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2025-01-21 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeComplete] Use HeuristicResolver to resolve pointee types (PR #121315)

2025-01-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Looks great, thanks https://github.com/llvm/llvm-project/pull/121315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/1

[clang] [llvm] Reland "[HLSL] Implement the `reflect` HLSL function" (PR #123853)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-backend-spir-v Author: Deric Cheung (Icohedron) Changes This PR relands [#122992](https://github.com/llvm/llvm-project/pull/122992). Some machines were failing to run the `reflect-error.ll` test due to the RUN lines ```

[clang] [llvm] Reland "[HLSL] Implement the `reflect` HLSL function" (PR #123853)

2025-01-21 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron created https://github.com/llvm/llvm-project/pull/123853 This PR relands [#122992](https://github.com/llvm/llvm-project/pull/122992). Some machines were failing to run the `reflect-error.ll` test due to the RUN lines ```llvm ; RUN: not %if spirv-tools %{ llc -O0 -m

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-21 Thread Helena Kotas via cfe-commits
@@ -536,89 +536,84 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() { } } -void CGHLSLRuntime::handleGlobalVarDefinition(const VarDecl *VD, - llvm::GlobalVariable *GV) { - // If the global variable has resource binding, add i

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ml-opt-rel-x86-64` running on `ml-opt-rel-x86-64-b1` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/185/builds/11836 Here i

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2025-01-21 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/11773

[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)

2025-01-21 Thread via cfe-commits
https://github.com/Shakil582 closed https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-write codegen for atomic_test_and_set and atomic_clear (PR #121943)

2025-01-21 Thread James Y Knight via cfe-commits
https://github.com/jyknight approved this pull request. https://github.com/llvm/llvm-project/pull/121943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Reject declaring an alias template with the same name as its template parameter. (PR #123533)

2025-01-21 Thread Valentyn Yukhymenko via cfe-commits
https://github.com/BaLiKfromUA edited https://github.com/llvm/llvm-project/pull/123533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-write codegen for atomic_test_and_set and atomic_clear (PR #121943)

2025-01-21 Thread James Y Knight via cfe-commits
@@ -3911,14 +3926,31 @@ ExprResult Sema::BuildAtomicExpr(SourceRange CallRange, SourceRange ExprRange, } } - // Pointer to object of size zero is not allowed. - if (RequireCompleteType(Ptr->getBeginLoc(), AtomTy, - diag::err_incomplete_type))

[clang] [clang] Lower non-builtin sincos[f|l] calls to llvm.sincos.* when -fno-math-errno is set (PR #121763)

2025-01-21 Thread Chang Lin via cfe-commits
clin111 wrote: Looks like it was never enabled --- or tested on X86 --- since UseAA was introduced in https://reviews.llvm.org/D67266. Eventually the dead option was removed with c266776. Would advise some caution with regards to register pressure and compile time. https://github.com/llvm/llv

[clang] [Clang] Reject declaring an alias template with the same name as its template parameter. (PR #123533)

2025-01-21 Thread Valentyn Yukhymenko via cfe-commits
@@ -13464,6 +13464,14 @@ Decl *Sema::ActOnAliasDeclaration(Scope *S, AccessSpecifier AS, } TemplateParameterList *TemplateParams = TemplateParamLists[0]; +// Check shadowing of a template parameter name +for (NamedDecl *TP : TemplateParams->asArray()) { +

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2025-01-21 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai commented: I've realized that the test doesn't have to be Objective-C, the failure is reproducible in C. Curiously, we aren't hitting the assertion in C++/Objective-C++ but I don't know why. I wanted to try defining the enums in different scopes (e.g. in a struct) an

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-21 Thread Deric Cheung via cfe-commits
Icohedron wrote: > Will a follow-up issue be created to move the useful Sema helpers into a > common file? I just created issue #123831 for this. https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Support BraceWrapping.AfterNamespace with AllowShortNamespacesOnASingleLine (PR #123010)

2025-01-21 Thread Galen Elias via cfe-commits
https://github.com/galenelias updated https://github.com/llvm/llvm-project/pull/123010 >From 9d60d4980f1edbdd4cd4a9499f69e9d225717238 Mon Sep 17 00:00:00 2001 From: Galen Elias Date: Tue, 14 Jan 2025 20:44:10 -0800 Subject: [PATCH 1/2] Support BraceWrapping.AfterNamespace with AllowShortNamesp

[clang] [llvm] [AArch64] FEAT_SPEv1p2 is optional in v8.7-A and v9.2-A (PR #123336)

2025-01-21 Thread Jon Roelofs via cfe-commits
jroelofs wrote: https://github.com/llvm/llvm-project/pull/123827 https://github.com/llvm/llvm-project/pull/123336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64] apple-m4 does not have FEAT_{SPEv1p2,SEL2,MPAM} (PR #123827)

2025-01-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jon Roelofs (jroelofs) Changes This commit addresses some uncertainty raised in 84fa1755a5b7845ddaeaa513a3786013c76c9c88 as to which features Apple M4 has. --- Full diff: https://github.com/llvm/llvm-project/pull/123827.diff 2 Fil

[clang] [llvm] [llvm][AArch64] apple-m4 does not have FEAT_{SPEv1p2,SEL2,MPAM} (PR #123827)

2025-01-21 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/123827 This commit addresses some uncertainty raised in 84fa1755a5b7845ddaeaa513a3786013c76c9c88 as to which features Apple M4 has. >From 1a97bea824bd6a1595fba2fc394ba9469fc92f8b Mon Sep 17 00:00:00 2001 From: Jon Roe

[clang] Make armv6 iOS by default instead of macOS when targeting Darwin (PR #117243)

2025-01-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12118 Here is the r

[clang-tools-extra] [clang-tidy] Add QtEnabled option to modernize-use-integer-sign-comprison (PR #122127)

2025-01-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/122127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add QtEnabled option to modernize-use-integer-sign-comprison (PR #122127)

2025-01-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: lgtm. please update the pr title and description before merging. because the option name is changed. https://github.com/llvm/llvm-project/pull/122127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] Make armv6 iOS by default instead of macOS when targeting Darwin (PR #117243)

2025-01-21 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/117243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5651544 - Make armv6 iOS by default instead of macOS when targeting Darwin (#117243)

2025-01-21 Thread via cfe-commits
Author: Un1q32 Date: 2025-01-21T13:16:19-08:00 New Revision: 5651544c3647910ddb9f65414b8181f2560b999c URL: https://github.com/llvm/llvm-project/commit/5651544c3647910ddb9f65414b8181f2560b999c DIFF: https://github.com/llvm/llvm-project/commit/5651544c3647910ddb9f65414b8181f2560b999c.diff LOG: M

[clang] [NFC] Minor fix to tryEmitAbstract type in EmitCXXNewAllocSize (PR #123433)

2025-01-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/123433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minor fix to tryEmitAbstract type in EmitCXXNewAllocSize (PR #123433)

2025-01-21 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Shouldn't there be a pointer-vs-intty difference in the LLVM-IR here? > > No, because in this case tryEmitAbstract() is only using the size of the type > that's passed in. After a few visits, it eventually calls this function: > > ``` > llvm::Constant *ProduceIntToIntCa

[clang] [llvm] [IR] Don't set strictfp on irrelevant calls (PR #122735)

2025-01-21 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > > My understanding of the attribute is that it only indicates that strict > > floating-point semantics are (potentially?) required at the call site. > > If strict floating-point semantics are required at this call site, they are > are required on every relevant call in this

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-21 Thread Justin Fargnoli via cfe-commits
@@ -11610,9 +11610,10 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, bool TakingCandidateAddress) { TemplateParameter Param = DeductionFailure.getTemplateParameter(); NamedDecl *ParamD; - (ParamD = Param.dy

[clang] Reapply "[Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (#104458)" (PR #109422)

2025-01-21 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cac67d3 - [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (#121419)

2025-01-21 Thread via cfe-commits
Author: Oleksandr T. Date: 2025-01-21T22:49:24+02:00 New Revision: cac67d39362b23466708e464c00ce84abe16bece URL: https://github.com/llvm/llvm-project/commit/cac67d39362b23466708e464c00ce84abe16bece DIFF: https://github.com/llvm/llvm-project/commit/cac67d39362b23466708e464c00ce84abe16bece.diff

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-01-21 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman could you review these changes? thanks https://github.com/llvm/llvm-project/pull/120896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] No longer require complete types with __builtin_launder (PR #91070)

2025-01-21 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I would like to see some more compelling motivation for an extension here. https://github.com/llvm/llvm-project/pull/91070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [NFC] Minor fix to tryEmitAbstract type in EmitCXXNewAllocSize (PR #123433)

2025-01-21 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > Shouldn't there be a pointer-vs-intty difference in the LLVM-IR here? No, because in this case tryEmitAbstract() is only using the size of the type that's passed in. After a few visits, it eventually calls this function: ``` llvm::Constant *ProduceIntToIntCast(const Expr *

  1   2   3   4   5   >