[clang] [clang-format] Skip line splices when sorting C++ includes (PR #120680)

2024-12-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla-2stage` running on `linaro-g3-04` while building `clang` at step 11 "build stage 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/4282 Here is the relevant piece of

[clang] [Clang] fix for heterogeneous chip's host side's MaybeODRUseExprs clear (PR #121085)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (fuaq) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/121085.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaStmtAsm.cpp (+6) ``diff diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/

[clang] [Clang] fix for heterogeneous chip's host side's MaybeODRUseExprs clear (PR #121085)

2024-12-24 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] fix for heterogeneous chip's host side's MaybeODRUseExprs clear (PR #121085)

2024-12-24 Thread via cfe-commits
https://github.com/fuaq created https://github.com/llvm/llvm-project/pull/121085 None >From 0009c75d7ac422444f426fdb7db463865c3b78fe Mon Sep 17 00:00:00 2001 From: fuanqi Date: Tue, 24 Dec 2024 19:47:31 -0800 Subject: [PATCH] [Clang] fix for heterogeneous chip's host side's MaybeODRUseExprs cl

[clang] [clang-format] Skip line splices when sorting C++ includes (PR #120680)

2024-12-24 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/120680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 141c544 - [clang-format] Skip line splices when sorting C++ includes (#120680)

2024-12-24 Thread via cfe-commits
Author: Owen Pan Date: 2024-12-24T21:47:53-08:00 New Revision: 141c544c03702ac7c50522373ad781ede3685e0a URL: https://github.com/llvm/llvm-project/commit/141c544c03702ac7c50522373ad781ede3685e0a DIFF: https://github.com/llvm/llvm-project/commit/141c544c03702ac7c50522373ad781ede3685e0a.diff LOG:

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-24 Thread Owen Pan via cfe-commits
@@ -38,6 +40,10 @@ static bool mustBreakAfterAttributes(const FormatToken &Tok, namespace { +// TODO: Add new Type modifiers +llvm::SmallVector castIdentifiers{"__type_identity_t", + "remove_reference_t"}; owe

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-24 Thread Owen Pan via cfe-commits
@@ -2474,6 +2480,11 @@ class AnnotatingParser { Current.getNextNonComment()->isOneOf(tok::comma, tok::r_brace)) { Current.setType(TT_StringInConcatenation); } +} else if (Style.isCpp() && Current.is(tok::kw_using)) { + if (Current.Next && Curren

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -336,6 +338,9 @@ class LLVM_LIBRARY_VISIBILITY Generic_GCC : public ToolChain { const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const override; + void AddSYCLIncludeArgs(const llvm::opt::ArgList &DriverArgs, MaskRay wr

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
MaskRay wrote: > …(https://github.com/llvm/llvm-project/pull/107493) The subject line is now wrapped by github's pr system. Perhaps just use `[Driver][SYCL] Add initial SYCL offload compilation support` as the subject and mention that this is a reland of #107493. https://github.com/llvm/llv

[clang] [NFC][Driver] Use global --implicit-check-not=libclang_rt (PR #121081)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes Simplifies and improve precision of the test. --- Patch is 47.35 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/121081.diff 1 Files Affected: - (modified) c

[clang] [NFC][Driver] Use global --implicit-check-not=libclang_rt (PR #121081)

2024-12-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/121081 Simplifies and improve precision of the test. >From 75aa55a129dd1311a889a9bb4b0f4ee04206d157 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 24 Dec 2024 19:38:02 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -6591,11 +6679,23 @@ const ToolChain &Driver::getOffloadingDeviceToolChain( HostTC, Args); break; } +case Action::OFK_SYCL: + switch (Target.getArch()) { MaskRay wrote: Use `isSPI

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,56 @@ +/// +/// Perform several driver tests for SYCL offloading for JIT +/// + +/// Check the phases graph with -fsycl. Use of -fsycl enables offload +// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \ +// RUN: -fsycl %s 2>&1 \ +// RUN: | FileCheck

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -780,6 +781,41 @@ Driver::OpenMPRuntimeKind Driver::getOpenMPRuntime(const ArgList &Args) const { return RT; } +static const char *getDefaultSYCLArch(Compilation &C) { MaskRay wrote: Remove this trivial function and inline its use https://github.com/ll

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -993,6 +1028,41 @@ void Driver::CreateOffloadingDeviceToolChains(Compilation &C, return; } + // MaskRay wrote: We don't use start a comment block with `//\n`. Just delete the part before `We need to generate a SYCL toolchain if the user specified

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,56 @@ +/// +/// Perform several driver tests for SYCL offloading for JIT +/// + +/// Check the phases graph with -fsycl. Use of -fsycl enables offload +// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \ +// RUN: -fsycl %s 2>&1 \ +// RUN: | FileCheck

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,56 @@ +/// +/// Perform several driver tests for SYCL offloading for JIT +/// + +/// Check the phases graph with -fsycl. Use of -fsycl enables offload +// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \ +// RUN: -fsycl %s 2>&1 \ +// RUN: | FileCheck

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,56 @@ +/// +/// Perform several driver tests for SYCL offloading for JIT +/// + +/// Check the phases graph with -fsycl. Use of -fsycl enables offload +// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \ +// RUN: -fsycl %s 2>&1 \ Mask

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]link LLVMTargetParser (PR #121072)

2024-12-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-03` while building `clang-tools-extra` at step 1 "Checkout lnt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4438 Here is the relevant piec

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Fangrui Song via cfe-commits
@@ -780,6 +781,41 @@ Driver::OpenMPRuntimeKind Driver::getOpenMPRuntime(const ArgList &Args) const { return RT; } +static const char *getDefaultSYCLArch(Compilation &C) { + // If -fsycl is supplied we will assume SPIR-V + if (C.getDefaultToolChain().getTriple().isArch32Bi

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

2024-12-24 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. We need a test to clang/test/Driver/ohos.c similar to linux-ld.c clang_rt.crtbegin.o. You can add UNSUPPORTED: system-windows to ohos.c so that we don't need backslashes. https://github.com/llvm/llvm-project/pull/120159 __

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-24 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay commented: We need a test to clang/test/Driver/ohos.c similar to linux-ld.c `clang_rt.crtbegin.o`. You can add UNSUPPORTED: system-windows to ohos.c so that we don't need backslashes. https://github.com/llvm/llvm-project/pull/118192 ___

[clang-tools-extra] [clang-tidy]link LLVMTargetParser (PR #121072)

2024-12-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/121072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 34f7000 - [clang-tidy]link LLVMTargetParser (#121072)

2024-12-24 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-25T11:07:05+08:00 New Revision: 34f70007348d2d1a0e59fc0996e90a0b6fba1933 URL: https://github.com/llvm/llvm-project/commit/34f70007348d2d1a0e59fc0996e90a0b6fba1933 DIFF: https://github.com/llvm/llvm-project/commit/34f70007348d2d1a0e59fc0996e90a0b6fba1933.diff

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

2024-12-24 Thread Tristan Ross via cfe-commits
RossComputerGuy wrote: We have a problem where everything related to `i128` / `long double` fail to compile in LLVM libc without compiler-rt on aarch64 and possibly x86_64, this is a problem. Related ABI info: - [aarch64](https://github.com/ARM-software/abi-aa/releases/download/2024Q3/aapcs64.

[clang] [llvm] [AArch64][docs] Add release notes for FUJITSU-MONAKA support (PR #120684)

2024-12-24 Thread Yuta Mukai via cfe-commits
https://github.com/ytmukai closed https://github.com/llvm/llvm-project/pull/120684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 88d04be - [AArch64][docs] Add release notes for FUJITSU-MONAKA support (#120684)

2024-12-24 Thread via cfe-commits
Author: Kinoshita Kotaro Date: 2024-12-25T10:59:59+09:00 New Revision: 88d04be815bd289c691ab81061ac8a573ad15677 URL: https://github.com/llvm/llvm-project/commit/88d04be815bd289c691ab81061ac8a573ad15677 DIFF: https://github.com/llvm/llvm-project/commit/88d04be815bd289c691ab81061ac8a573ad15677.di

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2024-12-24 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann updated https://github.com/llvm/llvm-project/pull/120327 >From 6ed96d3bf22c5da5af995ea5ffe083baf91594bb Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Fri, 1 Nov 2024 16:03:24 -0700 Subject: [PATCH 1/8] [SYCL] Basic diagnostics for the sycl_kernel_entry_point

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2024-12-24 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann updated https://github.com/llvm/llvm-project/pull/120327 >From 6ed96d3bf22c5da5af995ea5ffe083baf91594bb Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Fri, 1 Nov 2024 16:03:24 -0700 Subject: [PATCH 1/7] [SYCL] Basic diagnostics for the sycl_kernel_entry_point

[clang] 970f65a - [Clang][MIPS] Create specific targets for MIPS PE/COFF (#121040)

2024-12-24 Thread via cfe-commits
Author: Hervé Poussineau Date: 2024-12-25T09:26:31+08:00 New Revision: 970f65a98a681831e308860e7004e066f5152791 URL: https://github.com/llvm/llvm-project/commit/970f65a98a681831e308860e7004e066f5152791 DIFF: https://github.com/llvm/llvm-project/commit/970f65a98a681831e308860e7004e066f5152791.di

[clang] [Clang][MIPS] Create specific targets for MIPS PE/COFF (PR #121040)

2024-12-24 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa closed https://github.com/llvm/llvm-project/pull/121040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Phoebe Wang via cfe-commits
@@ -181,8 +181,26 @@ void X86AsmPrinter::emitKCFITypeId(const MachineFunction &MF) { // Embed the type hash in the X86::MOV32ri instruction to avoid special // casing object file parsers. EmitKCFITypePadding(MF); + + Register MovReg = X86::EAX; + const auto &Triple = M

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Phoebe Wang via cfe-commits
phoebewang wrote: And you cannot use ESI when it's used to pass arguments. Suggested registers: | Arity Indicator | Description | Encoding in reg field | | --- | --- | --- | | 0 | 0 parameters | EDI | | 1 | 1 parameter in RDI | ESI | | 2 | 2 parameters in RDI a

[clang] [compiler-rt] [Ubsan][Driver] Remove UBSAN C++ runtime from other sanitizers (PR #121006)

2024-12-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-solaris11-sparcv9` running on `solaris11-sparcv9` while building `clang,compiler-rt` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/13/builds/4296 Here is the releva

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Phoebe Wang via cfe-commits
@@ -181,8 +181,26 @@ void X86AsmPrinter::emitKCFITypeId(const MachineFunction &MF) { // Embed the type hash in the X86::MOV32ri instruction to avoid special // casing object file parsers. EmitKCFITypePadding(MF); + + Register MovReg = X86::EAX; + const auto &Triple = M

[clang] [Clang][ASTMatcher] Add `dependentScopeDeclRefExpr` Matcher (PR #120996)

2024-12-24 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks, LGTM! I will wait a few days before merging in case anyone else has feedback. https://github.com/llvm/llvm-project/pull/120996 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-24 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-24 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/118569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-24 Thread via cfe-commits
https://github.com/ronlieb approved this pull request. https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-24 Thread via cfe-commits
@@ -11077,6 +11077,221 @@ TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { Style); } +TEST_F(FormatTest, BreakBeforeTemplateClose) { leijurv wrote: Sorry if I misunderstood, but, I thought I added that here: ![Screenshot_20241224-154618](ht

[clang-tools-extra] [clang-tidy] add depercation warning for non-whitelisted global options (PR #121057)

2024-12-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/121057 >From 98d65a0b9a1189ce73d97d76527b458f93f17b43 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 24 Dec 2024 23:32:02 +0800 Subject: [PATCH] [clang-tidy] add depercation warning for non-whitelisted glo

[clang-tools-extra] [clang-tidy]link LLVMTargetParser (PR #121072)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes Fix build issue introduced in #120547 --- Full diff: https://github.com/llvm/llvm-project/pull/121072.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/tool/CMakeLists.txt (

[clang-tools-extra] [clang-tidy]link LLVMTargetParser (PR #121072)

2024-12-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/121072 Fix build issue introduced in #120547 >From 747b60109d9b4f05aa695898591c68845809c7a0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 25 Dec 2024 07:31:48 +0800 Subject: [PATCH] [clang-tidy]link LLVM

[clang] [compiler-rt] [Ubsan][Driver] Remove UBSAN C++ runtime from other sanitizers (PR #121006)

2024-12-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang,compiler-rt` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/5155 Here i

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Scott Constable via cfe-commits
@@ -254,6 +254,7 @@ FEATURE(is_trivially_constructible, LangOpts.CPlusPlus) FEATURE(is_trivially_copyable, LangOpts.CPlusPlus) FEATURE(is_union, LangOpts.CPlusPlus) FEATURE(kcfi, LangOpts.Sanitize.has(SanitizerKind::KCFI)) +FEATURE(kcfi_x86_arity, LangOpts.Sanitize.has(Sanitize

[clang] [compiler-rt] [Ubsan][Driver] Remove UBSAN C++ runtime from other sanitizers (PR #121006)

2024-12-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/121006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cd66c9b - [Ubsan][Driver] Remove UBSAN C++ runtime from other sanitizers (#121006)

2024-12-24 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-12-24T13:57:03-08:00 New Revision: cd66c9b6a04689659348c0a3ff4c1205b1133fe9 URL: https://github.com/llvm/llvm-project/commit/cd66c9b6a04689659348c0a3ff4c1205b1133fe9 DIFF: https://github.com/llvm/llvm-project/commit/cd66c9b6a04689659348c0a3ff4c1205b1133fe9.diff L

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-12-24 Thread Scott Constable via cfe-commits
scottconstable wrote: > I haven't received a reply for my concerns I commented at [#117121 > (comment)](https://github.com/llvm/llvm-project/pull/117121#issuecomment-2502346476) > and [#117121 > (comment)](https://github.com/llvm/llvm-project/pull/117121#issuecomment-2516251353), > and they s

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-24 Thread Björn Schäpers via cfe-commits
@@ -2831,8 +2842,21 @@ class AnnotatingParser { IsQualifiedPointerOrReference(BeforeRParen, LangOpts); bool ParensCouldEndDecl = AfterRParen->isOneOf(tok::equal, tok::semi, tok::l_brace, tok::greater); -if (ParensAreType && !ParensCouldEndDecl) +if

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-24 Thread Björn Schäpers via cfe-commits
@@ -38,6 +40,10 @@ static bool mustBreakAfterAttributes(const FormatToken &Tok, namespace { +// TODO: Add new Type modifiers HazardyKnusperkeks wrote: ```suggestion // TODO: Add new Type modifiers. ``` https://github.com/llvm/llvm-project/pull/120904 __

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Scott Constable via cfe-commits
@@ -181,8 +181,26 @@ void X86AsmPrinter::emitKCFITypeId(const MachineFunction &MF) { // Embed the type hash in the X86::MOV32ri instruction to avoid special // casing object file parsers. EmitKCFITypePadding(MF); + + Register MovReg = X86::EAX; + const auto &Triple = M

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-12-24 Thread Scott Constable via cfe-commits
scottconstable wrote: @phoebewang @sirmc @samitolvanen @Darksonn @lvwr @ojeda @maurer @rcvalle @MaskRay I have created https://github.com/llvm/llvm-project/pull/121070 to implement the alternate proposal summarized in this comment above: https://github.com/llvm/llvm-project/pull/117121#issuec

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-24 Thread Björn Schäpers via cfe-commits
@@ -11077,6 +11077,221 @@ TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { Style); } +TEST_F(FormatTest, BreakBeforeTemplateClose) { HazardyKnusperkeks wrote: This one is still missing. https://github.com/llvm/llvm-project/pull/118046 _

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Scott Constable via cfe-commits
https://github.com/scottconstable updated https://github.com/llvm/llvm-project/pull/121070 >From 70f1743e23ff8e218799e94b03a5bf033715666a Mon Sep 17 00:00:00 2001 From: Scott D Constable Date: Mon, 23 Dec 2024 13:48:48 -0800 Subject: [PATCH] Implement a new kcfi_x86_arity feature that encodes a

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Scott Constable (scottconstable) Changes Kernel Control Flow Integrity (kCFI) is a feature that hardens indirect calls by comparing a 32-bit hash of the function pointer's type against a hash of the target function's type. If the ha

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2024-12-24 Thread Scott Constable via cfe-commits
https://github.com/scottconstable created https://github.com/llvm/llvm-project/pull/121070 Kernel Control Flow Integrity (kCFI) is a feature that hardens indirect calls by comparing a 32-bit hash of the function pointer's type against a hash of the target function's type. If the hashes do not

[clang] [CIR] Upstream initial attribute support (PR #121069)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: David Olsen (dkolsen-pgi) Changes Upstream several ClangIR-specific MLIR attributes, in particular attributes for integer, floating-point, and null pointer constants. These are the first ClangIR attributes to be upstreamed, so infrastru

[clang] [CIR] Upstream initial attribute support (PR #121069)

2024-12-24 Thread David Olsen via cfe-commits
https://github.com/dkolsen-pgi created https://github.com/llvm/llvm-project/pull/121069 Upstream several ClangIR-specific MLIR attributes, in particular attributes for integer, floating-point, and null pointer constants. These are the first ClangIR attributes to be upstreamed, so infrastructur

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-24 Thread via cfe-commits
dyung wrote: `` > Hmm, this looks like I just didn't fix "enough". > > I've sent out #121043 and rebased this PR on top of that as well. Can you > take another spin? > > This PR should be the right branch, incorporating all the other changes. I've built and tested this PR (I think) and it doe

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Zahira Ammarguellat via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> { let association = AS_Loop; let category = CA_Executable; } +def OMP_Stripe : Directive<"stripe"> { + let allowedOnceClauses = [ +VersionedClause, alexey-bataev wrote: Sounds good https://githu

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Zahira Ammarguellat via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Zahira Ammarguellat via cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> { let association = AS_Loop; let category = CA_Executable; } +def OMP_Stripe : Directive<"stripe"> { + let allowedOnceClauses = [ +VersionedClause, zahiraam wrote: I see. In this case I think it

[clang] [clang-format] extend clang-format directive with options to prevent formatting for one line (PR #118566)

2024-12-24 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: > If we were to add // clang-format off-next-line, would "next line" mean the > next physical or logical/unwrapped line? I would expect it to apply only to the physical line, similar to how other formatters work. However, the main concern doesn’t seem to be about its behavio

[clang] Reapply "[Clang] Improve diagnostics for expansion length mismatch" (PR #121044)

2024-12-24 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Thanks! I think I completely missed the fact these were both reverted. https://github.com/llvm/llvm-project/pull/121044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> { let association = AS_Loop; let category = CA_Executable; } +def OMP_Stripe : Directive<"stripe"> { + let allowedOnceClauses = [ +VersionedClause, alexey-bataev wrote: Yes, should be 60 https:/

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -5965,6 +5967,269 @@ static bool teamsLoopCanBeParallelFor(Stmt *AStmt, Sema &SemaRef) { return Checker.teamsLoopCanBeParallelFor(); } +static Expr *getInitialExprFromCapturedExpr(Expr *Cond) { + + Expr *SubExpr = Cond->IgnoreParenImpCasts(); + + if (auto *DeclRef = dy

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciac (Load-Store Adress calculation) extension (PR #121037)

2024-12-24 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/121037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciac (Load-Store Adress calculation) extension (PR #121037)

2024-12-24 Thread Craig Topper via cfe-commits
@@ -184,6 +191,37 @@ let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in { } // hasSideEffects = 0, mayLoad = 0, mayStore = 0 } // Predicates = [HasVendorXqcia, IsRV32], DecoderNamespace = "Xqcia" +let Predicates = [HasVendorXqciac, IsRV32], DecoderNamespace = "Xqciac" in { +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { alexey-bataev wrote: Add a comment describing the supported construct https://gith

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Aldo, update OpenMPSupport page https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Codegen support for masked combined construct (PR #120520)

2024-12-24 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Split into several separate patches, one for each directive https://github.com/llvm/llvm-project/pull/120520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Ubsan][Driver] Remove UBSAN C++ runtime from other sanitizers (PR #121006)

2024-12-24 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/121006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-24 Thread Michael Toguchi via cfe-commits
mdtoguchi wrote: Ping https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Implement FP8 SVE/SME reinterpret intrinsics (PR #121063)

2024-12-24 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/121063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Implement FP8 SVE/SME reinterpret intrinsics (PR #121063)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes --- Patch is 199.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/121063.diff 2 Files Affected: - (added) clang/test/CodeGen/AArch64/fp8-intrinsic

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-24 Thread Alexey Gerenkov via cfe-commits
https://github.com/gerekon updated https://github.com/llvm/llvm-project/pull/118008 >From 55b08ec540d18d50011ef9fb0e301e1f7650ca9e Mon Sep 17 00:00:00 2001 From: Andrei Safronov Date: Thu, 1 Jun 2023 00:42:37 +0300 Subject: [PATCH] [Clang][Xtensa] Add Xtensa target. --- clang/include/clang/Ba

[clang] [analyzer] Simplify CallEvent castArgToParamTypeIfNeeded (PR #120981)

2024-12-24 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/120981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8dbb337 - [analyzer] Simplify CallEvent castArgToParamTypeIfNeeded (#120981)

2024-12-24 Thread via cfe-commits
Author: Balazs Benics Date: 2024-12-24T17:05:38+01:00 New Revision: 8dbb33762cfb8d8606d28a71293f437ddffee4af URL: https://github.com/llvm/llvm-project/commit/8dbb33762cfb8d8606d28a71293f437ddffee4af DIFF: https://github.com/llvm/llvm-project/commit/8dbb33762cfb8d8606d28a71293f437ddffee4af.diff

[clang-tools-extra] [clang-tidy] add depercation warning for non-whitelisted global options (PR #121057)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes We plan to depercate `StrictMode` and `IgnoreMacros` global options after 2 major versions and support local options only for them. This patch introduces the depercation warning. --- Full di

[clang-tools-extra] [clang-tidy] add depercation warning for non-whitelisted global options (PR #121057)

2024-12-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/121057 We plan to depercate `StrictMode` and `IgnoreMacros` global options after 2 major versions and support local options only for them. This patch introduces the depercation warning. >From 5d1269d61450ee641838

[clang-tools-extra] [clang-tidy] support parameters file in command line (PR #120547)

2024-12-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `clang-tools-extra` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/5609

[clang-tools-extra] [clang-tidy] swap cppcoreguidelines-narrowing-conversions and bugprone-narrowing-conversions (PR #120245)

2024-12-24 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: ping https://github.com/llvm/llvm-project/pull/120245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] support parameters file in command line (PR #120547)

2024-12-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/120547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added nullptr check to getFriendDecl access (PR #121056)

2024-12-24 Thread via cfe-commits
https://github.com/GrumpyPigSkin updated https://github.com/llvm/llvm-project/pull/121056 >From a6c7f0dfd1da4b17118f25023cf2f5da70ee3dab Mon Sep 17 00:00:00 2001 From: GrumpyPigSkin Date: Tue, 24 Dec 2024 15:18:29 + Subject: [PATCH 1/2] Added nullptr check to getFriendDecl access --- clan

[clang-tools-extra] 2ff614a - [clang-tidy] support parameters file in command line (#120547)

2024-12-24 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-24T23:24:14+08:00 New Revision: 2ff614aaa6eb94bc5d02c8f0fb70a1132acb4423 URL: https://github.com/llvm/llvm-project/commit/2ff614aaa6eb94bc5d02c8f0fb70a1132acb4423 DIFF: https://github.com/llvm/llvm-project/commit/2ff614aaa6eb94bc5d02c8f0fb70a1132acb4423.diff

[clang] [Clang] Added nullptr check to getFriendDecl access (PR #121056)

2024-12-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (GrumpyPigSkin) Changes fixes: #120857 where a `nullptr` access was causing a crash. @shafik please can you review. --- Full diff: https://github.com/llvm/llvm-project/pull/121056.diff 1 Files Affected: - (modified) clang/lib/Sem

[clang] [Clang] Added nullptr check to getFriendDecl access (PR #121056)

2024-12-24 Thread via cfe-commits
https://github.com/GrumpyPigSkin created https://github.com/llvm/llvm-project/pull/121056 fixes: #120857 where a `nullptr` access was causing a crash. @shafik please can you review. >From a6c7f0dfd1da4b17118f25023cf2f5da70ee3dab Mon Sep 17 00:00:00 2001 From: GrumpyPigSkin Date: Tue, 24 Dec

[clang] [llvm] [AArch64] Add Neon FP8 conversion intrinsics (PR #119033)

2024-12-24 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/119033 >From db963803f1a84b7deae31330e9c2f74df85a01cd Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Fri, 6 Dec 2024 13:09:23 + Subject: [PATCH 1/7] [AArch64] Refactor implementation of FP8 types (NFC

  1   2   >