Author: Nathan Ridge
Date: 2024-12-09T02:23:11-05:00
New Revision: 26760c7b907c1012c44d15959319bfa06848e5cd
URL:
https://github.com/llvm/llvm-project/commit/26760c7b907c1012c44d15959319bfa06848e5cd
DIFF:
https://github.com/llvm/llvm-project/commit/26760c7b907c1012c44d15959319bfa06848e5cd.diff
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/118906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/118906
>From 45311dbceed8d438f2ac0db5019719a7fa32c0bf Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 5 Dec 2024 19:45:25 -0500
Subject: [PATCH] [clangd] Add clarifying comment about when Dex::IdxContents
@@ -121,6 +121,8 @@ class Dex : public SymbolIndex {
llvm::DenseMap, std::vector>
Relations;
std::shared_ptr KeepAlive; // poor man's move-only std::any
// Set of files which were used during this index build.
+ // Files and IdxContents are only populated for dynamic an
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/118906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dyung wrote:
I’m still looking into the failure, but may be a bit slow as the machine isn’t
really setup for debugging, and I’m traveling today.
https://github.com/llvm/llvm-project/pull/118734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From c66fee7969fc4bd8b5ce79085f0fc09cbc4147da Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/13] Support MSVC lvalue to temporary reference binding
---
clang/
@@ -11077,6 +11077,157 @@ TEST_F(FormatTest,
WrapsTemplateDeclarationsWithComments) {
Style);
}
+TEST_F(FormatTest, BreakBeforeTemplateClose) {
leijurv wrote:
Good suggestion! I have added tests in this commit:
https://github.com/llvm/llvm-project/pul
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/119105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
(This was meant as a follow-up to
https://github.com/llvm/llvm-project/pull/118236 to add the assertion discussed
in [this
comment](https://github.com/llvm/llvm-project/pull/118236#discussion_r1865179512),
but I'm not proceeding with it because the assertion is tripped i
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH 1/3] [clang-format] Add BreakBeforeTemplateClose option
---
clang/doc
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH 1/3] [clang-format] Add BreakBeforeTemplateClose option
---
clang/doc
chandlerc wrote:
> Could the version of VC that we are using possibly have the issue with long
> strings that you mention? Is there a simple way to check that?
It's a compile time error, so no, that'd be really clear cut.
The only other thing I've seen is running out of heap, but that seems li
dyung wrote:
> > > > > > LLVM Buildbot has detected a new failure on builder
> > > > > > `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while
> > > > > > building `clang` at step 7 "test-build-unified-tree-check-all".
> > > > > > Full details are available at:
> > > > > > [lab.llvm.or
chandlerc wrote:
> > > > > LLVM Buildbot has detected a new failure on builder
> > > > > `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while
> > > > > building `clang` at step 7 "test-build-unified-tree-check-all".
> > > > > Full details are available at:
> > > > > [lab.llvm.org/buil
dyung wrote:
> > > > LLVM Buildbot has detected a new failure on builder
> > > > `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building
> > > > `clang` at step 7 "test-build-unified-tree-check-all".
> > > > Full details are available at:
> > > > [lab.llvm.org/buildbot#/builders
chandlerc wrote:
> > > LLVM Buildbot has detected a new failure on builder
> > > `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building
> > > `clang` at step 7 "test-build-unified-tree-check-all".
> > > Full details are available at:
> > > [lab.llvm.org/buildbot#/builders/46/bu
dyung wrote:
> > LLVM Buildbot has detected a new failure on builder
> > `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building
> > `clang` at step 7 "test-build-unified-tree-check-all".
> > Full details are available at:
> > [lab.llvm.org/buildbot#/builders/46/builds/9169](htt
asb wrote:
I think this change in behaviour deserves an entry in
clang/docs/ReleaseNotes.rst
https://github.com/llvm/llvm-project/pull/117140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/119071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc wrote:
> LLVM Buildbot has detected a new failure on builder
> `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building
> `clang` at step 7 "test-build-unified-tree-check-all".
>
> Full details are available at:
> [lab.llvm.org/buildbot#/builders/46/builds/9169](https:
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Nathan Ridge (HighCommander4)
Changes
Fixes https://github.com/clangd/clangd/issues/2248
---
Full diff: https://github.com/llvm/llvm-project/pull/119162.diff
2 Files Affected:
- (modified) clang-tools-extra/clangd/InlayHints
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Nathan Ridge (HighCommander4)
Changes
Fixes https://github.com/clangd/clangd/issues/2248
---
Full diff: https://github.com/llvm/llvm-project/pull/119162.diff
2 Files Affected:
- (modified) clang-tools-extra/clangd/InlayHints.cpp (+16-1
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/119162
Fixes https://github.com/clangd/clangd/issues/2248
>From c207c5d0d651b564acec0a0b6ef257fb89752ba0 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Mon, 21 Oct 2024 02:34:15 -0400
Subject: [PATCH] [clang
@@ -1410,7 +1410,7 @@ void tools::linkSanitizerRuntimeDeps(const ToolChain &TC,
// libresolv.a, even if exists, is an empty archive to satisfy POSIX -lresolv
// requirement.
if (TC.getTriple().isOSLinux() && !TC.getTriple().isAndroid() &&
- !TC.getTriple().isMusl())
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win`
running on `sie-win-worker` while building `clang` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/46/builds/9169
Here is the
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
iseki0 wr
https://github.com/chandlerc closed
https://github.com/llvm/llvm-project/pull/118734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chandler Carruth
Date: 2024-12-08T19:00:14-08:00
New Revision: be2df95e9281985b61270bb6420ea0eeeffbbe59
URL:
https://github.com/llvm/llvm-project/commit/be2df95e9281985b61270bb6420ea0eeeffbbe59
DIFF:
https://github.com/llvm/llvm-project/commit/be2df95e9281985b61270bb6420ea0eeeffbbe59.di
androm3da wrote:
cc @llvm/pr-subscribers-backend-hexagon and @iajbar
https://github.com/llvm/llvm-project/pull/118734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh approved this pull request.
Thanks for the fix! LGTM
https://github.com/llvm/llvm-project/pull/119077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Younan Zhang
Date: 2024-12-09T09:58:37+08:00
New Revision: a4506bb340c36d48d89afe5bd76a1a2f28f76fd9
URL:
https://github.com/llvm/llvm-project/commit/a4506bb340c36d48d89afe5bd76a1a2f28f76fd9
DIFF:
https://github.com/llvm/llvm-project/commit/a4506bb340c36d48d89afe5bd76a1a2f28f76fd9.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/119123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/119123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
@ckandeler Could you elaborate on the motivation for this change?
In my mind, the value proposition of the "extract variable" refactoring is that
it saves you the work of moving the expression from one location to another,
and typing the name of the variable twice (once a
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/119082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: c8ef
Date: 2024-12-09T09:28:12+08:00
New Revision: f145ff3f70d0c1a71d08613f692376003ab398b9
URL:
https://github.com/llvm/llvm-project/commit/f145ff3f70d0c1a71d08613f692376003ab398b9
DIFF:
https://github.com/llvm/llvm-project/commit/f145ff3f70d0c1a71d08613f692376003ab398b9.diff
LOG: [cl
github-actions[bot] wrote:
@kinoshita-fj Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a b
Author: Kinoshita Kotaro
Date: 2024-12-09T09:56:02+09:00
New Revision: a1197a2ca8a77c08a36445401a063a1c4efec6a9
URL:
https://github.com/llvm/llvm-project/commit/a1197a2ca8a77c08a36445401a063a1c4efec6a9
DIFF:
https://github.com/llvm/llvm-project/commit/a1197a2ca8a77c08a36445401a063a1c4efec6a9.di
https://github.com/ytmukai closed
https://github.com/llvm/llvm-project/pull/118432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ytmukai wrote:
Thank you for your reviews and help! Delayed due to holidays, but I will submit
it.
https://github.com/llvm/llvm-project/pull/118432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/chomosuke updated
https://github.com/llvm/llvm-project/pull/118569
>From efc17a803c9c22543de7d5f9e960a7267ade1f2e Mon Sep 17 00:00:00 2001
From: chomosuke
Date: Wed, 4 Dec 2024 14:42:24 +
Subject: [PATCH 1/2] [clangd][clang-tidy] Make clangd run
`format::cleanupAroundRep
https://github.com/chandlerc updated
https://github.com/llvm/llvm-project/pull/118734
>From 9553557e87ec5d9ae5ce5636f6227150fcd080bc Mon Sep 17 00:00:00 2001
From: Chandler Carruth
Date: Thu, 28 Nov 2024 09:56:40 +
Subject: [PATCH 1/6] Switch builtin strings to use string tables
MIME-Versio
chandlerc wrote:
> Confirmed that this works on GCC now. I'd suggest to replace the use of
> StringLiteral::size with plain sizeof(). The build time overhead of going
> through StringLiteral here is substantial.
Sure. I was initially worried about the subtlety of this use of `sizeof`, but
tha
@@ -4692,6 +4692,17 @@ bool Sema::InstantiateDefaultArgument(SourceLocation
CallLoc, FunctionDecl *FD,
ParmVarDecl *Param) {
assert(Param->hasUninstantiatedDefaultArg());
+ // FIXME: We don't track member specialization info for non-de
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oleksandr T. (a-tarasyuk)
Changes
Fixes #74924
---
Full diff: https://github.com/llvm/llvm-project/pull/119153.diff
3 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+2)
- (modified) clang/lib/AST/ExprConstant.cpp (+3-1)
- (
https://github.com/a-tarasyuk created
https://github.com/llvm/llvm-project/pull/119153
Fixes #74924
>From f19ea82bbe5c00af6a6e261f989c9a89ef4c78ca Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Mon, 9 Dec 2024 01:46:46 +0200
Subject: [PATCH] [Clang] allow [[msvc::constexpr]] usage outside th
phuang wrote:
Thanks for reviewing it.
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
> The IR is a representation of what goes on a final .o. It is not really
> intended to enable new features or make the program portable.
My .02 is, it depends on how to think about it. If we eliminate the "unwanted"
part (especially those that could potentially affect ABI) at
zygoloid wrote:
Did you mean a different issue than #119101? It's not clear to me what
connection this PR has to that issue.
It's not clear to me that there's an issue to be solved here. Under
`-pedantic-errors`, clang [already produces an
error](https://godbolt.org/z/h6oKarex9) on examples l
arsenm wrote:
> Does wave32/wave64 affect the lowering from front end source code to middle
> end IR, if we don't use certain functions, such as wave level primitives?
Yes. This is a fixed ABI setting that can change the binary function signature
(which then has knock on optimization effects).
https://github.com/SpencerAbson updated
https://github.com/llvm/llvm-project/pull/118549
>From 298e1372cb8e6b2f7707f42448521d3014bc Mon Sep 17 00:00:00 2001
From: Spencer Abson
Date: Mon, 25 Nov 2024 21:47:20 +
Subject: [PATCH 1/3] [AArch64] Implement intrinsics for SME FP8 FMOPA
---
kpdev wrote:
LGTM
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rounaq Khan (rkmaxhero)
Changes
CLANG parser previously allowed for invalid C/C++ auto classes declaration due
to a lack of logic addressing this case. Logic comparing with a valid case was
added to the ParseDeclarationOrFunctionDefinitio
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/rkmaxhero created
https://github.com/llvm/llvm-project/pull/119143
CLANG parser previously allowed for invalid C/C++ auto classes declaration due
to a lack of logic addressing this case. Logic comparing with a valid case was
added to the ParseDeclarationOrFunctionDefinition(
https://github.com/SpencerAbson updated
https://github.com/llvm/llvm-project/pull/118115
>From e1181dd6dab09b20be8077d1f4e70ef4da7ab437 Mon Sep 17 00:00:00 2001
From: Spencer Abson
Date: Mon, 25 Nov 2024 21:47:20 +
Subject: [PATCH 1/2] [AArch64] Implement intrinsics for SME FP8 FMOPA
---
https://github.com/SpencerAbson closed
https://github.com/llvm/llvm-project/pull/118027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: SpencerAbson
Date: 2024-12-08T19:34:01Z
New Revision: b0f06769e6e2ea2bc4ce3554ebf66384a1236106
URL:
https://github.com/llvm/llvm-project/commit/b0f06769e6e2ea2bc4ce3554ebf66384a1236106
DIFF:
https://github.com/llvm/llvm-project/commit/b0f06769e6e2ea2bc4ce3554ebf66384a1236106.diff
LOG:
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/118734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pedro Lobo (pedroclobo)
Changes
- Use `poison `instead of `undef` as a phi operand from an unreachable block.
- Call `@llvm.vector.insert` with a `poison` subvec when performing a
`bitcast` from a fixed vector to a scalable vector.
---
P
https://github.com/pedroclobo created
https://github.com/llvm/llvm-project/pull/119141
- Use `poison `instead of `undef` as a phi operand from an unreachable block.
- Call `@llvm.vector.insert` with a `poison` subvec when performing a `bitcast`
from a fixed vector to a scalable vector.
>From c
@@ -68,23 +69,156 @@ enum ID {
FirstTSBuiltin
};
+// The info used to represent each builtin.
struct Info {
- llvm::StringLiteral Name;
- const char *Type, *Attributes;
- const char *Features;
+ // Rather than store pointers to the string literals describing these four
https://github.com/nikic approved this pull request.
Confirmed that this works on GCC now. I'd suggest to replace the use of
StringLiteral::size with plain sizeof(). The build time overhead of going
through StringLiteral here is substantial.
https://github.com/llvm/llvm-project/pull/118734
___
@@ -68,23 +69,156 @@ enum ID {
FirstTSBuiltin
};
+// The info used to represent each builtin.
struct Info {
- llvm::StringLiteral Name;
- const char *Type, *Attributes;
- const char *Features;
+ // Rather than store pointers to the string literals describing these four
Author: Timm Baeder
Date: 2024-12-08T18:54:08+01:00
New Revision: 1fbbf4c418bc4945839a70fe2849cbe6fbcc3d66
URL:
https://github.com/llvm/llvm-project/commit/1fbbf4c418bc4945839a70fe2849cbe6fbcc3d66
DIFF:
https://github.com/llvm/llvm-project/commit/1fbbf4c418bc4945839a70fe2849cbe6fbcc3d66.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/119119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
compnerd
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/119090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chris Apple
Date: 2024-12-08T09:34:40-08:00
New Revision: 8843d2b4695419caa774b40582146446f350a504
URL:
https://github.com/llvm/llvm-project/commit/8843d2b4695419caa774b40582146446f350a504
DIFF:
https://github.com/llvm/llvm-project/commit/8843d2b4695419caa774b40582146446f350a504.diff
L
https://github.com/cjappl closed
https://github.com/llvm/llvm-project/pull/119074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
I am happy if @RKSimon is
https://github.com/llvm/llvm-project/pull/119082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RKSimon approved this pull request.
LGTM cheers
https://github.com/llvm/llvm-project/pull/119082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
> Two, we can add a "readnone_fp_intrinsic" attribute, which would mean the
> intrinsic is readnone unless there's an operand bundle indicating otherwise.
I think this needs to be more refined to FP mode read/write and errno
read/write. Basically a mirror of memory() for argument
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/119024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -92,6 +98,65 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T,
const Triple &TT,
setRequiresStructuredCFG(false);
}
+enum AddressSpace {
+ Function = storageClassToAddressSpace(SPIRV::StorageClass::Function),
+ CrossWorkgroup =
+ storageClassToAddressSpac
@@ -92,6 +98,65 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T,
const Triple &TT,
setRequiresStructuredCFG(false);
}
+enum AddressSpace {
+ Function = storageClassToAddressSpace(SPIRV::StorageClass::Function),
+ CrossWorkgroup =
+ storageClassToAddressSpac
@@ -178,6 +266,9 @@ void SPIRVPassConfig::addIRPasses() {
addPass(createSPIRVStructurizerPass());
}
+ if (TM.getOptLevel() > CodeGenOptLevel::None)
+addPass(createInferAddressSpacesPass(AddressSpace::Generic));
arsenm wrote:
I remember we had some
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/119082
>From 2af0eb663a106b712a3c9eb2028dc35014884708 Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sun, 8 Dec 2024 01:11:51 +0800
Subject: [PATCH 1/4] constexpr elementwise add_sat
---
clang/docs/LanguageExtensions.rst
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
shiltian wrote:
> This probably should retain separate wave32/wave64 builds. Additionally,
> should have extension points for subtarget specific implementations
Does wave32/wave64 affect the lowering from front end source code to middle end
IR, if we don't use certain functions, such as wave l
arsenm wrote:
> > This probably should retain separate wave32/wave64 builds. Additionally,
> > should have extension points for subtarget specific implementations
>
> That's what Shilei was talking about since we have `__nvvm_reflect` for that
> for NVPTX.
First I will always consider NVVM re
jhuber6 wrote:
> First I will always consider NVVM reflect a giant hack. NVVM reflect cannot
> actually deal with the full range of wavesize issues. It is an incompatible
> ABI and the code should never be intermixed
It's a hack, but still better than whatever it is AMD does currently.
https:
jhuber6 wrote:
> This probably should retain separate wave32/wave64 builds. Additionally,
> should have extension points for subtarget specific implementations
That's what Shilei was talking about since we have `__nvvm_reflect` for that
for NVPTX.
https://github.com/llvm/llvm-project/pull/119
arsenm wrote:
This probably should retain separate wave32/wave64 builds. Additionally, should
have extension points for subtarget specific implementations
https://github.com/llvm/llvm-project/pull/119091
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/RKSimon edited
https://github.com/llvm/llvm-project/pull/119082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
@MaskRay Please let me know if latest changes fix your previous comments and if
this could be merged.
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -822,3 +822,19 @@ static_assert(__builtin_elementwise_bitreverse(0x12345678)
== 0x1E6A2C48);
static_assert(__builtin_elementwise_bitreverse(0x0123456789ABCDEFULL) ==
0xF7B3D591E6A2C480);
static_assert(__builtin_bit_cast(unsigned,
__builtin_elementwise_bitreverse((vector4ch
https://github.com/RKSimon edited
https://github.com/llvm/llvm-project/pull/119082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
@@ -11339,6 +11339,31 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr
*E) {
return Success(APValue(ResultElements.data(), ResultElements.size()), E);
}
+ case Builtin::BI__builtin_elementwise_add_sat: {
+APValue SourceLHS, SourceRHS;
+if (!EvaluateAsR
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name
target_triple)
endif()
endfunction()
-# Generate a Bitcode library for all the gpu architectures the user requested.
-add_custom_target(omptarget.devicertl.nvptx)
add_custom_target(omptarget.devi
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/119082
>From 2af0eb663a106b712a3c9eb2028dc35014884708 Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sun, 8 Dec 2024 01:11:51 +0800
Subject: [PATCH 1/3] constexpr elementwise add_sat
---
clang/docs/LanguageExtensions.rst
@@ -11339,6 +11339,31 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr
*E) {
return Success(APValue(ResultElements.data(), ResultElements.size()), E);
}
+ case Builtin::BI__builtin_elementwise_add_sat: {
+APValue SourceLHS, SourceRHS;
+if (!EvaluateAsR
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/119123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin commented:
the commit message could use more details, otherwise LGTM.
Thanks for fixing that
https://github.com/llvm/llvm-project/pull/119123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
1 - 100 of 118 matches
Mail list logo
