xtexChooser wrote:
cc @jansvoboda11
https://github.com/llvm/llvm-project/pull/117458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thesamesam wrote:
I took a look and I think it may be too awkward to do, as we'd want to run e.g.
readelf afterwards. But an example is
`lld/test/ELF/as-needed-not-in-regular.s`. The idea being: if `-Wl,--as-needed`
is in the config file, do we correctly prune an unnecessary library from a
bu
owenca wrote:
You need to also update the command-line input file extensions, docs, and
git-clang-format.
https://github.com/llvm/llvm-project/pull/118188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
owenca wrote:
> What's the point of adding it to the `FormatTests` target though? Just to
> ensure proper test coverage of the `dump_format_style.py` file?
That and to also ensure that the edited Format.h doesn't break the python
script.
> Thinking about this a bit more, I think we can probab
https://github.com/phuang updated
https://github.com/llvm/llvm-project/pull/118192
>From 206f8f800df7e51648ec00b110f2437dca5a3ff6 Mon Sep 17 00:00:00 2001
From: Peng Huang
Date: Tue, 15 Oct 2024 13:39:03 -0400
Subject: [PATCH] Fix build error for OHOS
For ohos targets, libclang_rt.builtins.a,
xtexChooser wrote:
Ping
https://github.com/llvm/llvm-project/pull/117458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/phuang edited
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Peng Huang (phuang)
Changes
For ohos targets, libclang_rt.builtins.a, clang_rt.crtbegin.o and
clang_rt.crtend.o are installed in
clang/20/lib/${arch}-unknown-linux-ohos. However OHOS toolchain search them in
clang/20/lib/${arch}-li
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Peng Huang (phuang)
Changes
For ohos targets, libclang_rt.builtins.a, clang_rt.crtbegin.o and
clang_rt.crtend.o are installed in
clang/20/lib/${arch}-unknown-linux-ohos. However OHOS toolchain search them in
clang/20/lib/${arch}-linux-oho
https://github.com/phuang created
https://github.com/llvm/llvm-project/pull/118192
For ohos targets, libclang_rt.builtins.a, clang_rt.crtbegin.o and
clang_rt.crtend.o are installed in
clang/20/lib/${arch}-unknown-linux-ohos. However OHOS toolchain search them in
clang/20/lib/${arch}-linux-ohos
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/117428
>From 3e25d7ef2e223942298078dace8979905956d05c Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Fri, 22 Nov 2024 17:53:24 +0100
Subject: [PATCH 1/2] Add an off-by-default warning to complain about MSVC
bitfield
https://github.com/d3x0r edited https://github.com/llvm/llvm-project/pull/118188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Jim B (d3x0r)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/118188.diff
1 Files Affected:
- (modified) clang/lib/Format/Format.cpp (+1)
``diff
diff --git a/clang/lib/Format/Format.cpp b/clang/lib/Fo
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/d3x0r created
https://github.com/llvm/llvm-project/pull/118188
None
>From 8ce527dc2cc7ac285f782648838664491abffc30 Mon Sep 17 00:00:00 2001
From: d3x0r
Date: Sat, 30 Nov 2024 02:32:40 -0800
Subject: [PATCH] Add *.cjs handling for JavaScript Language.
---
clang/lib/Format/F
pawosm-arm wrote:
> This seems OK to me, although I'd feel more comfortable if we had a test
> which relied on `--Wl,--as-needed` too.
Could you provide or describe some example?
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits maili
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/118113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thesamesam edited
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thesamesam commented:
This seems OK to me, although I'd feel more comfortable if we had a test which
relied on `--Wl,--as-needed`.
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: William Tran-Viet (smallp-o-p)
Changes
Fixes #116932
---
Full diff: https://github.com/llvm/llvm-project/pull/118186.diff
2 Files Affected:
- (modified) clang/lib/Sema/SemaExprMember.cpp (+3-1)
- (modified) clang/test/SemaCXX/vector-b
https://github.com/smallp-o-p created
https://github.com/llvm/llvm-project/pull/118186
Fixes #116932
>From 3b7cf6e65bdfedf8d15e393c9c2f819c4ed70386 Mon Sep 17 00:00:00 2001
From: William Tran-Viet
Date: Sat, 30 Nov 2024 15:53:32 -0500
Subject: [PATCH] Fix double-quotes in diagnostic when atte
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH] [clang-format] Add BreakBeforeTemplateClose option
---
clang/docs/Cl
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From b254c9311fb91374a21ba6ac5d44e087e4a55e98 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH] [clang-format] Add BreakBeforeTemplateClose option
---
clang/docs/Cl
5chmidti wrote:
> > Please add the matcher to
> > https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp
> > as well (clang-query).
>
> i will do it separately to avoid this pr become bigger.
I think you only have to add it into that file for it to work, and
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/117428
>From 3e25d7ef2e223942298078dace8979905956d05c Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Fri, 22 Nov 2024 17:53:24 +0100
Subject: [PATCH] Add an off-by-default warning to complain about MSVC bitfield
padd
@@ -61,3 +61,29 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The linker input flags should be moved to the end of input list and
appear only when linking.
+!
https://github.com/pawosm-arm updated
https://github.com/llvm/llvm-project/pull/117573
>From 65917ba219e26bd8547e8d1d9ff2c4ced1cdcad1 Mon Sep 17 00:00:00 2001
From: Pawel Osmialowski
Date: Mon, 25 Nov 2024 14:46:55 +
Subject: [PATCH] [clang][driver] Special care for -l and -Wl, flags in con
https://github.com/ojhunt ready_for_review
https://github.com/llvm/llvm-project/pull/113510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1073,6 +1086,19 @@ bool Driver::readConfigFile(StringRef FileName,
appendOneArg(*CfgOptions, Opt, BaseArg);
}
}
+
+ if (!CfgLinkerInputs)
+CfgLinkerInputs = std::move(NewLinkerIns);
+ else {
+// If this is a subsequent config file, append options to th
@@ -82,3 +82,29 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
@@ -1062,6 +1062,19 @@ bool Driver::readConfigFile(StringRef FileName,
for (Arg *A : *NewOptions)
A->claim();
+ // Filter out all -l and -Wl, options, put them into a separate list and
erase
+ // from the original list of configuration file options. These will be used
@@ -1206,6 +1245,19 @@ void Writer::createMiscChunks() {
IMAGE_DLL_CHARACTERISTICS_EX_CET_COMPAT));
}
+ if (writeLTO) {
+debugRecords.emplace_back(COFF::IMAGE_DEBUG_TYPE_POGO,
+ make(ltcg));
@@ -61,3 +61,29 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The linker input flags should be moved to the end of input list and
appear only when linking.
+!
@@ -61,3 +61,29 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The linker input flags should be moved to the end of input list and
appear only when linking.
+!
@@ -1073,6 +1086,19 @@ bool Driver::readConfigFile(StringRef FileName,
appendOneArg(*CfgOptions, Opt, BaseArg);
}
}
+
+ if (!CfgLinkerInputs)
+CfgLinkerInputs = std::move(NewLinkerIns);
+ else {
+// If this is a subsequent config file, append options to th
@@ -61,3 +61,29 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The linker input flags should be moved to the end of input list and
appear only when linking.
+!
@@ -61,3 +61,29 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The linker input flags should be moved to the end of input list and
appear only when linking.
+!
@@ -82,3 +82,29 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
@@ -82,3 +82,29 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
@@ -61,3 +61,29 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The linker input flags should be moved to the end of input list and
appear only when linking.
+!
@@ -1062,6 +1062,19 @@ bool Driver::readConfigFile(StringRef FileName,
for (Arg *A : *NewOptions)
A->claim();
+ // Filter out all -l and -Wl, options, put them into a separate list and
erase
+ // from the original list of configuration file options. These will be used
https://github.com/pawosm-arm edited
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1062,6 +1062,16 @@ bool Driver::readConfigFile(StringRef FileName,
for (Arg *A : *NewOptions)
A->claim();
+ std::unique_ptr NewLinkerIns =
std::make_unique();
pawosm-arm wrote:
changed and added a comment
https://github.com/llvm/llvm-project/pul
@@ -82,3 +82,35 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
@@ -82,3 +82,35 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
https://github.com/pawosm-arm updated
https://github.com/llvm/llvm-project/pull/117573
>From e5769df6180f6b89ad2c494e74d3e4dc9d88dec8 Mon Sep 17 00:00:00 2001
From: Pawel Osmialowski
Date: Mon, 25 Nov 2024 14:46:55 +
Subject: [PATCH] [clang][driver] Special care for -l and -Wl, flags in con
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From efb5b98de8817ce02a226353d9f5e36095874b27 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH] [clang-format] Add BreakBeforeTemplateClose option
---
clang/docs/Cl
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (c8ef)
Changes
Part of #51787.
This patch adds constexpr support for the built-in elementwise bitreverse
function.
---
Full diff: https://github.com/llvm/llvm-project/pull/118177.diff
6 Files Affected:
- (modified) clang/docs/Lan
https://github.com/c8ef ready_for_review
https://github.com/llvm/llvm-project/pull/118177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/118177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/118177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while
building `clang-tools-extra` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/52/builds/4138
Here is
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vadim D. (vvd170501)
Changes
https://github.com/PeterFeicht/cppreference-doc/releases/tag/v20241110
---
Full diff: https://github.com/llvm/llvm-project/pull/118174.diff
2 Files Affected:
- (modified) clang/lib/Tooling/Inclusions/Stdlib/
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/118177
>From 69c3275b5119adc049821aacf2b9f01641d73aad Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sun, 1 Dec 2024 00:10:58 +0800
Subject: [PATCH 1/2] constexpr elementwise bitreverse
---
clang/docs/LanguageExtensions.rst
https://github.com/vvd170501 ready_for_review
https://github.com/llvm/llvm-project/pull/118174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/stefanp-ibm created
https://github.com/llvm/llvm-project/pull/118178
In the backend we want to provide special handling for the function memcmp.
This patch adds an intrinsic so that the backend will recognize it as more than
just a regular function call.
This patch also add
tschuett wrote:
langref update for the new intrinsic?
https://github.com/llvm/llvm-project/pull/118178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-powerpc
Author: Stefan Pintilie (stefanp-ibm)
Changes
In the backend we want to provide special handling for the function memcmp.
This patch adds an intrinsic so that the backend will recognize it as more than
just a regular function call.
Thi
llvmbot wrote:
@llvm/pr-subscribers-llvm-selectiondag
Author: Stefan Pintilie (stefanp-ibm)
Changes
In the backend we want to provide special handling for the function memcmp.
This patch adds an intrinsic so that the backend will recognize it as more than
just a regular function call.
T
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/118177
None
>From 69c3275b5119adc049821aacf2b9f01641d73aad Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sun, 1 Dec 2024 00:10:58 +0800
Subject: [PATCH] constexpr elementwise bitreverse
---
clang/docs/LanguageExtensions.rst
chomosuke wrote:
Hi @kadircet, I have just started looking into `FeatureModule` and could not
find any example of it being used apart from testing. Just want to confirm that
this infrastructure isn't currently being used by anything in Clangd.
I assume I should extend `FeatureModule` to add my
aganea wrote:
I had a more in-depth look at this. Overall I don't agree with the whole
direction of this patch. I don't think it's wise for LLD to emit debug
records/`coffgrp` that do not match what MSVC is generating. We can't just
blindly emit a record with the string of the debug type (ie.
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/118176
The NTTP argument appearing inside a trailing return type of a generic lambda
would have to check for potential lambda captures, where the function needs
GLTemplateParameterList of the current LSI to tell wheth
@@ -1241,8 +1254,7 @@ SYMBOL(fgetwc, None, )
SYMBOL(fgetws, std::, )
SYMBOL(fgetws, None, )
SYMBOL(fgetws, None, )
-SYMBOL(filebuf, std::, )
-SYMBOL(filebuf, std::, )
+SYMBOL(filebuf, std::, )
vvd170501 wrote:
Previous versions of cppreference mentioned incorr
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/118174
>From 4c2d6a11ad6364182e93686f6e0bc8b834355877 Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Sat, 30 Nov 2024 18:09:23 +0300
Subject: [PATCH 1/2] Update std symbol mapping to v2024
---
.../Inclusions
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/118174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/118174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 created
https://github.com/llvm/llvm-project/pull/118174
None
>From 4c2d6a11ad6364182e93686f6e0bc8b834355877 Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Sat, 30 Nov 2024 18:09:23 +0300
Subject: [PATCH] Update std symbol mapping to v2024
---
.../Inclusio
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/117901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-11-30T22:14:36+08:00
New Revision: f89fa238faa6a63168997a8a1d03c15b71da8080
URL:
https://github.com/llvm/llvm-project/commit/f89fa238faa6a63168997a8a1d03c15b71da8080
DIFF:
https://github.com/llvm/llvm-project/commit/f89fa238faa6a63168997a8a1d03c15b71da8080.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HerrCai0907 wrote:
> Please add the matcher to
> https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp
> as well (clang-query).
i will do it separately to avoid this pr become bigger.
https://github.com/llvm/llvm-project/pull/117901
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oleksandr T. (a-tarasyuk)
Changes
Fixes #112205
---
Commit that introduced this feature -
https://github.com/llvm/llvm-project/commit/9306ef9750b7a319d59f6d3e4977e01e39b8f161
---
Full diff: https://github.com/llvm/llvm-project/pull/118
https://github.com/a-tarasyuk created
https://github.com/llvm/llvm-project/pull/118170
Fixes #112205
---
Commit that introduced this feature -
https://github.com/llvm/llvm-project/commit/9306ef9750b7a319d59f6d3e4977e01e39b8f161
>From f667cf6d39845ae7143ec6481297b7bb41b313fe Mon Sep 17 00:00
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/116709
>From 025f937646f190978325c58967ccb02828a78bd2 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Mon, 18 Nov 2024 16:06:31 +0100
Subject: [PATCH 1/2] [libc++] Define an internal API for std::invoke and
fr
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/116709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/117945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
5chmidti wrote:
And maybe @carlosgalvezp wants to comment
https://github.com/llvm/llvm-project/pull/66810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti approved this pull request.
LGTM, but please add a release note about fixing the infinite recursion
https://github.com/llvm/llvm-project/pull/66810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/118074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
5chmidti wrote:
Please add tests with macros involved (e.g., fully wrapped `#define F(obj,
n)...` or `#define N 2`, etc), and with templates
https://github.com/llvm/llvm-project/pull/118074
___
cfe-commits mailing li
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/118074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/5chmidti requested changes to this pull request.
It would be great to have this check work with uninstantiated templates and use
`TK_TraversUnlessSpelledInSource` as well.
Here is an example of a matcher for the uninstantiated case:
https://godbolt.org/z/1xnGGj7z9
I couldn'
@@ -0,0 +1,44 @@
+//===--- UseSpanFirstLastCheck.h - clang-tidy---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/118074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
5chmidti wrote:
You removed this by mistake, it's from another check
https://github.com/llvm/llvm-project/pull/118074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,110 @@
+//===--- UseSpanFirstLastCheck.cpp - clang-tidy-*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -172,6 +173,8 @@ class ReadabilityModule : public ClangTidyModule {
"readability-use-anyofallof");
CheckFactories.registerCheck(
"readability-use-std-min-max");
+CheckFactories.registerCheck(
+"readability-use-span-first-last");
--
https://github.com/chomosuke closed
https://github.com/llvm/llvm-project/pull/114661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -926,6 +926,8 @@ AST Matchers
- Ensure ``hasName`` matches template specializations across inline namespaces,
making `matchesNodeFullSlow` and `matchesNodeFullFast` consistent.
+- Add ``exportDecl`` matches export declaration.
5chmidti wrote:
> Add a `ex
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/117901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti commented:
Please add the matcher to
https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp
as well (clang-query).
https://github.com/llvm/llvm-project/pull/117901
___
cfe-commits mailing
1 - 100 of 105 matches
Mail list logo
