[clang] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the implementation of it is known (PR #85465)

2024-11-16 Thread via cfe-commits
https://github.com/AreaZR updated https://github.com/llvm/llvm-project/pull/85465 >From ffbc1da0d631f3969be4f470f5f446b34adf49fc Mon Sep 17 00:00:00 2001 From: Rose Date: Fri, 15 Mar 2024 16:43:10 -0400 Subject: [PATCH] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-11-16 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/111616 >From d8f59628643bc6eb4d572949d7f9df6df42f0146 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 8 Oct 2024 21:43:55 -0400 Subject: [PATCH] [clangd] Harden incomingCalls() against possible misinterp

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-11-16 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Updated patch with the following changes: * Resolve the potential UAF by storing `clangd::Location` rather than `SymbolLocation` in the `CallsIn` map * Add a testcase for the scenario from [this thread](https://github.com/llvm/llvm-project/pull/111616#discussion_r181041

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-11-16 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/111616 >From 3d0c93948072cd2412a656a38f48de3d6e23e996 Mon Sep 17 00:00:00 2001 From: timon-ul Date: Sun, 3 Nov 2024 07:38:25 +0100 Subject: [PATCH 1/3] Support call hierarchy for fields and non-local variables

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-11-16 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/111616 >From c72cc8dedc165091654eb5d922927319327f34c4 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 8 Oct 2024 21:43:55 -0400 Subject: [PATCH] [clangd] Harden incomingCalls() against possible misinterp

[clang] Added a PthreadCreateChecker and attempted to register it (PR #116515)

2024-11-16 Thread Balazs Benics via cfe-commits
steakhal wrote: Could you please ellaborate your intentions and motives? The PR description wasn't clear to me. @MaxSanchez99 https://github.com/llvm/llvm-project/pull/116515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [docs][asan][lsan] Drop list of supported architechures (PR #116302)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes Full list is quite long, and quality of implementation can vary. Drop the lists to avoid confusion like https://github.com/rust-lang/rust/pull/123617#issuecomment-2471695102 We don't maintain these for oth

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-16 Thread Congcong Cai via cfe-commits
@@ -269,6 +473,21 @@ void BranchCloneCheck::check(const MatchFinder::MatchResult &Result) { return; } + if (const auto *IS = Result.Nodes.getNodeAs("ifWithDescendantIf")) { +const Stmt *Then = IS->getThen(); +auto CS = dyn_cast(Then); +if (CS && (!CS->body_

[clang] [Clang] avoid adding consteval condition as the last statement to preserve valid CFG (PR #116513)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #116485 --- Full diff: https://github.com/llvm/llvm-project/pull/116513.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/lib/Analysis/CFG.cpp (+4-1) - (mod

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-16 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 5a48960ab73890b10381b4e7ebd32d3f66246bdd Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-16 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 11c24e5592bfdf8849bb415580d37a6f545e4952 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-16 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 11c24e5592bfdf8849bb415580d37a6f545e4952 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-16 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 0de2ff271efd672bae0b4974c404149da79ff747 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-16 Thread Vladislav Belov via cfe-commits
vbe-sc wrote: > I don't think this patch fixes the following case: > > ```c++ > template > struct A > { > struct B > { > using X = int; > > struct C > { > using X = void; > > struct D; > }; > }; > }; > > template > struct

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-16 Thread via cfe-commits
kolobabka wrote: > I don't think this patch fixes the following case: > > ```c++ > template > struct A > { > struct B > { > using X = int; > > struct C > { > using X = void; > > struct D; > }; > }; > }; > > template > str

[clang] [Clang] SemaFunctionEffects: Fix bug where lambdas produced by template expansion weren't verified. (PR #116505)

2024-11-16 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/116505 >From d235d3ea8bb3cabfc8db9d87233455a93fa23c05 Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Sat, 16 Nov 2024 11:59:03 -0800 Subject: [PATCH 1/2] [Clang] SemaFunctionEffects: Fix bug where lambdas produced

[clang] [llvm] Reland "[LLVM] Add IRNormalizer Pass" (PR #113780)

2024-11-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `llvm` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1464 Here is the relevant piece of the build log fo

[clang] Added a PthreadCreateChecker and attempted to register it (PR #116515)

2024-11-16 Thread via cfe-commits
https://github.com/MaxSanchez99 created https://github.com/llvm/llvm-project/pull/116515 None >From 029c4183c5685ac3047aec9154a593339b206a48 Mon Sep 17 00:00:00 2001 From: Maximino Sanchez Jr Date: Sat, 16 Nov 2024 18:35:39 -0600 Subject: [PATCH] Added a PthreadCreateChecker and attempted to r

[clang] [Clang] avoid adding consteval condition as the last statement to preserve valid CFG (PR #116513)

2024-11-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/116513 Fixes #116485 >From 69689f6ba5ac1715cc1df6cf08b79bb4b8bbe107 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 17 Nov 2024 01:34:42 +0200 Subject: [PATCH] [Clang] avoid adding consteval condition as the

[clang] Added a PthreadCreateChecker and attempted to register it (PR #116515)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (MaxSanchez99) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/116515.diff 5 Files Affected: - (modified) clang/include/clang/StaticAnalyzer/Checkers/Checkers.td (+4) - (modified) clang/lib/Head

[clang] Added a PthreadCreateChecker and attempted to register it (PR #116515)

2024-11-16 Thread via cfe-commits
https://github.com/MaxSanchez99 updated https://github.com/llvm/llvm-project/pull/116515 >From 029c4183c5685ac3047aec9154a593339b206a48 Mon Sep 17 00:00:00 2001 From: Maximino Sanchez Jr Date: Sat, 16 Nov 2024 18:35:39 -0600 Subject: [PATCH] Added a PthreadCreateChecker and attempted to registe

[clang] Added a PthreadCreateChecker and attempted to register it (PR #116515)

2024-11-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] SemaFunctionEffects: Fix bug where lambdas produced by template expansion weren't verified. (PR #116505)

2024-11-16 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. Ah yeah, I should have noticed that in review: `ActOnX` is generally only called during parsing, whereas `BuildX` is also called during template instantiation. As for the template notes, I don’t have a good solution for those either... A

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-11-16 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 219424f9cd3477d9290c8766eaa857234a1ae387 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/6] [clang-format] Add new option: WrapNamespaceBodyWithNewlines -

[clang] [Clang] SemaFunctionEffects: Fix bug where lambdas produced by template expansion weren't verified. (PR #116505)

2024-11-16 Thread Doug Wyatt via cfe-commits
dougsonos wrote: Thanks for the quick look. > Ah yeah, I should have noticed that in review: `ActOnX` is generally only > called during parsing, whereas `BuildX` is also called during template > instantiation. I actually do think it might have come up early in one of the giant reviews, but g

[clang] [Clang] SemaFunctionEffects: Fix bug where lambdas produced by template expansion weren't verified. (PR #116505)

2024-11-16 Thread via cfe-commits
Sirraide wrote: > Something like: The function template is pretty much what I meant, yeah, but by ‘templated lambda’ I meant either one that is an implicit template because one of its parameters is declared with `auto` (`[](auto x)`) or one that has an explicit template parameter list (`[]`).

[clang] [lld] [Clang][MinGW] Pass --functionpadmin to the linker when -fms-hotpatch is used (PR #116512)

2024-11-16 Thread Jacek Caban via cfe-commits
cjacek wrote: GCC offers the `ms_hook_prologue` function attribute as an alternative. It provides similar guarantees: it inserts a hardcoded prologue and adds padding. However, it applies on a per-function basis, so there isn’t an easy way to make the entire module hotpatchable. In GCC, the pa

[clang] [Clang][ScanDeps] Fix error message typo (PR #88404)

2024-11-16 Thread Arthur Laurent via cfe-commits
Arthapz wrote: observed this today, this should be merge :D ![image](https://github.com/user-attachments/assets/1990d0e0-414e-41e0-8e40-d6fe3b45a04f) https://github.com/llvm/llvm-project/pull/88404 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [lld] [Clang][MinGW] Pass --functionpadmin to the linker when -fms-hotpatch is used (PR #116512)

2024-11-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. This looks reasonable. Is this something that GCC doesn't have? IIRC they do have some support for hotpatchability in some way - can you briefly summarize what they have and what we have in common and what differs? https://github.com/llv

[clang] [lld] [Clang][MinGW] Pass --functionpadmin to the linker when -fms-hotpatch is used (PR #116512)

2024-11-16 Thread Jacek Caban via cfe-commits
cjacek wrote: This PR depends on #116511. It updates `-fms-hotpatch` to behave similarly during linking as it does in MSVC mode. However, one limitation remains: object files are marked as hotpatchable through CodeView data, so this is only effective when `-gcodeview` is enabled. This is simi

[clang] [lld] [Clang][MinGW] Pass --functionpadmin to the linker when -fms-hotpatch is used (PR #116512)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jacek Caban (cjacek) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/116512.diff 5 Files Affected: - (modified) clang/lib/Driver/ToolChains/MinGW.cpp (+3) - (modified) clang/test/Driver/mingw.cpp (+4) - (modif

[clang] [lld] [Clang][MinGW] Pass --functionpadmin to the linker when -fms-hotpatch is used (PR #116512)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-lld Author: Jacek Caban (cjacek) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/116512.diff 5 Files Affected: - (modified) clang/lib/Driver/ToolChains/MinGW.cpp (+3) - (modified) clang/test/Driver/mingw.

[clang] [lld] [Clang][MinGW] Pass --functionpadmin to the linker when -fms-hotpatch is used (PR #116512)

2024-11-16 Thread Jacek Caban via cfe-commits
https://github.com/cjacek created https://github.com/llvm/llvm-project/pull/116512 None >From c13f631c8074c85242fd1f639fd09aae78fede6a Mon Sep 17 00:00:00 2001 From: Jacek Caban Date: Sat, 16 Nov 2024 14:16:58 +0100 Subject: [PATCH 1/2] [LLD][MinGW] Add support for --functionpadmin option Thi

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-16 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: We basically have the following options here: 1. Use C++23 semantics in C++23 mode, with a warning. 2. Use C++2c semantics in C++23 mode, with a warning. 3. Reject the construct with a hard error in C++23 mode. (2) and (3) are basically removing the pack expansion parse fro

[clang] [Clang][ScanDeps] Fix error message typo (PR #88404)

2024-11-16 Thread Arthur Laurent via cfe-commits
Arthapz wrote: Ping https://github.com/llvm/llvm-project/pull/88404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/3768 Here is the relevan

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-16 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/116132 >From 5c52bea612c677352d555ce8100d222f149414d0 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 16 Nov 2024 15:41:00 -0500 Subject: [PATCH] [clang-tidy][modernize-use-starts-ends-with] Fix minor mi

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-16 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/116132 >From 5c52bea612c677352d555ce8100d222f149414d0 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 16 Nov 2024 15:41:00 -0500 Subject: [PATCH] [clang-tidy][modernize-use-starts-ends-with] Fix minor mi

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-16 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/116132 >From 56fd8556333a86a63903ffd370d307cf9484fd5a Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 16 Nov 2024 15:35:13 -0500 Subject: [PATCH] [clang-tidy][modernize-use-starts-ends-with] Fix minor mi

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-16 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/116132 >From 56fd8556333a86a63903ffd370d307cf9484fd5a Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 16 Nov 2024 15:35:13 -0500 Subject: [PATCH] [clang-tidy][modernize-use-starts-ends-with] Fix minor mi

[clang] [Clang] SemaFunctionEffects: Fix bug where lambdas produced by template expansion weren't verified. (PR #116505)

2024-11-16 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos created https://github.com/llvm/llvm-project/pull/116505 Lambdas are added to the list of Decls to verify using `Sema::maybeAddDeclWithEffects()`. Up until now this call was in `ActOnLambdaExpr`, which happens in the context of a template but not in the context o

[clang] [Clang] SemaFunctionEffects: Fix bug where lambdas produced by template expansion weren't verified. (PR #116505)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Wyatt (dougsonos) Changes Lambdas are added to the list of Decls to verify using `Sema::maybeAddDeclWithEffects()`. Up until now this call was in `ActOnLambdaExpr`, which happens in the context of a template but not in the context

[clang] 7642759 - [Lex] Remove unused includes (NFC) (#116460)

2024-11-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-11-16T12:14:06-08:00 New Revision: 764275949897533a4be0728250e69a94d228fbc5 URL: https://github.com/llvm/llvm-project/commit/764275949897533a4be0728250e69a94d228fbc5 DIFF: https://github.com/llvm/llvm-project/commit/764275949897533a4be0728250e69a94d228fbc5.diff L

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/116460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/116460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Remove ParseDiagnostic.h (PR #116496)

2024-11-16 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > Can you explain what is the perceived benefit of this change? Thanks Sure. - We'll have less code. - We'll have fewer "false positives" from clangd's "unused include" warnings. The .cpp files are not using anything declared in `ParseDiagnostic.h` because, after all, `

[clang] [CodeGen] Remove unused includes (NFC) (PR #116459)

2024-11-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/116459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Remove ParseDiagnostic.h (PR #116496)

2024-11-16 Thread via cfe-commits
cor3ntin wrote: Can you explain what is the perceived benefit of this change? Thanks https://github.com/llvm/llvm-project/pull/116496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-11-16 Thread via cfe-commits
cor3ntin wrote: @zyn0217 should we wait then? https://github.com/llvm/llvm-project/pull/102857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-16 Thread via cfe-commits
cor3ntin wrote: I did think about this more, and given we made the feature an extension we should not have 2 different meaning in different contexts, so I think improving the diagnostic is really the only thing we should consider here https://github.com/llvm/llvm-project/pull/116332 __

[clang] [Parse] Remove ParseDiagnostic.h (PR #116496)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Kazu Hirata (kazutakahirata) Changes This patch removes clang/Parse/ParseDiagnostic.h because it just forwards to clang/Basic/DiagnosticParse.h. --- Full diff: https://github.com/llvm/llvm-project/pull/116496.diff 17 Files Affected: - (

[clang] [Parse] Remove ParseDiagnostic.h (PR #116496)

2024-11-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/116496 This patch removes clang/Parse/ParseDiagnostic.h because it just forwards to clang/Basic/DiagnosticParse.h. >From 62d97fa37e10f478cb02651abb38dde9d03da76d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date

[clang] [llvm] [Opened-by-mistake] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread Dmitriy Sokolov via cfe-commits
https://github.com/dee-tree edited https://github.com/llvm/llvm-project/pull/116492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Opened-by-mistake] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread Dmitriy Sokolov via cfe-commits
https://github.com/dee-tree edited https://github.com/llvm/llvm-project/pull/116492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread Dmitriy Sokolov via cfe-commits
https://github.com/dee-tree closed https://github.com/llvm/llvm-project/pull/116492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Dmitriy Sokolov (dee-tree) Changes - Non-optimal machine basic block placement via fuzz option - machine block frequency inversion under the special option --- Patch is 20.87 KiB, truncated to 20.00 KiB below, full version: https:

[clang] [llvm] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Dmitriy Sokolov (dee-tree) Changes - Non-optimal machine basic block placement via fuzz option - machine block frequency inversion under the special option --- Patch is 20.87 KiB, truncated to 20.00 KiB below, full version: https

[clang] [llvm] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] BPU Machine basic block placement fuzz (PR #116492)

2024-11-16 Thread Dmitriy Sokolov via cfe-commits
https://github.com/dee-tree created https://github.com/llvm/llvm-project/pull/116492 - Non-optimal machine basic block placement via fuzz option - machine block frequency inversion under the special option >From 8376db35a7a7736d78bb7f0febf38203e415b489 Mon Sep 17 00:00:00 2001 From: Arseny Boch

[clang] [NFC][Clang][TableGen] Fix file header comments (PR #116491)

2024-11-16 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/116491 None >From a69664043703506d4331ff008d97de0c978a8aed Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 15 Nov 2024 09:49:12 -0800 Subject: [PATCH] [NFC][Clang][TableGen] Fix file header comments --- clang/

[clang] [NFC][Clang][TableGen] Fix file header comments (PR #116491)

2024-11-16 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/116491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Fix file header comments (PR #116491)

2024-11-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/116491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-16 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Fix file header comments (PR #116491)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Rahul Joshi (jurahul) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/116491.diff 21 Files Affected: - (modified) clang/utils/TableGen/ASTTableGen.cpp (+1-1) - (modified) clang/utils/TableGen/ClangASTNodesEmi

[clang] 71b3b32 - [Clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (#113830)

2024-11-16 Thread via cfe-commits
Author: Maurice Heumann Date: 2024-11-16T17:15:47+01:00 New Revision: 71b3b32c6ec8e4691b67b2571b4f44cdd15cb588 URL: https://github.com/llvm/llvm-project/commit/71b3b32c6ec8e4691b67b2571b4f44cdd15cb588 DIFF: https://github.com/llvm/llvm-project/commit/71b3b32c6ec8e4691b67b2571b4f44cdd15cb588.dif

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-16 Thread Kazu Hirata via cfe-commits
@@ -14,14 +14,10 @@ #include "clang/Basic/CharInfo.h" #include "clang/Basic/FileManager.h" #include "clang/Lex/HeaderMapTypes.h" -#include "llvm/ADT/SmallString.h" #include "llvm/Support/Compiler.h" -#include "llvm/Support/DataTypes.h" #include "llvm/Support/Debug.h" #includ

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/116460 >From ff95c21b5a5dbc4164c26d0d1760be2aa3d4 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 15 Nov 2024 17:34:23 -0800 Subject: [PATCH 1/2] [Lex] Remove unused includes (NFC) Identified with mis

[clang] 46d750b - [Sema] Remove unused includes (NFC) (#116461)

2024-11-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-11-16T07:37:33-08:00 New Revision: 46d750be2e19220c318bc907dfaf6c61d3a0de92 URL: https://github.com/llvm/llvm-project/commit/46d750be2e19220c318bc907dfaf6c61d3a0de92 DIFF: https://github.com/llvm/llvm-project/commit/46d750be2e19220c318bc907dfaf6c61d3a0de92.diff L

[clang] [Sema] Remove unused includes (NFC) (PR #116461)

2024-11-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/116461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e8a6624 - [CodeGen] Remove unused includes (NFC) (#116459)

2024-11-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-11-16T07:37:13-08:00 New Revision: e8a6624325e0c628ec23e5f124f1d2002f138dd5 URL: https://github.com/llvm/llvm-project/commit/e8a6624325e0c628ec23e5f124f1d2002f138dd5 DIFF: https://github.com/llvm/llvm-project/commit/e8a6624325e0c628ec23e5f124f1d2002f138dd5.diff L

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka edited https://github.com/llvm/llvm-project/pull/116033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[HLSL] Add implicit resource element type concepts to AST" (PR #116305)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joshua Batista (bob80905) Changes Reverts llvm/llvm-project#112600 --- Full diff: https://github.com/llvm/llvm-project/pull/116305.diff 6 Files Affected: - (modified) clang/lib/Sema/HLSLExternalSemaSource.cpp (+12-205) - (modified) cla

[clang] Thread safety analysis: Fix substitution for operator calls (PR #116487)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis @llvm/pr-subscribers-clang Author: Aaron Puchert (aaronpuchert) Changes For operator calls that go to methods we need to substitute the first parameter for "this" and the following parameters into the function parameters, instead of subs

[clang] [Driver] Remove unused includes (NFC) (PR #116316)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Identified with misc-include-cleaner. --- Full diff: https://github.com/llvm/llvm-project/pull/116316.diff 12 Files Affected: - (modified) clang/lib/Driver/Compilation.cpp (-3) - (modified) clang/l

[clang] Thread safety analysis: Fix substitution for operator calls (PR #116487)

2024-11-16 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert created https://github.com/llvm/llvm-project/pull/116487 For operator calls that go to methods we need to substitute the first parameter for "this" and the following parameters into the function parameters, instead of substituting all of them into the parameters

[clang] [analyzer] [MallocChecker] Less aggressive analysis of functions (PR #116383)

2024-11-16 Thread via cfe-commits
https://github.com/likeamahoney edited https://github.com/llvm/llvm-project/pull/116383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-16 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/116332 >From 5973de1d4c368a26fd179954a13de94595f35575 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 15 Nov 2024 14:09:14 +0800 Subject: [PATCH 1/2] [Clang][Parser] Make 'T...[N]' within a function parameter a

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-11-16 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Sadly I think I should figure out a way to remove reliance on the refactoring work of `getTemplateInstantiationArgs()`, as it is still unstable at this point. https://github.com/llvm/llvm-project/pull/102857 ___ cfe-commits mailing list

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-16 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 722a446023bd394c85c6eebf66e7bb5631a92a4d Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] [MS] Add /Zc:tlsGuards option to control tls guard emission --- cl

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
@@ -266,3 +269,53 @@ void test(std::string s, std::string_view sv, sub_string ss, sub_sub_string sss, s.compare(0, 1, "ab") == 0; s.rfind(suffix, 1) == s.size() - suffix.size(); } + +void test_substr() { +std::string str("hello world"); +std::string prefix = "hello

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From 23b4bcdf52041aad1c5581e0f7dc01028770a154 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang] [Clang] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. I'm not sure where __enqueue_kernel_basic is defined, but the signature it's declared with doesn't even have byval. This code certainly shouldn't have to be manually fixing up ABI details in any case https://github.com/llvm/llvm-project/pu

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1609 Here is the releva

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-16 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/116432 >From 865831ba2fb4778e8a1c25402b1cff70abd44d6b Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Fri, 15 Nov 2024 15:22:21 + Subject: [PATCH] [clang][driver] When -fveclib=ArmPL flag is in use, alway

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-16 Thread via cfe-commits
@@ -102,6 +102,210 @@ void BranchCloneCheck::registerMatchers(MatchFinder *Finder) { this); Finder->addMatcher(switchStmt().bind("switch"), this); Finder->addMatcher(conditionalOperator().bind("condOp"), this); + Finder->addMatcher(ifStmt(hasDescendant(ifStmt())).b

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #116413)

2024-11-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Joshua Batista (bob80905) Changes This PR is step one on the journey to implement resource element type validation via C++20 concepts. The PR sets up the infrastructure for injecting implicit concept decls / concept specialization expressi

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
@@ -189,7 +203,54 @@ void UseStartsEndsWithCheck::check(const MatchFinder::MatchResult &Result) { if (ComparisonExpr->getBeginLoc().isMacroID()) return; - const bool Neg = ComparisonExpr->getOpcode() == BO_NE; + bool Neg; + if (const auto *BO = llvm::dyn_cast(Compari

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From 7c446c6ce13e8c8c4fda22b70d5eef03852c5572 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-16 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/116432 >From dde726aa72cd23a5a824846e6b65583d1274d18c Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Fri, 15 Nov 2024 15:22:21 + Subject: [PATCH] [clang][driver] When -fveclib=ArmPL flag is in use, alway

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-16 Thread Eli Friedman via cfe-commits
@@ -58,8 +58,9 @@ void b(T[] ...); template void c(T ... []); // expected-error {{expected expression}} \ efriedma-quic wrote: Consider: ``` templatevoid c(T ... []); ``` Earlier versions of clang consider this valid: it's a function that takes pointers to

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-16 Thread via cfe-commits
cor3ntin wrote: I am not sure we want to keep supporting the old syntax, even in older language modes (notably, it isn't supported by other compilers and is at best missleading), but I'd like more people to chime in on that. I'm all for improving diagnostics though. https://github.com/llvm/ll

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-16 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From 336eb74f2c60ec74004f6c3625ba8bcf464e40b5 Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH] [analy

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-16 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From b149670c72ce08ace1f36c44d794f422f70708ed Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka commented: @nicovank feedback addressed * added support for .size() * more tests - incl. macros https://github.com/llvm/llvm-project/pull/116033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From 5b937c431486d23a696b536aa9dde560447b5756 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang] [Sema] Remove unused includes (NFC) (PR #116461)

2024-11-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/116461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/116435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-16 Thread Nikita Popov via cfe-commits
@@ -14,14 +14,10 @@ #include "clang/Basic/CharInfo.h" #include "clang/Basic/FileManager.h" #include "clang/Lex/HeaderMapTypes.h" -#include "llvm/ADT/SmallString.h" #include "llvm/Support/Compiler.h" -#include "llvm/Support/DataTypes.h" #include "llvm/Support/Debug.h" #includ

[clang] [CodeGen] Remove unused includes (NFC) (PR #116459)

2024-11-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/116459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >