[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-10-27 Thread via cfe-commits
MichelleCDjunaidi wrote: @5chmidti ah, so if I'm getting you correctly, next time I shouldn't rebase and just wait to fix the conflict on merge? https://github.com/llvm/llvm-project/pull/102299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [clang-format] Add -ConfigFile option (PR #113864)

2024-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/113864 >From b5f89c18b22bbc07d2f4fcbc2896996efea52478 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 27 Oct 2024 22:22:11 -0700 Subject: [PATCH] [clang-format] Add -ConfigFile option Close #107808. --- clang/inclu

[clang-tools-extra] Insert `// NOLINTNEXTLINE(...)` for clang-tidy diagnostics (PR #111640)

2024-10-27 Thread Richard Li via cfe-commits
https://github.com/chomosuke closed https://github.com/llvm/llvm-project/pull/111640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Don't allow '+f' as an inline asm constraint. (PR #113871)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Craig Topper (topperc) Changes f cannot be used as an output constraint. We already errored for '=f' but not '+f'. Fixes #113692. --- Full diff: https://github.com/llvm/llvm-project/pull/113871.diff 2 Files Affected: - (modified) clan

[clang] [X86] Don't allow '+f' as an inline asm constraint. (PR #113871)

2024-10-27 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/113871 f cannot be used as an output constraint. We already errored for '=f' but not '+f'. Fixes #113692. >From 48c30e1a7d82c7124abbe6980b0495f6e05a5753 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Sun, 27 Oct

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-10-27 Thread via cfe-commits
@@ -0,0 +1,35 @@ +//===--- IncorrectEnableSharedFromThisCheck.h - clang-tidy --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-10-27 Thread via cfe-commits
@@ -0,0 +1,62 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-10-27 Thread via cfe-commits
@@ -0,0 +1,62 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 23d4562382b753c604fffa078f8bdd0f75d57ac4 Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] [MS] Add /Zc:tlsGuards option to control tls guard emission --- cl

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 edited https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 edited https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add /Zc:tlsGuards option to control to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 edited https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add /Zc:tlsGuards option to control to control tls guard emission (PR #113830)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Maurice Heumann (momo5502) Changes This fixes #103484 --- Full diff: https://github.com/llvm/llvm-project/pull/113830.diff 6 Files Affected: - (modified) clang/include/clang/Basic/LangOptions.def (+1)

[clang] Add /Zc:tlsGuards option to control to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 ready_for_review https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add /Zc:tlsGuards option to control to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 edited https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add /Zc:tlsGuards- option (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 433a059884ce4bbfada60a300666fe58aecede4f Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] Add /Zc:tlsGuards option to control to control tls guard emission

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-27 Thread Jesse Huang via cfe-commits
https://github.com/jaidTw updated https://github.com/llvm/llvm-project/pull/112477 >From fe4a28fb691b69d9af384f1dc2f0667761adef44 Mon Sep 17 00:00:00 2001 From: Jesse Huang Date: Sun, 13 Oct 2024 15:11:06 +0800 Subject: [PATCH 1/8] [Clang][RISCV] Support -fcf-protection=return for RISC-V ---

[clang-tools-extra] Insert `// NOLINTNEXTLINE(...)` for clang-tidy diagnostics (PR #111640)

2024-10-27 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/111640 >From e1c2a46487c42c17dc0bbfab56cde194c15e14b3 Mon Sep 17 00:00:00 2001 From: chomosuke Date: Fri, 16 Aug 2024 13:31:21 + Subject: [PATCH 01/17] Fixing one error --- clang-tools-extra/clangd/ClangdServer

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-27 Thread Jesse Huang via cfe-commits
https://github.com/jaidTw updated https://github.com/llvm/llvm-project/pull/112477 >From fe4a28fb691b69d9af384f1dc2f0667761adef44 Mon Sep 17 00:00:00 2001 From: Jesse Huang Date: Sun, 13 Oct 2024 15:11:06 +0800 Subject: [PATCH 1/7] [Clang][RISCV] Support -fcf-protection=return for RISC-V ---

[clang] [clang][NFC] Accept const NamedDecl pointer for getDepthAndIndex (PR #113857)

2024-10-27 Thread via cfe-commits
https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/113857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix false positive for implicit conversion of comparison result in C23 (PR #113639)

2024-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while building `clang-tools-extra` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/3266 Here is

[clang] [clang-format] Add -ConfigFile option (PR #113864)

2024-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca converted_to_draft https://github.com/llvm/llvm-project/pull/113864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add -ConfigFile option (PR #113864)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Close #107808. --- Full diff: https://github.com/llvm/llvm-project/pull/113864.diff 2 Files Affected: - (modified) clang/include/clang/Format/Format.h (+5) - (modified) clang/lib/Format/Format.cpp (+14)

[clang] [clang-format] Add -ConfigFile option (PR #113864)

2024-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/113864 Close #107808. >From 4cbc31029c5d773dd68c80030e896b3fed88ab77 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 27 Oct 2024 22:22:11 -0700 Subject: [PATCH] [clang-format] Add -ConfigFile option Close #107808.

[clang-tools-extra] [clang-tidy] support `return c ? a : b;` in bugprone-return-const-ref-from-parameter (PR #107657)

2024-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/107657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedLocalVarsChecker] Warn the use of a raw pointer/reference when the guardian variable gets mutated. (PR #113859)

2024-10-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fb33af08e4c105a05855f8beeb972d493410e72f 8fce7f69eb5e28f6ec648ee0dc4cc23c793f64c0 --e

[clang-tools-extra] [clang-tidy] fix false positive for implicit conversion of comparison result in C23 (PR #113639)

2024-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/113639 >From 53ff1325281e37b164abc8705f2d75d7caeec3a4 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 25 Oct 2024 11:07:14 +0800 Subject: [PATCH 1/2] [clang-tidy] fix false positive for implicit conversion

[clang] [alpha.webkit.UncountedLocalVarsChecker] Warn the use of a raw pointer/reference when the guardian variable gets mutated. (PR #113859)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes This checker has a notion of a guardian variable which is a variable and keeps the object pointed to by a raw pointer / reference in an inner scope alive long enough to "guard" it from use-af

[clang] [alpha.webkit.UncountedLocalVarsChecker] Warn the use of a raw pointer/reference when the guardian variable gets mutated. (PR #113859)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes This checker has a notion of a guardian variable which is a variable and keeps the object pointed to by a raw pointer / reference in an inner scope alive long enough to "guard" it from use-after-free. But such

[clang] [alpha.webkit.UncountedLocalVarsChecker] Warn the use of a raw pointer/reference when the guardian variable gets mutated. (PR #113859)

2024-10-27 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/113859 This checker has a notion of a guardian variable which is a variable and keeps the object pointed to by a raw pointer / reference in an inner scope alive long enough to "guard" it from use-after-free. But such a

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -58,7 +58,7 @@ inline InheritableAttr *getDLLAttr(Decl *D) { } /// Retrieve the depth and index of a template parameter. -inline std::pair getDepthAndIndex(NamedDecl *ND) { +inline std::pair getDepthAndIndex(const NamedDecl *ND) { antangelo wrote: Done, se

[clang] c876d71 - [clang][NFC] Accept const NamedDecl pointer for getDepthAndIndex (#113857)

2024-10-27 Thread via cfe-commits
Author: antangelo Date: 2024-10-28T00:25:56-04:00 New Revision: c876d719ef5b10128eca6d8677068248b4831017 URL: https://github.com/llvm/llvm-project/commit/c876d719ef5b10128eca6d8677068248b4831017 DIFF: https://github.com/llvm/llvm-project/commit/c876d719ef5b10128eca6d8677068248b4831017.diff LOG

[clang] [clang][NFC] Accept const NamedDecl pointer for getDepthAndIndex (PR #113857)

2024-10-27 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/113857 None >From 9ba109b5e3eae0fc42939ead72991fc17dcd3d0a Mon Sep 17 00:00:00 2001 From: antangelo Date: Sun, 27 Oct 2024 22:41:24 -0400 Subject: [PATCH] [clang][NFC] Accept const NamedDecl pointer for getDepthAnd

[clang-tools-extra] [clang-tidy] fix false positive for implicit conversion of comparison result in C23 (PR #113639)

2024-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/113639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV]Add svvptc extension (PR #113758)

2024-10-27 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp commented: Please update ReleaseNotes. https://github.com/llvm/llvm-project/pull/113758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a1d31ca - [clang-tidy] fix false positive for implicit conversion of comparison result in C23 (#113639)

2024-10-27 Thread via cfe-commits
Author: Congcong Cai Date: 2024-10-28T11:36:37+08:00 New Revision: a1d31caa8c53082d12f580122dcf2b2ff8285e78 URL: https://github.com/llvm/llvm-project/commit/a1d31caa8c53082d12f580122dcf2b2ff8285e78 DIFF: https://github.com/llvm/llvm-project/commit/a1d31caa8c53082d12f580122dcf2b2ff8285e78.diff

[clang] [clang][NFC] Accept const NamedDecl pointer for getDepthAndIndex (PR #113857)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/113857.diff 1 Files Affected: - (modified) clang/include/clang/Sema/SemaInternal.h (+1-1) ``diff diff --git a/clang/include/clang/Sema/SemaInt

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-27 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/113826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add the Sha extension (PR #113820)

2024-10-27 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/113820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Use Sha extension in RVA23S64 profile (PR #113823)

2024-10-27 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/113823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Remove nvvm.ldg.global.* intrinsics (PR #112834)

2024-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot8` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/2313 Here is the r

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-27 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf closed https://github.com/llvm/llvm-project/pull/113402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-27 Thread Ming-Yi Lai via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -triple riscv64-linux-unknown -target-feature +zimop -emit-llvm -o - %s -fcf-protection=return | FileCheck %s +// RUN: %clang_cc1 -triple riscv64-linux-unknown -target-feature +zimop -emit-llvm -o - %s | FileCheck -check-prefix=NOSHADOWSTACK %

[clang] 5aa1275 - [X86] Support SM4 EVEX version intrinsics/instructions. (#113402)

2024-10-27 Thread via cfe-commits
Author: Freddy Ye Date: 2024-10-28T10:46:16+08:00 New Revision: 5aa1275d03b679f45f47f29f206292f663afed83 URL: https://github.com/llvm/llvm-project/commit/5aa1275d03b679f45f47f29f206292f663afed83 DIFF: https://github.com/llvm/llvm-project/commit/5aa1275d03b679f45f47f29f206292f663afed83.diff LOG

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-27 Thread Ming-Yi Lai via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -triple riscv64-linux-unknown -target-feature +zimop -emit-llvm -o - %s -fcf-protection=return | FileCheck %s +// RUN: %clang_cc1 -triple riscv64-linux-unknown -target-feature +zimop -emit-llvm -o - %s | FileCheck -check-prefix=NOSHADOWSTACK %

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -58,7 +58,7 @@ inline InheritableAttr *getDLLAttr(Decl *D) { } /// Retrieve the depth and index of a template parameter. -inline std::pair getDepthAndIndex(NamedDecl *ND) { +inline std::pair getDepthAndIndex(const NamedDecl *ND) { antangelo wrote: I'll spl

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -1216,10 +1308,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
antangelo wrote: Thanks for the reviews! > * can you give a description if what needs to be done in subsequent PRs? > (maybe cxx_status.html should say "partial" The remaining tasks are: - Supporting dependent using-declarators such as `using Derived::Base::Base`. These are somewhat annoy

[clang] [llvm] [X86][AMX] Support AMX-FP8 (PR #113850)

2024-10-27 Thread Feng Zou via cfe-commits
https://github.com/fzou1 updated https://github.com/llvm/llvm-project/pull/113850 >From fd570cb8d41f5f94b61d515985245fc81aab633e Mon Sep 17 00:00:00 2001 From: Feng Zou Date: Thu, 24 Oct 2024 21:56:48 +0800 Subject: [PATCH 1/2] Support AMX-FP8 Ref.: https://cdrdv2.intel.com/v1/dl/getContent/67

[clang] [llvm] [X86][AMX] Support AMX-FP8 (PR #113850)

2024-10-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1fe8e7838bb5118b9e48fa15fa21a4638bae8ae1 fd570cb8d41f5f94b61d515985245fc81aab633e --e

[clang] [llvm] [X86][AMX] Support AMX-FP8 (PR #113850)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Feng Zou (fzou1) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 --- Patch is 24.90 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/113850.diff 24 Files Affected: - (modi

[clang] [llvm] [X86][AMX] Support AMX-FP8 (PR #113850)

2024-10-27 Thread Feng Zou via cfe-commits
https://github.com/fzou1 created https://github.com/llvm/llvm-project/pull/113850 Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 >From fd570cb8d41f5f94b61d515985245fc81aab633e Mon Sep 17 00:00:00 2001 From: Feng Zou Date: Thu, 24 Oct 2024 21:56:48 +0800 Subject: [PATCH] Support AMX-FP8

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -11758,6 +11795,40 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } +// Errors in deduction guides from inherited constructors +// will present as substitution failures in the mapping +// partial specialization

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -1398,5 +1807,30 @@ void Sema::DeclareImplicitDeductionGuides(TemplateDecl *Template, ->getTemplatedDecl()) ->setDeductionCandidateKind(DeductionCandidate::Copy); + CXXRecordDecl *TemplatedDecl = Pattern->getTemplatedDecl(); + if (getLangOpts().CPlusPlus2

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -931,12 +935,73 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +struct InheritedConstructorDeductionInfo { + // Class template for which we are declaring deduction guides + // This is `C` i

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -899,7 +902,8 @@ Expr *buildIsDeducibleConstraint(Sema &SemaRef, return TypeTraitExpr::Create( Context, Context.getLogicalOperationType(), AliasTemplate->getLocation(), TypeTrait::BTT_IsDeducible, IsDeducibleTypeTraitArgs, - AliasTemplate->getLocation(), /

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -11758,6 +11795,40 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } +// Errors in deduction guides from inherited constructors +// will present as substitution failures in the mapping +// partial specialization

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -11758,6 +11795,40 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } +// Errors in deduction guides from inherited constructors +// will present as substitution failures in the mapping antangelo wro

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -10616,6 +10616,43 @@ bool clang::isBetterOverloadCandidate( auto *Guide1 = dyn_cast_or_null(Cand1.Function); auto *Guide2 = dyn_cast_or_null(Cand2.Function); if (Guide1 && Guide2) { + // -- F1 and F2 are generated from class template argument deduction +

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -10616,6 +10616,43 @@ bool clang::isBetterOverloadCandidate( auto *Guide1 = dyn_cast_or_null(Cand1.Function); auto *Guide2 = dyn_cast_or_null(Cand2.Function); if (Guide1 && Guide2) { + // -- F1 and F2 are generated from class template argument deduction +

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-10-27 Thread via cfe-commits
@@ -1960,24 +1960,38 @@ class ExplicitSpecifier { class CXXDeductionGuideDecl : public FunctionDecl { void anchor() override; +public: + enum class SourceKind { antangelo wrote: Done, renamed to `SourceDeductionGuideKind` to align with the class member and

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-27 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/110471 >From ba04e964207053724db5df8795675b89e533260a Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 26 Sep 2024 16:24:59 +0200 Subject: [PATCH] [clang-tidy] [analyzer] Move nondeterministic pointer usage

[clang] [llvm] [NVPTX] Remove nvvm.ldg.global.* intrinsics (PR #112834)

2024-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang,llvm` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/3935 Here is the relevant piece of the build l

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-27 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/113845 >From 1524ca532c9c1ef015c162360d4e4688296bbc0d Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 27 Oct 2024 16:30:48 -0700 Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functio

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fb33af08e4c105a05855f8beeb972d493410e72f 1524ca532c9c1ef015c162360d4e4688296bbc0d --e

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes This PR makes webkit.UncountedLambdaCapturesChecker ignore trivial functions as well as the one being passed to an argument with [[clang::noescape]] attribute. This dramatically reduces the false positive rate

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-27 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/113845 This PR makes webkit.UncountedLambdaCapturesChecker ignore trivial functions as well as the one being passed to an argument with [[clang::noescape]] attribute. This dramatically reduces the false positive rate fo

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes This PR makes webkit.UncountedLambdaCapturesChecker ignore trivial functions as well as the one being passed to an argument with [[clang::noescape]] attribute. This dramatically reduces the f

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-27 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/110471 >From 4dc4e525ffbf9bb391356008011f5cc6ab20bc1d Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 26 Sep 2024 16:24:59 +0200 Subject: [PATCH] [clang-tidy] [analyzer] Move nondeterministic pointer usage

[clang] [llvm] [NVPTX] Remove nvvm.ldg.global.* intrinsics (PR #112834)

2024-10-27 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean closed https://github.com/llvm/llvm-project/pull/112834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb33af0 - [NVPTX] Remove nvvm.ldg.global.* intrinsics (#112834)

2024-10-27 Thread via cfe-commits
Author: Alex MacLean Date: 2024-10-27T16:14:13-07:00 New Revision: fb33af08e4c105a05855f8beeb972d493410e72f URL: https://github.com/llvm/llvm-project/commit/fb33af08e4c105a05855f8beeb972d493410e72f DIFF: https://github.com/llvm/llvm-project/commit/fb33af08e4c105a05855f8beeb972d493410e72f.diff

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-27 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > I do plan to work on improvements Great > would like to get this baseline checker in for now as a "scope of work" for > this PR Yep, what I meant as well > I don't mind documenting the improvement step > Do you have suggestions on where to document improvements? As sugges

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-27 Thread via cfe-commits
vabridgers wrote: Thanks @5chmidti ! I do plan to work on improvements, but would like to get this baseline checker in for now as a "scope of work" for this PR. I don't mind documenting the improvement steps per @whisperity suggestions, and addressing your most recent comments. Do you have sug

[clang] [libcxx] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-27 Thread via cfe-commits
serge-sans-paille wrote: Waiting for @AaronBallman ack then ^^! https://github.com/llvm/llvm-project/pull/111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-27 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/111434 >From 9b57e5b54def6fcacb2a587e7f2c967e3e4de1ba Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 7 Oct 2024 15:30:24 +0200 Subject: [PATCH 1/2] [clang] Warn about memset/memcpy to NonTriviall

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-27 Thread Owen Pan via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] [clang-format] Make bitwise and imply requires clause (PR #110942)

2024-10-27 Thread Owen Pan via cfe-commits
@@ -1296,6 +1296,15 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("bool x = t && requires(Foo x) { x.foo(); };"); ASSERT_EQ(Tokens.size(), 25u) << Tokens; EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresExpression); + + //

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-27 Thread Owen Pan via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-27 Thread Owen Pan via cfe-commits
@@ -185,6651 +179,10 @@ the configuration (without a prefix: ``Auto``). subdirectories. This is also possible through the command line, e.g.: ``--style={BasedOnStyle: InheritParentConfig, ColumnLimit: 20}`` +.. This section of the file is automatically generated by the

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-27 Thread Owen Pan via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang-tools-extra] [clang-tidy] do not expand macros in modernize-use-using fix (PR #113837)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Julian Schmidt (5chmidti) Changes Previously, the implementation used the printed type, which contains the macro arguments expanded (also deleting comments). Instead, this check can be more surgical and keep the actual written t

[clang-tools-extra] [clang-tidy] do not expand macros in modernize-use-using fix (PR #113837)

2024-10-27 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/113837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] do not expand macros in modernize-use-using fix (PR #113837)

2024-10-27 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/113837 Previously, the implementation used the printed type, which contains the macro arguments expanded (also deleting comments). Instead, this check can be more surgical and keep the actual written type as is, keepin

[clang-tools-extra] [clang-tidy] Fix crash in modernize-use-designated-initializers check (PR #113688)

2024-10-27 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. Looking at it again, this way is also good, no preference. Good to merge 👍 https://github.com/llvm/llvm-project/pull/113688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [clang][Index] check `TemplateTypeParmTypeLoc::getDecl()` against `nullptr` in `TypeIndexer` and `CursorVisitor` (PR #89392)

2024-10-27 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Fixed by https://github.com/llvm/llvm-project/commit/c7bfc41860a6abe5c92dc5afb47348b0c9e69963 https://github.com/llvm/llvm-project/pull/89392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang][Index] check `TemplateTypeParmTypeLoc::getDecl()` against `nullptr` in `TypeIndexer` and `CursorVisitor` (PR #89392)

2024-10-27 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/89392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix crash in altera-id-dependent-backward-branch (PR #113833)

2024-10-27 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/113833 Add some checks for `nullptr` and change some `dyn_cast` to `dyn_cast_if_present` to avoid crashes. Fixes #55408 >From 99090f44fdfe049d7e01e469787ebb0039b965c4 Mon Sep 17 00:00:00 2001 From: Julian Schmidt D

[clang-tools-extra] [clang-tidy] fix crash in altera-id-dependent-backward-branch (PR #113833)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Julian Schmidt (5chmidti) Changes Add some checks for `nullptr` and change some `dyn_cast` to `dyn_cast_if_present` to avoid crashes. Fixes #55408 --- Full diff: https://github.com/llvm/llvm-project/pull/113833.diff 1 Files

[clang-tools-extra] [clang-tidy] fix crash in altera-id-dependent-backward-branch (PR #113833)

2024-10-27 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/113833 >From 99090f44fdfe049d7e01e469787ebb0039b965c4 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sun, 27 Oct 2024 20:47:21 +0100 Subject: [PATCH 1/2] [clang-tidy] fix crash in altera-id-dependent-backward-br

[clang-tools-extra] [clang-tidy] fix crash in altera-id-dependent-backward-branch (PR #113833)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Julian Schmidt (5chmidti) Changes Add some checks for `nullptr` and change some `dyn_cast` to `dyn_cast_if_present` to avoid crashes. Fixes #55408 --- Full diff: https://github.com/llvm/llvm-project/pull/113833.diff 1 Files Affect

[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

2024-10-27 Thread Julian Schmidt via cfe-commits
5chmidti wrote: There is a minimal repro in #111436 available https://github.com/llvm/llvm-project/pull/66810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Use Sha extension in RVA23S64 profile (PR #113823)

2024-10-27 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113823 Stacks on top of #113820 In the ratified version of the RVA23S64 definition, the Sha extension is now used to group together the set of hypervisor related extensions.

[clang] Add /Zc:tlsGuards- option (PR #113830)

2024-10-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 60d2feded5c0f55b21d042ee2f35227847d66ee0 b1b4da14386856667d11c284535348002954f94f --e

[clang] Add /Zc:tlsGuards- option (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 created https://github.com/llvm/llvm-project/pull/113830 This fixes #103484 >From b1b4da14386856667d11c284535348002954f94f Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] Add /Zc:tlsGuards- option --- clang/include/cl

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-27 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113826 All of the extensions used by these profile are themselves non-experimental, and RVA23 was just ratified .

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-27 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm edited https://github.com/llvm/llvm-project/pull/109837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-27 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/109837 >From 07a2cab3fa5df2965f9f7da9ee2d3603581a47f1 Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 22 Sep 2024 20:23:20 -0700 Subject: [PATCH 1/8] [InstrPGO] Instrument sampling profile based cold function --- c

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-27 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/109837 >From 07a2cab3fa5df2965f9f7da9ee2d3603581a47f1 Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 22 Sep 2024 20:23:20 -0700 Subject: [PATCH 1/8] [InstrPGO] Instrument sampling profile based cold function --- c

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Bradbury (asb) Changes All of the extensions used by these profile are themselves non-experimental, and RVA23 was just ratified ;.

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-27 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann updated https://github.com/llvm/llvm-project/pull/111389 >From 3c4a2b8a52d3f1c730df88a308dece21a67834ef Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Fri, 4 Oct 2024 11:10:32 -0700 Subject: [PATCH 1/5] [SYCL] The sycl_kernel_entry_point attribute. The `sycl_

  1   2   >