[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
arsenm wrote: > 1. Usually (or at least AFAIK) optimization passes won't consider datalayout > automatically, The datalayout is a widely used global constant. There's no option of "not considering it" > Do you plan to go over LLVM passes adding this check? There's nothing new to do here. T

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/110695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
@@ -1,56 +0,0 @@ -; This test aims to check ability to support "Arithmetic with Overflow" intrinsics arsenm wrote: > Right but it's relying on a non-guaranteed maybe-optimisation firing, as far > as I can tell. The point is to test the optimization does work.

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-10-01 Thread Vassil Vassilev via cfe-commits
@@ -702,10 +723,8 @@ llvm::Error Interpreter::LoadDynamicLibrary(const char *name) { if (!EE) return EE.takeError(); - auto &DL = EE->getDataLayout(); - - if (auto DLSG = llvm::orc::DynamicLibrarySearchGenerator::Load( - name, DL.getGlobalPrefix())) + if (au

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-10-01 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-10-01 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev commented: I'd feel more comfortable if @lhames takes a look, too. Can you run some benchmarks and compare in-process to out-of-process to out-of-process with shared memory (same architecture)? https://github.com/llvm/llvm-project/pull/110418 _

[clang] [llvm] [Hashing] Use a non-deterministic seed if LLVM_ENABLE_ABI_BREAKING_CHECKS (PR #96282)

2024-10-01 Thread Christian Sigg via cfe-commits
@@ -322,24 +306,20 @@ struct hash_state { } }; - -/// A global, fixed seed-override variable. -/// -/// This variable can be set using the \see llvm::set_fixed_execution_seed -/// function. See that function for details. Do not, under any circumstances, -/// set or read this

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Michal Paszkowski via cfe-commits
@@ -1,56 +0,0 @@ -; This test aims to check ability to support "Arithmetic with Overflow" intrinsics michalpaszkowski wrote: @AlexVlx I am not sure I follow the reasoning here. The idea behind those various tests in `/SPIRV/optimizations/` (including this one)

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
c8ef wrote: > Please also add a note in the `clang/docs/ReleaseNotes.rst` Done. https://github.com/llvm/llvm-project/pull/110638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
@@ -108,6 +108,7 @@ namespace MultilevelSpecialization { template<> template void B::f(int i, int (&arr1)[a], int (&arr2)[b]) {} // since-cxx11-error@-1 {{out-of-line definition of 'f' does not match any declaration in 'cwg2233::MultilevelSpecialization::B'}} +//

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread via cfe-commits
@@ -522,6 +526,28 @@ let Predicates = [BPFNoALU32] in { } def STD : STOREi64; +class relaxed_store + : PatFrag<(ops node:$val, node:$ptr), (base node:$val, node:$ptr)> { + let IsAtomic = 1; + let IsAtomicOrderingReleaseOrStronger = 0; +} + +class releasing_store + : PatFra

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-01 Thread Florian Albrechtskirchinger via cfe-commits
https://github.com/falbrechtskirchinger updated https://github.com/llvm/llvm-project/pull/110496 >From 220d76a2b2327318a6b5261896736ddd3f05988a Mon Sep 17 00:00:00 2001 From: Florian Albrechtskirchinger Date: Mon, 30 Sep 2024 12:58:15 +0200 Subject: [PATCH] [Serialization] Handle uninitialized

[clang] [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (PR #110780)

2024-10-01 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai closed https://github.com/llvm/llvm-project/pull/110780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1202c24 - [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (#110780)

2024-10-01 Thread via cfe-commits
Author: Volodymyr Sapsai Date: 2024-10-01T21:47:52-07:00 New Revision: 1202c24b0d128c4838252daeeb1268707da69507 URL: https://github.com/llvm/llvm-project/commit/1202c24b0d128c4838252daeeb1268707da69507 DIFF: https://github.com/llvm/llvm-project/commit/1202c24b0d128c4838252daeeb1268707da69507.di

[clang] [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (PR #110780)

2024-10-01 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: CI error ``` Traceback (most recent call last): File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-r8xzr-1/llvm-project/github-pull-requests/libcxx/utils/generate_iwyu_mapping.py", line 92, in main(sys.argv[1:]) File "/var/lib/buildkite-agent/builds/linux-56-59b8f

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
francisvm wrote: I totally agree with you @tex3d, I wish we could add these constraints somewhere in `Builtins.td` in a more structured way. The diagnostic change was not unintentional, I just assumed we'd fix the one argument builtins in a separate commit from this one (aimed at two args). h

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
@@ -9519,15 +9519,28 @@ Sema::ActOnStartRequiresExpr(SourceLocation RequiresKWLoc, } else if (Param->getType().hasQualifiers()) { Diag(Param->getBeginLoc(), diag::err_void_param_qualified); } -} - -if (Param->hasDefaultArg()) +} else if (Param->

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Younan Zhang via cfe-commits
@@ -9519,15 +9519,28 @@ Sema::ActOnStartRequiresExpr(SourceLocation RequiresKWLoc, } else if (Param->getType().hasQualifiers()) { Diag(Param->getBeginLoc(), diag::err_void_param_qualified); } -} - -if (Param->hasDefaultArg()) +} else if (Param->

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-01 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: This example from the failing test should warn I think: ```c++ class Foo { public: void foo1(); void foo2(); void foo3(Foo

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
c8ef wrote: Thanks! 🥰 https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 679be52 - [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (#110773)

2024-10-01 Thread via cfe-commits
Author: c8ef Date: 2024-10-02T12:01:31+08:00 New Revision: 679be527095ea60d5933b883ca276d8e593920ee URL: https://github.com/llvm/llvm-project/commit/679be527095ea60d5933b883ca276d8e593920ee DIFF: https://github.com/llvm/llvm-project/commit/679be527095ea60d5933b883ca276d8e593920ee.diff LOG: [Cl

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/109994 >From 012465670c63c3283a42a275cf3e5be0c5ffe9f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 25 Sep 2024 16:42:55 +0200 Subject: [PATCH] [clang][docs] Add documentation for APValue con

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread Timm Baeder via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] [clang][bytecode] Protect ia32_{lzcnt,tzcnt} against non-integers (PR #110699)

2024-10-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e1e788f - [clang][bytecode] Protect ia32_{lzcnt,tzcnt} against non-integers (#110699)

2024-10-01 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-02T05:44:54+02:00 New Revision: e1e788f423b5c780c40912ab102b0a3c4b92b9de URL: https://github.com/llvm/llvm-project/commit/e1e788f423b5c780c40912ab102b0a3c4b92b9de DIFF: https://github.com/llvm/llvm-project/commit/e1e788f423b5c780c40912ab102b0a3c4b92b9de.diff L

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-10-01 Thread via cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464 >From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001 From: awson Date: Mon, 24 Jun 2024 10:34:51 +0300 Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early. --- clang/lib/Se

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-10-01 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 7ea9d3dbb6ff74ca3f7f9b9a0c589e4a0a3366f2 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH 1/2] Add Clang attribute to ensure that fields are

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/7] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/6] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/108570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Thank you so much for your quick review! However, it seems the current CI is > blocked by the issues mentioned in #110783 :( I wouldn't be worried about that for a simple change like this, you can go ahead and merge. https://github.com/llvm/llvm-project/pull/110773 _

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/5] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
c8ef wrote: Thank you so much for your quick review! However, it seems the current CI is blocked by the issues mentioned in #110783 :( https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -1,8 +1,14 @@ ;; Ensure __llvm_gcov_(writeout|reset|init) have !kcfi_type with KCFI. ; RUN: mkdir -p %t && cd %t -; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s +; RUN: opt < %s -S -passes=insert-gcov-profiling \ +; RUN: -mtriple=x86_64-unknown-linux-gnu | F

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -914,6 +918,7 @@ bool GCOVProfiler::emitProfileNotes( GlobalVariable *Counters = new GlobalVariable( *M, CounterTy, false, GlobalValue::InternalLinkage, Constant::getNullValue(CounterTy), "__llvm_gcov_ctr"); +Counters->setSection("__ll

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -2962,13 +2964,34 @@ void PPCAIXAsmPrinter::emitPGORefs(Module &M) { } } +void PPCAIXAsmPrinter::emitGCOVRefs() { + if (!OutContext.hasXCOFFSection( + "__llvm_gcov_ctr_section", + XCOFF::CsectProperties(XCOFF::XMC_RW, XCOFF::XTY_SD))) +return; + +

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -1,7 +1,13 @@ ; RUN: mkdir -p %t && cd %t -; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s +; RUN: opt < %s -S -passes=insert-gcov-profiling \ +; RUN: -mtriple=x86_64-unknown-linux-gnu | FileCheck \ +; RUN: --check-prefixes=CHECK,CHECK-ELF %s

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -781,6 +798,9 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure, #define INSTR_PROF_COVNAME_COFF ".lcovn" #define INSTR_PROF_ORDERFILE_COFF ".lorderfile$M" +// TODO: Placeholder for Windows. We need to revise when we upstream this. hubert-reinte

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -2962,13 +2964,34 @@ void PPCAIXAsmPrinter::emitPGORefs(Module &M) { } } +void PPCAIXAsmPrinter::emitGCOVRefs() { + if (!OutContext.hasXCOFFSection( + "__llvm_gcov_ctr_section", + XCOFF::CsectProperties(XCOFF::XMC_RW, XCOFF::XTY_SD))) +return; + +

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -1,9 +1,15 @@ ;; Ensure __llvm_gcov_(writeout|reset|init) have the correct !kcfi_type ;; with integer normalization. ; RUN: mkdir -p %t && cd %t -; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s +; RUN: opt < %s -S -passes=insert-gcov-profiling \ +; RUN: -mtr

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -781,6 +798,9 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure, #define INSTR_PROF_COVNAME_COFF ".lcovn" #define INSTR_PROF_ORDERFILE_COFF ".lorderfile$M" +// TODO: Placeholder for Windows. We need to revise when we upstream this. hubert-reinte

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/110638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/4] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: > But IIUC, the diagnostic message change from this PR might be unintentional. > The expected error message in > [793ded7](https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765) > doesn't align to the error message from other tests in the same file.

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (c8ef) Changes This patch is a follow-up to #109831. In the discussion, we agreed that having parameter checks scattered across different areas isn't ideal. Therefore, I suggest merging the check from #88974 into the void parameter

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
c8ef wrote: CC @zyn0217 @mizvekov @cor3ntin https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef ready_for_review https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the 'requires' expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/109994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread Peilin Ye via cfe-commits
peilin-ye wrote: Hi @yonghong-song, No worries, and thanks for taking a look at this! > So far, I suggest to stick to cpu v4. I see, I can do that. > is it possible to add acquire/release support in BPF_ATOMIC? We might want to > reserve BPFModelModifier 7 for future use. Sounds good, that

[clang] [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (PR #110780)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110780.diff 1 Files Affected: - (modified) clang/include/module.modulemap (+1) ``diff diff --git a/clang/include/module.modulemap b/

[clang] [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (PR #110780)

2024-10-01 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai created https://github.com/llvm/llvm-project/pull/110780 None >From 030597a499d59b860cd14a6e5ba69b93a4b30290 Mon Sep 17 00:00:00 2001 From: Volodymyr Sapsai Date: Tue, 1 Oct 2024 18:46:04 -0700 Subject: [PATCH] [Modules] Mark CFProtectionOptions.def as a textual head

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Brian Cain via cfe-commits
https://github.com/androm3da updated https://github.com/llvm/llvm-project/pull/98712 >From 8fab99299900ef7312dc0503d829bae99d67cd60 Mon Sep 17 00:00:00 2001 From: Brian Cain Date: Fri, 12 Jul 2024 21:34:56 -0700 Subject: [PATCH] [cmake] Add hexagon-linux cmake cache files These can be used to

[clang] Draft (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110773 >From 59c8706f4bb83228fb476d3205d96f767080a0fc Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 2 Oct 2024 08:54:59 +0800 Subject: [PATCH 1/2] this diagose --- clang/lib/Parse/ParseDecl.cpp | 15 +-- cl

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Brian Cain via cfe-commits
@@ -0,0 +1,25 @@ + androm3da wrote: Absolutely. That's been the status quo and this PR on its own can't change that. The intent of this pull req is to allow anyone to build a toolchain for targeting hexagon (of which libc++, libc++abi, libunwind are a part).

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: Unfortunately, I didn't see your revert, and my pull didn't show any changes from main before I quickly committed the test change. So my test change would also break the build with your revert. So I reverted the test change just now! Revert: 5d308af894ccc3f7a288d6abd6f9097b4cbc8

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
zeroomega wrote: Looks like https://github.com/llvm/llvm-project/pull/108999 broke the check bots. https://github.com/llvm/llvm-project/pull/110777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: Test fix has re-landed: fea18afeed39fe4435d67eee1834f0f34b23013d. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fea18af - Fix failing test caused by b70d327

2024-10-01 Thread Tex Riddell via cfe-commits
Author: Tex Riddell Date: 2024-10-01T18:26:05-07:00 New Revision: fea18afeed39fe4435d67eee1834f0f34b23013d URL: https://github.com/llvm/llvm-project/commit/fea18afeed39fe4435d67eee1834f0f34b23013d DIFF: https://github.com/llvm/llvm-project/commit/fea18afeed39fe4435d67eee1834f0f34b23013d.diff L

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread via cfe-commits
zeroomega wrote: But IIUC, the diagnostic message change from this PR might be unintentional. The expected error message in 793ded7d0b7f1407636a98007f83074b8dd5f765 doesn't align to the error message from other tests in the same file. Should that be addressed? https://github.com/llvm/llvm-pro

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread via cfe-commits
zeroomega wrote: > Oh dang. That's why I didn't see an update. Because the revert wasn't pushed > to llvm/main, it was a revert on another repo. Looks like I could re-apply > the test fix again unless you're planning on doing a revert on llvm/main. Yes, I was testing the revert by pushing int

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: I just pushed a fix for the test: https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765 https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] Draft (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110773 >From 59c8706f4bb83228fb476d3205d96f767080a0fc Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 2 Oct 2024 08:54:59 +0800 Subject: [PATCH 1/2] this diagose --- clang/lib/Parse/ParseDecl.cpp | 15 +-- cl

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: Oh dang. That's why I didn't see an update. Because the revert wasn't pushed to llvm/main, it was a revert on another repo. Looks like I could re-apply the test fix again unless you're planning on doing a revert on llvm/main. https://github.com/llvm/llvm-project/pull/110198 ___

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Haowei (zeroomega) Changes This patch fixes an issue when test runner cannot find libwind library when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used. --- Full diff: https://github.com/llvm/llvm-project/pull/110777.diff 1 Files Affected

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
zeroomega wrote: Test run on our downstream bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-linux-x64/b8735236964550803665/overview This patch should address the build failure introduced in PR #110171 https://github.com/llvm/llvm-project/pull/110777 ___

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/110777 This patch fixes an issue when test runner cannot find libwind library when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used. >From c8d071ba2bc9dae14676304dc6a221319527ffe0 Mon Sep 17 00:00:00 2001 From: Haowei Wu

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: You should be able to re-land your change if you add the test fix to it. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-10-01 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/91101 >From 74e64cd80956d599548041d25e4fdfd1cd1c8d68 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Sat, 4 May 2024 18:12:34 -0500 Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter attrib

[clang] 5d308af - Revert "Fix failing test caused by b70d327"

2024-10-01 Thread Tex Riddell via cfe-commits
Author: Tex Riddell Date: 2024-10-01T18:11:20-07:00 New Revision: 5d308af894ccc3f7a288d6abd6f9097b4cbc8cf4 URL: https://github.com/llvm/llvm-project/commit/5d308af894ccc3f7a288d6abd6f9097b4cbc8cf4 DIFF: https://github.com/llvm/llvm-project/commit/5d308af894ccc3f7a288d6abd6f9097b4cbc8cf4.diff L

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
francisvm wrote: Thank you @tex3d, sorry about that! https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 793ded7 - Fix failing test caused by b70d327

2024-10-01 Thread Tex Riddell via cfe-commits
Author: Tex Riddell Date: 2024-10-01T18:05:05-07:00 New Revision: 793ded7d0b7f1407636a98007f83074b8dd5f765 URL: https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765 DIFF: https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765.diff L

[clang] Draft (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/110773 None >From 59c8706f4bb83228fb476d3205d96f767080a0fc Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 2 Oct 2024 08:54:59 +0800 Subject: [PATCH] this diagose --- clang/lib/Parse/ParseDecl.cpp | 15 +--

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread Peilin Ye via cfe-commits
@@ -522,6 +526,28 @@ let Predicates = [BPFNoALU32] in { } def STD : STOREi64; +class relaxed_store + : PatFrag<(ops node:$val, node:$ptr), (base node:$val, node:$ptr)> { + let IsAtomic = 1; + let IsAtomicOrderingReleaseOrStronger = 0; +} + +class releasing_store + : PatFra

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks check-clang: http://45.33.8.238/linux/149333/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@list

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: @francisvm This changed diagnostics, but didn't update all the affected tests. See: https://github.com/llvm/llvm-project/pull/110187#issuecomment-2387260975 https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cf

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: No worries https://github.com/llvm/llvm-project/pull/110487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-testing-tools Author: Henrik G. Olsson (hnrklssn) Changes Reverts llvm/llvm-project#108425 --- Full diff: https://github.com/llvm/llvm-project/pull/110772.diff 9 Files Affected: - (modified) clang/test/lit.cfg.py (-10) - (modified) llvm/docs/Command

[clang] Allow tag-based API notes on anonymous tag decls with typedef names (PR #110768)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Gregor (DougGregor) Changes It is common practice in C to declare anonymous tags that are immediately given a typedef name, e.g., typedef enum { ... } MyType; At present, one can only express API notes on the typedef. However, t

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
bwendling wrote: > @bwendling I think you accidentally compiled the wrong branch. Looks like > that is in `builtin_get_counted_by`, but this PR is in > `bdos-member-expr-error` Yeah, sorry about that. https://github.com/llvm/llvm-project/pull/110487 ___

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: @bwendling I think you accidentally compiled the wrong branch. Looks like that is in `builtin_get_counted_by`, but this PR is in `bdos-member-expr-error` https://github.com/llvm/llvm-project/pull/110487 ___ cfe-commits mailing list cfe-co

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM overall; I just have some minor comments https://github.com/llvm/llvm-project/pull/109994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] e495231 - Revert "[Utils] Add new --update-tests flag to llvm-lit" (#110772)

2024-10-01 Thread via cfe-commits
Author: Henrik G. Olsson Date: 2024-10-01T17:14:50-07:00 New Revision: e495231238b86ae2a3c7bb5f94634c19ca2af19a URL: https://github.com/llvm/llvm-project/commit/e495231238b86ae2a3c7bb5f94634c19ca2af19a DIFF: https://github.com/llvm/llvm-project/commit/e495231238b86ae2a3c7bb5f94634c19ca2af19a.di

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Mircea Trofin via cfe-commits
https://github.com/mtrofin edited https://github.com/llvm/llvm-project/pull/109837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: Interesting. You compiled with `-O2`, I compiled without optimization. When I compile it with `-O2`, I now get `0`. I've uploaded a gist with the disassembly generated with ``` clang -mllvm --x86-asm-syntax=intel -S test.c -o ./test-no-optimize.S ``` and ``` clang -O2 -mllvm --x86-

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Mircea Trofin via cfe-commits
@@ -1784,6 +1784,12 @@ defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", PosFlag, NegFlag>; +def fprofile_generate_cold_function_coverage : Flag<["-"], "fprofile-generate-cold-function-coverage">, mtrofin wrote: I meant, why not jus

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
bwendling wrote: > > I reverted my last commit. This leaves the original patch, which seems to > > work. @efriedma-quic, would you be okay with this patch while I work to > > improve the code in follow-up? > > The original (and current) patch in this PR still introduces a regression. So > it

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrik G. Olsson (hnrklssn) Changes Reverts llvm/llvm-project#108425 --- Full diff: https://github.com/llvm/llvm-project/pull/110772.diff 9 Files Affected: - (modified) clang/test/lit.cfg.py (-10) - (modified) llvm/docs/CommandGuide/li

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-10-01 Thread via cfe-commits
zeroomega wrote: > Thanks for the analysis. Per-target runtime dir strikes again! That setting > keeps on creating issues (by no fault of its own) because it's not the > default. > > Can we do something like this instead, then? > > ``` > config.substitutions.append(('%{lib}', > '@LIBUNWIND_T

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn closed https://github.com/llvm/llvm-project/pull/110772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn created https://github.com/llvm/llvm-project/pull/110772 Reverts llvm/llvm-project#108425 >From 133d368b16d11e44bc3fca92a042cf5ad0ce8dd1 Mon Sep 17 00:00:00 2001 From: "Henrik G. Olsson" Date: Tue, 1 Oct 2024 17:14:31 -0700 Subject: [PATCH] Revert "[Utils] Add new -

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/109994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >