[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-09-17 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/90933 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/4] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib/

[clang] [llvm] Thin4 (PR #109081)

2024-09-17 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/109081 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/4] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-17 Thread Piyou Chen via cfe-commits
@@ -11027,13 +11029,27 @@ static bool CheckMultiVersionValue(Sema &S, const FunctionDecl *FD) { } if (TVA) { -llvm::SmallVector Feats; -TVA->getFeatures(Feats); -for (const auto &Feat : Feats) { - if (!TargetInfo.validateCpuSupports(Feat)) { -S.Di

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 MOVZXC new Instructions. (PR #108537)

2024-09-17 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/108537 >From d06ba3b08ddf7282da9e53705a4ca9b27f0c1c4d Mon Sep 17 00:00:00 2001 From: mattarde Date: Fri, 13 Sep 2024 03:26:14 -0700 Subject: [PATCH 1/6] update clr --- clang/lib/Headers/CMakeLists.txt

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-17 Thread Piyou Chen via cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/99040 >From 54b5d6833a52271dfd1ca3912d5d9e886b1970c2 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Tue, 19 Mar 2024 02:02:35 -0700 Subject: [PATCH 1/5] [RISCV][FMV] Support target_version --- clang/lib/AST/ASTContext.c

[clang] [analyzer] Indicate UnarySymExpr is not supported by Z3 (PR #108900)

2024-09-17 Thread Mikael Holmén via cfe-commits
@@ -278,6 +278,13 @@ class SMTConstraintManager : public clang::ento::SimpleConstraintManager { if (const SymbolCast *SC = dyn_cast(Sym)) return canReasonAbout(SVB.makeSymbolVal(SC->getOperand())); +// If a UnarySymExpr is encountered, the Z3 +// wrapper doe

[clang] [compiler-rt] [Clang][compiler-rt][UBSan] Remove `BuiltinCheckKind` (PR #109088)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Yingwei Zheng (dtcxzyw) Changes This patch removes unneeded enum `BuiltinCheckKind` and fixes a copy-paste mistake in `__ubsan_handle_invalid_builtin`. Address comment https://github.com/llvm/llvm-project/pull/104741#discussion_r

[clang] [compiler-rt] [Clang][compiler-rt][UBSan] Remove `BuiltinCheckKind` (PR #109088)

2024-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/109088 This patch removes unneeded enum `BuiltinCheckKind` and fixes a copy-paste mistake in `__ubsan_handle_invalid_builtin`. Address comment https://github.com/llvm/llvm-project/pull/104741#discussion_r1764323722.

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-17 Thread via cfe-commits
https://github.com/ofAlpaca updated https://github.com/llvm/llvm-project/pull/108142 >From efcf875af403831bbd4d472a9a3a9fbff4438753 Mon Sep 17 00:00:00 2001 From: ofAlpaca Date: Wed, 11 Sep 2024 11:24:55 +0800 Subject: [PATCH 1/2] [clang] Fix TemplatedDecl being nullptr and cause crash --- cl

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-17 Thread via cfe-commits
https://github.com/ofAlpaca updated https://github.com/llvm/llvm-project/pull/108142 >From efcf875af403831bbd4d472a9a3a9fbff4438753 Mon Sep 17 00:00:00 2001 From: ofAlpaca Date: Wed, 11 Sep 2024 11:24:55 +0800 Subject: [PATCH] [clang] Fix TemplatedDecl being nullptr and cause crash --- clang/

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-17 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/108142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Propagate elide safe context through [[clang::coro_await_elidable_argument]] (PR #108474)

2024-09-17 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 closed https://github.com/llvm/llvm-project/pull/108474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e1b40dc - [Clang] Propagate elide safe context through [[clang::coro_await_elidable_argument]] (#108474)

2024-09-17 Thread via cfe-commits
Author: Yuxuan Chen Date: 2024-09-17T22:58:21-07:00 New Revision: e1b40dc06373de1bb8535d543a3887646367dd8d URL: https://github.com/llvm/llvm-project/commit/e1b40dc06373de1bb8535d543a3887646367dd8d DIFF: https://github.com/llvm/llvm-project/commit/e1b40dc06373de1bb8535d543a3887646367dd8d.diff L

[clang] Fix evaluation of the unsigned enumeration values, #108766 (PR #108769)

2024-09-17 Thread Dmitry Fursov via cfe-commits
fursov wrote: @DeinAlptraum, thank you for the review. The findings are fixed now. Could you say if the fix to be backported to other relelases, like 18.x or 19rc? If yes, how this is done? https://github.com/llvm/llvm-project/pull/108769 ___ cfe-comm

[clang] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (PR #108656)

2024-09-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/6407 Here is the relevan

[clang] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (PR #108656)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/108656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fd21b79 - [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (#108656)

2024-09-17 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-09-17T22:23:27-07:00 New Revision: fd21b7911fbdddc80db2d3971ff10ee70a49b7e3 URL: https://github.com/llvm/llvm-project/commit/fd21b7911fbdddc80db2d3971ff10ee70a49b7e3 DIFF: https://github.com/llvm/llvm-project/commit/fd21b7911fbdddc80db2d3971ff10ee70a49b7e3.diff

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-17 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Regarding test case 2, that further reduces to: ```C++ template class Q {}; template void F(Q); template void F(Q) = delete; void test() { F(Q()); } ``` The problem is that we consider the parenthesized expression significant in terms of forming a distinct type. You can s

[clang] [HLSL][NFC] Remove RegisterBindingFlags struct (PR #108924)

2024-09-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/108924 >From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 16 Sep 2024 20:54:23 -0700 Subject: [PATCH 1/5] [HLSL][NFC] Remove RegisterBindingFlags struct When diagnosin

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-09-17 Thread Nuri Amari via cfe-commits
@@ -1558,6 +1562,60 @@ class InProcessThinBackend : public ThinBackendProc { return BackendThreadPool.getMaxConcurrency(); } }; + +/// This Backend will run ThinBackend process but throw away all the output from +/// the codegen. This class facilitates the first codegen

[clang] [clang-format] Handle C-style cast of qualified type (PR #108929)

2024-09-17 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/108929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4d18ce1 - [clang-format] Handle C-style cast of qualified type (#108929)

2024-09-17 Thread via cfe-commits
Author: Owen Pan Date: 2024-09-17T21:19:56-07:00 New Revision: 4d18ce1dd2640829c3ad9cbb31e6ff92e2e29438 URL: https://github.com/llvm/llvm-project/commit/4d18ce1dd2640829c3ad9cbb31e6ff92e2e29438 DIFF: https://github.com/llvm/llvm-project/commit/4d18ce1dd2640829c3ad9cbb31e6ff92e2e29438.diff LOG:

[clang] [clang-format] Fix a bug in SpacesInParens InConditionalStatements (PR #108797)

2024-09-17 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/108797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a8dd8f6 - [clang-format] Fix a bug in SpacesInParens InConditionalStatements (#108797)

2024-09-17 Thread via cfe-commits
Author: Owen Pan Date: 2024-09-17T21:17:30-07:00 New Revision: a8dd8f6302e5fd405de7ed2bbfe195f305279bf8 URL: https://github.com/llvm/llvm-project/commit/a8dd8f6302e5fd405de7ed2bbfe195f305279bf8 DIFF: https://github.com/llvm/llvm-project/commit/a8dd8f6302e5fd405de7ed2bbfe195f305279bf8.diff LOG:

[clang] [clang-format] Reimplement InsertNewlineAtEOF (PR #108513)

2024-09-17 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/108513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7153a4b - [clang-format] Reimplement InsertNewlineAtEOF (#108513)

2024-09-17 Thread via cfe-commits
Author: Owen Pan Date: 2024-09-17T21:16:20-07:00 New Revision: 7153a4bbf6d46e58ce32d59220515c5ab9f35691 URL: https://github.com/llvm/llvm-project/commit/7153a4bbf6d46e58ce32d59220515c5ab9f35691 DIFF: https://github.com/llvm/llvm-project/commit/7153a4bbf6d46e58ce32d59220515c5ab9f35691.diff LOG:

[clang] ddbe6c4 - [clang-format[NFC] Clean up FormatTestBase and Proto/TextProto tests (#108334)

2024-09-17 Thread via cfe-commits
Author: Owen Pan Date: 2024-09-17T21:15:44-07:00 New Revision: ddbe6c412bab3fe7a3ffaf6f42c49849a518b4c6 URL: https://github.com/llvm/llvm-project/commit/ddbe6c412bab3fe7a3ffaf6f42c49849a518b4c6 DIFF: https://github.com/llvm/llvm-project/commit/ddbe6c412bab3fe7a3ffaf6f42c49849a518b4c6.diff LOG:

[clang] [clang-format[NFC] Clean up FormatTestBase and Proto/TextProto tests (PR #108334)

2024-09-17 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/108334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Thin4 (PR #109081)

2024-09-17 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com created https://github.com/llvm/llvm-project/pull/109081 None >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/3] [ThinLTO][NFC] Prep for two-codegen rounds --- cla

[clang] [clang-tools-extra] [llvm] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2024-09-17 Thread Matheus Izvekov via cfe-commits
@@ -309,7 +309,10 @@ enum BuiltinTemplateKind : int { BTK__make_integer_seq, /// This names the __type_pack_element BuiltinTemplateDecl. - BTK__type_pack_element + BTK__type_pack_element, + + /// This names the __type_list_dedup BuiltinTemplateDecl. + BTK__type_list_de

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2024-09-17 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. This looks good to me, thanks! https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-09-17 Thread Nuri Amari via cfe-commits
@@ -1558,6 +1562,60 @@ class InProcessThinBackend : public ThinBackendProc { return BackendThreadPool.getMaxConcurrency(); } }; + +/// This Backend will run ThinBackend process but throw away all the output from +/// the codegen. This class facilitates the first codegen

[clang] [clang-tools-extra] [llvm] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2024-09-17 Thread Matheus Izvekov via cfe-commits
@@ -3158,6 +3161,33 @@ checkBuiltinTemplateIdType(Sema &SemaRef, BuiltinTemplateDecl *BTD, int64_t N = Index.getExtValue(); return Ts.getPackAsArray()[N].getAsType(); } + case BTK__type_pack_dedup: { +assert(Converted.size() == 2 && "__builtin_type_pack_dedup sh

[clang] [clang-tools-extra] [llvm] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2024-09-17 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov requested changes to this pull request. https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KCFI][NFC] Rename the !kcfi_type Function metadata to !cfi_type (PR #109080)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Ming-Yi Lai (mylai-mtk) Changes According to the comments in ;, which introduces the KCFI sanitizer, the data structures of KCFI should avoid embedding the term "kcfi" in their names so that later

[clang] [llvm] [KCFI][NFC] Rename the !kcfi_type Function metadata to !cfi_type (PR #109080)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ming-Yi Lai (mylai-mtk) Changes According to the comments in ;, which introduces the KCFI sanitizer, the data structures of KCFI should avoid embedding the term "kcfi" in their names so that later/new CFI

[clang] [llvm] [KCFI][NFC] Rename the !kcfi_type Function metadata to !cfi_type (PR #109080)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-backend-x86 Author: Ming-Yi Lai (mylai-mtk) Changes According to the comments in ;, which introduces the KCFI sanitizer, the data structures of KCFI should avoid embedding the term

[clang] [llvm] [KCFI][NFC] Rename the !kcfi_type Function metadata to !cfi_type (PR #109080)

2024-09-17 Thread Ming-Yi Lai via cfe-commits
https://github.com/mylai-mtk created https://github.com/llvm/llvm-project/pull/109080 According to the comments in , which introduces the KCFI sanitizer, the data structures of KCFI should avoid embedding the term "kcfi" in their names so that later/new CFI me

[clang] [clang-tools-extra] [llvm] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2024-09-17 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2024-09-17 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov commented: Thanks for working on this problem! I think the current approach is limited in ABI stability, we could broaden the usability here by designing this builtin so it produces a type list which is unique per set of types (order independent). I had a chat with

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2ae968a0d9fb61606b020e898d884c82dd0ed8b5 2e6275d645485c5ae32754a753ed99bcfc507dba --e

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-17 Thread Mainak Sil via cfe-commits
MainakSil wrote: Check Please https://github.com/llvm/llvm-project/pull/108804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-17 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108804 >From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Mon, 16 Sep 2024 09:50:33 +0530 Subject: [PATCH 1/7] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOp

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-17 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108804 >From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Mon, 16 Sep 2024 09:50:33 +0530 Subject: [PATCH 1/6] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOp

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-17 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108804 >From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Mon, 16 Sep 2024 09:50:33 +0530 Subject: [PATCH 1/5] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOp

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-17 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108804 >From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Mon, 16 Sep 2024 09:50:33 +0530 Subject: [PATCH 1/4] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOp

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-09-17 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @sam-mccall @kadircet @HighCommander4 ping https://github.com/llvm/llvm-project/pull/106683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-17 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @AaronBallman @cor3ntin @erichkeane @zygoloid @iains ping https://github.com/llvm/llvm-project/pull/107194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] generate hlsl.wavesize attribute (PR #107176)

2024-09-17 Thread Xiang Li via cfe-commits
https://github.com/python3kgae closed https://github.com/llvm/llvm-project/pull/107176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0f77bdd - [HLSL] generate hlsl.wavesize attribute (#107176)

2024-09-17 Thread via cfe-commits
Author: Xiang Li Date: 2024-09-17T23:00:13-04:00 New Revision: 0f77bdd2c9bed6db6c2b9e10e05b5e99fde13d66 URL: https://github.com/llvm/llvm-project/commit/0f77bdd2c9bed6db6c2b9e10e05b5e99fde13d66 DIFF: https://github.com/llvm/llvm-project/commit/0f77bdd2c9bed6db6c2b9e10e05b5e99fde13d66.diff LOG:

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-17 Thread Piyou Chen via cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/99040 >From 54b5d6833a52271dfd1ca3912d5d9e886b1970c2 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Tue, 19 Mar 2024 02:02:35 -0700 Subject: [PATCH 1/4] [RISCV][FMV] Support target_version --- clang/lib/AST/ASTContext.c

[clang] [compiler-rt] [UBSan] Diagnose assumption violation (PR #104741)

2024-09-17 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Thanks! LGTM in general. https://github.com/llvm/llvm-project/pull/104741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [UBSan] Diagnose assumption violation (PR #104741)

2024-09-17 Thread Vitaly Buka via cfe-commits
@@ -633,9 +633,11 @@ static void handleInvalidBuiltin(InvalidBuiltinData *Data, ReportOptions Opts) { ScopedReport R(Opts, Loc, ET); - Diag(Loc, DL_Error, ET, - "passing zero to %0, which is not a valid argument") -<< ((Data->Kind == BCK_CTZPassedZero) ? "ctz()"

[clang] [compiler-rt] [UBSan] Diagnose assumption violation (PR #104741)

2024-09-17 Thread Vitaly Buka via cfe-commits
@@ -1996,16 +1996,21 @@ struct CallObjCArcUse final : EHScopeStack::Cleanup { Value *CodeGenFunction::EmitCheckedArgForBuiltin(const Expr *E, vitalybuka wrote: TO my taste, I'd rather forked EmitCheckedArgForBuiltin into a version for Assume very little code

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108786 >From a4187bb5ca769ae3eac4dfe6ec57642640bb6e74 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 17 Sep 2024 21:47:45 -0400 Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to represent flat address spa

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-09-17 Thread Vitaly Buka via cfe-commits
@@ -48,6 +49,63 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-09-17 Thread Vitaly Buka via cfe-commits
@@ -1,7 +1,28 @@ +// Verify ubsan doesn't emit checks for ignorelisted types +// RUN: echo "[{unsigned-integer-overflow,signed-integer-overflow}]" > %t-int.ignorelist +// RUN: echo "type:int" >> %t-int.ignorelist +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-int

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-09-17 Thread Vitaly Buka via cfe-commits
@@ -48,6 +49,63 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-09-17 Thread Vitaly Buka via cfe-commits
@@ -817,6 +817,37 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] 7046a9f - [C++20] [Modules] Treat in class defined member functions in language linkage as implicitly inline

2024-09-17 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-09-18T10:13:06+08:00 New Revision: 7046a9fb05f65f4699a2e88abbcb7dad8a21db2d URL: https://github.com/llvm/llvm-project/commit/7046a9fb05f65f4699a2e88abbcb7dad8a21db2d DIFF: https://github.com/llvm/llvm-project/commit/7046a9fb05f65f4699a2e88abbcb7dad8a21db2d.diff LO

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Shilei Tian via cfe-commits
@@ -245,6 +246,7 @@ class DataLayout { unsigned getDefaultGlobalsAddressSpace() const { return DefaultGlobalsAddrSpace; } + unsigned getFlatAddressSpace() const { return FlatAddressSpace; } shiltian wrote: I added an enum such that all the checks can

[clang] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (PR #108656)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/108656 >From e86f101c5cd87db597c5fc8ab017b20adba98284 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 13 Sep 2024 15:19:45 -0700 Subject: [PATCH 1/2] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still ge

[clang] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (PR #108656)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
@@ -119,6 +119,11 @@ template ensureOnMainThread([this] { delete static_cast(this); }); +} else if constexpr (destructionThread == DestructionThread::MainRunLoop) { +auto deleteThis = [this] { rniwa w

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108786 >From feadf29036d9157fec452343cf768a6b78d018e5 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 17 Sep 2024 21:47:45 -0400 Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to represent flat address spa

[clang] [Clang] Propagate elide safe context through [[clang::coro_await_elidable_argument]] (PR #108474)

2024-09-17 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. https://github.com/llvm/llvm-project/pull/108474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (PR #108656)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
@@ -84,13 +84,22 @@ class DerefFuncDeleteExprVisitor E = E->IgnoreParenCasts(); if (auto *TempE = dyn_cast(E)) E = TempE->getSubExpr(); +E = E->IgnoreParenCasts(); +if (auto *Ref = dyn_cast(E)) { + if (auto *Decl = Ref->getDecl()) { +if (auto

[clang] [webkit.RefCntblBaseVirtualDtor] ThreadSafeRefCounted still generates warnings (PR #108656)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
@@ -84,13 +84,22 @@ class DerefFuncDeleteExprVisitor E = E->IgnoreParenCasts(); if (auto *TempE = dyn_cast(E)) E = TempE->getSubExpr(); +E = E->IgnoreParenCasts(); +if (auto *Ref = dyn_cast(E)) { + if (auto *Decl = Ref->getDecl()) { +if (auto

[clang] [alpha.webkit.UncountedCallArgsChecker] Add support for Objective-C++ property access (PR #108669)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: > I'm also somewhat terrified of returning C++ objects from ObjC methods by > value, ever since I learned that when you call an ObjC method on a nil it > returns a _zero-initialized_ object without calling a constructor on it. Yikes. I didn't know that! https://github.com/llvm/ll

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: @efriedma-quic's comment resonates with me. At least all use cases that come to my mind right now are basically questions of the following form: 1) Can I transform a pointer lossless from from AS(A) to AS(B)? 2) Is AS(A) "better"/more specialized than AS(B)? 3) Give me the most

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108786 >From 89eb7686f8304b33a8cacb639ced6c229b70f6ea Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 17 Sep 2024 21:47:45 -0400 Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to represent flat address spa

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
yronglin wrote: Thanks for your review! https://github.com/llvm/llvm-project/pull/108949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Shilei Tian via cfe-commits
shiltian wrote: Thank all for the valuable input. I changed the wording in `LangRef.rst`. Hopefully it can make it more clear. https://github.com/llvm/llvm-project/pull/108786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-17 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108786 >From 2546b9cef422ab60f75dfc1321a097ae22415a82 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 15 Sep 2024 21:53:50 -0400 Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to represent flat address spa

[clang] [alpha.webkit.UncountedCallArgsChecker] Add support for Objective-C++ property access (PR #108669)

2024-09-17 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/108669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 33533ba - [alpha.webkit.UncountedCallArgsChecker] Add support for Objective-C++ property access (#108669)

2024-09-17 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-09-17T18:39:22-07:00 New Revision: 33533baf631a4c6ea9b04eb1dda0090f80d143c5 URL: https://github.com/llvm/llvm-project/commit/33533baf631a4c6ea9b04eb1dda0090f80d143c5 DIFF: https://github.com/llvm/llvm-project/commit/33533baf631a4c6ea9b04eb1dda0090f80d143c5.diff

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/108949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/108949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
@@ -1281,26 +1277,67 @@ bool Compiler::VisitVectorBinOp(const BinaryOperator *E) { const Expr *LHS = E->getLHS(); const Expr *RHS = E->getRHS(); const auto *VecTy = E->getType()->getAs(); + auto Op = E->isCompoundAssignmentOp() +? BinaryOperator::getOpFo

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
@@ -1371,10 +1455,27 @@ bool Compiler::VisitVectorBinOp(const BinaryOperator *E) { return false; } +// If we performed an integer promotion, we need to cast the compute result +// into result vector element type. +if (NeedIntPromot && +!this->e

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
@@ -1267,12 +1267,8 @@ bool Compiler::VisitVectorBinOp(const BinaryOperator *E) { assert(E->getLHS()->getType()->isVectorType()); assert(E->getRHS()->getType()->isVectorType()); - // FIXME: Current only support comparison binary operator, add support for - // other bina

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/108949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-17 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/108949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use canonical type for substitution which might be incomplete (PR #109065)

2024-09-17 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh approved this pull request. Looks good as a temporary fix. Thanks! https://github.com/llvm/llvm-project/pull/109065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-17 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > @alexfh #109065 Fixes test case 1. I can confirm that it also fixes the compilation error in the original code. https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] Reland "[Utils] add update-verify-tests.py" (#108630)" (PR #108658)

2024-09-17 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: > > But for clang -verify you have to add checkers for exactly the emitted > > diagnostics. No more or less. So the only real question is on which line to > > place them. > > I don't think it's that simple at least for some tests. We have tests that > run in `-verify` mode mul

[clang] [llvm] [clang][OpenMP] Prototype #1 of directive splitting (PR #108855)

2024-09-17 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: How many other (codegen) tests would this affect? https://github.com/llvm/llvm-project/pull/108855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] add qutation mark for C++ classes in warning message (PR #109068)

2024-09-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/109068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] add qutation mark for C++ classes in warning message (PR #109068)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109068.diff 10 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp (+5-5) - (modified) cla

[clang-tools-extra] [clang-tidy][NFC] add qutation mark for C++ classes in warning message (PR #109068)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109068.diff 10 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp (+5-5) - (modified) clang-tool

[clang-tools-extra] [clang-tidy][NFC] add qutation mark for C++ classes in warning message (PR #109068)

2024-09-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/109068 None >From 66be189c281db7a49c5238c2fe09df64842c1e25 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 17 Sep 2024 23:01:17 +0800 Subject: [PATCH] add quotation --- .../modernize/AvoidCArraysCheck.cpp

[clang] [HLSL][NFC] Remove RegisterBindingFlags struct (PR #108924)

2024-09-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/108924 >From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 16 Sep 2024 20:54:23 -0700 Subject: [PATCH 1/5] [HLSL][NFC] Remove RegisterBindingFlags struct When diagnosin

[clang] [HLSL][NFC] Remove RegisterBindingFlags struct (PR #108924)

2024-09-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/108924 >From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 16 Sep 2024 20:54:23 -0700 Subject: [PATCH 1/4] [HLSL][NFC] Remove RegisterBindingFlags struct When diagnosin

[clang-tools-extra] [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (PR #108555)

2024-09-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/108555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 785624b - [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (#108555)

2024-09-17 Thread via cfe-commits
Author: Congcong Cai Date: 2024-09-18T08:03:06+08:00 New Revision: 785624b28237bb75d4fa3b8e4219a5448b90eaac URL: https://github.com/llvm/llvm-project/commit/785624b28237bb75d4fa3b8e4219a5448b90eaac DIFF: https://github.com/llvm/llvm-project/commit/785624b28237bb75d4fa3b8e4219a5448b90eaac.diff

[clang] Reland "[Utils] add update-verify-tests.py" (#108630)" (PR #108658)

2024-09-17 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > That was always true, in the sense that there's nothing preventing the author > from doing the exact same thing: looking at the output from the clang -verify > failure and adding/removing expected diagnostics until it matches. In fact, > even without this script that is the mo

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-17 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: @alexfh https://github.com/llvm/llvm-project/pull/109065 Fixes test case 1. https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang] Use canonical type for substitution which might be incomplete (PR #109065)

2024-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes When checking deduction consistency, a substitution can be incomplete such that only sugar parts refer to non-deduced template parameters. This would not otherwise lead to an inconsistent deduction, so t

[clang] [clang] Use canonical type for substitution which might be incomplete (PR #109065)

2024-09-17 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/109065 When checking deduction consistency, a substitution can be incomplete such that only sugar parts refer to non-deduced template parameters. This would not otherwise lead to an inconsistent deduction, so this pa

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-17 Thread Sarah Spall via cfe-commits
https://github.com/spall updated https://github.com/llvm/llvm-project/pull/108121 >From ebb4078d485559f70d79d3b10dc9f4ce401a3261 Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Fri, 6 Sep 2024 21:03:05 + Subject: [PATCH 1/3] implement elementwise popcount to implement countbits --- clang

  1   2   3   4   5   >