https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/105976
>From 033d4003154440fb00c62c0e85fe3dac4af10d22 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sun, 25 Aug 2024 02:57:55 -0400
Subject: [PATCH] [clang][Sema] Fix particular operator overload crash
Fix
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nicolas van Kempen (nicovank)
Changes
Fix #104883.
Fix #104800.
Thanks @Endilll for the reduced reproducer. Bisection points to
0cb7e7ca0c864e052bf49978f3bcd667c9e16930 as the faulty commit, but nothing
there seems to indicate what the p
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/105976
Fix #104883.
Fix #104800.
Thanks @Endilll for the reduced reproducer. Bisection points to
0cb7e7ca0c864e052bf49978f3bcd667c9e16930 as the faulty commit, but nothing
there seems to indicate what the problem is
https://github.com/LYP951018 edited
https://github.com/llvm/llvm-project/pull/105953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`clang-aarch64-sve-vla-2stage` running on `linaro-g3-04` while building `clang`
at step 11 "build stage 2".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/41/builds/1495
Here is the relevant piece of
llvmbot wrote:
/pull-request llvm/llvm-project#105971
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick 0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-08-24T20:10:03-07:00
New Revision: 0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74
URL:
https://github.com/llvm/llvm-project/commit/0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74
DIFF:
https://github.com/llvm/llvm-project/commit/0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74.diff
LOG:
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/105969
Patch pulled from https://github.com/NixOS/nixpkgs/pull/336465
This PR removes `NO_DEFAULT_PATH` where possible, the flag prevents Nix from
building libclc correctly.
>From e8b910246d0c7c3d9fff994f71c6
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/66/builds/3083
Here is the relevant piece of the bu
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/102131
>From aa99ac433c9d383bfca732c19e5082a555f64c2d Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Tue, 6 Aug 2024 20:08:43 +0800
Subject: [PATCH 1/2] [Clang][Concepts] Fix the constraint equivalence checking
for
llvmbot wrote:
/pull-request llvm/llvm-project#105967
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick 6bc225e0630f28e83290a43c3d9b25b057fc815a
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-08-24T19:12:15-07:00
New Revision: 6bc225e0630f28e83290a43c3d9b25b057fc815a
URL:
https://github.com/llvm/llvm-project/commit/6bc225e0630f28e83290a43c3d9b25b057fc815a
DIFF:
https://github.com/llvm/llvm-project/commit/6bc225e0630f28e83290a43c3d9b25b057fc815a.diff
LOG:
@@ -5554,38 +5869,50 @@ FunctionTemplateDecl *Sema::getMoreSpecializedTemplate(
// "that is a member function with no expicit object argument".
// Otherwise the ordering rules for methods with expicit objet arguments
// against anything else make no sense.
-Shou
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/100692
>From f8fd471a954f5e304f3118df3236cf7ff4ef1020 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Wed, 24 Jul 2024 03:59:41 -0300
Subject: [PATCH] [clang] check deduction consistency when partial ordering
fu
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/104722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Max Winkler
Date: 2024-08-24T12:25:46-07:00
New Revision: 43b88851cefe68645aa59b1fccc8390a8a31f469
URL:
https://github.com/llvm/llvm-project/commit/43b88851cefe68645aa59b1fccc8390a8a31f469
DIFF:
https://github.com/llvm/llvm-project/commit/43b88851cefe68645aa59b1fccc8390a8a31f469.diff
L
https://github.com/rymiel approved this pull request.
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 08acc3f73b64bed578d18812a04015cb537c9c82
afdff4e15c518984206da5b7cdbe9b14bb1b3bea --e
https://github.com/LYP951018 edited
https://github.com/llvm/llvm-project/pull/105953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/LYP951018 edited
https://github.com/llvm/llvm-project/pull/105953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/LYP951018 created
https://github.com/llvm/llvm-project/pull/105953
## Code Changes:
- Currently, Clang requires instantiation to determine captures of a packs
(refer to 7bf8f6fa8ab123fe97ccd82d9a0ddff85505ee5f), but P0588 allows delayed
instantiation of `if constexpr` stat
https://github.com/rymiel approved this pull request.
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann converted_to_draft
https://github.com/llvm/llvm-project/pull/105738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nicovank wrote:
Added release note, rebased to trigger CI again.
FWIW I don't remember this happening on any of the ~3 machines I tested on
previously, and it only happens on interrupt, not normal execution. If you
think this should be backported, let me know if there is anything I can help
w
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/105724
>From 84535cd4386a7afee32353e07c020e59420e36ef Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 24 Aug 2024 12:59:13 -0400
Subject: [PATCH] [clang-tidy][run-clang-tidy] Fix minor shutdown noise
On
https://github.com/5chmidti approved this pull request.
Because the commit with asyncio is in llvm-19, could you please add a release
note for this fix?
@PiotrZSL wdyt about backporting this? 19.1.0 may be too late, but for 19.2.0
then
https://github.com/llvm/llvm-project/pull/105724
@@ -116,6 +116,10 @@ Changes in existing checks
` check to
remove `->`, when redundant `get()` is removed.
+- Fixed :doc:`cppcoreguidelines-pro-type-union-access
+ ` check to
+ report location even when member location is not valid.
ksromanov wrote:
Tha
https://github.com/ksromanov updated
https://github.com/llvm/llvm-project/pull/104540
>From 31ed1cf97be643b3a6c9a05d4e461789c37e2408 Mon Sep 17 00:00:00 2001
From: Konstantin Romanov
Date: Fri, 9 Aug 2024 23:40:07 -0400
Subject: [PATCH 1/6] Workaround for cppcoreguidelines-pro-type-union-access
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/95235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -144,8 +144,13 @@ getQualification(ASTContext &Context, const DeclContext
*DestContext,
// since we stored inner-most parent first.
std::string Result;
llvm::raw_string_ostream OS(Result);
- for (const auto *Parent : llvm::reverse(Parents))
+ for (const auto *Parent
@@ -128,7 +128,27 @@ getFunctionSourceAfterReplacements(const FunctionDecl *FD,
SM.getBufferData(SM.getMainFileID()), Replacements);
if (!QualifiedFunc)
return QualifiedFunc.takeError();
- return QualifiedFunc->substr(FuncBegin, FuncEnd - FuncBegin + 1);
+
+ std::
@@ -407,10 +431,21 @@ class DefineOutline : public Tweak {
return !SameFile;
}
-// Bail out in templated classes, as it is hard to spell the class name,
-// i.e if the template parameter is unnamed.
-if (MD->getParent()->isTemplated())
- return false
@@ -407,10 +431,21 @@ class DefineOutline : public Tweak {
return !SameFile;
}
-// Bail out in templated classes, as it is hard to spell the class name,
-// i.e if the template parameter is unnamed.
-if (MD->getParent()->isTemplated())
- return false
@@ -212,9 +232,13 @@ getFunctionSourceCode(const FunctionDecl *FD, const
DeclContext *TargetContext,
}
}
const NamedDecl *ND = Ref.Targets.front();
-const std::string Qualifier =
+std::string Qualifier =
getQualification(A
https://github.com/5chmidti commented:
>From a functionality standpoint, this looks good to me. I noted some small
>things in the code, and this is also missing a release not entry.
https://github.com/llvm/llvm-project/pull/95235
___
cfe-commits maili
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/95235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann updated
https://github.com/llvm/llvm-project/pull/105738
>From 57192d52acfdab7f253da013b89cc2f7cef037a3 Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Thu, 22 Aug 2024 09:44:56 -0700
Subject: [PATCH] [Clang] Match MSVC handling of duplicate header search paths
@@ -116,6 +116,10 @@ Changes in existing checks
` check to
remove `->`, when redundant `get()` is removed.
+- Fixed :doc:`cppcoreguidelines-pro-type-union-access
+ ` check to
+ report location even when member location is not valid.
5chmidti wrote:
nit:
https://github.com/5chmidti approved this pull request.
https://github.com/llvm/llvm-project/pull/104540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ksromanov updated
https://github.com/llvm/llvm-project/pull/104540
>From 31ed1cf97be643b3a6c9a05d4e461789c37e2408 Mon Sep 17 00:00:00 2001
From: Konstantin Romanov
Date: Fri, 9 Aug 2024 23:40:07 -0400
Subject: [PATCH 1/5] Workaround for cppcoreguidelines-pro-type-union-access
ksromanov wrote:
> This is still missing a release note, see
Many thanks! This is my first PR to `llvm`, I didn't know about it, sorry.
https://github.com/llvm/llvm-project/pull/104540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
@@ -9,6 +9,7 @@
#include "TodoCommentCheck.h"
#include "clang/Frontend/CompilerInstance.h"
#include "clang/Lex/Preprocessor.h"
+#include
5chmidti wrote:
Please remove this unused include
https://github.com/llvm/llvm-project/pull/104868
__
@@ -24,3 +24,7 @@
// TODO(b/12345): find the holy grail
// TODO (b/12345): allow spaces before parentheses
// TODO(asdf) allow missing semicolon
+// TODO: bug 12345678 - Remove this after the 2047q4 compatibility window
expires.
+// TODO: example.com/my-design-doc - Manually f
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #105877.
---
Full diff: https://github.com/llvm/llvm-project/pull/105941.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+1-1)
- (modified) clang/unittests/Format/TokenAnn
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105941
Fixes #105877.
>From 28983f4532df55ee31fc366fb5a945594c0baf1a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 24 Aug 2024 07:32:08 -0700
Subject: [PATCH] [clang-format] Fix a misannotation of less/greater as
5chmidti wrote:
> for me oryginal version that used registerMatchers instead of visitor were
> way better, specially that there are matchers that could be used for this, or
> could be written.
We do have the `isDerivedFrom` matcher, actually.
> in most projects not many classes actually used
@@ -653,10 +686,12 @@ bool HasNameMatcher::matchesNodeFullSlow(const NamedDecl
&Node) const {
for (const StringRef Pattern : Names) {
if (Pattern.starts_with("::")) {
-if (FullName == Pattern)
+if (auto Result = consumePatternBack(Pattern, FullName);
https://github.com/5chmidti requested changes to this pull request.
I think it does make sense to add this wildcard. The motivation to skip regex
sounds like a good one, and it does make sense to special case templates
specifically. The implementation looks correct to me. Just some small things
@@ -638,6 +638,39 @@ bool HasNameMatcher::matchesNodeFullFast(const NamedDecl
&Node) const {
return Patterns.foundMatch(/*AllowFullyQualified=*/true);
}
+static std::optional consumePatternBack(StringRef Pattern,
+ StringRef
@@ -638,6 +638,39 @@ bool HasNameMatcher::matchesNodeFullFast(const NamedDecl
&Node) const {
return Patterns.foundMatch(/*AllowFullyQualified=*/true);
}
+static std::optional consumePatternBack(StringRef Pattern,
+ StringRef
@@ -638,6 +638,39 @@ bool HasNameMatcher::matchesNodeFullFast(const NamedDecl
&Node) const {
return Patterns.foundMatch(/*AllowFullyQualified=*/true);
}
+static std::optional consumePatternBack(StringRef Pattern,
+ StringRef
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/100349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti requested changes to this pull request.
This is still missing a release note, see
https://github.com/llvm/llvm-project/blob/40975da950c95124155b752cd683d945f7d203fd/clang-tools-extra/docs/ReleaseNotes.rst?plain=1#L104
for where to add it and how they look like
Funct
@@ -392,8 +402,16 @@ void ImplicitBoolConversionCheck::handleCastFromBool(
if (const auto *BoolLiteral =
dyn_cast(Cast->getSubExpr()->IgnoreParens())) {
-Diag << tooling::fixit::createReplacement(
-*Cast, getEquivalentForBoolLiteral(BoolLiteral, DestTyp
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/104882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti approved this pull request.
LGTM but with two nits
https://github.com/llvm/llvm-project/pull/104882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,6 +108,11 @@ Changes in existing checks
` check to
remove `->`, when reduntant `get()` is removed.
+- Improved :doc:`readablility-implicit-bool-conversion
5chmidti wrote:
Please sort your entry before `readability-redundant-smartptr-get`
https://
kimgr wrote:
Do we need anything more to make progress with this PR?
My own primary concerns are basically things I can't check myself:
* Is there an out-of-tree scenario where `CLANG_RESOURCE_DIR` needs to be
replaced with something else at runtime, i.e. a real use-case for the optional
`Cus
5chmidti wrote:
rebase + ping. @AaronBallman could you check if this is okay now? I could merge
the AST matcher doc testing stack if that is the case
https://github.com/llvm/llvm-project/pull/94243
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/94243
>From 1ef1bc0bfebca8ca114a57ea2d5016418e36446d Mon Sep 17 00:00:00 2001
From: Julian Schmidt
Date: Sat, 1 Jun 2024 17:38:37 +0200
Subject: [PATCH 1/3] [clang][test] add TestLanguage.def to specify all tested
la
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/105930
>From 4568aab8bfd39be10a3df69535e083f3429e3a9e Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 24 Aug 2024 10:08:23 +0200
Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/85786
>From 395ce72afbf9e4b12fcbfaf9cdbda8921c9ff72a Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Tue, 23 Jul 2024 19:59:06 -0700
Subject: [PATCH 01/13] [RISCV][FMV] Support target_clones
---
.../clang/Basic/Diagnosti
labrinea wrote:
> @labrinea @jroelofs Is there anything that still needs to be done here or can
> this be merged?
Currently the dependent PR #87939 is on hold. Unless it moves forward this PR
is not needed.
https://github.com/llvm/llvm-project/pull/87942
__
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/89934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AmrDeveloper wrote:
@pow2clk
https://github.com/llvm/llvm-project/pull/105930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amr Hesham (AmrDeveloper)
Changes
Update all hybird DXIL/SPIRV codegen tests to use temp variable representing
interchange target
Fixes: #105710
---
Patch is 101.99 KiB, truncated to 20.00 KiB below, full version:
https://github.com/ll
https://github.com/AmrDeveloper created
https://github.com/llvm/llvm-project/pull/105930
Update all hybird DXIL/SPIRV codegen tests to use temp variable representing
interchange target
Fixes: #105710
>From 6f7b394dc573dfb2c9ce68b5ff8ec3a933830225 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
D
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/105927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-08-24T09:23:25+02:00
New Revision: 99b85cae628c1cc5641944290712cd84ccf1f6c8
URL:
https://github.com/llvm/llvm-project/commit/99b85cae628c1cc5641944290712cd84ccf1f6c8
DIFF:
https://github.com/llvm/llvm-project/commit/99b85cae628c1cc5641944290712cd84ccf1f6c8.diff
L
@@ -972,8 +972,15 @@ static const Expr
*SubstituteConstraintExpressionWithoutSatisfaction(
// equivalence.
LocalInstantiationScope ScopeForParameters(S);
if (auto *FD = DeclInfo.getDecl()->getAsFunction())
-for (auto *PVD : FD->parameters())
- ScopeForParameters
75 matches
Mail list logo
