[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-12 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/96301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-12 Thread via cfe-commits
@@ -1395,7 +1395,8 @@ class CXXRecordDecl : public RecordDecl { bool allowConstDefaultInit() const { return !data().HasUninitializedFields || !(data().HasDefaultedDefaultConstructor || - needsImplicitDefaultConstructor()); + needsImplici

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-12 Thread via cfe-commits
@@ -217,6 +217,11 @@ Bug Fixes to C++ Support - Clang now preserves the unexpanded flag in a lambda transform used for pack expansion. (#GH56852), (#GH85667), (#GH99877). - Fixed a bug when diagnosing ambiguous explicit specializations of constrained member functions. +- Cl

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-12 Thread via cfe-commits
https://github.com/Sirraide commented: I think the changes generally make sense. https://github.com/llvm/llvm-project/pull/96301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support -Wa, options -mmsa and -mno-msa (PR #99615)

2024-08-12 Thread via cfe-commits
https://github.com/yingopq edited https://github.com/llvm/llvm-project/pull/99615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support -Wa, options -mmsa and -mno-msa (PR #99615)

2024-08-12 Thread via cfe-commits
@@ -2507,6 +2507,7 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, bool Crel = false, ExperimentalCrel = false; bool UseRelaxRelocations = C.getDefaultToolChain().useRelaxRelocations(); bool UseNoExecStack = false; + bool Msa = false; y

[clang] Fixes and closes issues, #53390 and #58710. Added new controls to IndentNamespaceAliases, IndentUsingDeclarations and DecorateReflowedComments. (PR #102894)

2024-08-12 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. Isn't there overlap here with the other comments review, please separate out the 2 changes https://github.com/llvm/llvm-project/pull/102894 ___ cfe-commits mailing list cfe-comm

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-12 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM too. (I admittedly haven’t checked every line of this because there’s just that many of them, but that’s what CI is for; the changes seem fine overall) https://github.com/llvm/llvm-project/pull/102757

[clang] Fixes and closes issues, #53390 and #58710. Added new controls to IndentNamespaceAliases, IndentUsingDeclarations and DecorateReflowedComments. (PR #102894)

2024-08-12 Thread via cfe-commits
mydeveloperday wrote: Why are we added 2 features in one PR please separate https://github.com/llvm/llvm-project/pull/102894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support -Wa, options -mmsa and -mno-msa (PR #99615)

2024-08-12 Thread Fangrui Song via cfe-commits
@@ -2507,6 +2507,7 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, bool Crel = false, ExperimentalCrel = false; bool UseRelaxRelocations = C.getDefaultToolChain().useRelaxRelocations(); bool UseNoExecStack = false; + bool Msa = false; M

[clang] [clang-format] Fix annotation of braces enclosing stringification (PR #102998)

2024-08-12 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/102998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

2024-08-12 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > > Quick question for my understanding: With `spr` we don't get meaningful > > > commit messages anymore? That's quite unfortunate... > > > > > > Can you please clarify? > > The commit messages in this PR are `initial version` and `Update const.cpp`, > which is totally u

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

2024-08-12 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > > Quick question for my understanding: With `spr` we don't get meaningful > > commit messages anymore? That's quite unfortunate... > > Can you please clarify? The commit messages in this PR are `initial version` and `Update const.cpp`, which is totally useless if I came across

[clang] [clang] Support -Wa, options -mmsa and -mno-msa (PR #99615)

2024-08-12 Thread via cfe-commits
@@ -2507,6 +2507,7 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, bool Crel = false, ExperimentalCrel = false; bool UseRelaxRelocations = C.getDefaultToolChain().useRelaxRelocations(); bool UseNoExecStack = false; + bool Msa = false; y

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-12 Thread via cfe-commits
https://github.com/Harini0924 updated https://github.com/llvm/llvm-project/pull/102647 >From 658af04b25dfdb00d418936d576d13f301ffe0e6 Mon Sep 17 00:00:00 2001 From: Harini Date: Tue, 6 Aug 2024 04:40:30 + Subject: [PATCH 1/4] [llvm-lit] Replace Shell Substitutions with lit Syntax for Envir

[clang] [Clang] [Sema] Error on reference types inside a union with msvc 1900+ (PR #102851)

2024-08-12 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 edited https://github.com/llvm/llvm-project/pull/102851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Error on reference types inside a union with msvc 1910+ (PR #102851)

2024-08-12 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/102851 >From e6b925894066656a2773278a093dbf709ba66319 Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Sun, 11 Aug 2024 22:37:55 -0700 Subject: [PATCH 1/2] Error on reference inside a union with msvc 1910+ --- clang/li

[clang] [clang] Support -Wa, options -mmsa and -mno-msa (PR #99615)

2024-08-12 Thread Fangrui Song via cfe-commits
@@ -2507,6 +2507,7 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, bool Crel = false, ExperimentalCrel = false; bool UseRelaxRelocations = C.getDefaultToolChain().useRelaxRelocations(); bool UseNoExecStack = false; + bool Msa = false; M

[clang] [clang-format] Fix annotation of braces enclosing stringification (PR #102998)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #102937. --- Full diff: https://github.com/llvm/llvm-project/pull/102998.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+3) - (modified) clang/unittests/Format/Token

[clang] [clang-format] Fix annotation of braces enclosing stringification (PR #102998)

2024-08-12 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/102998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotation of braces enclosing stringification (PR #102998)

2024-08-12 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/102998 Fixes #102937. >From bd4a32c90f6148d27b010a5a1497c0f447144d9a Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 12 Aug 2024 20:58:04 -0700 Subject: [PATCH] [clang-format] Fix annotation of braces enclosing str

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-12 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,85 @@ += +RealtimeSanitizer += + +.. contents:: + :local: + +Introduction + +RealtimeSanitizer (a.k.a. RTSan) is a real-time safety testing tool for C and +C++ projects. RTSan can be used to detect real-time violations,such

[clang] a27f40e - [X86_64] Fix empty field error in vaarg of C++. (#101639)

2024-08-12 Thread via cfe-commits
Author: Longsheng Mou Date: 2024-08-13T11:35:23+08:00 New Revision: a27f40e5d9636b0853e8de0b95d72261f8d34696 URL: https://github.com/llvm/llvm-project/commit/a27f40e5d9636b0853e8de0b95d72261f8d34696 DIFF: https://github.com/llvm/llvm-project/commit/a27f40e5d9636b0853e8de0b95d72261f8d34696.diff

[clang] Warning Libc functions (PR #101583)

2024-08-12 Thread Ziqing Luo via cfe-commits
@@ -443,6 +447,314 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { return false; } +AST_MATCHER(CallExpr, isUnsafeLibcFunctionCall) { + static const std::set PredefinedNames{ + // numeric conversion: + "atof", + "atoi", + "atol", + "atoll

[clang] Warning Libc functions (PR #101583)

2024-08-12 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/101583 >From cce5781733a7c294f10dc75f48372ff6ee331239 Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Thu, 1 Aug 2024 16:36:27 -0700 Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Add warn on unsafe calls to libc f

[clang] [Clang] [AST] Fix placeholder return type name mangling for MSVC 1920+ / VS2019+ (PR #102848)

2024-08-12 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 edited https://github.com/llvm/llvm-project/pull/102848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [AST] Fix placeholder return type name mangling for MSVC 1920+ / VS2019+ (PR #102848)

2024-08-12 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/102848 >From e5071bd3be7607730654e5aa815a535db130fdee Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Sun, 11 Aug 2024 16:50:58 -0700 Subject: [PATCH 1/4] Fix placeholder return type name mangling for MSVC 1920+ --- c

[clang] [Clang] [AST] Fix placeholder return type name mangling for MSVC 1920+ / VS2019+ (PR #102848)

2024-08-12 Thread Max Winkler via cfe-commits
@@ -408,6 +408,9 @@ class MicrosoftCXXNameMangler { void mangleSourceName(StringRef Name); void mangleNestedName(GlobalDecl GD); + void mangleAutoReturnType(QualType T, SourceRange Range, MaxEW707 wrote: Argh you are correct. This is holdover from develo

[clang] [Clang] [AST] Fix placeholder return type name mangling for MSVC 1920+ / VS2019+ (PR #102848)

2024-08-12 Thread Max Winkler via cfe-commits
@@ -2494,6 +2506,58 @@ void MicrosoftCXXNameMangler::mangleAddressSpaceType(QualType T, mangleArtificialTagType(TagTypeKind::Struct, ASMangling, {"__clang"}); } +void MicrosoftCXXNameMangler::mangleAutoReturnType(QualType T, +

[clang] [Clang] [Sema] Error on reference types inside a union with msvc 1910+ (PR #102851)

2024-08-12 Thread Max Winkler via cfe-commits
MaxEW707 wrote: > > I definitely remember this being an extension in older versions of VS > > around VS 2012 but don't know when MSVC no longer exactly removed support > > for this extension wholesale. > > This was definitely required for MFC headers; I remember implementing this > horrible n

[clang-tools-extra] [clang-tidy] Create bugprone-public-enable-shared-from-this check (PR #102299)

2024-08-12 Thread via cfe-commits
MichelleCDjunaidi wrote: > > maintaining the name of the matched classes in a vector and checking for > > every other class if it inherits from `::std::enable_shared_from_this` or > > classes in the vector. > > You wouldn't want to save the name, because then you would do a lot of string > co

[clang] [Clang][Sema] fix noexecpt mismatch of friend declaration (PR #102267)

2024-08-12 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/102267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Create bugprone-public-enable-shared-from-this check (PR #102299)

2024-08-12 Thread via cfe-commits
https://github.com/MichelleCDjunaidi updated https://github.com/llvm/llvm-project/pull/102299 >From 75306bd83eb43d0606630f9f059fc04ad1b20b06 Mon Sep 17 00:00:00 2001 From: Michelle C Djunaidi Date: Wed, 7 Aug 2024 13:10:02 +0800 Subject: [PATCH 1/7] [clang-tidy] Add bugprone-public-enable-share

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-08-12 Thread via cfe-commits
@@ -510,6 +528,18 @@ def OMP_EndAssumes : Directive<"end assumes"> { let association = AS_Delimited; let category = OMP_Assumes.category; } +def OMP_Assume : Directive<"assume"> { + let association = AS_Block; TigerTimeJ wrote: why need this? https://git

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-08-12 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/102975 >From 4ad7fc6a206a1d4004fe11013bce9ebee0347479 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 12 Aug 2024 14:32:08 -0600 Subject: [PATCH 1/3] [clang][flang][mlir] Support -frecord-command-line option

[clang] Warning Libc functions (PR #101583)

2024-08-12 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/101583 >From cce5781733a7c294f10dc75f48372ff6ee331239 Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Thu, 1 Aug 2024 16:36:27 -0700 Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Add warn on unsafe calls to libc f

[clang] [ASTDump] TextNodeDumper learned to dump builtin name for AtomicExpr (PR #102748)

2024-08-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/3544 Here is the relevant piece of the build log for

[clang] [llvm] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload (PR #94549)

2024-08-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-aarch64` running on `as-builder-2` while building `clang,offload` at step 14 "test-libc++abi". Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/1824 Here is the relevant pie

[clang] [ASTDump] TextNodeDumper learned to dump builtin name for AtomicExpr (PR #102748)

2024-08-12 Thread via cfe-commits
https://github.com/Enna1 closed https://github.com/llvm/llvm-project/pull/102748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 17db331 - [ASTDump] TextNodeDumper learned to dump builtin name for AtomicExpr (#102748)

2024-08-12 Thread via cfe-commits
Author: Enna1 Date: 2024-08-13T09:50:34+08:00 New Revision: 17db3313c75120fd8415529723eb96cbad399338 URL: https://github.com/llvm/llvm-project/commit/17db3313c75120fd8415529723eb96cbad399338 DIFF: https://github.com/llvm/llvm-project/commit/17db3313c75120fd8415529723eb96cbad399338.diff LOG: [A

[clang] [Clang][NFCI] Slightly refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/102922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFCI] Refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/102922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFCI] Refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/102922 >From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 12 Aug 2024 23:32:34 +0800 Subject: [PATCH 1/2] [Clang][NFCI] Slightly refactor getTemplateInstantiationArgs

[clang] [Clang][NFCI] Refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/102922 >From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 12 Aug 2024 23:32:34 +0800 Subject: [PATCH] [Clang][NFCI] Slightly refactor getTemplateInstantiationArgs()

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,118 @@ +; RUN: opt -S -dxil-intrinsic-expansion < %s | FileCheck %s --check-prefixes=CHECK,EXPCHECK +; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library < %s | FileCheck %s --check-prefixes=CHECK,DOPCHECK + +; Make sure dxil operation function call

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/102683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

2024-08-12 Thread via cfe-commits
https://github.com/yronglin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFCI] Refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/102922 >From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 12 Aug 2024 23:32:34 +0800 Subject: [PATCH] [Clang][NFCI] Slightly refactor getTemplateInstantiationArgs()

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,73 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ +// RUN: --check-prefixes=CHECK,NATIVE_HALF +// RUN: %clang_cc1 -fi

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
@@ -4725,6 +4725,12 @@ def HLSLMad : LangBuiltin<"HLSL_LANG"> { let Prototype = "void(...)"; } +def HLSLNormalize : LangBuiltin<"HLSL_LANG"> { + let Spellings = ["__builtin_hlsl_normalize"]; farzonl wrote: I'm fine with this as is. resolving. https://gith

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

2024-08-12 Thread via cfe-commits
https://github.com/yronglin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/102683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly handle C# attribute on auto property (PR #102921)

2024-08-12 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/102921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d990cc4 - [clang-format] Correctly handle C# attribute on auto property (#102921)

2024-08-12 Thread via cfe-commits
Author: Owen Pan Date: 2024-08-12T18:27:32-07:00 New Revision: d990cc4568f45c28d1d5ac86125935628c76efc8 URL: https://github.com/llvm/llvm-project/commit/d990cc4568f45c28d1d5ac86125935628c76efc8 DIFF: https://github.com/llvm/llvm-project/commit/d990cc4568f45c28d1d5ac86125935628c76efc8.diff LOG:

[clang] [X86_64] Fix empty field error in vaarg of C++. (PR #101639)

2024-08-12 Thread Longsheng Mou via cfe-commits
CoTinker wrote: Thanks. https://github.com/llvm/llvm-project/pull/101639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload (PR #94549)

2024-08-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,offload` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/3628 Here i

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-08-12 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/102592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Freddy Ye via cfe-commits
@@ -200,6 +200,14 @@ #include #endif +#if !defined(__SCE__) || __has_feature(modules) || defined(__AVX10_2__) +#include FreddyLeaf wrote: merge with other avx10_2 header files. https://github.com/llvm/llvm-project/pull/102592 __

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-12 Thread via cfe-commits
eddyz87 wrote: @AaronBallman, @efriedma-quic, could you please comment? We are eager to use this feature on the BPF side (e.g. [here](https://lore.kernel.org/bpf/caadnvqjdki9gcxdaagjwb+hrkt2enzyxm8k3238xxpthkhu...@mail.gmail.com/) and landing it to the `main` would simplify the cooperation. ht

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-12 Thread Bill Wendling via cfe-commits
@@ -649,6 +649,8 @@ class alignas(void *) Stmt { /// It is 0 otherwise. LLVM_PREFERRED_TYPE(bool) unsigned HasFPFeatures : 1; +LLVM_PREFERRED_TYPE(bool) bwendling wrote: Nit: Newline and maybe a comment? https://github.com/llvm/llvm-project/pu

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-12 Thread Justin Stitt via cfe-commits
@@ -3860,6 +3860,7 @@ class CStyleCastExpr final class BinaryOperator : public Expr { enum { LHS, RHS, END_EXPR }; Stmt *SubExprs[END_EXPR]; + bool ExcludedOverflowPattern = false; JustinStitt wrote: Ok, I think I found a spare bit in `BinaryOperatorBits`

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-12 Thread Justin Stitt via cfe-commits
@@ -195,13 +196,23 @@ static bool CanElideOverflowCheck(const ASTContext &Ctx, const BinOpInfo &Op) { if (!Op.mayHaveIntegerOverflow()) return true; + const UnaryOperator *UO = dyn_cast(Op.E); + + if (UO && UO->getOpcode() == UO_Minus && UO->isIntegerConstantExpr(Ctx)

[clang] [llvm] [DataLayout] Remove constructor accepting a pointer to Module (PR #102841)

2024-08-12 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov closed https://github.com/llvm/llvm-project/pull/102841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 75c7bca - [DataLayout] Remove constructor accepting a pointer to Module (#102841)

2024-08-12 Thread via cfe-commits
Author: Sergei Barannikov Date: 2024-08-13T04:00:19+03:00 New Revision: 75c7bca740935a0cca462e28475dd6b046a6872c URL: https://github.com/llvm/llvm-project/commit/75c7bca740935a0cca462e28475dd6b046a6872c DIFF: https://github.com/llvm/llvm-project/commit/75c7bca740935a0cca462e28475dd6b046a6872c.d

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-12 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt updated https://github.com/llvm/llvm-project/pull/100272 >From 154d3505ab13275086b3dffed67bcdcac52f79a3 Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Tue, 23 Jul 2024 20:21:49 + Subject: [PATCH 01/10] implement idiom exclusions Add flag `-fno-sanitize-ove

[clang] [llvm] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload (PR #94549)

2024-08-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang,offload` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/3871 Here is the

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-08-12 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu edited https://github.com/llvm/llvm-project/pull/102975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-08-12 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/102975 >From 4ad7fc6a206a1d4004fe11013bce9ebee0347479 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 12 Aug 2024 14:32:08 -0600 Subject: [PATCH 1/2] [clang][flang][mlir] Support -frecord-command-line option

[clang] [llvm] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload (PR #94549)

2024-08-12 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert closed https://github.com/llvm/llvm-project/pull/94549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload (PR #94549)

2024-08-12 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert updated https://github.com/llvm/llvm-project/pull/94549 >From e0dca9181683badc5053848a5fe399c371cd81ce Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Mon, 3 Jun 2024 19:52:12 -0700 Subject: [PATCH] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload MIME-

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread via cfe-commits
Da-Viper wrote: > Please add tests, a release notes entry, and document the option in the > documentation of the check. Do you want it as an option to the check ? if yes which one would be the default the upper case or lower case https://github.com/llvm/llvm-project/pull/102831 __

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/102831 >From 8a4f6af9fc1f44c2f8b5fd3693ca14eaf776fd02 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 11 Aug 2024 21:39:35 +0100 Subject: [PATCH 1/2] [clang-tidy] use upper cace letters for bool conversion suff

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/102683 >From 547b4da91b20811db156a8c73fcb2f381cfed7bd Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 9 Aug 2024 10:48:10 -0700 Subject: [PATCH 1/9] suboptimal expansion of normalize done --- clang/include/

[clang] Fixes and closes issues, #53390 and #58710. Added new controls to IndentNamespaceAliases, IndentUsingDeclarations and DecorateReflowedComments. (PR #102894)

2024-08-12 Thread Rajkumar Ananthu via cfe-commits
@@ -47,8 +47,7 @@ void printLine(llvm::raw_ostream &OS, const UnwrappedLine &Line, OS << Prefix; NewLine = false; } -OS << I->Tok->Tok.getName() << "[" - << "T=" << (unsigned)I->Tok->getType() +OS << I->Tok->Tok.getName() << "[" << "T=" << (unsign

[clang] Fixes and closes issues, #53390 and #58710. Added new controls to IndentNamespaceAliases, IndentUsingDeclarations and DecorateReflowedComments. (PR #102894)

2024-08-12 Thread Rajkumar Ananthu via cfe-commits
rajkumarananthu wrote: Thankyou @HazardyKnusperkeks for the review, I am beginner level contributor to LLVM Project and that might be the reason I might have missed some minor details. I will address them. And as advised I will close this pull-request and split into multiple small reviews afte

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/101282 >From ac1c7b5cbf3024bf8cd4021174a47b914d7f7dea Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Tue, 30 Jul 2024 23:58:27 -0400 Subject: [PATCH 1/9] [clang-doc] add suport for clang-doc enum generation --- c

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/101282 >From ac1c7b5cbf3024bf8cd4021174a47b914d7f7dea Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Tue, 30 Jul 2024 23:58:27 -0400 Subject: [PATCH 1/8] [clang-doc] add suport for clang-doc enum generation --- c

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/101282 >From ac1c7b5cbf3024bf8cd4021174a47b914d7f7dea Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Tue, 30 Jul 2024 23:58:27 -0400 Subject: [PATCH 1/7] [clang-doc] add suport for clang-doc enum generation --- c

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread Paul Kirth via cfe-commits
@@ -124,9 +145,37 @@ namespace Vehicles { // MD-VEHICLES: **brief** specify type of car // HTML-VEHICLES: namespace Vehicles -// HTML-VEHICLES: Enums -// HTML-VEHICLES: enum Car -// HTML-VEHICLES: Sedan -// HTML-VEHICLES: SUV -// HTML-VEHICLES: Pickup -// HTML-VEHICLES: Hatchb

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread Paul Kirth via cfe-commits
@@ -716,8 +774,8 @@ genHTML(const FunctionInfo &I, const ClangDocContext &CDCtx, if (!CDCtx.RepositoryUrl) Out.emplace_back(writeFileDefinition(*I.DefLoc)); else - Out.emplace_back(writeFileDefinition( - *I.DefLoc, StringRef{*CDCtx.RepositoryUrl}));

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM modulo some minor nits. https://github.com/llvm/llvm-project/pull/101282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread Paul Kirth via cfe-commits
@@ -558,15 +568,15 @@ static void populateFunctionInfo(FunctionInfo &I, const FunctionDecl *D, static void populateMemberTypeInfo(MemberTypeInfo &I, const FieldDecl *D) { assert(D && "Expect non-null FieldDecl in populateMemberTypeInfo"); - ASTContext& Context = D->getASTC

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread Paul Kirth via cfe-commits
@@ -653,22 +695,38 @@ static std::vector> genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) { std::vector> Out; std::string EnumType = I.Scoped ? "enum class " : "enum "; - - Out.emplace_back( - std::make_unique(HTMLTag::TAG_H3, EnumType + I.Name)); - Out.back

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/101282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-12 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B updated https://github.com/llvm/llvm-project/pull/100247 >From da1ac9d36bd284dc607b7366ff83ba556fb64fb5 Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Thu, 18 Jul 2024 15:05:01 -0700 Subject: [PATCH 1/2] [CUDA] Add a pseudo GPU sm_next which allows overrides for

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread via cfe-commits
Da-Viper wrote: > There might be people who don't want uppercase suffix, so this will cause > problems to them. This should be put into a configuration option instead. Correct me if I am wrong, but the way I see it is that if a check is applied it should align with existing checks. take for

[clang] [Clang][Sema] fix noexecpt mismatch of friend declaration (PR #102267)

2024-08-12 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > substitute so all references to template parameters have the correct depth @sdkrystian Agree! The underlying issue is the incorrect depth makes the comparison of the operands of the `noexcept-specifier` failed. because clang can't find instantiated template parameter declaratio

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/102683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
@@ -18584,6 +18584,29 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID, CGM.getHLSLRuntime().getLengthIntrinsic(), ArrayRef{X}, nullptr, "hlsl.length"); } + case Builtin::BI__builtin_hlsl_normalize: { +Value *X = EmitScalarExpr(E->getArg

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-12 Thread Farzon Lotfi via cfe-commits
@@ -380,6 +383,20 @@ bool SPIRVInstructionSelector::spvSelect(Register ResVReg, MIB.addImm(V); return MIB.constrainAllUses(TII, TRI, RBI); } + + case TargetOpcode::G_FDOTPROD: { +MachineBasicBlock &BB = *I.getParent(); +return BuildMI(BB, I, I.getDebugLoc()

[clang-tools-extra] [clang-doc] add support for enums comments in html generation (PR #101282)

2024-08-12 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/101282 >From ac1c7b5cbf3024bf8cd4021174a47b914d7f7dea Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Tue, 30 Jul 2024 23:58:27 -0400 Subject: [PATCH 1/6] [clang-doc] add suport for clang-doc enum generation --- c

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3c3df1bef84bd509bdd2b6033bc9bb3653826388 c08c0153cbde1f43bebdbb8b50b74e77cdfc40bb --e

[clang-tools-extra] [clang-doc] add support for block commands in clang-doc html output (PR #101108)

2024-08-12 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/101108 >From 8d054ac3ada0e978fa1a663170090f033016edfe Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Tue, 30 Jul 2024 17:48:24 -0400 Subject: [PATCH 1/7] [clang-doc] add support for block commands --- clang-tools

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-12 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/102872 >From 6fde4bc98d0156024cf7acc27e2e986b9bec3993 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Fri, 2 Aug 2024 20:10:04 -0600 Subject: [PATCH 1/4] Create llvm dot intrinsic Per https://discourse.llvm.org/t/rfc-a

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-12 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B updated https://github.com/llvm/llvm-project/pull/100247 >From da1ac9d36bd284dc607b7366ff83ba556fb64fb5 Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Thu, 18 Jul 2024 15:05:01 -0700 Subject: [PATCH] [CUDA] Add a pseudo GPU sm_next which allows overrides for SM/

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-12 Thread Chris Apple via cfe-commits
cjappl wrote: (Sorry for the "double ping", I just got commit powers, so adding people to the review explicitly) https://github.com/llvm/llvm-project/pull/102622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-08-12 Thread Jan Svoboda via cfe-commits
@@ -2933,8 +2933,21 @@ recursive_directory_iterator::increment(std::error_code &EC) { return *this; } +void TracingFileSystem::printImpl(raw_ostream &OS, PrintType Type, jansvoboda11 wrote: Good idea, implemented in the new commit. https://github.com/llvm

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-08-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/88326 >From c543c01b144f702e57d04c961fbfd5ebfa43e863 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 12 Apr 2024 10:47:13 -0700 Subject: [PATCH 1/2] [llvm][support] Implement tracing virtual file system ---

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/102683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-12 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/102683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >