vgvassilev wrote:
Hi @AaronBallman, could we move that forward?
https://github.com/llvm/llvm-project/pull/98138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -698,13 +685,15 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S,
NestedNameSpecInfo &IdInfo,
if (ErrorRecoveryLookup)
return true;
+#if 0
// If we didn't find anything during our lookup, try again with
// ordinary name lookup, which can help us produce bette
@@ -767,6 +757,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S,
NestedNameSpecInfo &IdInfo,
else
Diag(IdInfo.IdentifierLoc, diag::err_undeclared_var_use)
<< IdInfo.Identifier;
+#endif
mizvekov wrote:
You should probably remove these before
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Petr Hosek (petrhosek)
Changes
These are needed for baremetal targets as well.
---
Full diff: https://github.com/llvm/llvm-project/pull/100908.diff
1 Files Affected:
- (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+34-8)
``
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/100908
These are needed for baremetal targets as well.
>From 5177b4ac9ce9d1b45e80e0613e1cb3363e73bd39 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Sat, 27 Jul 2024 17:10:01 -0700
Subject: [PATCH] [CMake][Fuchsia]
jeaye wrote:
Thanks, Vassil! I'm following up to confirm that this does fix the hard crash I
was seeing. Really hoping we can get this merged.
https://github.com/llvm/llvm-project/pull/98138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
https://github.com/vegerot converted_to_draft
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
@@ -3921,7 +3921,7 @@ _ForwardIterator basic_regex<_CharT,
_Traits>::__parse_character_escape(
if (__hd == -1)
__throw_regex_error();
__sum = 16 * __sum + static_cast(__hd);
- // fall
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
https://github.com/vegerot edited
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
@@ -3921,7 +3921,7 @@ _ForwardIterator basic_regex<_CharT,
_Traits>::__parse_character_escape(
if (__hd == -1)
__throw_regex_error();
__sum = 16 * __sum + static_cast(__hd);
- // fall
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/100903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/100903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
This reverts commit 88e5206f2c96a34e23a4d63f0a38afb2db044f0a. The original
change went in a while ago (last year) in https://reviews.llvm.org/D145057. The
specific reason I'm proposing a revert is that th
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/100903
This reverts commit 88e5206f2c96a34e23a4d63f0a38afb2db044f0a. The original
change went in a while ago (last year) in https://reviews.llvm.org/D145057. The
specific reason I'm proposing a revert is that this
@@ -5346,7 +5346,6 @@ static EvalStmtResult EvaluateStmt(StmtResult &Result,
EvalInfo &Info,
const Expr *RetExpr = cast(S)->getRetValue();
FullExpressionRAII Scope(Info);
if (RetExpr && RetExpr->isValueDependent()) {
- EvaluateDependentExpr(RetExpr, Info);
---
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: None (vabridgers)
Changes
This change avoids crashes in the stream checker when bifurcating the analysis
state produces a non-null return value for opening a stream and does not
produces a null return value because of co
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (vabridgers)
Changes
This change avoids crashes in the stream checker when bifurcating the analysis
state produces a non-null return value for opening a stream and does not
produces a null return value because of constraints found du
https://github.com/vabridgers created
https://github.com/llvm/llvm-project/pull/100901
This change avoids crashes in the stream checker when bifurcating the analysis
state produces a non-null return value for opening a stream and does not
produces a null return value because of constraints fou
@@ -5399,11 +5434,85 @@ static QualType
GetImplicitObjectParameterType(ASTContext &Context,
return Context.getLValueReferenceType(RawType);
}
+static TemplateDeductionResult FinishTemplateArgumentDeduction(
+Sema &S, FunctionTemplateDecl *FTD, int ArgIdx, QualType P, Qu
mizvekov wrote:
@MaskRay the latest version fixes libc++ regressions.
Also abseil-cpp builds correctly on MacOS, according to those instructions.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/pskrgag updated
https://github.com/llvm/llvm-project/pull/99564
>From 6b7ec7c95df16de5eb0fecf2d69befb5461d98a5 Mon Sep 17 00:00:00 2001
From: Pavel Skripkin
Date: Thu, 18 Jul 2024 18:48:47 +0300
Subject: [PATCH 1/7] clang/sema: disallow ownership_returns for functions that
r
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/100692
>From 89e016886fd87ab54856ed61a0a419d25f7df9e5 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Wed, 24 Jul 2024 03:59:41 -0300
Subject: [PATCH] [clang] check deduction consistency when partial ordering
fu
njames93 wrote:
@5chmidti I decided to run this version of the check on llvm and clang
https://gist.github.com/njames93/6f8863573972cb07c388ac19e8a20467
Seems like most of the warnings detected are when we are deliberately exceeding
the bounds of a range when we know its a slice of a bigger ran
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/99917
>From c79951fdc4f866413f83a94b1eaa16f3ffb10aa4 Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Tue, 23 Jul 2024 10:59:45 +0100
Subject: [PATCH] Create a new check to look for mis-use in calls that take
iterat
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are
defined:
value should be sign-extended to the extent required by the target's
ABI (which is usually 32-bits) by the caller (for a parameter) or
the callee (for a return value).
+``noext``
Endilll wrote:
Shafik contacted me offline about a libc++ test failure this PR causes. The
test in question is `mem.res.eq/not_equal_pass.cpp`.
I reduced it down to the following:
```cpp
struct memory_resource {
virtual ~memory_resource();
bool is_equal(const memory_resource &) const noexcep
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
@@ -3921,7 +3921,7 @@ _ForwardIterator basic_regex<_CharT,
_Traits>::__parse_character_escape(
if (__hd == -1)
__throw_regex_error();
__sum = 16 * __sum + static_cast(__hd);
- // fall
njames93 wrote:
Added some detection for trying to advance past the end or before the start of
a range.
https://github.com/llvm/llvm-project/pull/99917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/99917
>From e1c3086cf28f7c075d631c128c984bc25109cd81 Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Tue, 23 Jul 2024 10:59:45 +0100
Subject: [PATCH] Create a new check to look for mis-use in calls that take
iterat
yronglin wrote:
Thanks for the review! Yes, there are three regressions, I've revert back the
handling of an expression, and enable new interpreter in these three test.
https://github.com/llvm/llvm-project/pull/100761
___
cfe-commits mailing list
cfe-
@@ -14,33 +14,29 @@ struct DelBase {
constexpr DelBase() = delete; // expected-note {{'DelBase' has been
explicitly marked deleted here}}
yronglin wrote:
Removed 2nd bullet.
https://github.com/llvm/llvm-project/pull/100761
___
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S,
SourceLocation Loc,
}
// Check Fields in all bases
- for (const Record::Base &B : R->bases()) {
+ unsigned BaseIndex = 0;
+ const CXXRecordDecl *CD = dyn_cast(R->getDecl());
+ for (const CXXBaseS
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/100761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S,
SourceLocation Loc,
}
// Check Fields in all bases
- for (const Record::Base &B : R->bases()) {
+ unsigned BaseIndex = 0;
+ const CXXRecordDecl *CD = dyn_cast(R->getDecl());
+ for (const CXXBaseS
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S,
SourceLocation Loc,
}
// Check Fields in all bases
- for (const Record::Base &B : R->bases()) {
+ unsigned BaseIndex = 0;
+ const CXXRecordDecl *CD = dyn_cast(R->getDecl());
yrong
mikecrowe wrote:
@5chmidti wrote:
> It'll be 1 week+ before I am back at my main machine to take a better look at
> the macro question. Maybe this can just be landed, without that distinction.
Thanks for letting me know and thanks for the review.
I've pushed a new version to this PR with the t
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/100761
>From eb237d1b6434c16366f8095f47af1456cb776a27 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Fri, 26 Jul 2024 23:09:42 +0800
Subject: [PATCH 1/2] [Clang][Interp] Fix the location of uninitialized base
warning
https://github.com/mikecrowe updated
https://github.com/llvm/llvm-project/pull/97911
>From f6c1a231681092189a621e2bc6af97300b2a7bfa Mon Sep 17 00:00:00 2001
From: Mike Crowe
Date: Wed, 12 Jun 2024 21:06:26 +0100
Subject: [PATCH 1/6] [clang-tidy] Only expand macros in
modernize-use-std-format/
https://github.com/pskrgag updated
https://github.com/llvm/llvm-project/pull/99564
>From 6b7ec7c95df16de5eb0fecf2d69befb5461d98a5 Mon Sep 17 00:00:00 2001
From: Pavel Skripkin
Date: Thu, 18 Jul 2024 18:48:47 +0300
Subject: [PATCH 1/6] clang/sema: disallow ownership_returns for functions that
r
@@ -231,6 +231,10 @@ Crash and bug fixes
Improvements
+- Improved the handling of the `ownership_returns` attribute. Now, Clang
reports an
+ error if the attribute is attached to a function that returns a non-pointer
value.
AaronBallman wrote:
https://github.com/AaronBallman commented:
Just a few minor nits, otherwise LGTM
https://github.com/llvm/llvm-project/pull/99564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1481,6 +1481,15 @@ static void handleOwnershipAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
break;
}
+ // Allow only pointers to be return type for functions with ownership_returns
+ // attribute. This matches with current OwnershipAttr::Takes semantics
+ if (K
@@ -3330,6 +3330,8 @@ def err_attribute_invalid_implicit_this_argument : Error<
"%0 attribute is invalid for the implicit this argument">;
def err_ownership_type : Error<
"%0 attribute only applies to %select{pointer|integer}1 arguments">;
+def err_ownership_takes_return_ty
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/99564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/100778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4699,7 +4699,7 @@ class FunctionEffect {
private:
LLVM_PREFERRED_TYPE(Kind)
- unsigned FKind : 3;
+ uint8_t FKind : 3;
dougsonos wrote:
That PR has been merged.
https://github.com/llvm/llvm-project/pull/99656
_
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/100874
This was missing a call to `ignoreCFGOmittedNodes()`. As a result, the function
would erroneously conclude that a block did not contain an expression consumed
in a different block if the expression in questi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (martinboehme)
Changes
This was missing a call to `ignoreCFGOmittedNodes()`. As a result, the function
would erroneously conclude that a block did not contain an expression consumed
in a different block if the expression in question wa
llvmbot wrote:
/pull-request llvm/llvm-project#100873
https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cjacek wrote:
/cherry-pick ea98dc8b8f508b8393651992830e5e51d3876728
https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjacek milestoned
https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
>/cherry-pick ea98dc8b8f508b8393651992830e5e51d3876728
Error: Command failed due to missing milestone.
https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
cjacek wrote:
Thanks. I created #100872 for dllexport fix.
https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cjacek wrote:
/cherry-pick ea98dc8b8f508b8393651992830e5e51d3876728
https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/njames93 closed
https://github.com/llvm/llvm-project/pull/100129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nathan James
Date: 2024-07-27T14:13:21+01:00
New Revision: 154d00d5d0416c42388d6e82cac96fbc091101d2
URL:
https://github.com/llvm/llvm-project/commit/154d00d5d0416c42388d6e82cac96fbc091101d2
DIFF:
https://github.com/llvm/llvm-project/commit/154d00d5d0416c42388d6e82cac96fbc091101d2.diff
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/100129
>From b76a506ad12f3923dbca13063b66bb83a336f0c2 Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Tue, 23 Jul 2024 15:24:52 +0100
Subject: [PATCH] Extend support for specifying languages and version in
add_new_
@@ -0,0 +1,756 @@
+//===--- IncorrectIteratorsCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/99917
>From bbf32f3ca89e8950d82fe920b232fee4b82cb43e Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Tue, 23 Jul 2024 10:59:45 +0100
Subject: [PATCH] Create a new check to look for mis-use in calls that take
iterat
Author: Jacek Caban
Date: 2024-07-27T14:29:05+02:00
New Revision: ea98dc8b8f508b8393651992830e5e51d3876728
URL:
https://github.com/llvm/llvm-project/commit/ea98dc8b8f508b8393651992830e5e51d3876728
DIFF:
https://github.com/llvm/llvm-project/commit/ea98dc8b8f508b8393651992830e5e51d3876728.diff
L
https://github.com/cjacek closed https://github.com/llvm/llvm-project/pull/99478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
The flaky test `basic-project.test` failure is unrelated -- I didn't rebase my
branch onto 88549cf4
https://github.com/llvm/llvm-project/pull/100865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/100865
>From 13724c6cd47c17b92b57f04436c544bd9d681070 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 27 Jul 2024 18:52:23 +0800
Subject: [PATCH 1/2] [Clang][CTAD][NFC] Unify transformTemplateParameter()
We end
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
We ended up having two transformTemplateParameter() after CTAD for type aliases
was landed. This patch cleans them up and allows them to share one
implementation.
---
Full diff: https://github.com/llvm/llvm
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/100865
We ended up having two transformTemplateParameter() after CTAD for type aliases
was landed. This patch cleans them up and allows them to share one
implementation.
>From 13724c6cd47c17b92b57f04436c544bd9d681070
https://github.com/phoebewang edited
https://github.com/llvm/llvm-project/pull/100757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are
defined:
value should be sign-extended to the extent required by the target's
ABI (which is usually 32-bits) by the caller (for a parameter) or
the callee (for a return value).
+``noext``
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Hirofumi Nakamura (hnakamura5)
Changes
Trying to fix https://github.com/llvm/llvm-project/issues/98559 .
This PR modifies the ad-hoc tweaks introduced by
https://reviews.llvm.org/D50078 .
The change is limited to the case `AlignOpe
https://github.com/hnakamura5 created
https://github.com/llvm/llvm-project/pull/100860
Trying to fix https://github.com/llvm/llvm-project/issues/98559 .
This PR modifies the ad-hoc tweaks introduced by
https://reviews.llvm.org/D50078 .
The change is limited to the case `AlignOperands ` and
`B
https://github.com/vfdff updated
https://github.com/llvm/llvm-project/pull/100302
>From c750234674531788ee26958954a5f9a6b59ea866 Mon Sep 17 00:00:00 2001
From: zhongyunde 00443407
Date: Tue, 23 Jul 2024 23:10:42 -0400
Subject: [PATCH 1/3] [clang codegen] Emit int TBAA metadata on more FP math
pskrgag wrote:
@AaronBallman sorry for Saturday ping, but could you, please, take a look?
https://github.com/llvm/llvm-project/pull/99564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are
defined:
value should be sign-extended to the extent required by the target's
ABI (which is usually 32-bits) by the caller (for a parameter) or
the callee (for a return value).
+``noext``
73 matches
Mail list logo
