zwuis wrote:
> Can you check this case with your build?
Also pass this test.
https://github.com/llvm/llvm-project/pull/89713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlosgalvezp wrote:
Good check idea! A couple of comments:
- This is not really a "modernize"check. Both styles are equally valid and it's
a matter of taste. Modernize is typically for checks that bump from one
standard to a newer one.
- Instead I think this check fits better in "readabili
Author: Timm Bäder
Date: 2024-07-20T08:26:06+02:00
New Revision: 06d2176d81cab1d3ed8d0c17f78c1d3ef65cbab8
URL:
https://github.com/llvm/llvm-project/commit/06d2176d81cab1d3ed8d0c17f78c1d3ef65cbab8
DIFF:
https://github.com/llvm/llvm-project/commit/06d2176d81cab1d3ed8d0c17f78c1d3ef65cbab8.diff
LO
@@ -0,0 +1,38 @@
+//===--- UseCppStyleCommentsCheck.h -
clang-tidy---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -172,6 +172,11 @@ New checks
Detects variables and functions that can be marked as static or moved into
an anonymous namespace to enforce internal linkage.
+- New :doc:`modernize-use-cpp-style-comments
+ ` check.
+
+ Find C Style comments and suggests to use C++ style
@@ -0,0 +1,67 @@
+//===--- UseCppStyleCommentsCheck.cpp -
clang-tidy-===//
+
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,67 @@
+//===--- UseCppStyleCommentsCheck.cpp -
clang-tidy-===//
+
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/99713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %check_clang_tidy -std=c++11 %s modernize-use-cpp-style-comments %t
+
+static auto PI = 3.14159265; /* value of pi upto 8 decimal places */
+// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: use C++ style comments '//'
instead of C style comments '/*...*/' [m
@@ -0,0 +1,12 @@
+.. title:: clang-tidy - modernize-use-cpp-style-comments
+
+modernize-use-cpp-style-comments
+
+
+Finds C-style comments and suggests to use C++ style comments `//`.
PiotrZSL wrote:
this line should be synchronize
https://github.com/PiotrZSL requested changes to this pull request.
Except nits:
- check should fix comments, not delete them.
- few tests are missing, with comments in a middle of code
https://github.com/llvm/llvm-project/pull/99713
___
cfe-commits ma
@@ -0,0 +1,12 @@
+.. title:: clang-tidy - modernize-use-cpp-style-comments
+
+modernize-use-cpp-style-comments
+
+
+Finds C-style comments and suggests to use C++ style comments `//`.
+
+
+.. code-block:: c++
+
+ memcpy(a, b, sizeof(int) * 5); /* u
@@ -0,0 +1,38 @@
+//===--- UseCppStyleCommentsCheck.h -
clang-tidy---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,38 @@
+//===--- UseCppStyleCommentsCheck.h -
clang-tidy---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,38 @@
+//===--- UseCppStyleCommentsCheck.h -
clang-tidy---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/njames93 edited
https://github.com/llvm/llvm-project/pull/99713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,12 @@
+.. title:: clang-tidy - modernize-use-cpp-style-comments
+
+modernize-use-cpp-style-comments
+
+
+Finds C-style comments and suggests to use C++ style comments `//`.
+
+
+.. code-block:: c++
+
+ memcpy(a, b, sizeof(int) * 5); /* u
@@ -0,0 +1,67 @@
+//===--- UseCppStyleCommentsCheck.cpp -
clang-tidy-===//
+
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,38 @@
+//===--- UseCppStyleCommentsCheck.h -
clang-tidy---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -172,6 +172,11 @@ New checks
Detects variables and functions that can be marked as static or moved into
an anonymous namespace to enforce internal linkage.
+- New :doc:`modernize-use-cpp-style-comments
+ ` check.
+
+ Find C Style comments and suggests to use C++ style
https://github.com/njames93 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/99713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %check_clang_tidy -std=c++11 %s modernize-use-cpp-style-comments %t
+
+static auto PI = 3.14159265; /* value of pi upto 8 decimal places */
+// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: use C++ style comments '//'
instead of C style comments '/*...*/' [m
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/99433
>From ebf25d890ff47be48bd153942d943906943a247b Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 17 Jul 2024 22:30:21 -0700
Subject: [PATCH 1/3] [clang-format] Fix a bug in annotating `*` in `#define`s
Fixes #99
https://github.com/asl approved this pull request.
Neat!
https://github.com/llvm/llvm-project/pull/99741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a96c906102e8d0284c7a402eac4fa1ad9ab3e871
5822eb8f5b0d420a89d539f8fd2e23c69983967a --e
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oliver Hunt (ojhunt)
Changes
Fixes an error where we use the wrong authentication schema for secondary
vtable pointers in constant initialized globals of types with multiple
polymorphic base classes.
---
Full diff: https://github.com/llv
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Oliver Hunt (ojhunt)
Changes
Fixes an error where we use the wrong authentication schema for secondary
vtable pointers in constant initialized globals of types with multiple
polymorphic base classes.
---
Full diff: https://github
ojhunt wrote:
@ahmedbougacha @asl @kovdan01 pinging for review
https://github.com/llvm/llvm-project/pull/99741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ojhunt created
https://github.com/llvm/llvm-project/pull/99741
Fixes an error where we use the wrong authentication schema for secondary
vtable pointers in constant initialized globals of types with multiple
polymorphic base classes.
>From 5822eb8f5b0d420a89d539f8fd2e23c699
BeMg wrote:
> * Updating clang tests to exercise this logic.
> * Actually running it at all. I did not build compiler-rt, and thus all my
> checking was of generated asm/IR.
Maybe we could compile the test code with
`compiler-rt/lib/builtins/riscv/feature_bits.c` manually. Then we could get r
@@ -62,6 +62,8 @@
#include "llvm/Support/MathExtras.h"
#include "llvm/Support/ScopedPrinter.h"
#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/TargetParser/RISCVISAInfo.h"
+#include "llvm/TargetParser/RISCVTargetParser.h"
BeMg wrote:
`RISCVT
@@ -1020,3 +1020,64 @@ std::string
RISCVISAInfo::getTargetFeatureForExtension(StringRef Ext) {
return isExperimentalExtension(Name) ? "experimental-" + Name.str()
: Name.str();
}
+
+struct RISCVExtBit {
+ const StringRef ext;
+ uint64
hubert-reinterpretcast wrote:
> PS: Sorry for misunderstanding the original issue.
Totally understandable. Thanks for following up on this.
> These changes pass all tests above:
Can you check this case with your build?
```cpp
struct A { int x; };
char q(int *);
short q(int A::*);
template
c
https://github.com/zeroomega closed
https://github.com/llvm/llvm-project/pull/99722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haowei
Date: 2024-07-19T21:42:57-07:00
New Revision: 72d8c2737bb557af9d0c735b9fa30b1b03485627
URL:
https://github.com/llvm/llvm-project/commit/72d8c2737bb557af9d0c735b9fa30b1b03485627
DIFF:
https://github.com/llvm/llvm-project/commit/72d8c2737bb557af9d0c735b9fa30b1b03485627.diff
LOG: [
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/99722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chaitanyav edited
https://github.com/llvm/llvm-project/pull/99713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -49,7 +48,25 @@
#define __need_rsize_t
#endif
#define __need_wchar_t
+#if !defined(__STDDEF_H) && !__building_module(_Builtin_stddef)
ian-twilightcoder wrote:
We do still need everything when we're building with modules for the reasons
outlined in the comm
@@ -783,51 +783,76 @@ static void ProcessVersionedAPINotes(
}
}
+static std::optional
+UnwindNamespaceContext(DeclContext *DC, api_notes::APINotesManager &APINotes) {
+ if (auto NamespaceContext = dyn_cast(DC)) {
+for (auto Reader : APINotes.findAPINotes(NamespaceContex
@@ -456,6 +458,7 @@ template <> struct MappingTraits {
IO.mapOptional("EnumKind", T.EnumConvenienceKind);
IO.mapOptional("SwiftCopyable", T.SwiftCopyable);
IO.mapOptional("Methods", T.Methods);
+IO.mapOptional("Tags", T.Tags);
compnerd wrote:
H
chrisnc wrote:
ping
https://github.com/llvm/llvm-project/pull/97534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phoebewang wrote:
What's the ties mean here? The SDM uses `Round to nearest (even)`. As for
target intrinsic, I think we sholuld be close to target document. Also, will
GCC accept the name? We need compatibility with GCC, or even MSVC.
https://github.com/llvm/llvm-project/pull/99691
__
@@ -175,8 +175,6 @@ X86_FEATURE_COMPAT(AVX512BF16, "avx512bf16",
34)
X86_FEATURE_COMPAT(AVX512VP2INTERSECT, "avx512vp2intersect", 35)
// Below Features has some missings comparing to gcc, it's because gcc has some
// not one-to-one mapped in llvm.
-X86_FEATURE_
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/99716
>From 02012a704c4ad0c666d38bf2b2a7bf74c7f3b2c1 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Fri, 19 Jul 2024 17:33:08 -0500
Subject: [PATCH] [Clang] Fix C library wrappers for offloading
Summary:
This block
https://github.com/shiltian converted_to_draft
https://github.com/llvm/llvm-project/pull/99732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21703,32 +21703,37 @@ const ValueDecl
*SemaOpenMP::getOpenMPDeclareMapperVarName() const {
return cast(DSAStack->getDeclareMapperVarRef())->getDecl();
}
-OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(Expr *NumTeams,
+OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(A
https://github.com/phoebewang approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/99352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shilei Tian (shiltian)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/99732.diff
7 Files Affected:
- (modified) clang/include/clang/AST/OpenMPClause.h (+48-31)
- (modified) clang/include/clang/AST/RecursiveASTVisitor
shiltian wrote:
* **#99732** https://app.graphite.dev/github/pr/llvm/llvm-project/99732?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈
* `main`
This stack of pull requests is managed by Graphi
https://github.com/shiltian ready_for_review
https://github.com/llvm/llvm-project/pull/99732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian created
https://github.com/llvm/llvm-project/pull/99732
None
>From 299dca893dc70f5d56895e78900fe69023cbcd40 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Fri, 19 Jul 2024 22:07:06 -0400
Subject: [PATCH] [Clang][OpenMP] Allow `num_teams` to accept multiple
expres
https://github.com/slackito closed
https://github.com/llvm/llvm-project/pull/99731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jorge Gorbe Moya
Date: 2024-07-19T18:58:25-07:00
New Revision: abaf13ad589d72b356a8788a5095f869d9d038d0
URL:
https://github.com/llvm/llvm-project/commit/abaf13ad589d72b356a8788a5095f869d9d038d0
DIFF:
https://github.com/llvm/llvm-project/commit/abaf13ad589d72b356a8788a5095f869d9d038d0.di
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/99731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Jorge Gorbe Moya (slackito)
Changes
Reverts llvm/llvm-project#99545
There were a couple of issues reported in the PR: a sanitizer warning
(https://lab.llvm.org/buildbot/#/builders/164/builds/1246/steps/14/logs/stdio)
and a tmp fil
https://github.com/slackito created
https://github.com/llvm/llvm-project/pull/99731
Reverts llvm/llvm-project#99545
There were a couple of issues reported in the PR: a sanitizer warning
(https://lab.llvm.org/buildbot/#/builders/164/builds/1246/steps/14/logs/stdio)
and a tmp file accidentally
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/66/builds/1861
Here is the relevant piece of the bu
jhuber6 wrote:
> Yeah, rewriting the function signature is gonna be quite a hassle. LG for now.
>
> If we change the function signature, does it make easier to set default
> argument?
It'll be similar code, but it would allow us to use the same helpers that the
other targets use.
https://git
@@ -49,7 +48,25 @@
#define __need_rsize_t
#endif
#define __need_wchar_t
+#if !defined(__STDDEF_H) && !__building_module(_Builtin_stddef)
zygoloid wrote:
I'm not sure that the second condition here makes any difference: I'd think the
only way we could get here
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/99426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Max Winkler
Date: 2024-07-19T18:04:39-07:00
New Revision: 4a739fb53cacdb850d27b164dd6f173d21d5f083
URL:
https://github.com/llvm/llvm-project/commit/4a739fb53cacdb850d27b164dd6f173d21d5f083
DIFF:
https://github.com/llvm/llvm-project/commit/4a739fb53cacdb850d27b164dd6f173d21d5f083.diff
L
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ian Anderson (ian-twilightcoder)
Changes
stddef.h always includes __stddef_null.h. This is fine in modules because it's
not possible to re-include the pcm, and it's necessary to export the
_Builtin_stddef.null submodule. However, without
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Ian Anderson (ian-twilightcoder)
Changes
stddef.h always includes __stddef_null.h. This is fine in modules because it's
not possible to re-include the pcm, and it's necessary to export the
_Builtin_stddef.null submodule. However, wi
https://github.com/ian-twilightcoder created
https://github.com/llvm/llvm-project/pull/99727
stddef.h always includes __stddef_null.h. This is fine in modules because it's
not possible to re-include the pcm, and it's necessary to export the
_Builtin_stddef.null submodule. However, without modu
mizvekov wrote:
> We already do that :) the problem is when what follows `A` _doesn't_
> unambiguously look like a template argument list:
Sure, but before CWG1835, we would perform the lookup anyway and treat the
`<0>` as a template argument list, even if it isn't unambiguously a template
ar
DeinAlptraum wrote:
\*Ping*
@Endilll do you have time to take a look at this?
https://github.com/llvm/llvm-project/pull/98745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahmedbougacha edited
https://github.com/llvm/llvm-project/pull/99726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahmedbougacha created
https://github.com/llvm/llvm-project/pull/99726
We want to be able to support full type and address discrimination of type_info
on targets that don't have existing ABI compatibility constraints.
This patch does not enable such behavior on any platform,
sdkrystian wrote:
> > @mizvekov Without unannotated tentative parsing (to be _properly_
> > introduced by #96364), issuing a warning is infeasible. Either way, by the
> > time we detect the error we could be who knows how deep into the second
> > operand of a `>` operator.
>
> So when we are
https://github.com/sayhaan updated
https://github.com/llvm/llvm-project/pull/99225
>From f07d79ccb57075ee75783cb4bd5cba4b4ca6af80 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Tue, 1 Jun 2021 11:37:41 -0700
Subject: [PATCH 1/4] Rebase: [Facebook] Add clang driver options to test debug
info
MaskRay wrote:
For future reverts, consider adding some rationale :)
https://github.com/llvm/llvm-project/pull/99711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STOP
-Original Message-
From:
Sent: Fri, 19 Jul 2024 17:05:11 -0700
To: 7578703...@txt.att.net
Subject: =?utf-8?q?cfe-commits_Digest=2C_Vol_205=2C_Issue_1727?=
>Send cfe-commits mailing list submissions to
> cfe-commits@lists.llvm.org
>
>To subscribe or unsubscribe via the
andykaylor wrote:
This is a refreshed version of https://github.com/llvm/llvm-project/pull/91271.
Given how long it's been since I updated that PR, it seemed better to just
start fresh.
https://github.com/llvm/llvm-project/pull/99723
___
cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Julius Alexandre (medievalghoul)
Changes
**Issue:** https://github.com/llvm/llvm-project/issues/94373
---
Full diff: https://github.com/llvm/llvm-project/pull/99724.diff
1 Files Affected:
- (modified) clang/utils/TableGen/ClangOptionDoc
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andy Kaylor (andykaylor)
Changes
This change refactors the fp-contract handling in
RenderFloatingPointOptions in the clang driver code and fixes some
inconsistencies in the way warnings are reported for changes in the
fp-contract behavior.
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Andy Kaylor (andykaylor)
Changes
This change refactors the fp-contract handling in
RenderFloatingPointOptions in the clang driver code and fixes some
inconsistencies in the way warnings are reported for changes in the
fp-contract beh
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/medievalghoul created
https://github.com/llvm/llvm-project/pull/99724
**Issue:** https://github.com/llvm/llvm-project/issues/94373
>From 1d6e719fdf70ff77657f2c021839f549abada120 Mon Sep 17 00:00:00 2001
From: medievalghoul <61852278+medievalgh...@users.noreply.github.com>
Dat
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/99723
This change refactors the fp-contract handling in
RenderFloatingPointOptions in the clang driver code and fixes some
inconsistencies in the way warnings are reported for changes in the
fp-contract behavior.
>
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haowei (zeroomega)
Changes
This patch removes CMAKE_XXX_LINKER_FLAGS from list of flags that passed
through to stage2 build.
---
Full diff: https://github.com/llvm/llvm-project/pull/99722.diff
1 Files Affected:
- (modified) clang/cmake
https://github.com/zeroomega created
https://github.com/llvm/llvm-project/pull/99722
This patch removes CMAKE_XXX_LINKER_FLAGS from list of flags that passed
through to stage2 build.
>From d86ac6711d8a84e3f5d9d59d7ad181d26f9ef89f Mon Sep 17 00:00:00 2001
From: Haowei Wu
Date: Fri, 19 Jul 2024
mizvekov wrote:
> @mizvekov Without unannotated tentative parsing (to be _properly_ introduced
> by #96364), issuing a warning is infeasible. Either way, by the time we
> detect the error we could be who knows how deep into the second operand of a
> `>` operator.
So when we are parsing `this-
zwuis wrote:
These changes pass all tests above:
```diff
-if (isa(op) && cast(op)->getQualifier()) {
+if (isa(op) && cast(op)->getQualifier() &&
+!isa(OrigOp.get())) {
DeclContext *Ctx = dcl->getDeclContext();
if (Ctx && Ctx->isRecord()) {
if (dcl->getType()->isReferenceType()) {
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/99716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian approved this pull request.
Yeah, rewriting the function signature is gonna be quite a hassle. LG for now.
If we change the function signature, does it make easier to set default
argument?
https://github.com/llvm/llvm-project/pull/99716
_
https://github.com/sayhaan updated
https://github.com/llvm/llvm-project/pull/99225
>From f07d79ccb57075ee75783cb4bd5cba4b4ca6af80 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Tue, 1 Jun 2021 11:37:41 -0700
Subject: [PATCH 1/3] Rebase: [Facebook] Add clang driver options to test debug
info
sdkrystian wrote:
> Another option would be to apply the resolution to all modes, but recover and
> issue a warning instead of an error. How feasible would that be?
@mizvekov Without unannotated tentative parsing (to be _properly_ introduced by
#96364), issuing a warning is infeasible. Either
@@ -8108,6 +8108,24 @@ but do not pass them to the underlying coroutine or pass
them by value.
}];
}
+def CoroAwaitElidableDoc : Documentation {
+ let Category = DocCatDecl;
+ let Content = [{
+The ``[[clang::coro_await_elidable]]`` is a class attribute which can be
applie
@@ -8108,6 +8108,24 @@ but do not pass them to the underlying coroutine or pass
them by value.
}];
}
+def CoroAwaitElidableDoc : Documentation {
+ let Category = DocCatDecl;
+ let Content = [{
+The ``[[clang::coro_await_elidable]]`` is a class attribute which can be
applie
@@ -825,6 +826,32 @@ ExprResult Sema::BuildOperatorCoawaitLookupExpr(Scope *S,
SourceLocation Loc) {
return CoawaitOp;
}
+static bool isAttributedCoroInplaceTask(const QualType &QT) {
+ auto *Record = QT->getAsCXXRecordDecl();
+ return Record && Record->hasAttr();
+}
+
+s
ojhunt wrote:
@asl could you check this as well? (I apparently can't add/request reviewers?)
https://github.com/llvm/llvm-project/pull/99576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Oliver Hunt (ojhunt)
Changes
Introduces type based signing of member function pointers. To support this
discrimination schema we no longer emit member function pointer to virtual
methods and indices into a vtable but migrate to us
https://github.com/ojhunt ready_for_review
https://github.com/llvm/llvm-project/pull/99576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/99576
>From 547ce3e9c7fe7e046b20f51f2f0d370a683659d1 Mon Sep 17 00:00:00 2001
From: Ahmed Bougacha
Date: Fri, 10 May 2024 15:58:57 -0700
Subject: [PATCH] [PAC] Implement pointer authentication for C++ member
function p
https://github.com/chaitanyav updated
https://github.com/llvm/llvm-project/pull/99713
>From 2899eab6f5d9bbed72a20b8da9e01ebccf7b576c Mon Sep 17 00:00:00 2001
From: NagaChaitanya Vellanki
Date: Fri, 19 Jul 2024 14:26:23 -0700
Subject: [PATCH] [clang-tidy]
modernize-use-cpp-style-comments chec
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fada9227325b3eaa0bdc09a486f29a7f08b7b3fb
fc4e93006a8a1def0fabdc358ce85fac267e5a63 --e
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/92731
>From fc4e93006a8a1def0fabdc358ce85fac267e5a63 Mon Sep 17 00:00:00 2001
From: Julian Brown
Date: Wed, 1 May 2024 06:35:59 -0500
Subject: [PATCH] [OpenMP] OpenMP 5.1 "assume" directive parsing support
This patch sup
https://github.com/azhan92 updated
https://github.com/llvm/llvm-project/pull/99511
>From 52100e3378c86eddb9a4757f8f3e175804a6dc76 Mon Sep 17 00:00:00 2001
From: Alison Zhang
Date: Thu, 18 Jul 2024 10:27:40 -0400
Subject: [PATCH 1/8] Add support for -mcpu=pwr11 / -mtune=pwr11
---
clang/lib/Bas
STOP
-Original Message-
From:
Sent: Fri, 19 Jul 2024 16:01:19 -0700
To: 7578703...@txt.att.net
Subject: =?utf-8?q?cfe-commits_Digest=2C_Vol_205=2C_Issue_1719?=
>Send cfe-commits mailing list submissions to
> cfe-commits@lists.llvm.org
>
>To subscribe or unsubscribe via the
DenisGZM wrote:
> Have sent you a PR to your branch with one test file :) Hope that helps!
Thanks a lot! Still need some time to get used to these unit tests, but it's
getting better :)
https://github.com/llvm/llvm-project/pull/99646
___
cfe-commits
1 - 100 of 409 matches
Mail list logo
