llvmbot wrote:
@llvm/pr-subscribers-backend-x86
@llvm/pr-subscribers-clang
Author: Phoebe Wang (phoebewang)
Changes
This is how MSVC handles it. https://godbolt.org/z/Eav3vx7cd
---
Full diff: https://github.com/llvm/llvm-project/pull/97939.diff
2 Files Affected:
- (modified) clang/lib/
https://github.com/phoebewang created
https://github.com/llvm/llvm-project/pull/97939
This is how MSVC handles it. https://godbolt.org/z/Eav3vx7cd
>From cf19ec8d705434ca6d989a72069dba1040c360ca Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Sun, 7 Jul 2024 13:14:59 +0800
Subject: [PATCH] [X8
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while,
tok::kw_switch);
};
+ // Detecting functions is brittle. It wo
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/97938.diff
3 Files Affected:
- (modified) clang/lib/Format/FormatToken.h (+1)
- (modified) clang/lib/Format/TokenAnnotator.cpp (+6)
- (modified
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/97938
None
>From eb53318b3c5dec2452c4a0d5aed7944ebdd99380 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 6 Jul 2024 22:21:26 -0700
Subject: [PATCH] [clang-format][NFC] Annotate function decl l_paren
---
clang/lib
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/97933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This patch adds a self-assignment check to the ObjCMethodList assignment
operator to prevent issues when an object is assigned to itself.
The fix ensures the integrity of the object's data during such assignments.
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/97933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/97933
…nment
This patch adds a self-assignment check to the ObjCMethodList assignment
operator to prevent issues when an object is assigned to itself.
The fix ensures the integrity of the object's data during such a
@@ -60,3 +60,26 @@ template C1>> auto t3() {
template C1>> auto t3();
static_assert(is_same()), X>>>);
#endif
+
+namespace GH95735 {
+
+int g(int fn) {
+ return [f = fn](auto tpl) noexcept(noexcept(f)) { return f; }(0);
+}
+
+int foo(auto... fn) {
+ // FIXME: This one hits th
zyn0217 wrote:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/97166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/97166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Younan Zhang
Date: 2024-07-07T09:46:38+08:00
New Revision: f4c781174b4b8fd958d9074c25eb06b6e276cb1c
URL:
https://github.com/llvm/llvm-project/commit/f4c781174b4b8fd958d9074c25eb06b6e276cb1c
DIFF:
https://github.com/llvm/llvm-project/commit/f4c781174b4b8fd958d9074c25eb06b6e276cb1c.diff
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/97166
>From 91a28dcde9dc569b955df92db91c858c550f6ad3 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 29 Jun 2024 21:32:01 +0800
Subject: [PATCH] [Clang] Add captures to the instantiation scope for noexcept
spec
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/70976
>From a91f499900d4cea4804833d004b6c4e54a7d8b15 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sun, 3 Sep 2023 17:26:28 -0700
Subject: [PATCH 1/5] [clang] Extend diagnose_if to accept more detailed
warni
https://github.com/zyn0217 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/97913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -636,6 +636,9 @@ bool Sema::SetupConstraintScope(
? FD->getInstantiatedFromMemberFunction()
: FD->getInstantiatedFromDecl();
+if (!InstantiatedFrom)
+ return true;
+
zyn0217 wrote:
This is unnecessary.
For both `TK_MemberSp
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/97913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (MagentaTreehouse)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/97930.diff
1 Files Affected:
- (modified) clang/include/clang/AST/UnresolvedSet.h (+2-3)
``diff
diff --git a/clang/include/clang/AST/Un
https://github.com/MagentaTreehouse created
https://github.com/llvm/llvm-project/pull/97930
None
>From de625afb940fb87efa10c0ecf0e67c9930eab182 Mon Sep 17 00:00:00 2001
From: Mingyi Chen
Date: Sat, 6 Jul 2024 21:25:15 -0400
Subject: [PATCH] [clang] [NFC] Mark `UnresolvedSetImpl`'s move operati
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From c05d739d105b76fcf83985b20762809f6eea6f40 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?=
=?UTF-8?q?an?=
Date: Sat, 6 Jul 2024 17:22:55 -0700
Subject: [
vegerot wrote:
@AaronBallman please review
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Max Coplan (vegerot)
Changes
This patch adds -Wimplicit-fallthrough to -Wextra. GCC already includes it in
-Wextra.
This patch also adds a test to check that -Wimplicit-fallthrough is included in
-Wextra.
Note: This patch may regress pe
https://github.com/vegerot ready_for_review
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/vegerot created
https://github.com/llvm/llvm-project/pull/97926
This patch adds -Wimplicit-fallthrough to -Wextra. GCC already includes it in
-Wextra.
This patch also adds a test to check that -Wimplicit-fallthrough is included in
-Wextra.
Note: This patch may regress perf
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/97915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2024-07-07T08:15:09+09:00
New Revision: f767295942288bd70156ad322defac60b568c927
URL:
https://github.com/llvm/llvm-project/commit/f767295942288bd70156ad322defac60b568c927
DIFF:
https://github.com/llvm/llvm-project/commit/f767295942288bd70156ad322defac60b568c927.diff
L
https://github.com/h-vetinari updated
https://github.com/llvm/llvm-project/pull/96171
>From 1df587efeb71fb1929667f008d7e9b251863d9d8 Mon Sep 17 00:00:00 2001
From: "H. Vetinari"
Date: Thu, 20 Jun 2024 21:43:31 +1100
Subject: [PATCH 1/4] [cmake] switch to CMake's native check_linker_flag,
delet
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/97915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/97915.diff
1 Files Affected:
- (modified) clang-tools-extra/clangd/support/ThreadsafeFS.cpp (+1-1)
``diff
diff --git a
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/97915
None
>From 91325539452e0fabef33894d66a0f643319891f2 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 29 Jun 2024 12:40:11 -0700
Subject: [PATCH] [clangd] Use std::make_unique (NFC)
---
clang-tools-
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This patch adds a null check for InstantiatedFrom to prevent dereferencing a
null pointer during the template instantiation process in
clang::Sema::SetupConstraintScope().
The fix ensures that the function exits e
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/97913
This patch adds a null check for InstantiatedFrom to prevent dereferencing a
null pointer during the template instantiation process in
clang::Sema::SetupConstraintScope().
The fix ensures that the function exi
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/97912
>From c30e531027828d7b531d3791c48779b465e69360 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Sat, 6 Jul 2024 14:02:16 -0700
Subject: [PATCH 1/3] [Clang] Prevent null pointer dereference in
TransformUnaryT
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8426b51e0e942b27af8a50b9cee53c1b68d139c2
87eceedcfabb4f3f3b7c69f970716a40c745bf7a --
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/97912
>From c30e531027828d7b531d3791c48779b465e69360 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Sat, 6 Jul 2024 14:02:16 -0700
Subject: [PATCH 1/2] [Clang] Prevent null pointer dereference in
TransformUnaryT
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This patch adds null check after TransformType call to avoid dereferencing a
null pointer when calling getType().
---
Full diff: https://github.com/llvm/llvm-project/pull/97912.diff
1 Files Affected:
- (modified
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/97912
This patch adds null check after TransformType call to avoid dereferencing a
null pointer when calling getType().
>From c30e531027828d7b531d3791c48779b465e69360 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Da
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const
CountAttributedType *T) {
Expr *CountExpr = importChecked(Err, T->getCountExpr());
SmallVector CoupledDecls;
- for (auto TI : T->dependent_decls()) {
+ for (const TypeCoupledDeclRefInfo &TI : T->depen
https://github.com/MagentaTreehouse updated
https://github.com/llvm/llvm-project/pull/97908
>From def9d161e4ea79ee1b24a8d662a5c0dd17c2dd8f Mon Sep 17 00:00:00 2001
From: Mingyi Chen
Date: Sat, 6 Jul 2024 15:41:08 -0400
Subject: [PATCH 1/2] [clang][Sema] Improve `collectViableConversionCandidate
mikecrowe wrote:
I'm not particularly happy with the `FormatStringConverter` constructor now
taking seven parameters. The risk of them getting muddled isn't huge though
because they are all of different types. Should I perhaps put them all into the
`FormatStringConverter::Configuration` struct
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Mike Crowe (mikecrowe)
Changes
Expanding all macros in the printf/absl::StrFormat format string before
conversion could easily break code if those macros are expended to change their
definition between builds. It's important f
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Mike Crowe (mikecrowe)
Changes
Expanding all macros in the printf/absl::StrFormat format string before
conversion could easily break code if those macros are expended to change their
definition between builds. It's important for this
https://github.com/mikecrowe created
https://github.com/llvm/llvm-project/pull/97911
Expanding all macros in the printf/absl::StrFormat format string before
conversion could easily break code if those macros are expended to change their
definition between builds. It's important for this check
https://github.com/GO-NFT-GO commented:
Ok
https://github.com/llvm/llvm-project/pull/97392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This patch addresses static analyzer concern where TSI could be dereferenced
after being assigned a null value from SubstType in
clang::TemplateDeclInstantiator::VisitUsingEnumDecl(clang::UsingEnumDecl *).
The fix
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/97910
This patch addresses static analyzer concern where TSI could be dereferenced
after being assigned a null value from SubstType in
clang::TemplateDeclInstantiator::VisitUsingEnumDecl(clang::UsingEnumDecl *).
The
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (MagentaTreehouse)
Changes
* Use range-based for
* The value of `Conv` is not used when `ConvTemplate` is not null, so we do not
need to compute it on that path
---
Full diff: https://github.com/llvm/llvm-project/pull/97908.diff
1
https://github.com/MagentaTreehouse created
https://github.com/llvm/llvm-project/pull/97908
* Use range-based for
* The value of `Conv` is not used when `ConvTemplate` is not null, so we do not
need to compute it on that path
>From def9d161e4ea79ee1b24a8d662a5c0dd17c2dd8f Mon Sep 17 00:00:00 2
@@ -2379,23 +2379,32 @@ Sema::LambdaScopeForCallOperatorInstantiationRAII::
SemaRef.RebuildLambdaScopeInfo(cast(FD));
- FunctionDecl *Pattern = getPatternFunctionDecl(FD);
- if (Pattern) {
-SemaRef.addInstantiatedCapturesToScope(FD, Pattern, Scope, MLTAL);
+ Function
https://github.com/LYP951018 updated
https://github.com/llvm/llvm-project/pull/97215
>From a997ae70f86230200b1082c9bdc0bdf56e30b7c4 Mon Sep 17 00:00:00 2001
From: letrec
Date: Sun, 30 Jun 2024 21:03:23 +0800
Subject: [PATCH 1/2] Fix the order of addInstantiatedParameters in
LambdaScopeForCallO
@@ -365,7 +365,12 @@ int DwarfInstructions::stepWithDwarf(A
&addressSpace, pint_t pc,
// Return address is address after call site instruction, so setting IP
to
// that does simulates a return.
- newRegisters.setIP(returnAddress);
+ //
+ // In case
MaskRay wrote:
> I'm not the owner of this code, but I just dropped by to say that I don't
> think this patch will be accepted. A few lines above your changes, there is a
> comment that says, "Please don't add more elements to *Triples.".
>
> @MaskRay is working to reduce the number of target
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/82232
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -905,6 +912,7 @@ void Preprocessor::Lex(Token &Result) {
// This token is injected to represent the translation of '#include "a.h"'
// into "import a.h;". Mimic the notional ';'.
case tok::annot_module_include:
+case tok::annot_repl_input_end:
---
@@ -860,9 +861,15 @@ bool Preprocessor::HandleIdentifier(Token &Identifier) {
ModuleImportLoc = Identifier.getLocation();
NamedModuleImportPath.clear();
IsAtImport = true;
-ModuleImportExpectsIdentifier = true;
CurLexerCallback = CLK_LexAfterModuleImport;
@@ -35,6 +35,7 @@
#include "clang/Basic/SourceLocation.h"
#include "clang/Basic/SourceManager.h"
#include "clang/Basic/TargetInfo.h"
+#include "clang/Basic/TokenKinds.h"
cor3ntin wrote:
I don't think we need that change
https://github.com/llvm/llvm-project/pu
@@ -160,6 +160,8 @@ static char GetFirstChar(const Preprocessor &PP, const
Token &Tok) {
bool TokenConcatenation::AvoidConcat(const Token &PrevPrevTok,
const Token &PrevTok,
const Token &Tok) const {
+
@@ -741,6 +757,9 @@ class IdentifierTable {
if (Name == "import")
II->setModulesImport(true);
+if (Name == "module")
cor3ntin wrote:
```suggestion
else if (Name == "module")
```
https://github.com/llvm/llvm-project/pull/90574
___
https://github.com/cor3ntin commented:
I think this is starting to look pretty good.
Can we simplify further by lexing the partition along with the module name,
when there is one?
We could also have a ModuleNameInfo::toString() function we could use in a
couple places.
https://github.com/llv
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexMaclean wrote:
> Can you add some tests to demonstrate that this patch will enable more
> optimizations in some real-world applications?
I can extend the existing test cases to make them more elaborate/real-looking,
but I'm guessing that would not qualify as "real-world". This patch is
mo
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/97900
>From dd36ef6dd52f57d175fd60534172f0e28e11ef48 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Sat, 6 Jul 2024 08:29:26 -0700
Subject: [PATCH 1/3] [InstallAPI] Fix potential null pointer dereference in
file
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
Reported by Static Analyzer Tool:
In clang::ASTNodeImporter::VisitCountAttributedType(clang::CountAttributedType
const *): Using the auto keyword without an & causes the copy of an object
of type TypeCoupledDeclRe
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/97902
Reported by Static Analyzer Tool:
In clang::ASTNodeImporter::VisitCountAttributedType(clang::CountAttributedType
const *): Using the auto keyword without an & causes the copy of an object of
type TypeCoupledDe
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/97900
>From dd36ef6dd52f57d175fd60534172f0e28e11ef48 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Sat, 6 Jul 2024 08:29:26 -0700
Subject: [PATCH 1/2] [InstallAPI] Fix potential null pointer dereference in
file
memory-thrasher wrote:
PR updated to output mangled function name matching the one from godbolt for
this specific use case. I suggest someone better at this stuff than me should
eventually attempt to implement a more comprehensive mimicry.
https://github.com/llvm/llvm-project/pull/97792
__
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From 9f909ffb4714294d62264e541a44137adfcd7cb9 Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds an arbitrary pseudonym to clang"s windows mangler to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9e9404387d3b787305dc8bf21b0e20c477b6ff39
dd36ef6dd52f57d175fd60534172f0e28e11ef48 --
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/97900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/97900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This patch addresses a static analyser concern about a potential null pointer
dereference in the clang::installapi::enumerateFiles function.
The recursive_directory_iterator could become invalid (i.e., i.State set
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/97900
This patch addresses a static analyser concern about a potential null pointer
dereference in the clang::installapi::enumerateFiles function.
The recursive_directory_iterator could become invalid (i.e., i.State
memory-thrasher wrote:
> Godbolt for reference: https://godbolt.org/z/b9v8KhPET
Huh. Must be my vstools install on this windows laptop is out of date or broken
in some other way. I could copy the scheme in that use case into my PR for at
least a non-zero chance that it would match the msvc man
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/6] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
Author: cor3ntin
Date: 2024-07-06T16:18:20+02:00
New Revision: e55585fd7bddf5bb3824a53cbe2971206d3c20c6
URL:
https://github.com/llvm/llvm-project/commit/e55585fd7bddf5bb3824a53cbe2971206d3c20c6
DIFF:
https://github.com/llvm/llvm-project/commit/e55585fd7bddf5bb3824a53cbe2971206d3c20c6.diff
LOG:
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/96228
>From 9e2730da07df0ee5102912490a687ba40bf06def Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Mon, 24 Jun 2024 18:55:51 +0300
Subject: [PATCH] [Clang] fix cast failures by adjusting the resolution of
record
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/97860
>From cb3c677c9eb10998ed7357cdde2722f3b3c1c847 Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Sat, 6 Jul 2024 00:24:06 +0300
Subject: [PATCH] [Clang] prevent checking destructor reference with an invalid
in
cor3ntin wrote:
> Thank you work on this! I really like this feature. Will this PR also provide
> support for the new constant interpreter? The new constant interpreter seems
> to already support some unknown constexpr features (FYI
> https://godbolt.org/z/xTYhGEfxT). It has the concept of `Du
pdherbemont wrote:
> LGTM. Let me know if you need me to merge this change.
Yes, please!
https://github.com/llvm/llvm-project/pull/95455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/97338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1165,6 +1165,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineType("__WCHAR_TYPE__", TI.getWCharType(), Builder);
DefineType("__WINT_TYPE__", TI.getWIntType(), Builder);
DefineTypeSizeAndWidth("__SIG_ATOMIC", TI.getSigAtomicType(), TI, Builder)
@@ -2068,7 +2068,8 @@ bool Lexer::LexNumericConstant(Token &Result, const char
*CurPtr) {
}
// If we have a digit separator, continue.
- if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) {
+ if (C == '\'' &&
+ (LangOpts.CPlusPlus14 || LangOpts.C23 || Parsing
https://github.com/cor3ntin approved this pull request.
LGTM, thanks!
I think your fixme can be resolved in a follow up PR
https://github.com/llvm/llvm-project/pull/97166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux`
running on `ppc64le-sanitizer` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/72/builds/873
Here is the relevant piece of the buil
@@ -60,3 +60,26 @@ template C1>> auto t3() {
template C1>> auto t3();
static_assert(is_same()), X>>>);
#endif
+
+namespace GH95735 {
+
+int g(int fn) {
+ return [f = fn](auto tpl) noexcept(noexcept(f)) { return f; }(0);
+}
+
+int foo(auto... fn) {
+ // FIXME: This one hits th
@@ -2379,23 +2379,32 @@ Sema::LambdaScopeForCallOperatorInstantiationRAII::
SemaRef.RebuildLambdaScopeInfo(cast(FD));
- FunctionDecl *Pattern = getPatternFunctionDecl(FD);
- if (Pattern) {
-SemaRef.addInstantiatedCapturesToScope(FD, Pattern, Scope, MLTAL);
+ Function
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/96407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Gábor Spaits
Date: 2024-07-06T15:22:51+02:00
New Revision: de88b2cb16af4bba659d0bb2ddf10bda681ec84d
URL:
https://github.com/llvm/llvm-project/commit/de88b2cb16af4bba659d0bb2ddf10bda681ec84d
DIFF:
https://github.com/llvm/llvm-project/commit/de88b2cb16af4bba659d0bb2ddf10bda681ec84d.diff
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
cor3ntin wrote:
Thanks for the fix; I think this makes sense. Can you provide a release note?
https://github.com/llvm/llvm-project/pull/96509
___
cfe-commits mailing list
cfe-co
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/96407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/96686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3216,6 +3226,44 @@ void DeclareImplicitDeductionGuidesForTypeAlias(
Guides.suppressDiagnostics();
for (auto *G : Guides) {
+if (auto *DG = dyn_cast(G)) {
+ // The deduction guide is a non-template function decl, we just clone it.
+ auto *FunctionType =
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikolas Klauser (philnik777)
Changes
This reverts commit 567b2c608c307c097315dd5ec4d6a5bbcddf898d.
---
Full diff: https://github.com/llvm/llvm-project/pull/97894.diff
5 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+4-1)
-
https://github.com/zyn0217 approved this pull request.
One nit, otherwise LGTM.
Regarding the issue of attaching the constraint to a non-template function,
pragmatically, this is just something internal to compiler, and we're still
conforming to the standard in terms of the user's codes. So, i
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/97894
This reverts commit 567b2c608c307c097315dd5ec4d6a5bbcddf898d.
>From 43b1972a867bf9fa16fdf0d93dcbca4deae9fd13 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 29 Jun 2024 21:51:02 +0200
Subject: [PAT
bc-lee wrote:
I'm not the owner of this code, but I just dropped by to say that
I don't think this patch will be accepted. A few lines above your changes,
there is a comment that says, "Please don't add more elements to *Triples.".
@MaskRay is working to reduce the number of target triples like
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/97806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-07-06T15:52:19+04:00
New Revision: be3a8b8d94608746b22cb0cf3fc03af33b7d8648
URL:
https://github.com/llvm/llvm-project/commit/be3a8b8d94608746b22cb0cf3fc03af33b7d8648
DIFF:
https://github.com/llvm/llvm-project/commit/be3a8b8d94608746b22cb0cf3fc03af33b7d8648.
1 - 100 of 132 matches
Mail list logo
