[clang] [Clang][Comments] Attach comments to decl even if preproc directives are in between (PR #88367)

2024-06-30 Thread via cfe-commits
hdoc wrote: This is rebased onto the latest rev of the main branch and should be ready to go. We do not have commit permissions, so @AaronBallman could you please help merge this in? Thank you :) https://github.com/llvm/llvm-project/pull/88367 ___ c

[clang] [Clang][Comments] Attach comments to decl even if preproc directives are in between (PR #88367)

2024-06-30 Thread via cfe-commits
https://github.com/hdoc updated https://github.com/llvm/llvm-project/pull/88367 >From 5a07a5d133a86b229bdfd42343820f0877735f04 Mon Sep 17 00:00:00 2001 From: hdoc Date: Thu, 11 Apr 2024 01:54:18 -0700 Subject: [PATCH 1/5] Attach comments to decl even if preproc directives are in between --- c

[clang-tools-extra] [clangd] Enable passing a `FeatureModuleSet` to `clangdMain`. (PR #97255)

2024-06-30 Thread Michael Park via cfe-commits
https://github.com/mpark closed https://github.com/llvm/llvm-project/pull/97255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Enable passing a `FeatureModuleSet` to `clangdMain`. (PR #97255)

2024-06-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8598bcb9934dca16ea16d87304e00defc85d986c 01ae6c9aee33d3b2b0a00484bf7c041f6b90e710 --

[clang-tools-extra] [clangd] Enable passing a `FeatureModuleSet` to `clangdMain`. (PR #97255)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd @llvm/pr-subscribers-clang-tools-extra Author: Michael Park (mpark) Changes This diff adds an overload of `clangdMain` that makes a `FeatureModuleSet`. `clangdMain` was initially added in 56ac9d46a7c1 to allow custom builds of clangd outside of

[clang-tools-extra] [clangd] Enable passing a `FeatureModuleSet` to `clangdMain`. (PR #97255)

2024-06-30 Thread Michael Park via cfe-commits
https://github.com/mpark created https://github.com/llvm/llvm-project/pull/97255 This diff adds an overload of `clangdMain` that makes a `FeatureModuleSet`. `clangdMain` was initially added in 56ac9d46a7c1 to allow custom builds of clangd outside of the LLVM repo that link against clangd. Curre

[clang] [llvm] [X86][CodeGen] security check cookie execute only when needed (PR #95904)

2024-06-30 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/95904 >From 6d6619f8f7a37906ac45791487a4d63b51a48ad1 Mon Sep 17 00:00:00 2001 From: mahesh-attarde Date: Wed, 12 Jun 2024 06:15:51 -0700 Subject: [PATCH 1/7] added regcall strct by reg support --- clang/lib/Co

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-30 Thread weiwei chen via cfe-commits
weiweichen wrote: Here is a self contained simple repro test cpp file: ``` #include "clang/Basic/Diagnostic.h" #include "clang/Basic/DiagnosticIDs.h" #include "clang/Basic/DiagnosticOptions.h" #include "clang/Basic/TargetInfo.h" #include "llvm/ADT/SmallString.h" #include "llvm/TargetParser/Host

[clang] [clang] Default to -fno-sized-deallocation for AIX (PR #97076)

2024-06-30 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/97076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Clear moved-from deque to ensure valid state post-move (PR #97221)

2024-06-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support `guarded_by` attribute and related attributes inside C structs and support late parsing them (PR #95455)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -29,6 +30,22 @@ struct LOCKABLE Mutex {}; struct Foo { struct Mutex *mu_; + int a_value GUARDED_BY(mu_); + + struct Bar { +struct Mutex *other_mu ACQUIRED_AFTER(mu_); +struct Mutex *third_mu ACQUIRED_BEFORE(other_mu); + } bar; + + int* a_ptr PT_GUARDED_BY(bar

[clang] Support `guarded_by` attribute and related attributes inside C structs and support late parsing them (PR #95455)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -29,6 +30,22 @@ struct LOCKABLE Mutex {}; struct Foo { struct Mutex *mu_; + int a_value GUARDED_BY(mu_); + + struct Bar { +struct Mutex *other_mu ACQUIRED_AFTER(mu_); aaronpuchert wrote: I'm not entirely sure how nested `struct`s work in C, but sh

[clang] Support `guarded_by` attribute and related attributes inside C structs and support late parsing them (PR #95455)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -764,12 +764,6 @@ doesn't know that munl.mu == mutex. The SCOPED_CAPABILITY attribute handles aliasing for MutexLocker, but does so only for that particular pattern. -ACQUIRED_BEFORE(...) and ACQUIRED_AFTER(...) are currently unimplemented. --

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/97232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -1359,17 +1361,18 @@ void ThreadSafetyAnalyzer::getMutexIDs(CapExprSet &Mtxs, AttrType *Attr, const Expr *Exp, const NamedDecl *D, const CFGBlock *PredBlock,

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -1954,6 +1954,125 @@ struct TestTryLock { } // end namespace TrylockTest +// Regression test for trylock attributes with an enumerator success argument. +// Prior versions of the analysis silently failed to evaluate success arguments +// that were neither `CXXBoolLiteralEx

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -608,15 +606,31 @@ static bool checkTryLockFunAttrCommon(Sema &S, Decl *D, const ParsedAttr &AL, if (!AL.checkAtLeastNumArgs(S, 1)) return false; - if (!isIntOrBool(AL.getArgAsExpr(0))) { + // The attribute's first argument defines the success value. + const Expr

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert edited https://github.com/llvm/llvm-project/pull/95290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert commented: Don't want to give the wrong impression, I like the idea of this change a lot. But I think we need to be clearer about the attribute, the return value, and the relation between them. The attribute needs to be a constant expression for sure, and it's p

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
@@ -756,7 +771,68 @@ void etf_fun_params(int lvar EXCLUSIVE_TRYLOCK_FUNCTION(1)); // \ // Check argument parsing. -// legal attribute arguments +int global_int = 0; +int* etf_fun_with_global_ptr_success() EXCLUSIVE_TRYLOCK_FUNCTION(&global_int, &mu1); //\ + // expected-err

[libc] [libunwind] [WIP] Enough to get `libc` to build `clang` on `aarch64` (PR #97231)

2024-06-30 Thread Izaak Schroeder via cfe-commits
https://github.com/izaakschroeder updated https://github.com/llvm/llvm-project/pull/97231 >From 31dc769c1866a4a0100dde0a3743c215a9a5f5eb Mon Sep 17 00:00:00 2001 From: Izaak Schroeder Date: Sun, 30 Jun 2024 13:33:16 -0700 Subject: [PATCH 1/5] [libc]: add missing aarch64 headers --- libc/confi

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-30 Thread Aaron Puchert via cfe-commits
aaronpuchert wrote: Thanks for looping me in and sorry for the late reply! > However, I'm not certain we implement the analysis in an exception-aware way. If I remember correctly, the CFG is still without exception-handling edges by default, and support for those edges is still rudimentary and

[clang] [llvm] [Hashing] Use a non-deterministic seed if LLVM_ENABLE_ABI_BREAKING_CHECKS (PR #96282)

2024-06-30 Thread Mehdi Amini via cfe-commits
@@ -322,24 +306,20 @@ struct hash_state { } }; - -/// A global, fixed seed-override variable. -/// -/// This variable can be set using the \see llvm::set_fixed_execution_seed -/// function. See that function for details. Do not, under any circumstances, -/// set or read this

[clang] [llvm] [Hashing] Use a non-deterministic seed if LLVM_ENABLE_ABI_BREAKING_CHECKS (PR #96282)

2024-06-30 Thread Mehdi Amini via cfe-commits
joker-eph wrote: The premerge config seems broken because of this PR. https://github.com/llvm/llvm-project/pull/96282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Implement `-mbranch-protection=pauthabi` option (PR #97237)

2024-06-30 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 milestoned https://github.com/llvm/llvm-project/pull/97237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Implement `-mbranch-protection=pauthabi` option (PR #97237)

2024-06-30 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 created https://github.com/llvm/llvm-project/pull/97237 Enable the following ptrauth flags when `pauthabi` is passed as branch protection: - `intrinsics`; - `calls`; - `returns`; - `auth-traps`; - `vtable-pointer-address-discrimination`; - `vtable-pointer-type-discr

[clang] [llvm] [BPF] Fix linking issues in static map initializers (PR #91310)

2024-06-30 Thread Nick Zavaritsky via cfe-commits
mejedi wrote: @yonghong-song @efriedma-quic Any chance we could get it merged? https://github.com/llvm/llvm-project/pull/91310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support --sysroot= for ${arch}-windows-msvc targets (PR #96417)

2024-06-30 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/96417 >From 3a78dfee50e86f10051b681b4a6dee0071b0ca78 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sun, 23 Jun 2024 00:07:19 -0400 Subject: [PATCH] Support --sysroot= for ${arch}-windows-msvc targets I think it is

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/97232 From bc68b1bc25f7a04a0ddf2188ae26ed7853913b69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 11 Jun 2024 15:50:26 +0300 Subject: [PATCH] [clang] Disable C++14 sized deallocation by d

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-30 Thread via cfe-commits
https://github.com/ZijunZhaoCCK closed https://github.com/llvm/llvm-project/pull/97129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4997af98a008e71a3df61707559710d1c2769839 424eb0ff6b32abcb4eede92c1b2f78a32d3b37a6 --

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Martin Storsjö (mstorsjo) Changes This reverts 130e93cc26ca9d3ac50ec5a92e3109577ca2e702 for the MinGW target. This avoids the issue that is discussed in https://github.com/llvm/llvm-project/issues/96899 (and which is summarized in

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/97232 This reverts 130e93cc26ca9d3ac50ec5a92e3109577ca2e702 for the MinGW target. This avoids the issue that is discussed in https://github.com/llvm/llvm-project/issues/96899 (and which is summarized in the code comm

[libc] [libunwind] [WIP] Enough to get `libc` to build `clang` on `aarch64` (PR #97231)

2024-06-30 Thread Izaak Schroeder via cfe-commits
https://github.com/izaakschroeder edited https://github.com/llvm/llvm-project/pull/97231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [libunwind] [WIP] Enough to get `libc` to build `clang` (PR #97231)

2024-06-30 Thread Izaak Schroeder via cfe-commits
https://github.com/izaakschroeder updated https://github.com/llvm/llvm-project/pull/97231 >From 31dc769c1866a4a0100dde0a3743c215a9a5f5eb Mon Sep 17 00:00:00 2001 From: Izaak Schroeder Date: Sun, 30 Jun 2024 13:33:16 -0700 Subject: [PATCH 1/3] [libc]: add missing aarch64 headers --- libc/confi

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-06-30 Thread Aaron Puchert via cfe-commits
aaronpuchert wrote: Doesn't this fit better in `Sema/SemaDeclAttr.cpp`? That's where we're checking the attributes themselves and whether they make sense on a declaration. This would seem like a good place to check against previous declarations. Though to be fair, I don't know how late the lat

[libc] [libunwind] [WIP] Enough to get `libc` to build `clang` (PR #97231)

2024-06-30 Thread Izaak Schroeder via cfe-commits
https://github.com/izaakschroeder edited https://github.com/llvm/llvm-project/pull/97231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [libunwind] Enough to get `libc` to build `clang` (PR #97231)

2024-06-30 Thread Izaak Schroeder via cfe-commits
https://github.com/izaakschroeder created https://github.com/llvm/llvm-project/pull/97231 Companion to https://github.com/llvm/llvm-project/issues/97191 >From 31dc769c1866a4a0100dde0a3743c215a9a5f5eb Mon Sep 17 00:00:00 2001 From: Izaak Schroeder Date: Sun, 30 Jun 2024 13:33:16 -0700 Subject:

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add support for -export-dynamic which can match GCC behavior. (PR #72781)

2024-06-30 Thread Eli Schwartz via cfe-commits
eli-schwartz wrote: The `-export-dynamic` flag is supported by libtool, not gcc and not binutils ld. If passed to libtool, it will cause `$export_dynamic_flag_spec` as conditionally per-platform defined in a GNU autotools configure script to be evaluated and passed to the compiler: - for gcc,

[clang] [llvm] [APFloat] Add support for f8E4M3 IEEE 754 type (PR #97179)

2024-06-30 Thread Alexander Pivovarov via cfe-commits
@@ -136,6 +136,7 @@ static constexpr fltSemantics semIEEEquad = {16383, -16382, 113, 128}; static constexpr fltSemantics semFloat8E5M2 = {15, -14, 3, 8}; static constexpr fltSemantics semFloat8E5M2FNUZ = { 15, -15, 3, 8, fltNonfiniteBehavior::NanOnly, fltNanEncoding::Nega

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-30 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: Fixing https://lab.llvm.org/buildbot/#/builders/95/builds/672 in https://github.com/llvm/llvm-project/pull/97228 https://github.com/llvm/llvm-project/pull/81442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/97200 >From 0dea95701ca4dfca9b7d0bd889003fc35aa3017e Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 30 Jun 2024 10:39:15 +0100 Subject: [PATCH 1/9] [NFC] [Clang] Some core issues have changed status from ten

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-06-30 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97220 >From 63f45c952ff8ab7df261a150355a34267e4a645c Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sun, 30 Jun 2024 08:40:27 -0700 Subject: [PATCH 1/3] [Clang] Prevent null pointer dereference in designated ini

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-06-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2051736f7bc3fb1a8daaeecc854f93604a590aba 44c309e87d2101b554321741b1c751247a5b6478 --

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-06-30 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97220 >From 63f45c952ff8ab7df261a150355a34267e4a645c Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sun, 30 Jun 2024 08:40:27 -0700 Subject: [PATCH 1/2] [Clang] Prevent null pointer dereference in designated ini

[clang] [Serialization] Clear moved-from deque to ensure valid state post-move (PR #97221)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: None (smanna12) Changes This patch addresses a use-after-move issue, reported by static analyzer tool, by clearing the `PotentiallyInterestingDecls` deque after it has been moved to `MaybeInterestingDecls`. The fix ensures that t

[clang] [Serialization] Clear moved-from deque to ensure valid state post-move (PR #97221)

2024-06-30 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/97221 This patch addresses a use-after-move issue, reported by static analyzer tool, by clearing the `PotentiallyInterestingDecls` deque after it has been moved to `MaybeInterestingDecls`. The fix ensures that the s

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang-tools-extra` at step 4 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/863 Here is the relevan

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a9b1e80 - [clang-doc] add async loading (#93276)

2024-06-30 Thread via cfe-commits
Author: PeterChou1 Date: 2024-06-30T08:52:36-07:00 New Revision: a9b1e80acbb3249a245a7bbd8c8f89607bcad954 URL: https://github.com/llvm/llvm-project/commit/a9b1e80acbb3249a245a7bbd8c8f89607bcad954 DIFF: https://github.com/llvm/llvm-project/commit/a9b1e80acbb3249a245a7bbd8c8f89607bcad954.diff LO

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -7,6 +7,7 @@ // RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Rectangle.html -check-prefix=HTML-RECTANGLE // RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Circle.html -check-prefix=HTML-CIRCLE +// JSON-INDEX: var RootPath = "{{.*}}"; ilove

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: echo "CHECK: var RootPath = \"%/t/docs\";" > %t/check.txt +// RUN: cp "%s" "%t/test.cpp" +// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp --output=%t/docs ilovepi wrote: ```sug

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: echo "CHECK: var RootPath = \"%/t/docs\";" > %t/check.txt +// RUN: cp "%s" "%t/test.cpp" +// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp --output=%t/docs +// RUN: FileCheck %t/check.txt -input-

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: echo "CHECK: var RootPath = \"%/t/docs\";" > %t/check.txt +// RUN: cp "%s" "%t/test.cpp" ilovepi wrote: I see you're trying to work around the path inconsistency issues, but that's just an end-around

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes This patch adds a null check for the current method declaration before attempting to determine if it is a designated initializer. This prevents a potential null pointer dereference when `getCurMethodDecl()` return

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-06-30 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/97220 This patch adds a null check for the current method declaration before attempting to determine if it is a designated initializer. This prevents a potential null pointer dereference when `getCurMethodDecl()` re

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/97215 >From a997ae70f86230200b1082c9bdc0bdf56e30b7c4 Mon Sep 17 00:00:00 2001 From: letrec Date: Sun, 30 Jun 2024 21:03:23 +0800 Subject: [PATCH] Fix the order of addInstantiatedParameters in LambdaScopeForCallOpera

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: cp "%s" "%t/test.cpp" +// RUN: clang-doc --doxygen --executor=standalone -p %t %t/test.cpp -output=../docs +// RUN: FileCheck %s -input-file=%t/docs/index_json.js +// RUN: rm -rf %t + +// CHECK: var RootPath = "{{.*}}.

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: echo "CHECK: var RootPath = \"%t\";" > %t/check.txt +// RUN: cp "%s" "%t/test.cpp" +// RUN: clang-doc --doxygen --executor=standalone -p %t %t/test.cpp -output=%t/docs +// RUN: FileCheck %t/check.txt -input-file=%t/doc

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: echo "CHECK: var RootPath = \"%t\";" > %t/check.txt +// RUN: cp "%s" "%t/test.cpp" ilovepi wrote: what is this doing? `CHECK` lines belong in the test file, generally. If you need to split them up som

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: rm -rf %t +// RUN: mkdir %t ilovepi wrote: nit: Can be one line w/ `&&` https://github.com/llvm/llvm-project/pull/93281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] ac84ada - [clang] Avoid 'raw_string_ostream::str' (NFC)

2024-06-30 Thread Youngsuk Kim via cfe-commits
Author: Youngsuk Kim Date: 2024-06-30T10:02:49-05:00 New Revision: ac84ada9a169a72ad136ef05c2c194f594f24a37 URL: https://github.com/llvm/llvm-project/commit/ac84ada9a169a72ad136ef05c2c194f594f24a37 DIFF: https://github.com/llvm/llvm-project/commit/ac84ada9a169a72ad136ef05c2c194f594f24a37.diff

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
LYP951018 wrote: Sorry for disturbing... I'm trying to get the CI working. I can't figure out why buildkite/github-pull-requests failed... https://github.com/llvm/llvm-project/pull/97215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
https://github.com/LYP951018 reopened https://github.com/llvm/llvm-project/pull/97215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
https://github.com/LYP951018 closed https://github.com/llvm/llvm-project/pull/97215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/97215 >From a997ae70f86230200b1082c9bdc0bdf56e30b7c4 Mon Sep 17 00:00:00 2001 From: letrec Date: Sun, 30 Jun 2024 21:03:23 +0800 Subject: [PATCH] Fix the order of addInstantiatedParameters in LambdaScopeForCallOpera

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/97215 >From a997ae70f86230200b1082c9bdc0bdf56e30b7c4 Mon Sep 17 00:00:00 2001 From: letrec Date: Sun, 30 Jun 2024 21:03:23 +0800 Subject: [PATCH] Fix the order of addInstantiatedParameters in LambdaScopeForCallOpera

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-30 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK updated https://github.com/llvm/llvm-project/pull/95220 From 37292995de0c5aa87408586749795a97468d4725 Mon Sep 17 00:00:00 2001 From: Sebastian Wolf Date: Wed, 17 Apr 2024 16:16:35 +0200 Subject: [PATCH 01/25] Enforce SL.con.3: Add check to replace operator[] with at() o

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yupei Liu (LYP951018) Changes Currently, `addInstantiatedParameters` is called from the innermost lambda outward. However, when the function parameters of an inner lambda depend on the function parameters of an outer lambda, it can lead t

[clang] [Clang] Fix the order of addInstantiatedParameters in LambdaScopeForCallOperatorInstantiationRAII (PR #97215)

2024-06-30 Thread Yupei Liu via cfe-commits
https://github.com/LYP951018 created https://github.com/llvm/llvm-project/pull/97215 Currently, `addInstantiatedParameters` is called from the innermost lambda outward. However, when the function parameters of an inner lambda depend on the function parameters of an outer lambda, it can lead to

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-30 Thread Thorsten Schütt via cfe-commits
https://github.com/tschuett edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-30 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK updated https://github.com/llvm/llvm-project/pull/95220 From 37292995de0c5aa87408586749795a97468d4725 Mon Sep 17 00:00:00 2001 From: Sebastian Wolf Date: Wed, 17 Apr 2024 16:16:35 +0200 Subject: [PATCH 01/24] Enforce SL.con.3: Add check to replace operator[] with at() o

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-30 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK updated https://github.com/llvm/llvm-project/pull/95220 From 37292995de0c5aa87408586749795a97468d4725 Mon Sep 17 00:00:00 2001 From: Sebastian Wolf Date: Wed, 17 Apr 2024 16:16:35 +0200 Subject: [PATCH 01/23] Enforce SL.con.3: Add check to replace operator[] with at() o

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok edited https://github.com/llvm/llvm-project/pull/97200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Mital Ashok via cfe-commits
@@ -111,7 +111,7 @@ struct D : N::B { #endif } // namespace cwg2857 -namespace cwg2858 { // cwg2858: 19 tentatively ready 2024-04-05 +namespace cwg2858 { // cwg2858: 19 ready 2024-04-05 MitalAshok wrote: The date of the proposed resolution did not change for

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/97200 >From 0dea95701ca4dfca9b7d0bd889003fc35aa3017e Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 30 Jun 2024 10:39:15 +0100 Subject: [PATCH 1/8] [NFC] [Clang] Some core issues have changed status from ten

[clang] [Clang] Warn with -Wpre-c23-compat instead of -Wpre-c++17-compat for u8 character literals in C23 (PR #97210)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mital Ashok (MitalAshok) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/97210.diff 4 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/include/clang/Basic/DiagnosticLexKinds.td (+3) -

[clang] [Clang] Warn with -Wpre-c23-compat instead of -Wpre-c++17-compat for u8 character literals in C23 (PR #97210)

2024-06-30 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok created https://github.com/llvm/llvm-project/pull/97210 None >From c6ee783243e1888074778e2cb6de05df41cc8333 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 30 Jun 2024 12:55:04 +0100 Subject: [PATCH] [Clang] Warn with -Wpre-c23-compat instead of -Wpre-c++17

[clang] [Clang] [C23] Implement N2653: u8 strings are char8_t[] (PR #97208)

2024-06-30 Thread Mital Ashok via cfe-commits
MitalAshok wrote: CC @AaronBallman Also the clang-format issues are intentional to fit the style of the surrounding lines https://github.com/llvm/llvm-project/pull/97208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [Clang] [C23] Implement N2653: u8 strings are char8_t[] (PR #97208)

2024-06-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7d33d4720f85fa2df7c1307bcc185017b6e4dd25 ef0072d1fc9b14f7ee657fa95f44a686b78b525a --

[clang] [Clang] [C23] Implement N2653: u8 strings are char8_t[] (PR #97208)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mital Ashok (MitalAshok) Changes https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm Closes #97202 --- Full diff: https://github.com/llvm/llvm-project/pull/97208.diff 7 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (

[clang] [Clang] [C23] Implement N2653: u8 strings are char8_t[] (PR #97208)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Mital Ashok (MitalAshok) Changes https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm Closes #97202 --- Full diff: https://github.com/llvm/llvm-project/pull/97208.diff 7 Files Affected: - (modified) clang/docs/ReleaseNotes

[clang] [Clang] [C23] Implement N2653: u8 strings are char8_t[] (PR #97208)

2024-06-30 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok created https://github.com/llvm/llvm-project/pull/97208 https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm Closes #97202 >From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 30 Jun 2024 12:07:54 +0100 Subje

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-30 Thread Yi Kong via cfe-commits
kongy wrote: > This is probably caused by some downstream patches in google3? > https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp > does not contain any mentions of `M->getFunction` or `M->getContext`. You > need to add the missing include t

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Vlad Serebrennikov via cfe-commits
@@ -134,7 +134,7 @@ struct A { } // namespace cwg2858 -namespace cwg2877 { // cwg2877: 19 tentatively ready 2024-05-31 +namespace cwg2877 { // cwg2877: 19 ready 2024-05-31 Endilll wrote: We should fix the comments as it was done in https://github.com/cplusp

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll requested changes to this pull request. Thank you for taking care of this! But I'd like to emphasize that updating statuses of existing DR tests is not just a menial task, otherwise I wouldn't even bother making the script this strict about statuses in the first place

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/97200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Vlad Serebrennikov via cfe-commits
@@ -150,7 +150,7 @@ void g() { #endif } // namespace cwg2877 -namespace cwg2881 { // cwg2881: 19 tentatively ready 2024-04-19 +namespace cwg2881 { // cwg2881: 19 ready 2024-04-19 Endilll wrote: Since this was added, wording has changed slightly, and a new ill

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mital Ashok (MitalAshok) Changes Also classes the "ready" status similarly to "tentatively ready" in make_cxx_dr_status --- Full diff: https://github.com/llvm/llvm-project/pull/97200.diff 4 Files Affected: - (modified) clang/test/CXX/

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-06-30 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok created https://github.com/llvm/llvm-project/pull/97200 Also classes the "ready" status similarly to "tentatively ready" in make_cxx_dr_status >From 0dea95701ca4dfca9b7d0bd889003fc35aa3017e Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 30 Jun 2024 10:39:

[clang] [analyzer] Fix crash in Stream checker when using void pointers (PR #97199)

2024-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes We can get zero type size (thus div by zero crash) if the region is for a 'void*' pointer. In this patch, let's just override the void type with a char type to avoid the crash. Fixes htt

[clang] [analyzer] Fix crash in Stream checker when using void pointers (PR #97199)

2024-06-30 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/97199 We can get zero type size (thus div by zero crash) if the region is for a 'void*' pointer. In this patch, let's just override the void type with a char type to avoid the crash. Fixes https://github.com/llvm/ll

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-06-30 Thread Kim Gräsman via cfe-commits
kimgr wrote: cc @llvm-beanz -- you seem to have done a fair bit with the LLVM CMake system. https://github.com/llvm/llvm-project/pull/97197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

  1   2   >