inaki-amatria wrote:
Closing this until I post in discourse. TYSM for your time, Aaron
https://github.com/llvm/llvm-project/pull/94544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inaki-amatria closed
https://github.com/llvm/llvm-project/pull/94544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wangpc-pp edited
https://github.com/llvm/llvm-project/pull/94564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -381,3 +381,20 @@ def XIANGSHAN_NANHU :
RISCVProcessorModel<"xiangshan-nanhu",
TuneZExtHFusion,
TuneZExtWFusion,
TuneShiftedZExtWFusion]>;
+
+
chapuni wrote:
I've created #95887 (Release notes).
https://github.com/llvm/llvm-project/pull/95496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: NAKAMURA Takumi (chapuni)
Changes
Mostly apparent changes are described here.
---
Full diff: https://github.com/llvm/llvm-project/pull/95887.diff
2 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+14)
- (modified) llvm/docs/R
Author: Timm Bäder
Date: 2024-06-18T08:30:43+02:00
New Revision: 18000feec0e174194fec3476b8b73db1d767e0d2
URL:
https://github.com/llvm/llvm-project/commit/18000feec0e174194fec3476b8b73db1d767e0d2
DIFF:
https://github.com/llvm/llvm-project/commit/18000feec0e174194fec3476b8b73db1d767e0d2.diff
LO
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/95887
Mostly apparent changes are described here.
>From defd3f6b694a5091da92d925738631b8359c43bb Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Tue, 18 Jun 2024 11:10:14 +0900
Subject: [PATCH] Update ReleaseNote
https://github.com/wangpc-pp approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/94564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-06-18T08:30:43+02:00
New Revision: 2d38becda8afa48a031995d67ebf9a6383e01e4f
URL:
https://github.com/llvm/llvm-project/commit/2d38becda8afa48a031995d67ebf9a6383e01e4f
DIFF:
https://github.com/llvm/llvm-project/commit/2d38becda8afa48a031995d67ebf9a6383e01e4f.diff
LO
https://github.com/dtcxzyw edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,65 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wno-unused-value -std=c++20 %s
+
+namespace std {
+ typedef decltype(sizeof(int)) size_t;
+
+ template
+ struct initializer_list
+ {
+const E *p;
+size_t n;
+initializer_list(const E *p, size_t n) : p(p),
@@ -0,0 +1,65 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wno-unused-value -std=c++20 %s
hokein wrote:
nit: please format the test file.
https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cf
https://github.com/hokein commented:
The change looks good to me. Please add a note in
`llvm-project/clang/docs/ReleaseNotes.rst`.
https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
@@ -0,0 +1,65 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wno-unused-value -std=c++20 %s
+
+namespace std {
+ typedef decltype(sizeof(int)) size_t;
+
+ template
+ struct initializer_list
+ {
+const E *p;
+size_t n;
+initializer_list(const E *p, size_t n) : p(p),
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexander-shaposhnikov edited
https://github.com/llvm/llvm-project/pull/95885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtcxzyw wrote:
Any progress? It would be helpful for me to avoid reviewing tons of diff in
https://github.com/dtcxzyw/llvm-opt-benchmark/pulls :)
Can you resolve merge conflicts first?
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits
https://github.com/alexander-shaposhnikov edited
https://github.com/llvm/llvm-project/pull/95885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexander-shaposhnikov updated
https://github.com/llvm/llvm-project/pull/95885
>From 7c286a320256732eca6a9183a1ba21ae60b99746 Mon Sep 17 00:00:00 2001
From: Alexander Shaposhnikov
Date: Tue, 18 Jun 2024 06:15:12 +
Subject: [PATCH] [Clang][Sanitizers] Enable NSAN on X86_64
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Alexander Shaposhnikov (alexander-shaposhnikov)
Changes
This is a follow-up to https://github.com/llvm/llvm-project/pull/93783.
The current set of patches covers only x86_64 (in particular, on compiler-rt's
https://github.com/alexander-shaposhnikov created
https://github.com/llvm/llvm-project/pull/95885
This is a follow-up to https://github.com/llvm/llvm-project/pull/93783.
The current set of patches covers only x86_64 (in particular, on compiler-rt's
side),
therefore we should now enable this fla
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/95846
>From 89da8b3bcc678430fe4225c723e87914f2c378cd Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Mon, 17 Jun 2024 21:48:57 +0100
Subject: [PATCH 1/3] [Clang] [Sema] Ensure noexcept(typeid(E)) checks if E
throw
@@ -33,6 +33,7 @@
// q -> Scalable vector, followed by the number of elements and the base type.
// Q -> target builtin type, followed by a character to distinguish the
builtin type
//Qa -> AArch64 svcount_t builtin type.
+//Qb -> AMDGPU __amdgpu_buffer_rsrc_t builti
@@ -19082,6 +19082,15 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned
BuiltinID,
CGM.getIntrinsic(Intrinsic::amdgcn_s_sendmsg_rtn, {ResultType});
return Builder.CreateCall(F, {Arg});
}
+ case AMDGPU::BI__builtin_amdgcn_make_buffer_rsrc: {
+llvm::Va
@@ -224,9 +225,26 @@ static LValueOrRValue
emitSuspendExpression(CodeGenFunction &CGF, CGCoroData &Co
AwaitKind Kind, AggValueSlot aggSlot,
bool ignoreResult, bool forLValue) {
auto *E = S.getCommonExpr(
@@ -5213,6 +5219,11 @@ class CoawaitExpr : public CoroutineSuspendExpr {
bool isImplicit() const { return CoawaitBits.IsImplicit; }
void setIsImplicit(bool value = true) { CoawaitBits.IsImplicit = value; }
+ bool isInplaceCall() const { return CoawaitBits.IsInplaceCall; }
@@ -224,9 +225,26 @@ static LValueOrRValue
emitSuspendExpression(CodeGenFunction &CGF, CGCoroData &Co
AwaitKind Kind, AggValueSlot aggSlot,
bool ignoreResult, bool forLValue) {
auto *E = S.getCommonExpr(
yuxuanchen1997 wrote:
@ChuanqiXu9, I actually did the FE changes first and most of the FE logic are
in `Sema` now. One question: there does not seem to be an obvious way to get
the `llvm::CallBase` from `CodeGenFunction::EmitCallExpr`. I can only get the
`llvm::Value *` for the return value th
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/94693
>From 093cd09a5b479deaabd3013be1fd6849f6c174d6 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 4 Jun 2024 23:22:00 -0700
Subject: [PATCH 1/2] [Clang] Introduce [[clang::structured_concurrency]]
---
Author: Timm Bäder
Date: 2024-06-18T07:53:51+02:00
New Revision: 5996496e7f1314fb40d57657e2085b5c41916766
URL:
https://github.com/llvm/llvm-project/commit/5996496e7f1314fb40d57657e2085b5c41916766
DIFF:
https://github.com/llvm/llvm-project/commit/5996496e7f1314fb40d57657e2085b5c41916766.diff
LO
Author: Timm Bäder
Date: 2024-06-18T07:53:51+02:00
New Revision: d563c0f96ca4a4160b149ce83b99c78eed865fa8
URL:
https://github.com/llvm/llvm-project/commit/d563c0f96ca4a4160b149ce83b99c78eed865fa8
DIFF:
https://github.com/llvm/llvm-project/commit/d563c0f96ca4a4160b149ce83b99c78eed865fa8.diff
LO
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/95849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/95849
>From b10aa2317f566febdf4cd3630a972be58fea515b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 17 Jun 2024 14:03:03 -0700
Subject: [PATCH 1/3] [SPIRV][HLSL] Add lowering of `rsqrt` to SPIRV
---
clang/lib/
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/95846
>From 89da8b3bcc678430fe4225c723e87914f2c378cd Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Mon, 17 Jun 2024 21:48:57 +0100
Subject: [PATCH 1/2] [Clang] [Sema] Ensure noexcept(typeid(E)) checks if E
throw
@@ -,13 +,18 @@ static CanThrowResult canDynamicCastThrow(const
CXXDynamicCastExpr *DC) {
}
static CanThrowResult canTypeidThrow(Sema &S, const CXXTypeidExpr *DC) {
- if (DC->isTypeOperand())
+ // Operand is not evaluated, cannot possibly throw
+ if (!DC->isPotenti
@@ -,13 +,18 @@ static CanThrowResult canDynamicCastThrow(const
CXXDynamicCastExpr *DC) {
}
static CanThrowResult canTypeidThrow(Sema &S, const CXXTypeidExpr *DC) {
- if (DC->isTypeOperand())
+ // Operand is not evaluated, cannot possibly throw
tbae
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #58987.
Fixes #95679.
---
Full diff: https://github.com/llvm/llvm-project/pull/95878.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+11-6)
- (modified) clang/unittes
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/95878
Fixes #58987.
Fixes #95679.
>From 299924c9f9485e7a784ffedcb6ec4fbccf5ad6f7 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 17 Jun 2024 21:13:10 -0700
Subject: [PATCH] [clang-format] Handle function try block w
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/93860
>From 532f10f77c862f6d429366f0d6903773da8fa79b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Thu, 30 May 2024 11:40:27 -0700
Subject: [PATCH 1/5] Implement HLSL strict diagnostic mode
---
clang/include/clang
DEBADRIBASAK wrote:
[jh7370](https://github.com/jh7370) sorry for pinging again. I will be highly
grateful if you kindly review this pull request. This change will unblock some
of our internal tasks and timely completion of this is crucial for us. Thank
you in advance.
https://github.com/llv
sunshaoce wrote:
> Could you explain these numbers? It looks like data in some columns is
> missing.
I only ran the default `base metrics` once. The geometric mean of this
`Estimated Base Ratio` column can be regarded as the comprehensive score for
this item.
[Q14. What is the difference be
ergawy wrote:
> @ergawy Could you take a look at this, given that you did something similar
> [even if it was much smaller] recently?
Sorry, this totally slipped my mind. I will take a look today.
https://github.com/llvm/llvm-project/pull/92430
___
c
michaelmaitland wrote:
Could you explain these numbers? It looks like data in some columns is missing.
https://github.com/llvm/llvm-project/pull/94564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/farzonl approved this pull request.
LGTM, code looka right, just a few more tests needed.
https://github.com/llvm/llvm-project/pull/95849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -62,4 +62,5 @@ let TargetPrefix = "spv" in {
def int_spv_any : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty]>;
def int_spv_lerp : Intrinsic<[LLVMMatchType<0>], [llvm_anyfloat_ty,
LLVMMatchType<0>,LLVMMatchType<0>],
[IntrNoMem, IntrWillReturn] >;
+ def int_spv_
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/95873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -230,7 +230,11 @@ template <> struct DenseMapInfo {
}
static unsigned getHashValue(const GlobalDeclID &Key) {
-return DenseMapInfo::getHashValue(Key.get());
+// Our default hash algorithm for 64 bits integer may not be very good.
+// In GlobalDeclID's case,
@@ -230,7 +230,11 @@ template <> struct DenseMapInfo {
}
static unsigned getHashValue(const GlobalDeclID &Key) {
-return DenseMapInfo::getHashValue(Key.get());
+// Our default hash algorithm for 64 bits integer may not be very good.
ChuanqiXu9 wrot
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/95730
>From 50923aa33f09b2530cfe492a53f70296f9ce9107 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Mon, 17 Jun 2024 11:32:35 +0800
Subject: [PATCH 1/2] [Serialization] Use specialized decl hash function for
Globa
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Adpated from polly-check-format.
---
Full diff: https://github.com/llvm/llvm-project/pull/95873.diff
1 Files Affected:
- (modified) clang/lib/Format/CMakeLists.txt (+24)
``diff
diff --git a/cl
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/95873
Adpated from polly-check-format.
>From ab2a61d1939f4be4551949e979fd43b9e11c5c49 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 17 Jun 2024 18:49:22 -0700
Subject: [PATCH] [clang-format][NFC] Add CMake target
sunshaoce wrote:
I've tested this patch with `spec 2006 int`. Everything seems to be running
smoothly:
```
Estimated Estimated
Base Base BasePeak Peak Peak
Benchmarks Ref. Run Time Rati
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/95276
>From 013a40d474e3acaa7a090d5e279f2d8a2f18fbd8 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Mon, 17 Jun 2024 18:48:33 -0400
Subject: [PATCH 1/2] [Clang][AMDGPU] Add a new builtin type for buffer rsrc
---
c
ChuanqiXu9 wrote:
> @ChuanqiXu9 are you still planning to chase this given that fixing the
> hashing function would fix performance for the aforementioned patch?
>
> The trade-off we are making here is hard to assess without benchmarks that
> show how much latency we win and how much more memo
@@ -0,0 +1,95 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -cl-std=CL2.0 -target-cpu
verde -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/95276
>From 013a40d474e3acaa7a090d5e279f2d8a2f18fbd8 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Mon, 17 Jun 2024 18:48:33 -0400
Subject: [PATCH 1/2] [Clang][AMDGPU] Add a new builtin type for buffer rsrc
---
c
ChuanqiXu9 wrote:
> Oh, I didn't realize you were eager to land this in Clang 19, thanks for
> sharing that. In that case, I think a specialiazed hash function for
> `GlobalDeclID` is indeed the way to go.
>
> I was also worried a little there are other performance implications of this
> chan
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/95727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-06-17T18:45:01-07:00
New Revision: 3c6a1090b25ef2dda5a378182cd17aad00439d35
URL:
https://github.com/llvm/llvm-project/commit/3c6a1090b25ef2dda5a378182cd17aad00439d35
DIFF:
https://github.com/llvm/llvm-project/commit/3c6a1090b25ef2dda5a378182cd17aad00439d35.diff
LOG:
ChuanqiXu9 wrote:
Thanks. Will do when landing.
https://github.com/llvm/llvm-project/pull/92085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/damyanp edited
https://github.com/llvm/llvm-project/pull/93860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -536,9 +536,34 @@ DiagnoseHLSLAvailability::FindAvailabilityAttr(const Decl
*D) {
void DiagnoseHLSLAvailability::CheckDeclAvailability(NamedDecl *D,
const AvailabilityAttr
*AA,
@@ -157,6 +157,18 @@ static bool ShouldDiagnoseAvailabilityInContext(
}
}
+ // In HLSL, emit diagnostic during parsing only if the diagnostic
+ // mode is set to strict (-fhlsl-strict-availability), and either the decl
+ // availability is not restricted to a specific
@@ -536,9 +536,34 @@ DiagnoseHLSLAvailability::FindAvailabilityAttr(const Decl
*D) {
void DiagnoseHLSLAvailability::CheckDeclAvailability(NamedDecl *D,
const AvailabilityAttr
*AA,
@@ -157,10 +157,12 @@ static bool ShouldDiagnoseAvailabilityInContext(
}
}
- // In HLSL, emit diagnostic during parsing only if the diagnostic
- // mode is set to strict (-fhlsl-strict-availability), and either the decl
- // availability is not restricted to a specifi
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/94791
>From 783f2820037dbe25673a67bbbf15297738466184 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 31 May 2024 10:55:53 -0700
Subject: [PATCH] [libc++] Fix deployment target Lit features
We were not making an
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/93860
>From 532f10f77c862f6d429366f0d6903773da8fa79b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Thu, 30 May 2024 11:40:27 -0700
Subject: [PATCH 1/4] Implement HLSL strict diagnostic mode
---
clang/include/clang
@@ -536,9 +536,34 @@ DiagnoseHLSLAvailability::FindAvailabilityAttr(const Decl
*D) {
void DiagnoseHLSLAvailability::CheckDeclAvailability(NamedDecl *D,
const AvailabilityAttr
*AA,
@@ -157,6 +157,18 @@ static bool ShouldDiagnoseAvailabilityInContext(
}
}
+ // In HLSL, emit diagnostic during parsing only if the diagnostic
+ // mode is set to strict (-fhlsl-strict-availability), and either the decl
+ // availability is not restricted to a specific
@@ -536,9 +536,34 @@ DiagnoseHLSLAvailability::FindAvailabilityAttr(const Decl
*D) {
void DiagnoseHLSLAvailability::CheckDeclAvailability(NamedDecl *D,
const AvailabilityAttr
*AA,
@@ -210,13 +222,16 @@ static bool ShouldDiagnoseAvailabilityInContext(
return true;
}
-static bool
-shouldDiagnoseAvailabilityByDefault(const ASTContext &Context,
-const VersionTuple &DeploymentVersion,
-
@@ -157,6 +157,18 @@ static bool ShouldDiagnoseAvailabilityInContext(
}
}
+ // In HLSL, emit diagnostic during parsing only if the diagnostic
+ // mode is set to strict (-fhlsl-strict-availability), and either the decl
+ // availability is not restricted to a specific
MaxEW707 wrote:
Friendly ping @rnk @efriedma-quic @zmodem
https://github.com/llvm/llvm-project/pull/92477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu approved this pull request.
LGTM. Thanks
https://github.com/llvm/llvm-project/pull/95061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/95849
>From b10aa2317f566febdf4cd3630a972be58fea515b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 17 Jun 2024 14:03:03 -0700
Subject: [PATCH 1/2] [SPIRV][HLSL] Add lowering of `rsqrt` to SPIRV
---
clang/lib/
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/94693
>From 093cd09a5b479deaabd3013be1fd6849f6c174d6 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 4 Jun 2024 23:22:00 -0700
Subject: [PATCH 1/2] [Clang] Introduce [[clang::structured_concurrency]]
---
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/94693
>From 093cd09a5b479deaabd3013be1fd6849f6c174d6 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 4 Jun 2024 23:22:00 -0700
Subject: [PATCH 1/2] [Clang] Introduce [[clang::structured_concurrency]]
---
@@ -3657,8 +3657,8 @@ class Foo {
int a GUARDED_BY(mu_);
bool c;
- inttryLockMutexI() EXCLUSIVE_TRYLOCK_FUNCTION(1, mu_);
- Mutex* tryLockMutexP() EXCLUSIVE_TRYLOCK_FUNCTION(1, mu_);
+ bool tryLockMutexI() EXCLUSIVE_TRYLOCK_FUNCTION(1, mu_);
dmcar
dmcardle wrote:
Just force-pushed what I described in the last comment.
1. Changed void-returning trylock functions to return bool in tests. (Probably
needs another pass to minimize the diff and undo some unnecessary changes.)
2. Now enforcing bool/int/pointer returns from trylock-annotated fun
https://github.com/dmcardle updated
https://github.com/llvm/llvm-project/pull/95290
>From e53ddc9e9ce0ddd8b5dfd5dfd4c8654afe643ce2 Mon Sep 17 00:00:00 2001
From: Dan McArdle
Date: Mon, 17 Jun 2024 17:53:30 -0400
Subject: [PATCH] [clang][ThreadSafety] Enforce trylock function return type
With t
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pavel Desyatnikov (desyatok)
Changes
This is a gitlab mirror (LLVM repo is too large to directly create one)
---
Patch is 21.96 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/95867.diff
10 Fi
https://github.com/desyatok closed
https://github.com/llvm/llvm-project/pull/95867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/desyatok created
https://github.com/llvm/llvm-project/pull/95867
This is a gitlab mirror (LLVM repo is too large to directly create one)
>From 6ac71484e0974f6f928fcab43e02ced5f184ce3c Mon Sep 17 00:00:00 2001
From: Pavel Desyatnikov
Date: Tue, 18 Jun 2024 02:41:55 +0300
Subj
efriedma-quic wrote:
That would mean if someone wrote `struct Empty {}; struct Z { Empty a,b,c; }`,
we'd lower it to `{ [3 x i8] }` instead of `{%Empty, %Empty, %Empty}`, which is
a bit ugly. Other than that, sure, I guess we could do that.
https://github.com/llvm/llvm-project/pull/93809
@@ -157,6 +157,18 @@ static bool ShouldDiagnoseAvailabilityInContext(
}
}
+ // In HLSL, emit diagnostic during parsing only if the diagnostic
+ // mode is set to strict (-fhlsl-strict-availability), and either the decl
+ // availability is not restricted to a specific
https://github.com/damyanp edited
https://github.com/llvm/llvm-project/pull/93860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -210,13 +222,16 @@ static bool ShouldDiagnoseAvailabilityInContext(
return true;
}
-static bool
-shouldDiagnoseAvailabilityByDefault(const ASTContext &Context,
-const VersionTuple &DeploymentVersion,
-
@@ -157,6 +157,18 @@ static bool ShouldDiagnoseAvailabilityInContext(
}
}
+ // In HLSL, emit diagnostic during parsing only if the diagnostic
+ // mode is set to strict (-fhlsl-strict-availability), and either the decl
+ // availability is not restricted to a specific
@@ -536,9 +536,34 @@ DiagnoseHLSLAvailability::FindAvailabilityAttr(const Decl
*D) {
void DiagnoseHLSLAvailability::CheckDeclAvailability(NamedDecl *D,
const AvailabilityAttr
*AA,
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/93860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Please don't commit binary files if it isn't absolutely necessary. You can
generate whatever files you need in a RUN line.
https://github.com/llvm/llvm-project/pull/95802
___
cfe-commits mailing
@@ -0,0 +1,98 @@
+// RUN: %clang_cc1 %s -fsyntax-only --embed-dir=%S/Inputs -verify=expected,cxx
-Wno-c23-extensions
+// RUN: %clang_cc1 -x c -std=c23 %s -fsyntax-only --embed-dir=%S/Inputs
-verify=expected,c
+#embed
+;
+
+void f (unsigned char x) { (void)x;}
+void g () {}
+voi
@@ -2422,6 +2422,10 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred,
Bldr.addNodes(Dst);
break;
}
+
+case Stmt::EmbedExprClass:
+ llvm_unreachable("Support for EmbedExpr is not implemented.");
efriedma-quic wrote:
Please do
dwblaikie wrote:
> Oh, in this particular case, the issue isn't the computed datasize, it's that
> FieldDecl::isZeroSize() returns the wrong result. If that's the case, maybe
> we can just change FieldDecl::isZeroSize() to say the field is zero size? So
> essentially, we pretend all empty fiel
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/94830
>From 013a40d474e3acaa7a090d5e279f2d8a2f18fbd8 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Mon, 17 Jun 2024 18:48:33 -0400
Subject: [PATCH] [Clang][AMDGPU] Add a new builtin type for buffer rsrc
---
clang
zygoloid wrote:
Perhaps we can start by supplying `CheckForModifiableLvalue` with extra
information about *why* we're doing the check. The current diagnostic we get
for incrementing a non-modifiable lvalue:
```console
:2:3: error: cannot assign to variable 'n' with const-qualified type
'const
jthackray wrote:
This is a good idea. Happy to approve, once all the FIXMEs are removed, since
others have already made many salient suggestions, which I agree with.
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-comm
efriedma-quic wrote:
Oh, in this particular case, the issue isn't the computed datasize, it's that
FieldDecl::isZeroSize() returns the wrong result. If that's the case, maybe we
can just change FieldDecl::isZeroSize() to say the field is zero size? So
essentially, we pretend all empty field
1 - 100 of 403 matches
Mail list logo
