[clang] [clang] Add another test case for CWG78 (PR #93708)

2024-05-29 Thread via cfe-commits
cor3ntin wrote: My reading is that `const int k;` ought to be conforming indeed but the fact no compiler supports that gives me pause. @zygoloid are we missing something? https://github.com/llvm/llvm-project/pull/93708 ___ cfe-commits mailing list cf

[clang] [X86]Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread Malay Sanghi via cfe-commits
@@ -329,6 +329,26 @@ static __inline__ void __DEFAULT_FN_ATTRS __stosq(unsigned __int64 *__dst, static __inline__ void __DEFAULT_FN_ATTRS __halt(void) { __asm__ volatile("hlt"); } + +static __inline__ int __DEFAULT_FN_ATTRS _outp(unsigned short port, int data) { + __asm__ v

[clang] [clang] CWG150: add tests and change to unreleased (PR #93758)

2024-05-29 Thread Vlad Serebrennikov via cfe-commits
@@ -753,6 +753,46 @@ namespace cwg148 { // cwg148: yes // cwg149: na +namespace cwg150 { // cwg150: yes Endilll wrote: ```suggestion namespace cwg150 { // cwg150: 19 ``` https://github.com/llvm/llvm-project/pull/93758 ___

[clang] [clang] CWG150: add tests and change to unreleased (PR #93758)

2024-05-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll requested changes to this pull request. You should apply the suggested change, and run `make_cxx_dr_status` script. I don't expect it to introduce new changes, though, but we should be on a safe side here, and not rely on manual editing of `cxx_dr_status.html`. https

[clang] [clang] CWG150: add tests and change to unreleased (PR #93758)

2024-05-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/93758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf closed https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 73f4c25 - [X86] Support EGPR for inline assembly. (#92338)

2024-05-29 Thread via cfe-commits
Author: Freddy Ye Date: 2024-05-30T14:47:47+08:00 New Revision: 73f4c2547dc3d1b6a453d3c4388648b122554dd1 URL: https://github.com/llvm/llvm-project/commit/73f4c2547dc3d1b6a453d3c4388648b122554dd1 DIFF: https://github.com/llvm/llvm-project/commit/73f4c2547dc3d1b6a453d3c4388648b122554dd1.diff LOG

[clang] [X86]Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread Phoebe Wang via cfe-commits
@@ -329,6 +329,26 @@ static __inline__ void __DEFAULT_FN_ATTRS __stosq(unsigned __int64 *__dst, static __inline__ void __DEFAULT_FN_ATTRS __halt(void) { __asm__ volatile("hlt"); } + +static __inline__ int __DEFAULT_FN_ATTRS _outp(unsigned short port, int data) { + __asm__ v

[clang] [X86]Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread Phoebe Wang via cfe-commits
@@ -329,6 +329,26 @@ static __inline__ void __DEFAULT_FN_ATTRS __stosq(unsigned __int64 *__dst, static __inline__ void __DEFAULT_FN_ATTRS __halt(void) { __asm__ volatile("hlt"); } + +static __inline__ int __DEFAULT_FN_ATTRS _outp(unsigned short port, int data) { + __asm__ v

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-05-29 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1ac592c - [clang] fix merging of UsingShadowDecl (#80245)

2024-05-29 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-05-30T03:43:27-03:00 New Revision: 1ac592c4e7b4ba7c680af9286ad79ed27ad628f1 URL: https://github.com/llvm/llvm-project/commit/1ac592c4e7b4ba7c680af9286ad79ed27ad628f1 DIFF: https://github.com/llvm/llvm-project/commit/1ac592c4e7b4ba7c680af9286ad79ed27ad628f1.dif

[clang] [X86]Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread Malay Sanghi via cfe-commits
https://github.com/MalaySanghi edited https://github.com/llvm/llvm-project/pull/93774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread Malay Sanghi via cfe-commits
MalaySanghi wrote: @FreddyLeaf @phoebewang please review https://github.com/llvm/llvm-project/pull/93774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Malay Sanghi (MalaySanghi) Changes Supported: outp, outpw, _outp, _outpw, _outpd These functions were removed from the Windows runtime library, but for kernel mode development it's still supported --- Full diff: https://github.com/l

[clang] Add support for _outp{|w|d} (PR #93774)

2024-05-29 Thread Malay Sanghi via cfe-commits
https://github.com/MalaySanghi created https://github.com/llvm/llvm-project/pull/93774 Supported: outp, outpw, _outp, _outpw, _outpd These functions were removed from the Windows runtime library, but for kernel mode development it's still supported >From 38359132ea0b3b56900ba48827c86a93c017223

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Owen Pan via cfe-commits
owenca wrote: See https://github.com/llvm/llvm-project/issues/93635#issuecomment-2138778128. Also, we need to deprecate [`SpaceInEmptyBlock`](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#spaceinemptyblock). https://github.com/llvm/llvm-project/pull/93634 ___

[clang] d10b765 - [ConstantFold] Remove notional over-indexing fold (#93697)

2024-05-29 Thread via cfe-commits
Author: Nikita Popov Date: 2024-05-30T08:36:44+02:00 New Revision: d10b76552f919ddb84347ab03908a55804ea6b8a URL: https://github.com/llvm/llvm-project/commit/d10b76552f919ddb84347ab03908a55804ea6b8a DIFF: https://github.com/llvm/llvm-project/commit/d10b76552f919ddb84347ab03908a55804ea6b8a.diff

[clang] [compiler-rt] [llvm] [mlir] [ConstantFold] Remove notional over-indexing fold (PR #93697)

2024-05-29 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/93697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add another test case for CWG78 (PR #93708)

2024-05-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/93708 >From 210d58b7133aeb007d423464bcd40d016fc25863 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 29 May 2024 15:57:30 +0300 Subject: [PATCH] [clang] Add another test case for CWG78 --- clang/test/CXX

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-05-29 Thread Alexander van der Grinten via cfe-commits
avdgrinten wrote: Regarding the acceptance bar, I'd like to stress the following point: it is true that Managarm is not a mainstream OS (but neither are some of the other OSes that have existing LLVM and Clang targets); however, LLVM is an infrastructure project that is used by a lot of downst

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-05-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-05-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LG. It looks not wise to block this good PR. After all, it is a change 6 lines. Let's go ahead. https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-05-29 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I have revived this PR after a long time. The original ODR violation bad diagnostic from the GH issue is gone from main, so I have removed the test for it. My best guess is that the ODR checking must have gotten weakened somehow. I really don't have time to dig into it though.

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-05-29 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/80245 >From 9763cc9e6f081bc28b74164c77a2b80ac42aec1c Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Feb 2024 02:26:10 -0300 Subject: [PATCH] [clang] fix merging of UsingShadowDecl Previously, when decidi

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 498da62 - [NFC] [clang] add tests for merging of UsingShadowDecl

2024-05-29 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2024-05-30T02:56:57-03:00 New Revision: 498da62088b22ef1d4e90d6021a80ae7bab6abae URL: https://github.com/llvm/llvm-project/commit/498da62088b22ef1d4e90d6021a80ae7bab6abae DIFF: https://github.com/llvm/llvm-project/commit/498da62088b22ef1d4e90d6021a80ae7bab6abae.dif

[clang] Revert "[DebugInfo] Add flag to only emit referenced member functions" (PR #93767)

2024-05-29 Thread David Blaikie via cfe-commits
dwblaikie wrote: Thanks! Sorry I didn't get to it sooner https://github.com/llvm/llvm-project/pull/93767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/92338 >From 41fbc18c7a4a26b11bc4b772bbe2e384ad9d9dbc Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 10 May 2024 16:29:55 +0800 Subject: [PATCH 01/13] [X86] Support EGPR for inline assembly. "jR": explictly ena

[clang] Pass LangOpts from CompilerInstance to DependencyScanningWorker (PR #93753)

2024-05-29 Thread via cfe-commits
cor3ntin wrote: Thanks for working on that. Your change is pretty much what i expected yes, it's great! https://github.com/llvm/llvm-project/pull/93753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang-format] Insert a space between a keyword and a literal (PR #93632)

2024-05-29 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/93632 >From be3cb7662b789c7ffa61aab55c9390543cbab2ca Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 28 May 2024 19:36:36 -0700 Subject: [PATCH 1/2] [clang-format] Insert a space between a keyword and a literal Fix

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -1,21 +1,27 @@ ; Check r16-r31 can not be used with 'q','r','l' constraint for backward compatibility. -; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s +; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -57999,13 +58020,25 @@ X86TargetLowering::getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI, case 'q': // GENERAL_REGS in 64-bit mode, Q_REGS in 32-bit mode. if (Subtarget.is64Bit()) { if (VT == MVT::i8 || VT == MVT::i1) - return std::m

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: [e752556](https://github.com/llvm/llvm-project/pull/92338/commits/e752556c06ac25d905c6e642bdcb5e9244db5da3) https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@li

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: [e752556](https://github.com/llvm/llvm-project/pull/92338/commits/e752556c06ac25d905c6e642bdcb5e9244db5da3) https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@li

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -0,0 +1,25 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: not llc -mtriple=x86_64 < %s | FileCheck %s +; RUN: not llc -mtriple=x86_64 -mattr=+egpr < %s | FileCheck %s FreddyLeaf wrote: [e752556](https://github.com/llv

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/92338 >From 41fbc18c7a4a26b11bc4b772bbe2e384ad9d9dbc Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 10 May 2024 16:29:55 +0800 Subject: [PATCH 01/13] [X86] Support EGPR for inline assembly. "jR": explictly ena

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -1,21 +1,27 @@ ; Check r16-r31 can not be used with 'q','r','l' constraint for backward compatibility. -; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s +; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s

[clang] [OpenACC] Loop construct basic Sema and AST work (PR #93742)

2024-05-29 Thread Erich Keane via cfe-commits
@@ -0,0 +1,164 @@ + +// RUN: %clang_cc1 %s -fopenacc -ast-dump | FileCheck %s + +// Test this with PCH. +// RUN: %clang_cc1 %s -fopenacc -emit-pch -o %t %s +// RUN: %clang_cc1 %s -fopenacc -include-pch %t -ast-dump-all | FileCheck %s + +#ifndef PCH_HELPER +#define PCH_HELPER + +vo

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -0,0 +1,25 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: not llc -mtriple=x86_64 < %s | FileCheck %s +; RUN: not llc -mtriple=x86_64 -mattr=+egpr < %s | FileCheck %s FreddyLeaf wrote: I'll try. If so, we can refine l

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -1,21 +1,27 @@ ; Check r16-r31 can not be used with 'q','r','l' constraint for backward compatibility. -; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s +; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s

[clang] [compiler-rt] [asan][windows] Eliminate the static asan runtime on windows (PR #93770)

2024-05-29 Thread Charlie Barto via cfe-commits
https://github.com/barcharcraz edited https://github.com/llvm/llvm-project/pull/93770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-05-29 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I think the fix for the breakage is to just pin the new test to a fixed triple like so `-triple x86_64-linux-gnu`. https://github.com/llvm/llvm-project/pull/81545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [compiler-rt] [asan][windows] Eliminate the static asan runtime on windows (PR #93770)

2024-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-platform-windows Author: Charlie Barto (barcharcraz) Changes Originally #81677 That PR was reverted due to breaking the MSVC build. The breakage in question was just msvc not understanding the "optnone" attribute, which has been corrected. --- Patch

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-05-29 Thread Mehdi Amini via cfe-commits
joker-eph wrote: Reverted in 7d4a45d98275e669bda40410f064891beb3480ce ; test is failing like this on Windows: ``` # RUN: at line 3 c:\ws\buildbot\premerge-monolithic-windows\build\bin\clang.exe -cc1 -internal-isystem C:\ws\buildbot\premerge-monolithic-windows\build\lib\clang\19\include -nost

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-05-29 Thread Eli Friedman via cfe-commits
@@ -5348,18 +5348,8 @@ Value *ScalarExprEmitter::VisitVAArgExpr(VAArgExpr *VE) { return llvm::UndefValue::get(ArgTy); } - // FIXME Volatility. - llvm::Value *Val = Builder.CreateLoad(ArgPtr); - - // If EmitVAArg promoted the type, we must truncate it. - if (ArgTy !=

[clang] 7d4a45d - Revert "Add option to generate additional debug info for expression dereferencing pointer to pointers. (#81545)"

2024-05-29 Thread Mehdi Amini via cfe-commits
Author: Mehdi Amini Date: 2024-05-29T21:56:59-07:00 New Revision: 7d4a45d98275e669bda40410f064891beb3480ce URL: https://github.com/llvm/llvm-project/commit/7d4a45d98275e669bda40410f064891beb3480ce DIFF: https://github.com/llvm/llvm-project/commit/7d4a45d98275e669bda40410f064891beb3480ce.diff L

[clang] [HLSL] Default and Relaxed Availability Diagnostics (PR #92704)

2024-05-29 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/92704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8890209 - [HLSL] Default and Relaxed Availability Diagnostics (#92704)

2024-05-29 Thread via cfe-commits
Author: Helena Kotas Date: 2024-05-29T21:52:20-07:00 New Revision: 8890209ead2246461985f49c4c9c01cc2371ac09 URL: https://github.com/llvm/llvm-project/commit/8890209ead2246461985f49c4c9c01cc2371ac09 DIFF: https://github.com/llvm/llvm-project/commit/8890209ead2246461985f49c4c9c01cc2371ac09.diff

[clang] Revert "[DebugInfo] Add flag to only emit referenced member functions" (PR #93767)

2024-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang-codegen Author: Mehdi Amini (joker-eph) Changes Reverts llvm/llvm-project#87018 MacOS and Windows bots are broken. --- Full diff: https://github.com/llvm/llvm-project/pull/93767.diff 6 Files Affected: - (modified

[clang] Revert "[DebugInfo] Add flag to only emit referenced member functions" (PR #93767)

2024-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mehdi Amini (joker-eph) Changes Reverts llvm/llvm-project#87018 MacOS and Windows bots are broken. --- Full diff: https://github.com/llvm/llvm-project/pull/93767.diff 6 Files Affected: - (modified) clang/include/clang/Basic/DebugOption

[clang] [DebugInfo] Add flag to only emit referenced member functions (PR #87018)

2024-05-29 Thread Mehdi Amini via cfe-commits
joker-eph wrote: Reverted in https://github.com/llvm/llvm-project/pull/93767 (maybe it's just a missing explicit triple in the test?) https://github.com/llvm/llvm-project/pull/87018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] Revert "[DebugInfo] Add flag to only emit referenced member functions" (PR #93767)

2024-05-29 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/93767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 02c6845 - Revert "[DebugInfo] Add flag to only emit referenced member functions" (#93767)

2024-05-29 Thread via cfe-commits
Author: Mehdi Amini Date: 2024-05-29T22:48:15-06:00 New Revision: 02c6845c762dfd0a19d4a2f997990e160f392dae URL: https://github.com/llvm/llvm-project/commit/02c6845c762dfd0a19d4a2f997990e160f392dae DIFF: https://github.com/llvm/llvm-project/commit/02c6845c762dfd0a19d4a2f997990e160f392dae.diff L

[clang] Revert "[DebugInfo] Add flag to only emit referenced member functions" (PR #93767)

2024-05-29 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/93767 Reverts llvm/llvm-project#87018 MacOS and Windows bots are broken. >From a35c320e18ba2abad17eab0ed162c4115601a828 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 29 May 2024 22:47:35 -0600 Subject: [PAT

[clang] [DebugInfo] Add flag to only emit referenced member functions (PR #87018)

2024-05-29 Thread Mehdi Amini via cfe-commits
joker-eph wrote: It also fails on Windows: https://lab.llvm.org/buildbot/#/builders/271/builds/8095 https://github.com/llvm/llvm-project/pull/87018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] [PowerPC] Diagnose musttail instead of crash inside backend (PR #93267)

2024-05-29 Thread Eli Friedman via cfe-commits
@@ -743,6 +743,20 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) { CallerType.Func = CallerDecl->getType()->getAs(); } + if (Context.getTargetInfo().getTriple().isPPC()) { +if (Context.getTargetInfo().getTriple().isOSAIX()) + return Diag(St->

[clang] 3db1f31 - [clang-format] Fix a regression in annotating class decl braces (#93657)

2024-05-29 Thread via cfe-commits
Author: Owen Pan Date: 2024-05-29T21:05:32-07:00 New Revision: 3db1f3110e714ad24f7d72114b3a2c14f6c63651 URL: https://github.com/llvm/llvm-project/commit/3db1f3110e714ad24f7d72114b3a2c14f6c63651 DIFF: https://github.com/llvm/llvm-project/commit/3db1f3110e714ad24f7d72114b3a2c14f6c63651.diff LOG:

[clang] [clang-format] Fix a regression in annotating class decl braces (PR #93657)

2024-05-29 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/93657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert edited https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-05-29 Thread Chuanqi Xu via cfe-commits
@@ -1802,6 +1802,12 @@ void ItaniumCXXABI::emitVTableDefinitions(CodeGenVTables &CGVT, if (VTable->hasInitializer()) return; + // If the class is attached to a C++ named module other than the one + // we're currently compiling, the vtable should be defined there. + i

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-05-29 Thread Chuanqi Xu via cfe-commits
@@ -1180,6 +1185,21 @@ bool CodeGenVTables::isVTableExternal(const CXXRecordDecl *RD) { TSK == TSK_ExplicitInstantiationDefinition) return false; + // Itanium C++ ABI [5.2.3]: + // Virtual tables for dynamic classes are emitted as follows: + // + // - If the cla

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert edited https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
@@ -0,0 +1,25 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: not llc -mtriple=x86_64 < %s | FileCheck %s +; RUN: not llc -mtriple=x86_64 -mattr=+egpr < %s | FileCheck %s KanRobert wrote: You can use sth like ``` not llc

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-05-29 Thread via cfe-commits
dyung wrote: Hi, the test debug-info-ptr-to-ptr.cpp is still failing on a Mac bot. Can you take a look? https://lab.llvm.org/buildbot/#/builders/280/builds/4515 https://github.com/llvm/llvm-project/pull/81545 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
@@ -1,21 +1,27 @@ ; Check r16-r31 can not be used with 'q','r','l' constraint for backward compatibility. -; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s +; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s

[clang] [DebugInfo] Add flag to only emit referenced member functions (PR #87018)

2024-05-29 Thread via cfe-commits
dyung wrote: Hi @dwblaikie the test debug-options.c is failing on the macOS build bot. Can you take a look? https://lab.llvm.org/buildbot/#/builders/280/builds/4510 https://github.com/llvm/llvm-project/pull/87018 ___ cfe-commits mailing list cfe-comm

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -1,21 +1,27 @@ ; Check r16-r31 can not be used with 'q','r','l' constraint for backward compatibility. -; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s +; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634 >From 0b41025a9ba677caf694f65620ce4a7b9aae2265 Mon Sep 17 00:00:00 2001 From: Kohei Asano Date: Wed, 29 May 2024 11:40:39 +0900 Subject: [PATCH] [clang-format] add an option to insert a space only for empty braces

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
KanRobert wrote: Nits: Rename this file to llvm/test/CodeGen/X86/apx/asm-constraint-jr.ll to align with existing one https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
KanRobert wrote: Nits: Rename this file to llvm/test/CodeGen/X86/apx/asm-constraint-jR.ll to align with existing one https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
@@ -57999,13 +58020,25 @@ X86TargetLowering::getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI, case 'q': // GENERAL_REGS in 64-bit mode, Q_REGS in 32-bit mode. if (Subtarget.is64Bit()) { if (VT == MVT::i8 || VT == MVT::i1) - return std::m

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Shengchen Kan via cfe-commits
@@ -1,21 +1,27 @@ ; Check r16-r31 can not be used with 'q','r','l' constraint for backward compatibility. -; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s +; RUN: not llc < %s -mtriple=x86_64-unknown-unknown -mattr=+egpr 2>&1 | FileCheck %s

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-29 Thread via cfe-commits
goldsteinn wrote: rebased https://github.com/llvm/llvm-project/pull/91101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/92338 >From 41fbc18c7a4a26b11bc4b772bbe2e384ad9d9dbc Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 10 May 2024 16:29:55 +0800 Subject: [PATCH 01/12] [X86] Support EGPR for inline assembly. "jR": explictly ena

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -0,0 +1,16 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: not llc -mtriple=x86_64 %s 2>&1 | FileCheck %s --check-prefix=ERR +; RUN: llc -mtriple=x86_64 -mattr=+egpr < %s | FileCheck %s +; RUN: llc -mtriple=x86_64 -mattr=+egpr,+inline-a

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: 81f58b6, pls review if I understand correctly. https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: 81f58b6 https://github.com/llvm/llvm-project/pull/92338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -5394,10 +5394,12 @@ X86: - ``Z``: An immediate 32-bit unsigned integer. - ``q``: An 8, 16, 32, or 64-bit register which can be accessed as an 8-bit ``l`` integer register. On X86-32, this is the ``a``, ``b``, ``c``, and ``d`` - registers, and on X86-64, it is all of the

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -5394,10 +5394,12 @@ X86: - ``Z``: An immediate 32-bit unsigned integer. - ``q``: An 8, 16, 32, or 64-bit register which can be accessed as an 8-bit ``l`` integer register. On X86-32, this is the ``a``, ``b``, ``c``, and ``d`` - registers, and on X86-64, it is all of the

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-05-29 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,74 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.core.PointerSub -verify %s + +void f1(void) { + int x, y, z[10]; + int d = &y - &x; // expected-warning{{Subtraction of two pointers that do not point into the same array is undefined behavior}} + d = z - &y;

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-05-29 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: It's nice to see that you're working on this checker; but unfortunately the language standard is very complicated in this area, so you'll need more complex code to cover it properly. https://github.com/llvm/llvm-project/pull/93676 ___

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-05-29 Thread Donát Nagy via cfe-commits
@@ -44,24 +44,30 @@ void PointerSubChecker::checkPreStmt(const BinaryOperator *B, const MemRegion *LR = LV.getAsRegion(); const MemRegion *RR = RV.getAsRegion(); - - if (!(LR && RR)) -return; - - const MemRegion *BaseLR = LR->getBaseRegion(); - const MemRegion *Bas

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-05-29 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/93676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/92338 >From 41fbc18c7a4a26b11bc4b772bbe2e384ad9d9dbc Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 10 May 2024 16:29:55 +0800 Subject: [PATCH 01/11] [X86] Support EGPR for inline assembly. "jR": explictly ena

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-29 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/91101 >From 362157ff823b9c79a5c069fcc574d01e3af23de0 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Sat, 4 May 2024 18:12:34 -0500 Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter attrib

[clang] [llvm] [PowerPC] Diagnose musttail instead of crash inside backend (PR #93267)

2024-05-29 Thread Chen Zheng via cfe-commits
@@ -743,6 +743,20 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) { CallerType.Func = CallerDecl->getType()->getAs(); } + if (Context.getTargetInfo().getTriple().isPPC()) { +if (Context.getTargetInfo().getTriple().isOSAIX()) + return Diag(St->

[clang] [llvm] [PowerPC] Diagnose musttail instead of crash inside backend (PR #93267)

2024-05-29 Thread Chen Zheng via cfe-commits
@@ -743,6 +743,20 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) { CallerType.Func = CallerDecl->getType()->getAs(); } + if (Context.getTargetInfo().getTriple().isPPC()) { +if (Context.getTargetInfo().getTriple().isOSAIX()) + return Diag(St->

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
@@ -4682,18 +4693,20 @@ struct FormatStyle { SpacesInParensCustom() khei4 wrote: Thanks for a good catch! I think more correspondence with [`.clang-format` ](https://github.com/WebKit/WebKit/blob/main/.clang-format) and `basedOnStyle: WebKit`, and WebKit

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
@@ -14027,6 +14027,11 @@ TEST_F(FormatTest, LayoutCxx11BraceInitializers) { SpaceBetweenBraces.SpacesInParens = FormatStyle::SIPO_Custom; SpaceBetweenBraces.SpacesInParensOptions.InEmptyParentheses = true; verifyFormat("vector< int > x{ };", SpaceBetweenBraces); + SpaceB

[clang] [analyzer] New optin.taint.TaintAlloc checker for catching unbounded memory allocation calls (PR #92420)

2024-05-29 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, thanks for the update! https://github.com/llvm/llvm-project/pull/92420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 203232ffbd80e9f4631213a3876f14dde155a92d d75153bb6777aacf4f08c2c08eca27646bb08727 --

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -57581,6 +57581,14 @@ X86TargetLowering::getConstraintType(StringRef Constraint) const { case '2': return C_RegisterClass; } +case 'j': + switch (Constraint[1]) { + default: +break; + case 'r': + case 'R': +return

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -57660,6 +57668,19 @@ X86TargetLowering::getSingleConstraintMatchWeight( break; } break; + case 'j': +if (StringRef(Constraint).size() != 2) + break; +switch (Constraint[1]) { +default: + return CW_Invalid; +case 'r': +case 'R': +

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-05-29 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634 >From f9022ddba4dd26dea5d04dbcd3c256d2d42b3bad Mon Sep 17 00:00:00 2001 From: Kohei Asano Date: Wed, 29 May 2024 11:40:39 +0900 Subject: [PATCH 1/2] [clang-format] add an option to insert a space only for empty bra

[clang] [llvm] [X86] Support EGPR for inline assembly. (PR #92338)

2024-05-29 Thread Freddy Ye via cfe-commits
@@ -57581,6 +57581,14 @@ X86TargetLowering::getConstraintType(StringRef Constraint) const { case '2': return C_RegisterClass; } +case 'j': + switch (Constraint[1]) { + default: +break; + case 'r': + case 'R': +return

[clang] [llvm] [PowerPC] Diagnose musttail instead of crash inside backend (PR #93267)

2024-05-29 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 deleted https://github.com/llvm/llvm-project/pull/93267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >