llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-backend-systemz
Author: Kazu Hirata (kazutakahirata)
Changes
I'm planning to remove StringRef::equals in favor of
StringRef::operator==.
- StringRef::operator==/!= outnumber StringRef::equals by a factor of
24 under
llvmbot wrote:
@llvm/pr-subscribers-backend-arm
Author: Kazu Hirata (kazutakahirata)
Changes
I'm planning to remove StringRef::equals in favor of
StringRef::operator==.
- StringRef::operator==/!= outnumber StringRef::equals by a factor of
24 under clang/ in terms of their usage.
- The
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/91844
I'm planning to remove StringRef::equals in favor of
StringRef::operator==.
- StringRef::operator==/!= outnumber StringRef::equals by a factor of
24 under clang/ in terms of their usage.
- The eliminati
https://github.com/Sirraide commented:
This needs tests to make sure this is actually doing what it’s supposed to do.
https://github.com/llvm/llvm-project/pull/91841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Qizhi Hu (jcsxky)
Changes
attempt to fix https://github.com/llvm/llvm-project/issues/77377
`isSameTemplateArg` returns incorrect result since clang didn't visit
constraint of NTTP. Furthermore, It makes class template partial
spe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
attempt to fix https://github.com/llvm/llvm-project/issues/77377
`isSameTemplateArg` returns incorrect result since clang didn't visit
constraint of NTTP. Furthermore, It makes class template partial
specializat
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/91842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/91842
attempt to fix
`isSameTemplateArg` returns incorrect result since clang didn't visit
constraint of NTTP. Furthermore, It makes class template partial
specialization not more specialized than the class template
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/91765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-05-11T10:20:27+04:00
New Revision: 1351aabf542b25e3ff1d36f4f2abe6727d0f19aa
URL:
https://github.com/llvm/llvm-project/commit/1351aabf542b25e3ff1d36f4f2abe6727d0f19aa
DIFF:
https://github.com/llvm/llvm-project/commit/1351aabf542b25e3ff1d36f4f2abe6727d0f19aa.
Author: Owen Pan
Date: 2024-05-10T23:14:58-07:00
New Revision: 5cd280433e8e063bf3c2390eaf152e726db5b0fb
URL:
https://github.com/llvm/llvm-project/commit/5cd280433e8e063bf3c2390eaf152e726db5b0fb
DIFF:
https://github.com/llvm/llvm-project/commit/5cd280433e8e063bf3c2390eaf152e726db5b0fb.diff
LOG:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Azmat Yusuf (azmat-y)
Changes
Added check for unexpanded parameter pack in attribute [[assume]]. This solves
#91232.
---
Full diff: https://github.com/llvm/llvm-project/pull/91841.diff
1 Files Affected:
- (modified) clang/lib/Sema/Sem
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/azmat-y created
https://github.com/llvm/llvm-project/pull/91841
Added check for unexpanded parameter pack in attribute [[assume]]. This solves
#91232.
>From c9f0887b5af64387938e0d80a4210af296e68f31 Mon Sep 17 00:00:00 2001
From: Azmat Yusuf
Date: Sat, 11 May 2024 09:56:02
https://github.com/goldsteinn updated
https://github.com/llvm/llvm-project/pull/91101
>From 33b4371e5285bea629eb51ed69b5664ea17c0383 Mon Sep 17 00:00:00 2001
From: Noah Goldstein
Date: Sat, 4 May 2024 18:12:34 -0500
Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter
attrib
https://github.com/goldsteinn edited
https://github.com/llvm/llvm-project/pull/91101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1352,20 +1352,43 @@ static void AddParamAndFnBasicAttributes(const CallBase
&CB,
auto &Context = CalledFunction->getContext();
// Collect valid attributes for all params.
- SmallVector ValidParamAttrs;
+ SmallVector ValidObjParamAttrs, ValidExactParamAttrs;
bool
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-05-11T12:15:24+08:00
New Revision: 3676b0945c800e3105f648d178b331953246716a
URL:
https://github.com/llvm/llvm-project/commit/3676b0945c800e3105f648d178b331953246716a
DIFF:
https://github.com/llvm/llvm-project/commit/3676b0945c800e3105f648d178b331953246716a.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/91757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
@sam-mccall @bgra8 @ericniebler I believe this MR should fix your issues:
https://github.com/llvm/llvm-project/pull/91833
Can you double check?
You might consider applying https://github.com/llvm/llvm-project/pull/91837,
since that is stacked on that and will revert the default
@@ -2583,11 +2580,27 @@ struct ConvertConstructorToDeductionGuideTransform {
//-- The types of the function parameters are those of the constructor.
for (auto *OldParam : TL.getParams()) {
- ParmVarDecl *NewParam =
- transformFunctionTypeParam(OldPara
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
When partial ordering alias templates against template template parameters,
allow pack expansions when the alias has a fixed-size parameter list.
These expansions were generally disallowed by proposed re
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/91833
When partial ordering alias templates against template template parameters,
allow pack expansions when the alias has a fixed-size parameter list.
These expansions were generally disallowed by proposed resolutio
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91830
>From 7773b0635aabeba769c0050e243f26008795d84b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 10 May 2024 18:42:07 -0700
Subject: [PATCH 1/5] [analyzer] Treat bitwise_cast, std::addressof, and new as
trivia
https://github.com/haoNoQ approved this pull request.
https://github.com/llvm/llvm-project/pull/91830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91830
>From 7773b0635aabeba769c0050e243f26008795d84b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 10 May 2024 18:42:07 -0700
Subject: [PATCH 1/4] [analyzer] Treat bitwise_cast, std::addressof, and new as
trivia
https://github.com/haoNoQ approved this pull request.
LGTM thanks!
https://github.com/llvm/llvm-project/pull/91830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/91712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-05-10T19:27:02-07:00
New Revision: e62ce1f8842cca36eb14126d79dcca0a85bf6d36
URL:
https://github.com/llvm/llvm-project/commit/e62ce1f8842cca36eb14126d79dcca0a85bf6d36
DIFF:
https://github.com/llvm/llvm-project/commit/e62ce1f8842cca36eb14126d79dcca0a85bf6d36.diff
LOG:
owenca wrote:
> I think this will stop people introducing extra arguments to function
>
> ...isCpp,isThis,isThat)
I meant to fix the FIXME after I had langded a8279a8bc541, but my previous
attempts didn't quite work. Now it seems this solution will stick.
https://github.com/llvm/llvm-project/
Author: Fangrui Song
Date: 2024-05-10T19:15:17-07:00
New Revision: df88d610ab10c1e3f22d7f5daf3794158972c584
URL:
https://github.com/llvm/llvm-project/commit/df88d610ab10c1e3f22d7f5daf3794158972c584
DIFF:
https://github.com/llvm/llvm-project/commit/df88d610ab10c1e3f22d7f5daf3794158972c584.diff
https://github.com/owenca requested changes to this pull request.
See https://github.com/llvm/llvm-project/pull/91221#issuecomment-2105454428.
https://github.com/llvm/llvm-project/pull/91221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
owenca wrote:
> Should I make dropping leading blank lines the default?
We should keep leading blank lines (up to `MaxEmptyLinesToKeep`) by default as
before.
https://github.com/llvm/llvm-project/pull/91221
___
cfe-commits mailing list
cfe-commits@li
@@ -819,6 +819,43 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
}
};
+// x86-64 UEFI target
+class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
+: public UEFITargetInfo {
+public:
+ UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar
owenca wrote:
I think this is a good time to combine the `KeepEmptyLines...` options. For
example:
```
KeepEmptyLines:
AtStartOfBlock: true
AtStartOfFile: false
AtEndOfFile: true
```
https://github.com/llvm/llvm-project/pull/91221
___
cfe-commit
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91830
>From 7773b0635aabeba769c0050e243f26008795d84b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 10 May 2024 18:42:07 -0700
Subject: [PATCH 1/3] [analyzer] Treat bitwise_cast, std::addressof, and new as
trivia
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91830
>From 7773b0635aabeba769c0050e243f26008795d84b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 10 May 2024 18:42:07 -0700
Subject: [PATCH 1/2] [analyzer] Treat bitwise_cast, std::addressof, and new as
trivia
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21be8182239a9c87a50071d122d5532037fd8305
7773b0635aabeba769c0050e243f26008795d84b --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91830.diff
2 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
(+6-1)
- (modified) clang/test/Analysis/Ch
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91830
None
>From 7773b0635aabeba769c0050e243f26008795d84b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 10 May 2024 18:42:07 -0700
Subject: [PATCH] [analyzer] Treat bitwise_cast, std::addressof, and new as
triv
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/87208
>From 35db92dfd0c2b43fc7afde5b093598763c4b8c89 Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Mon, 1 Apr 2024 02:26:14 +0300
Subject: [PATCH 1/4] Add config option to analyze unused system headers
---
clan
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 2dd3d3385642d88d538bc37673018f1231a56b14 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/2] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
@@ -1383,15 +1406,54 @@ static void AddParamAndFnBasicAttributes(const CallBase
&CB,
AttributeList AL = NewInnerCB->getAttributes();
for (unsigned I = 0, E = InnerCB->arg_size(); I < E; ++I) {
// Check if the underlying value for the parameter is an argumen
@@ -1352,20 +1352,43 @@ static void AddParamAndFnBasicAttributes(const CallBase
&CB,
auto &Context = CalledFunction->getContext();
// Collect valid attributes for all params.
- SmallVector ValidParamAttrs;
+ SmallVector ValidObjParamAttrs, ValidExactParamAttrs;
bool
https://github.com/dtcxzyw commented:
Oops I forgot to submit my review comment :(
https://github.com/llvm/llvm-project/pull/91101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw edited
https://github.com/llvm/llvm-project/pull/91101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -135,6 +135,21 @@ TEST(IncludeCleaner, GetUnusedHeaders) {
Pointee(writtenInclusion("\"dir/unused.h\"";
}
+TEST(IncludeCleaner, SystemUnusedHeaders) {
+ auto TU = TestTU::withCode(R"cpp(
+#include
+#include
+SystemClass x;
+ )c
@@ -135,6 +135,21 @@ TEST(IncludeCleaner, GetUnusedHeaders) {
Pointee(writtenInclusion("\"dir/unused.h\"";
}
+TEST(IncludeCleaner, SystemUnusedHeaders) {
+ auto TU = TestTU::withCode(R"cpp(
+#include
+#include
+SystemClass x;
+ )c
Author: Cyndy Ishida
Date: 2024-05-10T17:17:38-07:00
New Revision: 504cf554639360525c3f746e7296a242350b2af9
URL:
https://github.com/llvm/llvm-project/commit/504cf554639360525c3f746e7296a242350b2af9
DIFF:
https://github.com/llvm/llvm-project/commit/504cf554639360525c3f746e7296a242350b2af9.diff
@@ -572,32 +572,43 @@ struct FragmentCompiler {
#else
static llvm::Regex::RegexFlags Flags = llvm::Regex::NoFlags;
#endif
-auto Filters = std::make_shared>();
-for (auto &HeaderPattern : F.IgnoreHeader) {
- // Anchor on the right.
- std::string AnchoredPat
delcypher wrote:
> It's not a lie, because the contents of a pointer don't contribute to the
> size of the struct containing that pointer.
Consider this example. It tries to illustrate why putting `__counted_by()` on a
pointer to a structs containing flexible array members doesn't make sense.
@@ -572,32 +572,43 @@ struct FragmentCompiler {
#else
static llvm::Regex::RegexFlags Flags = llvm::Regex::NoFlags;
#endif
-auto Filters = std::make_shared>();
-for (auto &HeaderPattern : F.IgnoreHeader) {
- // Anchor on the right.
- std::string AnchoredPat
kees wrote:
> As @apple-fcloutier @rapidsna noted this is how `-fbounds-safety` is
> currently implemented (because its much simpler) but it is a restriction that
> could be lifted in future by only requiring `struct bar` to be defined at the
> point that `foo::bar` is used rather than when t
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/91757
>From e23675eae31ed9c3cc4bbf31d3bc43b492ef5eac Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 9 May 2024 00:51:58 +0800
Subject: [PATCH 1/2] [clang-tidy] avoid false postive when ignore macro
Fixes:
delcypher wrote:
> @rapidsna @delcypher @apple-fcloutier @kees:
>
> Okay, I think I see what the complication is. Are you trying to prevent the
> use case of someone writing something like:
>
> ```c
> struct bar;
>
> struct foo {
> size_t count;
> struct bar *ptr __counted_by(count);
> };
@@ -190,18 +190,30 @@ class SourceMappingRegion {
bool isBranch() const { return FalseCount.has_value(); }
+ bool isMCDCBranch() const {
+const auto *BranchParams =
std::get_if(&MCDCParams);
+assert(BranchParams == nullptr || BranchParams->ID >= 0);
+return (B
@@ -35,6 +35,8 @@ class RISCVTargetStreamer : public MCTargetStreamer {
RISCVABI::ABI TargetABI = RISCVABI::ABI_Unknown;
bool HasRVC = false;
bool HasTSO = false;
+ bool HasZICFILP = false;
jrtc27 wrote:
Make the fields and methods all Zifoo
https://gi
@@ -118,6 +147,19 @@ void RISCVTargetELFStreamer::finish() {
}
MCA.setELFHeaderEFlags(EFlags);
+
+ unsigned GNUNoteFlags = 0;
+
+ // check ZICFILP or ZICFISS with features
jrtc27 wrote:
Not sure this adds anything, but if it's staying please properly st
@@ -118,6 +147,19 @@ void RISCVTargetELFStreamer::finish() {
}
MCA.setELFHeaderEFlags(EFlags);
+
+ unsigned GNUNoteFlags = 0;
+
+ // check ZICFILP or ZICFISS with features
+ // TODO should we check with codegen enable ex. -mllvm
jrtc27 wrote:
This seem
@@ -5283,14 +5291,21 @@ static std::string getGNUProperty(uint32_t Type,
uint32_t DataSize,
OS << "";
return OS.str();
}
+
if (Type == GNU_PROPERTY_AARCH64_FEATURE_1_AND) {
- DumpBit(GNU_PROPERTY_AARCH64_FEATURE_1_BTI, "BTI");
- DumpBit(GNU_PROPE
@@ -85,6 +85,35 @@ void RISCVTargetELFStreamer::finishAttributeSection() {
ELF::SHT_RISCV_ATTRIBUTES, AttributeSection);
}
+void RISCVTargetELFStreamer::emitNoteSection(unsigned Flags) {
jrtc27 wrote:
I know this is what AArch64 call
@@ -5272,8 +5272,16 @@ static std::string getGNUProperty(uint32_t Type,
uint32_t DataSize,
return OS.str();
case GNU_PROPERTY_AARCH64_FEATURE_1_AND:
case GNU_PROPERTY_X86_FEATURE_1_AND:
-OS << ((Type == GNU_PROPERTY_AARCH64_FEATURE_1_AND) ? "aarch64 feature: "
-
delcypher wrote:
@vitalybuka Ping
https://github.com/llvm/llvm-project/pull/91032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/91822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2024-05-11T00:42:56+02:00
New Revision: 4198aebc96cb0236fc63e29a92d886e6a2e3fedb
URL:
https://github.com/llvm/llvm-project/commit/4198aebc96cb0236fc63e29a92d886e6a2e3fedb
DIFF:
https://github.com/llvm/llvm-project/commit/4198aebc96cb0236fc63e29a92d886e6a2e3fedb.diff
LOG:
https://github.com/jyu2-git converted_to_draft
https://github.com/llvm/llvm-project/pull/91426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyu2-git wrote:
Hi @alexey-bataev,
Sorry for bother you again. This is just re-check in the change you review
before. Plus a I need remove -fsyntex-only for my test target_ast_print.cpp
due to resent community change of e74a7a9fd79.
Thanks.
Jennifer
https://github.com/llvm/llvm-project/pu
https://github.com/mizvekov approved this pull request.
https://github.com/llvm/llvm-project/pull/91822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: cor3ntin (cor3ntin)
Changes
A few tests were checking for all driver flags.
We should revert this commit when we revert #91811
---
Full diff: https://github.com/llvm/llvm-project/pull/91822.diff
2 Files Affected:
- (modified) cla
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/91822
A few tests were checking for all driver flags.
We should revert this commit when we revert #91811
>From f2acd718bf4e24441a214309a1896771fe6c9fc9 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Sat, 11 May
ille-apple wrote:
Ping :)
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jyu2-git)
Changes
… (#90885)"
This reverts commit eea81aa29848361eb5b24f24d2af643fdeb9adfd.
---
Patch is 29.70 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91821.diff
4 Files Affecte
https://github.com/jyu2-git created
https://github.com/llvm/llvm-project/pull/91821
… (#90885)"
This reverts commit eea81aa29848361eb5b24f24d2af643fdeb9adfd.
>From f1b80dab94d13ef6d2425fdbae5b0ca532490584 Mon Sep 17 00:00:00 2001
From: Jennifer Yu
Date: Tue, 7 May 2024 18:24:53 -0700
Subject:
MaskRay wrote:
Some older toolchains were probably contributed with a lot of
`CmdArgs.push_back` uncovered by tests. They are not good examples to follow.
For new toolchains, we do want all constructed `CmdArgs.push_back` to be
covered. This allows refactoring by someone who is unfamiliar with
bwendling wrote:
@rapidsna @delcypher @apple-fcloutier @kees:
Okay, I think I see what the complication is. Are you trying to prevent the use
case of someone writing something like:
```c
struct bar;
struct foo {
size_t count;
struct bar *ptr __counted_by(count);
};
```
where `ptr` is a p
@@ -2583,11 +2580,27 @@ struct ConvertConstructorToDeductionGuideTransform {
//-- The types of the function parameters are those of the constructor.
for (auto *OldParam : TL.getParams()) {
- ParmVarDecl *NewParam =
- transformFunctionTypeParam(OldPara
bwendling wrote:
@apple-fcloutier:
> think that there's room to allow `__counted_by` on incomplete types so that a
> TU where it's complete could use it (and we have use cases where that would
> be handy), but our implementation doesn't support it at this time. This can
> be added without dis
cor3ntin wrote:
We operated a partial revert here
https://github.com/llvm/llvm-project/pull/91811
That should fix the issues in trunk while we investigate the regression more
thoroughly
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/91811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-05-10T23:32:34+02:00
New Revision: 2d5634a4b39d8e5497b6a67caa54049b3cfade8e
URL:
https://github.com/llvm/llvm-project/commit/2d5634a4b39d8e5497b6a67caa54049b3cfade8e
DIFF:
https://github.com/llvm/llvm-project/commit/2d5634a4b39d8e5497b6a67caa54049b3cfade8e.dif
cor3ntin wrote:
@erichkeane The goal is to provide a temporary working default, and a proper
fix next fix, so that folks who are impacted by the break (everyone working on
stdexec) isn't impacted longer than necessary. So I'll go and merge that and we
can discuss a longer-term solution monday
rnk wrote:
Hey, I went ahead and reverted this patch in
aa0776de464984e78ae1cc329bf541e9dd43631f because it is incompatible with ASan
ThinLTO builds. I think you have uncovered a latent issue in the ASan + thinlto
configuration that is not really the fault of this change, but I didn't see a
Author: Reid Kleckner
Date: 2024-05-10T21:28:13Z
New Revision: aa0776de464984e78ae1cc329bf541e9dd43631f
URL:
https://github.com/llvm/llvm-project/commit/aa0776de464984e78ae1cc329bf541e9dd43631f
DIFF:
https://github.com/llvm/llvm-project/commit/aa0776de464984e78ae1cc329bf541e9dd43631f.diff
LOG:
@@ -7249,15 +7249,15 @@ void Clang::ConstructJob(Compilation &C, const
JobAction &JA,
Args.addOptOutFlag(CmdArgs, options::OPT_fassume_unique_vtables,
options::OPT_fno_assume_unique_vtables);
- // -frelaxed-template-template-args is deprecated.
- if (
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/91811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
This should probably also change the release note that still says we've changed
this to on by default.
https://github.com/llvm/llvm-project/pull/91811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/91811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This partially reverts b86e0992bfa6c58be077d82d824016f590ac5d90.
Just the default is changed back, on the Driver side.
No Frontend changes.
The positive spelling of the flag is undeprecated.
No documenta
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Matheus Izvekov (mizvekov)
Changes
This partially reverts b86e0992bfa6c58be077d82d824016f590ac5d90.
Just the default is changed back, on the Driver side.
No Frontend changes.
The positive spelling of the flag is undeprecated.
No do
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/91811
This partially reverts b86e0992bfa6c58be077d82d824016f590ac5d90.
Just the default is changed back, on the Driver side.
No Frontend changes.
The positive spelling of the flag is undeprecated.
No documentation ch
https://github.com/antangelo edited
https://github.com/llvm/llvm-project/pull/91046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -238,3 +238,17 @@
// RUN: %clang -### -fno-unsafe-math-optimizations -funsafe-math-optimizations
\
// RUN: -ffp-contract=off -c %s 2>&1 | FileCheck --check-prefix=CHECK-FPC-OFF
%s
+// RUN: %clang -### -funsafe-math-optimizations -ffp-contract=off -c %s 2>&1 \
https://github.com/scchan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,55 @@
+/*=== __clang_hip_device_macro_guards.h - guards for HIP device macros -===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ * SPDX-License-Identifier: Apach
https://github.com/soukatch deleted
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 337 matches
Mail list logo
