prj- wrote:
Any hope that this lands in 18.1? Thanks anyway!
https://github.com/llvm/llvm-project/pull/81444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Closes #81399.
---
Full diff: https://github.com/llvm/llvm-project/pull/81444.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+1-1)
- (modified) clang/unittests/Format/Form
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/81444
Closes #81399.
>From 9d91878e9cb65ab67de8251976ee748ed03fc2b6 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 11 Feb 2024 23:28:25 -0800
Subject: [PATCH] [clang-format] Don't remove parentheses in macro defini
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,Nhat Nguyen
Message-ID:
In-Reply-To:
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00
Author: Owen Pan
Date: 2024-02-11T22:51:18-08:00
New Revision: 00918933fc4e181fe3c74006d81d7a598c2227b3
URL:
https://github.com/llvm/llvm-project/commit/00918933fc4e181fe3c74006d81d7a598c2227b3
DIFF:
https://github.com/llvm/llvm-project/commit/00918933fc4e181fe3c74006d81d7a598c2227b3.diff
LOG:
Author: Owen Pan
Date: 2024-02-11T22:01:23-08:00
New Revision: 32e65b0b8a743678974c7ca7913c1d6c41bb0772
URL:
https://github.com/llvm/llvm-project/commit/32e65b0b8a743678974c7ca7913c1d6c41bb0772
DIFF:
https://github.com/llvm/llvm-project/commit/32e65b0b8a743678974c7ca7913c1d6c41bb0772.diff
LOG:
@@ -898,6 +898,34 @@ TEST(DiagnosticTest, ClangTidySelfContainedDiags) {
withFix(equalToFix(ExpectedDFix));
}
+TEST(DiagnosticTest, ClangTidySelfContainedDiagsFormatting) {
kevinjoseph1995 wrote:
Added a case in
clang-tools-extra/test/cla
https://github.com/kevinjoseph1995 updated
https://github.com/llvm/llvm-project/pull/81435
>From db2c4ee74ffb0592ec7f3fd5557dbb5399ef998d Mon Sep 17 00:00:00 2001
From: Kevin Joseph
Date: Sun, 11 Feb 2024 13:39:51 -0800
Subject: [PATCH 1/2] [clangd] Clean formatting modernize-use-override
When
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 7ef83de2bfc13da0b317d144a38f223b3738889b Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
@@ -308,13 +309,21 @@ Error
RawCoverageMappingReader::readMappingRegionsSubArray(
return Err;
if (auto Err = readIntMax(FID, std::numeric_limits::max()))
return Err;
+ if (ID == 0)
+return make_error(
+cove
https://github.com/chapuni commented:
@ornata I want to isolate Decision stuff and Branch stuff in `MCDCParams`.
Also I'd like to encapsulate params into each record. Once parameters are set,
they are expected to hold "valid" values. Zeroing really confused me, (possibly
us).
I've found `std::
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
https://github.com/AtariDreams edited
https://github.com/llvm/llvm-project/pull/81335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
ornata wrote:
Is the main benefit of this avoiding zero initialization?
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -308,13 +309,21 @@ Error
RawCoverageMappingReader::readMappingRegionsSubArray(
return Err;
if (auto Err = readIntMax(FID, std::numeric_limits::max()))
return Err;
+ if (ID == 0)
+return make_error(
+cove
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH 1/2] =?UTF-8?q?[clang-tidy]=C2=A0Rem
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/81437
>From 3470dc38c1864b2fb6b773e99c30251c083dfd09 Mon Sep 17 00:00:00 2001
From: Julian Schmidt
Date: Mon, 12 Feb 2024 00:38:05 +0100
Subject: [PATCH 1/2] [clang] remove (clang::)ast_matchers:: namespace from
pars
5chmidti wrote:
Should the tag of this pr be [ASTMatcher] or [clang]?
https://github.com/llvm/llvm-project/pull/81437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Julian Schmidt (5chmidti)
Changes
When parsing the ASTMatchers.h file, a matcher could specify an argument that
is a matcher using the not needed namespace `(clang::)ast_matchers::`.
Change the argument parsing in dump_ast_matchers.py to r
HighCommander4 wrote:
(It's also no longer labelled as a "quick fix", likely due to the
`CodeActionKind` changing from `quickfix` to `refactor`, but that's probably
fine.)
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
c
https://github.com/5chmidti created
https://github.com/llvm/llvm-project/pull/81437
When parsing the ASTMatchers.h file, a matcher could specify an argument that
is a matcher using the not needed namespace `(clang::)ast_matchers::`.
Change the argument parsing in dump_ast_matchers.py to remove
HighCommander4 wrote:
Something else I noticed while trying out the patch locally: before the patch,
the description of the quick fix in the editor is "change 'foo' to 'Foo'", i.e.
a description of what the code action will do.
After the patch, the description of the quick fix is now "invalid
PiotrZSL wrote:
Release notes entry (for clang-tidy) is also missing.
https://github.com/llvm/llvm-project/pull/81435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -228,8 +228,8 @@ void UseOverrideCheck::check(const MatchFinder::MatchResult
&Result) {
if (HasVirtual) {
for (Token Tok : Tokens) {
if (Tok.is(tok::kw_virtual)) {
-Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange(
-Tok.getLoca
@@ -898,6 +898,34 @@ TEST(DiagnosticTest, ClangTidySelfContainedDiags) {
withFix(equalToFix(ExpectedDFix));
}
+TEST(DiagnosticTest, ClangTidySelfContainedDiagsFormatting) {
PiotrZSL wrote:
Tests for clang tidy should be added here:
clang-
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Kevin Joseph (kevinjoseph1995)
Changes
When applying the recommended fix for the
"modernize-use-override" clang-tidy diagnostic
there was a stray whitespace. This PR fixes that.
Resolves https://g
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/kevinjoseph1995 created
https://github.com/llvm/llvm-project/pull/81435
When applying the recommended fix for the
"modernize-use-override" clang-tidy diagnostic
there was a stray whitespace. This PR fixes that.
Resolves https://github.com/clangd/clangd/issues/1704
>From db2c4
Author: Owen Pan
Date: 2024-02-11T13:08:28-08:00
New Revision: 3dc8ef677d7d05116a0bf6524eb38b02ca6ba042
URL:
https://github.com/llvm/llvm-project/commit/3dc8ef677d7d05116a0bf6524eb38b02ca6ba042
DIFF:
https://github.com/llvm/llvm-project/commit/3dc8ef677d7d05116a0bf6524eb38b02ca6ba042.diff
LOG:
Author: Owen Pan
Date: 2024-02-11T12:59:05-08:00
New Revision: 03f571995b4f0c260254955afd16ec44d0764794
URL:
https://github.com/llvm/llvm-project/commit/03f571995b4f0c260254955afd16ec44d0764794
DIFF:
https://github.com/llvm/llvm-project/commit/03f571995b4f0c260254955afd16ec44d0764794.diff
LOG:
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -47,6 +47,9 @@ AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
+
+AST_MATCHER(clang::VarDecl, hasInitialization) { return Node.hasInit(); }
felix642 wrote:
Simply di
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
https://github.com/PiotrZSL approved this pull request.
LGTM.
Just 2 nits, but not a blocker.
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -47,6 +47,9 @@ AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
+
+AST_MATCHER(clang::VarDecl, hasInitialization) { return Node.hasInit(); }
PiotrZSL wrote:
why not u
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/80299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/81390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/torshepherd updated
https://github.com/llvm/llvm-project/pull/78999
>From 6abe2b5af090329bfca42d144597fbd5ca41d511 Mon Sep 17 00:00:00 2001
From: Tor Shepherd
Date: Sun, 21 Jan 2024 17:53:31 -0500
Subject: [PATCH] [clangd] Swap binary operands
---
.../clangd/refactor/tweaks
https://github.com/torshepherd updated
https://github.com/llvm/llvm-project/pull/79867
>From 636e8286b38839c9d90e9eb147ba59d588c3241c Mon Sep 17 00:00:00 2001
From: Tor Shepherd
Date: Mon, 29 Jan 2024 11:44:25 -0500
Subject: [PATCH] [clangd] Add fix-all CodeActions
---
clang-tools-extra/clang
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
https://github.com/AMP999 updated
https://github.com/llvm/llvm-project/pull/81298
>From d59c262b31937fdd2b907ec11d7f08e4a385007c Mon Sep 17 00:00:00 2001
From: Amirreza Ashouri
Date: Fri, 9 Feb 2024 21:55:03 +0330
Subject: [PATCH 1/2] [clang] Support `__is_trivially_copyable(int()&)==false`
IM
AMP999 wrote:
@AaronBallman, does this look okay to you? See
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p1144r9.html#abstract-opdef-trivially-relocatable
and
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2786r3.pdf#subsection.12.4
which both agree on this point.
htt
Author: Danny Mösch
Date: 2024-02-11T19:43:34+01:00
New Revision: 00e80fbfb9151a68e7383dcec7da69c867225e54
URL:
https://github.com/llvm/llvm-project/commit/00e80fbfb9151a68e7383dcec7da69c867225e54
DIFF:
https://github.com/llvm/llvm-project/commit/00e80fbfb9151a68e7383dcec7da69c867225e54.diff
L
https://github.com/SimplyDanny closed
https://github.com/llvm/llvm-project/pull/81421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Danny Mösch
Date: 2024-02-11T19:43:34+01:00
New Revision: 00e80fbfb9151a68e7383dcec7da69c867225e54
URL:
https://github.com/llvm/llvm-project/commit/00e80fbfb9151a68e7383dcec7da69c867225e54
DIFF:
https://github.com/llvm/llvm-project/commit/00e80fbfb9151a68e7383dcec7da69c867225e54.diff
L
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 56207acd7ce55b328b7c72071335b0b452c7a97b Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Félix-Antoine Constantin (felix642)
Changes
Updated the check to ignore point static data members with in class initializer
since removing the inline specifier would generate a compilation error
Fixes #80684
---
Full diff:
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH] =?UTF-8?q?[clang-tidy]=C2=A0Removed
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/81423
Updated the check to ignore point static data members with in class initializer
since removing the inline specifier would generate a compilation error
Fixes #80684
From 45c89e269bd37e298dd12035dc78c986fa47e8
https://github.com/5chmidti requested changes to this pull request.
I had an idea for the added matchers that improves their readability.
https://github.com/llvm/llvm-project/pull/77246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
@@ -19,6 +19,18 @@ using namespace clang::ast_matchers::internal;
namespace clang::tidy::cppcoreguidelines {
+namespace {
+AST_MATCHER_P(LambdaExpr, hasCallOperator,
+ ast_matchers::internal::Matcher, InnerMatcher) {
+ return InnerMatcher.matches(*Node.getCallOp
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/77246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -147,10 +161,51 @@ void OwningMemoryCheck::registerMatchers(MatchFinder
*Finder) {
// Matching on functions, that return an owner/resource, but don't declare
// their return type as owner.
Finder->addMatcher(
- functionDecl(hasDescendant(returnStmt(hasReturnValue
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/81421
From 270d4db6430c9e140b1e1a849b9dd6b61cd6075e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sun, 11 Feb 2024 17:27:55 +0100
Subject: [PATCH] Correct C++ standard names
---
.../clang-ti
https://github.com/EugeneZelenko approved this pull request.
https://github.com/llvm/llvm-project/pull/81421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/81421
From d2b0ecd78908c689c49e6405cc96beefea406115 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sun, 11 Feb 2024 17:27:55 +0100
Subject: [PATCH] Correct C++ standard names
---
.../clang-ti
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/81420
From 71a6a9810c9c3b67058f09969417ebac0f950fdb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sun, 11 Feb 2024 17:04:12 +0100
Subject: [PATCH 1/2] [clang-tidy] Add fix-its to
`avoid-retur
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-x86
Author: Danny Mösch (SimplyDanny)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81421.diff
16 Files Affected:
- (modified) clang-tools-extra/clang-tidy/mode
https://github.com/SimplyDanny created
https://github.com/llvm/llvm-project/pull/81421
None
From 836e74202bb9f80ad2a45ff93de1c4ff2002eaf6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sun, 11 Feb 2024 17:27:55 +0100
Subject: [PATCH] Correct C++ standard names
---
.../cl
@@ -42,10 +43,28 @@ void AvoidReturnWithVoidValueCheck::check(
const auto *VoidReturn = Result.Nodes.getNodeAs("void_return");
if (IgnoreMacros && VoidReturn->getBeginLoc().isMacroID())
return;
- if (!StrictMode && !Result.Nodes.getNodeAs("compound_parent"))
+ const a
@@ -42,10 +43,28 @@ void AvoidReturnWithVoidValueCheck::check(
const auto *VoidReturn = Result.Nodes.getNodeAs("void_return");
if (IgnoreMacros && VoidReturn->getBeginLoc().isMacroID())
return;
- if (!StrictMode && !Result.Nodes.getNodeAs("compound_parent"))
+ const a
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/80541
From 528ec390e23e6883356606c9acdba3315d5f59bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sat, 3 Feb 2024 13:13:50 +0100
Subject: [PATCH 01/23] Trigger on variable declarations
---
.
https://github.com/SimplyDanny edited
https://github.com/llvm/llvm-project/pull/80541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,14 +12,18 @@ void f2() {
return f1();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: return statement within a void
function should not have a specified return value
[readability-avoid-return-with-void-value]
// CHECK-MESSAGES-LENIENT: :[[@LINE-2]]:5: warning:
@@ -12,14 +12,18 @@ void f2() {
return f1();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: return statement within a void
function should not have a specified return value
[readability-avoid-return-with-void-value]
// CHECK-MESSAGES-LENIENT: :[[@LINE-2]]:5: warning:
AtariDreams wrote:
@rjmccall Are these tests adequate?
https://github.com/llvm/llvm-project/pull/81335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Danny Mösch (SimplyDanny)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81420.diff
3 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.cpp
(+21-2)
- (modified
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Danny Mösch (SimplyDanny)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81420.diff
3 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.cpp
(+21-2)
- (m
https://github.com/SimplyDanny created
https://github.com/llvm/llvm-project/pull/81420
None
From 71a6a9810c9c3b67058f09969417ebac0f950fdb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sun, 11 Feb 2024 17:04:12 +0100
Subject: [PATCH] [clang-tidy] Add fix-its to `avoid-retu
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3=B6sch?= ,
Danny =?utf-8?q?M=C3
@@ -168,3 +168,30 @@ auto lambda4 = [] requires(sizeof(char) == 1){}; //
expected-error {{expected bo
#if __cplusplus <= 202002L
// expected-warning@-2{{lambda without a parameter clause is a C++23
extension}}
#endif
+
+namespace GH78524 {
+
+template T Foo;
+
+template aut
@@ -1385,6 +1385,11 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer(
Diag(RAngleLoc,
diag::err_lambda_template_parameter_list_empty);
} else {
+ // We increase the template depth before recursing into a
requires-clause.
+ // The abbrev
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/80656
>From 48211eb7778db8fb8af144d59adb2e0941957c4c Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 5 Feb 2024 18:01:34 +0800
Subject: [PATCH 1/3] GH78524
---
clang/docs/ReleaseNotes.rst |
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (44-2-Kupa-Martin)
Changes
…C mode
Factored logic from `CheckImplicitConversion` into new methods
`Expr::getEnumConstantDecl` and `Expr::getEnumCoercedType` for use in
`checkEnumArithmeticConversions`.
Fix #29217
---
Full diff: ht
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/44-2-Kupa-Martin created
https://github.com/llvm/llvm-project/pull/81418
…C mode
Factored logic from `CheckImplicitConversion` into new methods
`Expr::getEnumConstantDecl` and `Expr::getEnumCoercedType` for use in
`checkEnumArithmeticConversions`.
Fix #29217
>From a1748e5
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/81150
>From d9fe7f3777a27057181eaa008577fc13a30d30ee Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 10 Feb 2024 15:34:36 +0800
Subject: [PATCH 1/3] fixup
---
clang/include/clang/AST/DeclCXX.h | 6 +
Author: Vlad Serebrennikov
Date: 2024-02-11T17:27:31+03:00
New Revision: e3f684d86b308bc2576d813aad1a230aa6b295ab
URL:
https://github.com/llvm/llvm-project/commit/e3f684d86b308bc2576d813aad1a230aa6b295ab
DIFF:
https://github.com/llvm/llvm-project/commit/e3f684d86b308bc2576d813aad1a230aa6b295ab.
SimplyDanny wrote:
@PiotrZSL: I'm not quite sure if I reproduced all your suggested examples
properly. Almost all of them appeared to be working as expected already, so I
only added them as test cases.
https://github.com/llvm/llvm-project/pull/80541
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/80541
From 528ec390e23e6883356606c9acdba3315d5f59bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sat, 3 Feb 2024 13:13:50 +0100
Subject: [PATCH 01/22] Trigger on variable declarations
---
.
11happy wrote:
sorry for last 3 continuous format code commits, I usually run `git
clang-format HEAD~1` and also ran this time idk why it was not correctly
formatted so I tried manually and it resulted in so many commits,
Thank you
https://github.com/llvm/llvm-project/pull/80040
__
SimplyDanny wrote:
I want to reuse this function from Clangd (which provides inlay hints for
aggregate types).
Not sure if this is the right place for such common functionality. Please guide
me to find a better location if it doesn't fit well here.
For revie
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/80541
From 528ec390e23e6883356606c9acdba3315d5f59bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sat, 3 Feb 2024 13:13:50 +0100
Subject: [PATCH 01/21] Trigger on variable declarations
---
.
vinayakdsci wrote:
@cor3ntin is this good to go?
Thanks!
https://github.com/llvm/llvm-project/pull/81127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 142 matches
Mail list logo
