PragmaTwice wrote:
The CI finally passed now : )
https://github.com/llvm/llvm-project/pull/71819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,49 @@
+//===--===//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
gedare wrote:
> > @owenca this waits for re-review
>
> Can you rebase the patch?
done
https://github.com/llvm/llvm-project/pull/69340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/gedare updated
https://github.com/llvm/llvm-project/pull/69340
>From 65e3a69e30810683ba76d9a233a9c408fd121120 Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Thu, 9 Nov 2023 09:30:24 -0700
Subject: [PATCH 1/7] Revert "Revert "[clang-format] Fix align consecutive
declaratio
https://github.com/MaskRay approved this pull request.
Looks great!
https://github.com/llvm/llvm-project/pull/73214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PragmaTwice updated
https://github.com/llvm/llvm-project/pull/71819
>From 3e4b73d2aeac411a83dda5cd63eb0572499db467 Mon Sep 17 00:00:00 2001
From: PragmaTwice
Date: Fri, 10 Nov 2023 00:50:24 +0900
Subject: [PATCH 1/8] [libc++] Implement LWG3940 (std::expected::value() also nee
https://github.com/shafik commented:
This should have a release note and I think this is a potentially breaking
change since folks using `Wextra` may get this diagnostic now.
https://github.com/llvm/llvm-project/pull/77178
___
cfe-commits mailing list
https://github.com/Abhinkop updated
https://github.com/llvm/llvm-project/pull/77178
>From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001
From: Abhin Parekadan Jose
Date: Sat, 6 Jan 2024 05:09:36 +0100
Subject: [PATCH] [clang] move -Wcast-function-type under -Wextra
---
clan
Abhinkop wrote:
@nickdesaulniers
https://github.com/llvm/llvm-project/pull/77178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Abhin P Jose (Abhinkop)
Changes
This patch is for github issue
https://github.com/llvm/llvm-project/issues/76872.
The -Wcast-fuction-type-strict has been moved under dignstic group -Wextra.
Edited the test cases for -Wcast-fuction-type-s
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
https://github.com/Abhinkop created
https://github.com/llvm/llvm-project/pull/77178
This patch is for github issue
https://github.com/llvm/llvm-project/issues/76872.
The -Wcast-fuction-type-strict has been moved under dignstic group -Wextra.
Edited the test cases for -Wcast-fuction-type-stric
https://github.com/nmosier closed
https://github.com/llvm/llvm-project/pull/77175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Nicholas Mosier (nmosier)
Changes
This patch fixes a bug (GitHub issue #77128) that caused the compiler
to emit 32-bit (rather than 64-bit) relocations for TLS offsets under a
medium/large code model for x86-64 targets, resulting in
https://github.com/nmosier updated
https://github.com/llvm/llvm-project/pull/77175
>From b6351e796868be27075518fb51830bf79c60cdf6 Mon Sep 17 00:00:00 2001
From: Nicholas Mosier
Date: Sat, 6 Jan 2024 03:36:03 +
Subject: [PATCH] [X86][ISel] Select MOV/ADD64ri32 for tglobaltlsaddr only
under
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
owenca wrote:
> @owenca this waits for re-review
Can you rebase the patch?
https://github.com/llvm/llvm-project/pull/69340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrmwng wrote:
> @jrmwng PR #76985 (landed in
> [853b133](https://github.com/llvm/llvm-project/commit/853b13342a131e06d61293ec6e840642054c6c85))
> seems to have resolved this issue for me. Can you confirm that on your end?
Yes, your fix is effective 💯
https://github.com/llvm/llvm-project/pull
@@ -0,0 +1,49 @@
+//===--===//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/PragmaTwice updated
https://github.com/llvm/llvm-project/pull/71819
>From 3e4b73d2aeac411a83dda5cd63eb0572499db467 Mon Sep 17 00:00:00 2001
From: PragmaTwice
Date: Fri, 10 Nov 2023 00:50:24 +0900
Subject: [PATCH 1/8] [libc++] Implement LWG3940 (std::expected::value() also nee
@@ -53,18 +53,76 @@ AST_MATCHER(ParmVarDecl, isTemplateTypeParameter) {
FuncTemplate->getTemplateParameters()->getDepth();
}
+AST_MATCHER_P(NamedDecl, hasSameNameAsBoundNode, std::string, BindingID) {
+ const auto &Name = Node.getNameAsString();
+
+ return Builder->
@@ -53,18 +53,76 @@ AST_MATCHER(ParmVarDecl, isTemplateTypeParameter) {
FuncTemplate->getTemplateParameters()->getDepth();
}
+AST_MATCHER_P(NamedDecl, hasSameNameAsBoundNode, std::string, BindingID) {
+ const auto &Name = Node.getNameAsString();
+
+ return Builder->
@@ -147,4 +147,24 @@ class AClass {
T data;
};
+template
+void lambda_value_reference(T&& t) {
+ [&]() { T other = std::forward(t); };
+}
+
+template
+void lambda_value_reference_capture_list_ref_1(T&& t) {
+[=, &t] { T other = std::forward(t); };
+}
+
+template
+void
@@ -53,18 +53,76 @@ AST_MATCHER(ParmVarDecl, isTemplateTypeParameter) {
FuncTemplate->getTemplateParameters()->getDepth();
}
+AST_MATCHER_P(NamedDecl, hasSameNameAsBoundNode, std::string, BindingID) {
+ const auto &Name = Node.getNameAsString();
jcsx
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/77056
>From 0f1e72b143d360c1f005f4bd63a378c5277d4480 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Wed, 3 Jan 2024 09:44:26 +0800
Subject: [PATCH] [clang-tidy] fix false positive in
cppcoreguidelines-missing-std-forward
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/77056
>From 4b8438f448010d8a805549d8c0fa902266c643e0 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Wed, 3 Jan 2024 09:44:26 +0800
Subject: [PATCH] [clang-tidy] fix false positive in
cppcoreguidelines-missing-std-forward
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/77162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/77162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/77152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bwendling closed
https://github.com/llvm/llvm-project/pull/76882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -187,80 +187,132 @@ Value *lowerObjectSizeCall(
const TargetLibraryInfo *TLI, AAResults *AA, bool MustSucceed,
SmallVectorImpl *InsertedInstructions = nullptr);
-using SizeOffsetType = std::pair;
+/// SizeOffsetType - A base template class for the object size visito
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/76882
>From ca7a96a40952fe94b916dacc52f07aa90bbdb1e7 Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Wed, 3 Jan 2024 13:22:37 -0800
Subject: [PATCH 1/9] [builtin_object_size] Use classes instead of std::pair
(NFC
https://github.com/kstoimenov approved this pull request.
https://github.com/llvm/llvm-project/pull/77152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> illumos has an older version of the Solaris linker that does not support the
> GNU version script compat nor version scripts and does not support
> -Bsymbolic-functions. Treat illumos linker separately.
Are they aware of the issue and is there a tracking feature request/issue?
@@ -241,6 +241,11 @@ if (NOT DEFINED LLVM_LINKER_DETECTED AND NOT WIN32)
set(LLVM_LINKER_DETECTED YES CACHE INTERNAL "")
set(LLVM_LINKER_IS_GNULD YES CACHE INTERNAL "")
message(STATUS "Linker detection: GNU ld")
+elseif("${stderr}" MATCHES "(illumos)" OR
+
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/77163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/77152
>From 484721a2c62b33385bf8cfec2f00450c2079a2a2 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 5 Jan 2024 14:31:51 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?UT
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/77148
>From 4714b0c03897ab61322e3a16288994ccb01dbfac Mon Sep 17 00:00:00 2001
From: ziqingluo-90
Date: Fri, 5 Jan 2024 13:39:39 -0800
Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Add a new warning for use of
two-
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/77146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/77146
>From 250c84b0b0278e4f03aace2bfc03943543ed5f23 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 5 Jan 2024 14:06:44 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?UT
https://github.com/heiher closed https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hev
Date: 2024-01-06T08:51:59+08:00
New Revision: 4df566290751403f470fea3b27aa148ab1ddf144
URL:
https://github.com/llvm/llvm-project/commit/4df566290751403f470fea3b27aa148ab1ddf144
DIFF:
https://github.com/llvm/llvm-project/commit/4df566290751403f470fea3b27aa148ab1ddf144.diff
LOG: [cla
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/77148
>From fb93d83d65ef1c52857b4471ccda2e82447d45dc Mon Sep 17 00:00:00 2001
From: ziqingluo-90
Date: Fri, 5 Jan 2024 13:39:39 -0800
Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Add a new warning for use of
two-
@@ -5,13 +5,13 @@
// RUN: %clang -O3 -target aarch64-linux-eabi -mno-fix-cortex-a53-835769 %s -S
-o- 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NO --check-prefix=CHECK %s
-// RUN: %clang -O3 -target aarch64-android-eabi %s -S -o- \
+// RUN: %clang -O3 -target aarch64-l
@@ -786,4 +786,7 @@ def warn_android_unversioned_fallback : Warning<
" directories will not be used in Clang 19. Provide a versioned directory"
" for the target version or lower instead.">,
InGroup>;
+
+def err_android_version_invalid : Error<
+ "Version %0 in triple %1-
https://github.com/antiagainst closed
https://github.com/llvm/llvm-project/pull/75660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
antiagainst wrote:
Thanks for the contribution! Sorry about the delay in reviews. I do have some
style-ish comments but given this has been a while I just went ahead fixed them
and will land this path directly. Thanks again!
https://github.com/llvm/llvm-project/pull/75660
https://github.com/antiagainst approved this pull request.
https://github.com/llvm/llvm-project/pull/75660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
The title should probably be changed to something like:
`[RISCV] Add Zicfiss support to the shadow call stack implementation`
The current title doesn't make much sense to me, but maybe I've misunderstood
the intent?
https://github.com/llvm/llvm-project/pull/68075
__
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/77146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2499,6 +2499,15 @@ TEST_F(TokenAnnotatorTest, BraceKind) {
EXPECT_BRACE_KIND(Tokens[6], BK_Block);
}
+TEST_F(TokenAnnotatorTest, StreamOperator) {
+ auto Tokens = annotate("\"foo\\n\" << aux << \"foo\\n\" << \"foo\";");
+ ASSERT_EQ(Tokens.size(), 9u) << Tokens;
+ EXPE
@@ -57,11 +57,14 @@ compiled application or the operating system. Integrating
the runtime into
the operating system should be preferred since otherwise all thread creation
and destruction would need to be intercepted by the application.
-The instrumentation makes use of the p
https://github.com/ilovepi commented:
Should the driver issue an error when using `-mforced-sw-shadow-stack` w/o
`Zicfiss`? As mentioned in-line, I'm not sure we can do that check, but it
feels like it should be incompatible.
https://github.com/llvm/llvm-project/pull/68075
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/68075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -151,9 +155,10 @@ Usage
To enable ShadowCallStack, just pass the ``-fsanitize=shadow-call-stack`` flag
to both compile and link command lines. On aarch64, you also need to pass
-``-ffixed-x18`` unless your target already reserves ``x18``. On RISC-V, ``x3``
-(``gp``) is alwa
https://github.com/antiagainst updated
https://github.com/llvm/llvm-project/pull/75660
>From fd8c637f2b146ffce657307841f84a4123e351af Mon Sep 17 00:00:00 2001
From: Dimple Prajapati
Date: Wed, 13 Dec 2023 22:33:23 +
Subject: [PATCH 1/6] [mlir][spirv] Fix spirv dialect to support Specializat
ellishg wrote:
> This caused some ignorelist changes, e.g.
>
>
>
> `src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h`
>
>
>
> didn't work anymore and the opt-out made it work again. Still investigating
> why.
Not sure if it's the reason, but the `.` in `vk_mem_alloc.h` matc
aeubanks wrote:
This caused some ignorelist changes, e.g.
`src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h`
didn't work anymore and the opt-out made it work again. Still investigating why.
https://github.com/llvm/llvm-project/pull/74809
_
shafik wrote:
I think I would like some more eyes on this, I don't know if it is obvious to
me what it means to reallocate a volatile object.
https://github.com/llvm/llvm-project/pull/77092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
SimplyDanny wrote:
Thank you, @PiotrZSL, for the reviews and helpful suggestions!
https://github.com/llvm/llvm-project/pull/76249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SimplyDanny closed
https://github.com/llvm/llvm-project/pull/76249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Danny Mösch
Date: 2024-01-06T00:14:08+01:00
New Revision: a89141f733cef817c586bb6da0ea69a5a323874e
URL:
https://github.com/llvm/llvm-project/commit/a89141f733cef817c586bb6da0ea69a5a323874e
DIFF:
https://github.com/llvm/llvm-project/commit/a89141f733cef817c586bb6da0ea69a5a323874e.diff
L
Michael137 wrote:
Proposed fix: https://github.com/llvm/llvm-project/pull/77155
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/77145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/77145
>From d3a38ee314802fca37849ae33fa7d445369f0956 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 5 Jan 2024 14:06:41 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?UT
EugeneZelenko wrote:
You need to do interactive rebase:
```
git fetch --prune # get latest main and remove local copies deleted branch
git rebase origin/main # rebase from main
git rebase -i origin/main # interactive rebase, just use fixup command
git rebase --force origin # push updated branc
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/77145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13846,6 +13880,37 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/77144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeroomega wrote:
Hi, this change breaks libcxx test on Windows due to unable to find "unistd.h"
file (which doesn't exist on msvc based environment).
Failed test message and failed commandline:
```
Failed Tests (8):
llvm-libc++-static-clangcl.cfg.in ::
std/input.output
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/77144
>From 878c38dba9d819b79b8db8b3044078839f5a4e55 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 5 Jan 2024 14:06:37 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?UT
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d7b4debf98fd740f821bda717de7b807e26ae95a
54d75df6c413a5b273a059426b00def7437ab525 --
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
@llvm/pr-subscribers-clang
Author: Ziqing Luo (ziqingluo-90)
Changes
The PR contains two commits:
1. adding a new waring under a sub-group of `-Wunsafe-buffer-usage`
2. teach the analyzer to be quiet on some benign cases
---
Patch is 22.
@@ -5151,6 +5151,14 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
&Line,
return true;
if (Left.IsUnterminatedLiteral)
return true;
+ // FIXME: Breaking after newlines seems useful in general. Turn this into an
+ // option and recognize more cases like
https://github.com/ziqingluo-90 created
https://github.com/llvm/llvm-project/pull/77148
The PR contains two commits:
1. adding a new waring under a sub-group of `-Wunsafe-buffer-usage`
2. teach the analyzer to be quiet on some benign cases
>From 475d918fb0b5991be7ce559ef6ef7f20c6b231e5 Mon Sep
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f22dc88759a53d4224c17d3833a359ef5674b4ea
83314b0226f0585c3f689c8fdf556e45dbec207c --
@@ -0,0 +1,71 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-llvm-support
Author: cor3ntin (cor3ntin)
Changes
This update all of our Unicode tables to Unicode 15.1. This is a minor version
so only a relatively small numbers of characters are added, mainly ideographs
https://www.unicode
@@ -1161,9 +1185,11 @@ struct Proxy {
return lhs.data == rhs.data;
}
- friend constexpr auto operator<=>(const Proxy&, const Proxy&)
-requires (std::three_way_comparable && !std::is_reference_v)
- = default;
+ friend constexpr auto operator<=>(const Proxy& lhs, co
@@ -1172,6 +1198,22 @@ struct Proxy {
requires std::three_way_comparable_with, std::decay_t> {
return lhs.data <=> rhs.data;
}
+
+ // Needed to allow certain types to be weakly_incremental
+ constexpr Proxy& operator++()
+requires(HasPreIncrementOp)
+ {
+++
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,171 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,71 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -1149,9 +1171,11 @@ struct Proxy {
// Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues)
// Compare operators are defined for the convenience of the tests
- friend constexpr bool operator==(const Proxy&, const Proxy&)
-requires (std::equality_comparable && !
@@ -0,0 +1,71 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -1083,6 +1083,27 @@ rvalue_iterator(T*) -> rvalue_iterator;
static_assert(std::random_access_iterator>);
+// The ProxyDiffTBase allows us to conditionally specify
Proxy::difference_type
+// which we need in certain situations. For example when we want
+// std::weakly_incr
@@ -0,0 +1,171 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/cjdb requested changes to this pull request.
Thanks for working on this, it's an important algorithm to have. I've left some
comments, but would like to see this merged by the end of January.
https://github.com/llvm/llvm-project/pull/68494
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/76249
From 16b877e782951293a67a819441a3910f19bc24ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Fri, 22 Dec 2023 17:09:59 +0100
Subject: [PATCH 01/16] [clang-tidy] Add check
readability-ret
zahiraam wrote:
> Expanding the scope a bit, it would also be useful to have warnings for
> constant NaN or Inf values passed as arguments or used in binary operations.
Added that.
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits maili
@@ -13044,9 +13044,12 @@ static QualType checkArithmeticOrEnumeralCompare(Sema
&S, ExprResult &LHS,
if (Type->isAnyComplexType() && BinaryOperator::isRelationalOp(Opc))
return S.InvalidOperands(Loc, LHS, RHS);
- // Check for comparisons of floating point operands using
@@ -13846,6 +13880,37 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
@@ -13846,6 +13880,37 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
@@ -2267,6 +2273,16 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl,
unsigned BuiltinID,
case Builtin::BI__builtin_signbit:
case Builtin::BI__builtin_signbitf:
case Builtin::BI__builtin_signbitl:
+FPO = TheCall->getFPFeaturesInEffect(getLangOpts());
---
pizzud wrote:
Not sure how to squash properly; I tried rebasing but all the commits on the
main branch snuck in to the history and I'm quite new to git. If it would be
preferred I can store this off as a patch and open up a new PR. Sorry for all
the hassle with the merges!
https://github.com/
https://github.com/jonathonpenix closed
https://github.com/llvm/llvm-project/pull/77130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jonathon Penix
Date: 2024-01-05T13:55:50-08:00
New Revision: f1d75d08adb9841dd9cebad63b76d4823ec2bdac
URL:
https://github.com/llvm/llvm-project/commit/f1d75d08adb9841dd9cebad63b76d4823ec2bdac
DIFF:
https://github.com/llvm/llvm-project/commit/f1d75d08adb9841dd9cebad63b76d4823ec2bdac.diff
@@ -0,0 +1,157 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/76873
>From 7dbaf037b6b2196cee7c0c837e0a89ce3c2556ed Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 3 Jan 2024 14:37:17 -0800
Subject: [PATCH 1/2] [CLANG] Add warning when comparing to INF or NAN in fast
math
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 6d5d35e1273f595e8a0382053d5183cbce7a9d8a Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 1/6] [clang-tidy] Add bugprone-move-shared-pointer-contents
check.
1 - 100 of 451 matches
Mail list logo