@@ -367,3 +394,14 @@ clang::dataflow::FieldSet
clang::dataflow::getObjectFields(QualType Type) {
getFieldsFromClassHierarchy(Type, Fields);
return Fields;
}
+
+bool clang::dataflow::containsSameFields(
+const clang::dataflow::FieldSet &Fields,
+const clang::dataflo
https://github.com/KanRobert updated
https://github.com/llvm/llvm-project/pull/74199
>From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001
From: Shengchen Kan
Date: Sat, 2 Dec 2023 23:52:53 +0800
Subject: [PATCH 1/5] [X86] Support CFE flags for APX features
Positive options:
@@ -927,6 +939,16 @@ void X86TargetInfo::getTargetDefines(const LangOptions
&Opts,
Builder.defineMacro("__USERMSR__");
if (HasCRC32)
Builder.defineMacro("__CRC32__");
+ if (HasEGPR)
+Builder.defineMacro("__EGPR__");
+ if (HasPush2Pop2)
+Builder.defineMacro(
rikhuijzer wrote:
> Is it possible to add the test case (or minimal similar example) with
> `--inline` option so that we can confirm the original issue is resolved.
>
> #73383
Thanks for the review and fixing the typos that I've made! I've added a test in
a new `MemRef/inlining.mlir` file, wh
@@ -5999,6 +5999,12 @@ def mno_gather : Flag<["-"], "mno-gather">,
Group,
HelpText<"Disable generation of gather instructions in
auto-vectorization(x86 only)">;
def mno_scatter : Flag<["-"], "mno-scatter">, Group,
HelpText<"Disable generatio
https://github.com/rikhuijzer updated
https://github.com/llvm/llvm-project/pull/74200
>From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001
From: Rik Huijzer
Date: Mon, 20 Nov 2023 09:02:41 +0100
Subject: [PATCH 1/7] [mlir][tensor] Fix canon via `hasNegativeDimension`
---
ml
https://github.com/KanRobert updated
https://github.com/llvm/llvm-project/pull/74199
>From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001
From: Shengchen Kan
Date: Sat, 2 Dec 2023 23:52:53 +0800
Subject: [PATCH 1/4] [X86] Support CFE flags for APX features
Positive options:
@@ -422,3 +422,28 @@
// RUN: touch %t.o
// RUN: %clang -fdriver-only -Werror --target=x86_64-pc-linux-gnu
-mharden-sls=all %t.o -o /dev/null 2>&1 | count 0
+// RUN: %clang -target x86_64-unknown-linux-gnu -mapxf %s -### -o %t.o 2>&1 |
FileCheck -check-prefix=APXF %s
@@ -422,3 +422,28 @@
// RUN: touch %t.o
// RUN: %clang -fdriver-only -Werror --target=x86_64-pc-linux-gnu
-mharden-sls=all %t.o -o /dev/null 2>&1 | count 0
+// RUN: %clang -target x86_64-unknown-linux-gnu -mapxf %s -### -o %t.o 2>&1 |
FileCheck -check-prefix=APXF %s
+// RUN:
@@ -5999,6 +5999,12 @@ def mno_gather : Flag<["-"], "mno-gather">,
Group,
HelpText<"Disable generation of gather instructions in
auto-vectorization(x86 only)">;
def mno_scatter : Flag<["-"], "mno-scatter">, Group,
HelpText<"Disable generatio
https://github.com/KanRobert edited
https://github.com/llvm/llvm-project/pull/74199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -927,6 +939,16 @@ void X86TargetInfo::getTargetDefines(const LangOptions
&Opts,
Builder.defineMacro("__USERMSR__");
if (HasCRC32)
Builder.defineMacro("__CRC32__");
+ if (HasEGPR)
+Builder.defineMacro("__EGPR__");
+ if (HasPush2Pop2)
+Builder.defineMacro(
@@ -5999,6 +5999,12 @@ def mno_gather : Flag<["-"], "mno-gather">,
Group,
HelpText<"Disable generation of gather instructions in
auto-vectorization(x86 only)">;
def mno_scatter : Flag<["-"], "mno-scatter">, Group,
HelpText<"Disable generatio
@@ -298,3 +298,11 @@ multiclass ZAAddSub {
defm SVADD : ZAAddSub<"add">;
defm SVSUB : ZAAddSub<"sub">;
+
+//
+// Spill and fill of ZT0
+//
+let TargetGuard = "sme2" in {
+ def SVLDR_ZT : Inst<"svldr_zt", "viQ", "", MergeNone, "aarch64_sme_ldr_zt",
[IsOverloadNone, IsStreamin
https://github.com/rikhuijzer updated
https://github.com/llvm/llvm-project/pull/74200
>From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001
From: Rik Huijzer
Date: Mon, 20 Nov 2023 09:02:41 +0100
Subject: [PATCH 1/6] [mlir][tensor] Fix canon via `hasNegativeDimension`
---
ml
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/74235
>From 7323d9261fe8c876fe3a656a98e186af3dd0b2a0 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 3 Dec 2023 01:41:57 -0800
Subject: [PATCH 1/2] [clang-format] Remove duplicates in @property using
std::set
Re-im
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Brandon Wu (4vtomat)
Changes
The
spec(https://sifive.cdn.prismic.io/sifive/60d5a660-3af0-49a3-a904-d2bbb1a21517_int8-matmul-spec.pdf)
is updated.
---
Patch is 121.79 KiB, truncated to 20.00 KiB below, full version:
https://gi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Brandon Wu (4vtomat)
Changes
The
spec(https://sifive.cdn.prismic.io/sifive/60d5a660-3af0-49a3-a904-d2bbb1a21517_int8-matmul-spec.pdf)
is updated.
---
Patch is 121.79 KiB, truncated to 20.00 KiB below, full version:
https://github.com/
vikramRH wrote:
> Is there a separate PR open for "Add vector processing support to AMDGPU
> printf"? I think it's easiest to move this part forward first
@arsenm , you are right. I just want to make sure we are good on runtime
changes too now since there seems to be a blocker. The changes her
bcl5980 wrote:
> > We should add TTI check for the condition. I believe don't unroll on X86 is
> > a correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy
> > stack cost need this.
> > And I think you need to precommit tests first.
>
> In fact, there is no direct/strong rela
https://github.com/Lewuathe commented:
Is it possible to add the test case (or minimal similar example) with
`--inline` option so that we can confirm the original issue is resolved.
https://github.com/llvm/llvm-project/issues/73383
https://github.com/llvm/llvm-project/pull/74200
__
@@ -139,12 +139,36 @@ SmallVector
getValuesSortedByKey(ArrayRef keys, ArrayRef values,
llvm::function_ref compare);
+/// Helper function to check whether the passed in `sizes` or `values` are
+/// valid. This can be used to re-check whether dimensions are
https://github.com/Lewuathe edited
https://github.com/llvm/llvm-project/pull/74200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -139,12 +139,36 @@ SmallVector
getValuesSortedByKey(ArrayRef keys, ArrayRef values,
llvm::function_ref compare);
+/// Helper function to check whether the passed in `sizes` or `values` are
Lewuathe wrote:
```suggestion
/// Helper funct
https://github.com/KanRobert updated
https://github.com/llvm/llvm-project/pull/74199
>From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001
From: Shengchen Kan
Date: Sat, 2 Dec 2023 23:52:53 +0800
Subject: [PATCH 1/3] [X86] Support CFE flags for APX features
Positive options:
JOE1994 wrote:
I've been using `git clang-format` without the `--bin` flag using the following
setting
1. `PATH=$PATH:~/llvm-project/build/bin:~/llvm-project/clang/tools/clang-format`
2. Run `git clang-format HEAD~1` at `~/llvm-project` directory
After this revision, I get the following error:
xiangzh1 wrote:
> We should add TTI check for the condition. I believe don't unroll on X86 is a
> correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy
> stack cost need this.
>
> And I think you need to precommit tests first.
In fact, there is no direct/strong relation wit
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/74279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Wang Pengcheng (wangpc-pp)
Changes
We can reduce some code.
---
Full diff: https://github.com/llvm/llvm-project/pull/74280.diff
1 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Arch/RISCV.cpp (+2-7)
``diff
https://github.com/wangpc-pp created
https://github.com/llvm/llvm-project/pull/74280
We can reduce some code.
>From 1a9364a8b1e0eae320774253ac98a445daf7ec9f Mon Sep 17 00:00:00 2001
From: wangpc
Date: Mon, 4 Dec 2023 14:11:19 +0800
Subject: [PATCH] [RISCV][NFC] Use AddTargetFeature to add
fa
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Youngsuk Kim (JOE1994)
Changes
Merge consecutive AddrSpaceCasts into a single AddrSpaceCast.
---
Full diff: https://github.com/llvm/llvm-project/pull/74279.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGOpenMPRuntimeGPU
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Youngsuk Kim (JOE1994)
Changes
Merge consecutive AddrSpaceCasts into a single AddrSpaceCast.
---
Full diff: https://github.com/llvm/llvm-project/pull/74279.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp (+2
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/74279
Merge consecutive AddrSpaceCasts into a single AddrSpaceCast.
>From 4e86272d980b26bf1240df94cbc894e7ded0d018 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Sun, 3 Dec 2023 23:52:33 -0600
Subject: [PATCH] [cla
https://github.com/cor3ntin approved this pull request.
LGTM.
Please give some time for clang-format folks to review the change as it is not
my area of expertise.
https://github.com/llvm/llvm-project/pull/74230
___
cfe-commits mailing list
cfe-commit
cor3ntin wrote:
Thanks for your first contribution. Maybe the first of many :D
https://github.com/llvm/llvm-project/pull/69061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/69061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: wheatman
Date: 2023-12-04T06:49:37+01:00
New Revision: 0031efe6be19735402656a76b64a173d17f1f935
URL:
https://github.com/llvm/llvm-project/commit/0031efe6be19735402656a76b64a173d17f1f935
DIFF:
https://github.com/llvm/llvm-project/commit/0031efe6be19735402656a76b64a173d17f1f935.diff
LOG:
ChuanqiXu9 wrote:
@sam-mccall ping
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ssahasra updated
https://github.com/llvm/llvm-project/pull/73906
>From 8ecb6310a4912de50628cf3db5ff8488fa919bb1 Mon Sep 17 00:00:00 2001
From: Sameer Sahasrabuddhe
Date: Fri, 1 Dec 2023 14:24:30 +0530
Subject: [PATCH 1/2] [clang][AMDGPU] precommit test for ballot on Windows
https://github.com/ssahasra closed
https://github.com/llvm/llvm-project/pull/73920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sameer Sahasrabuddhe
Date: 2023-12-04T10:43:16+05:30
New Revision: 0f8681b38e51e8a68894042e638eba681f7737f1
URL:
https://github.com/llvm/llvm-project/commit/0f8681b38e51e8a68894042e638eba681f7737f1
DIFF:
https://github.com/llvm/llvm-project/commit/0f8681b38e51e8a68894042e638eba681f7737f
@@ -180,13 +180,10 @@ void emitCodeGenSwitchBody(const RVVIntrinsic *RVVI,
raw_ostream &OS) {
return;
}
- // Cast pointer operand of vector load intrinsic.
for (const auto &I : enumerate(RVVI->getInputTypes())) {
wangpc-pp wrote:
Why not remove thi
bcl5980 wrote:
We should add TTI check for the condition. I believe don't unroll on X86 is a
correct decision.
Only like AMDGPU or NVPTX these GPU target with heavy stack cost backend target
need this.
https://github.com/llvm/llvm-project/pull/74268
hstk30-hw wrote:
I guess the `i8` is from
https://github.com/ARM-software/abi-aa/blob/2a70c42d62e9c3eb5887fa50b71257f20daca6f9/cppabi64/cppabi64.rst#41summary-of-differences-from-and-additions-to-the-generic-c-abi
> The GC++ABI defines the way in which empty class types are laid out. For the
>
Author: Utkarsh Saxena
Date: 2023-12-04T04:11:05+01:00
New Revision: 239bcba65099558e2ec4f57d14ef6ce46b1ae74e
URL:
https://github.com/llvm/llvm-project/commit/239bcba65099558e2ec4f57d14ef6ce46b1ae74e
DIFF:
https://github.com/llvm/llvm-project/commit/239bcba65099558e2ec4f57d14ef6ce46b1ae74e.diff
https://github.com/KanRobert updated
https://github.com/llvm/llvm-project/pull/74199
>From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001
From: Shengchen Kan
Date: Sat, 2 Dec 2023 23:52:53 +0800
Subject: [PATCH 1/2] [X86] Support CFE flags for APX features
Positive options:
xiangzh1 wrote:
Seems the check fail "dr2xx.cpp Line 1297: conversion from 'T' to 'unsigned
long long' is ambiguous" has no relation with this change.
https://github.com/llvm/llvm-project/pull/74268
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/73860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
Overall, I love it! I have some comments on some features in the future, but
those are probably not going to be addressed any time soon. First of all, I
think in the future when we reason about the values of the pointers, synthetic
field
@@ -367,3 +394,14 @@ clang::dataflow::FieldSet
clang::dataflow::getObjectFields(QualType Type) {
getFieldsFromClassHierarchy(Type, Fields);
return Fields;
}
+
+bool clang::dataflow::containsSameFields(
+const clang::dataflow::FieldSet &Fields,
+const clang::dataflo
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/73860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik wrote:
Please make sure before you commit that you update the description with more
details. This is what will show up in the git log and we want to make sure that
is detailed enough to allow folks to debug build issues etc without having to
examine each commit in detail.
https://githu
shafik wrote:
> Thanks for this PR! Emitting a diag in `TransformTemplateParmRefExpr` would
> probably a better way to go about it. It's not clear to me that the assert`
> is an improvement , and adding a diag would not be a lot more work. Would
> that be something you would be willing to expl
shafik wrote:
> > Can you add a release note?
>
> Do you think this small diagnostic wording change is worth noting in relnotes?
Yes, we have a `Improvments to clang diagnostics` section.
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commi
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidTruby closed
https://github.com/llvm/llvm-project/pull/73250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Truby
Date: 2023-12-04T02:20:03Z
New Revision: dff5bb92d47ef226319ba1b70a334785d7896de8
URL:
https://github.com/llvm/llvm-project/commit/dff5bb92d47ef226319ba1b70a334785d7896de8
DIFF:
https://github.com/llvm/llvm-project/commit/dff5bb92d47ef226319ba1b70a334785d7896de8.diff
LOG: [
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (xiangzh1)
Changes
Loop header with constant usually can be optimized in unroll, folding branch in
such loop header at SimplifyCFG will break unroll optimization.
for example:
Escape folding "I < ConstNum" with "Cond2" due to loops o
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: None (xiangzh1)
Changes
Loop header with constant usually can be optimized in unroll, folding branch in
such loop header at SimplifyCFG will break unroll optimization.
for example:
Escape folding "I < ConstNum" with "Cond2" due
https://github.com/xiangzh1 created
https://github.com/llvm/llvm-project/pull/74268
Loop header with constant usually can be optimized in unroll, folding branch in
such loop header at SimplifyCFG will break unroll optimization.
for example:
Escape folding "I < ConstNum" with "Cond2" due to loo
https://github.com/antangelo updated
https://github.com/llvm/llvm-project/pull/74265
>From a8e841657b9816a78f6eb1520c8513454fe0008b Mon Sep 17 00:00:00 2001
From: Antonio Abbatangelo
Date: Tue, 28 Nov 2023 21:19:13 -0500
Subject: [PATCH 1/2] [clang] Exclude non-template classes when checking if
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (antangelo)
Changes
When checking if the constraint uses any enclosing template parameters for
[temp.friend]p9, if a containing record is used as argument, we assume that the
constraint depends on enclosing template parameters withou
https://github.com/antangelo created
https://github.com/llvm/llvm-project/pull/74265
When checking if the constraint uses any enclosing template parameters for
[temp.friend]p9, if a containing record is used as argument, we assume that the
constraint depends on enclosing template parameters wi
aaronpuchert wrote:
In the end it probably boils down to how you view an enumeration type. Is it a
type with the declared enumerators as inhabitants, or is it an integer type of
some length with associated symbolic constants of that type? In other words, is
an enumeration a "strong" type or a
aaronpuchert wrote:
> There is one clang-tidy check (bugprone-switch-missing-default-case) also for
> this feature.
This excludes enumeration types though, while GCC `-Wswitch-default` warns on
them as well. (Even if all enumeration values are covered.)
> whether switch statements should have
@@ -1718,6 +1720,13 @@ struct TestScopedLockable {
MutexLock{&mu1}, a = 5;
}
+ void temporary2(int x) {
+if (check(MutexLock{&mu1}) || x) {
+
+}
aaronpuchert wrote:
The `if` is probably not needed here, right? We could just write
```suggestion
@@ -2392,6 +2397,8 @@ void
ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContext &AC) {
for (const auto &Lock : LocksReleased)
ExpectedFunctionExitSet.removeLock(FactMan, Lock);
+ ConstructedObjectMapTy ConstructedObjects;
aaronpuchert wrote:
I wonder
https://github.com/aaronpuchert commented:
I have some suggestions, but in principle this is absolutely right. Thanks for
finding this and providing a fix!
> The issue is that the map lives within a CFG block.
It didn't cross my mind to check how long `BuildLockset` lived, I always
assumed i
@@ -1718,6 +1720,13 @@ struct TestScopedLockable {
MutexLock{&mu1}, a = 5;
}
+ void temporary2(int x) {
aaronpuchert wrote:
I would suggest a speaking name for the test, like `temporary_cfg`.
https://github.com/llvm/llvm-project/pull/74020
___
@@ -1718,6 +1720,13 @@ struct TestScopedLockable {
MutexLock{&mu1}, a = 5;
}
+ void temporary2(int x) {
+if (check(MutexLock{&mu1}) || x) {
+
+}
+check(MutexLock{&mu1});
aaronpuchert wrote:
The `check` here doesn't do anything, right?
http
https://github.com/aaronpuchert edited
https://github.com/llvm/llvm-project/pull/74020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1544,7 +1544,10 @@ class BuildLockset : public
ConstStmtVisitor {
// The fact set for the function on exit.
const FactSet &FunctionExitFSet;
/// Maps constructed objects to `this` placeholder prior to initialization.
- llvm::SmallDenseMap ConstructedObjects;
+ ///
https://github.com/jaredgrubb edited
https://github.com/llvm/llvm-project/pull/74235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -171,18 +171,18 @@ TEST_F(ObjCPropertyAttributeOrderFixerTest,
HandlesDuplicatedAttributes) {
Style.ObjCPropertyAttributeOrder = {"a", "b", "c"};
// Just a dup and nothing else.
- verifyFormat("@property(a, a) int p;", Style);
+ verifyFormat("@property(a) int p;", "@
https://github.com/jaredgrubb approved this pull request.
Looks good to me!
https://github.com/llvm/llvm-project/pull/74235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-xl closed
https://github.com/llvm/llvm-project/pull/73845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Li
Date: 2023-12-03T14:10:57-08:00
New Revision: 7882f380a234a8c0260b79290406967c851a0df2
URL:
https://github.com/llvm/llvm-project/commit/7882f380a234a8c0260b79290406967c851a0df2
DIFF:
https://github.com/llvm/llvm-project/commit/7882f380a234a8c0260b79290406967c851a0df2.diff
LOG:
https://github.com/lhames approved this pull request.
LGTM too. Thanks @allight!
https://github.com/llvm/llvm-project/pull/73717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -153,7 +157,10 @@ def main():
else:
if len(commits) > 2:
die('at most two commits allowed; %d given' % len(commits))
- changed_lines = compute_diff_and_extract_lines(commits, files, opts.staged)
+ changed_lines = compute_diff_and_extract_lines(commits,
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/74230
>From ae4097b53b90e31802be0be5c8a81fb74c81efc9 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Sat, 2 Dec 2023 23:46:58 -0800
Subject: [PATCH 1/2] [clang-format] Add "three dot" diff option to
git-cla
@@ -128,169 +128,169 @@ void foo(){
const auto Actually2 = 2;
bar::sqrt(Actually2);
-// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: prefer std::numbers math
constant [modernize-use-std-numbers]
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: prefer 'std::numbers::sq
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/74230
>From ae4097b53b90e31802be0be5c8a81fb74c81efc9 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Sat, 2 Dec 2023 23:46:58 -0800
Subject: [PATCH] [clang-format] Add "three dot" diff option to
git-clang-f
5chmidti wrote:
It looks like GitHub decided to not list all new commits in the conversation
view... there are a few more in the commits tab.
The newly pushed changes start at commit [refactor from using transformer to a
normal
check](https://github.com/llvm/llvm-project/pull/66583/commits/b1a
tblah wrote:
@banach-space once this is in, I'll remove `-f[no-]alias-analysis` in a
separate patch, as it didn't turn out to be as useful for debugging as I
expected (the `-mllvm` option is more specific), and as you mentioned - these
arguments are non-standard.
https://github.com/llvm/llvm-
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Tom Eccles (tblah)
Changes
Enable by default for optimization levels higher than 0 (same behavior as
clang).
For simplicity, only forward the flag to the frontend driver when it
contradicts what is implied by the optimization leve
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Tom Eccles (tblah)
Changes
Enable by default for optimization levels higher than 0 (same behavior as
clang).
For simplicity, only forward the flag to the frontend driver when it
contradicts what is implied by the optimization level.
Thi
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/74250
Enable by default for optimization levels higher than 0 (same behavior as
clang).
For simplicity, only forward the flag to the frontend driver when it
contradicts what is implied by the optimization level.
This w
https://github.com/mjklemm edited
https://github.com/llvm/llvm-project/pull/74139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtcxzyw wrote:
Could you please rebase this patch on
https://github.com/llvm/llvm-project/pull/74246 and add a test for
https://github.com/llvm/llvm-project/issues/74242?
https://github.com/llvm/llvm-project/pull/73662
___
cfe-commits mailing list
c
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From ff1b0d96e7beef51a082d59548c49b9c02d79eb0 Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
@@ -5992,6 +5992,15 @@ static ExprResult BuildConvertedConstantExpression(Sema
&S, Expr *From,
/*InOverloadResolution=*/false,
/*AllowObjCWritebackConversion=*/false,
/*AllowE
bolshakov-a wrote:
> Can you add a release note?
Do you think this small diagnostic wording change is worth noting in relnotes?
> Do we need more tests in other contexts where a converted constant expression
> is used?
Seems like constant expressions converted to references may currently only
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9f78edbd20ed922cced9482f7791deb9899a6d82
bc2ea1ab74b613f700b11390a4715a0f2bec10e7 --
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From bc2ea1ab74b613f700b11390a4715a0f2bec10e7 Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
ronlieb wrote:
original perf regressions seem recovered enough, thx.
appreciate the info message being added for future triage...
https://github.com/llvm/llvm-project/pull/70401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/74243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-12-03T18:35:49+04:00
New Revision: bc51a36fd67c9ef08259612a1a04db6be51a8b76
URL:
https://github.com/llvm/llvm-project/commit/bc51a36fd67c9ef08259612a1a04db6be51a8b76
DIFF:
https://github.com/llvm/llvm-project/commit/bc51a36fd67c9ef08259612a1a04db6be51a8b76.
wheatman wrote:
@cor3ntin done, thanks for taking a look
https://github.com/llvm/llvm-project/pull/69061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch continues the work started with
ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding
PR for details.
---
Patch is 76.50 KiB, truncated to 20.00 KiB below, full v
Endilll wrote:
This PR is created only for CI purposes.
https://github.com/llvm/llvm-project/pull/74243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 129 matches
Mail list logo
