[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-11-07 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:444 +OpenMPClauseKind CK = static_cast(Type); +switch (CK) { +case OMPC_unknown: Hi @koops , clang complains on this patch with ``` ../../clang/lib/Basic/OpenMPKinds.cpp:444:13

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread Iain Sandoe via cfe-commits
iains wrote: perhaps in the context we can use "sparse" instead of "thin" - but I do not have a good short word replace 'fat'. https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread Timm Baeder via cfe-commits
@@ -270,6 +274,35 @@ namespace clang { }; } +bool clang::MayDefAffectABI(const Decl *D) { + if (auto *FD = dyn_cast(D)) { tbaederr wrote: ```suggestion if (const auto *FD = dyn_cast(D)) { ``` https://github.com/llvm/llvm-project/pull/71622 _

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread Timm Baeder via cfe-commits
@@ -270,6 +274,35 @@ namespace clang { }; } +bool clang::MayDefAffectABI(const Decl *D) { + if (auto *FD = dyn_cast(D)) { +if (FD->isInlined() || FD->isConstexpr()) + return true; + +// Non-user-provided functions get emitted as weak definitions with every +

[flang] [clang] [mlir] [llvm] [lld] [ELF] Merge exportDynamic into versionId (PR #71272)

2023-11-07 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson approved this pull request. https://github.com/llvm/llvm-project/pull/71272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [clang] [llvm] [lld] [ELF] Merge exportDynamic into versionId (PR #71272)

2023-11-07 Thread Alexander Richardson via cfe-commits
@@ -2518,9 +2521,9 @@ static void combineVersionedSymbol(Symbol &sym, sym.symbolKind = Symbol::PlaceholderKind; sym.isUsedInRegularObj = false; } else if (auto *sym1 = dyn_cast(&sym)) { -if (sym2->versionId > VER_NDX_GLOBAL -? config->versionDefinition

[mlir] [clang] [llvm] [flang] [lld] [ELF] Merge exportDynamic into versionId (PR #71272)

2023-11-07 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/71272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

2023-11-07 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2509 // Attempt to parse token as a register. - if (parseRegister(Operands, true).isSuccess()) + if (parseRegister(Operands, true).isSuccess()) { +// Parse memory base regi

[clang] [llvm] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread Paulo Matos via cfe-commits
pmatos wrote: > Very cool! LGTM so far. It's really nice that we can delete that entire pass > out of the backend. Where can I read more about these new target extension > types? There's not a lot but there's something here: https://llvm.org/docs/LangRef.html#target-extension-type and of cour

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71518 >From b12b8ef5b9cc65cabf14eeeb3dacd6f41e5bf54e Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 16:44:05 +0800 Subject: [PATCH] [clang][analyzer] Support `fputc` in StreamChecker --- .../StaticAna

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread Wei Wang via cfe-commits
@@ -0,0 +1,59 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -O3 -emit-llvm %s -o - | FileCheck %s --check-pre

[PATCH] D154396: [clang] Add support for SerenityOS

2023-11-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.h:61 + bool isPICDefault() const override { return true; } + bool isPIEDefault(const llvm::opt::ArgList &) const override { return true; } + bool isPICDefaultForced() const override { return false;

[PATCH] D154396: [clang] Add support for SerenityOS

2023-11-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/serenity.cpp:20 +// SERENITY_X86_64: "{{(.*[^-.0-9A-Z_a-z])?}}ld.lld" +// SERENITY_X86_64: "-pie" +// SERENITY_X86_64: "-dynamic-linker" "/usr/lib/Loader.so" "--eh-frame-hdr" Prefer `-SAME:` whenever ap

[clang] [clang][Interp] Fix stack peek offset for This ptr (PR #70663)

2023-11-07 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/70663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-11-07 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang-tools-extra] [clang] [llvm] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-07 Thread Erich Keane via cfe-commits
erichkeane wrote: > @AaronBallman, @erichkeane I have addressed comments in the PR, could you > please revisit this PR? Thank you! I'm still away at the WG21 meeting, but I've got this on my list of things to review when I return. https://github.com/llvm/llvm-project/pull/70762 __

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-11-07 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] c79b544 - [SEH] Fix assertin when return scalar value from __try block. (#71488)

2023-11-07 Thread via cfe-commits
Author: jyu2-git Date: 2023-11-07T20:43:40-08:00 New Revision: c79b544d2b988e26f35db829088e0e5088c57498 URL: https://github.com/llvm/llvm-project/commit/c79b544d2b988e26f35db829088e0e5088c57498 DIFF: https://github.com/llvm/llvm-project/commit/c79b544d2b988e26f35db829088e0e5088c57498.diff LOG:

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread via cfe-commits
https://github.com/jyu2-git closed https://github.com/llvm/llvm-project/pull/71488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2023-11-07 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/69133 >From 1ca9ce9ef3e90e3d24aea3945ae2d5129682621d Mon Sep 17 00:00:00 2001 From: Amir Aupov Date: Mon, 16 Oct 2023 01:08:28 +0200 Subject: [PATCH 1/3] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT opti

[clang] [clang][dataflow] Expand debug dumping of `Value`s. (PR #71527)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/71527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 64ed4ed - [clang][dataflow] Expand debug dumping of `Value`s. (#71527)

2023-11-07 Thread via cfe-commits
Author: martinboehme Date: 2023-11-08T05:41:26+01:00 New Revision: 64ed4edca8e76e2ce2586584fdcb3b906532aa18 URL: https://github.com/llvm/llvm-project/commit/64ed4edca8e76e2ce2586584fdcb3b906532aa18 DIFF: https://github.com/llvm/llvm-project/commit/64ed4edca8e76e2ce2586584fdcb3b906532aa18.diff

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

2023-11-07 Thread Brandon Wu via cfe-commits
@@ -106,6 +106,8 @@ static const RISCVSupportedExtension SupportedExtensions[] = { {"zdinx", RISCVExtensionVersion{1, 0}}, +{"zexperimental", RISCVExtensionVersion{1, 0}}, + 4vtomat wrote: No, we don't~ https://github.com/llvm/llvm-project/pull/690

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

2023-11-07 Thread Brandon Wu via cfe-commits
4vtomat wrote: > > Since it's possible that **ISA spec** and **intrinsics spec** are not > > synchronized, so the updates add an dummy extension called > > **zexperimental**, once `-menable-experimental-extensions` is specified, > > the feature `zexperimental` is automatically added. > > If `l

[clang] [clang][dataflow] Replace one remaining call to deprecated `addToFlowCondition()`. (PR #71547)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/71547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a070053 - [clang][dataflow] Replace one remaining call to deprecated `addToFlowCondition()`. (#71547)

2023-11-07 Thread via cfe-commits
Author: martinboehme Date: 2023-11-08T05:32:04+01:00 New Revision: a0700532ddcc850ff381e08576590ee26fad1f1e URL: https://github.com/llvm/llvm-project/commit/a0700532ddcc850ff381e08576590ee26fad1f1e DIFF: https://github.com/llvm/llvm-project/commit/a0700532ddcc850ff381e08576590ee26fad1f1e.diff

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2023-11-07 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/69133 >From 96e644279ccec1970c42cca89c05aac186b872e6 Mon Sep 17 00:00:00 2001 From: Amir Aupov Date: Mon, 16 Oct 2023 01:08:28 +0200 Subject: [PATCH 1/3] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT opti

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/71618 This contains https://github.com/llvm/llvm-project/pull/71622 and so that it is not easy to review this until we have stacked reviews. So the main pur

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/71618 This contains https://github.com/llvm/llvm-project/pull/71622 and so that it is not easy to review this until we have stacked reviews. So the m

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

2023-11-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 converted_to_draft https://github.com/llvm/llvm-project/pull/71627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-11-07 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D144006#4656383 , @dzhidzhoev wrote: > In D144006#4656371 , @aeubanks > wrote: > >> Is there any issue with mixing IR built with >> `LLVMContext::enableDebugTypeODRUniquing()` and w

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,137 @@ +; RUN: opt < %s -passes='cgscc(coro-split),early-cse,dce,simplifycfg' -S | FileCheck %s + +%"struct.std::__n4861::noop_coroutine_promise" = type { i8 } +%struct.Promise = type { %"struct.std::__n4861::coroutine_handle" } +%"struct.std::__n4861::coroutine_handle

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
h-vetinari wrote: filename still has `-done` not `-complete` https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -718,6 +718,7 @@ enum AttributeKindCodes { ATTR_KIND_NOFPCLASS = 87, ATTR_KIND_OPTIMIZE_FOR_DEBUGGING = 88, ATTR_KIND_WRITABLE = 89, + ATTR_KIND_CORO_ONLY_DESTROY_WHEN_DONE = 90, h-vetinari wrote: still `_DONE` not `_COMPLETE` (plus all later usages

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -318,6 +318,9 @@ def MustProgress : EnumAttr<"mustprogress", [FnAttr]>; /// Function is a presplit coroutine. def PresplitCoroutine : EnumAttr<"presplitcoroutine", [FnAttr]>; +/// The coroutine would only be destroyed when it is done. +def CoroDestroyOnlyWhenComplete : Enum

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
https://github.com/h-vetinari edited https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,59 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -O3 -emit-llvm %s -o - | FileCheck %s --check-pre

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
https://github.com/h-vetinari commented: > > Presumably there should only be one spelling everywhere. > > Done Missed a few. ;-) https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -1775,6 +1775,17 @@ CoroCleanup This pass runs late to lower all coroutine related intrinsics not replaced by earlier passes. +Attributes +== + +coro_only_destroy_when_done +--- + +When the coroutine are marked with coro_only_destroy_when_don

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/71488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid copying Param and Constr (PR #65488)

2023-11-07 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/65488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread Jan Svoboda via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: rm -rf %t jansvoboda11 wrote: Could you add a short summary of what this test is for? https://github.com/llvm/llvm-project/pull/71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread Jan Svoboda via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/build/compile-commands.json.in > %t/build/compile-commands.json +// RUN: clang-scan-deps -compilation-database %t/build/compile-commands.json \ +// RUN: -j 1 -format experimental-full

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread Jan Svoboda via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/build/compile-commands.json.in > %t/build/compile-commands.json +// RUN: clang-scan-deps -compilation-database %t/build/compile-commands.json \ +// RUN: -j 1 -format experimental-full

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

2023-11-07 Thread Matt Arsenault via cfe-commits
@@ -17632,8 +17632,27 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, case AMDGPU::BI__builtin_amdgcn_mov_dpp: case AMDGPU::BI__builtin_amdgcn_update_dpp: { llvm::SmallVector Args; -for (unsigned I = 0; I != E->getNumArgs(); ++I) - Args.pu

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

2023-11-07 Thread Matt Arsenault via cfe-commits
@@ -17632,8 +17632,20 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, case AMDGPU::BI__builtin_amdgcn_mov_dpp: case AMDGPU::BI__builtin_amdgcn_update_dpp: { llvm::SmallVector Args; -for (unsigned I = 0; I != E->getNumArgs(); ++I) - Args.pu

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread Jan Svoboda via cfe-commits
@@ -52,6 +52,28 @@ static void optimizeHeaderSearchOpts(HeaderSearchOptions &Opts, Opts.UserEntries.push_back(Entries[Idx]); } +static void optimizeDiagnosticOpts(DiagnosticOptions &Opts, + bool IsSystemModule) { + // If this is not a sy

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > It was suggested to avoid "thin" and "fat" terminology (I started using it > with LTO as a precedent for the terms), but I suppose something more > descriptive could be selected. Any suggestions? My english is not good, you know. > I'll also note that my prior usage was in

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-11-07 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/68846 >From 40dca93d3e1f339f3e756e54687ea5506b3d6f2e Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 17 Oct 2023 10:41:18 +0800 Subject: [PATCH] [Docs][Clang] DR status in cxx_status.html --- clang/www/c

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread Ben Boeckel via cfe-commits
mathstuf wrote: I'll also note that my prior usage was in reference to embedding transitive BMI references in the BMI, not about including function definitions. https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@l

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread Ben Boeckel via cfe-commits
mathstuf wrote: It was suggested to avoid "thin" and "fat" terminology (I started using it with LTO as a precedent for the terms), but I suppose something more descriptive could be selected. https://github.com/llvm/llvm-project/pull/71622 ___ cfe-com

[clang] [llvm] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-07 Thread via cfe-commits
smanna12 wrote: @AaronBallman, @erichkeane I addressed comments in the PR, could you please revisit this PR? Thank you! https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71518 >From 3a51a9067e2581e1cb7091e24725439a991fdc78 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 16:44:05 +0800 Subject: [PATCH] [clang][analyzer] Support `fputc` in StreamChecker --- .../StaticAna

[clang] [OpenMP] Add a missing 'const' (NFC) (PR #71596)

2023-11-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/71596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 182b7e6 - [OpenMP] Add a missing 'const' (NFC) (#71596)

2023-11-07 Thread via cfe-commits
Author: Mike Rice Date: 2023-11-07T18:42:23-08:00 New Revision: 182b7e6ba75055a84544943a06df9964d3a08d81 URL: https://github.com/llvm/llvm-project/commit/182b7e6ba75055a84544943a06df9964d3a08d81 DIFF: https://github.com/llvm/llvm-project/commit/182b7e6ba75055a84544943a06df9964d3a08d81.diff LOG

[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

2023-11-07 Thread Kito Cheng via cfe-commits
@@ -106,6 +106,8 @@ static const RISCVSupportedExtension SupportedExtensions[] = { {"zdinx", RISCVExtensionVersion{1, 0}}, +{"zexperimental", RISCVExtensionVersion{1, 0}}, + kito-cheng wrote: I guess we don't really need this dummy extension in RISC

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b85fdc4ffde48f2035e4621d4f9af69bf16f2136 839d38d96d2275dbc0a9aa9fae3427720a6d3344 --

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/71034 This patch introduces thin BMI, which doesn't contain the definitions of functions and variables if its definitions won't contribute to the AB

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-07 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thanks! Please go ahead and merge it. :-) https://github.com/llvm/llvm-project/pull/71415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71518 >From eb4da0df114586c4099a495e5114ab0c1c9f9e27 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 16:44:05 +0800 Subject: [PATCH] [clang][analyzer] Support `fputc` in StreamChecker --- .../StaticAna

[clang] [Clang][OpenMP] Return empty QualType when a negative array was created (PR #71552)

2023-11-07 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/71552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP]Return empty QualType when a negative array was created. (PR #71552)

2023-11-07 Thread via cfe-commits
https://github.com/lwshanbd edited https://github.com/llvm/llvm-project/pull/71552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 reopened https://github.com/llvm/llvm-project/pull/71518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @bcardosolopes @apolloww @rjmccall would you like to take a look for the middle end part? https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > There is substantial inconsistency between "coro only destroy when complete" > and "... when done" throughout the PR (in various forms; e.g. literal > strings, snake_case, CamelCase, ALL_CAPS as well as file names). > > Presumably there should only be one spelling everywher

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/71014 >From c69205d54e1a4858211b5bbce69e10bba7063359 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 2 Nov 2023 11:11:59 +0800 Subject: [PATCH] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]]

[PATCH] D154402: [compiler-rt] Enable profile instrumentation for SerenityOS

2023-11-07 Thread Andrew Kaster via Phabricator via cfe-commits
ADKaster updated this revision to Diff 558045. ADKaster added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154402/new/ https://reviews.llvm.org/D154402 Files: clang/lib/Driver/ToolChains/Serenity.cpp clang/test/Driver/instrp

[PATCH] D154396: [clang] Add support for SerenityOS

2023-11-07 Thread Andrew Kaster via Phabricator via cfe-commits
ADKaster updated this revision to Diff 558043. ADKaster added a comment. test LTO with option fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Tar

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

2023-11-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Sorry for being too hurry here. https://github.com/llvm/llvm-project/pull/71031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/71488 >From 3313aca0622da3882a9e5bf304b89f28fecce7fe Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Mon, 6 Nov 2023 20:51:39 -0800 Subject: [PATCH 1/2] [SEH] Fix assertin when return scalar value from __try block.

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Spencer (Bigcheese) Changes Since system modules don't emit most warnings, remove the warning flags to increase module reuse. --- Full diff: https://github.com/llvm/llvm-project/pull/71612.diff 4 Files Affected: - (modified) c

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/71612 Since system modules don't emit most warnings, remove the warning flags to increase module reuse. >From 6c8c4cde5698a1693ad64a14a156030f249032a6 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Tue, 7 Nov

[clang] [llvm] [clang][DepScan] Make OptimizeArgs a bit mask enum and enable by default (PR #71588)

2023-11-07 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/71588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb07d9c - [clang][DepScan] Make OptimizeArgs a bit mask enum and enable by default (#71588)

2023-11-07 Thread via cfe-commits
Author: Michael Spencer Date: 2023-11-07T16:06:59-08:00 New Revision: fb07d9cc096f4a0c2473dee064c427edc2a83157 URL: https://github.com/llvm/llvm-project/commit/fb07d9cc096f4a0c2473dee064c427edc2a83157 DIFF: https://github.com/llvm/llvm-project/commit/fb07d9cc096f4a0c2473dee064c427edc2a83157.dif

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-11-07 Thread David Pagan via Phabricator via cfe-commits
ddpagan added a comment. Is there a github PR associated with this? If yes, what is the PR? If not, one should be created that includes a fix for the teams loop/loop error issue. Please add me as a reviewer. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: dupes (tdupes) Changes call hierarchy cannot be enhanced via the remote index because the Refs returned by the remote index do not have the ID of its container. --- Full diff: https://github.com/llvm/llvm-project/pull/71605.diff 2 Fil

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-11-07 Thread via cfe-commits
https://github.com/tdupes created https://github.com/llvm/llvm-project/pull/71605 call hierarchy cannot be enhanced via the remote index because the Refs returned by the remote index do not have the ID of its container. >From 4b8ab9e39c974b4cfa6573eb0589116cac3101e5 Mon Sep 17 00:00:00 2001 F

[llvm] [clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading (PR #68986)

2023-11-07 Thread Vladislav Dzhidzhoev via cfe-commits
dzhidzhoev wrote: Reverted due to Chromium build crash https://bugs.chromium.org/p/chromium/issues/detail?id=1500022. https://github.com/llvm/llvm-project/pull/68986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] 6beddd6 - Revert "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)"

2023-11-07 Thread Vladislav Dzhidzhoev via cfe-commits
Author: Vladislav Dzhidzhoev Date: 2023-11-08T00:29:24+01:00 New Revision: 6beddd668adf8e6bddbbc58ec02e4728dd889e9e URL: https://github.com/llvm/llvm-project/commit/6beddd668adf8e6bddbbc58ec02e4728dd889e9e DIFF: https://github.com/llvm/llvm-project/commit/6beddd668adf8e6bddbbc58ec02e4728dd889e9

[clang] Add ability for clang-format-diff to exit with non-0 status (PR #70883)

2023-11-07 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. Let go without the option for now https://github.com/llvm/llvm-project/pull/70883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-11-07 Thread Vladislav Dzhidzhoev via Phabricator via cfe-commits
dzhidzhoev added a comment. In D144006#4656371 , @aeubanks wrote: > Is there any issue with mixing IR built with > `LLVMContext::enableDebugTypeODRUniquing()` and without? I'm suspecting that > ThinLTO is mixing Rust and Clang IR which set that differen

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-11-07 Thread Chi Chun Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG086b65340cca: [OpenMP] atomic compare fail : Parser & AST support (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo CH

[clang] 086b653 - [OpenMP] atomic compare fail : Parser & AST support

2023-11-07 Thread Chi Chun Chen via cfe-commits
Author: Sunil Kuravinakop Date: 2023-11-07T16:57:50-06:00 New Revision: 086b65340cca2648a2a91a0a47d28c7d9bafd1e5 URL: https://github.com/llvm/llvm-project/commit/086b65340cca2648a2a91a0a47d28c7d9bafd1e5 DIFF: https://github.com/llvm/llvm-project/commit/086b65340cca2648a2a91a0a47d28c7d9bafd1e5.d

[clang] [OpenMP] Add a missing 'const' (NFC) (PR #71596)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mike Rice (mikerice1969) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71596.diff 1 Files Affected: - (modified) clang/include/clang/AST/StmtOpenMP.h (+1-1) ``diff diff --git a/clang/include/clang/AST/Stmt

[clang] [OpenMP] Add a missing 'const' (NFC) (PR #71596)

2023-11-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/71596 None >From 41f147c79a0a32fa541e7fb99cb2053b8f4b7ea2 Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Tue, 7 Nov 2023 14:51:55 -0800 Subject: [PATCH] [OpenMP] Add a missing 'const' (NFC) --- clang/include/cl

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-11-07 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. F30438826: i.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list cfe-

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: Makes sense, small nit https://github.com/llvm/llvm-project/pull/71488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread Reid Kleckner via cfe-commits
@@ -3507,6 +3507,9 @@ static llvm::StoreInst *findDominatingStoreToReturnValue(CodeGenFunction &CGF) { return nullptr; // These aren't actually possible for non-coerced returns, and we // only care about non-coerced returns on this code path. +// All memory i

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/71488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland closed https://github.com/llvm/llvm-project/pull/71518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/70877 >From 18369263a3160963b943cd8574edaa212b6d0996 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Tue, 31 Oct 2023 16:45:17 -0700 Subject: [PATCH 1/2] Fix attribute plugins --- clang/lib/Sema/ParsedAttr.cpp | 15

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
amykhuang wrote: Updated the PR description and the patch. The existing `clang/test/Frontend/plugin-attribute.cpp` seems sufficient for test coverage. (I guess it wasn't being tested on bots though, otherwise we would have seen it?) https://github.com/llvm/llvm-project/pull/70877

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-07 Thread Björn Pettersson via cfe-commits
@@ -0,0 +1,29 @@ +# RUN: clangd -lit-test < %s | FileCheck %s bjope wrote: Thanks. I'm not that familiar with the clangd test cases. But I've update the pull-request with a unittest instead. https://github.com/llvm/llvm-project/pull/71415 __

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/70877 >From 18369263a3160963b943cd8574edaa212b6d0996 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Tue, 31 Oct 2023 16:45:17 -0700 Subject: [PATCH] Fix attribute plugins --- clang/lib/Sema/ParsedAttr.cpp | 15

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope updated https://github.com/llvm/llvm-project/pull/71415 From 2b1af2bff6432a50eb725adf86e6cfcc52cc020b Mon Sep 17 00:00:00 2001 From: Bjorn Pettersson Date: Mon, 6 Nov 2023 17:27:28 +0100 Subject: [PATCH 1/2] [clangd] Allow hover over 128-bit variable without crashing W

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread Thomas Lively via cfe-commits
https://github.com/tlively commented: Very cool! LGTM so far. It's really nice that we can delete that entire pass out of the backend. Where can I read more about these new target extension types? https://github.com/llvm/llvm-project/pull/71540 ___ c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-11-07 Thread Vladislav Dzhidzhoev via Phabricator via cfe-commits
dzhidzhoev added a comment. In D144006#4656350 , @aeubanks wrote: > Heads up, we're seeing issues from this in Chrome again, will try to post a > reduced repro (https://crbug.com/1500022) > > The reduced repro I found crashed very far back, so I'm guessi

[clang] [BoundsSafety] Initial documentation for -fbounds-safety (PR #70749)

2023-11-07 Thread Dan Liew via cfe-commits
delcypher wrote: @rapidsna The CI is complaining about trailing whitespace https://buildkite.com/llvm-project/clang-ci/builds/5817#018b830d-fb91-40df-8956-9e4dd325d27f https://github.com/llvm/llvm-project/pull/70749 ___ cfe-commits mailing list cfe-co

[llvm] [clang] [clang][DepScan] Make OptimizeArgs a bit mask enum and enable by default (PR #71588)

2023-11-07 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/71588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >