[flang] [compiler-rt] [clang-tools-extra] [clang] [libc] [lld] [llvm] [libcxxabi] [libcxx] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-11-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/69498 >From 77c0256c3ae99808a8def68bfcf5eee2fad704ca Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 14 Jun 2023 17:49:22 -0700 Subject: [PATCH 1/8] [libc++] Fix the behavior of throwing `operator new` under -f

[llvm] [polly] [clang] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Paulo Matos via cfe-commits
https://github.com/pmatos updated https://github.com/llvm/llvm-project/pull/71029 >From fe3ed6bcc6eface6e7bfa3e9b043f8287dd129b0 Mon Sep 17 00:00:00 2001 From: Paulo Matos Date: Fri, 3 Nov 2023 12:03:07 +0100 Subject: [PATCH 1/3] [NFC] Remove Type::getInt8PtrTy Replace this with PointerType::g

[llvm] [polly] [clang] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Paulo Matos via cfe-commits
https://github.com/pmatos updated https://github.com/llvm/llvm-project/pull/71029 >From fe3ed6bcc6eface6e7bfa3e9b043f8287dd129b0 Mon Sep 17 00:00:00 2001 From: Paulo Matos Date: Fri, 3 Nov 2023 12:03:07 +0100 Subject: [PATCH 1/2] [NFC] Remove Type::getInt8PtrTy Replace this with PointerType::g

[llvm] [polly] [clang] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Paulo Matos via cfe-commits
https://github.com/pmatos updated https://github.com/llvm/llvm-project/pull/71029 >From fe3ed6bcc6eface6e7bfa3e9b043f8287dd129b0 Mon Sep 17 00:00:00 2001 From: Paulo Matos Date: Fri, 3 Nov 2023 12:03:07 +0100 Subject: [PATCH] [NFC] Remove Type::getInt8PtrTy Replace this with PointerType::getUn

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
sun-jacobi wrote: Moreover, in the original implementation, the `checkStatement` return false if and only if there is no error in the statement. The question is whether `checkStatement` should consider a statement, which contains semantic errors not related to the atomic directive, as a `NoErr

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
sun-jacobi wrote: > This doesn't look like the right place to fix this issue to me. > @alexey-bataev might have better suggestion. The crash occurs at https://github.com/llvm/llvm-project/blob/d34a10a47d25103725174c62ed5e84e8ca380249/clang/lib/Sema/SemaOpenMP.cpp#L13011 The reason why I fix

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71394 >From 095c386c2a9a4be6bf87d36ed0081d3756c9624b Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 14:11:37 +0800 Subject: [PATCH] [clang][analyzer][NFC] Remove redundant code in StreamChecker --- cl

[clang] [X86] Add a EVEX256 macro to match with GCC and MSVC (PR #71317)

2023-11-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/71317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c78aeab - [X86] Add a EVEX256 macro to match with GCC and MSVC (#71317)

2023-11-06 Thread via cfe-commits
Author: Phoebe Wang Date: 2023-11-07T14:39:24+08:00 New Revision: c78aeabaecb6c9b1df1fef4b3d42ceb48bca2152 URL: https://github.com/llvm/llvm-project/commit/c78aeabaecb6c9b1df1fef4b3d42ceb48bca2152 DIFF: https://github.com/llvm/llvm-project/commit/c78aeabaecb6c9b1df1fef4b3d42ceb48bca2152.diff L

[clang] [Clang][CodeGen] Stoping emitting alignment assumes for `align_{up,down}` (PR #71295)

2023-11-06 Thread via cfe-commits
https://github.com/goldsteinn closed https://github.com/llvm/llvm-project/pull/71295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 590884a - [Clang][CodeGen] Stoping emitting alignment assumes for `align_{up,down}`

2023-11-06 Thread Noah Goldstein via cfe-commits
Author: Noah Goldstein Date: 2023-11-07T00:31:04-06:00 New Revision: 590884a860ccc5fce50bf0a7eba91ec1bfe71fb6 URL: https://github.com/llvm/llvm-project/commit/590884a860ccc5fce50bf0a7eba91ec1bfe71fb6 DIFF: https://github.com/llvm/llvm-project/commit/590884a860ccc5fce50bf0a7eba91ec1bfe71fb6.diff

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/71366 >From 4a878b63cbdd33833b998896120a992178438180 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 6 Nov 2023 16:50:02 +0800 Subject: [PATCH 1/3] [clangd] Don't show inlay hints for PseudoObjectExprs in C++

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
zyn0217 wrote: On second thought I think I should not kill all the expressions involving `PseudoObjectExpr`: I'm not sure if our ObjC / CUDA support does need that for presenting useful hints. https://github.com/llvm/llvm-project/pull/71366 ___ cfe-c

[clang] d0c778c - [NFC] Remove unused member function 'Error' from PCHValidator

2023-11-06 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-11-07T14:13:33+08:00 New Revision: d0c778c882f117182f8a43d0f986cc8c2cfbb688 URL: https://github.com/llvm/llvm-project/commit/d0c778c882f117182f8a43d0f986cc8c2cfbb688 DIFF: https://github.com/llvm/llvm-project/commit/d0c778c882f117182f8a43d0f986cc8c2cfbb688.diff LO

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
benshi001 wrote: It seems my previous change make little sense, so I reuse this PR for another change. https://github.com/llvm/llvm-project/pull/71394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 edited https://github.com/llvm/llvm-project/pull/71394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwrite of StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71394 >From 3be57e39926bda29b273d5e9e01bff5ec8b2302e Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 14:11:37 +0800 Subject: [PATCH] [clang][analyzer][NFC] Remove redundant code in StreamChecker --- cl

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (jyu2-git) Changes Current compler assert with `!SI->isAtomic() && !SI->isVolatile()' failed This due to following rule: First, no exception can move in or out of _try region., i.e., no "potential faulty instruction can be m

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (jyu2-git) Changes Current compler assert with `!SI->isAtomic() && !SI->isVolatile()' failed This due to following rule: First, no exception can move in or out of _try region., i.e., no "potential faulty instruction can be moved acr

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-06 Thread via cfe-commits
https://github.com/jyu2-git created https://github.com/llvm/llvm-project/pull/71488 Current compler assert with `!SI->isAtomic() && !SI->isVolatile()' failed This due to following rule: First, no exception can move in or out of _try region., i.e., no "potential faulty instruction can be moved

[clang] 407afbf - [clang][examples] Remove unused variable 'key' in LLVMPrintFunctionNames.cpp (NFC)

2023-11-06 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2023-11-07T13:09:20+08:00 New Revision: 407afbf1bc276fb70569da335e5ef57b7cb119db URL: https://github.com/llvm/llvm-project/commit/407afbf1bc276fb70569da335e5ef57b7cb119db DIFF: https://github.com/llvm/llvm-project/commit/407afbf1bc276fb70569da335e5ef57b7cb119db.diff LOG: [

[clang] [clang-format] Add spaces around the Verilog implication operator (PR #71352)

2023-11-06 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/71352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7c3707a - Reland "clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (#70639)"

2023-11-06 Thread Michael Buch via cfe-commits
Author: Michael Buch Date: 2023-11-07T04:53:54Z New Revision: 7c3707aea8a6f1fc245ad2862982b8a51b6c0fea URL: https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea DIFF: https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea.diff LOG:

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/11] [clang] Add support for new loop attribute [[clang::code

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: I think I have expressed I wanted to say... The new probing semantics seems really unusual to me. I do not feel that how path-related options usually behave. https://github.com/llvm/llvm-project/pull/71446 ___ cfe-commits mailing list

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

2023-11-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: > [Driver][BoundsSafety] Add -fbounds-safety-experimental flag #70480 The patch implements `-fexperimental-bounds-safety` https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/10] [clang] Add support for new loop attribute [[clang::code

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread Shilei Tian via cfe-commits
shiltian wrote: This doesn't look like the right place to fix this issue to me. @alexey-bataev might have better suggestion. https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

2023-11-06 Thread Fangrui Song via cfe-commits
@@ -1412,6 +1412,9 @@ def FunctionMultiVersioning def NoDeref : DiagGroup<"noderef">; +// Bounds safety specific warnings +def IgnoredBoundsSafety : DiagGroup<"ignored-bounds-safety">; MaskRay wrote: This is `-Wignored-bounds-safety` is not used. https://gi

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

2023-11-06 Thread Fangrui Song via cfe-commits
@@ -3618,6 +3618,27 @@ void CompilerInvocationBase::GenerateLangArgs(const LangOptions &Opts, GenerateArg(Consumer, OPT_frandomize_layout_seed_EQ, Opts.RandstructSeed); } +static void CheckBoundsSafetyLang(InputKind IK, DiagnosticsEngine &Diags) { MaskRay

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

2023-11-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][BoundsSafety] Add -fbounds-safety-experimental flag (PR #70480)

2023-11-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
@@ -788,6 +797,20 @@ void LoopInfoStack::push(BasicBlock *Header, clang::ASTContext &Ctx, } } + // Translate 'loop attributes' arguments to equivalent Attr enums. + // It's being handled separately from LoopHintAttrs not to support + // legacy GNU attributes and prag

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; compnerd wrote: ```suggestion const Module &M; ``` https://git

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
@@ -635,3 +638,496 @@ bool clang::api_notes::parseAndDumpAPINotes(StringRef YI, return false; } + +namespace { +using namespace api_notes; + +class YAMLConverter { + const Module &TheModule; + APINotesWriter Writer; + llvm::raw_ostream &OS; + llvm::SourceMgr::DiagHandler

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/71413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd commented: Given the instances of quoting, I feel like it might make some sense to have a helper that quotes. At the very least, please use a `llvm::Twine` for the error messages where you are quoting the names. https://github.com/llvm/llvm-project/pull/71413 __

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread William Moses via cfe-commits
https://github.com/wsmoses closed https://github.com/llvm/llvm-project/pull/70171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3c11ac5 - [Clang] Add codegen option to add passbuilder callback functions (#70171)

2023-11-06 Thread via cfe-commits
Author: William Moses Date: 2023-11-06T22:26:38-06:00 New Revision: 3c11ac51180ffebe7d71b8773ec03275aec2eb7a URL: https://github.com/llvm/llvm-project/commit/3c11ac51180ffebe7d71b8773ec03275aec2eb7a DIFF: https://github.com/llvm/llvm-project/commit/3c11ac51180ffebe7d71b8773ec03275aec2eb7a.diff

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
@@ -322,6 +322,56 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 1/9] [clang] Add support for new loop attribute [[clang::code_a

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
https://github.com/sun-jacobi updated https://github.com/llvm/llvm-project/pull/71480 >From 265c0586330a678ef61a64c9610cf0ee7c51367f Mon Sep 17 00:00:00 2001 From: sun-jacobi Date: Tue, 7 Nov 2023 12:06:28 +0900 Subject: [PATCH 1/2] [Clang][OpenMP]: fixed crash due to invalid binary expression

[clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-06 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 1/8] [clang] Add support for new loop attribute [[clang::code_a

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chia (sun-jacobi) Changes This PR fixes https://github.com/llvm/llvm-project/issues/69069 . --- Full diff: https://github.com/llvm/llvm-project/pull/71480.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaOpenMP.cpp (+7) `

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
https://github.com/sun-jacobi created https://github.com/llvm/llvm-project/pull/71480 This PR fixes https://github.com/llvm/llvm-project/issues/69069 . >From 265c0586330a678ef61a64c9610cf0ee7c51367f Mon Sep 17 00:00:00 2001 From: sun-jacobi Date: Tue, 7 Nov 2023 12:06:28 +0900 Subject: [PATC

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

2023-11-06 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I'd like to land this change later since the existing behavior violates our expectations for ABI. https://github.com/llvm/llvm-project/pull/71031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-06 Thread Younan Zhang via cfe-commits
@@ -0,0 +1,29 @@ +# RUN: clangd -lit-test < %s | FileCheck %s zyn0217 wrote: Rather than creating a lit-test, could you please move it to the `HoverTests.cpp` under the unittests directory? That would be more straightforward, and I think we could add the case t

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thank you! I didn't realize that `getActiveBits` was calculated by the count of leading zeros, even for negative numbers. This generally looks good modulo a question on the test. https://github.com/llvm/llvm-project/pull/71415 ___

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Remove unneeded template keyword" (PR #71478)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Reverts llvm/llvm-project#71435 This is failing on some build bots e.g.: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62315/consoleFull#-3939952849ba4694-19c4-4d7e-bec5-911270d8a58c --- Full

[clang] Revert "[Clang] Remove unneeded template keyword" (PR #71478)

2023-11-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/71478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ef618b5 - Revert "[Clang] Remove unneeded template keyword" (#71478)

2023-11-06 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2023-11-06T18:22:42-08:00 New Revision: ef618b598e6d767208c0b93cc1e47fbec59857dd URL: https://github.com/llvm/llvm-project/commit/ef618b598e6d767208c0b93cc1e47fbec59857dd DIFF: https://github.com/llvm/llvm-project/commit/ef618b598e6d767208c0b93cc1e47fbec59857dd.dif

[clang] Revert "[Clang] Remove unneeded template keyword" (PR #71478)

2023-11-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/71478 Reverts llvm/llvm-project#71435 This is failing on some build bots e.g.: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62315/consoleFull#-3939952849ba4694-19c4-4d7e-bec5-911270d8a58c >From 61934f800b

[clang] [Clang] Remove unneeded template keyword (PR #71435)

2023-11-06 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Sadly this is failing on some build bots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62315/consoleFull#-3939952849ba4694-19c4-4d7e-bec5-911270d8a58c Not sure why at the moment. Will revert for now. https://github.com/llvm/llvm-project/pull/71435 ___

[clang-tools-extra] [clang] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

2023-11-06 Thread Qizhi Hu via cfe-commits
jcsxky wrote: how about adding a function call like `f()`? will this can prevent clang to emit empty function body? https://github.com/llvm/llvm-project/pull/70559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[llvm] [clang] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -338,12 +574,33 @@ PreservedAnalyses GlobalDCEPass::run(Module &M, ModuleAnalysisManager &MAM) { // The second pass drops the bodies of functions which are dead... std::vector DeadFunctions; - for (Function &F : M) + std::set DeadFunctionsSet; + auto funcRemovedInIn

[llvm] [clang] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -34,12 +40,223 @@ static cl::opt ClEnableVFE("enable-vfe", cl::Hidden, cl::init(true), cl::desc("Enable virtual function elimination")); +static cl::opt ClReadSummary( +"globaldce-read-summary", +cl::desc("Read summary from given bitcode before r

[clang] [llvm] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -1362,6 +1362,8 @@ class ModuleSummaryIndex { // Temporary map while building StackIds list. Clear when index is completely // built via releaseTemporaryMemory. std::map StackIdToIndex; + std::set FuncsWithNonVtableRef; teresajohnson wrote: Instead o

[llvm] [clang] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -34,12 +40,223 @@ static cl::opt ClEnableVFE("enable-vfe", cl::Hidden, cl::init(true), cl::desc("Enable virtual function elimination")); +static cl::opt ClReadSummary( +"globaldce-read-summary", +cl::desc("Read summary from given bitcode before r

[clang] [llvm] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -34,12 +40,223 @@ static cl::opt ClEnableVFE("enable-vfe", cl::Hidden, cl::init(true), cl::desc("Enable virtual function elimination")); +static cl::opt ClReadSummary( +"globaldce-read-summary", +cl::desc("Read summary from given bitcode before r

[llvm] [clang] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -775,6 +783,58 @@ static void computeVariableSummary(ModuleSummaryIndex &Index, Index.addGlobalValueSummary(V, std::move(GVarSummary)); } +static void ComputeDependencies( teresajohnson wrote: nit: function should be lowerCamelCase https://github.com/l

[clang] [llvm] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -34,12 +40,223 @@ static cl::opt ClEnableVFE("enable-vfe", cl::Hidden, cl::init(true), cl::desc("Enable virtual function elimination")); +static cl::opt ClReadSummary( +"globaldce-read-summary", +cl::desc("Read summary from given bitcode before r

[llvm] [clang] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -34,12 +40,223 @@ static cl::opt ClEnableVFE("enable-vfe", cl::Hidden, cl::init(true), cl::desc("Enable virtual function elimination")); +static cl::opt ClReadSummary( +"globaldce-read-summary", +cl::desc("Read summary from given bitcode before r

[clang] [llvm] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
@@ -1362,6 +1362,8 @@ class ModuleSummaryIndex { // Temporary map while building StackIds list. Clear when index is completely // built via releaseTemporaryMemory. std::map StackIdToIndex; + std::set FuncsWithNonVtableRef; + std::set VFuncsToBeRemoved; // no need to ser

[clang] [llvm] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
https://github.com/teresajohnson commented: Thanks for the patch! I didn't go through in too much detail yet, but have some mostly higher level comments and suggestions. https://github.com/llvm/llvm-project/pull/69735 ___ cfe-commits mailing list cfe-

[clang] [llvm] Support VFE in thinLTO (PR #69735)

2023-11-06 Thread Teresa Johnson via cfe-commits
https://github.com/teresajohnson edited https://github.com/llvm/llvm-project/pull/69735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove unneeded template keyword (PR #71435)

2023-11-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/71435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9c34678 - [Clang] Remove unneeded template keyword (#71435)

2023-11-06 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2023-11-06T17:52:45-08:00 New Revision: 9c346780dc1deed1c5362fcfca874e281c53e6e0 URL: https://github.com/llvm/llvm-project/commit/9c346780dc1deed1c5362fcfca874e281c53e6e0 DIFF: https://github.com/llvm/llvm-project/commit/9c346780dc1deed1c5362fcfca874e281c53e6e0.dif

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-06 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/68932 >From a87ba1892375ef67edb5d6f3bd537869203273a6 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Thu, 12 Oct 2023 16:45:59 -0500 Subject: [PATCH 1/6] [AMDGPU] Emit a waitcnt instruction after each memory instruct

[mlir] [compiler-rt] [libcxx] [libcxxabi] [clang] [llvm] [lldb] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-11-06 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl edited https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [compiler-rt] [llvm] [lldb] [libcxxabi] [mlir] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-11-06 Thread Anton Rydahl via cfe-commits
@@ -466,6 +466,114 @@ Unpoisoning may not be an option, if (for example) you are not maintaining the a * You are using allocator, which does not call destructor during deallocation. * You are aware that memory allocated with an allocator may be accessed, even when unused by co

[clang] 0936a71 - [clang][CGObjCGNU] Remove no-op ptr-to-ptr bitcasts (NFC)

2023-11-06 Thread Youngsuk Kim via cfe-commits
Author: Youngsuk Kim Date: 2023-11-06T19:41:32-06:00 New Revision: 0936a718492d248a726b8e8d4529e4aa194bc8e9 URL: https://github.com/llvm/llvm-project/commit/0936a718492d248a726b8e8d4529e4aa194bc8e9 DIFF: https://github.com/llvm/llvm-project/commit/0936a718492d248a726b8e8d4529e4aa194bc8e9.diff

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-06 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/68932 >From a87ba1892375ef67edb5d6f3bd537869203273a6 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Thu, 12 Oct 2023 16:45:59 -0500 Subject: [PATCH 1/5] [AMDGPU] Emit a waitcnt instruction after each memory instruct

[clang] bdb309c - [clang][modules] Avoid modules diagnostics for `__has_include()` (#71450)

2023-11-06 Thread via cfe-commits
Author: Jan Svoboda Date: 2023-11-06T17:31:27-08:00 New Revision: bdb309c5fd4030ae6ff9d5114e3532d45a98a183 URL: https://github.com/llvm/llvm-project/commit/bdb309c5fd4030ae6ff9d5114e3532d45a98a183 DIFF: https://github.com/llvm/llvm-project/commit/bdb309c5fd4030ae6ff9d5114e3532d45a98a183.diff L

[clang] [clang][modules] Avoid modules diagnostics for `__has_include()` (PR #71450)

2023-11-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/71450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]get non-injected-class before finding instantiated decl (PR #70886)

2023-11-06 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: ping @erichkeane @AaronBallman @shafik @cor3ntin https://github.com/llvm/llvm-project/pull/70886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [flang] [libc] [clang-tools-extra] [llvm] [clang] [compiler-rt] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-06 Thread Mehdi Amini via cfe-commits
@@ -95,7 +95,7 @@ class SerializeToHsacoPass std::unique_ptr> serializeISA(const std::string &isa) override; - std::unique_ptr> assembleIsa(const std::string &isa); + std::unique_ptr> assembleIsa(const std::string &isa); joker-eph wrote: @krzysz00 can y

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-06 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/68932 >From 07b3f94e49df221406cf7b83a05c8704e1af1c75 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Thu, 12 Oct 2023 16:45:59 -0500 Subject: [PATCH 1/5] [AMDGPU] Emit a waitcnt instruction after each memory instruct

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

2023-11-06 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. LGTM. Thanks https://github.com/llvm/llvm-project/pull/69371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

2023-11-06 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: sometimes the formatter checks the diff of the rebase when you rebase your code. However if you rebase your commits against ToT of trunk the formatter issue may disappear. https://github.com/llvm/llvm-project/pull/69371 ___ cfe-commit

[libc] [clang-tools-extra] [libcxx] [compiler-rt] [clang] [llvm] [flang] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread via cfe-commits
@@ -698,6 +695,19 @@ StmtResult Parser::ParseSEHLeaveStatement() { return Actions.ActOnSEHLeaveStmt(LeaveLoc, getCurScope()); } +static void DiagnoseLabelFollowedByDecl(Parser &P, const Stmt *SubStmt) { + // When in C mode (but not Microsoft extensions mode), diagnose use o

[llvm] [compiler-rt] [libc] [clang] [libcxx] [flang] [clang-tools-extra] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread via cfe-commits
@@ -712,9 +722,7 @@ StmtResult Parser::ParseLabeledStatement(ParsedAttributes &Attrs, assert(Tok.is(tok::identifier) && Tok.getIdentifierInfo() && "Not an identifier!"); - // The substatement is always a 'statement', not a 'declaration', but is - // otherwise in

  1   2   3   4   5   >