[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I think it would be better to disable assert instead of revert this change. https://github.com/llvm/llvm-project/pull/69106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-18 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 39427b1 - Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (#68572)

2023-10-18 Thread via cfe-commits
Author: Clement Courbet Date: 2023-10-19T08:34:59+02:00 New Revision: 39427b10985f034b85a12e8b229a4f816d844afb URL: https://github.com/llvm/llvm-project/commit/39427b10985f034b85a12e8b229a4f816d844afb DIFF: https://github.com/llvm/llvm-project/commit/39427b10985f034b85a12e8b229a4f816d844afb.dif

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

2023-10-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. LGTM then https://github.com/llvm/llvm-project/pull/68962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-18 Thread Clement Courbet via cfe-commits
@@ -1061,11 +1061,13 @@ def Most : DiagGroup<"most", [ ]>; // Thread Safety warnings -def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">; -def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">; -def ThreadSafetyPrecise: DiagGroup<"thread-safety-

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-18 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From f3b0c9708bbf6fb0962fb82b605a7fc0b52d4a5b Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH] =?UTF-8?q?Reapply=20"[clang=20analysis][thread-safety]=20?=

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-18 Thread Clement Courbet via cfe-commits
@@ -2278,7 +2303,7 @@ void ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContext &AC) { PostOrderCFGView::CFGBlockSet VisitedBlocks(CFGraph); CFGBlockInfo &Initial = BlockInfo[CFGraph->getEntry().getBlockID()]; - CFGBlockInfo &Final = BlockInfo[CFGraph->getExit().getBl

[clang] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/69277 >From 9e673f332b8f7a3cfdeb1a73f6a77aee651f7664 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Wed, 11 Oct 2023 10:25:36 +0800 Subject: [PATCH 1/2] [X86] Support -march=pantherlake,clearwaterforest --- clang/

[clang-tools-extra] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/69277 >From 9e673f332b8f7a3cfdeb1a73f6a77aee651f7664 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Wed, 11 Oct 2023 10:25:36 +0800 Subject: [PATCH 1/2] [X86] Support -march=pantherlake,clearwaterforest --- clang/

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/68081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 59d2dc2 - [clang][Interp] IntegralAP zero-initializers (#68081)

2023-10-18 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-19T08:20:53+02:00 New Revision: 59d2dc239b053d124ebc82937da2e7a38d0ec11e URL: https://github.com/llvm/llvm-project/commit/59d2dc239b053d124ebc82937da2e7a38d0ec11e DIFF: https://github.com/llvm/llvm-project/commit/59d2dc239b053d124ebc82937da2e7a38d0ec11e.diff L

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
@@ -847,7 +845,33 @@ template bool ByteCodeExprGen::VisitOpaqueValueExpr(const OpaqueValueExpr *E) { if (Initializing) return this->visitInitializer(E->getSourceExpr()); - return this->visit(E->getSourceExpr()); + + PrimType CacheVariableTy = classify(E).value_or(PT_Pt

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
@@ -810,9 +810,7 @@ bool ByteCodeExprGen::VisitArrayInitLoopExpr( const ArrayInitLoopExpr *E) { assert(Initializing); assert(!DiscardResult); - // TODO: This compiles to quite a lot of bytecode if the array is larger. - // Investigate compiling this to a loop, or at

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/68039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
@@ -847,7 +845,33 @@ template bool ByteCodeExprGen::VisitOpaqueValueExpr(const OpaqueValueExpr *E) { if (Initializing) return this->visitInitializer(E->getSourceExpr()); - return this->visit(E->getSourceExpr()); + + PrimType CacheVariableTy = classify(E).value_or(PT_Pt

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr requested changes to this pull request. https://github.com/llvm/llvm-project/pull/68039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
@@ -847,7 +845,33 @@ template bool ByteCodeExprGen::VisitOpaqueValueExpr(const OpaqueValueExpr *E) { if (Initializing) return this->visitInitializer(E->getSourceExpr()); - return this->visit(E->getSourceExpr()); + + PrimType CacheVariableTy = classify(E).value_or(PT_Pt

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-18 Thread Timm Baeder via cfe-commits
@@ -847,7 +845,33 @@ template bool ByteCodeExprGen::VisitOpaqueValueExpr(const OpaqueValueExpr *E) { if (Initializing) return this->visitInitializer(E->getSourceExpr()); - return this->visit(E->getSourceExpr()); + + PrimType CacheVariableTy = classify(E).value_or(PT_Pt

[clang-tools-extra] fix usr rhs (PR #68329)

2023-10-18 Thread Sam McCall via cfe-commits
@@ -1070,6 +1063,24 @@ void USRGenerator::VisitMSGuidDecl(const MSGuidDecl *D) { D->NamedDecl::printName(Out); } +void USRGenerator::VisitBaseUsingDecl(const BaseUsingDecl *D) { + // Add the filename when needed to disambiguate using decls from different + // files. + if

[clang-tools-extra] fix usr rhs (PR #68329)

2023-10-18 Thread Sam McCall via cfe-commits
@@ -1070,6 +1063,24 @@ void USRGenerator::VisitMSGuidDecl(const MSGuidDecl *D) { D->NamedDecl::printName(Out); } +void USRGenerator::VisitBaseUsingDecl(const BaseUsingDecl *D) { + // Add the filename when needed to disambiguate using decls from different + // files. --

[clang-tools-extra] fix usr rhs (PR #68329)

2023-10-18 Thread Sam McCall via cfe-commits
@@ -1070,6 +1063,24 @@ void USRGenerator::VisitMSGuidDecl(const MSGuidDecl *D) { D->NamedDecl::printName(Out); } +void USRGenerator::VisitBaseUsingDecl(const BaseUsingDecl *D) { + // Add the filename when needed to disambiguate using decls from different + // files. + if

[clang-tools-extra] fix usr rhs (PR #68329)

2023-10-18 Thread Sam McCall via cfe-commits
@@ -1070,6 +1063,24 @@ void USRGenerator::VisitMSGuidDecl(const MSGuidDecl *D) { D->NamedDecl::printName(Out); } +void USRGenerator::VisitBaseUsingDecl(const BaseUsingDecl *D) { + // Add the filename when needed to disambiguate using decls from different + // files. + if

[clang] fix usr rhs (PR #68329)

2023-10-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall commented: Thanks! This is a bit subtle, so I'm being a bit picky... Can you add a more useful commit message? https://github.com/llvm/llvm-project/pull/68329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] fix usr rhs (PR #68329)

2023-10-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/68329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
HaohaiWen wrote: > Rebase you other patch then I can review. Already rebased. Please take a look https://github.com/llvm/llvm-project/pull/68502 https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
HaohaiWen wrote: > Rebase you other patch then I can review. Already rebased. Please take a look https://github.com/llvm/llvm-project/pull/68502 https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I'd vote for something like `-fassume-nothrow-exception-dtor` or `-fenforce-nothrow-exception-dtor` depending on if the patch will also implement the enforcement mentioned in https://github.com/llvm/llvm-project/issues/57375#issuecomment-1230590204, but we can bikeshed

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D108905#4654411 , @MaskRay wrote: > In D108905#4654410 , @smeenai wrote: > >> In D108905#4654403 , @ChuanqiXu >> wrote: >> >>> In D108905#46

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-18 Thread via cfe-commits
mzyKi wrote: > > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > > assertion but it will not result in crash. > > Have you find the exact commit to break this case? @mzyKi @HerrCai0907 after this commit 610ec954e1f81c0e8fcadedcd25afe643f5a094e , clang will crash in te

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D108905#4654410 , @smeenai wrote: > In D108905#4654403 , @ChuanqiXu > wrote: > >> In D108905#4654393 , @smeenai >> wrote: >> >>> In D108905#2

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D108905#4654403 , @ChuanqiXu wrote: > In D108905#4654393 , @smeenai wrote: > >> In D108905#2975712 , @rsmith wrote: >> >>> No decision as yet,

[clang] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

2023-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 817519058a986794e6acc06e4386fa183c4472a0 c61f6fb37e5d8ad0b7dfa68803f5a0161d542867 --

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/2] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to v

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b858309ddc977d5e70de54f3fa3888915b5fbc0c 96f6b90ed4a70430f94eab2d9ca317dd8367022a --

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
goldsteinn wrote: Rebase you other patch then I can review. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
goldsteinn wrote: Rebase you other patch then I can review. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shivam Gupta (xgupta) Changes This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak --- Full diff: https://github.com/llvm/llvm-project/pull/69557.diff 3 Files Affected: - (modified) clang/include/clang/AS

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/69557 This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +053

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69555 >From 86663a35a7af039f9440af2cc1896e8b4cf33310 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 19 Oct 2023 11:28:01 +0800 Subject: [PATCH] [C++20] [Modules] Warn if we found #include in module purview

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/68615. It is generally wrong to include in the module purview. Although there are cases to include files in the module purview, generally these

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69555 Close https://github.com/llvm/llvm-project/issues/68615. It is generally wrong to include in the module purview. Although there are cases to include files in the module purview, generally these use cases sh

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: The CI failure is the bootstrapping build agent dying, definitely not related to this. Shipping. https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: The CI failure is the bootstrapping build agent dying, definitely not related to this. Shipping. https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

2023-10-18 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > Thanks, looks good! > > You can submit as is, but if you're up for it, it would actually be better to > add the new test case directly to the model's unittests. Something like this > test (though just one case is enough -- please put it in a separate TEST_P): > > https://githu

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

2023-10-18 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/68510 >From a5c5fc7a17f57a0b6ae328f7138435b4aaf7f9b5 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 8 Oct 2023 16:00:29 +0800 Subject: [PATCH] [clang][analysis]Use dyn_cast_or_null instead of cast to prevent crash

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D108905#4654393 , @smeenai wrote: > In D108905#2975712 , @rsmith wrote: > >> No decision as yet, but so far it looks very likely that we'll settle on the >> rule that exceptions cann

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/69439. This patch tries to reuse the codes to generate make style dependencies information with P1689 format directly. --- Full diff: https://github.com/ll

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69551 Close https://github.com/llvm/llvm-project/issues/69439. This patch tries to reuse the codes to generate make style dependencies information with P1689 format directly. >From 17b84659fa91d8a92a3d41aad8fbc3fa

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/3] [clang]Transform uninstantiated ExceptionSpec in Template

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

2023-10-18 Thread via cfe-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/68502 >From 5b3b1bbb5b263bc5711adde031d85b1461ccbab6 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Sat, 7 Oct 2023 13:48:32 +0800 Subject: [PATCH 1/2] [InstCombine] Refactor matchFunnelShift to allow more pattern

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Does MSVC have the delayed template parsing effects when using modules? If > not, perhaps we should just disable the flag/not allow it to be composed > together? As far as I can reach, (from the issue reports in MSVC community), MSVC don't have problems with the delayed te

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
https://github.com/HaohaiWen closed https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Herald added subscribers: pmatos, asb. Herald added a project: All. In D108905#2975712 , @rsmith wrote: > No decision as yet, but so far it looks very likely that we'll settle on the > rule that exceptions cannot have potentially

[clang] [Driver][DragonFly] Fixes for linker path and command-line option handling (PR #69095)

2023-10-18 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0913a2d - [Driver][DragonFly] Fixes for linker path and command-line option handling (#69095)

2023-10-18 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-18T20:47:04-04:00 New Revision: 0913a2d07d06b66780e4a1e4361f9159ce0013f8 URL: https://github.com/llvm/llvm-project/commit/0913a2d07d06b66780e4a1e4361f9159ce0013f8 DIFF: https://github.com/llvm/llvm-project/commit/0913a2d07d06b66780e4a1e4361f9159ce0013f8.diff LO

[clang] 2172eea - [clang-format][NFC] Take a constant conjunct out of a loop condition

2023-10-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-18T17:37:41-07:00 New Revision: 2172eeaa52bec211b255e9cb4d8464a8908ff709 URL: https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709 DIFF: https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709.diff LOG:

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
@@ -66,6 +66,11 @@ using namespace clang; using namespace CodeGen; using namespace llvm; +static llvm::cl::opt ClSanitizeAlignmentBuiltin( +"sanitize-alignment-builtin", llvm::cl::Hidden, +llvm::cl::desc("Instrument builtin functions for -fsanitize=alignment"), +ll

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

2023-10-18 Thread via cfe-commits
vabridgers wrote: > LGTM! Btw, if you're just repairing tests like you had to do here, you > generally are okay to not go through another round of review unless you want > an extra set of eyes on things. The original approval is fine so long as > you're not making substantial changes to the co

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-18 Thread Brad Smith via cfe-commits
brad0 wrote: > Ah, I meant potential changes to `llvm/lib/Target` and `llvm/lib/MC`. But I > did search in backend using FreeBSD as keyword for example, few places need > to support it explicitly. If Haiku uses similar ABI and binary format to > Linux or FreeBSD, that makes sense. Yes, Haiku

[clang] cfbf0a5 - [X86][RFC] Support AVX10 options (#67278)

2023-10-18 Thread via cfe-commits
Author: Phoebe Wang Date: 2023-10-19T07:52:50+08:00 New Revision: cfbf0a500f173b532f64fcb856af2fb0cb7ba725 URL: https://github.com/llvm/llvm-project/commit/cfbf0a500f173b532f64fcb856af2fb0cb7ba725 DIFF: https://github.com/llvm/llvm-project/commit/cfbf0a500f173b532f64fcb856af2fb0cb7ba725.diff L

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > assertion but it will not result in crash. Have you find the exact commit to break this case? @mzyKi https://github.com/llvm/llvm-project/pull/69106 ___ cf

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

2023-10-18 Thread via cfe-commits
https://github.com/kyulee-com closed https://github.com/llvm/llvm-project/pull/69489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7aa2491 - [clang] Expand invalid PCM diagnostic (#69489)

2023-10-18 Thread via cfe-commits
Author: Nuri Amari Date: 2023-10-18T16:19:54-07:00 New Revision: 7aa24915cb66c51bab7c15854877136930d3ed17 URL: https://github.com/llvm/llvm-project/commit/7aa24915cb66c51bab7c15854877136930d3ed17 DIFF: https://github.com/llvm/llvm-project/commit/7aa24915cb66c51bab7c15854877136930d3ed17.diff LO

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: friendly ping @erichkeane https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: friendly ping @erichkeane https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in Template

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in Template

[clang] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/69465 >From 627f68e57b2526fb72285ef4831fc3c02a6ee6d0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 18 Oct 2023 08:47:02 +0800 Subject: [PATCH 1/7] [clang-tidy]Add new check bugprone-casting-through-void F

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave closed https://github.com/llvm/llvm-project/pull/67863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,50 @@ +//===--- CastingThroughVoidCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/8] [RISCV][GISel] Add ISel supports for SHXADD from Zba extens

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/8] [RISCV][GISel] Add ISel supports for SHXADD from Zba extens

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/7] [RISCV][GISel] Add ISel supports for SHXADD from Zba extens

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/7] [RISCV][GISel] Add ISel supports for SHXADD from Zba extens

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fazlay Rabbi (mdfazlay) Changes The syntax of modifiers without comma separators in the map clause was deprecated in OpenMP 5.2. Reference: OpenMP 5.2 Spec, page 627, line 19 --- Patch is 26.39 KiB, truncated to 20.00 KiB below, full ve

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

2023-10-18 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay created https://github.com/llvm/llvm-project/pull/69534 The syntax of modifiers without comma separators in the map clause was deprecated in OpenMP 5.2. Reference: OpenMP 5.2 Spec, page 627, line 19 >From 4b21bd09b1f1e3d5c68bd3e0c4701d7cb912631e Mon Sep 17 00:00:00

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

2023-10-18 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. Looks good. I wonder how this happened in the first place - that the author of the diagnostic was already adding the 3rd parameter into the arguments but there was no `%2` in the diagnostic text/template... It'd be great if we had some

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/6] [RISCV][GISel] Add ISel supports for SHXADD from Zba extens

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/6] [RISCV][GISel] Add ISel supports for SHXADD from Zba extens

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

2023-10-18 Thread Nuri Amari via cfe-commits
https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/69489 >From 3fa795fae47d00ece00e9414a268610d3c4a6bf3 Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Fri, 22 Sep 2023 12:03:23 -0700 Subject: [PATCH 1/2] Expand invalid PCM diagnostic Summary: When a PCM file is lo

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

2023-10-18 Thread Paul Kirth via cfe-commits
ilovepi wrote: Hi, is there a way to disable this check w/o disabling all `-Wconversion` warnings? We'd like to disable this one on some third_party code(e.g. the vulkansdk), but keep `-Wconversion` as a whole in place whenever we can. Unfortunately, `-Wno-bitfield-conversion` doesn't seem to

[clang-tools-extra] [clang-tidy] Add StrictMode to cppcoreguidelines-pro-type-static-cast-downcast (PR #69529)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Add StrictMode option that controls behavior whatever warnings are emitted for casts on non-polymorphic types. Fixes: #69414 --- Full diff: https://github.com/llvm/llvm-project/pull/69529.diff 5 Files

[clang-tools-extra] [clang-tidy] Add StrictMode to cppcoreguidelines-pro-type-static-cast-downcast (PR #69529)

2023-10-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/69529 Add StrictMode option that controls behavior whatever warnings are emitted for casts on non-polymorphic types. Fixes: #69414 >From 641a1daf6cd969a697c3cb4f0f7e168ca9187fe9 Mon Sep 17 00:00:00 2001 From: Piotr Z

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-18 Thread David Blaikie via cfe-commits
dwblaikie wrote: Does MSVC have the delayed template parsing effects when using modules? If not, perhaps we should just disable the flag/not allow it to be composed together? https://github.com/llvm/llvm-project/pull/69431 ___ cfe-commits mailing list

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-18 Thread via cfe-commits
philnik777 wrote: > > > One thing I REALLY hate about our pattern of using bitfields for enums, > > > is that it becomes pretty trivial to add an entry to an enum and forget > > > to increase the size of the bitfield. I think such a attribute could > > > cause a diagnostic of `bitfield says it

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-10-18 Thread Ellis Hoag via cfe-commits
@@ -60,10 +60,7 @@ using namespace llvm; #define DEBUG_TYPE "instrprof" namespace llvm { -cl::opt -DebugInfoCorrelate("debug-info-correlate", - cl::desc("Use debug info to correlate profiles."), - cl::init(false)); --

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-10-18 Thread David Li via cfe-commits
david-xl wrote: Can you send a RFC for this enhancement ? The first 2 paragraph of this PR can be expanded a little more to show motivations (RAM saving, or raw profile size saving and why) and the savings data. https://github.com/llvm/llvm-project/pull/69493 __

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

2023-10-18 Thread David Blaikie via cfe-commits
@@ -62,7 +62,7 @@ def err_ast_file_out_of_date : Error< "%select{PCH|module|AST}0 file '%1' is out of date and " "needs to be rebuilt%select{|: %3}2">, DefaultFatal; def err_ast_file_invalid : Error< - "file '%1' is not a valid precompiled %select{PCH|module|AST}0 file">,

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Karl-Johan Karlsson (karka228) Changes Constant values of _BitInt have the bitwith to exactly fit the constant number. This patch fix a problem in Sema when building an APInt where the supplied bitwidth can become too small and simply tru

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-10-18 Thread Zequan Wu via cfe-commits
@@ -0,0 +1,11 @@ +; RUN: opt < %s -passes=instrprof -profile-correlate=binary -S | FileCheck %s + +; CHECK: @__profd_foo = private global { i64, i64, i64, ptr, ptr, i32, [2 x i16] } { i64 {{.*}}, i64 {{.*}}, i64 ptrtoint (ptr @__profc_foo to i64) ZequanWu wrote:

  1   2   3   4   >