[clang] 3a3b84b - [clang] remove ClassScopeFunctionSpecializationDecl (#66636)

2023-10-06 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2023-10-07T10:55:31+04:00 New Revision: 3a3b84b180278207731451dfac24f47d02b50e84 URL: https://github.com/llvm/llvm-project/commit/3a3b84b180278207731451dfac24f47d02b50e84 DIFF: https://github.com/llvm/llvm-project/commit/3a3b84b180278207731451dfac24f47d02b50e84

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/68276 >From 24660d933c3dbdbf9c3d9976a0e36c274635f668 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 5 Oct 2023 02:39:12 +0200 Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types W

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-06 Thread Shao-Ce SUN via cfe-commits
sunshaoce wrote: `clang/test/Preprocessor/riscv-target-features.c` need to be modified. https://github.com/llvm/llvm-project/pull/68295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-06 Thread Shao-Ce SUN via cfe-commits
@@ -103,3 +103,27 @@ let SupportOverloading = false in { defm sf_vc_v_fvw : RVVVCIXBuiltinSet<["si"], "UwKzUwUvFe", [-1, 0, 2, 3], UseGPR=0>; } } + +multiclass RVVVQMACCBuiltinSet> suffixes_prototypes> { + let OverloadedName = NAME, + Name = NAME, + HasMasked

[clang] 859f2d0 - Revert "Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (#68394)"

2023-10-06 Thread Caroline Tice via cfe-commits
Author: Caroline Tice Date: 2023-10-06T22:23:02-07:00 New Revision: 859f2d032386632562521a99db20923217d98988 URL: https://github.com/llvm/llvm-project/commit/859f2d032386632562521a99db20923217d98988 DIFF: https://github.com/llvm/llvm-project/commit/859f2d032386632562521a99db20923217d98988.diff

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://gi

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: The latest commit keeps a list

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr converted_to_draft

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://gi

[clang] c654193 - [clang][Lex][NFC] Make some local variables const

2023-10-06 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-07T07:11:45+02:00 New Revision: c654193c22d29c7de35004b1935b8848c43e2aa2 URL: https://github.com/llvm/llvm-project/commit/c654193c22d29c7de35004b1935b8848c43e2aa2 DIFF: https://github.com/llvm/llvm-project/commit/c654193c22d29c7de35004b1935b8848c43e2aa2.diff LO

[clang-tools-extra] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-10-06 Thread via cfe-commits
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626 >From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001 From: jathu Date: Wed, 27 Sep 2023 18:01:19 -0700 Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy --- .../clang-

[clang] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-10-06 Thread via cfe-commits
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626 >From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001 From: jathu Date: Wed, 27 Sep 2023 18:01:19 -0700 Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy --- .../clang-

[clang] [SVE][InstCombine] Delete redundante sel instructions with ptrue (PR #68463)

2023-10-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes svsel(pture, x, y) => x. depend on D121792 --- Full diff: https://github.com/llvm/llvm-project/pull/68463.diff 3 Files Affected: - (modified) clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_sel.c (+14) - (modified) llvm/lib/Target/AA

[clang] [SVE][InstCombine] Delete redundante sel instructions with ptrue (PR #68463)

2023-10-06 Thread via cfe-commits
https://github.com/vfdff created https://github.com/llvm/llvm-project/pull/68463 svsel(pture, x, y) => x. depend on D121792 >From d4d0d96afa5c98be6b4a443f017321fbd1c41112 Mon Sep 17 00:00:00 2001 From: zhongyunde 00443407 Date: Fri, 6 Oct 2023 21:54:36 -0400 Subject: [PATCH 1/2] [SVE][InstCombi

[clang-tools-extra] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-06 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

2023-10-06 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-06 Thread Shao-Ce SUN via cfe-commits
@@ -178,6 +178,19 @@ multiclass CustomSiFiveVCIX; } +let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in { +class CustomSiFiveVMACC funct6, RISCVVFormat opv, string opcodestr> +: RVInstVCCustom2 { + let vm = 1; + let funct6_lo2 = funct6{1-0}; +} +} + +multiclass CustomSi

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-10-06 Thread via cfe-commits
Naville wrote: I'll take a look at into improving llvm-config https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-06 Thread Shao-Ce SUN via cfe-commits
@@ -0,0 +1,57 @@ +# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+v,+xsfvqmaccqoq,+xsfvqmaccdod %s \ +# RUN:| FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST +# RUN: not llvm-mc -triple=riscv64 -show-encoding %s 2>&1 \ +# RUN:| FileCheck %s --check-

[clang] [clang][ASTImporter] Fix crash when import `VarTemplateDecl` in record (PR #67522)

2023-10-06 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/67522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 869d168 - [clang][ASTImporter] Fix crash when import `VarTemplateDecl` in record (#67522)

2023-10-06 Thread via cfe-commits
Author: Qizhi Hu Date: 2023-10-07T09:36:04+08:00 New Revision: 869d1680edb0cc264f01fc6e59f0a1b93330c6da URL: https://github.com/llvm/llvm-project/commit/869d1680edb0cc264f01fc6e59f0a1b93330c6da DIFF: https://github.com/llvm/llvm-project/commit/869d1680edb0cc264f01fc6e59f0a1b93330c6da.diff LOG:

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

2023-10-06 Thread Fei Peng via Phabricator via cfe-commits
fiigii added a comment. How does this patch work with `visitGEPOfGEP` that does a reverse transformation? // Replace: gep (gep %P, long B), long A, ... // With:T = long A+B; gep %P, T, ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1556

[clang] [clang-cl] Document behavior difference of strict aliasing in clang-cl vs clang. (PR #68460)

2023-10-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Add an user note to pass -fstrict-aliasing explicitly for clang-cl at optimization levels O3 and below to enable TBAA. Also add help text for -f[no-]strict-aliasing. --- Full diff: https://github.com/llvm/llvm-project/pull/68460.diff 2 F

[clang] [clang-cl] Document behavior difference of strict aliasing in clang-cl vs clang. (PR #68460)

2023-10-06 Thread Huihui Zhang via cfe-commits
https://github.com/huihzhang created https://github.com/llvm/llvm-project/pull/68460 Add an user note to pass -fstrict-aliasing explicitly for clang-cl at optimization levels O3 and below to enable TBAA. Also add help text for -f[no-]strict-aliasing. >From 866ebc3da4208f2be206cc9839fc06d689d9b

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

2023-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. This is finding lots of real issues in code, which is awesome, but could I request that this be put under a separate warning flag so we can toggle off just the new functionality and turn it on as we clean our codebase? Repository: rG LLVM Github Monorepo CHANGES SI

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-06 Thread via cfe-commits
goldsteinn wrote: > Since the langref definition is based on GEP, can we use index width instead > of pointer width? If you disagree with this, it would still be good if you > could add a test where the datalayout has index width < pointer width to show > the current semantics. Any target inm

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
Artem-B wrote: Found another issue. We merge four independent byte loads with `align 1` into a 32-bit load, which fails at runtime on misaligned pointers. ``` %t0 = type { [17 x i8] } @shared_storage = linkonce_odr local_unnamed_addr addrspace(3) global %t0 undef, align 1 define <4 x i8> @i

[clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
Artem-B wrote: Found another issue. We merge four independent byte loads with `align 1` into a 32-bit load, which fails at runtime on misaligned pointers. ``` %t0 = type { [17 x i8] } @shared_storage = linkonce_odr local_unnamed_addr addrspace(3) global %t0 undef, align 1 define <4 x i8> @i

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
@@ -6171,6 +6171,9 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "bit-field %0 (

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
vabridgers wrote: Updates - Moved check to a subcat of conversion - Added release notes - Updated diagnostic message https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] 285ab3e - [clang] Fix tests build after 537344fc

2023-10-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-10-06T15:49:57-07:00 New Revision: 285ab3e936018c8f46594f721a9a2d2a45a0597d URL: https://github.com/llvm/llvm-project/commit/285ab3e936018c8f46594f721a9a2d2a45a0597d DIFF: https://github.com/llvm/llvm-project/commit/285ab3e936018c8f46594f721a9a2d2a45a0597d.diff L

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/68276 >From becc33800464287379f7d42955637a10487a22da Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 5 Oct 2023 02:39:12 +0200 Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types W

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-10-06 Thread James Y Knight via cfe-commits
@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-10-06 Thread James Y Knight via cfe-commits
@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-10-06 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/66576 >From 209a8f9c06a7633737e9f022bc4e61d580ad95e7 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Sat, 16 Sep 2023 12:32:21 + Subject: [PATCH 1/5] [libcxx] Allow string to use SSO in constant evaluation. P

[PATCH] D157331: [clang] Implement C23

2023-10-06 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/test/C/C2x/n2683_2.c:5-6 +#include +#include +// CHECK-LABEL: define dso_local void @test_add_overflow_to64( +// CHECK-SAME: ) #[[ATTR0:[0-9]+]] { jrtc27 wrote: > UTC won't insert such a blank line if it doesn't e

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-06 Thread Richard Howell via cfe-commits
rmaz wrote: How about the updated approach? This will use a different include dir based on if the header is a builtin header name or not, which also solves the issue of having to pass the extra include path to the frontend. https://github.com/llvm/llvm-project/pull/68023 __

[clang] [RISCV][GlobalISel] Select G_FRAME_INDEX (PR #68254)

2023-10-06 Thread Craig Topper via cfe-commits
https://github.com/topperc requested changes to this pull request. Missing test for register bank selection https://github.com/llvm/llvm-project/pull/68254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-06 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From 9d5ae4b53558614bdf9681bbefd02cf04aeb107b Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] add module builtin headers relative to resource dir When inc

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-06 Thread Richard Howell via cfe-commits
https://github.com/rmaz edited https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

2023-10-06 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From d824f3839d34b0d043469c95cff4c146124b3666 Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] add module builtin headers relative to resource dir When inc

[clang] 28e8ade - [clang] Fix build after 537344fc

2023-10-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-10-06T15:08:06-07:00 New Revision: 28e8ade041d04ba1847d7b05f56b0b2632471169 URL: https://github.com/llvm/llvm-project/commit/28e8ade041d04ba1847d7b05f56b0b2632471169 DIFF: https://github.com/llvm/llvm-project/commit/28e8ade041d04ba1847d7b05f56b0b2632471169.diff L

[clang] 531233d - Revert "add support for riscv64"

2023-10-06 Thread Haowei Wu via cfe-commits
Author: Haowei Wu Date: 2023-10-06T14:56:16-07:00 New Revision: 531233d4b099835a3b384456c2c22453010f9780 URL: https://github.com/llvm/llvm-project/commit/531233d4b099835a3b384456c2c22453010f9780 DIFF: https://github.com/llvm/llvm-project/commit/531233d4b099835a3b384456c2c22453010f9780.diff LOG

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 537344f - [clang][modules] Move `SLocEntry` search into `ASTReader` (#66966)

2023-10-06 Thread via cfe-commits
Author: Jan Svoboda Date: 2023-10-06T14:52:19-07:00 New Revision: 537344fc502474545d332bf5592db257cc568250 URL: https://github.com/llvm/llvm-project/commit/537344fc502474545d332bf5592db257cc568250 DIFF: https://github.com/llvm/llvm-project/commit/537344fc502474545d332bf5592db257cc568250.diff L

[clang] 8eff5e4 - Add '-p' argument to mkdir in test so that it does not give an error if the directory already exists.

2023-10-06 Thread Douglas Yung via cfe-commits
Author: Douglas Yung Date: 2023-10-06T14:50:22-07:00 New Revision: 8eff5e4b696d2b70e46bcea7a81288a823906f20 URL: https://github.com/llvm/llvm-project/commit/8eff5e4b696d2b70e46bcea7a81288a823906f20 DIFF: https://github.com/llvm/llvm-project/commit/8eff5e4b696d2b70e46bcea7a81288a823906f20.diff

[PATCH] D145214: [TSAN] add support for riscv64

2023-10-06 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. Hi, I believe you forgot to add `tsan_rtl_riscv64.S` to your patch when you land it. We are seeing build errors on our bots with following messages: -- Configuring done (12.3s) CMake Error at /b/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cm

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,1248 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3 +; ## Support i16x2 instructions +; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda -mcpu=sm_90 -mattr=+ptx80 \ +; RUN: -O0 -disable-post-ra -frame-pointer=

[clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-10-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5d2a7101b72a8cae8c4c1f7a11ede7f656efd583 58763b6dcc5682636073a22a574f85b19fce9e70 --

[clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,1248 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3 +; ## Support i16x2 instructions +; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda -mcpu=sm_90 -mattr=+ptx80 \ +; RUN: -O0 -disable-post-ra -frame-pointer=

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

2023-10-06 Thread via cfe-commits
https://github.com/michaelrj-google closed https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] daca972 - [clang-tidy][libc] Fix namespace check with macro (#68134)

2023-10-06 Thread via cfe-commits
Author: michaelrj-google Date: 2023-10-06T14:06:22-07:00 New Revision: daca97216cf132d733513f992d49e3c722aabf40 URL: https://github.com/llvm/llvm-project/commit/daca97216cf132d733513f992d49e3c722aabf40 DIFF: https://github.com/llvm/llvm-project/commit/daca97216cf132d733513f992d49e3c722aabf40.di

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

2023-10-06 Thread via cfe-commits
@@ -45,18 +46,21 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function is a m

[clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-10-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Changes Add output backend that can be used to virtualize outputs from all LLVM based tools. This can easily allow functions like: * redirect the compiler output * duplicating the compiler output * output to memory instead of to file system

[PATCH] D145214: [TSAN] add support for riscv64

2023-10-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0a8245b0fe: add support for riscv64 (authored by alexfanqi, committed by AdityaK <1894981+hiradi...@users.noreply.github.com>). Changed prior to commit: https://reviews.llvm.org/D145214?vs=557362&id=

[clang] cd0a824 - add support for riscv64

2023-10-06 Thread via cfe-commits
Author: Alex Fan Date: 2023-10-06T13:48:48-07:00 New Revision: cd0a8245b0feb951569eb3d396a1ff629daeb55c URL: https://github.com/llvm/llvm-project/commit/cd0a8245b0feb951569eb3d396a1ff629daeb55c DIFF: https://github.com/llvm/llvm-project/commit/cd0a8245b0feb951569eb3d396a1ff629daeb55c.diff LOG:

[clang] [mlir][sparse] introduce MapRef, unify conversion/codegen for reader (PR #68360)

2023-10-06 Thread Aart Bik via cfe-commits
https://github.com/aartbik closed https://github.com/llvm/llvm-project/pull/68360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/66636 >From 39744e6eb218ae519bcce83d90273296de496d94 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 25 Aug 2023 14:07:32 -0400 Subject: [PATCH] [clang] remove ClassScopeFunctionSpecializationDecl ---

[libunwind] [RISCV][GlobalISel] Select G_FRAME_INDEX (PR #68254)

2023-10-06 Thread Nitin John Raj via cfe-commits
https://github.com/nitinjohnraj updated https://github.com/llvm/llvm-project/pull/68254 >From 7a21ee374f2762d0b3b8a68b25be6ac1a71f3cfd Mon Sep 17 00:00:00 2001 From: Nitin John Raj Date: Tue, 3 Oct 2023 09:40:22 -0700 Subject: [PATCH 1/4] [RISCV][GlobalISel] Select G_FRAME_INDEX --- .../RISCV

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread Erich Keane via cfe-commits
erichkeane wrote: If Aaron doesn't get to it, feel free to ping me on Monday. Its too late on a Friday for me to be able to merge this for you, but monday morning would be fine for me. https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7050ff4615d7341eab7fca821b061b3fe3dd4bd8 cc76b72371488fba04915132f3ffd8496891c193 --

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/66636 >From 4ea4e89cb47ed7e4d3f1cf2a9d99d2f7e9ad33bb Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 25 Aug 2023 14:07:32 -0400 Subject: [PATCH] [clang] remove ClassScopeFunctionSpecializationDecl ---

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/66636 >From 9a8db570fab063209a7998bbf631765419034d74 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 25 Aug 2023 14:07:32 -0400 Subject: [PATCH 1/5] [clang] remove ClassScopeFunctionSpecializationDecl

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-06 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @AaronBallman I don't have write access, so that would be appreciated 🙂. I was putting off rebasing incase there were more responses to my comments, but I presume that there won't be so I will get it rebased now https://github.com/llvm/llvm-project/pull/66636

[clang] 5009d24 - [Basic] Fix a warning

2023-10-06 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-06T13:07:53-07:00 New Revision: 5009d249a5ef6548182256ce3e8ece55e8c68987 URL: https://github.com/llvm/llvm-project/commit/5009d249a5ef6548182256ce3e8ece55e8c68987 DIFF: https://github.com/llvm/llvm-project/commit/5009d249a5ef6548182256ce3e8ece55e8c68987.diff L

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-06 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/67673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-06 Thread Nick Desaulniers via cfe-commits
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::De

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-06 Thread Nick Desaulniers via cfe-commits
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::De

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-10-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-10-06 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Something got screwed up when I tried to squash all but the first commit together. I put it back together manually. The NFC commit was pushed as 9500616, the functional stuff squashed and committed as 71d83bb. https://github.com/llvm/llvm-project/pull/67684 __

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-10-06 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Something got screwed up when I tried to squash all but the first commit together. I put it back together manually. The NFC commit was pushed as 9500616, the functional stuff squashed and committed as 71d83bb. https://github.com/llvm/llvm-project/pull/67684 __

[clang-tools-extra] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-10-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 71d83bb - Add -fkeep-system-includes modifier for -E

2023-10-06 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2023-10-06T12:55:48-07:00 New Revision: 71d83bb426104fb77605382c61968aaf55b537b8 URL: https://github.com/llvm/llvm-project/commit/71d83bb426104fb77605382c61968aaf55b537b8 DIFF: https://github.com/llvm/llvm-project/commit/71d83bb426104fb77605382c61968aaf55b537b8.diff

[clang] 9500616 - [NFC] Change a reference member to pointer

2023-10-06 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2023-10-06T12:55:48-07:00 New Revision: 9500616a049995c0d23e070534a41b2ddbec1495 URL: https://github.com/llvm/llvm-project/commit/9500616a049995c0d23e070534a41b2ddbec1495 DIFF: https://github.com/llvm/llvm-project/commit/9500616a049995c0d23e070534a41b2ddbec1495.diff

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-06 Thread via cfe-commits
antangelo wrote: > This seems reasonable, however it needs a release note. Thanks for the review! I've added a release note to the C++ bugfix section https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
@@ -6171,6 +6171,9 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "bit-field %0 (

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Benjamin Kramer via cfe-commits
https://github.com/d0k approved this pull request. https://github.com/llvm/llvm-project/pull/67866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Benjamin Kramer via cfe-commits
https://github.com/d0k approved this pull request. https://github.com/llvm/llvm-project/pull/67866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0dfb5da - [clang][modules] Remove preloaded SLocEntries from PCM files (#66962)

2023-10-06 Thread via cfe-commits
Author: Jan Svoboda Date: 2023-10-06T12:50:16-07:00 New Revision: 0dfb5dadc6df0fdc1a25b02921d1faa3d955cd5d URL: https://github.com/llvm/llvm-project/commit/0dfb5dadc6df0fdc1a25b02921d1faa3d955cd5d DIFF: https://github.com/llvm/llvm-project/commit/0dfb5dadc6df0fdc1a25b02921d1faa3d955cd5d.diff L

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

2023-10-06 Thread Christoph Rüthing via Phabricator via cfe-commits
kolrami added a comment. Hi @cjdb , I would be interested in this change also since GCC supports the same sarif-stderr and sarif-file options. Is there a further plan that it might be integrated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14528

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-06 Thread via cfe-commits
https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/68379 >From e4f4a7bbaad90103e87ad6e6ba80f10fad1e0b58 Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Thu, 5 Oct 2023 21:07:37 -0400 Subject: [PATCH 1/2] [clang][Sema] Use original template pattern when decl

[PATCH] D145214: [TSAN] add support for riscv64

2023-10-06 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larg

[clang-tools-extra] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-10-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/67684 >From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 27 Sep 2023 15:30:52 -0700 Subject: [PATCH 1/5] [NFC] Change a reference member to pointer This will allow th

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

2023-10-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/67684 >From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 27 Sep 2023 15:30:52 -0700 Subject: [PATCH 1/5] [NFC] Change a reference member to pointer This will allow th

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

2023-10-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a16b51 - Make -frewrite-includes put an endif at the end of the included text (#67613)

2023-10-06 Thread via cfe-commits
Author: Paul T Robinson Date: 2023-10-06T12:27:07-07:00 New Revision: 4a16b51f438ad2827220bd21799bfee5ff3d55ef URL: https://github.com/llvm/llvm-project/commit/4a16b51f438ad2827220bd21799bfee5ff3d55ef DIFF: https://github.com/llvm/llvm-project/commit/4a16b51f438ad2827220bd21799bfee5ff3d55ef.dif

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-06 Thread Alexander Richardson via cfe-commits
@@ -44,12 +44,8 @@ BACKDEPLOYMENT_PARAMETERS = [ config.substitutions.append(('%{flags}', '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else '' )) -config.substitutions.append(('%{compile_flags}', -'-nostdinc++ -I %{include} -I %{libcxx}/test/su

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
Artem-B wrote: > > I see one suspicious failure in tensorflow tests. I suspect I've messed > > something up in v4i8 comparison. > > Yup, there is a problem: > > ``` > Successfully custom legalized node > ... replacing: t10: v4i8 = BUILD_VECTOR Constant:i16<-128>, > Constant:i16<-128>, Consta

[clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
Artem-B wrote: > > I see one suspicious failure in tensorflow tests. I suspect I've messed > > something up in v4i8 comparison. > > Yup, there is a problem: > > ``` > Successfully custom legalized node > ... replacing: t10: v4i8 = BUILD_VECTOR Constant:i16<-128>, > Constant:i16<-128>, Consta

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-06 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67201 >From 6fba1ce12731a7b81384a3aea5422419c7ecb335 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 6 Sep 2023 11:41:56 -0700 Subject: [PATCH] [libunwind][libc++][libc++abi] Add cross-compilation flags t

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

2023-10-06 Thread Andy Kaylor via cfe-commits
@@ -1309,6 +1309,13 @@ void Sema::ActOnPragmaFPReassociate(SourceLocation Loc, bool IsEnabled) { CurFPFeatures = NewFPFeatures.applyOverrides(getLangOpts()); } +void Sema::ActOnPragmaFPReciprocal(SourceLocation Loc, bool IsEnabled) { andykaylor wrote: Ther

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
@@ -2150,58 +2179,94 @@ NVPTXTargetLowering::LowerCONCAT_VECTORS(SDValue Op, SelectionDAG &DAG) const { return DAG.getBuildVector(Node->getValueType(0), dl, Ops); } -// We can init constant f16x2 with a single .b32 move. Normally it +// We can init constant f16x2/v2i16/v4i

[clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
@@ -2150,58 +2179,94 @@ NVPTXTargetLowering::LowerCONCAT_VECTORS(SDValue Op, SelectionDAG &DAG) const { return DAG.getBuildVector(Node->getValueType(0), dl, Ops); } -// We can init constant f16x2 with a single .b32 move. Normally it +// We can init constant f16x2/v2i16/v4i

[clang] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for bare kernel (PR #68373)

2023-10-06 Thread Shilei Tian via cfe-commits
shiltian wrote: > I think the follow up, to force the user bound for bare kernels, make sense. > I am not sold on this patch though. Why would we disallow users to do the > same looping we do in the deviceRTL while hoping the offload runtime will > pick a good grid size? Because we don't have

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-06 Thread Stella Laurenzo via cfe-commits
stellaraccident wrote: Thank you for the revert. We were failing on assertion when integrating this patch: ``` iree-compile: /home/stella/megabump/work/iree/third_party/llvm-project/llvm/include/llvm/Support/Casting.h:566: decltype(auto) llvm::cast(const From &) [To = mlir::LLVM::LLVMPointerT

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B deleted https://github.com/llvm/llvm-project/pull/67866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B deleted https://github.com/llvm/llvm-project/pull/67866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NVPTX] Improve lowering of v4i8 (PR #67866)

2023-10-06 Thread Artem Belevich via cfe-commits
@@ -2150,58 +2179,94 @@ NVPTXTargetLowering::LowerCONCAT_VECTORS(SDValue Op, SelectionDAG &DAG) const { return DAG.getBuildVector(Node->getValueType(0), dl, Ops); } -// We can init constant f16x2 with a single .b32 move. Normally it +// We can init constant f16x2/v2i16/v4i

  1   2   3   >