[libunwind] [libunwind] Add Unwind-wasm.c to CMakeLists.txt (PR #67770)

2023-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3f8d4a8ef21dce88de0f79140556771d37944d19 3277e2c8058c5d9b0afcc073d711646ebbf7ed62 --

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/10] Introduce PagedVector class

[libunwind] [libunwind] Add Unwind-wasm.c to CMakeLists.txt (PR #67770)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Changes This was missing when the file was added. --- Full diff: https://github.com/llvm/llvm-project/pull/67770.diff 2 Files Affected: - (modified) libunwind/src/CMakeLists.txt (+1) - (modified) libunwind/src/Unwind-wasm.c (+2-1) ``

[libunwind] [libunwind] Add Unwind-wasm.c to CMakeLists.txt (PR #67770)

2023-09-28 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin created https://github.com/llvm/llvm-project/pull/67770 This was missing when the file was added. >From 3277e2c8058c5d9b0afcc073d711646ebbf7ed62 Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Thu, 28 Sep 2023 23:43:26 -0700 Subject: [PATCH] [libunwind] Add Unwind-wa

[clang] Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (PR #67667)

2023-09-28 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda closed https://github.com/llvm/llvm-project/pull/67667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3f8d4a8 - Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (#67667)

2023-09-28 Thread via cfe-commits
Author: Jakub Chlanda Date: 2023-09-29T08:39:31+02:00 New Revision: 3f8d4a8ef21dce88de0f79140556771d37944d19 URL: https://github.com/llvm/llvm-project/commit/3f8d4a8ef21dce88de0f79140556771d37944d19 DIFF: https://github.com/llvm/llvm-project/commit/3f8d4a8ef21dce88de0f79140556771d37944d19.diff

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

2023-09-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D145843#4221826 , @nridge wrote: > Thanks for the clarification and suggested formulation. > > In D145843#4209750 , @sammccall > wrote: > >> I'd suggest something like: >> >> Style: >

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Changes Projects can now add config fragments like this to their .clangd: ```yaml Style: QuotedHeaders: "src/.*" AngledHeaders: ["path/sdk/.*", "third-party/.*"] ``` to force headers inserted via the --header-insertion=iwyu mode matching at

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread Timm Baeder via cfe-commits
tbaederr wrote: I've pushed https://github.com/llvm/llvm-project/commit/38018ecf965fda81d15edfb904b5b28adb6051b0 since, so you could remove the `CUR_INTERP` stuff from there and get a new test case for free. https://github.com/llvm/llvm-project/pull/67722 _

[clang] -fsanitize=alignment: check memcpy/memmove arguments (PR #67766)

2023-09-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/67766 >From b1201f3fd4d758b739b04e3d5e474549917added Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 28 Sep 2023 15:22:38 -0700 Subject: [PATCH] -fsanitize=alignment: check memcpy/memmove arguments Similar to h

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

2023-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66862 >From f2b9dec7ccf73258eb74c1823e4a954a459b5d51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 20 Sep 2023 08:18:51 +0200 Subject: [PATCH] [clang][Interp] Zero-init remaining string liter

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

2023-09-28 Thread Timm Baeder via cfe-commits
@@ -858,8 +858,8 @@ bool ByteCodeExprGen::VisitStringLiteral(const StringLiteral *E) { // If the initializer string is too long, a diagnostic has already been // emitted. Read only the array length from the string literal. - unsigned N = - std::min(unsigned(CAT->get

[clang] [clang] Support fixed point type mangling (PR #67750)

2023-09-28 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/67750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=alignment: check memcpy/memmove arguments (PR #67766)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Similar to https://reviews.llvm.org/D9673, emit -fsanitize=alignment check for arguments of builtin memcpy and memmove functions to catch misaligned load like: ``` // Check a void unaligned_load(int *a, void *b) { memcpy(a, b, sizeof(*a)); }

[clang] -fsanitize=alignment: check memcpy/memmove arguments (PR #67766)

2023-09-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/67766 Similar to https://reviews.llvm.org/D9673, emit -fsanitize=alignment check for arguments of builtin memcpy and memmove functions to catch misaligned load like: ``` // Check a void unaligned_load(int *a, void *b) {

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-09-28 Thread Brad Smith via cfe-commits
brad0 wrote: @MaskRay Can you comment on the -Bdynamic part? Is that appropriate for relocatable linking? https://github.com/llvm/llvm-project/pull/67254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Driver] Hook up Haiku ARM support (PR #67222)

2023-09-28 Thread Brad Smith via cfe-commits
brad0 wrote: @MaskRay https://github.com/llvm/llvm-project/pull/67222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread via cfe-commits
isuckatcs wrote: Removed `Interp/` changes. https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/67722 >From fb0bf2fcc9d873ce9cf4269cfb6de8786ac6f343 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 28 Sep 2023 20:43:23 +0200 Subject: [PATCH 1/3] [clang] Fix a cras

[clang] 38018ec - [clang][Interp][NFC] Add a failing test case for ArrayInitLoopExprs

2023-09-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-29T07:04:31+02:00 New Revision: 38018ecf965fda81d15edfb904b5b28adb6051b0 URL: https://github.com/llvm/llvm-project/commit/38018ecf965fda81d15edfb904b5b28adb6051b0 DIFF: https://github.com/llvm/llvm-project/commit/38018ecf965fda81d15edfb904b5b28adb6051b0.diff LO

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread Timm Baeder via cfe-commits
tbaederr wrote: Remove the `Interp/` changes please, I'll have a look at that later. https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue unresolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: ExprConstant changes LGTM. I don't have state on the Interp changes; someone else should review that. https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-repl] Emit const variables only once (PR #65257)

2023-09-28 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,29 @@ +// UNSUPPORTED: system-aix +// RUN: cat %s | clang-repl | FileCheck %s +// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s + +extern "C" int printf(const char*, ...); + vgvassilev wrote: Can you add a case for a file scope constant? We also sho

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue resolved https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 9c8e6c71084e1f0e7a96987b7aa2d251b02bea48 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 1/2] [clang][MBD] set up module build daemon infrastructure The modu

[clang] b251897 - Re-apply "[ORC] Add N_SO and N_OSO stabs entries to MachO debug..." with fixes.

2023-09-28 Thread Lang Hames via cfe-commits
Author: Lang Hames Date: 2023-09-28T21:34:14-07:00 New Revision: b2518971d82331b09d7630ac1aecbb49e876a496 URL: https://github.com/llvm/llvm-project/commit/b2518971d82331b09d7630ac1aecbb49e876a496 DIFF: https://github.com/llvm/llvm-project/commit/b2518971d82331b09d7630ac1aecbb49e876a496.diff LO

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-28 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > I guess this ends up producing a CK_NoOp CastExpr? That's probably okay, but > can we amend the documentation for CK_NoOp to give this as an example? Done https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing li

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-28 Thread Dmitry Vyukov via Phabricator via cfe-commits
dvyukov accepted this revision. dvyukov added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE

[clang] [clang][ExprConst] Don't create useless temporary variable (PR #67716)

2023-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Don't create useless temporary variable (PR #67716)

2023-09-28 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ah, didn't realize that. We should have a test case for this. https://github.com/llvm/llvm-project/pull/67716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-28 Thread via cfe-commits
@@ -47,7 +47,11 @@ struct __libcpp_datasizeof { }; #endif kasuga-fj wrote: Done. Thanks https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-28 Thread via cfe-commits
https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246 >From cc6f7f7cb125f544de708830b3a9c0f39745ed1f Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/8] [Clang] Fix missing diagnostic for non-standard layout

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-28 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,18 @@ +// Check that clang invocation can spawn and handshake with module build daemon + +// REQUIRES: !system-windows + +// RUN: if pgrep -f "cc1modbuildd mbd-handshake"; then pkill -f "cc1modbuildd mbd-handshake"; fi +// RUN: rm -rf mbd-handshake %t ---

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread via cfe-commits
https://github.com/isuckatcs resolved https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread via cfe-commits
@@ -10950,6 +10950,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( } bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { + + FullExpressionRAII Scope(Info); + isuckatcs wrote: I added your second testcase to the patc

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

2023-09-28 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/67722 >From fb0bf2fcc9d873ce9cf4269cfb6de8786ac6f343 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 28 Sep 2023 20:43:23 +0200 Subject: [PATCH 1/3] [clang] Fix a cras

[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

2023-09-28 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert accepted this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. Got it, so it's because we want to work on a different fact set than what `BuildLockset` holds. Yeah, I think this makes sense. And after all the methods aren't too far away from

[clang] [clang] Support fixed point type mangling (PR #67750)

2023-09-28 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: This patch is *primarily* adding support for fixed-point types to C++, which seems like it ought to be in the PR title. With that said, I don't have any objection to either the goal or the implementation. https://github.com/llvm/llvm-project/pull/67750 _

[clang] [clang-repl] Emit const variables only once (PR #65257)

2023-09-28 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: ping @vgvassilev https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b191ff0 - [clang] Fix -Wunused-variable in ASTContext.cpp (NFC)

2023-09-28 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2023-09-29T08:38:13+08:00 New Revision: b191ff01dc337e9a44e422b47cdc6d013cdf4bcf URL: https://github.com/llvm/llvm-project/commit/b191ff01dc337e9a44e422b47cdc6d013cdf4bcf DIFF: https://github.com/llvm/llvm-project/commit/b191ff01dc337e9a44e422b47cdc6d013cdf4bcf.diff LOG: [

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Changes - [Inliner] Regen checks for old test; NFC - [Clang][X86] Split some tests for c/cpp; NFC - [Inliner] Use "best" ret attribute when propagating attributes during inlining - [Inliner] Also propagate `noundef` and `align` ret attributes

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

2023-09-28 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-28 Thread via cfe-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-28 Thread via cfe-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang][RelativeVTables] Make the rtti_proxy LinkOnceODR instead of External linkage (PR #67755)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes This way, it the rtti_proxies can be candidates for being replaced altogether with GOTPCREL relocations because they are discardable. Functionally, this shouldn't change the final ELF linkage of the proxies. --- Full diff: https:/

[clang] [clang][RelativeVTables] Make the rtti_proxy LinkOnceODR instead of External linkage (PR #67755)

2023-09-28 Thread via cfe-commits
PiJoules wrote: This can be landed independently of https://github.com/llvm/llvm-project/pull/67754 but we'll really only see it's intended use with https://github.com/llvm/llvm-project/pull/67754. https://github.com/llvm/llvm-project/pull/67755 ___

[clang] [clang][RelativeVTables] Make the rtti_proxy LinkOnceODR instead of External linkage (PR #67755)

2023-09-28 Thread via cfe-commits
https://github.com/PiJoules created https://github.com/llvm/llvm-project/pull/67755 This way, it the rtti_proxies can be candidates for being replaced altogether with GOTPCREL relocations because they are discardable. Functionally, this shouldn't change the final ELF linkage of the proxies. >

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-09-28 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 557473. void added a comment. Add a "FIXME" to improve the diagnostics with a typo hint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/docs/ReleaseNotes

[clang] 06721bb - [clang] implement common sugared type of inst-dependent DecltypeType (#67739)

2023-09-28 Thread via cfe-commits
Author: Matheus Izvekov Date: 2023-09-29T02:22:50+02:00 New Revision: 06721bb8b4a95efaf0d0b2d6d1bd2256f8e24c60 URL: https://github.com/llvm/llvm-project/commit/06721bb8b4a95efaf0d0b2d6d1bd2256f8e24c60 DIFF: https://github.com/llvm/llvm-project/commit/06721bb8b4a95efaf0d0b2d6d1bd2256f8e24c60.dif

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

2023-09-28 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

2023-09-28 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir edited https://github.com/llvm/llvm-project/pull/67742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

2023-09-28 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. Comment in the test needs a fix, but otherwise LGTM https://github.com/llvm/llvm-project/pull/67742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

2023-09-28 Thread Ben Langmuir via cfe-commits
@@ -179,6 +179,46 @@ TEST(FileEntryTest, DenseMapInfo) { EXPECT_TRUE(Set.find(R1)->isSameRef(R1)); EXPECT_TRUE(Set.find(R2)->isSameRef(R2)); } + + // Insert R1Also second and confirm R1 "wins" when looked up as FileEntry. benlangmuir wrote: This com

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

2023-09-28 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: For what it's worth, until recently there was almost no **use** of the implicit unique file semantics for FileEntryRef even though the DenseMapInfo had been available for a long time. But okay, I see there are more uses now so this is not the right place to push back on tha

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

2023-09-28 Thread Kazushi Marukawa via cfe-commits
@@ -2213,12 +2210,12 @@ bool tools::GetSDLFromOffloadArchive( // Wrapper function used by driver for adding SDLs during link phase. void tools::AddStaticDeviceLibsLinking(Compilation &C, const Tool &T, -const JobAction &JA, kaz7

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

2023-09-28 Thread Kazushi Marukawa via cfe-commits
https://github.com/kaz7 updated https://github.com/llvm/llvm-project/pull/67671 >From 80e49b131f2a00d8eb71e7d23652870b53603a37 Mon Sep 17 00:00:00 2001 From: "Kazushi (Jam) Marukawa" Date: Thu, 28 Sep 2023 19:25:09 +0900 Subject: [PATCH] [Clang][VE] Correct rpath handling on VE Add rpath for li

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-09-28 Thread Bill Wendling via Phabricator via cfe-commits
void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4246 +private: + SourceRange countedByFieldLoc; +public: aaron.ballman wrote: > void wrote: > > aaron.ballman wrote: > > > void wrote: > > > > erichkeane wrote: > > > > > aaron

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

2023-09-28 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I understand your concern, we should definitely look into this. However, I think the inode uniquing functionality is pretty fundamental to `FileEntry`, so I'm not sure it's reasonable for type named `FileEntryRef` to do anything else. I guess we could split `FileEntryRef` i

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Stacked, consider only last commit. --- Patch is 28.71 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/67751.diff 6 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+3) - (modified)

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

2023-09-28 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/67751 Stacked, consider only last commit. >From 7009ebf7f2016816b5cbb694e0611cd2a86d7cf1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 28 Sep 2023 22:38:59 +0200 Subject: [PATCH 1/2] [clang] implement com

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2f3b7d33f421b723728262a6978041d93f1f8c5c d2bb8241dfd396c1c77413918f1983b1afe16517 --

[clang] [clang] Support fixed point type mangling (PR #67750)

2023-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2f3b7d33f421b723728262a6978041d93f1f8c5c d92d6d2ba64d9dffad0b5f3aa6f784f8fa2076e6 --

[clang] [clang] Support fixed point type mangling (PR #67750)

2023-09-28 Thread via cfe-commits
https://github.com/PiJoules created https://github.com/llvm/llvm-project/pull/67750 None >From d92d6d2ba64d9dffad0b5f3aa6f784f8fa2076e6 Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Thu, 28 Sep 2023 22:47:23 + Subject: [PATCH] [clang] Support fixed point type mangling --- clang/inclu

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-09-28 Thread kleines Filmröllchen via cfe-commits
https://github.com/kleinesfilmroellchen created https://github.com/llvm/llvm-project/pull/67749 Projects can now add config fragments like this to their .clangd: ```yaml Style: QuotedHeaders: "src/.*" AngledHeaders: ["path/sdk/.*", "third-party/.*"] ``` to force headers inserted via the --

[clang] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

2023-09-28 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir commented: I'm skeptical that treating `FileEntryRef` as `FileEntry *` for the purposes of equality and hashing is a good idea. To me, the obvious interpretation of `FileEntryRef ==` is that the path must be equal, and having it based on the dev/inode is surpris

[clang] [analyzer] Remove inaccurate legacy handling of bad bitwise shifts (PR #66647)

2023-09-28 Thread via cfe-commits
vabridgers wrote: LGTM if ok with everyone. https://github.com/llvm/llvm-project/pull/66647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-28 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Thanks for laying it out. I also find this easier to understand in your latest changes because the comments in `isBeforeInTranslationUnit` lay out the intended ordering without relying on `isInTheSameTranslationUnit` returning `false` for builtin buffers, which is the part t

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf unresolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-28 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/66389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-28 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Closing. I want to achieve this by fixing the underlying issues: * Speeding up `SLocEntry` deserialization (https://github.com/llvm/llvm-project/pull/66962, https://github.com/llvm/llvm-project/pull/66966). * Either adding caching to `DependencyScanningWorkerFilesystem::getR

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/8] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/7] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/6] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

2023-09-28 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >