@@ -52,6 +52,7 @@ set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "")
set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
set(CMAKE_BUILD_TYPE Release CACHE STRING "")
+set(CMAKE_CXX_VISIBILITY_PRESET default CACHE STRING "")
petrhosek wrote:
Should we also set `CMAK
phosek added a comment.
Is it possible to abandon this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152206/new/
https://reviews.llvm.org/D152206
___
cfe-commits mailing list
cfe-commits@lists.ll
phosek added inline comments.
Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:58-59
+
+ // Other UEFI binary subsystems that are currently unsupported:
+ // efi_boot_service_driver, efi_rom, efi_runtime_driver.
+ CmdArgs.push_back("-subsystem:efi_application");
--
@@ -463,3 +463,38 @@ static_assert(bit_cast(ld539) ==
fivehundredandthirtynine, "");
static_assert(round_trip<__int128_t>(34.0L));
#endif
}
+
+namespace test_vector {
+
+typedef unsigned uint2 __attribute__((vector_size(2 * sizeof(unsigned;
+typedef char byte8 __attribute_
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
`isRVVSizelessBuiltinType` and `isRVVType` has the same functionality. This
commit removes the former since we have more variants available in `isRVVType`.
---
Full diff: https://github.com/llvm/llvm-project/pull/67089.diff
5 Files Affec
https://github.com/eopXD created https://github.com/llvm/llvm-project/pull/67089
`isRVVSizelessBuiltinType` and `isRVVType` has the same functionality. This
commit removes the former since we have more variants available in `isRVVType`.
>From 483240e16d800e52783dcfaf52eae81fb1dfca7c Mon Sep 17
@@ -156,10 +156,11 @@ define void @storesTIInit(double %Val) #0 {
; SMALL32: # %bb.0: # %entry
; SMALL32-NEXT:mflr 0
; SMALL32-NEXT:stwu 1, -32(1)
-; SMALL32-NEXT:lwz 3, L..C4(2) # target-flags(ppc-lo) @TIInit
-; SMALL32-NEXT:lwz 4, L..C5(2) # target-flags
kasuga-fj wrote:
Thank you for your review! Here are some comments and my thoughts.
> Note that you should probably rebase your patch onto main and force-push to
> update the PR
Does it mean that I can rebase and force-push since (it should be avoided in
normal case but) this is a special cas
https://github.com/eopXD edited https://github.com/llvm/llvm-project/pull/67018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/eopXD edited https://github.com/llvm/llvm-project/pull/67018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes closed
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Bruno Cardoso Lopes
Date: 2023-09-21T22:52:05-07:00
New Revision: 34415fd611e2d92da570bc4adf931a6410fb406e
URL:
https://github.com/llvm/llvm-project/commit/34415fd611e2d92da570bc4adf931a6410fb406e
DIFF:
https://github.com/llvm/llvm-project/commit/34415fd611e2d92da570bc4adf931a6410fb406e
orcguru wrote:
> The primary advantage of the local-dynamic access method is that you only
> make a single function call to __tls_get_mod() and use the returned pointer
> to get at all TLS variables. This implementation makes a function call for
> every variable. The only thing you've gained i
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/66358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Balazs Benics
Date: 2023-09-22T07:14:32+02:00
New Revision: f90e063308226fae26589fdc97b6eca78edbc463
URL:
https://github.com/llvm/llvm-project/commit/f90e063308226fae26589fdc97b6eca78edbc463
DIFF:
https://github.com/llvm/llvm-project/commit/f90e063308226fae26589fdc97b6eca78edbc463.diff
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/66514
>From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
tbaederr wrote:
> > One of the remaining tests fails because `PP->getIdentifierInfo()` ends up
> > doing external lookup via `ASTReader`, which ends up emitting a diagnos
brad0 wrote:
> Can a Haiku developer confirm that these changes work on Haiku?
I built a few random Haiku apps. Look to be all C++ code. They worked fine.
Same results for both GCC and Clang.
https://github.com/llvm/llvm-project/pull/66038
___
cfe-co
Author: Kazu Hirata
Date: 2023-09-21T21:15:57-07:00
New Revision: 1d0b7b6c8aed0b769f6cb41e09c4e62b618a7037
URL:
https://github.com/llvm/llvm-project/commit/1d0b7b6c8aed0b769f6cb41e09c4e62b618a7037
DIFF:
https://github.com/llvm/llvm-project/commit/1d0b7b6c8aed0b769f6cb41e09c4e62b618a7037.diff
L
orcguru wrote:
> > I tried to parallelize the review effort, but github didn't show the delta
> > for me: #66972
>
> Let's include FE change in this PR.
Thanks! Added clang change.
https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mail
https://github.com/orcguru edited
https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
@sam-mccall gentle ping
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/brad0 resolved
https://github.com/llvm/llvm-project/pull/66038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038
>From 55445ca9ac5e301a6088bdeb3dcd286cc7cdcdc7 Mon Sep 17 00:00:00 2001
From: X512
Date: Mon, 11 Sep 2023 20:56:02 -0400
Subject: [PATCH] [Driver] Implement ToolChain on Haiku
Co-authored-by: David Karoly
Co-autho
@@ -15,30 +15,53 @@
namespace clang {
namespace driver {
+namespace tools {
+
+/// Directly call GNU Binutils assembler and linker
+namespace haiku {
+class LLVM_LIBRARY_VISIBILITY Linker : public Tool {
MaskRay wrote:
`class LLVM_LIBRARY_VISIBILITY Linker fi
@@ -599,15 +599,21 @@ def HasStdExtZvkned :
Predicate<"Subtarget->hasStdExtZvkned()">,
def FeatureStdExtZvknha
: SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true",
"'Zvknha' (Vector SHA-2 (SHA-256 only))">;
-
-def FeatureStdExtZvknhb
MaskRay wrote:
@madscientist
https://github.com/llvm/llvm-project/pull/67084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/67084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/67084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Changes
`-include a.h` probes `a.h.pch` and `a.h.gch`, if not found, falls back to
`a.h`. `.pch` is the preferred extension name. Probing .gch is supposed to
provide compatibility with build systems that do
```
clang -x c-header a.h -o out/a.
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/67084
`-include a.h` probes `a.h.pch` and `a.h.gch`, if not found, falls back to
`a.h`. `.pch` is the preferred extension name. Probing .gch is supposed to
provide compatibility with build systems that do
```
clang -x c
https://github.com/ChuanqiXu9 approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prabhuk updated this revision to Diff 557214.
Prabhuk added a comment.
Handle UEFI64 in X86RegisterInfo for all Win64 equivalent cases except for
Swift and OCL.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159540/new/
https://reviews.llvm.org/D15
dyung added a comment.
Hi @rsmith, we have an internal test where your change seems to have changed
the mangling in C++17 mode and wanted to check if that was intentional.
Consider the following code:
// Literals in templates
#include
template T returnit() {return I;};
enum colour { R
@@ -15,30 +15,53 @@
namespace clang {
namespace driver {
+namespace tools {
+
+/// Directly call GNU Binutils assembler and linker
+namespace haiku {
+class LLVM_LIBRARY_VISIBILITY Linker : public Tool {
brad0 wrote:
I am not sure what you meant by this.
htt
https://github.com/brad0 resolved
https://github.com/llvm/llvm-project/pull/66038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038
>From d40ff6ebfd283701a5bb07695c2aa5a58d3ed703 Mon Sep 17 00:00:00 2001
From: X512
Date: Mon, 11 Sep 2023 20:56:02 -0400
Subject: [PATCH] [Driver] Implement ToolChain on Haiku
Co-authored-by: David Karoly
Co-autho
https://github.com/brad0 resolved
https://github.com/llvm/llvm-project/pull/66038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
zygoloid wrote:
> One of the remaining tests fails because `PP->getIdentifierInfo()` ends up
> doing external lookup via `ASTReader`, which ends up emitting a diagnostic
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/66966
>From d26f9487dedf53ac419cbd9dfb8c29214ba0e09f Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Wed, 20 Sep 2023 17:30:45 -0700
Subject: [PATCH 1/2] [clang][modules] Move `SLocEntry` search into `ASTReader`
hvdijk added a comment.
I do not think there is a sensible way to keep
[`upgrade-datalayout2.ll`](https://github.com/llvm/llvm-project/blob/main/llvm/test/Bitcode/upgrade-datalayout2.ll)
working, with the way the upgrade logic is structured, and we should rethink
that test. The change here inte
@@ -52,6 +52,7 @@ set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "")
set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
set(CMAKE_BUILD_TYPE Release CACHE STRING "")
+set(CMAKE_CXX_VISIBILITY_PRESET default CACHE STRING "")
frobtech wrote:
It merits a comment here
https://github.com/frobtech edited
https://github.com/llvm/llvm-project/pull/67067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frobtech approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/67067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -686,9 +708,11 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure,
than WIN32 */
#define INSTR_PROF_DATA_COMMON __llvm_prf_data
#define INSTR_PROF_NAME_COMMON __llvm_prf_names
+#define INSTR_PROF_VNAME_COMMON __llvm_prf_vnames
david-xl wrote:
@@ -305,13 +320,24 @@ lprofWriteDataImpl(ProfDataWriter *Writer, const
__llvm_profile_data *DataBegin,
/* Write the profile header. */
ProfDataIOVec IOVec[] = {{&Header, sizeof(__llvm_profile_header), 1, 0}};
+ // printf("Size of profile header is %d\n",
+ // (int)(size
@@ -92,6 +92,19 @@ INSTR_PROF_DATA(const uint16_t, Int16ArrayTy,
NumValueSites[IPVK_Last+1], \
/* INSTR_PROF_DATA end. */
+#ifndef INSTR_PROF_VTABLE_DATA
+#define INSTR_PROF_VTABLE_DATA(Type, LLVMType, Name, Initializer)
+#else
+#define INSTR_PROF_VTABLE_DATA_DEFINED
+#endif
@@ -272,18 +279,26 @@ lprofWriteDataImpl(ProfDataWriter *Writer, const
__llvm_profile_data *DataBegin,
const uint64_t NumCounters =
__llvm_profile_get_num_counters(CountersBegin, CountersEnd);
const uint64_t NamesSize = DebugInfoCorrelate ? 0 : NamesEnd - NamesBegin;
@@ -124,9 +124,27 @@ int __llvm_profile_merge_from_buffer(const char
*ProfileData,
SrcCountersEnd = SrcCountersStart +
Header->NumCounters * __llvm_profile_counter_entry_size();
SrcNameStart = SrcCountersEnd;
- SrcValueProfDataStart =
+ // This is to a
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/67066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apolloww wrote:
Thanks for the fix! I think originally the deferred conversion is placed after
`coro.end` so that it won't be counted as "use across suspend point", but it
doesn't stop optimizer from breaking that assumption.
https://github.com/llvm/llvm-project/pull/66706
___
ldionne wrote:
Ok so after scratching my head a bit, I'm actually not certain of how to
proceed with this. I can't find a way to implement `__libcpp_datasizeof` in
libc++ that doesn't involve `offsetof`, so our only option would be to silence
the warning. We could do it like (if we end up doin
Author: Ziqing Luo
Date: 2023-09-21T15:06:22-07:00
New Revision: 700baeb765cfe8628eb68bc24319b3db0209dd84
URL:
https://github.com/llvm/llvm-project/commit/700baeb765cfe8628eb68bc24319b3db0209dd84
DIFF:
https://github.com/llvm/llvm-project/commit/700baeb765cfe8628eb68bc24319b3db0209dd84.diff
LO
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
ziqingluo-90 marked an inline comment as done.
Closed by commit rG700baeb765cf: [-Wunsafe-buffer-usage] Use `Strategy` to
determine whether to fix a parameter (authored
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
There was an issue with relative vtables when two TU's which define the same
vtable object are built with different default visibilities. Some TU's are
built with -fvisibility=hidden in the code base, grep for
CMAKE_CXX_VISIBILITY_PRESET
https://github.com/abrachet updated
https://github.com/llvm/llvm-project/pull/67067
>From 3aa0af93dfe73edd2b6cba62c55e7797320665da Mon Sep 17 00:00:00 2001
From: Alex Brachet
Date: Wed, 20 Sep 2023 17:55:44 -0400
Subject: [PATCH] [Fuchsia] Build with -fvisibility=default
There was an issue wit
https://github.com/abrachet created
https://github.com/llvm/llvm-project/pull/67067
There was an issue with relative vtables when two TU's which define the same
vtable object are built with different default visibilities. Some TU's are
built with -fvisibility=hidden in the code base, grep for
ziqingluo-90 marked an inline comment as done.
ziqingluo-90 added a comment.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2586
#endif
it = FixablesForAllVars.byVar.erase(it);
} else if (Tracker.hasUnclaimedUses(it->first)) {
NoQ wrote:
ldionne wrote:
Note that you should probably rebase your patch onto `main` and force-push to
update the PR. The CI for Clang now runs on Windows from GH PRs as well (it
used not to when you submitted the patch, I think).
https://github.com/llvm/llvm-project/pull/65246
_
ldionne wrote:
I think when the @llvm/pr-subscribers-libcxx group was pinged 2 weeks ago, most
of us didn't have the right GH notifications set up yet and we didn't see it.
Looking now.
https://github.com/llvm/llvm-project/pull/65246
___
cfe-commits
huangjd wrote:
Full profile load is further reduced to 24s after optimizing lazy loading of
name table, which was a bottleneck
https://github.com/llvm/llvm-project/pull/66164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
huangjd wrote:
I will hold on renaming variables to a different patch because this will change
files everywhere, may cause confusion to review in this patch.
https://github.com/llvm/llvm-project/pull/66164
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/67066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/66554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amy Huang
Date: 2023-09-21T14:34:59-07:00
New Revision: 03c698a431b4dc23c2b9de3e9befd1860fef6e80
URL:
https://github.com/llvm/llvm-project/commit/03c698a431b4dc23c2b9de3e9befd1860fef6e80
DIFF:
https://github.com/llvm/llvm-project/commit/03c698a431b4dc23c2b9de3e9befd1860fef6e80.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Changes
This is stacked on top of https://github.com/llvm/llvm-project/pull/66816
Disregard first commit.
---
Full diff: https://github.com/llvm/llvm-project/pull/67066.diff
12 Files Affected:
- (modified) clang/include/clang/AST/Mangle.
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/67066
This is stacked on top of https://github.com/llvm/llvm-project/pull/66816
Disregard first commit.
>From 47bd926491f28f722c429f3ab4a993aa5d85d1b7 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Tue, 19 Sep
@@ -463,3 +463,38 @@ static_assert(bit_cast(ld539) ==
fivehundredandthirtynine, "");
static_assert(round_trip<__int128_t>(34.0L));
#endif
}
+
+namespace test_vector {
+
+typedef unsigned uint2 __attribute__((vector_size(2 * sizeof(unsigned;
+typedef char byte8 __attribute_
https://github.com/ZijunZhaoCCK ready_for_review
https://github.com/llvm/llvm-project/pull/66963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZijunZhaoCCK ready_for_review
https://github.com/llvm/llvm-project/pull/66963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mysterymath added inline comments.
Comment at: llvm/lib/Target/X86/X86CallingConv.td:522
// Mingw64 and native Win64 use Win64 CC
CCIfSubtarget<"isTargetWin64()", CCDelegateTo>,
You'll need to add switching for Win64 here too; this appears to be the
conv
Prabhuk updated this revision to Diff 557203.
Prabhuk added a comment.
Uploading the backend changes correctly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159540/new/
https://reviews.llvm.org/D159540
Files:
llvm/lib/Target/X86/MCTargetDesc/X8
Prabhuk marked an inline comment as done.
Prabhuk added a comment.
Clang Driver Changes - https://reviews.llvm.org/D159541
Current - https://reviews.llvm.org/D152206
X86 Backend changes - https://reviews.llvm.org/D159540
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:/
https://github.com/zygoloid edited
https://github.com/llvm/llvm-project/pull/66894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter {
return true;
}
+ bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) {
+const auto *VT = Ty->castAs();
+unsigned VectorLength = Val.getVectorLength();
+
+if (VT->isExtVectorBoolType()) {
Prabhuk updated this revision to Diff 557202.
Prabhuk added a comment.
Splitting commit into 3 commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152206/new/
https://reviews.llvm.org/D152206
Files:
llvm/lib/Target/X86/MCTargetDesc/X86MCTarge
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter {
return true;
}
+ bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) {
+const auto *VT = Ty->castAs();
+unsigned VectorLength = Val.getVectorLength();
+
+if (VT->isExtVectorBoolType()) {
@@ -8335,6 +8335,26 @@ bool
AArch64InstrInfo::shouldOutlineFromFunctionByDefault(
return MF.getFunction().hasMinSize();
}
+void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB,
bwendling wrote:
I added more context to the commit m
@@ -8335,6 +8335,26 @@ bool
AArch64InstrInfo::shouldOutlineFromFunctionByDefault(
return MF.getFunction().hasMinSize();
}
+void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB,
bwendling wrote:
I added more context to the commit m
https://github.com/bwendling edited
https://github.com/llvm/llvm-project/pull/66958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bwendling edited
https://github.com/llvm/llvm-project/pull/66958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prabhuk created this revision.
Prabhuk added a reviewer: phosek.
Herald added a subscriber: pengfei.
Herald added a project: All.
Prabhuk requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Introduce changes necessary for UEFI X86_64 ta
https://github.com/nickdesaulniers resolved
https://github.com/llvm/llvm-project/pull/66958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nickdesaulniers resolved
https://github.com/llvm/llvm-project/pull/66958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nickdesaulniers edited
https://github.com/llvm/llvm-project/pull/66958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nickdesaulniers edited
https://github.com/llvm/llvm-project/pull/66958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8335,6 +8335,26 @@ bool
AArch64InstrInfo::shouldOutlineFromFunctionByDefault(
return MF.getFunction().hasMinSize();
}
+void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB,
nickdesaulniers wrote:
Ah! Ok, they *why* for this PR
@@ -8335,6 +8335,26 @@ bool
AArch64InstrInfo::shouldOutlineFromFunctionByDefault(
return MF.getFunction().hasMinSize();
}
+void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB,
nickdesaulniers wrote:
Ah! Ok, they *why* for this PR
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo {
"Target didn't implement TargetInstrInfo::insertOutlinedCall!");
}
+ /// Insert an architecture-specific instruction to clear a register.
+ virtual void buildClearRegister(Register Reg, MachineBasi
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo {
"Target didn't implement TargetInstrInfo::insertOutlinedCall!");
}
+ /// Insert an architecture-specific instruction to clear a register.
+ virtual void buildClearRegister(Register Reg, MachineBasi
Prabhuk updated this revision to Diff 557199.
Prabhuk added a comment.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Clang Driver changes for UEFI X86_64
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159540/new/
htt
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo {
"Target didn't implement TargetInstrInfo::insertOutlinedCall!");
}
+ /// Insert an architecture-specific instruction to clear a register.
+ virtual void buildClearRegister(Register Reg, MachineBasi
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo {
"Target didn't implement TargetInstrInfo::insertOutlinedCall!");
}
+ /// Insert an architecture-specific instruction to clear a register.
+ virtual void buildClearRegister(Register Reg, MachineBasi
@@ -7095,6 +7096,45 @@ class APValueToBufferConverter {
return true;
}
+ bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) {
+const auto *VT = Ty->castAs();
+unsigned VectorLength = Val.getVectorLength();
+
+if (VT->isExtVectorBoolType()) {
@@ -8335,6 +8335,26 @@ bool
AArch64InstrInfo::shouldOutlineFromFunctionByDefault(
return MF.getFunction().hasMinSize();
}
+void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB,
bwendling wrote:
Yes, in particular I want to call it
@@ -8335,6 +8335,26 @@ bool
AArch64InstrInfo::shouldOutlineFromFunctionByDefault(
return MF.getFunction().hasMinSize();
}
+void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB,
bwendling wrote:
Yes, in particular I want to call it
aaronpuchert added a comment.
Yeah, we should get this over the line. I'm still not quite sure where to put
the check. Reading @rsmith's comment again, SemaInit might perhaps be
acceptable for now, except that I should add the additional tests (in case we
don't have them already).
I think we a
https://github.com/DaMatrix updated
https://github.com/llvm/llvm-project/pull/66894
>From 61f1f5f7325e7cfea8c04ad5c0dea0fdd8c96ab5 Mon Sep 17 00:00:00 2001
From: DaPorkchop_
Date: Sun, 13 Aug 2023 22:39:12 +0200
Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors
---
clang/lib/A
https://github.com/rnk approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 410 matches
Mail list logo
