[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0b2c88e - [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (#65933)

Author: Owen Pan Date: 2023-09-13T23:57:34-07:00 New Revision: 0b2c88eea7c8c595bc32af114646e15ee69af0fa URL: https://github.com/llvm/llvm-project/commit/0b2c88eea7c8c595bc32af114646e15ee69af0fa DIFF: https://github.com/llvm/llvm-project/commit/0b2c88eea7c8c595bc32af114646e15ee69af0fa.diff LOG:

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

llvmbot wrote: @llvm/pr-subscribers-mlir Changes One of the main user of these kind of coroutines is swift. There yield-once (`retcon.once`) coroutines are used to temporary "expose" pointers to internal fields of various objects creating borrow scopes. However, in some cases

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/antoniofrighetto closed https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

antoniofrighetto wrote: Closing this as landed in 660876a4019b81b5a7427a3dcec5ce8c39cd1ee0. Thanks. https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] 660876a - [clang] Bail out when handling union access with virtual inheritance

Author: Antonio Frighetto Date: 2023-09-14T08:48:59+02:00 New Revision: 660876a4019b81b5a7427a3dcec5ce8c39cd1ee0 URL: https://github.com/llvm/llvm-project/commit/660876a4019b81b5a7427a3dcec5ce8c39cd1ee0 DIFF: https://github.com/llvm/llvm-project/commit/660876a4019b81b5a7427a3dcec5ce8c39cd1ee0.d

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/asl review_requested https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Update Zicntr and Zihpm to version 2p0 (PR #66323)

jacquesguan wrote: > Sorry, that was a mis-statement. There are two counter extensions you are > bumping. > > Anyway, rewording the commit message is a nit from me. OK, I retitle the commit. https://github.com/llvm/llvm-project/pull/66323 ___ cfe-co

[clang] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66055: >From ed5150a69925dc3b6557796026a2820ac5c2e2f5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 12 Sep 2023 14:41:57 +0800 Subject: [PATCH 01/12] add --- .../bugprone/BugproneTidyModule.cpp

[clang] [clang-format] More on unbreakable strings in TypeScript (PR #66321)

https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/66321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Update counters to version 2p0 (PR #66323)

eopXD wrote: Sorry, that was a mis-statement. There are two counter extensions you are bumping. Anyway, rewording the commit message is a nit from me. https://github.com/llvm/llvm-project/pull/66323 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Update counters to version 2p0 (PR #66323)

jacquesguan wrote: > Your commit bumps both the counter and timer extension, which makes your > commit message inaccurate. I think Counters in RISCV ISA include both "Zicntr" and "Zihpm", https://github.com/riscv/riscv-isa-manual/blob/main/src/counters.adoc. https://github.com/llvm/llvm-proje

[clang] [RISCV] Update counters to version 2p0 (PR #66323)

eopXD wrote: Your commit bumps both the counter and timer extension, which makes your commit message inaccurate. https://github.com/llvm/llvm-project/pull/66323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

eopXD wrote: Maybe test coverage? https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/66330.diff 1 Files Affected: - (modified) clang/lib/Headers/CMakeLists.txt (+5) diff --git a/clang/lib/Headers/CMakeLists.txt b/clang/lib/Headers/CMakeLists.

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/4vtomat labeled https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/4vtomat unlabeled https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/66330: None >From 8eb805beb037ba824fdf01dd8528b797a80de7ad Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Wed, 13 Sep 2023 22:59:30 -0700 Subject: [PATCH] [RISCV] Install sifive_vector.h to riscv-resource-headers ---

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/4vtomat review_requested https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. Hi Owen, thanks for reaching out, no. In fact we realized that we don't have enough capacity to be working on it. Best, Henrik - Henrik Lafrenz, Ableton AG Schoenhauser Allee 6-7, 10119 Berlin, Germany T: +49 30 288 763-256 Board: Gerhard Behles, Jan Bohl Supervis

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,66 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to m

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,37 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.h - clang-tidy *- C++ +//-*-===// EugeneZelenko wrote: Please merge with previous line. You could reduce number of `=`. https://github.com/llvm/llvm-project/pull/66055

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,107 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,66 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to m

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,90 @@ +// RUN: %check_clang_tidy %s bugprone-compare-pointer-to-member-virtual-function %t + +struct A { + virtual ~A(); + void f1(); + void f2(); + virtual void f3(); + virtual void f4(); + + void g1(int); +}; + +bool Result; + +void base() { + Result = (&A::f1

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

dyung added a comment. Hi @leonardchan your change was still causing a failure on the PS4 linux bot, so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 . I noticed earlier that the failing test omit-rtti-component-wi

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/shafik commented: If the function is `constexpr` do we treat it as a VLA? https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -9843,30 +9833,44 @@ class Sema final { /// diagnostics that will be suppressed. std::optional isSFINAEContext() const; - /// Determines whether we are currently in a context that - /// is not evaluated as per C++ [expr] p5. - bool isUnevaluatedContext() const { + /

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041: >From fd7138ee568d0a46a71a7f4e268ecd491e600b31 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivale

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -13928,7 +13930,7 @@ static bool CheckTautologicalComparison(Sema &S, BinaryOperator *E, return false; IntRange OtherValueRange = GetExprRange( - S.Context, Other, S.isConstantEvaluated(), /*Approximate*/ false); + S.Context, Other, S.isConstantEvaluatedCon

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -13928,7 +13930,7 @@ static bool CheckTautologicalComparison(Sema &S, BinaryOperator *E, return false; IntRange OtherValueRange = GetExprRange( - S.Context, Other, S.isConstantEvaluated(), /*Approximate*/ false); + S.Context, Other, S.isConstantEvaluatedCon

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -14143,8 +14145,9 @@ static void AnalyzeComparison(Sema &S, BinaryOperator *E) { } // Otherwise, calculate the effective range of the signed operand. - IntRange signedRange = GetExprRange( - S.Context, signedOperand, S.isConstantEvaluated(), /*Approximate*/ true)

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -15159,16 +15163,16 @@ static void CheckImplicitConversion(Sema &S, Expr *E, QualType T, IntRange SourceTypeRange = IntRange::forTargetOfCanonicalType(S.Context, Source); - IntRange LikelySourceRange = - GetExprRange(S.Context, E, S.isConstantEvaluated(), /*A

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -15090,8 +15093,9 @@ static void CheckImplicitConversion(Sema &S, Expr *E, QualType T, if (SourceBT && TargetBT && SourceBT->isIntegerType() && TargetBT->isFloatingType() && !IsListInit) { // Determine the number of precision bits in the source integer type. -

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

@@ -214,6 +214,16 @@ class StmtComparer { return E1->size() == E2->size(); } + bool IsStmtEquivalent(const DeclRefExpr *DRE1, const DeclRefExpr *DRE2) { +auto *Decl1 = DRE1->getDecl(); +auto *Decl2 = DRE2->getDecl(); mzyKi wrote: ```cpp /// Det

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

https://github.com/mshockwave approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16970 + OS << '\''; + WriteCharValueForDiagnostic(CodeUnit, BTy, TyWidth, OS); + OS << "' (0x" To have the diagnostic printer handle separating any

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

FreddyLeaf wrote: Here's the change for 512 variants before: https://reviews.llvm.org/D66786 https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

llvmbot wrote: @llvm/pr-subscribers-clang Changes For *_stream_* series intrinsics. -- Full diff: https://github.com/llvm/llvm-project/pull/66310.diff 10 Files Affected: - (modified) clang/lib/Headers/avx2intrin.h (+1-1) - (modified) clang/lib/Headers/avxintrin.h (+3-3) - (m

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf created https://github.com/llvm/llvm-project/pull/66310: For *_stream_* series intrinsics. >From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Thu, 14 Sep 2023 09:17:39 +0800 Subject: [PATCH] [X86] Align 128/256 variants

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added a comment. Herald added a reviewer: MyDeveloperDay. @hel-ableton do you intend to continue working on this? If not, we can commandeer it and finish or abandon it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 _

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

alexfh wrote: Unfortunately, this is not enough. I found at least one more broken case (pun intended): ``` export type LooongTypeName = ''|('BB'); ``` gets transformed into ``` export type LooongTypeName = ''|('B' +

[clang] e16474b - Revert "Revert "[clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used""

Author: Leonard Chan Date: 2023-09-14T00:00:50Z New Revision: e16474ba2cba8fa69b413a83852d06c93155f8c9 URL: https://github.com/llvm/llvm-project/commit/e16474ba2cba8fa69b413a83852d06c93155f8c9 DIFF: https://github.com/llvm/llvm-project/commit/e16474ba2cba8fa69b413a83852d06c93155f8c9.diff LOG:

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:2250 +def fexperimental_omit_rtti_component : + Flag<["-"], "fexperimental-omit-rtti-component">, + Group, Flags<[CC1Option]>, phosek wrote: > I think the name should signal th

[clang] 87e11ec - Revert "[clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used"

Author: Leonard Chan Date: 2023-09-13T23:55:05Z New Revision: 87e11ecbaec95d8411d1b332d6d88d458b408739 URL: https://github.com/llvm/llvm-project/commit/87e11ecbaec95d8411d1b332d6d88d458b408739 DIFF: https://github.com/llvm/llvm-project/commit/87e11ecbaec95d8411d1b332d6d88d458b408739.diff LOG:

[PATCH] D135341: adds `__reference_constructs_from_temporary`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3b0b417143: [clang] adds `__reference_constructs_from_temporary` (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 8f3b0b4 - [clang] adds `__reference_constructs_from_temporary`

Author: Christopher Di Bella Date: 2023-09-13T23:51:43Z New Revision: 8f3b0b4171431ced5550d5c8a70d1b683343f062 URL: https://github.com/llvm/llvm-project/commit/8f3b0b4171431ced5550d5c8a70d1b683343f062 DIFF: https://github.com/llvm/llvm-project/commit/8f3b0b4171431ced5550d5c8a70d1b683343f062.dif

[PATCH] D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza added a comment. @gribozavr2 - ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158532/new/ https://reviews.llvm.org/D158532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/include/clang/AST/Decl.h:4272-4275 +FieldDecl *FD = nullptr; +for (FieldDecl *Field : fields()) + FD = Field; +return FD; aaron.ballman wrote: > Could this be implemented as: `return !field_empty() ?

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556734. void marked 36 inline comments as done. void added a comment. Added more error messages. Changed some code around to align with coding practices. Added some more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D127270: [clang-format] Add space in placement new expression

owenpan added inline comments. Herald added a reviewer: rymiel. Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), - AfterRequi

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake] Add VE cache file (PR #65921)

kaz7 wrote: Add a comment to the cache file and rebase. https://github.com/llvm/llvm-project/pull/65921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake] Add VE cache file (PR #65921)

https://github.com/kaz7 updated https://github.com/llvm/llvm-project/pull/65921: >From 7c1a3ccb7977781ec8b45f4c230520abeca907f5 Mon Sep 17 00:00:00 2001 From: "Kazushi (Jam) Marukawa" Date: Mon, 11 Sep 2023 11:46:56 +0900 Subject: [PATCH] [CMake] Add VE cache file Add VE cache file for the ease

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c8c075e - [MS] Follow up fix to pass aligned args to variadic x86_32 functions (#65692)

Author: Reid Kleckner Date: 2023-09-13T16:29:11-07:00 New Revision: c8c075e8769a615451653b37e5426eb5d7a1d16c URL: https://github.com/llvm/llvm-project/commit/c8c075e8769a615451653b37e5426eb5d7a1d16c DIFF: https://github.com/llvm/llvm-project/commit/c8c075e8769a615451653b37e5426eb5d7a1d16c.diff

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk resolved https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

llvmbot wrote: @llvm/pr-subscribers-clang Changes MSVC allows users to pass structures with required alignments greater than 4 to variadic functions. It does not pass them indirectly to correctly align them. Instead, it passes them directly with the usual 4 byte stack alignment

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

@@ -812,11 +815,13 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState &State, } llvm::IntegerType *PaddingType = NeedsPadding ? Int32 : nullptr; -// Pass over-aligned aggregates on Windows indirectly. This behavior was -// added in MSVC 201

[clang-tools-extra] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/65692: >From 98d560c8057b171c81b43d93c1a0c26f1d27cf5b Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 29 Aug 2023 14:26:10 -0700 Subject: [PATCH 1/2] [MS] Follow up fix to pass aligned args to variadic x86_32 funct

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

owenpan added a comment. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. It seems that this patch caused a regression. See https://github.com/llvm/llvm-project/issues/62768. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review conta

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6385c1df919f: [clang] Add experimental option to omit the RTTI component from the vtable when… (authored by leonardchan). Changed prior to commit:

[clang] 6385c1d - [clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

Author: Leonard Chan Date: 2023-09-13T23:15:50Z New Revision: 6385c1df919f237d4149fabf542a158f61010bf8 URL: https://github.com/llvm/llvm-project/commit/6385c1df919f237d4149fabf542a158f61010bf8 DIFF: https://github.com/llvm/llvm-project/commit/6385c1df919f237d4149fabf542a158f61010bf8.diff LOG:

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -214,14 +214,14 @@ class LLVM_MemcpyIntrOpBase : /*requiresAccessGroup=*/1, /*requiresAliasAnalysis=*/1> { dag args = (ins Arg:$dst, Arg:$src, - AnySignlessInteger:$len, I1Attr:$isVolatile); urnathan wrote: thanks, l

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget &Subtarget, return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4645381 , @Jake-Egan wrote: > @jansvoboda11 Actually, we could give you access to an AIX machine to debug > this. Would that work for you? Hi, I'd be happy to try that! Repository: rG LLVM Github Monorepo CH

  1   2   3   4   5   >