[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + bool IsUnwindTablesDefault(const llvm::opt::ArgList &Args) const

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/65329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/owenca review_request_removed https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

@@ -209,14 +212,16 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult &Result) { // main file. if (auto Replacement = HeaderIncludes.insert(llvm::StringRef{Spelling}.trim("\"<>"), danix800 wrote: `HeaderIncludes` is NOT a co

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/danix800 edited https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

@@ -199,6 +199,9 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult &Result) { tooling::HeaderIncludes HeaderIncludes(getCurrentMainFile(), Code, FileStyle->IncludeStyle); + // `tooling::HeaderIncludes::insert` will n

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

@@ -209,14 +212,16 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult &Result) { // main file. if (auto Replacement = HeaderIncludes.insert(llvm::StringRef{Spelling}.trim("\"<>"), PiotrZSL wrote: insert -> emplace https://g

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 976dbae - [libunwind] Haiku: Initial support

Author: Trung Nguyen Date: 2023-09-06T00:56:09-04:00 New Revision: 976dbae2463804869004daef5a7effc72268204f URL: https://github.com/llvm/llvm-project/commit/976dbae2463804869004daef5a7effc72268204f DIFF: https://github.com/llvm/llvm-project/commit/976dbae2463804869004daef5a7effc72268204f.diff

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

danix800 added a comment. Duplicated to https://github.com/llvm/llvm-project/pull/65431, abandon this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159263/new/ https://reviews.llvm.org/D159263 ___ c

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

danix800 wrote: Please refer to https://reviews.llvm.org/D159263 about `areDiagsSelfContained`. https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/65431: `HeaderIncludes` won't update `ExistingIncludes` during inserting. We need to manage it in tidy check. Fixed: #65285 >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Ca

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -17,7 +17,7 @@ struct Base { int x; }; struct Derived : Base { int y; }; int o = __builtin_offsetof(Derived, x); // expected-warning{{offset of on non-POD type}} -const int o2 = sizeof(__builtin_offsetof(Derived, x)); +const int o2 = sizeof(__builtin_offsetof(Derived, x));

[clang] clang-linker-wrapper/LinkerWrapperOpts.td: "--sysroot" => "--sysroot=" (PR #65313)

https://github.com/MaskRay approved this pull request. Long options separated by a space are not common and newer driver options prefer `=`. There is no compatibility concern for this internal tool spawned by clang. So LGTM https://github.com/llvm/llvm-project/pull/65313 __

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/6] [Clang] Fix missing diagnostic for non-standard layout

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65429: None >From 57a72b3867aa9fb99372cea73866cede4ab45a75 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 5 Sep 2023 18:04:46 -0700 Subject: [PATCH] [clang-format] Fix broken dump_format_help.py and sync the RST f

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG400d3261a0da: [HLSL] Cleanup support for `this` as an l-value (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 400d326 - [HLSL] Cleanup support for `this` as an l-value

Author: Chris Bieneman Date: 2023-09-05T19:38:50-05:00 New Revision: 400d3261a0da56554aee8e5a2fbc27eade9d05db URL: https://github.com/llvm/llvm-project/commit/400d3261a0da56554aee8e5a2fbc27eade9d05db DIFF: https://github.com/llvm/llvm-project/commit/400d3261a0da56554aee8e5a2fbc27eade9d05db.diff

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/compnerd review_requested https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/compnerd labeled https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

@@ -131,3 +144,20 @@ // CHECK-ARM64-MINGW: #define _WIN64 1 // CHECK-ARM64-MINGW: #define __GCC_ASM_FLAG_OUTPUTS__ 1 // CHECK-ARM64-MINGW: #define __aarch64__ 1 + +// RUN: %clang_cc1 -triple arm64ec-windows-gnu %s -E -dM -o - \ +// RUN: | FileCheck -match-full-lines %s --chec

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

@@ -792,11 +793,11 @@ void clang::TextNodeDumper::dumpNestedNameSpecifier(const NestedNameSpecifier *N OS << " '" << NNS->getAsIdentifier()->getName() << "'"; break; case NestedNameSpecifier::Namespace: - OS << " Namespace"; + OS << " "; // "Namespace

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/shafik commented: LGTM but we should test all changes. https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129050: [clang-format] Update documentation

Herald added a subscriber: wangpc. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi review_requested https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi review_requested https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

jrtc27 wrote: > So it looks like some of these changes undo some of the change introduced by > @mizvekov in some tests. Maybe @zygoloid or @AaronBallman has some more input > here. Do you have a pointer to such changes? https://github.com/llvm/llvm-project/pull/65214 _

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

shafik wrote: So it looks like some of these changes undo some of the change introduced by @mizvekov in some tests. Maybe @zygoloid or @AaronBallman has some more input here. https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing lis

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi review_requested https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi labeled https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

mpaszkowski accepted this revision. mpaszkowski added a comment. This revision is now accepted and ready to land. @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I think that this solution despite being a "hack" seems to be the most straightforward. Eventual differences

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

emaste added a comment. Looks like this still needs someone to push it -- @brooks if you rebase and send to GitHub I cna pick it up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

shafik added a comment. I think this looks good but I would like @tahonermann to review this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 ___ cfe-c

[clang] 3e19b10 - Partial revert of b0cbf3a0dac5

Author: Bill Wendling Date: 2023-09-05T16:18:20-07:00 New Revision: 3e19b10b02a72c21c3961fbfd3a0aa86dbe60c70 URL: https://github.com/llvm/llvm-project/commit/3e19b10b02a72c21c3961fbfd3a0aa86dbe60c70 DIFF: https://github.com/llvm/llvm-project/commit/3e19b10b02a72c21c3961fbfd3a0aa86dbe60c70.diff

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From 968fc04bc9bdcc33bb3f9401073343d2f69369f3 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 1 Sep 2023 15:07:23 -0700 Subject: [PATCH 1/5] [llvm][adt] Implement `IntrusiveRefCntPtr::unique()` ---

[PATCH] D135115: [clang-format] update --files help description

Herald added a subscriber: wangpc. Herald added a reviewer: rymiel. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or

[clang] 2a702ec - Use unsigned types for __popc/__popcll to match their declarations in CUDA headers.

Author: Artem Belevich Date: 2023-09-05T16:02:42-07:00 New Revision: 2a702eca3efa066e3a470cd3b17082a05e118c91 URL: https://github.com/llvm/llvm-project/commit/2a702eca3efa066e3a470cd3b17082a05e118c91 DIFF: https://github.com/llvm/llvm-project/commit/2a702eca3efa066e3a470cd3b17082a05e118c91.diff

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/bylaws review_requested https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/bylaws review_requested https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/bylaws created https://github.com/llvm/llvm-project/pull/65420: The ARM64EC ABI requires that struct layouts match between regular x86_64 code and ARM64EC code. Ensure this is always the case by defining the same set of macros as are set when targeting x86_64 but with the ad

[clang] [clang][deps] Optimize command line generation (PR #65412)

jansvoboda11 wrote: > > There are places in Clang where we store the result of the const function > > in some kind of long-lived data structure, and someplace else modify the > > result of the non-const function, expecting the change to be reflected. > > I would be comfortable with this, becau

[PATCH] D159435: [NFC] remove unneded header includes

JDevlieghere added a comment. This breaks the LLDB (modules) build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/59738/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159435/new/ https://reviews.llvm.org/D159435 __

[clang] [clang][deps] Optimize command line generation (PR #65412)

benlangmuir wrote: > There are places in Clang where we store the result of the const function in > some kind of long-lived data structure, and someplace else modify the result > of the non-const function, expecting the change to be reflected. I would be comfortable with this, because you woul

[clang] [clang][deps] Optimize command line generation (PR #65412)

jansvoboda11 wrote: I did, but decided against it. There are places in Clang where we store the result of the const function in some kind of long-lived data structure, and someplace else modify the result of the non-const function, expecting the change to be reflected. I wanted to make the se

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

sunfish added a comment. I believe wasi-sdk doesn't have this issue, because it has modifications to all headers which define NULL to always use the NULL defined in stddef.h, and it doesn't ship musl's stddef.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D148381: [Clang] Add counted_by attribute

void updated this revision to Diff 555946. void added a comment. Update documentation. Cribbed off of Qing Zhao's GCC implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include

[clang] 28b4155 - [docs] Mention that function multi-versioning using target_version is also fixed

Author: Fangrui Song Date: 2023-09-05T15:05:11-07:00 New Revision: 28b4155c87c7d09db01e0d2a10be5bbffd982f13 URL: https://github.com/llvm/llvm-project/commit/28b4155c87c7d09db01e0d2a10be5bbffd982f13 DIFF: https://github.com/llvm/llvm-project/commit/28b4155c87c7d09db01e0d2a10be5bbffd982f13.diff

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:208 (`#61334 `_) +- For function multi-versioning using the ``target`` or ``target_clones`` + attributes, remove comdat for internal linkage functions. --

[clang] [clang][deps] Optimize command line generation (PR #65412)

benlangmuir wrote: I haven't dug into this in depth yet, but did you consider keeping the normal function names for the `const` versions and only rename the mutating ones? My thinking is you could use `CowCompilerInvocation` as a drop-in replacement for `CompilerInvocation` in immutable settin

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

dalias added a comment. To be clear, musl does not support this regardless of whether `#include_next` is being used "right" or not. The only supported thing is not mixing headers at all. If Emscripten and wasi are using musl-based headers, it probably makes sense for these targets to do the sa

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From 968fc04bc9bdcc33bb3f9401073343d2f69369f3 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 1 Sep 2023 15:07:23 -0700 Subject: [PATCH 1/5] [llvm][adt] Implement `IntrusiveRefCntPtr::unique()` ---

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From 968fc04bc9bdcc33bb3f9401073343d2f69369f3 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 1 Sep 2023 15:07:23 -0700 Subject: [PATCH 1/6] [llvm][adt] Implement `IntrusiveRefCntPtr::unique()` ---

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

dschuff added a comment. Although having said all that, I guess a question for @aaron.ballman or other clang header experts: It does seem that many std C headers in clang are designed to handle this kind of case using `include_next` (e.g. stdint.h and stdatomic.h) but not all of them (e.g. stdd

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

dschuff added a comment. The 2 common WebAssembly toolchain variants (Emscripten and wasi-sdk) use libcs that are derived from musl (a subset along with additions specific to their environments); they share the system-include configuration in `WebAssembly::AddClangSystemIncludeArgs()` in `clan

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

dschuff added subscribers: sbc100, sunfish. dschuff added a comment. The 2 common WebAssembly toolchain variants (Emscripten and wasi-sdk) use libcs that are derived from musl (a subset along with additions specific to their environments); they share the system-include configuration in `WebAsse

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. In D157913#4638569 , @phosek wrote: > In D157913#4626007 , @zequanwu > wrote: > >>> It seems that the `__llvm_prf_names` is retained in this mode. What is the >>> overhead of this secti

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rG666098c5b3ea: [Headers] Remove musl-related comment about NULL (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/ https://revi

[clang] 666098c - [Headers] Remove musl-related comment about NULL

Author: Heejin Ahn Date: 2023-09-05T13:29:02-07:00 New Revision: 666098c5b3ea6e01ffe9e827064c26dfaaf9c655 URL: https://github.com/llvm/llvm-project/commit/666098c5b3ea6e01ffe9e827064c26dfaaf9c655 DIFF: https://github.com/llvm/llvm-project/commit/666098c5b3ea6e01ffe9e827064c26dfaaf9c655.diff LO

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/65412: This PR speeds up the dependency scanner by optimizing how it generates command lines for discovered modular dependencies. This now happens lazily based on copy-on-write `CompilerInvocation` objects. >Fro

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Optimize command line generation (PR #65412)

https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2030-2031 + bool EnabledForTarget = TEntry->second; + if (EnabledForTarget != EnabledForFunc) +return; +} jmmartinez wrote: > arsenm wrote: > > Early return breaks the ot

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added inline comments. Comment at: compiler-rt/lib/xray/xray_trampoline_riscv32.S:54 + // Handler address will be null if it is not set + beq a2, x0, FunctionEntry_restore + MaskRay wrote: > This local symbol doesn't seem useful. We can j

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 555925. ashwin98 marked an inline comment as done. ashwin98 added a comment. Sorry for the delay in getting back to you. I've updated the NOP sled generation and tested it out, it now seems to work with compressed instructions - the patched sleds were ident

[clang] e76d4fd - [clang][arcmt] NFCI: Change invocation const-ness

Author: Jan Svoboda Date: 2023-09-05T13:23:54-07:00 New Revision: e76d4fddcbbe2f60e24dbe048ca50e130260edee URL: https://github.com/llvm/llvm-project/commit/e76d4fddcbbe2f60e24dbe048ca50e130260edee DIFF: https://github.com/llvm/llvm-project/commit/e76d4fddcbbe2f60e24dbe048ca50e130260edee.diff L

[clang] 8e0c9bb - [clang] NFCI: Change returned AnalyzerOptions smart pointer to reference

Author: Jan Svoboda Date: 2023-09-05T13:23:53-07:00 New Revision: 8e0c9bb91f484b7d2fa86c01919d96a41a7071d7 URL: https://github.com/llvm/llvm-project/commit/8e0c9bb91f484b7d2fa86c01919d96a41a7071d7 DIFF: https://github.com/llvm/llvm-project/commit/8e0c9bb91f484b7d2fa86c01919d96a41a7071d7.diff L

[clang] 5746002 - [clang] NFCI: Change returned LanguageOptions pointer to reference

Author: Jan Svoboda Date: 2023-09-05T13:23:53-07:00 New Revision: 5746002ebb9c3d02be408edf13c2edc39aecf591 URL: https://github.com/llvm/llvm-project/commit/5746002ebb9c3d02be408edf13c2edc39aecf591 DIFF: https://github.com/llvm/llvm-project/commit/5746002ebb9c3d02be408edf13c2edc39aecf591.diff L

[PATCH] D159421: [NFC] Remove unneeded header includes

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d6283fd0901: [NFC] Remove unneeded header includes (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159421/new/ https://reviews.llvm.org/D

[PATCH] D159435: [NFC] remove unneded header includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0cbf3a0dac5: [NFC] remove unneded header includes (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 7d6283f - [NFC] Remove unneeded header includes

Author: Bill Wendling Date: 2023-09-05T13:12:00-07:00 New Revision: 7d6283fd09016fda711a3ad211be7d25336dabc6 URL: https://github.com/llvm/llvm-project/commit/7d6283fd09016fda711a3ad211be7d25336dabc6 DIFF: https://github.com/llvm/llvm-project/commit/7d6283fd09016fda711a3ad211be7d25336dabc6.diff

[clang] b0cbf3a - [NFC] remove unneded header includes

Author: Bill Wendling Date: 2023-09-05T13:12:01-07:00 New Revision: b0cbf3a0dac51d426dd38c307f745e74f409aed7 URL: https://github.com/llvm/llvm-project/commit/b0cbf3a0dac51d426dd38c307f745e74f409aed7 DIFF: https://github.com/llvm/llvm-project/commit/b0cbf3a0dac51d426dd38c307f745e74f409aed7.diff

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

jhuber6 wrote: The `libc` tests will need to be updated as well. I'll need to look into that. https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

https://github.com/saiislam review_requested https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >