[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/65301: The shape of certain elements of the AST can vary depending on the langugage. We currently only support C++. >From fc120d9d9df7cb02008f578219afb6a7d1977b83 Mon Sep 17 00:00:00 2001 From: Martin Braenne Da

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

tbaeder added a comment. I thought this review wasn't clear at all on what's supposed to happen but since https://reviews.llvm.org/D157072 is going nowhere, I'll just push this one in the next few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb50c87d1e63f: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction… (authored by burakemir, committed by mboehme). Repositor

[clang] b50c87d - [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

Author: Burak Emir Date: 2023-09-05T06:23:04Z New Revision: b50c87d1e63f187105b5b73f7add37717ccce7f6 URL: https://github.com/llvm/llvm-project/commit/b50c87d1e63f187105b5b73f7add37717ccce7f6 DIFF: https://github.com/llvm/llvm-project/commit/b50c87d1e63f187105b5b73f7add37717ccce7f6.diff LOG: [c

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:840 -if (S->Scope == "std::" && S->Name == "move") { - if (!S->Signature.contains(',')) -return ""; - return ""; -} - -if (auto StdSym = tooling::stdl

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf updated this revision to Diff 555805. qiucf added a comment. - Add macro alias to `mffs` `mffsl` `mtfsf` and `set_fpscr_rn`, although they don't work in freestanding mode - Add C++ run lines to intrinsics tests. To avoid further messing codegen checks, make them run under `-fsyntax-only`.

[PATCH] D159397: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a73e1eb47dd: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[clang] 0a73e1e - [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc

Author: Brad Smith Date: 2023-09-05T01:06:43-04:00 New Revision: 0a73e1eb47ddc87fad51c390b4a8e20019614a08 URL: https://github.com/llvm/llvm-project/commit/0a73e1eb47ddc87fad51c390b4a8e20019614a08 DIFF: https://github.com/llvm/llvm-project/commit/0a73e1eb47ddc87fad51c390b4a8e20019614a08.diff LO

[PATCH] D159412: [analyzer]FieldRegion in getStaticSize should return size of pointee type

jcsxky added a comment. In D159412#4636813 , @donat.nagy wrote: > Please add a testcase that demonstrates this issue (fails when your change in > MemRegion.cpp isn't added) and shows that your commit fixes it. Thanks for your advice. We use this api i

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

metaflow wrote: alright, build has been triggered successfully! thank you <3 https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/5] [Clang] Fix missing diagnostic for non-standard layout

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh resolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh resolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh resolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1362206 - [clang-format][doc] Fix the doc format

Author: sstwcw Date: 2023-09-05T03:39:24Z New Revision: 1362206e8ad3ec70603d4cdb78d1d4c7b9cb0528 URL: https://github.com/llvm/llvm-project/commit/1362206e8ad3ec70603d4cdb78d1d4c7b9cb0528 DIFF: https://github.com/llvm/llvm-project/commit/1362206e8ad3ec70603d4cdb78d1d4c7b9cb0528.diff LOG: [clang

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

This revision was automatically updated to reflect the committed changes. Closed by commit rG082c5d7f63c4: [PowerPC] Implement builtin for mffsl (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158065/new/ https://reviews.llvm.org/

[clang] 082c5d7 - [PowerPC] Implement builtin for mffsl

Author: Qiu Chaofan Date: 2023-09-05T11:22:09+08:00 New Revision: 082c5d7f63c490af69e8280e5b5ff6bf6051bd59 URL: https://github.com/llvm/llvm-project/commit/082c5d7f63c490af69e8280e5b5ff6bf6051bd59 DIFF: https://github.com/llvm/llvm-project/commit/082c5d7f63c490af69e8280e5b5ff6bf6051bd59.diff L

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGddc80637ccbc: [clang-format] Break long string literals in C#, etc. (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D154093?vs=553729&id=555795#toc Repository: rG LLVM Github

[clang] ddc8063 - [clang-format] Break long string literals in C#, etc.

Author: sstwcw Date: 2023-09-05T03:19:49Z New Revision: ddc80637ccbc5be26ae40f01841c6019a38d1955 URL: https://github.com/llvm/llvm-project/commit/ddc80637ccbc5be26ae40f01841c6019a38d1955 DIFF: https://github.com/llvm/llvm-project/commit/ddc80637ccbc5be26ae40f01841c6019a38d1955.diff LOG: [clang

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ef5217b - [clang][Diagnostics] Fix wrong line number display (#65238)

Author: Takuya Shimizu Date: 2023-09-05T12:12:42+09:00 New Revision: ef5217b3c0dcbb58927fe43400b6d1faa677bf98 URL: https://github.com/llvm/llvm-project/commit/ef5217b3c0dcbb58927fe43400b6d1faa677bf98 DIFF: https://github.com/llvm/llvm-project/commit/ef5217b3c0dcbb58927fe43400b6d1faa677bf98.diff

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555794. brad edited the summary of this revision. brad added a comment. Separate out the GCC path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clan

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG880f39af6115: [Clang] Enable AIX initial-exec TLS mode (authored by qiucf). Repository: rG LLVM Github Monorepo CHAN

[clang] 880f39a - [Clang] Enable AIX initial-exec TLS mode

Author: Qiu Chaofan Date: 2023-09-05T10:57:37+08:00 New Revision: 880f39af6115184ccd1950ff263b7c43993cd438 URL: https://github.com/llvm/llvm-project/commit/880f39af6115184ccd1950ff263b7c43993cd438 DIFF: https://github.com/llvm/llvm-project/commit/880f39af6115184ccd1950ff263b7c43993cd438.diff L

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

hazohelet wrote: Adding an irrelevant new line in a modified test file would suffice to trigger the CI build. Force-pushing doesn't seem to be desirable during code review. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list c

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/3] [clang][MSExtentions] Fix invalid overload failure about

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

kasuga-fj wrote: Ah, thanks. Then what should I do? Can I make another commit with the same content as the last commit and force push? (sorry, I don't fully understand the LLVM's PR rules) https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commi

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 555789. felix642 added a comment. Reworded release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h cla

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 555788. felix642 added a comment. Added entry to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

hazohelet wrote: FWIW, an empty commit didn't trigger CI correctly yesterday, so pushing a non-empty commit might fix the CI issue. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. If a parameter value is eith

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555785. brad added a comment. Add some C++ header path tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/tes

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

kasuga-fj wrote: @metaflow I added an empty commit and the build was triggered, but it still failed. Could you help me? https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555783. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/test/Driver/haiku.c cla

[PATCH] D159435: [NFC] remove unneded header includes

void created this revision. void added reviewers: nickdesaulniers, aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. This time from clang/Pa

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/4] [Clang] Fix missing diagnostic for non-standard layout

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -1199,6 +1199,15 @@ template <> struct DocumentListTraits> { return Seq[Index]; } }; + +template <> struct ScalarEnumerationTraits { + static void enumeration(IO &IO, FormatStyle::GotoLabelIndentation &Value) { +IO.enumCase(Value, "None", FormatStyle::GLI_None);

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/mydeveloperday requested changes to this pull request. I’m not sure I quite understand what you are trying to do here now https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) { CHECK_PARSE_BOOL(IndentAccessModifiers); CHECK_PARSE_BOOL(IndentCaseLabels); CHECK_PARSE_BOOL(IndentCaseBlocks); - CHECK_PARSE_BOOL(IndentGotoLabels); + CHECK_PARSE_ENUM(IndentGotoLabels,

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2421,20 +2421,28 @@ struct FormatStyle { /// Indent goto labels. /// - /// When ``false``, goto labels are flushed left. /// \code - ///true: false: - ///int f() { vs. int f() { - /// if (foo

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

cor3ntin wrote: This looks correct to me, but I'd like @sam-mccall to confirm that it was unintended. Maybe we should keep the old code around as loops tend to share _some_ code and we don't want `if(!!;;)` to crash either https://github.com/llvm/llvm-project/pull/65269 ___

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

ilinpv added inline comments. Comment at: clang/docs/ReleaseNotes.rst:208 (`#61334 `_) +- For function multi-versioning using the ``target`` or ``target_clones`` + attributes, remove comdat for internal linkage functions. ---

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu added a comment. Thanks! Updated the patch. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:650 + assert(FieldsForInit.size() + R->getNumBases() == Inits.size()); + for ([[maybe_unused]] const CXXBaseSpecifier &Base : R->bases()) { +assert(Init

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu updated this revision to Diff 555777. kinu marked 19 inline comments as done. kinu added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/D159284 Files: clang/lib/Analysis/Flow

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

ast added a comment. In D133361#4637008 , @eddyz87 wrote: > In D133361#4629292 , @ast wrote: > >> ... >> Right. Such recursive propagation of PAI is necessary. For btf_tag we cannot >> do it. Always propagating i

[clang] dd27036 - [TableGen] Modernize OverloadInfo (NFC)

Author: Kazu Hirata Date: 2023-09-04T13:35:26-07:00 New Revision: dd27036ff7292c90c4a0e08494579980cfa6922e URL: https://github.com/llvm/llvm-project/commit/dd27036ff7292c90c4a0e08494579980cfa6922e DIFF: https://github.com/llvm/llvm-project/commit/dd27036ff7292c90c4a0e08494579980cfa6922e.diff L

[clang] 77604d2 - [StaticAnalyzer] Modernize ObjCNonNilReturnValueChecker (NFC)

Author: Kazu Hirata Date: 2023-09-04T13:35:25-07:00 New Revision: 77604d2a845217cb6d793530c4819dc63bfd61d3 URL: https://github.com/llvm/llvm-project/commit/77604d2a845217cb6d793530c4819dc63bfd61d3 DIFF: https://github.com/llvm/llvm-project/commit/77604d2a845217cb6d793530c4819dc63bfd61d3.diff L

[clang] 232d29e - [TableGen] Modernize GroupInfo (NFC)

Author: Kazu Hirata Date: 2023-09-04T13:35:23-07:00 New Revision: 232d29ea0bd30ae94c76d48700fa2774b929e984 URL: https://github.com/llvm/llvm-project/commit/232d29ea0bd30ae94c76d48700fa2774b929e984 DIFF: https://github.com/llvm/llvm-project/commit/232d29ea0bd30ae94c76d48700fa2774b929e984.diff L

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``). .. _IndentGotoLabels: -**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶ ` +**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶ ` Indent goto labels. -

[clang] [clang-format] modified goto bool to enum (PR #65140)

varshneydevansh wrote: > Do you actually want to use that feature, or do you only want to work on > something? > As it's something of my past pending task, I'm looking to learn and contribute in any way I can. I left without even trying to contribute to open source codes. =) https://gith

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2421,20 +2421,28 @@ struct FormatStyle { /// Indent goto labels. /// - /// When ``false``, goto labels are flushed left. /// \code - ///true: false: - ///int f() { vs. int f() { - /// if (foo

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) { CHECK_PARSE_BOOL(IndentAccessModifiers); CHECK_PARSE_BOOL(IndentCaseLabels); CHECK_PARSE_BOOL(IndentCaseBlocks); - CHECK_PARSE_BOOL(IndentGotoLabels); + CHECK_PARSE_ENUM(IndentGotoLabels,

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``). .. _IndentGotoLabels: -**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶ ` +**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶ ` Indent goto labels. -

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``). .. _IndentGotoLabels: -**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶ ` +**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶ ` Indent goto labels. -

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2421,20 +2421,28 @@ struct FormatStyle { /// Indent goto labels. /// - /// When ``false``, goto labels are flushed left. /// \code - ///true: false: - ///int f() { vs. int f() { - /// if (foo

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) { CHECK_PARSE_BOOL(IndentAccessModifiers); CHECK_PARSE_BOOL(IndentCaseLabels); CHECK_PARSE_BOOL(IndentCaseBlocks); - CHECK_PARSE_BOOL(IndentGotoLabels); + CHECK_PARSE_ENUM(IndentGotoLabels,

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/HazardyKnusperkeks requested changes to this pull request. Do you actually want to use that feature, or do you only want to work on something? Please take a greater look on how enums are documented, parsed, and tested. A fairly recent example which transitioned from `bool` w

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2432,9 +2431,25 @@ struct FormatStyle { ///label2:label2: /// return 1; return 1; ///} } + /// + ///GLI_HalfIndent: + ///int f() { + /// if

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

ilinpv added a comment. > Offtopic: Outlining atomics seems to be very CPU specific thing. In my > experience LSE were ~= old exclusive semantics. So adding extra call + extra > bit check (too bad IFUNCs are not used :)) each time it would be executed > seems to be quite an extra load (for CPU,

[clang] 8dc789a - [APINotes] Upstream APINotesWriter

Author: Egor Zhdan Date: 2023-09-04T19:45:55+01:00 New Revision: 8dc789a22666f9b9fdde54fda23c9332dbc1db9b URL: https://github.com/llvm/llvm-project/commit/8dc789a22666f9b9fdde54fda23c9332dbc1db9b DIFF: https://github.com/llvm/llvm-project/commit/8dc789a22666f9b9fdde54fda23c9332dbc1db9b.diff LO

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

yota9 added a comment. Also please keep in mind that despite of different behaviour in gcc/clang not implying outline atomics won't result in any problems, but implying them in cases where we don't want them might result in some problems. Offtopic: Outlining atomics seems to be very CPU specifi

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -105,6 +110,40 @@ class APINotesWriter::Implementation { llvm::SmallVector, 1>> Typedefs; + /// Retrieve the ID for the given identifier. + IdentifierID getIdentifier(StringRef Identifier) { +if (Identifier.empty()) + return 0; + +auto

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/65187: >From a3e72323513a5ac102abb6c28ae4071955cc2373 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 1 Sep 2023 22:07:47 +0100 Subject: [PATCH] [APINotes] Upstream APINotesWriter This upstreams more of the Cla

[PATCH] D159397: [StaticAnalyzer] Use switch statement in MallocChecker::performKernelMalloc. NFC

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It doesn't look much of an improvement TBH, but I won't stand against it either. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159397/ne

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh updated https://github.com/llvm/llvm-project/pull/65140: >From be006b494c4e34463818a7f1fd30cde9282fcea1 Mon Sep 17 00:00:00 2001 From: varshneydevansh Date: Thu, 31 Aug 2023 17:27:58 +0530 Subject: [PATCH 1/3] [clang] modified goto bool to enum --- clang/doc

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd approved this pull request. Would appreciate the removal of the noted unnecessary braces, but LGTM. https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -105,6 +110,40 @@ class APINotesWriter::Implementation { llvm::SmallVector, 1>> Typedefs; + /// Retrieve the ID for the given identifier. + IdentifierID getIdentifier(StringRef Identifier) { +if (Identifier.empty()) + return 0; + +auto

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

sepavloff added inline comments. Comment at: clang/test/CXX/expr/expr.const/p2-0x.cpp:281-283 +constexpr float f10 = f2 - f2; +constexpr float f11 = f2 + f4; +constexpr float f12 = f2 / f2; I don't think silent NaN origination is a right behavior. By

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03a7f15f019: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159

[clang-tools-extra] d03a7f1 - [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

Author: Ivan Murashko Date: 2023-09-04T18:53:49+01:00 New Revision: d03a7f15f019beb1896872ba9321cfed5f16a05f URL: https://github.com/llvm/llvm-project/commit/d03a7f15f019beb1896872ba9321cfed5f16a05f DIFF: https://github.com/llvm/llvm-project/commit/d03a7f15f019beb1896872ba9321cfed5f16a05f.diff

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/vgvassilev approved this pull request. That looks good to me. Can we backport that to the llvm17 release branch? I know at least one downstream project that jumps through hoops to support this. https://github.com/llvm/llvm-project/pull/65257 __

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/cor3ntin approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Don't escape _ in .rst files. (PR #65277)

https://github.com/mordante labeled https://github.com/llvm/llvm-project/pull/65277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Don't escape _ in .rst files. (PR #65277)

https://github.com/mordante review_requested https://github.com/llvm/llvm-project/pull/65277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Mordante added a comment. Herald added subscribers: bviyer, jplehr. For libc++ we like to clean up the review queue for the GitHub PR transition. Is there still interest on working on this patch? If so would it be possible to finish it before the Phabricator is changed to read only mode? CHANG

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -33,6 +33,7 @@ class APINotesWriter::Implementation { /// Mapping from strings to identifier IDs. llvm::StringMap IdentifierIDs; +public: egorzhdan wrote: Reverted this part of the change by making `APINotesWriter` a friend class of `Implementation`

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -19,11 +19,11 @@ namespace clang { namespace api_notes { -class APINotesWriter::Implementation { - template - using VersionedSmallVector = - llvm::SmallVector, 1>; +template +using VersionedSmallVector = +llvm::SmallVector, 1>; egorzhdan wrote:

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/65187: >From a553de6bbcc96f0bbd94859defcb64f2c6dfa0f5 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 1 Sep 2023 22:07:47 +0100 Subject: [PATCH] [APINotes] Upstream APINotesWriter This upstreams more of the Cla

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan edited https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2432,9 +2431,25 @@ struct FormatStyle { ///label2:label2: /// return 1; return 1; ///} } + /// + ///GLI_HalfIndent: + ///int f() { + /// if

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh review_requested https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh review_requested https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh updated https://github.com/llvm/llvm-project/pull/65140: >From be006b494c4e34463818a7f1fd30cde9282fcea1 Mon Sep 17 00:00:00 2001 From: varshneydevansh Date: Thu, 31 Aug 2023 17:27:58 +0530 Subject: [PATCH 1/2] [clang] modified goto bool to enum --- clang/doc

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

cor3ntin wrote: Looks good to me but can you add a release note? This was landed before RC1 and I'm not sure it qualifies for a backport at this stage (@AaronBallman @tru) https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cf

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/cor3ntin approved this pull request. LGTM modulo one nitpick https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

@@ -16,6 +16,7 @@ #include "clang/AST/DeclOpenMP.h" #include "clang/AST/DeclTemplate.h" #include "clang/AST/LocInfoType.h" +#include "clang/AST/NestedNameSpecifier.h" cor3ntin wrote: That does not seem necessary https://github.com/llvm/llvm-project/pull/65266

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/2] [clang][MSExtentions] Fix invalid overload failure about

  1   2   3   >