[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

hazohelet wrote: When the `Loc` is higher than the lowest begin source location, `DisplayLineNo` still points to the lowest begin location line because we have ```c++ DisplayLineNo = std::min(DisplayLineNo, SM.getPresumedLineNumber(I.getBegin())); ``` in L1169, correct? This does not b

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; I think the instructions in this multiclass are the vector variants. Can t

[PATCH] D159264: [clang][dataflow] Remove deprecated synonyms related to `RecordStorageLocation` and `RecordValue`

mboehme added a comment. Failing pre-merge checks look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159264/new/ https://reviews.llvm.org/D159264 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D159262: [clang][dataflow] Eliminate deprecated `ControlFlowContext::build()` overload.

mboehme added a comment. Failing pre-merge checks look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159262/new/ https://reviews.llvm.org/D159262 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

nielx accepted this revision. nielx added a comment. This revision is now accepted and ready to land. Patch looks good to me and in line with previous work that was done on LLVM to run it on Haiku. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1594

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

tbaederr wrote: In 8554a55d041f2c7de329adda538cadf7eeb6e8a8, this was added to fix a range with a lower begin source location than `Loc` is, so I think this change would break that? https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mail

[PATCH] D159261: [clang][dataflow] Eliminate deprecated `DataflowAnalysis` constructor.

mboehme added a comment. Failing pre-merge checks look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159261/new/ https://reviews.llvm.org/D159261 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

cor3ntin wrote: This looks good. My only question is, can `Loc` ever be invalid there, and what happens if it is? https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

cor3ntin wrote: Thanks for working on this. This generally looks good to me. Can you add an entry in clang/docs/ReleaseNotes.rst? Thanks! https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS TransformUtils ) +# Workaround for MSVC ARM64 performance regression: disable all optimizations (/Od) +# and then enable back all /O2 options except one. +if(NOT CMAKE_BUILD_TYPE MATCHES Debug +AND MSVC +AND MSVC_VERSI

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

https://github.com/kasuga-fj edited https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

https://github.com/kasuga-fj review_requested https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

https://github.com/kasuga-fj created https://github.com/llvm/llvm-project/pull/65246: `offsetof` Fixes #64619 Clang warns diagnostic for non-standard layout types in `offsetof` only if they are in evaluated context. With this patch, you'll also get diagnostic if you use `offsetof` on non-st

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

skan added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:271 + // Attach EVEX512 feature when we have AVX512 features and EVEX512 is not set. + size_t posNoEVEX512 = FS.rfind("-evex512"); It seems the change in X86.cpp is redundant? Rep

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

skan added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:275 + size_t posEVEX512 = FS.rfind("+evex512"); + size_t posAVX512F = FS.rfind("+avx512"); + Missing f? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D159373: [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00e54d04ae28: [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be… (authored by kees). Repository: rG LLVM Github Mono

[clang] 00e54d0 - [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

Author: Kees Cook Date: 2023-09-03T22:24:37-07:00 New Revision: 00e54d04ae2802d498741097d4b83e898bc99c5b URL: https://github.com/llvm/llvm-project/commit/00e54d04ae2802d498741097d4b83e898bc99c5b DIFF: https://github.com/llvm/llvm-project/commit/00e54d04ae2802d498741097d4b83e898bc99c5b.diff LOG

[clang] f585b7d - [NFC] Add an overload for getP1689ModuleDependencyFile without output parameters

Author: Chuanqi Xu Date: 2023-09-04T13:22:17+08:00 New Revision: f585b7db07f8b3c69141f3975a94c70f6899f733 URL: https://github.com/llvm/llvm-project/commit/f585b7db07f8b3c69141f3975a94c70f6899f733 DIFF: https://github.com/llvm/llvm-project/commit/f585b7db07f8b3c69141f3975a94c70f6899f733.diff LO

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

@@ -830,6 +831,182 @@ void PrintIRInstrumentation::registerCallbacks( } } +void DumpIRInstrumentation::registerCallbacks( +PassInstrumentationCallbacks &PIC) { + + if (!(shouldDumpBeforeSomePass() || shouldDumpAfterSomePass())) +return; + + this->PIC = &PIC; + + P

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

@@ -830,6 +831,182 @@ void PrintIRInstrumentation::registerCallbacks( } } +void DumpIRInstrumentation::registerCallbacks( +PassInstrumentationCallbacks &PIC) { + + if (!(shouldDumpBeforeSomePass() || shouldDumpAfterSomePass())) +return; + + this->PIC = &PIC; + + P

[clang] [mlir][OpenMP] Added omp.region operation (PR #65243)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/65243: >From ff635ce0ce910f0cde248a4babb3c27333ddc108 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Sun, 3 Sep 2023 22:40:10 -0500 Subject: [PATCH] [mlir][OpenMP] Added omp.region operation This patch adds om

[PATCH] D159412: [analyzer]FieldRegion in getStaticSize should return size of pointee type

jcsxky created this revision. jcsxky added reviewers: steakhal, balazske, aaron.ballman, NoQ. jcsxky added projects: clang, clang-c. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald add

[PATCH] D107115: [CMake][Fuchsia] Use standalone unwinder in Fuchsia toolchain

phosek abandoned this revision. phosek added a comment. Herald added subscribers: ekilmer, abrachet. Herald added a project: All. Superseded by D127887 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107115/new/ ht

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/65238: When the caret location is lower than the lowest source range, clang is printing wrong line numbers. The first line number should consider caret location line even when there are source ranges provided. Curr

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

danix800 added a comment. Ping @kadircet~, could you please take a look at this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159263/new/ https://reviews.llvm.org/D159263 ___ cfe-commits mailin

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 555642. giulianobelinassi added a comment. Apply @erichkeane suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 Files: clang/include/clang/Basic/

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

@@ -677,13 +677,18 @@ void TextNodeDumper::dumpBareType(QualType T, bool Desugar) { ColorScope Color(OS, ShowColors, TypeColor); SplitQualType T_split = T.split(); - OS << "'" << QualType::getAsString(T_split, PrintPolicy) << "'"; + std::string T_str = QualType::getAsSt

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

jrtc27 wrote: > > These are an artifact of how types are structured but serve little > > purpose, merely showing that the type is sugared in some way. For > > example, ElaboratedType's existence means struct S gets printed as > > 'struct S':'struct S' in the AST, which is unnecessary visual clutt

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

@@ -315,12 +315,16 @@ std::string JSONNodeDumper::createPointerRepresentation(const void *Ptr) { llvm::json::Object JSONNodeDumper::createQualType(QualType QT, bool Desugar) { SplitQualType SQT = QT.split(); - llvm::json::Object Ret{{"qualType", QualType::getAsString(SQT,

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS TransformUtils ) +# Workaround for MSVC ARM64 performance regression: disable all optimizations (/Od) lxbndr wrote: I was not sure if the link is acceptable to mention there. Will do, thanks! https://github.co

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS TransformUtils ) +# Workaround for MSVC ARM64 performance regression: disable all optimizations (/Od) +# and then enable back all /O2 options except one. +if(NOT CMAKE_BUILD_TYPE MATCHES Debug +AND MSVC +AND MSVC_VERSI

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/philnik777 labeled https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing lis

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= @@ -13,22 +13,9 @@ namespace clang::tidy::modernize { -/// Mark unimplemented private special member functions with '= delete'. -/// \co

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= carlosgalvezp wrote: Yes good point, will fix! https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing l

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= PiotrZSL wrote: Do we want to sync comment above check class in code with first sentence in documentation ? https://github.com/llvm/llvm-project/pull/65231 ___

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65231 ___ cfe-com

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= carlosgalvezp wrote: Yep, we could certainly change it to C++11 or later, but I think it's out of the scope for this NFC patch. Regarding documentation, I haven't seen that we documen

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= @@ -3,22 +3,37 @@ modernize-use-equals-delete === -This check marks unimplemented private special member functions with ``= delete``. -To av

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= PiotrZSL wrote: Other interesting thing is that currently this check is limited just to LangOpts.CPlusPlus, when it should be to LangOpts.CPlusPlus11. And in such case documentation c

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= @@ -3,22 +3,37 @@ modernize-use-equals-delete === -This check marks unimplemented private special member functions with ``= delete``. -To av

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= @@ -3,22 +3,37 @@ modernize-use-equals-delete === -This check marks unimplemented private special member functions with ``= delete``. -To av

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun,

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun, 3 Sep 2023 18:24:55 + S

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= https://github.com/PiotrZSL commented: Maybe: ``` Identifies unimplemented private special member functions, recommends using '= delete' for them, and suggests relocating such deleted functions from the private to the public section. Before the introduction of C++1

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?G=C3=A1lvez?= @@ -3,22 +3,34 @@ modernize-use-equals-delete === +Prior to C++11, the only way to "delete" a given function was to make it PiotrZSL wrote: Begining of the description should say what check does, not a

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun, 3 Sep 2023 18:24:55 + Subject: [PATCH 1/2] [clang-t

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

@@ -3,22 +3,34 @@ modernize-use-equals-delete === +Prior to C++11, the only way to "delete" a given function was to make it +``private`` and without definition, to generate a compiler error (calling +private function) or a linker error (undefined refere

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp edited https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun, 3 Sep 2023 18:24:55 + Subject: [PATCH] [clang-tidy][NFC][doc] Improve documenta

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp review_requested https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp review_requested https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/65231: …-delete So the purpose of the check is more clear. Update examples code to show compliant code. >From 0ffc7aab2f385babd81b57e8116b0433d85cfaf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lv

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp review_requested https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/3] Add flags to dump IR to a file before and after LLVM passes

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/3] Add flags to dump IR to a file before and after LLVM passes

[PATCH] D158486: [clang-tidy] Ignore used special-members in modernize-use-equals-delete

This revision was automatically updated to reflect the committed changes. Closed by commit rG208fa9acc0ff: [clang-tidy] Ignore used special-members in modernize-use-equals-delete (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158486?vs=552217&id=555635#toc Repositor

[clang-tools-extra] 208fa9a - [clang-tidy] Ignore used special-members in modernize-use-equals-delete

Author: Piotr Zegar Date: 2023-09-03T17:05:31Z New Revision: 208fa9acc0ffe5a460bcd504229c24a8d3f87180 URL: https://github.com/llvm/llvm-project/commit/208fa9acc0ffe5a460bcd504229c24a8d3f87180 DIFF: https://github.com/llvm/llvm-project/commit/208fa9acc0ffe5a460bcd504229c24a8d3f87180.diff LOG: [

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/2] Add flags to dump IR to a file before and after LLVM passes

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/2] Add flags to dump IR to a file before and after LLVM passes

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] fa8e740 - [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (#65202)

Author: Piotr Zegar Date: 2023-09-03T18:40:18+02:00 New Revision: fa8e74073762300d07b02adec42c629daf82c44b URL: https://github.com/llvm/llvm-project/commit/fa8e74073762300d07b02adec42c629daf82c44b DIFF: https://github.com/llvm/llvm-project/commit/fa8e74073762300d07b02adec42c629daf82c44b.diff L

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

https://github.com/carlosgalvezp approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

dalias added a comment. musl targets **already** have the libc header path before the compiler header path in a BSD-like configuration (the BSDs also have this order on GCC and I would assume on clang as well), so if the compiler-provided `stddef.h` is getting seen at all, there's either a bug

[PATCH] D158486: [clang-tidy] Ignore used special-members in modernize-use-equals-delete

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158486/new/ https://reviews.llvm.org/D158486 _

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

aaron.ballman accepted this revision. aaron.ballman added a comment. As far as the change goes, this is fine (it keeps the status quo we previously had), but I still wonder if we should be trying to detect that the user is working with musl and do an include_next so our stddef.h header never get

[clang] 65b40f2 - RegAlloc: Rename MLRegalloc* files to use consistent captalization

Author: Matt Arsenault Date: 2023-09-03T09:00:27-04:00 New Revision: 65b40f273f09a53f61a13ac6f4bb65ec4ac63d6e URL: https://github.com/llvm/llvm-project/commit/65b40f273f09a53f61a13ac6f4bb65ec4ac63d6e DIFF: https://github.com/llvm/llvm-project/commit/65b40f273f09a53f61a13ac6f4bb65ec4ac63d6e.diff

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555626. brad marked an inline comment as not done. brad added a comment. Use --target= for all additions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

@@ -677,13 +677,18 @@ void TextNodeDumper::dumpBareType(QualType T, bool Desugar) { ColorScope Color(OS, ShowColors, TypeColor); SplitQualType T_split = T.split(); - OS << "'" << QualType::getAsString(T_split, PrintPolicy) << "'"; + std::string T_str = QualType::getAsSt

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

@@ -315,12 +315,16 @@ std::string JSONNodeDumper::createPointerRepresentation(const void *Ptr) { llvm::json::Object JSONNodeDumper::createQualType(QualType QT, bool Desugar) { SplitQualType SQT = QT.split(); - llvm::json::Object Ret{{"qualType", QualType::getAsString(SQT,

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

cor3ntin wrote: > These are an artifact of how types are structured but serve little purpose, merely showing that the type is sugared in some way. For example, ElaboratedType's existence means struct S gets printed as 'struct S':'struct S' in the AST, which is unnecessary visual clutter. Note tha

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

https://github.com/tru labeled https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

https://github.com/tru labeled https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS TransformUtils ) +# Workaround for MSVC ARM64 performance regression: disable all optimizations (/Od) tru wrote: I think this comment also should link to the issue on the Microsoft side so that we can know to

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

https://github.com/tru review_requested https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS TransformUtils ) +# Workaround for MSVC ARM64 performance regression: disable all optimizations (/Od) +# and then enable back all /O2 options except one. +if(NOT CMAKE_BUILD_TYPE MATCHES Debug +AND MSVC +AND MSVC_VERSI

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

https://github.com/tru requested changes to this pull request. Thanks for the PR, I think we at least need to make sure that we don't erase flags that have been set by the user manually. Another option would just to say that this configuration ARM64 + MSVC of this version is not a valid config

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

https://github.com/tru edited https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555623. brad added a comment. Bump DWARF version to 4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h clang/test/CodeGen/

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad added a comment. Comment at: clang/lib/Driver/ToolChains/Haiku.h:39 + + unsigned GetDefaultDwarfVersion() const override { return 2; } + nielx wrote: > I propose pushing this to version 4. Haiku's GCC also defaults to version 4 > now. I was using the ve

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

nielx added a comment. Have you been able to test the changes? Comment at: clang/lib/Driver/ToolChains/Haiku.h:39 + + unsigned GetDefaultDwarfVersion() const override { return 2; } + I propose pushing this to version 4. Haiku's GCC also defaults to version 4 n

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555622. brad added a comment. More context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h clang/test/CodeGen/dwarf-versio

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555621. brad added a comment. Add a test for the debug handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h clang/tes

[clang-tools-extra] c2bee1e - [clang-tidy][NFC] Unwind if-else-if-... in UnusedUsingDeclsCheck

Author: Piotr Zegar Date: 2023-09-03T06:24:56Z New Revision: c2bee1ed26a3355d164c92f1eb70ebf88804560d URL: https://github.com/llvm/llvm-project/commit/c2bee1ed26a3355d164c92f1eb70ebf88804560d DIFF: https://github.com/llvm/llvm-project/commit/c2bee1ed26a3355d164c92f1eb70ebf88804560d.diff LOG: [