[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan marked an inline comment as done. zyounan added a comment. Thanks again for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28 + +// expected-error@#1 {{no member named 'value' in 'is_convertible'}} + erichkeane wrote: > So I

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 555277. zyounan marked an inline comment as done. zyounan added a comment. Address one last nit comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clan

[PATCH] D159338: [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs

kadircet created this revision. kadircet added reviewers: sammccall, nridge. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rjmccall, daltenty, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. v.g.vassilev requested review of this revision. Herald added a subscriber: wangpc. This patch fixes valgrind reports from downstream

[PATCH] D159337: [clangd][tests] Assert for idleness of scheduler

kadircet created this revision. kadircet added reviewers: sammccall, nridge. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

MaskRay abandoned this revision. MaskRay added a comment. Obsoleted by D159173 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158688/new/ https://reviews.llvm.org/D158688 _

[PATCH] D159173: [Driver] Report warnings for unclaimed TargetSpecific options for assembler input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9d454d1c195: [Driver] Report warnings for unclaimed TargetSpecific options for assembler… (authored by MaskRay). Repository: rG LLVM Github Monor

[clang] e9d454d - [Driver] Report warnings for unclaimed TargetSpecific options for assembler input

Author: Fangrui Song Date: 2023-08-31T23:26:46-07:00 New Revision: e9d454d1c195958645fb0948f8b97262e7f8b33a URL: https://github.com/llvm/llvm-project/commit/e9d454d1c195958645fb0948f8b97262e7f8b33a DIFF: https://github.com/llvm/llvm-project/commit/e9d454d1c195958645fb0948f8b97262e7f8b33a.diff

[PATCH] D159173: [Driver] Report warnings for unclaimed TargetSpecific options for assembler input

MaskRay added a comment. Thank you. I am testing more thoroughly. We need this to catch up 17.0.0rc4... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159173/new/ https://reviews.llvm.org/D159173 ___ cfe-

[PATCH] D159335: [Object] Change OffloadBinary::write to return SmallString<0>

MaskRay updated this revision to Diff 555258. MaskRay added a comment. update clang-offload-packager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159335/new/ https://reviews.llvm.org/D159335 Files: clang/tools/clang-linker-wrapper/ClangLinkerWr

[PATCH] D159173: [Driver] Report warnings for unclaimed TargetSpecific options for assembler input

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159173/new/ https://reviews.llvm.org/D159173 _

[PATCH] D159335: [Object] Change OffloadBinary::write to return SmallString<0>

MaskRay created this revision. MaskRay added reviewers: jhuber6, JonChesterfield. Herald added a subscriber: hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. SmallString<0> is

[PATCH] D159293: [driver] Perform fallback target searches for stdlib

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159293/new/ https://reviews.llvm.org/D159293 ___

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 555251. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/PathDiagnostic.

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2113 + +bool CFGBuilder::hasTrivialDestructor(VarDecl *VD) const { // Check for const references bound to temporary. Set type to pointee. steakhal w

[PATCH] D159293: [driver] Perform fallback target searches for stdlib

smeenai updated this revision to Diff 555247. smeenai added a comment. Rebase to avoid pre-existing CI failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159293/new/ https://reviews.llvm.org/D159293 Files: clang/include/clang/Driver/ToolChain

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai updated this revision to Diff 555246. smeenai added a comment. Rebase to avoid pre-existing CI failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292/new/ https://reviews.llvm.org/D159292 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158702/new/ https://reviews.llvm.org/D158702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158595/new/ https://reviews.llvm.org/D158595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder added a comment. In D158502#4616174 , @cor3ntin wrote: > FYI there are build failures. you probably need to rebase (visitAPValue does > not seem to actually exist) This depends on the `__builtin_offsetof()` patch. Repository: rG LLVM Github

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9512 uint64_t TSize = Info.Ctx.getTypeSizeInChars(T).getQuantity(); +if (TSize == 0) + return false; shafik wrote: > I think we should issue a diagnostic, we don't have any in

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG534e23e47b03: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https

[clang] 534e23e - [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin

Author: Wael Yehia Date: 2023-09-01T03:17:54Z New Revision: 534e23e47b03292f80a3c8265a88a790f610d3f5 URL: https://github.com/llvm/llvm-project/commit/534e23e47b03292f80a3c8265a88a790f610d3f5 DIFF: https://github.com/llvm/llvm-project/commit/534e23e47b03292f80a3c8265a88a790f610d3f5.diff LOG: [T

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet added inline comments. Comment at: clang/test/Sema/warn-fortify-source.c:100-102 + __builtin_snprintf(buf, 2, "%#x", n); + __builtin_snprintf(buf, 2, "%#X", n); + __builtin_snprintf(buf, 2, "%#o", n); nickdesaulniers wrote: > Note that GCC -Wformat-t

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 555219. void added a comment. Fix testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclBase.h

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 555213. smeenai added a comment. Add warning and release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D159320: [NFC] Cleanup some #includes in header files

void created this revision. void added reviewers: nickdesaulniers, erichkeane. Herald added a subscriber: ChuanqiXu. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Limit the #includes to the least necessar

[clang] ef8121b - [Headers] Remove a space in NULL define

Author: Heejin Ahn Date: 2023-08-31T17:22:44-07:00 New Revision: ef8121b109ef0be9fe94289acbfb9736d66cff15 URL: https://github.com/llvm/llvm-project/commit/ef8121b109ef0be9fe94289acbfb9736d66cff15 DIFF: https://github.com/llvm/llvm-project/commit/ef8121b109ef0be9fe94289acbfb9736d66cff15.diff LO

[PATCH] D159312: [Headers] Remove a space in NULL define

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef8121b109ef: [Headers] Remove a space in NULL define (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. Thank you for the feedback and the revert! Distinguishing condition variables from other unused variables in Wunused warnings was something I was trying initially, and I agree that it's the best way forward. The difficulty is in how to know whether an unused `VarDecl`

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. Done. Btw musl defines `NULL` in several places, not only `stdio.h`. It defines `NULL` in `local.h`, `stddef.h`, `stdio.h`, `stdlib.h`, `string.h`, `time.h`, `unistd.h`, and `wchar.h`. Not sure why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin updated this revision to Diff 555201. aheejin added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 Files: clang/lib/Headers/__stddef_null.h Index: clang/lib/Headers/__s

[PATCH] D158883: [Matrix] Try to emit fmuladd for both vector and matrix types

This revision was automatically updated to reflect the committed changes. Closed by commit rGc987f9d7fdc7: [Matrix] Try to emit fmuladd for both vector and matrix types (authored by thegameg). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mono

[clang] c987f9d - [Matrix] Try to emit fmuladd for both vector and matrix types

Author: Francis Visoiu Mistrih Date: 2023-08-31T17:13:19-07:00 New Revision: c987f9d7fdc7b22c9bf68d7b3f0df10b68c679be URL: https://github.com/llvm/llvm-project/commit/c987f9d7fdc7b22c9bf68d7b3f0df10b68c679be DIFF: https://github.com/llvm/llvm-project/commit/c987f9d7fdc7b22c9bf68d7b3f0df10b68c67

[PATCH] D159312: [Headers] Remove a space in NULL define

iana accepted this revision. iana added a comment. This revision is now accepted and ready to land. Can you add a comment that says the spacing is important please? Although why the heck is musl declaring NULL in stdio.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7bd43675753: [clang][ASTImporter] Add import of a few type related nodes (authored by dingfei ). Repository: rG LLVM Github Mono

[clang] e7bd436 - [clang][ASTImporter] Add import of a few type related nodes

Author: dingfei Date: 2023-09-01T07:59:21+08:00 New Revision: e7bd43675753476e97e63aa13c13b3498407ed1c URL: https://github.com/llvm/llvm-project/commit/e7bd43675753476e97e63aa13c13b3498407ed1c DIFF: https://github.com/llvm/llvm-project/commit/e7bd43675753476e97e63aa13c13b3498407ed1c.diff LOG:

[PATCH] D159317: [clang][Docs] Document X86 interrupt attribute

antangelo created this revision. antangelo added reviewers: pengfei, aaron.ballman. Herald added a project: All. antangelo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1593

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2017 +for (StringRef Feature : llvm::split(FFeatures.getValueAsString(), ',')) { + bool EnabledForFunc = Feature[0] == '+'; + StringRef Name = Feature.substr(1); Do you need to g

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 555180. void added a comment. Remove un-needed change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

glandium abandoned this revision. glandium added a comment. Superseded by D159292 + D159293 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146664/new/ https://reviews.llvm.org/D

[PATCH] D159293: [driver] Perform fallback target searches for stdlib

glandium resigned from this revision. glandium added a comment. This replaces D146664 quite nicely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159293/new/ https://reviews.llvm.org/D159293 _

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

glandium resigned from this revision. glandium added a comment. This + D159293 works great for me. Thanks a bunch. (I'm not a reviewer, though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292/new/ https://re

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:732-733 +int RDKind = RD->isClass() ? 0 : (RD->isStruct() ? 1 : 2); +S.Diag(PtrArg->getBeginLoc(), diag::err_builtin_dump_struct_too_complex) +<< RDKind << RD->getName(); +return ExprErr

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aheejin added a comment. The added space in `((void *)0)` in `__stddef_null.h` broke Emscripten CI. I added the space back in D159312

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. The added space actually caused emscripten's CI to break: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8771230198259238865/+/u/Build_Emscripten__upstream_/stdout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin created this revision. aheejin added reviewers: iana, dschuff. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was no space in `((void *)0)` before D158709

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 555169. void added a comment. Add a few more tests to the codegen testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h cla

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu updated this revision to Diff 555166. kinu added a comment. Exclude lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/D159284 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp clang/l

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

This revision was automatically updated to reflect the committed changes. Closed by commit rG58c67e724f71: [clang-format] Fix AlignArrayOfStructures + Cpp11BracedListStyle=false (authored by galenelias, committed by owenpan). Changed prior to commit: https://reviews.llvm.org/D158795?vs=553809&i

[clang] 58c67e7 - [clang-format] Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

Author: Galen Elias Date: 2023-08-31T14:21:19-07:00 New Revision: 58c67e724f718be06ea43c766871135a338c2d55 URL: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55 DIFF: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55.diff L

[PATCH] D159307: [Sema] add test cases for D152495 NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa578cde031: [Sema] add test cases for D152495 NFC (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159307/new/ https://reviews

[clang] cfa578c - [Sema] add test cases for D152495 NFC

Author: Nick Desaulniers Date: 2023-08-31T14:17:41-07:00 New Revision: cfa578cde0314935c6eb5d7fa19ec26390d431dd URL: https://github.com/llvm/llvm-project/commit/cfa578cde0314935c6eb5d7fa19ec26390d431dd DIFF: https://github.com/llvm/llvm-project/commit/cfa578cde0314935c6eb5d7fa19ec26390d431dd.di

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172 ___

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added inline comments. Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28 +// OMP51: target: parallel +// OMP51: target: parallel +// OMP51-NOT: target: parallel mstorsjo wrote: > This test fails when running (on Windows) on GitHub Actions

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:153 /// All literals in the input that are not `NullLit` must be distinct. - void addCla

[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

sammccall created this revision. sammccall added reviewers: massberg, aaron.ballman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds only the trivial conceptReference() matcher. (Also adds te

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. @aaron.ballman This error gets generated on test cases even when a struct/class as no virtual base class. see this example on here: example Is this right behaviour? The note for this should not be generated since this does not ha

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan added a comment. Do you need us to commit it for you? See https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4632188 , @thakis wrote: > Works for me. How do you imagine the transition happening? Should we emit > some kind of warning if the old fallback is hit? That's a good call. I'll add that plus a release note. Reposito

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108 +SmallString<128> TargetDir(Path); +llvm::sys::path::append(TargetDir, Target, "c++", Version); if (D.getVFS().exists(TargetDir)) rprichard wrote: > Will the `Target`

[PATCH] D137338: Fix dupe word typos

Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or refactoring, adding documentation etc..) Add your unit tests in `c

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

shafik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const FunctionProtoType *FPT, cor3ntin wrote: > Whitespace only change Spurious change. Comment at: clang/lib/Sema/SemaExprMembe

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

rprichard added a comment. This change looks like an improvement to me. The NDK currently puts the libc++ headers into the sysroot, but putting it in the usual toolchain include location seems better. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108 +SmallString<128>

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG4294bca5e4f6: [clang-tidy] Add exit code support to clang-tidy-diff.py (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ htt

[clang-tools-extra] 4294bca - [clang-tidy] Add exit code support to clang-tidy-diff.py

Author: Piotr Zegar Date: 2023-08-31T19:58:15Z New Revision: 4294bca5e4f6e6e8cfdbd9fbe8751c5e5415fd47 URL: https://github.com/llvm/llvm-project/commit/4294bca5e4f6e6e8cfdbd9fbe8751c5e5415fd47 DIFF: https://github.com/llvm/llvm-project/commit/4294bca5e4f6e6e8cfdbd9fbe8751c5e5415fd47.diff LOG: [

[PATCH] D159307: [Sema] add test cases for D152495

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (this could be a NFC change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159307/new/ https://reviews.llvm.org/D159307 __

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. I would like @aaron.ballman to weight in, (he might not get back to you until next week), but overall, i think I'm pretty happy with this new direction. Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const Functi

[clang-tools-extra] efebb4e - [clang-tidy] readability-container-size-empty handle std::string length()

Author: Piotr Zegar Date: 2023-08-31T19:56:07Z New Revision: efebb4e0fabe91b70eaf58c049e516e50c726893 URL: https://github.com/llvm/llvm-project/commit/efebb4e0fabe91b70eaf58c049e516e50c726893 DIFF: https://github.com/llvm/llvm-project/commit/efebb4e0fabe91b70eaf58c049e516e50c726893.diff LOG: [

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGefebb4e0fabe: [clang-tidy] readability-container-size-empty handle std::string length() (authored by PiotrZSL). Changed p

[PATCH] D159307: [Sema] add test cases for D152495

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure these don't regress the next time we reland D152495 . Link: https

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

Mordante added a comment. @aaron.ballman We'd like to clean up the patches from the libc++ review queue. Is this patch is still relevant? Especially after landing https://reviews.llvm.org/D133535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1334

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

sammccall added a comment. Herald added a subscriber: wangpc. In D122529#3422158 , @aaron.ballman wrote: > This looks good? to me. :-) > > Despite this complicating things by a fair amount, I don't have a better > suggestion to offer. LGTM (sor

[clang-tools-extra] a199d8f - [clang-tidy][NFC] Improve compilation time of IntegralLiteralExpressionMatcher

Author: Piotr Zegar Date: 2023-08-31T19:22:17Z New Revision: a199d8fac027c226577ffb0c47b014015980dbb5 URL: https://github.com/llvm/llvm-project/commit/a199d8fac027c226577ffb0c47b014015980dbb5 DIFF: https://github.com/llvm/llvm-project/commit/a199d8fac027c226577ffb0c47b014015980dbb5.diff LOG: [

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/ https://reviews.llvm.org/D56644 ___ cfe-commits mailing list cfe-commit

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4632240 , @aaron.ballman wrote: > In D158540#4629042 , @NoumanAmir657 > wrote: > >> Do you want the note to be like this: >> >> ../llvm-test/x.cpp:5:1: note: virtual b

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added a comment. In D158540#4629042 , @NoumanAmir657 wrote: > Do you want the note to be like this: > > ../llvm-test/x.cpp:5:1: note: virtual base class declared here > 5 | struct Derived : virtual Base { > | ^ > 1 error g

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159279/new/ https://reviews.llvm.org/D159279 _

[clang] f0f395e - Revert "Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions""

Author: Nick Desaulniers Date: 2023-08-31T11:58:41-07:00 New Revision: f0f395e00e2ec3f1f20ca9021d1554fde73d56c9 URL: https://github.com/llvm/llvm-project/commit/f0f395e00e2ec3f1f20ca9021d1554fde73d56c9 DIFF: https://github.com/llvm/llvm-project/commit/f0f395e00e2ec3f1f20ca9021d1554fde73d56c9.di

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

cseo added a comment. Ping. Any other comments/concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158135/new/ https://reviews.llvm.org/D158135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158476: [driver] Search for compatible Android runtime directories

thakis added a comment. Works for me. How do you imagine the transition happening? Should we emit some kind of warning if the old fallback is hit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

aaron.ballman added a comment. In D152495#4631829 , @nickdesaulniers wrote: > Here's a more blatant regression caused by this patch. > > https://godbolt.org/z/q19Ge64G3 > > Causing breakage for the Linux kernel: > https://github.com/ClangBuiltLinux/linux

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:59 // RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \ -// RUN: --target=x86_64-pc-windows-msvc \ +// RUN: --target=x86_64-pc-windows-msvc -fuse-ld= \ // RUN: -nogpuinc -nog

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz updated this revision to Diff 555118. beanz added a comment. Updating based on review feedback from @core3ntin. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/ https://reviews.llvm.org/D159247 Files: clang/include/clan

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/Threading.cpp:102 llvm::set_thread_name(Name); +// Mark the bottom of the stack for clang to be aware of the stack usage and +// prevent stack overflow. ugh, I forgot: thi

[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

sammccall created this revision. sammccall added a reviewer: massberg. Herald added a subscriber: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. The dump() is not actually incl

[PATCH] D159299: [clangd] Support ConceptReference in generic AST wrangling code

sammccall created this revision. sammccall added a reviewer: massberg. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. N

[clang] fa832d5 - [clang][doc] Uses C++20 instead of C++2a.

Author: Mark de Wever Date: 2023-08-31T20:22:35+02:00 New Revision: fa832d5ae8b3d61d0f1f44e20c4cc61030753d79 URL: https://github.com/llvm/llvm-project/commit/fa832d5ae8b3d61d0f1f44e20c4cc61030753d79 DIFF: https://github.com/llvm/llvm-project/commit/fa832d5ae8b3d61d0f1f44e20c4cc61030753d79.diff

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 ___ cfe-commits mailing list cfe-comm

[PATCH] D85309: [Driver] Support GNU ld on Solaris

MaskRay added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:59 // RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \ -// RUN: --target=x86_64-pc-windows-msvc \ +// RUN: --target=x86_64-pc-windows-msvc -fuse-ld= \ // RUN: -nogpuinc

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz added a comment. Yea, we could do that approach. It will mean filtering about a few `getNonReferenceType()` calls, which is what I was trying to avoid. That said, it might be the better solution since it can be unconditional and will work for both deducing `this` and HLSL. I'll test it o

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL added a comment. In D159045#4631820 , @felix642 wrote: > In that case, I agree with you, it would be helpful to add this feature. I > think supporting an empty value rather than a boolean is preferable. We > should maybe do that in another Diff

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Clean up the test layout a little as a part of the commit, otherwise, LGTM! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28 + +// expected-error@#1

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

nickdesaulniers added a comment. Here's a more blatant regression caused by this patch. https://godbolt.org/z/q19Ge64G3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___

  1   2   3   >