[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

cor3ntin added a comment. Thanks for working on this! Looks good to me except for a couple typos. Can you an an entry in `clang/docs/ReleaseNotes.rst` (mentioning the github issue) Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBa

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

cor3ntin added a comment. For context this seems to be the patch that did not increment the bit field https://reviews.llvm.org/D139837 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG317a0fe5bd71: [Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary… (authored by shenhan). Repository: rG LLVM Github Monorep

[clang] 317a0fe - [Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary compilation.

Author: Han Shen Date: 2023-08-16T23:41:34-07:00 New Revision: 317a0fe5bd7113c0ac9d30b2de58ca409e5ff754 URL: https://github.com/llvm/llvm-project/commit/317a0fe5bd7113c0ac9d30b2de58ca409e5ff754 DIFF: https://github.com/llvm/llvm-project/commit/317a0fe5bd7113c0ac9d30b2de58ca409e5ff754.diff LOG:

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 updated this revision to Diff 551016. danix800 added a comment. Add alternative testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files: clang/include/clang/AST/DeclBase.h clang/lib/S

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3fe3ed97bc: [CodeGen] Remove Constant arguments from linkage functions, NFCI. (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANG

[clang] 2f3fe3e - [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Author: Jonas Hahnfeld Date: 2023-08-17T08:28:51+02:00 New Revision: 2f3fe3ed97bcf778d73eda5aae9f166810a4af02 URL: https://github.com/llvm/llvm-project/commit/2f3fe3ed97bcf778d73eda5aae9f166810a4af02 DIFF: https://github.com/llvm/llvm-project/commit/2f3fe3ed97bcf778d73eda5aae9f166810a4af02.diff

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG28741a23c9fc: [clang][SVE] Rename isVLSTBuiltinType, NFC (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://review

[clang] 28741a2 - [clang][SVE] Rename isVLSTBuiltinType, NFC

Author: Jianjian GUAN Date: 2023-08-17T14:18:32+08:00 New Revision: 28741a23c9fc5e9c9ba9cad8e71c3067544bcd66 URL: https://github.com/llvm/llvm-project/commit/28741a23c9fc5e9c9ba9cad8e71c3067544bcd66 DIFF: https://github.com/llvm/llvm-project/commit/28741a23c9fc5e9c9ba9cad8e71c3067544bcd66.diff

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

danix800 added a comment. In D156461#4583806 , @balazske wrote: > It looks not good to remove an invalid node from the DeclContext that > otherwise remains in the AST. I checked the problem and found that the > existing move constructor (originally in t

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

yonghong-song added a comment. > Ah, right right - sorry, failed to push. Here it is: > 2993243c45abdb4f2bc3979336d054be165b1134 > Thanks! I tested and the problem with bpf backend is resolved! Repository: rG LLVM Github

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 created this revision. danix800 added reviewers: aaron.ballman, cor3ntin, ychen, balazske. danix800 added a project: clang. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. `FunctionDeclBitfie

[clang] 235dad3 - [clang][Interp][NFC] Make some variables const

Author: Timm Bäder Date: 2023-08-17T07:54:37+02:00 New Revision: 235dad33284a6c7514e4eadff21cb5e8157d4edc URL: https://github.com/llvm/llvm-project/commit/235dad33284a6c7514e4eadff21cb5e8157d4edc DIFF: https://github.com/llvm/llvm-project/commit/235dad33284a6c7514e4eadff21cb5e8157d4edc.diff LO

[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158137/new/ https://reviews.llvm.org/D158137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 551001. XinWang10 added a comment. - update fe test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Drive

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added a comment. In D156726#4594005 , @yonghong-song wrote: > In D156726#4593671 , @dblaikie > wrote: > >> Fixed in 19c216b5ab7c34c297b4c3c4da64b49b3c830a3a > > Hi, @dblaikie I cannot find the above com

[clang] 2993243 - Fix misdiagnosed writability for __attribute__((section()))

Author: David Blaikie Date: 2023-08-17T05:35:40Z New Revision: 2993243c45abdb4f2bc3979336d054be165b1134 URL: https://github.com/llvm/llvm-project/commit/2993243c45abdb4f2bc3979336d054be165b1134 DIFF: https://github.com/llvm/llvm-project/commit/2993243c45abdb4f2bc3979336d054be165b1134.diff LOG:

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550998. fakepaper56 added a comment. Address jrtc27's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-featu

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550996. Amir added a comment. Bugfixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake clang/utils/perf

[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

MaskRay added a comment. In D158137#4594181 , @dexonsmith wrote: > LGTM. > > Perhaps as a follow-up, rename warn_drv_overriding_flag_option to have “t” in > it? Thanks! I agree. d9ad0681fad9a98f43d9baddb95d505b37153c48 (2013) renamed `warn_drv_overrid

[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Perhaps as a follow-up, rename warn_drv_overriding_flag_option to have “t” in it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:1 +//=== RISCVInstrInfoZicfiss.td - RISC-V CFG -*- tablegen -*===// +//

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

argentite added reviewers: v.g.vassilev, sgraenitz, lhames. argentite added a comment. This cannot built yet because it depends on lld which does not seem to usable from clang directly. I am looking for feedback/ideas on how to proceed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

argentite created this revision. Herald added subscribers: cfe-commits, pmatos, asb, sunfish, jgravelle-google, sbc100, dschuff. Herald added projects: clang, All. argentite requested review of this revision. Herald added a subscriber: aheejin. This commit introduces support for running clang-rep

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 ___

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550987. fakepaper56 added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-features.c l

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 550983. wangpc marked 10 inline comments as done. wangpc added a comment. - Rebase. - Update tests, remove clang-17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Fi

[clang] 574ee1c - [C++20] [Modules] Prevent to accept clang modules

Author: Chuanqi Xu Date: 2023-08-17T11:45:50+08:00 New Revision: 574ee1c02ef73b66c5957cf93888234b0471695f URL: https://github.com/llvm/llvm-project/commit/574ee1c02ef73b66c5957cf93888234b0471695f DIFF: https://github.com/llvm/llvm-project/commit/574ee1c02ef73b66c5957cf93888234b0471695f.diff LO

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

yonghong-song added a comment. In D156726#4593671 , @dblaikie wrote: > Fixed in 19c216b5ab7c34c297b4c3c4da64b49b3c830a3a Hi, @dblaikie I cannot find the above commit in llvm-project and with latest llvm-project 'main' branch, the problem seems still exi

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan added a comment. In D158045#4592331 , @paulwalker-arm wrote: > I'd hope there are common code paths where `isVLSTBuiltinType` would still be > useful but I guess this step is required to make that happen anyway. > > If you permit a minor req

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan updated this revision to Diff 550967. jacquesguan added a comment. rename to isSveVLSBuiltinType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://reviews.llvm.org/D158045 Files: clang/include/clang/AST/Type.h clan

[PATCH] D158136: [clang][modules] Avoid storing command-line macro definitions into implicitly built PCM files

jansvoboda11 updated this revision to Diff 550964. jansvoboda11 added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158136/new/ https://reviews.llvm.org/D158136 Files: clang/include/clang/Serialization/ASTReader.h clang/inclu

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf added subscribers: quinnp, amyk. qiucf added a comment. CC @amyk @quinnp Any comments about the naming? I see some `__builtin_ppc_xxx` are aliased into `__builtin_xxx` by `defineXLCompatMacros`. But these are not XL-compatible builtins, and the macros do not always work. Repository: r

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

MaskRay updated this revision to Diff 550963. MaskRay added a comment. rebase we may not go with this approach, but update to show the test difference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153835/new/ https://reviews.llvm.org/D153835 Files

[PATCH] D154774: [Sema] Respect instantiated-from template's VisibilityAttr for two implicit/explicit instantiation cases

MaskRay updated this revision to Diff 550961. MaskRay added a comment. rebase. this does not address rjmccall's comment, but just to show the difference to other tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154774/new/ https://reviews.llvm.

[PATCH] D157485: [X86][RFC] Support new feature AVX10

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:261 +if (AVXVecSize == 256) + D.Diag(diag::warn_drv_overriding_flag_option) << "AVX10-256" +<< "AVX10-512"; ---

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

MaskRay added inline comments. Herald added a subscriber: ributzka. Herald added a project: All. Comment at: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp:1545 +std::string TargetArg = OSTarget->getAsString(Args, Opts); +getDriver().Diag(clang::diag::warn_drv_overrid

[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

MaskRay created this revision. MaskRay added reviewers: clang, aaron.ballman, andrew.w.kaylor, hans, skan, zahiraam. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. warn_drv_overriding_flag_option was i

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

evelez7 updated this revision to Diff 550958. evelez7 added a comment. Update to use the new Template class constructor instead of old getFragments. Also better functional style for appending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158029/ne

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a comment. In D157297#4592851 , @aaron.ballman wrote: > In D157297#4590886 , @pengfei wrote: > >> BTW, maybe @aaron.ballman knows why we don't support such syntax in C++. > > The return statement ex

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:169 + // functions. + return !Awaiter->field_empty(); +} rjmccall wrote: > Is it possible for the awaiter type to be incomplete here? Tha

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu updated this revision to Diff 550955. ChuanqiXu marked 4 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157833/new/ https://reviews.llvm.org/D157833 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/C

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 updated this revision to Diff 550953. evelez7 added a comment. Update Spec naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 Files: clang/include/clang/ExtractAPI/API.h clang/include/clan

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550950. evelez7 added a comment. Forgot Spec instance in SerializerBase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files: clang/include/clang/ExtractAPI/API.h

[clang] 52c62d4 - Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-16T18:27:17-07:00 New Revision: 52c62d46a0c8ebf6023233cabc5beb4ee2687c78 URL: https://github.com/llvm/llvm-project/commit/52c62d46a0c8ebf6023233cabc5beb4ee2687c78 DIFF: https://github.com/llvm/llvm-project/commit/52c62d46a0c8ebf6023233cabc5beb4ee2687c78.di

[PATCH] D157485: [X86][RFC] Support new feature AVX10

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:739 + if (HasAVX10_512BIT) +Builder.defineMacro("__AVX10_512BIT__"); + This is untested? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

evelez7 updated this revision to Diff 550948. evelez7 added a comment. Update instances of Spec to Specialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157579/new/ https://reviews.llvm.org/D157579 Files: clang/include/clang/ExtractAPI/AP

[PATCH] D157485: [X86][RFC] Support new feature AVX10

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157485/new/ https://reviews.llvm.org/D157485 ___ cfe

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 550945. evelez7 added a comment. Also rename traverseSpec* in SerializerBase.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files: clang/include/clang/ExtractAPI

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550944. evelez7 added a comment. Update all instances of Spec to Specialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files: clang/include/clang/ExtractAP

[PATCH] D158136: [clang][modules] Avoid storing command-line macro definitions into implicitly built PCM files

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, rsmith, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With implicit m

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 550940. capfredf added a comment. up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Interprete

[PATCH] D158135: [Clang] Add __builtin_bcopy

cseo created this revision. Herald added a project: All. cseo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add __builtin_bcopy to the list of GNU builtins. This was causing a series of test failures in glibc. Fixes #51409. Fixes #63065.

[PATCH] D129061: [Lex] Diagnose macro in command lines

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:664 HelpText<"Define to (or 1 if omitted)">; +def DriverDefine : JoinedOrSeparate<["-"], "driver-define">, Group, +Flags<[CC1Option, FlangOption, FC1Option]>, MetaVarName<"=">, -

[PATCH] D158131: HIP: Directly use f32 sqrt intrinsic

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. I'm hoping to write some brute force tests for the `fp32` math functions in `libc` soonish. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158131/new/ https://reviews.llvm.org/D1581

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

brad created this revision. brad added reviewers: mkuper, waltl. brad added a project: clang. Herald added a project: All. brad requested review of this revision. As has been done for other OS's. Move the header path management to the driver. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 added a comment. We didn't handle inheriting from a template parameter, but now we do by serializing the relationship. The parameter does not produce a target USR so it falls back to its name. Comment at: clang/include/clang/ExtractAPI/DeclarationFragments.h:191 +cl

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:37 + let Inst{12} = 0; + let Inst{11-7} = rs1; + let Inst{6-2} = 0b0; Do we need the rs1 variable or can we use rs1val here? We usually have the rs1 field becau

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 550937. evelez7 marked 5 inline comments as done. evelez7 added a comment. Address review feedback - Handle inheriting from a template parameter. - Add a new test to check inheriting from a template parameter. - Move base class gathering to a new private meth

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64MCInstLower.cpp:51-54 +// For ARM64EC, symbol lookup in the MSVC linker has limited awareness +// of ARM64EC mangling ("#"/"$$h"). So object files need to refer to both +// the mangled and unma

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/test/C/C2x/n2359.c:40 +#error "__STDC_VERSION_STDCKDINT_H__ not defined" +// expected-error@-1 {{"__STDC_VERSION_STDCKDINT_H__ not defined"}} +#endif enh wrote: > don't you need another test somewhere that this _

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

MaskRay added inline comments. Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:4 +// RUN: | FileCheck --check-prefix=NOGATHER %s +// RUN: %clangxx -c -mno-gather -### %s 2>&1 \ +// RUN: | FileCheck --check-prefix=NOGATHER %s Each RUN line makes tests

[clang] 314a5d7 - Simplify a conditional in order to avoid a warning under MSVC

Author: Justin Bogner Date: 2023-08-16T16:19:57-07:00 New Revision: 314a5d707fe70369e3e1a6ac561d64884896dbd7 URL: https://github.com/llvm/llvm-project/commit/314a5d707fe70369e3e1a6ac561d64884896dbd7 DIFF: https://github.com/llvm/llvm-project/commit/314a5d707fe70369e3e1a6ac561d64884896dbd7.diff

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added a comment. Fixed in 19c216b5ab7c34c297b4c3c4da64b49b3c830a3a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 ___ cfe-commits mailing list cfe-com

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 550927. SlaterLatiao added a comment. - Refactor instantiating members into 2 functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files: clang/lib/Sema/

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added a comment. In D157750#4593582 , @dhoekwater wrote: > This patch will make it difficult to write tests for MFS on AArch64 before it > is officially enabled. Currently, because clang performs the Triple check, we > can use `-enable-split-ma

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

jacek added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64MCInstLower.cpp:51-54 +// For ARM64EC, symbol lookup in the MSVC linker has limited awareness +// of ARM64EC mangling ("#"/"$$h"). So object files need to refer to both +// the mangled and unmangl

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/test/C/C2x/n2359.c:40 +#error "__STDC_VERSION_STDCKDINT_H__ not defined" +// expected-error@-1 {{"__STDC_VERSION_STDCKDINT_H__ not defined"}} +#endif don't you need another test somewhere that this _is_ defined under s

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550913. shenhan added a comment. Refined the test case a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

dhoekwater added a comment. This patch will make it difficult to write tests for MFS on AArch64 before it is officially enabled. Currently, because clang performs the Triple check, we can use `-enable-split-machine-functions` to run tests with MFS on Arm, but after this patch the flag won't do

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

xur accepted this revision. xur added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D157331: [clang] Implement C23

ZijunZhao added a comment. Skip `static_assert()` tests because `constexpr` is not supported in C23 yet: https://github.com/llvm/llvm-project/issues/64742 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 550910. ZijunZhao added a comment. 1. separate two files in clang/test/C/C2x 2. make some update about the macro __STDC_VERSION_STDCKDINT_H__ add the test for testing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

smeenai added a comment. In D141918#4577930 , @jyknight wrote: > In D141918#4566838 , @smeenai wrote: > >> $ clang -std=c++20 -O2 -c crash.cpp >> cannot use musttail with unwindabort > > Thanks for the report. We

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. Thanks @lei for the help testing. Re-applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list cfe-co

[clang] e698695 - Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

Author: Erik Pilkington Date: 2023-08-16T15:21:46-07:00 New Revision: e698695fbbf62e6676f8907665187f2d2c4d814b URL: https://github.com/llvm/llvm-project/commit/e698695fbbf62e6676f8907665187f2d2c4d814b DIFF: https://github.com/llvm/llvm-project/commit/e698695fbbf62e6676f8907665187f2d2c4d814b.dif

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

This revision was automatically updated to reflect the committed changes. Closed by commit rGe698695fbbf6: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument… (authored by erik.pilkington, committed by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:519-521 + if (const ElaboratedType *ET = dyn_cast(BaseType)) { +if (const TemplateSpecializationType *TST = +dyn_cast(ET->getNamedType())) { I think you can skip the `c

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

MaskRay added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4218 + Outputs.push_back(Out.get()); + Arg++; +} https://llvm.org/docs/CodingStandards.html#prefer-preincrement Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

MaskRay added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3292 + std::string NewFieldName = + PackedField->getName().str() + "@" + std::to_string(Arg); + PackedField->setDeclName(&Context.Idents.get(NewFieldName)); --

[clang] bb5f64a - Add Requires x86 target to test due to failure in clang-armv8-quick

Author: usama hameed Date: 2023-08-16T15:09:14-07:00 New Revision: bb5f64a6fc059fcf81b4b9ffe035f5063956ddd8 URL: https://github.com/llvm/llvm-project/commit/bb5f64a6fc059fcf81b4b9ffe035f5063956ddd8 DIFF: https://github.com/llvm/llvm-project/commit/bb5f64a6fc059fcf81b4b9ffe035f5063956ddd8.diff

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 550899. hazohelet added a comment. rebase to upstream to run ci CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td cl

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9afc57dcb2e5: [CodeGen][UBSan] Handle sugared QualTypes correctly in (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157445/new/ htt

[clang] 9afc57d - [CodeGen][UBSan] Handle sugared QualTypes correctly in

Author: usama hameed Date: 2023-08-16T14:47:49-07:00 New Revision: 9afc57dcb2e5cd36ca1ddf0fee3efa958bfd4c2a URL: https://github.com/llvm/llvm-project/commit/9afc57dcb2e5cd36ca1ddf0fee3efa958bfd4c2a DIFF: https://github.com/llvm/llvm-project/commit/9afc57dcb2e5cd36ca1ddf0fee3efa958bfd4c2a.diff

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

dhoekwater accepted this revision. dhoekwater added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 __

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

jcranmer-intel added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17317-17319 +if (TInfo->getType()->isSpecificBuiltinType(BuiltinType::Float) || +TInfo->getType()->isSpecificBuiltinType(BuiltinType::Half)) PromoteType = Context.DoubleTy; --

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:657 + const Stmt *S = AcquireNode->getStmtForDiagnostics(); + assert(S && "Statmement cannot be null."); PathDiagnosticLocation LocUsedForUniqueing = --

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550885. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGe62b2fc40d11: [NFC][Clang] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D157888?vs=549962&id=550886#toc Repositor

[clang] e62b2fc - [NFC][Clang] Fix static analyzer concern

Author: Elizabeth Andrews Date: 2023-08-16T13:52:45-07:00 New Revision: e62b2fc40d11b6b13bcc08d7ceafe1472abe4c58 URL: https://github.com/llvm/llvm-project/commit/e62b2fc40d11b6b13bcc08d7ceafe1472abe4c58 DIFF: https://github.com/llvm/llvm-project/commit/e62b2fc40d11b6b13bcc08d7ceafe1472abe4c58.d

[PATCH] D78441: Delete NaCl support

dschuff added a comment. Deprecation is progressing (https://groups.google.com/a/chromium.org/g/chromium-extensions/c/v8H1UHnPotY/m/NmzrIv_VBAAJ) but we are still supporting it on some platforms, (and using clang's upstream support), so we aren't there yet. Repository: rG LLVM Github Monore

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 550881. hazohelet marked an inline comment as done. hazohelet added a comment. Address comments from Chris - Generate fix-it hint to remove `constexpr` in constexpr-if Added `SourceLocation` field to Sema that saves the location of `constexpr` in constexp

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 550874. to268 marked 4 inline comments as done. to268 added a comment. This update is mostly a followup of a change upstream that consist of renaming all C2x references to C23. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dmgreen added a comment. It looks like there are patterns for A[0]*B+C and B*A[0]*C to handle commutivity. Are there tests for both forms too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008

[PATCH] D158113: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

bogner created this revision. bogner added a reviewer: beanz. Herald added a subscriber: mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds /Zi handling and explicitly ignores /Qembed_deb

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:10 + +#ifndef __STDC_VERSION_STDCKDINT_H__ +#define __STDC_VERSION_STDCKDINT_H__ i think this should just be `__STDCKDINT_H` to match the other headers' include guards, and then you want a _sep

[PATCH] D158071: [clang] Remove rdar links; NFC

NoQ added a comment. Uh-oh looks like I missed 3 links that were spelled as `radar://`. I confirm that they can be safely removed as I looked into those internal bug reports and found no useful information to add. I'll take a brief look at the links in static analyzer tests later today or tomo

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16920-16926 +if (llvm::ConvertCodePointToUTF8(Value, Ptr)) { + OS << StringRef(Arr, Ptr - Arr); +} else { + OS << "\\x" + << llvm::format_hex_no_prefix(Value, TyWidt

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added a comment. In D156726#4591543 , @eddyz87 wrote: > As an additional data point, the same example but w/o section specification > compiles fine: > > const int with_init = 1; > const int no_init; > > And puts both globals to the same sect

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK to me - thanks! bit more detail in the actual patch description/commit message (from some of the comments in this review, perhaps) would be handy. CHANGES SINCE LAST ACTION h

  1   2   3   >