[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

fakepaper56 updated this revision to Diff 549262. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files: clang/test/Preprocessor/riscv-target-fea

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, I am OK with that, actually our downstream toolchain has downgrade the dwarf version to 4 too, because binutils/gdb not well support before... Repository: rG LLVM Github Monor

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157072/new/ https://reviews.llvm.org/D157072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return false; cor3ntin wrote: > Shouldn't that

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping Comment at: clang/test/AST/Interp/literals.cpp:1047 - // expected-warning {{variable length array folded to constant array}} -} Ignore this block, that's just from rebasing. CHANGES SINCE LAST ACT

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 549251. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-fea

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added a comment. Please update docs/RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e3b2c46084: Fix assertion when -fasy-exception is used. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm

[clang] 33e3b2c - Fix assertion when -fasy-exception is used.

Author: Jennifer Yu Date: 2023-08-10T21:54:32-07:00 New Revision: 33e3b2c46084bc47ef4067ed487b24b58934d044 URL: https://github.com/llvm/llvm-project/commit/33e3b2c46084bc47ef4067ed487b24b58934d044 DIFF: https://github.com/llvm/llvm-project/commit/33e3b2c46084bc47ef4067ed487b24b58934d044.diff L

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter marked an inline comment as done. ccotter added a comment. @PiotrZSL would you mind landing this for me? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

MaskRay updated this revision to Diff 549233. MaskRay retitled this revision from "[Driver] Default riscv*-linux* to -fdebug-default-version=4" to "[Driver] Default riscv*- triples to -fdebug-default-version=4". MaskRay edited the summary of this revision. MaskRay added a comment. Thanks for men

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 549232. void added a comment. Update to more match Qing's GCC implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D157584: [clang][Sema] Skip access check on arrays of zero-length element

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157584/new/ https://reviews.llvm.org/D157584 _

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added a comment. @rnk & I figured that the user probably isn't relying on this much - if they cared about a particular variable, they could use an attribute instead of a pragma. The pragma just being about "put all my const things over here and all my non-const things over there" - bug

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) efriedma wrote: > dblaikie wrote: > > rnk wrote: > > > rsmith wrote:

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie updated this revision to Diff 549206. dblaikie added a comment. Add a warning for MSVC pragma inconsistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 Files: clang/include/clang/AST/Type.h

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 549203. hazohelet added a comment. Resolved the constexpr-if init-statement expression evaluation context problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. I've just published https://reviews.llvm.org/D157664, so you'll want to rebase ontop of it if it lands soon. I would also like to see some more tests added to `instrprof-merge-error.c` to make sure two different binaries can't merge profiles together with `--debug-info-co

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 549197. fridtjof added a comment. It was the unit test I added - I forgot to properly dispose of the EvalResult there CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 Files: clang/docs/ReleaseNotes.rst

[clang] 9c9e8b4 - Fix test clang/test/AST/Interp/builtin-functions.cpp for compilers that default to a C++ standard earlier than C++17.

Author: Douglas Yung Date: 2023-08-10T16:21:41-07:00 New Revision: 9c9e8b4797a4305d4273c63b0ab4ce84e3a79e7d URL: https://github.com/llvm/llvm-project/commit/9c9e8b4797a4305d4273c63b0ab4ce84e3a79e7d DIFF: https://github.com/llvm/llvm-project/commit/9c9e8b4797a4305d4273c63b0ab4ce84e3a79e7d.diff

[PATCH] D157663: [Driver] Default riscv*-linux* to -fdebug-default-version=4

jrtc27 added a comment. Also Haiku I guess, as another OS that has a somewhat working RISC-V port but falls back on ToolChain's default implementation. So maybe this just belongs in the default implementation, given all the ones that need modifying are the ones that end up there. Repository:

[PATCH] D157663: [Driver] Default riscv*-linux* to -fdebug-default-version=4

jrtc27 added a comment. RISCVToolchain also needs an override Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157663/new/ https://reviews.llvm.org/D157663 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D157663: [Driver] Default riscv*-linux* to -fdebug-default-version=4

MaskRay updated this revision to Diff 549192. MaskRay added a comment. add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157663/new/ https://reviews.llvm.org/D157663 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/test/Driver/clan

[PATCH] D157663: [Driver] Default riscv*-linux* to -fdebug-default-version=4

MaskRay created this revision. MaskRay added reviewers: asb, dblaikie, jrtc27, kito-cheng. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, simoncook, arichardson. Herald added a project: All. MaskRay requested revie

[PATCH] D157244: [clang-format] Correctly count annoated lines in a namespace body

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b8542ce8e8c: [clang-format] Correctly count annoated lines of a namespace body (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D157244?vs=547612&id=549190#toc Repository: rG

[clang] 2b8542c - [clang-format] Correctly count annoated lines of a namespace body

Author: Owen Pan Date: 2023-08-10T15:55:01-07:00 New Revision: 2b8542ce8e8c24dfcdd0433542cf733556b8 URL: https://github.com/llvm/llvm-project/commit/2b8542ce8e8c24dfcdd0433542cf733556b8 DIFF: https://github.com/llvm/llvm-project/commit/2b8542ce8e8c24dfcdd0433542cf733556b8.diff LOG:

[PATCH] D154359: [clang] Reset FP options before template instantiation

hubert.reinterpretcast added a comment. This patch seems to be direct cause of a regression: https://github.com/llvm/llvm-project/issues/64605. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154359/new/ https://reviews.llvm.org/D154359 ___

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4577790 , @awarzynski wrote: > Hey @bogner , I've only skimmed through so far and it's looking great! That > Include/Exclude API was not fun to use. What you are proposing here takes > Options.td to a much a better pl

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); vitalybuka wrote: > There is a leak here https://lab.llvm.org/buildbot/#/bu

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157040/new/ https://reviews.llvm.org/D157040 ___

[clang] 332a34c - Revert "[libclang] Expose arguments of clang::annotate"

Author: Vitaly Buka Date: 2023-08-10T15:25:02-07:00 New Revision: 332a34c71e7675ab4e0ebd28b0d2c15302a81a51 URL: https://github.com/llvm/llvm-project/commit/332a34c71e7675ab4e0ebd28b0d2c15302a81a51 DIFF: https://github.com/llvm/llvm-project/commit/332a34c71e7675ab4e0ebd28b0d2c15302a81a51.diff L

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added a comment. Not sure why the similar code above does not leak, so I will revert and leave to author to investigate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. Thanks for working on this! Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:103-104 COMPILER_RT_VISIBILITY int __llvm_profile_merge_from_buffer(const char *ProfileData, uint64_t ProfileSize) { __llvm_pr

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); There is a leak here https://lab.llvm.org/buildbot/#/builders/5/builds/3572

[clang] fe9c332 - Revert "Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.""

Author: Volodymyr Sapsai Date: 2023-08-10T15:14:26-07:00 New Revision: fe9c332408603e50ab846c1ad8aeb705df2950b1 URL: https://github.com/llvm/llvm-project/commit/fe9c332408603e50ab846c1ad8aeb705df2950b1 DIFF: https://github.com/llvm/llvm-project/commit/fe9c332408603e50ab846c1ad8aeb705df2950b1.di

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

yaxunl added inline comments. Comment at: clang/test/SemaStdPar/device-can-call-host.cpp:1 +// RUN: %clang %s --stdpar --stdpar-path=%S/Inputs \ +// RUN: --stdpar-thrust-path=%S/Inputs --stdpar-prim-path=%S/Inputs \ can we use %clang_cc1 and omit the stdpar pat

[clang] b070be8 - Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-10T14:52:49-07:00 New Revision: b070be82bb8fb4414a8a6eb4fbfc77921d89fa4b URL: https://github.com/llvm/llvm-project/commit/b070be82bb8fb4414a8a6eb4fbfc77921d89fa4b DIFF: https://github.com/llvm/llvm-project/commit/b070be82bb8fb4414a8a6eb4fbfc77921d89fa4b.di

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5237-5238 + + if (VTy->isPointerTy() && + VTy->getPointerAddressSpace() != IRTy->getPointerAddressSpace()) { +// In the case of targets that use a non-default address space f

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

erjin added a comment. Ping. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157040/new/ https://reviews.llvm.org/D157040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 549177. MitalAshok added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156054/new/ https://reviews.llvm.org/D156054 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/FormatString.

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 549176. MitalAshok added a comment. Address feedback; Reuse DefaultArgumentPromotion instead of duplicating its functionality when building VaArgExpr There is the added bonus for it working with dependent types somewhat (`template __builtin_va_arg(ap, T[

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

jyu2 updated this revision to Diff 549174. jyu2 added a comment. Thanks all for the review! This is fix space problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm.org/D157566 Files: clang/lib/CodeGen/CGCleanup.cpp clang/test/CodeGen/windows-seh-a

[PATCH] D157520: [Driver] Replace a link to openradar with a comment. NFC

ahatanak added a comment. It looks like the linker bug has been fixed, but we probably need extensive testing before enabling it on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157520/new/ https://reviews.llvm.org/D157520 ___

[PATCH] D157520: [Driver] Replace a link to openradar with a comment. NFC

ahatanak updated this revision to Diff 549165. ahatanak added a comment. Mention that the linker bug has been fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157520/new/ https://reviews.llvm.org/D157520 Files: clang/lib/Driver/ToolChains/Cl

[PATCH] D157651: [RISCV] Rewrite CheckInvalidVLENandLMUL to avoid floating point.

craig.topper created this revision. craig.topper added reviewers: 4vtomat, kito-cheng, reames, asb. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, simoncook, arichardson. Herald added a project: All. craig.to

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 549159. AlexVlx added a comment. Switch to `__ASM` prefix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/C

[clang] 7fc6fa9 - [clang][AST] TextNodeDumper learned to output exception specifications

Author: Timo Stripf Date: 2023-08-10T20:42:34Z New Revision: 7fc6fa97edb6aedf0e25a124dee925dc6d00c69d URL: https://github.com/llvm/llvm-project/commit/7fc6fa97edb6aedf0e25a124dee925dc6d00c69d DIFF: https://github.com/llvm/llvm-project/commit/7fc6fa97edb6aedf0e25a124dee925dc6d00c69d.diff LOG: [

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fc6fa97edb6: [clang][AST] TextNodeDumper learned to output exception specifications (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix cr

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

NoQ accepted this revision. NoQ added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156474/new/ https://reviews.llvm.org/D156474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D157376: [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f29f14d0257: [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D157367: [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rG894140b4fdde: [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157367?vs=548085&id=549148#toc R

[clang-tools-extra] 894140b - [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member-init

Author: Piotr Zegar Date: 2023-08-10T19:51:09Z New Revision: 894140b4fdde10b6bff7fc99104b2292ade3c91c URL: https://github.com/llvm/llvm-project/commit/894140b4fdde10b6bff7fc99104b2292ade3c91c DIFF: https://github.com/llvm/llvm-project/commit/894140b4fdde10b6bff7fc99104b2292ade3c91c.diff LOG: [

[clang-tools-extra] 7f29f14 - [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg

Author: Piotr Zegar Date: 2023-08-10T19:51:09Z New Revision: 7f29f14d025702a04ca3e5cdd31de40c392e2799 URL: https://github.com/llvm/llvm-project/commit/7f29f14d025702a04ca3e5cdd31de40c392e2799 DIFF: https://github.com/llvm/llvm-project/commit/7f29f14d025702a04ca3e5cdd31de40c392e2799.diff LOG: [

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok marked 2 inline comments as done and an inline comment as not done. MitalAshok added a comment. It seems there were two places which relied on `T x = { xvalue_of_type_T }` being a copy-initialization: The test at https://reviews.llvm.org/D156032#inline-1509544 and that one pair constr

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. Hi @dblaikie, Could you please take a look at my response ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143967/new/ https://reviews.llvm.org/D143967 ___

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok updated this revision to Diff 549145. MitalAshok added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Fix broken libc++ pair constructor test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jyknight added a comment. In D141918#4566838 , @smeenai wrote: > $ clang -std=c++20 -O2 -c crash.cpp > cannot use musttail with unwindabort Thanks for the report. We were missing a check of `CI.isUnwindAbort()` in CoroSplit.cpp's `shouldBeMustTail()` fu

[clang] 91b10f6 - Revert "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-10T11:27:08-07:00 New Revision: 91b10f69740ec91ca80ec45323d9807c39252334 URL: https://github.com/llvm/llvm-project/commit/91b10f69740ec91ca80ec45323d9807c39252334 DIFF: https://github.com/llvm/llvm-project/commit/91b10f69740ec91ca80ec45323d9807c39252334.di

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

awarzynski added a comment. Hey @bogner , I've only skimmed through so far and it's looking great! That Include/Exclude API was not fun to use. What you are proposing here takes Options.td to a much a better place - this is a much needed and long overdue refactor. There's quite a bit of churn

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added a comment. In D155610#4575579 , @cor3ntin wrote: > @hubert.reinterpretcast It does not, Unicode characters are only escaped in > Diagnostics.cpp, and I think this is what we want. > Currently, llvm assume UTF-8 terminal, exce

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal added a comment. Great progress. Now, moving to the docs. Have you checked that the docs compile without errors and look as you would expect? Please post how it looks. Please make a note about this new checker in the clang's release docs, as we usually announce new checkers and major c

[clang] 315d1d0 - [C23] Update user-facing docs for C23

Author: Aaron Ballman Date: 2023-08-10T14:19:41-04:00 New Revision: 315d1d094f7fe3f2a28fb3658f576bea0c33c094 URL: https://github.com/llvm/llvm-project/commit/315d1d094f7fe3f2a28fb3658f576bea0c33c094 DIFF: https://github.com/llvm/llvm-project/commit/315d1d094f7fe3f2a28fb3658f576bea0c33c094.diff

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

hans added a comment. In D157334#4573902 , @aaron.ballman wrote: > I'm curious to hear what others think about this (especially @rnk and @hans). Seems reasonable to me. (Looks like the define was originally added here: https://github.com/llvm/llvm-pro

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 549117. AlexVlx added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155833/new/ https://reviews.llvm.org/D155833 Files: clang/lib/Sema/SemaCUDA.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaStmtAsm.cpp clang/test/S

[PATCH] D157637: [ASTImporter][NFC] Fix typo in testcase

danix800 created this revision. danix800 added a reviewer: balazske. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix typo in t

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 549113. AlexVlx removed a reviewer: jdoerfert. AlexVlx added a comment. Remove noise / unintended file. Add support for dealing with unsupported ASM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155833/new/ https://reviews.llvm.org/D155833 Files:

[clang-tools-extra] 13629b1 - [C2x] Support -std=c23 and -std=gnu23

Author: Aaron Ballman Date: 2023-08-10T13:57:40-04:00 New Revision: 13629b140801870feff855ca168edf6b34dbef8d URL: https://github.com/llvm/llvm-project/commit/13629b140801870feff855ca168edf6b34dbef8d DIFF: https://github.com/llvm/llvm-project/commit/13629b140801870feff855ca168edf6b34dbef8d.diff

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner updated this revision to Diff 549111. bogner added a comment. Resolve conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https://reviews.llvm.org/D157149 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/lib/Fro

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

rapidsna requested changes to this revision. rapidsna added a comment. This revision now requires changes to proceed. We should add a test to exercise when `Ty` is wrapped by other sugar types. Could you try with `typedef`? Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:573

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5690-5691 +def warn_unknown_ext : Warning<"Unknown extension kind: %0">; +def warn_cxx11_ext : Warning<"%0 is a C++11 extension">, +InGroup; +def warn_cxx14_ext : Warning<"%0 is a C++1

[PATCH] D157606: [C2x] Support -std=c23 and -std=gnu23

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13629b140801: [C2x] Support -std=c23 and -std=gnu23 (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

steakhal added a comment. Looks pretty good. Comment at: clang/docs/analyzer/checkers.rst:704 +optin.portabilityMinor.UnixAPI +" +Finds non-severe implementation-defined behavior in UNIX/Posix functions. This line should be just as long,

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2422 +static void EmitStdParUnsupportedAsm(CodeGenFunction *CGF, const AsmStmt &S) { + constexpr auto Name = "ASM__stdpar_unsupported"; + maybe prefix with `__` to avoid potential name collis

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aaron.ballman added a comment. In D157334#4574197 , @aidengrossman wrote: > It's interesting that GCC doesn't set the `_MSC_EXTENSIONS` macro with > `-fms-extensions`. It should if it wants to match the behavior of MSVC. FWIW, I filed https://gcc.gnu.o

[clang] 97dfaf4 - [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

Author: Volodymyr Sapsai Date: 2023-08-10T10:47:51-07:00 New Revision: 97dfaf4cd27814bdf9aa9d2eafc21fdb4f76c56d URL: https://github.com/llvm/llvm-project/commit/97dfaf4cd27814bdf9aa9d2eafc21fdb4f76c56d DIFF: https://github.com/llvm/llvm-project/commit/97dfaf4cd27814bdf9aa9d2eafc21fdb4f76c56d.di

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97dfaf4cd278: [modules] Fix error about the same module being defined in different .pcm files… (authored by vsapsai). Repository: rG LLVM Github M

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 549101. AlexVlx added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGStmt.cpp clan

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo updated this revision to Diff 549099. mstorsjo added a comment. Plumb the info from EmitInitializerForField through AggValueSlot and ReturnValueSlot to EmitCall. The fields/variables could use better names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 549097. AlexVlx added a comment. Add support for handling certain cases of unambiguously accelerator unsupported ASM i.e. cases where constraints are clearly mismatched. When that happens, we instead emit an `ASM__stdpar_unsupported` stub which takes as its

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5690-5691 +def warn_unknown_ext : Warning<"Unknown extension kind: %0">; +def warn_cxx11_ext : Warning<"%0 is a C++11 extension">, +InGroup; +def warn_cxx14_ext : Warning<"%0 is a C++14 e

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. In D157554#4577504 , @aaron.ballman wrote: > In D157554#4576720 , @eandrews > wrote: > >> In D157554#4576478 , >> @aaron.ballman wrote: >> >>>

[clang] bbdb0c7 - [clang][modules] Respect "-fmodule-name=" when serializing included files into a PCH

Author: Jan Svoboda Date: 2023-08-10T10:11:43-07:00 New Revision: bbdb0c7e4496b145a5e9354f951eec272695049d URL: https://github.com/llvm/llvm-project/commit/bbdb0c7e4496b145a5e9354f951eec272695049d DIFF: https://github.com/llvm/llvm-project/commit/bbdb0c7e4496b145a5e9354f951eec272695049d.diff L

[PATCH] D157559: [clang][modules] Respect "-fmodule-name=" when serializing included files into a PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbdb0c7e4496: [clang][modules] Respect "-fmodule-name=" when serializing included files into… (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

aaron.ballman added a comment. In D157554#4576720 , @eandrews wrote: > In D157554#4576478 , @aaron.ballman > wrote: > >> This feels a bit more like a functional change than a non-functional change >> because it

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 549091. donat.nagy marked 2 inline comments as done. donat.nagy added a comment. Uploading a new version based on the reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.o

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 21 inline comments as done. donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:29-30 + +using namespace clang; +using namespace ento; + steakhal wrote: > This is used quite often and hinders t

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

asmith accepted this revision. asmith added inline comments. Comment at: clang/test/CodeGen/windows-seh-async-exceptions.cpp:21 +{ +devif_Warning(""); +return 0; nit; spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. In D153536#4577187 , @vitalybuka wrote: > In D153536#4576683 , @aaron.ballman > wrote: > >> In D153536#4571435 , @vitalybuka >> wrote: >>

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

kiranchandramohan added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:156-158 +/// Parse a remark command line argument. It may be missing, disabled/enabled by +/// '-R[no-]group' or specified with a regular expression by '-Rgroup=regexp'. +/// On top of

[PATCH] D157619: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157619/new/ https://reviews.llvm.org/D157619

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm.org/D157566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D157562: [Driver][DXC] Treat stdin as HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d459b71dc28: [Driver][DXC] Treat stdin as HLSL (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 0d459b7 - [Driver][DXC] Treat stdin as HLSL

Author: Justin Bogner Date: 2023-08-10T09:52:31-07:00 New Revision: 0d459b71dc280eede85f443921240df4f7a5c6ff URL: https://github.com/llvm/llvm-project/commit/0d459b71dc280eede85f443921240df4f7a5c6ff DIFF: https://github.com/llvm/llvm-project/commit/0d459b71dc280eede85f443921240df4f7a5c6ff.diff

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa06b18940c: [libclang] Expose arguments of clang::annotate (authored by fridtjof, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 5aa06b1 - [libclang] Expose arguments of clang::annotate

Author: fridtjof Date: 2023-08-10T12:40:23-04:00 New Revision: 5aa06b18940c9b96cbf1c31da6aee3fbb92183ed URL: https://github.com/llvm/llvm-project/commit/5aa06b18940c9b96cbf1c31da6aee3fbb92183ed DIFF: https://github.com/llvm/llvm-project/commit/5aa06b18940c9b96cbf1c31da6aee3fbb92183ed.diff LOG:

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:18171 +bool Sema::CheckOverridingExplicitObjectMembers(CXXMethodDecl *New, +const CXXMethodDecl *Old) { cor3ntin wrote: > aaron.ballm

  1   2   >