[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1046 def ThreadSafetyPrecise: DiagGroup<"thread-safety-precise">; def ThreadSafetyReference : DiagGroup<"thread-safety-reference">; +def ThreadSafetyReturn : DiagGroup<"thread-safe

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. The changes to clang/www/cxx_status.html got lost during the rebase, can you fix that? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 __

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Reverts 4986f3f2f220

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139267/new/ https://reviews.llvm.org/D139267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3cf2f5c - [NFC][X86] Correct tests with wrong locations before.

Author: Freddy Ye Date: 2023-06-30T14:14:31+08:00 New Revision: 3cf2f5c4cd512548c7eff7c167fb6d8d7b21aded URL: https://github.com/llvm/llvm-project/commit/3cf2f5c4cd512548c7eff7c167fb6d8d7b21aded DIFF: https://github.com/llvm/llvm-project/commit/3cf2f5c4cd512548c7eff7c167fb6d8d7b21aded.diff LOG

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536118. FreddyYe added a comment. changes according to the new RULE3, pls review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targ

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536116. FreddyYe added a comment. Rebase for D154181 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targ

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

FreddyYe added a comment. Thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154181/new/ https://reviews.llvm.org/D154181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9256a2e0450: [x86] Add missing FeatureCMOV in frontend targets. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] a9256a2 - [x86] Add missing FeatureCMOV in frontend targets.

Author: Freddy Ye Date: 2023-06-30T13:19:15+08:00 New Revision: a9256a2e0450019aeb2dfcc3ad9fefb23d6d6f83 URL: https://github.com/llvm/llvm-project/commit/a9256a2e0450019aeb2dfcc3ad9fefb23d6d6f83 DIFF: https://github.com/llvm/llvm-project/commit/a9256a2e0450019aeb2dfcc3ad9fefb23d6d6f83.diff LOG

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154181/new/ https://reviews.llvm.org/D154181 ___

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

craig.topper added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:325 + { {"pentiumpro"}, CK_PentiumPro, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B }, + { {"i686"}, CK_i686, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B }, { {"pentium2"}, CK

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

craig.topper added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:325 + { {"pentiumpro"}, CK_PentiumPro, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B }, + { {"i686"}, CK_i686, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B }, { {"pentium2"}, CK

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. > Yes, it looks like it would be best to split off and commit some of the fixes > (cmov / the isa changes causing the attr-cpuspecific.c diffs etc.) first, > before this refactor patch. Done in https://reviews.llvm.org/D154181 Repository: rG LLVM Github Monorepo C

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The missing info is gathered from X86.td. Repository:

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald a

[PATCH] D154171: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4609b4106f3: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions… (authored by craig.topper). Repository: rG LLVM Git

[clang] b4609b4 - [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

Author: Craig Topper Date: 2023-06-29T20:58:55-07:00 New Revision: b4609b4106f3f12882434ac26d8c1c12f57d8dc7 URL: https://github.com/llvm/llvm-project/commit/b4609b4106f3f12882434ac26d8c1c12f57d8dc7 DIFF: https://github.com/llvm/llvm-project/commit/b4609b4106f3f12882434ac26d8c1c12f57d8dc7.diff

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

sameerds added a comment. In D153953#4458386 , @foad wrote: > In D153953#4458134 , @sameerds > wrote: > >> @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that >> were added for atomic opti

[PATCH] D140690: [dfsan] Support Linux loongarch64

Ami-zhang updated this revision to Diff 536091. Ami-zhang retitled this revision from "[compiler-rt][dfsan] Enable loongarch64 and add test support" to "[dfsan] Support Linux loongarch64". Ami-zhang edited the summary of this revision. Ami-zhang added a comment. Herald added subscribers: llvm-comm

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

HaohaiWen added a comment. In D154070#4461674 , @MaskRay wrote: > I'll be away for a few days and back on July 5. Clicked "Accept" if you keep > just the lld/COFF part for this patch and create another patch for > clang/lib/Driver. > > I guess @mstorsjo

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen created this revision. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Check linker earlier so that lld specific flags can be append before inputs. Just like position of other flags.

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. In D153674#4461195 , @sammccall wrote: > Sorry about the delay, and thanks for the `.i`. > > It took me a while to work out what was going on, but it looks like it's just > a bug where GCC forgets to automatic-move. > Fixed in

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. @sammccall @nridge gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. > Oh, I guess we're somehow adding a semi-resolved form of the base class type > of D into the ODR hash, which then includes details of the using-declaration. > That seems wrong -- we should either (preferably) be including only the > syntactic form of the base specif

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

jdoerfert added a comment. I would recommend to introduce `__AMDGCN_WAVEFRONT_SIZE__` as an alias for `'__AMDGCN_WAVEFRONT_SIZE` and at some point to deprecate the latter. Otherwise, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 __

[PATCH] D154070: [Driver][lld/COFF] Support DWARF fission when using LTO on Windows

HaohaiWen updated this revision to Diff 536084. HaohaiWen added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Remove driver changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/ https://reviews.llvm.o

[PATCH] D154171: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

craig.topper added a comment. In D154171#4462182 , @eopXD wrote: > ~~Do we need to do the same for v extension?~~ > > I didn't understand the problem fully, we don't need to care about v > extension here because 'v' itself adds something new to the archi

[PATCH] D154171: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154171/new/ https://reviews.llvm.org/D154171 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. > we might emit member function declarations for call sites in DWARF, for > instance So are you now leaning more toward wanting to emit the "used" declarations as well? I'm sure you don't want to implement it the way we did... I *think* the template parameter thing h

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

owenpan added a comment. Regarding commandeering, I would wait for a couple of weeks after pinging the author. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89918/new/ https://reviews.llvm.org/D89918 __

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. There aren't any variables or fields in the tests currently, waiting on D154038 because of no semicolons in their fragments. Comment at: clang/lib/ExtractAPI/API.cpp:19 #include "clang/AST/RawCommentList.h" +#include

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 536071. evelez7 added a comment. Add C++ class tests, fix exception spec fragments - Add tests for single and multiple inheritance, class methods, and functions with noexcept. - Exception spec fragments had a space included in it, moved it to separate fragm

[PATCH] D154171: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. The change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154171/new/ https://reviews.llvm.org/D154171 ___

[PATCH] D154171: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

eopXD added a comment. Do we need to do the same for v extension? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154171/new/ https://reviews.llvm.org/D154171 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added a comment. I have modified the patch to only do one thing rather than several things as the previous patch. Essentially this patch now only handles the delayed emission of the __kmpc_alloc_shared for the VLA which it could not emit in the Prolog of the function. This is now very

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536059. doru1004 retitled this revision from "[Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions" to "[Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs ". doru1004 edited the summary of this r

[PATCH] D154171: [RISCV] Mark zvkn* and zvks* extensions as enabled when all their subextensions are.

craig.topper created this revision. craig.topper added reviewers: 4vtomat, ego, kito-cheng, eopXD. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer0

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1fcce97a6af: [Clang] Fix crash in isCXXDeclarationSpecifier when

[clang] d1fcce9 - [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

Author: Shafik Yaghmour Date: 2023-06-29T15:42:18-07:00 New Revision: d1fcce97a6af872e64b365d80d5b85eb94487dc8 URL: https://github.com/llvm/llvm-project/commit/d1fcce97a6af872e64b365d80d5b85eb94487dc8 DIFF: https://github.com/llvm/llvm-project/commit/d1fcce97a6af872e64b365d80d5b85eb94487dc8.dif

[clang] f78c9be - Adjust tests in 632dd6a4ca0036009f for ARM host

Author: Yuanfang Chen Date: 2023-06-29T15:35:10-07:00 New Revision: f78c9be14d739b27875004a751283c2431220ad1 URL: https://github.com/llvm/llvm-project/commit/f78c9be14d739b27875004a751283c2431220ad1 DIFF: https://github.com/llvm/llvm-project/commit/f78c9be14d739b27875004a751283c2431220ad1.diff

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks good to me! This doesn't take care of the GNU syntax (`__attribute__((unsafe_buffer_usage))`), but this probably isn't a big deal as people can simply use the modern C++ syntax in any code for

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

efriedma added a comment. The fundamental problem here is the interaction with SFINAE; if we don't diagnose this as an error, we actually miscompile some cases. Because of that, a flag wouldn't really be "turning off the warning"; it would be enabling a non-compliant language mode that has dif

[PATCH] D140727: [XRay] Add initial support for loongarch64

MaskRay added inline comments. Comment at: llvm/test/CodeGen/LoongArch/xray-attribute-instrumentation.ll:1 +; RUN: llc --mtriple=loongarch64 %s -o - | FileCheck %s +; RUN: llc --mtriple=loongarch64 -filetype=obj %s -o %t I think you want to read my recent updates

[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164 +StringRef ArgVal = Arg->getValue(1); +if (ArgVal.startswith("-mllvm=")) { + ArgVal = ArgVal.substr(strlen("-mllvm=")); arsenm wrote: > StringRef Prefix("-mllvm=")

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536004. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index: clang/docs/AMDGPUS

[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164 +StringRef ArgVal = Arg->getValue(1); +if (ArgVal.startswith("-mllvm=")) { + ArgVal = ArgVal.substr(strlen("-mllvm=")); StringRef Prefix("-mllvm=") and then use the

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:33 + * - ``__AMD__`` + - Indicates that the code is being compiled for an AMD GPU. + * - ``__AMDGPU__`` jdoerfert wrote: > FWIW, this arguably

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 536003. ellis added a comment. Fix memory bug and add TODO about a regex/glob config. Lets wait for others to comment before I put work into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632dd6a4ca00: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1 (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 632dd6a - [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

Author: Yuanfang Chen Date: 2023-06-29T14:22:24-07:00 New Revision: 632dd6a4ca0036009febd55d95e4e1f93eeb412c URL: https://github.com/llvm/llvm-project/commit/632dd6a4ca0036009febd55d95e4e1f93eeb412c DIFF: https://github.com/llvm/llvm-project/commit/632dd6a4ca0036009febd55d95e4e1f93eeb412c.diff

[PATCH] D154070: [Driver][lld/COFF] Support DWARF fission when using LTO on Windows

MaskRay accepted this revision. MaskRay added a subscriber: mstorsjo. MaskRay added a comment. This revision is now accepted and ready to land. I'll be away for a few days and back on July 5. Clicked "Accept" if you keep just the lld/COFF part for this patch and create another patch for clang/li

[PATCH] D154070: [Driver][lld/COFF] Support DWARF fission when using LTO on Windows

MaskRay added a comment. Normally clang and lld patches are separate. You can `git log -- lld/COFF` to find who usually reviews lld/COFF code and add these folks as reviewers. Not many people set subscription rules but some may appreciate if you let know that there is such a change. Though, I ha

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; ziqingluo-90 wrote: > NoQ wrote: > > ziqing

[PATCH] D154151: [clang-tidy] Improve documentation for modernize-use-std-print check

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

rsmith added a comment. In D153003#4458323 , @ChuanqiXu wrote: > In D153003#4456595 , @rsmith wrote: > >> How to we even get into the ODR hasher here? I thought we only applied it to >> function and class definit

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 updated this revision to Diff 535983. jhuber6 added a comment. Add some checks to `stdlib.h` to ensure ABI compatibility for `div` functions. Because this patch makes us always include the LLVM libc repo when offloading, we mask off the wrappers if they were not installed by `libc`, so th

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:62 + - Defined if fast FMA instruction is available. + * - ``__AMDGCN_WAVEFRONT_SIZE`` + - Defines the wavefront size. Allowed values are 32 and 64. jdoerfert wrote: > Any reason thi

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

jdoerfert added a comment. typo in the title. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:1444 +/// alloca address where the runtime returns the device pointers. +llvm::DenseMap CaptureDeviceAddrMap; }; If it is an alloca (for sure) use `llvm::Al

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Let's move on. I described what this should look like, just for the record. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399 +DeviceID = CGF.Builder.getInt64

[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154145/new/ https://reviews.llvm.org/D154145 ___ cfe-commits mailing list cfe-

[PATCH] D154016: [clang][modules] Avoid serializing all diag mappings in non-deterministic order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. benlangmuir marked an inline comment as done. Closed by commit rG1ede7b47493f: [clang][modules] Avoid serializing all diag mappings in non-deterministic order (authored

[clang] 1ede7b4 - [clang][modules] Avoid serializing all diag mappings in non-deterministic order

Author: Ben Langmuir Date: 2023-06-29T13:17:24-07:00 New Revision: 1ede7b47493f8d8548202e5f4e4a150c11e070fd URL: https://github.com/llvm/llvm-project/commit/1ede7b47493f8d8548202e5f4e4a150c11e070fd DIFF: https://github.com/llvm/llvm-project/commit/1ede7b47493f8d8548202e5f4e4a150c11e070fd.diff

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:54 + - Defined if FMAF instruction is available (deprecated). + * - ``FP_FAST_FMAF`` + - Defined if fast FMAF instruction is available. The fma macro was actually from the opencl spe

[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker

yaxunl created this revision. yaxunl added reviewers: tra, jhuber6. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. currently clang passes -mllvm options to the device lld linker plugin when compiling HIP. This is against default clang beh

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

jdoerfert added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:33 + * - ``__AMD__`` + - Indicates that the code is being compiled for an AMD GPU. + * - ``__AMDGPU__`` FWIW, this arguably confusing use of __AMD__, and duplication of __AMDGPU__,

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

t-rasmud added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:251 +} +// CHECK-NOT: fix-it:{{.*}}:{[[@LINE-1]] Does this patch handle virtual methods? Ideally we'd like the fixed methods to have the same subt

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

aaron.ballman added a comment. In D89918#4460401 , @MyDeveloperDay wrote: > @owenpan @HazardyKnusperkeks @rymiel what are your feeling on how we should > close old clang-format reviews like this? (@aaron.ballman any thoughts on > how it should be done?

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

srhines added a comment. > They'd already have had a chance to deal with their code when this was a > warning-default-error without "ShowInSystemHeaders"? (or, if the yhaven't > picked up a new compiler often enough, and they go from "a warning we didn't > care about" to "warning-default-error-

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 test.hip -o test.o + can we add -xhip to enable HIP for files without the .hip file ext? Comment at: clang/docs/HIPSupport.rst:56 +Envir

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis added a comment. In D154014#4461076 , @rupprecht wrote: > In D154014#4457883 , @MaskRay wrote: > >>> This is a breaking change since some SCLs might use .* or (abc|def) which >>> are supported regexes but n

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 closed this revision. jyu2 added a comment. Checked in with rG085845a2acbe CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

sammccall added a comment. Sorry about the delay, and thanks for the `.i`. It took me a while to work out what was going on, but it looks like it's just a bug where GCC forgets to automatic-move. Fixed in 2f7d30dee8262746c3e8ee1f6f25be8c1ace9990

[clang] 2f7d30d - [dataflow] fix compile on gcc7

Author: Sam McCall Date: 2023-06-29T21:20:53+02:00 New Revision: 2f7d30dee8262746c3e8ee1f6f25be8c1ace9990 URL: https://github.com/llvm/llvm-project/commit/2f7d30dee8262746c3e8ee1f6f25be8c1ace9990 DIFF: https://github.com/llvm/llvm-project/commit/2f7d30dee8262746c3e8ee1f6f25be8c1ace9990.diff LO

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 535952. yaxunl added a comment. remove redundant text CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index: clang/docs/AMDGPUSupport.rst

[PATCH] D154134: [clang] Fix ASTUnit working directory handling

hamishknight created this revision. hamishknight added reviewers: bnbarham, benlangmuir. hamishknight added a project: clang. Herald added a project: All. hamishknight requested review of this revision. Herald added a subscriber: cfe-commits. Fix a couple of issues with the handling of the current

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm, tra, scchan. Herald added subscribers: kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Herald added a reviewer

[clang] 085845a - [OMP5.2] Initial support for doacross clause.

Author: Jennifer Yu Date: 2023-06-29T11:58:17-07:00 New Revision: 085845a2acbefd26d5c229338225dfd76e2c2df3 URL: https://github.com/llvm/llvm-project/commit/085845a2acbefd26d5c229338225dfd76e2c2df3 DIFF: https://github.com/llvm/llvm-project/commit/085845a2acbefd26d5c229338225dfd76e2c2df3.diff L

[PATCH] D154077: [HIP] Fix version detection for old HIP-PATH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG41a1625e07e8: [HIP] Fix version detection for old HIP-PATH (authored by yaxunl). Herald added a project: cla

[clang] 41a1625 - [HIP] Fix version detection for old HIP-PATH

Author: Yaxun (Sam) Liu Date: 2023-06-29T14:57:26-04:00 New Revision: 41a1625e07e8b20dafec11f0d138031106abfad0 URL: https://github.com/llvm/llvm-project/commit/41a1625e07e8b20dafec11f0d138031106abfad0 DIFF: https://github.com/llvm/llvm-project/commit/41a1625e07e8b20dafec11f0d138031106abfad0.dif

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

rupprecht added a comment. In D154014#4457883 , @MaskRay wrote: >> This is a breaking change since some SCLs might use .* or (abc|def) which >> are supported regexes but not valid globs. Since we have just cut clang 16.x >> this is a good time to make t

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

t-rasmud added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:5 + +// FIXME: what about possible diagnostic message non-determinism? + I have used a workaround for non-determinism by using regular expressions

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:104 + - This macro is defined when the GPU default stream kind is set to per-thread. + b-sumner wrote: > Should we include the __gfxNNN__ or __GFXN__ macros here? What about wave > size, a

[PATCH] D154123: [HIP] Start document HIP support by clang

b-sumner added inline comments. Comment at: clang/docs/HIPSupport.rst:104 + - This macro is defined when the GPU default stream kind is set to per-thread. + Should we include the __gfxNNN__ or __GFXN__ macros here? What about wave size, and CU mode? And w

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP updated this revision to Diff 535937. SeanP added a comment. fix merge conflicts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basic/Targe

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 535936. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclBase.h clan

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian created this revision. MrTrillian added reviewers: rnk, compnerd, nlopes, Jake-Egan. Herald added a subscriber: delcypher. Herald added a reviewer: ributzka. Herald added a project: All. MrTrillian requested review of this revision. Herald added a reviewer: dang. Herald added projects: c

[PATCH] D154077: [HIP] Fix version detection for old HIP-PATH

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:471 {std::string(SharePath) + "/hip/version", + std::string(ParentSharePath) + "/hip/version", std::string(BinPath) + "/.hipVers

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay added a comment. In D154043#4459446 , @simon_tatham wrote: > The details of this approach look good to me, but is this the best place to > solve it? Doing it in clang means that //every// language front end that > wants to use either of these s

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl created this revision. yaxunl added reviewers: tra, scchan, b-sumner, arsenm. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. start with example usage, predefined macros and env vars. https://reviews.llvm.org/D154123 Files: clang/

[PATCH] D154016: [clang][modules] Avoid serializing all diag mappings in non-deterministic order

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154016/new/ https://reviews.llvm.org/D154016 ___ cfe-commits mailing list cfe-com

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); erichkeane wrote: > Fznamznon

[PATCH] D154077: [HIP] Fix version detection for old HIP-PATH

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general with a minor suggestion. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:471 {std::string(SharePath) + "/hip/version", + std::string(ParentSha

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4460664 , @cor3ntin wrote: > Thanks a lot for working on this! > Do you need Aaron or myself to commit this for you? If so, which name / mail > do you want us to use? That's okay. I'm doing the rebase and I could commit

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

efriedma added a comment. I also think it makes sense to fix the alignment when we lower the metadata, not in the frontend, unless I'm missing something. It's not clear to me how "strict-align" is relevant; if sanitizer lowering is generating "align 4" loads, the relevant pointers need to be ap

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. Thanks a lot for working on this! Do you need Aaron or myself to commit this for you? If so, which name / mail do you want us to use? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139

[PATCH] D154016: [clang][modules] Avoid serializing all diag mappings in non-deterministic order

benlangmuir marked an inline comment as done. benlangmuir added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3016 for (const auto &I : *State) { -if (I.second.isPragma() || IncludeNonPragmaStates) { - Record.push_back(I.first); -

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:98 +- Implemented `P1816R0: `_ and `P2082R1: `_, + which allows CTAD for aggregates (parenthesized aggregate-initialization is not supported). -

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 535883. ychen marked 4 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNot

  1   2   3   >