[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

pengfei added a comment. It looks to me the failed unit tests might be related to this patch, please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 _

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. I have some concerns for RULE 3, especially `core_aes_pclmulqdq -> westmere` and `atom_sse4_2_movbe -> silvermont`. Sometimes, we have minor feature differences in the same generation targets

[PATCH] D137556: [POC] Clang implementation for AArch64 SME and SME2 builtins

sdesmalen updated this revision to Diff 535645. sdesmalen retitled this revision from "[POC] Clang implementation for AArch64 SME and some SME2 builtins" to "[POC] Clang implementation for AArch64 SME and SME2 builtins". sdesmalen edited the summary of this revision. sdesmalen added a comment. He

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. For comments that are already address, it's customary to mark those as "Done" to make it clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:57 + CmdArgs.push_back("-nologo"); + + if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7)) We should be also passing `-subsystem:efi_application`. Note that COFF also has

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153960/new/ https://reviews.llvm.org/D153960 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4458366 , @Hahnfeld wrote: > In D153003#4458323 , @ChuanqiXu > wrote: > >> In D153003#4456595 , @rsmith wrote: >> >>> I think the be

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

foad added a comment. In D153953#4458134 , @sameerds wrote: > @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that > were added for atomic optimizations. In particular, the mbcnt is now being > moved across/into/out of control flow

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

pravinjagtap added a comment. In D153953#4458134 , @sameerds wrote: > @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that > were added for atomic optimizations. In particular, the mbcnt is now being > moved across/into/out of cont

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:385 + StringRef ExtName = Ext.substr(1); + if (llvm::RISCVISAInfo::isSupportedExtensionWithVersion(ExtName) || + llvm::RISCVISAInfo::isSupportedExtension(ExtName)) ---

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4458323 , @ChuanqiXu wrote: > In D153003#4456595 , @rsmith wrote: > >> I think the behavior change for the testcase here is correct, though I'm not >> sure that the patch is g

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay created this revision. MaskRay added reviewers: efriedma, rjmccall, simon_tatham, samitolvanen. Herald added a subscriber: kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

pengfei added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:1324 +/// k := i*16 +/// result[k+15:k] := SignExtend(__V[j+7:7]) +/// ENDFOR j Comment at: clang/lib/Headers/avx2intrin.h:1352 +/// k := i*32 +/// result[k+31:k]

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4456595 , @rsmith wrote: > I think the behavior change for the testcase here is correct, though I'm not > sure that the patch is getting that behaviour change in the right way. Per > [temp.type]/1.4 (http://eel.is/c

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:385 + StringRef ExtName = Ext.substr(1); + if (llvm::RISCVISAInfo::isSupportedExtensionWithVersion(ExtName) || + llvm::RISCVISAInfo::isSupportedExtension(ExtName)) ---

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

Arsenic updated this revision to Diff 535630. Arsenic added a comment. Changes majorly include fixing issues pointed out by review comments : - Remove WrappingExtractAPIAction::prepareToExecuteAction() - Move knownInputFiles from Base action to ExtractAPIFrontendAction - Fix naming of MacroCallba

[PATCH] D153714: [NFC] Add missing cpu tests in predefined-arch-macros.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG548e08c3f635: [NFC] Add missing cpu tests in predefined-arch-macros.c (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153714/new/ http

[clang] 548e08c - [NFC] Add missing cpu tests in predefined-arch-macros.c

Author: Freddy Ye Date: 2023-06-29T13:30:13+08:00 New Revision: 548e08c3f635f72519d3bcadcc71cca7d31d1e6d URL: https://github.com/llvm/llvm-project/commit/548e08c3f635f72519d3bcadcc71cca7d31d1e6d DIFF: https://github.com/llvm/llvm-project/commit/548e08c3f635f72519d3bcadcc71cca7d31d1e6d.diff LOG

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder added a comment. I think this makes https://reviews.llvm.org/D153653 unnecessary(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mail

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1022 + +if (DiscardResult) + return this->emitPopPtr(E); shafik wrote: > Could you just pass `DiscardResult` to `visitLocalInitializer` Nope, the `visitInitializer` funct

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. In D151567#4458232 , @hubert.reinterpretcast wrote: > @azhan92, please incorporate a revert of > https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it > is an `XFAIL`. once the problem is

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. @azhan92, rG6ace52e5e49cff6664fc301fa4985fc28c88f26f and rGc14df228ff3ca73e3c5c00c495216bba56665fd5 should also be

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. @azhan92, please incorporate a revert of https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it is an `XFAIL`. once the problem is fixed, the test will end up being an "unexpected success" unless we remove the `XFAIL`. Repository:

[PATCH] D153854: [clang][dataflow] Make `getThisPointeeStorageLocation()` return an `AggregateStorageLocation`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74d8455ba6a1: [clang][dataflow] Make `getThisPointeeStorageLocation()` return an… (authored by mboehme). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rGd36324866ee1: [clang][dataflow] Initialize fields of anonymous records correctly. (authored by mboehme). R

[clang] d363248 - [clang][dataflow] Initialize fields of anonymous records correctly.

Author: Martin Braenne Date: 2023-06-29T04:07:04Z New Revision: d36324866ee1fb4d1c26552b6b686a463d2b448f URL: https://github.com/llvm/llvm-project/commit/d36324866ee1fb4d1c26552b6b686a463d2b448f DIFF: https://github.com/llvm/llvm-project/commit/d36324866ee1fb4d1c26552b6b686a463d2b448f.diff LOG

[clang] 74d8455 - [clang][dataflow] Make `getThisPointeeStorageLocation()` return an `AggregateStorageLocation`.

Author: Martin Braenne Date: 2023-06-29T04:07:08Z New Revision: 74d8455ba6a19d9eeaa561fd0eccc8cbf5351a47 URL: https://github.com/llvm/llvm-project/commit/74d8455ba6a19d9eeaa561fd0eccc8cbf5351a47 DIFF: https://github.com/llvm/llvm-project/commit/74d8455ba6a19d9eeaa561fd0eccc8cbf5351a47.diff LOG

[clang] a806ec4 - [analyzer] Refactor codes in findMethodDecl()

Author: Manna, Soumi Date: 2023-06-28T20:40:02-07:00 New Revision: a806ec4857c2c662c89755edba56d893ae1beeb4 URL: https://github.com/llvm/llvm-project/commit/a806ec4857c2c662c89755edba56d893ae1beeb4 DIFF: https://github.com/llvm/llvm-project/commit/a806ec4857c2c662c89755edba56d893ae1beeb4.diff

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rGa806ec4857c2: [analyzer] Refactor codes in findMethodDecl() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152194/new/ https://reviews.l

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining added a comment. In D140727#4019019 , @SixWeining wrote: > D140725 is abandoned. Let me defer this > change until we support 64bit PC-relative relocation for `SymA - SymB`. Update: R_LARCH_64_PCREL can be e

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 added a comment. Thanks. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier = getOpenMPSimpleClauseTyp

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535601. jyu2 added a comment. Thanks Alexey's review. This is address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/Ope

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02f94a655fb6: [RISCV] Bump vector crypto to v1.0.0-rc1 (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 02f94a6 - [RISCV] Bump vector crypto to v1.0.0-rc1

Author: 4vtomat Date: 2023-06-28T19:53:07-07:00 New Revision: 02f94a655fb6ee494df6cd9e136e7ab713be2043 URL: https://github.com/llvm/llvm-project/commit/02f94a655fb6ee494df6cd9e136e7ab713be2043 DIFF: https://github.com/llvm/llvm-project/commit/02f94a655fb6ee494df6cd9e136e7ab713be2043.diff LOG:

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

4vtomat added a comment. In D153836#4452236 , @asb wrote: > Agreed that looking at > https://github.com/riscv/riscv-crypto/compare/v20230531...v20230620 there are > no changes that need to be reflected on the LLVM side beyond the version bump > here. L

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 added a comment. These updated tests pass locally for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

eastb233 added a comment. In D153321#4455776 , @ABataev wrote: > LG Thanks a lot for the review. And I do not have commit access, could you please help commit the patch And my name is "Zhiheng Xie", email is "eastb...@qq.com" Repository: rG LLVM Git

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

sameerds requested review of this revision. sameerds added a comment. @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that were added for atomic optimizations. In particular, the mbcnt is now being moved across/into/out of control flow because it is no longer convergent. I

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

This revision was automatically updated to reflect the committed changes. Closed by commit rG7372c0d46d21: [CLANG] Fix potential integer overflow value in getRVVTypeSize() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153146/new/

[clang] 7372c0d - [CLANG] Fix potential integer overflow value in getRVVTypeSize()

Author: Manna, Soumi Date: 2023-06-28T19:25:53-07:00 New Revision: 7372c0d46d2185017c509eb30910b102b4f9cdaa URL: https://github.com/llvm/llvm-project/commit/7372c0d46d2185017c509eb30910b102b4f9cdaa DIFF: https://github.com/llvm/llvm-project/commit/7372c0d46d2185017c509eb30910b102b4f9cdaa.diff

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 ___

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 updated this revision to Diff 535600. jhuber6 added a comment. Hack around the `string` problem. GNU likes to provide different prototypes for C++. Manually disable this for now. Unsure if this will have reasonable fallout, but it seems bizarre that `string.h` would define C++ constructs

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added a comment. In D146777#4457839 , @paulkirth wrote: > In D146777#4457209 , @MaskRay wrote: > >> As mentioned, you may consider landing llvm patch then wait a bit so that >> (a) people can experiment w

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 added a comment. For reference, here is what one of the newly generated headers looks like that is used. #ifndef __LLVM_LIBC_DECLARATIONS_STDIO_H #define __LLVM_LIBC_DECLARATIONS_STDIO_H #ifndef __LIBC_ATTRS #define __LIBC_ATTRS #endif #ifdef __cplusplus extern "C" {

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, sivachandra, lntue, michaelrj, tra, JonChesterfield. Herald added projects: libc-project, All. Herald added a subscriber: libc-commits. jhuber6 requested review of this revision. Herald added subscribers: cfe-commit

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay added a comment. > This is a breaking change since some SCLs might use .* or (abc|def) which are > supported regexes but not valid globs. Since we have just cut clang 16.x this > is a good time to make this change. My user has some ignore lists, but there is no `^[a-z]+:.*\(` or `^[a-z]

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4457209 , @MaskRay wrote: > As mentioned, you may consider landing llvm patch then wait a bit so that (a) > people can experiment with the clang patch better (b) prevent the llvm/clang > patches to be both reverted,

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

dblaikie accepted this revision. dblaikie added a comment. In D153898#4457263 , @chiyuze wrote: > Regarding cost, only BPF target triggers this debug info generation for > extern variables. Ah, OK - if that's what you need for BPF and it doesn't affect

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

avl added a comment. this LGTM. please, wait if James has any concern. Comment at: llvm/unittests/Support/raw_ostream_test.cpp:525 + ASSERT_TRUE(Perms) << "should be able to get permissions"; + // Verify that writeToOutput doesn't set exe bit. + EXPECT_EQ(Perms.get(), llvm::

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: MaskRay, phosek, vitalybuka, samsonov, hctim. ellis updated this revision to Diff 535560. ellis added a comment. ellis published this rev

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis abandoned this revision. ellis added a comment. Moved to https://reviews.llvm.org/D154014 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152762/new/ https://reviews.llvm.org/D152762 ___ cfe-commits

[PATCH] D154016: [clang][modules] Avoid serializing all diag mappings in non-deterministic order

benlangmuir created this revision. benlangmuir added reviewers: steven_wu, jansvoboda11, akyrtzi. Herald added a subscriber: mgrang. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When writing a pcm

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 535559. evelez7 marked 6 inline comments as done. evelez7 added a comment. Address some review feedback Remove RK_Struct, RK_Union from CXXClassRecord::classof, use std::string for AccessControl, style and remove unused imports Repository: rG LLVM Github

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5103 -if (Addr.getAlignment() < Align && +if (CallInfo.isDelegateCall()) { + NeedCopy = false; rnk wrote: > akhuang wrote: > > I think the problem is that it tries

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5103 -if (Addr.getAlignment() < Align && +if (CallInfo.isDelegateCall()) { + NeedCopy = false; akhuang wrote: > I think the problem is that it tries to do a copy here b

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang added a comment. In D154007#4457561 , @efriedma wrote: > I'm not confident that isUsed() works the way you want it to in this context. > In particular, if the code in question runs before we've translated the > whole translation unit, the isUse

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

rnk added a comment. Can you please add a test case for the issue that caused the revert? I wanted to dig into that to try to understand why the extra copy was being emitted. I think you mentioned it has something to do with increasing the alignment. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

efriedma added a comment. I'm not confident that isUsed() works the way you want it to in this context. In particular, if the code in question runs before we've translated the whole translation unit, the isUsed() bit could change. If you want that's more obviously safe, you could just check i

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik added a comment. I think I am going to land this as is and if we can come up w/ an example that covers the `annot_typename` I can do a follow-up. As this is now it fixes a crash bug. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn added a comment. Hi Piotr - I'm sorry for the delay in getting back to you. Thank you again for your review comments. I did my best trying to get the right combination of matchers that limit the candidates and allow the exceptions that we want. I wasn't successful in figuring out a way t

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn updated this revision to Diff 535546. Caslyn marked 12 inline comments as done. Caslyn added a comment. Changes per review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152953/new/ https://reviews.llvm.org/D152953 Files: clang-tools-extr

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

owenpan added a comment. This is no longer an issue in version 17, e.g. 7a4cdbe : $ clang-format void main() { // clang-format off #define Sum(x, y) ((x) + (y)) Sum(1, 2); #undef Sum // clang

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

MaskRay added a comment. > This patch is required so that we can still use kconfig in such BPF programs > compiled from C++. Assuming that you mean https://www.kernel.org/doc/html/next/kbuild/kconfig-language.html#kconfig-language , how is Kconfig relevant here? Clang BPF supports `-mcpu=v[12

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

MaskRay added a comment. I wonder whether you have ready-to-use instructions to test this for folks who are not familiar with Linux kernel/eBPF. (I happened to start to read eBPF one week ago, but I guess it would take some time for me to be more familiar with it, even if I contributed some stu

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

owenpan accepted this revision. owenpan added a comment. In D153926#4456833 , @schittir wrote: > Not sure what clang-format wants. I hope it likes this patch. The clang-format part LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 8ed7aa59f489715d39d32e72a787b8e75cfda151

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

chiyuze added a comment. Regarding cost, only BPF target triggers this debug info generation for extern variables. There is no impact on x86 builds of clang: Without patch: bloaty build/RelWithDebInfo/83d47ba15a1229a21aaca8a8d6a33e0e90aabfd4/bin/clang FILE SIZEVM SIZE ---

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

jrbyrnes added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3328-3330 + CompileDeviceOnly = C.getDriver().offloadDeviceOnly(); + Relocatable = Args.hasFlag(options::OPT_fgpu_rdc, + options::OPT_fno_gpu_rdc, /*Default=*/false);

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

jrbyrnes updated this revision to Diff 535519. jrbyrnes marked 3 inline comments as done. jrbyrnes added a comment. Address Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/c

[clang] fe65043 - HIP: Directly call floor builtins

Author: Matt Arsenault Date: 2023-06-28T16:57:53-04:00 New Revision: fe65043a67c85345887339f371cca1a0c735a639 URL: https://github.com/llvm/llvm-project/commit/fe65043a67c85345887339f371cca1a0c735a639 DIFF: https://github.com/llvm/llvm-project/commit/fe65043a67c85345887339f371cca1a0c735a639.diff

[PATCH] D153600: Implement -frecord-command-line for XCOFF

scott.linder added a comment. Sorry for the delay in review, I am not too familiar with XCOFF so I was hoping someone else would take a look first. If my understanding of the COFF docs I could find is correct then this LGTM save for some nits/suggestions Comment at: llvm/lib

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added a comment. As mentioned, you may consider landing llvm patch then wait a bit so that (a) people can experiment with the clang patch better (b) prevent the llvm/clang patches to be both reverted, if some issue has been identified with the llvm patch. (Don't worry that a feature doe

[PATCH] D154000: HIP: Directly call round builtins

arsenm created this revision. arsenm added reviewers: JonChesterfield, yaxunl, jhuber6. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Pretty sure these lround->round cases are just wrong https://reviews.llvm.org/D154000 Files: clang/li

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

HazardyKnusperkeks added a comment. Is this still an issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89918/new/ https://reviews.llvm.org/D89918 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D153890: [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cf8b982042e: [clang] Fix checking the equality comparator of base classes in… (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES

[clang] 3cf8b98 - [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

Author: Nikolas Klauser Date: 2023-06-28T13:34:02-07:00 New Revision: 3cf8b982042e91d9aabb880ccc7a556256187ff9 URL: https://github.com/llvm/llvm-project/commit/3cf8b982042e91d9aabb880ccc7a556256187ff9 DIFF: https://github.com/llvm/llvm-project/commit/3cf8b982042e91d9aabb880ccc7a556256187ff9.dif

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3328-3330 + CompileDeviceOnly = C.getDriver().offloadDeviceOnly(); + Relocatable = Args.hasFlag(options::OPT_fgpu_rdc, + options::OPT_fno_gpu_rdc, /*Default=*/false); -

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. new changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#4456864 , @aaron.ballman wrote: > I don't think it's correct to assume that all string arguments to attributes > are unevaluated, but it is hard to tell where to draw the line sometimes. > Backing up a step, as I un

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 535491. sammccall added a comment. rebase, primarily on the SAT-inputs-are-ordered change (SetVector etc) clarify that Formula::print output is supposed to be reliably stable. This is useful for testing downstream analyses: having a representation of formul

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a comment. In D105759#4456864 , @aaron.ballman wrote: > I don't think it's correct to assume that all string arguments to attributes > are unevaluated, but it is hard to tell where to draw the line sometimes. > Backing up a step, as

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456872 , @aaron.ballman wrote: > In D152818#4456797 , @zahiraam > wrote: > >> In D152818#4456717 , >> @aaron.ballman wrote: >> >>>

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. I checked the ISA manual about mbcnt and I agree that its value should only depend on thread position in warp and not on CFG. It is possible that the side effect of preventing it from merging

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535489. Fznamznon added a comment. Rebase, don't use MaybeCreateExprWithCleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rs

[clang] 82a3969 - Revert "[Clang] Reset FP options before function instantiations"

Author: Serge Pavlov Date: 2023-06-29T02:07:41+07:00 New Revision: 82a3969d710f5fb7a2ee4c9afadb648653923fef URL: https://github.com/llvm/llvm-project/commit/82a3969d710f5fb7a2ee4c9afadb648653923fef DIFF: https://github.com/llvm/llvm-project/commit/82a3969d710f5fb7a2ee4c9afadb648653923fef.diff

[clang] bf8e92c - HIP: Use frexp builtins in math headers

Author: Matt Arsenault Date: 2023-06-28T15:06:54-04:00 New Revision: bf8e92c0e792cbe3c9cc50607a1e33c6912ffd0e URL: https://github.com/llvm/llvm-project/commit/bf8e92c0e792cbe3c9cc50607a1e33c6912ffd0e DIFF: https://github.com/llvm/llvm-project/commit/bf8e92c0e792cbe3c9cc50607a1e33c6912ffd0e.diff

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

jrbyrnes updated this revision to Diff 535484. jrbyrnes added a comment. Use member variabls + add diagnostic + tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/clang/Driver/Op

[PATCH] D149716: clang: Use new frexp intrinsic for builtins and add f16 version

arsenm closed this revision. arsenm added a comment. 85bdea023f5116f789095b606554739403042a21 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149716/new/ https://reviews.llvm.org/D149716 __

[clang] 85bdea0 - clang: Use new frexp intrinsic for builtins and add f16 version

Author: Matt Arsenault Date: 2023-06-28T14:50:17-04:00 New Revision: 85bdea023f5116f789095b606554739403042a21 URL: https://github.com/llvm/llvm-project/commit/85bdea023f5116f789095b606554739403042a21 DIFF: https://github.com/llvm/llvm-project/commit/85bdea023f5116f789095b606554739403042a21.diff

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added a subscriber: cfe-commits. probinson added a comment. + cfe-commits which didn't get added automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 ___ cfe-commits mailing list

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

dblaikie added a comment. Got some details on how much this costs? (eg: `bloaty` comparison for a clang bootstrap with/without this patch applied?) Could you provide a quick summary of why this debug info is required? The definition should be provided in whatever translation unit defines the var

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 535472. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

zibi accepted this revision. zibi added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153580/new/ https://reviews.llvm.org/D153580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

aaron.ballman added a comment. In D152818#4456797 , @zahiraam wrote: > In D152818#4456717 , @aaron.ballman > wrote: > >> In D152818#4456510 , @zahiraam >> wrote: >> >>>

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a comment. I don't think it's correct to assume that all string arguments to attributes are unevaluated, but it is hard to tell where to draw the line sometimes. Backing up a step, as I understand P2361 , an unevaluated string is one which is

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7374 auto *E = ExprWithCleanups::Create( Context, SubExpr, Cleanup.cleanupsHaveSideEffects(), Cleanups); Because we may potentially pass some cleanups here (which are outs

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3335-3337 +bool IsRDCMode = Args.hasFlag(options::OPT_fgpu_rdc, + options::OPT_fno_gpu_rdc, false); +bool DeviceOnly = C.getDriver().offloadDeviceOnly(); ---

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 535466. schittir added a comment. Not sure what clang-format wants. I hope it likes this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153926/new/ https://reviews.llvm.org/D153926 Files: clang/include/clang/AST/RawCommentList.h clang/in

  1   2   3   >