[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Thanks for the patch! I think this is a nice and general solution, which rather than solving just a specific problem (e.g. highlighting of `new` as an operator vs. a keyword), gives

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

ikudrin added a comment. In D149119#4312518 , @simon_tatham wrote: > Do LLVM's current portability goals include the constraint that you can only > build LLVM for a platform it can also target? If not, then there surely still > needs to be //some// kin

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:329 +static void +builtinTransferScopeEnd(const CFGScopeEnd &Elt, +TypeErasedDataflowAnalysisState &InputState) { xazax.hun wrote: >

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b55e9117ebb: [RISCV] Add MC support of RISCV zcmp Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 6b55e91 - [RISCV] Add MC support of RISCV zcmp Extension

Author: WuXinlong Date: 2023-05-08T14:29:50+08:00 New Revision: 6b55e9117ebbd32d66b6f6ad12326a6b2acaef58 URL: https://github.com/llvm/llvm-project/commit/6b55e9117ebbd32d66b6f6ad12326a6b2acaef58 DIFF: https://github.com/llvm/llvm-project/commit/6b55e9117ebbd32d66b6f6ad12326a6b2acaef58.diff LOG

[PATCH] D150089: [LoongArch] Support fcc* (condition flag) registers in inlineasm clobbers

SixWeining created this revision. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150089 Files: clang/lib/Basic/Ta

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5473 + if (Right.isOneOf(tok::kw___attribute, TT_AttributeMacro)) +return true; + HazardyKnusperkeks wrote: > Does changing this return value make no difference? In other words

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 ___

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/lambda.cpp:92 + static_assert(foo() == 1); // expected-error {{not an integral constant expression}} +} + tbaeder wrote: > aaron.ballman wrote: > > How about some tests like: > > ``` > > constexpr

[PATCH] D150087: [Clang] Support more stdio builtins

tbaeder added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:102 // std libcall builtins are implemented. static SmallDenseMap F128Builtins{ + {Builtin::BI__builtin___fprintf_chk, "__fprintfieee128"}, The size should be increased I guess?

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 520253. VincentWu marked 3 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D150087: [Clang] Support more stdio builtins

qiucf created this revision. qiucf added reviewers: nemanjai, craig.topper, PowerPC, tuliom, tstellar. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add more builtins

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 520247. jaredgrubb added a comment. Update `ClangFormatStyleOptions.rst` as requested by the auto-comment (thanks auto-bot!). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 Files: clang/docs/ClangFo

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. Some implementation notes: - The implementation was modeled after `QualifierAlignmentFixer` and `sortCppIncludes`. - the additions to the `.bazel`/`.gn` build files was done naively based on searching for where "QualifierFixerTest" appeared in the repo; I can't reall

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb created this revision. jaredgrubb added reviewers: benhamilton, egorzhdan, owenpan, HazardyKnusperkeks. jaredgrubb added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, MyDeveloperDay. Herald added a comm

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

owenpan added a comment. In D149562#4312573 , @sstwcw wrote: > The port list thing and the comment thing work fine for now, except > when there is a comment for the first port. The comment on the first > line would cause the port list to be indented, lik

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 520237. ccotter marked an inline comment as done. ccotter added a comment. - Fix compile for non-libc++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:481 + // CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead + // CHECK-FIXES: for (auto It :

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 520232. ccotter added a comment. Feedback and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 10 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:477 + + for (S::const_iterator It = cbegin(Ss), E = cend(Ss); It != E; ++It) { +printf("s4 has value %d\n", (*It

[clang] ad5bed5 - Revert "[clang] Make predefined expressions string literals under -fms-extensions"

Author: Arthur Eubanks Date: 2023-05-07T16:51:02-07:00 New Revision: ad5bed5372f3f73a07f0b98a05444e7acda2b9d9 URL: https://github.com/llvm/llvm-project/commit/ad5bed5372f3f73a07f0b98a05444e7acda2b9d9 DIFF: https://github.com/llvm/llvm-project/commit/ad5bed5372f3f73a07f0b98a05444e7acda2b9d9.diff

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 520215. kushanam added a comment. removing bf16 specific registers classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976 Files: clang/include/clang/Basic/Builtin

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 520210. kushanam added a comment. Addressing the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added a comment. In D150057#4325350 , @HazardyKnusperkeks wrote: > I have to say, I don't understand it, but I believe you. Why is continuing, > when the token is finalized the right thing? See D150057#inline-1449546

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" + "#ifdef BAR\n" +

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

faisalv created this revision. faisalv added reviewers: aaron.ballman, shafik, royjacobson. faisalv added a project: clang. Herald added a subscriber: pengfei. Herald added a project: All. faisalv requested review of this revision. Herald added a subscriber: cfe-commits. See issue https://github.c

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4371 +incorrect code, leading to an ABI mismatch. This case is prevented by emitting a +diagnostic. + Suggestion: ``` ``math.h`` defines the typedefs ``float_t`` and ``double_t`` base

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; aaron.ballman wrote: > junaire wrote:

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4514-4515 +// Apply this logic for parens that are not function attribute macros. +if ((Left.is(tok::r_paren) && Left.isNot(TT_AttributeParen)) && +canBeObjCSelectorComponent

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I have to say, I don't understand it, but I believe you. Why is continuing, when the token is finalized the right thing? Comment at: clang/unittests/Format/FormatTestComments.cpp:4319 /\ -/ +/

[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. > Separating the changes into two patches would only prolong this process and > potentially delay the completion of this task. I understand the concern, but in practice it's actu

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG856f384bf945: [clang] Make predefined expressions string literals under -fms-extensions (authored by aeubanks). Changed prior to commit: https://r

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. added a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 856f384 - [clang] Make predefined expressions string literals under -fms-extensions

Author: Arthur Eubanks Date: 2023-05-07T11:27:02-07:00 New Revision: 856f384bf94513c89e754906b7d80fbe5377ab53 URL: https://github.com/llvm/llvm-project/commit/856f384bf94513c89e754906b7d80fbe5377ab53 DIFF: https://github.com/llvm/llvm-project/commit/856f384bf94513c89e754906b7d80fbe5377ab53.diff

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3164 } - return false; Drop this change Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:650 +LLVM_DEBUG( +

[PATCH] D150072: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150072 Files: c

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5545f1bbd4e1: [clang-tidy][NFC] Split bugprone-exception-escape tests (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ http

[clang-tools-extra] 5545f1b - [clang-tidy][NFC] Split bugprone-exception-escape tests

Author: Piotr Zegar Date: 2023-05-07T17:56:47Z New Revision: 5545f1bbd4e18b9ffda993ee13460d417194941a URL: https://github.com/llvm/llvm-project/commit/5545f1bbd4e18b9ffda993ee13460d417194941a DIFF: https://github.com/llvm/llvm-project/commit/5545f1bbd4e18b9ffda993ee13460d417194941a.diff LOG: [

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 520195. jaredgrubb added a comment. Address review feedback about `code/endcode`. Otherwise the patch is the same and I hope ready for merge? I'd love to get a green check :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://revi

[PATCH] D150071: [clang-tidy] Fix bugprone-assert-side-effect to actually give warnings

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Some time ago a pa

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! > A lot of our test files uses macros to differentiate between specific C++ > standards, why not do that here too? It's not that easy, because the #ifdef lines do not remo

[PATCH] D149899: [clang-tidy] Support SystemHeaders in .clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG26f476286fbc: [clang-tidy] Support SystemHeaders in .clang-tidy (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149899/new/ https

[clang-tools-extra] 26f4762 - [clang-tidy] Support SystemHeaders in .clang-tidy

Author: Carlos Galvez Date: 2023-05-07T16:36:30Z New Revision: 26f476286fbcb5cde51176abb2d3c6c0986bc410 URL: https://github.com/llvm/llvm-project/commit/26f476286fbcb5cde51176abb2d3c6c0986bc410 DIFF: https://github.com/llvm/llvm-project/commit/26f476286fbcb5cde51176abb2d3c6c0986bc410.diff LOG:

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

Mordante created this revision. Mordante added a reviewer: aaron.ballman. Herald added a project: All. Mordante updated this revision to Diff 520185. Mordante added a comment. Mordante edited the summary of this revision. Mordante published this revision for review. Herald added a project: clang. H

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Well done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150057/new/ https://reviews.llvm.org/D150057 ___

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

jrtc27 added a comment. So GCC gives me: warning: ‘stdcall’ attribute directive ignored [-Wattributes] when trying to use `__attribute__((stdcall))` on m68k, which matches the fact it's only mentioned in the manage for the x86 option. Interestingly it seems to ICE during expand when I use -m

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 520170. VincentWu marked 6 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

alvinhochun updated this revision to Diff 520158. alvinhochun added a comment. Apply suggestions: remove TODO, put negative tests in the same file as positive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149579/new/ https://reviews.llvm.or

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xry111 added a comment. In D149946#4324877 , @SixWeining wrote: > In D149946#4324803 , @xen0n wrote: > >> From a LoongArch developer's perspective, it may be better to only enable >> UAL for LA464 and other supp

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. In D149946#4324803 , @xen0n wrote: > From a LoongArch developer's perspective, it may be better to only enable UAL > for LA464 and other supporting models, instead of for the generic > `loongarch64` model too. This is because

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. @rZhBoYao are you still working on this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139586/new/ https://reviews.llvm.org/D139586 ___ cfe-commits mailing list cfe-comm

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder updated this revision to Diff 520155. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeEmitter.h clang/lib/AST/In

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:875 1 ? 0 : 1; +sizeof(A); +alignof(A); aaron.ballman wrote: > Let's make sure we still reject this: > ``` > constexpr int oh_my() { > int x = 0; > sizeof(int[x++]); //

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/lambda.cpp:92 + static_assert(foo() == 1); // expected-error {{not an integral constant expression}} +} + aaron.ballman wrote: > How about some tests like: > ``` > constexpr int call_thru_func_ptr

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520154. cor3ntin added a comment. Update commit message and add comment referencing the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs

[PATCH] D149837: [clang][Interp] Fix ignoring CompoundLiteralExprs

tbaeder updated this revision to Diff 520153. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149837/new/ https://reviews.llvm.org/D149837 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AS