[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 created this revision. HerrCai0907 added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch wants to fix inline friend decl like t

[PATCH] D148908: [Driver][NFC] Simplify code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3a5a965a14: [Driver][NFC] Simplify code. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148908/new/ https://reviews.llvm.org/D14

[clang] 8e3a5a9 - [Driver][NFC] Simplify code.

Author: Jianjian GUAN Date: 2023-04-23T10:56:27+08:00 New Revision: 8e3a5a965a14f3d40c0ef07456e244509358abd7 URL: https://github.com/llvm/llvm-project/commit/8e3a5a965a14f3d40c0ef07456e244509358abd7 DIFF: https://github.com/llvm/llvm-project/commit/8e3a5a965a14f3d40c0ef07456e244509358abd7.diff

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 516110. tianshilei1992 added a comment. Fix two test failres. It looks like not working on AMDGPU because of the global read on the host is not correct. Needs to investigate more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

0x59616e added a comment. LGTM. Thanks ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/ https://reviews.llvm.org/D147481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 reopened this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. In D142569#4290109 , @ronlieb wrote: > @tianshilei1992 this seems to have broken the amdgpu buildbot, could you > please address qui

[PATCH] D142569: [OpenMP] Introduce kernel environment

ronlieb added a comment. @tianshilei1992 this seems to have broken the amdgpu buildbot, could you please address quickly ? or revert and fix ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569

[PATCH] D142569: [OpenMP] Introduce kernel environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35cfadfbe2de: [OpenMP] Introduce kernel environment (authored by tianshilei1992). Herald added a subscriber: hoy. Repository: rG LLVM Github Monor

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/ https://reviews.llvm.org/D147481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149006: [llvm][Support] Replace `%` operator with `&` in `Align::isAligned(...)`

Stoorx created this revision. Herald added a project: All. Stoorx requested review of this revision. Herald added a project: LLVM. Since the function `Align::value()` ALWAYS returns power of 2, it is easier to check reminder by conjunction with mask, which is `(Pow2Value - 1)`. Repository: rG

[libunwind] f6320f5 - [libunwind] [SEH] Clear DISPATCHER_CONTEXT when initializing a cursor

Author: Martin Storsjö Date: 2023-04-22T22:47:45+03:00 New Revision: f6320f5e0e63268049086d17e903ee9bc80a996d URL: https://github.com/llvm/llvm-project/commit/f6320f5e0e63268049086d17e903ee9bc80a996d DIFF: https://github.com/llvm/llvm-project/commit/f6320f5e0e63268049086d17e903ee9bc80a996d.diff

[PATCH] D149003: [clang] Add test for CWG1821

Endill created this revision. Endill added reviewers: shafik, clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : My clarification in “Where can namespace-s

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 516088. tianshilei1992 added a comment. add the last test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp c

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516087. Krishna-13-cyber added a comment. - Apologies for uploading some other/incorrect diff - Updated Diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: aaron.ballman, tbaeder, Quuxplusone. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch solves the issue pointed

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. After reading some threads (https://github.com/OpenMP/spec/issues/2178#issue-622053885 and https://github.com/OpenMP/spec/issues/1870), I think `has_device_addr` is not supposed to have any semantics about creating a mapping, especially in `https://github.com/Op

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 updated this revision to Diff 516086. tianshilei1992 added a comment. Herald added subscribers: jplehr, sunshaoce. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 Files: clang/lib/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 516081. junaire added a comment. Rebuild, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/inclu

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 516080. junaire added a comment. Break the IsSemiMissing/ repl_input_end parts out from the Value part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is the first part of the below RFC: https://discourse.llvm.org/t/rfc-handle-execution-results-in-clang-repl/68493

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. In D141824#4289752 , @argentite wrote: > I made patch with both precompiled library and without cstdio. D148992 > > > @dyung We can also enable this now on PS4/5 if you are interested. Sure. Plea

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

mehdi_amini added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491 +mapTypes = exitDataOp.getMapTypes(); +mapperFunc = false; +return success(); This line is not needed afte

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. @steakhal your comments are fixed. Thanks for the review. Comment at: clang/lib/StaticAnalyzer/Checkers/DivZeroChecker.cpp:108-109 + if ((stateNotZero && stateZero)) { +std::vector taintedSyms = getTaintedSymbols(C.getState(), *DV); +if (!tainte

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 516077. dkrupp marked 13 inline comments as done. dkrupp added a comment. -getTaintedSymbols(.) -> getTaintedSymbolsImpl() proxy function introduced for interface safety -Other minor fixes based on comments from @steakhal CHANGES SINCE LAST ACTION https://

[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Move areStatementsIde

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added a comment. I made patch with both precompiled library and without cstdio. D148992 @dyung We can also enable this now on PS4/5 if you are interested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker

argentite created this revision. Herald added a project: All. argentite added reviewers: bcain, zhuhan0, sgraenitz, v.g.vassilev. argentite published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some platforms do not have a working linker present

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 516061. argentite added a comment. Herald added a subscriber: ormris. Use virtual file system to store CUDA fatbinaries in memory Adapted Interpreter tests to use the CompilerBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 _

[PATCH] D148987: [clang][Interp] Check Neg ops for errors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not sure what to do with the float case here, m

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

Mordante added a comment. One suggestion for the commit message either use `[[maybe_unused]]` or `-Wno-unused` that way the unrelated messages aren't shown in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://r

[clang-tools-extra] 1d90376 - [clang-tidy][NFC] Fix documentation for performance-avoid-endl

Author: Piotr Zegar Date: 2023-04-22T10:54:51Z New Revision: 1d90376a48406336ed73d3fc3f8f6aa90f90cb0f URL: https://github.com/llvm/llvm-project/commit/1d90376a48406336ed73d3fc3f8f6aa90f90cb0f DIFF: https://github.com/llvm/llvm-project/commit/1d90376a48406336ed73d3fc3f8f6aa90f90cb0f.diff LOG: [

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd893308b5d4: [clang-tidy] Add `performance-avoid-endl` check (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14831

[clang-tools-extra] cd89330 - [clang-tidy] Add `performance-avoid-endl` check

Author: AMS21 Date: 2023-04-22T10:50:51Z New Revision: cd893308b5d4d058b8ec6a2c4b00843d89e25552 URL: https://github.com/llvm/llvm-project/commit/cd893308b5d4d058b8ec6a2c4b00843d89e25552 DIFF: https://github.com/llvm/llvm-project/commit/cd893308b5d4d058b8ec6a2c4b00843d89e25552.diff LOG: [clang-

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu added inline comments. Comment at: lld/ELF/InputSection.h:404 -static_assert(sizeof(InputSection) <= 152, "InputSection is too big"); +static_assert(sizeof(InputSection) <= 160, "InputSection is too big"); kito-cheng wrote: > Why we need this change

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D148982: [clang][Interp] Fix ignoring conditional operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 516043. VincentWu marked 2 inline comments as done. VincentWu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/P

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 516042. VincentWu marked an inline comment as done. VincentWu added a comment. address comment, remove wrong comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added a comment. If someone could be so kind as to push this on my behalf, it would be greatly appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 __

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 516037. ipriyanshi1708 marked 4 inline comments as done. ipriyanshi1708 added a comment. Removed unwanted changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D14798

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148372/new/ https://reviews.llvm.org/D148372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org