[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak marked an inline comment as done. dhruvachak added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_hold.cpp:211 +// CHECK-NOUSE-I386: @llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 0, ptr @.omp_offloading.requi

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 505987. dhruvachak added a comment. Fixed clang test OpenMP/target_map_codegen_hold.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 Files: clang/lib/CodeGen

[clang] 0818433 - Remove the outdated feature macro '__cpp_coroutines'

Author: Chuanqi Xu Date: 2023-03-17T13:52:18+08:00 New Revision: 0818433a5515df24c5d2cd95087e375ba8596cb0 URL: https://github.com/llvm/llvm-project/commit/0818433a5515df24c5d2cd95087e375ba8596cb0 DIFF: https://github.com/llvm/llvm-project/commit/0818433a5515df24c5d2cd95087e375ba8596cb0.diff LO

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu added a comment. > Should we also be updating InitPreprocessor.cpp at the same time, for > non-Windows targets? I didn't address this since we didn't do this before. (Defining feature macro according to the targets). Also I feel it may be bad for windows users. Since currently the co

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9410-9421 +def ext_incorrect_defaulted_comparison_constexpr : Extension< "defaulted definition of %select{%sub{select_defaulted_comparison_kind}1|" "three-way comparison operator}0 "

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 505986. shafik added a comment. - Added release note - Update CXX status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added a comment. Recommitted at e82d2e8c9ca34bcccb8fef67a8727543a978 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089

[clang] e82d2e8 - Recommit "[Sema] Fix null pointer dereference handleAlwaysInlineAttr."

Author: Craig Topper Date: 2023-03-16T21:37:35-07:00 New Revision: e82d2e8c9ca34bcccb8fef67a8727543a978 URL: https://github.com/llvm/llvm-project/commit/e82d2e8c9ca34bcccb8fef67a8727543a978 DIFF: https://github.com/llvm/llvm-project/commit/e82d2e8c9ca34bcccb8fef67a8727543a978.diff

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 505985. shafik marked 6 inline comments as done. shafik added a comment. - Updating diagnostic wording - Adding Reference to changes from p2448r2 to the comments - Modified p3 tests to have an extension pass as well CHANGES SINCE LAST ACTION https://reviews

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu added a comment. > but we don't define __cpp_­impl_­coroutine: > http://eel.is/c++draft/tab:cpp.predefined.ft We defined `__cpp_­impl_­coroutine`. And `__cpp_coroutines` is for Coroutines TS. I forgot to remove this too. I'll handle it in a separate patch. CHANGES SINCE LAST ACTION

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu updated this revision to Diff 505979. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146187/new/ https://reviews.llvm.org/D146187 Files: clang/docs/ReleaseNotes.rst clang/www/cxx_status.html Index: clang/www/cxx_status.html ==

RE: [clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

LG. Thanks! > -Original Message- > From: Craig Topper > Sent: Thursday, March 16, 2023 8:01 PM > To: Voss, Matthew > Cc: Craig Topper ; cfe-commits@lists.llvm.org > Subject: Re: [clang] 1029747 - [Sema] Fix null pointer dereference > handleAlwaysInlineAttr. > > Thanks for the heads up.

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. I don't remember clearly if we have a test for the initializer in the implementation unit. Ignore this if we already have one. Comment at: clang/include/clang/Basic/Module.h:137 ImplicitGlobalModuleFragment, }; We may be ab

[clang] e8a632d - Revert "[Sema] Fix null pointer dereference handleAlwaysInlineAttr."

Author: Craig Topper Date: 2023-03-16T20:05:33-07:00 New Revision: e8a632dac2204d66293dd5e0ba92eb65941c4aa3 URL: https://github.com/llvm/llvm-project/commit/e8a632dac2204d66293dd5e0ba92eb65941c4aa3 DIFF: https://github.com/llvm/llvm-project/commit/e8a632dac2204d66293dd5e0ba92eb65941c4aa3.diff

RE: [clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

Hi Craig, There are some failures on the PS5 buildbot after this change. Could you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/18474 Thanks, Matt > -Original Message- > From: cfe-commits On Behalf Of Craig > Topper via cfe-commits > Sent: Thursday, March 16, 2023

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. (I don't why I can't send emails in the original mail address. It told me that your email addressed is not recorded by MX, while I don't know what is MX. So I tried to reply your email here) This FIXME was added 6 years ago for Modules TS. (https://github.com/llvm/ll

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

jrtc27 added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU

wzssyqa created this revision. wzssyqa added a reviewer: MaskRay. Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. wzssyqa requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In general, MIPS suppo

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG10297470e953: [Sema] Fix null pointer dereference handleAlwaysInlineAttr. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D146089?vs=505596&id=505961#toc Repository: rG

[clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

Author: Craig Topper Date: 2023-03-16T17:49:34-07:00 New Revision: 10297470e953f4f3968c54c851c8af82b07af00b URL: https://github.com/llvm/llvm-project/commit/10297470e953f4f3968c54c851c8af82b07af00b DIFF: https://github.com/llvm/llvm-project/commit/10297470e953f4f3968c54c851c8af82b07af00b.diff

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. Recent commit added some more detail to the comment on the fembed-offload-object argument as requested by @awarzynski Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 __

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon updated this revision to Diff 505957. agozillon edited the summary of this revision. agozillon added a comment. - [Flang][Driver] Expand further on the embed-offload-object comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) awarzynski wrote: > jhuber6 wrote: > > a

[libunwind] a7aade1 - [runtimes] Synchronize warnings flags between libc++/libc++abi/libunwind

Author: Nikolas Klauser Date: 2023-03-17T00:40:59+01:00 New Revision: a7aade1f36eb60161235b66bca46db12e5326a0c URL: https://github.com/llvm/llvm-project/commit/a7aade1f36eb60161235b66bca46db12e5326a0c DIFF: https://github.com/llvm/llvm-project/commit/a7aade1f36eb60161235b66bca46db12e5326a0c.dif

[PATCH] D146211: Make globals used for array initialization codegen constant

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146211/new/ https://reviews.llvm.org/D146211 ___

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added a comment. The approach of attempting to adjust the depth here is not correct, and we should rip this whole mechanism out and reimplement it. Consider this closely related testcase: template concept Concept = true; template struct A { template V> void C(V&& t)

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e2a4eff8f6: [clang] Unconditionally add autolink hints for frameworks. (authored by ributzka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ h

[clang] 29e2a4e - [clang] Unconditionally add autolink hints for frameworks.

Author: Juergen Ributzka Date: 2023-03-16T15:31:17-07:00 New Revision: 29e2a4eff8f62d12754f31f90d70e9a346bc2075 URL: https://github.com/llvm/llvm-project/commit/29e2a4eff8f62d12754f31f90d70e9a346bc2075 DIFF: https://github.com/llvm/llvm-project/commit/29e2a4eff8f62d12754f31f90d70e9a346bc2075.di

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

ributzka added a comment. Thanks for the prompt reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ https://reviews.llvm.org/D146255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

Bigcheese accepted this revision. Bigcheese added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ https://reviews.llvm.org/D146255 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

awarzynski added inline comments. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + jhuber6 wrote: > agozillon wrote: > > awarzynski wrote: > > > Given that you use `-###`, I think that this can be skipped (please

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4200331 , @dfaust wrote: > In D143967#4197288 , @eddyz87 wrote: > >> ... >> I think there are two sides to this: >> >> - conceptual: is it ok to allow annotations for CVR modifi

[PATCH] D143704: [flang] Feature list plugin

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as it doesn't affect core features. Comment at: flang/examples/FeatureList/FeatureList.cpp:40-43 +const auto [it, ins] = frequencies.insert({name, 1}); +if

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1372 +.. _AlwaysBreakBeforeFunctionParameters: + +**AlwaysBreakBeforeFunctionParameters** (``Boolean``) :versionbadge:`clang-format 16.0` jrmolin wrote: > MyDeveloperDay wro

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. I would like to see an annotator test just to be sure its getting annotated correctly. apart from that it looks pretty good, would you add this to the release notes please? Comment at: clang/unittests/Format/FormatTestJS.cpp:2186 +TEST_F(Forma

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu added a comment. In D146164#4200414 , @rsmith wrote: > FYI: this attribute appears to not work on (at least) x86 and arm currently, > because the backend also does some merging: https://godbolt.org/z/d43M83oax Thanks for reporting it. I'll look

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jhuber6 accepted this revision. jhuber6 added a comment. LGTM, it's much simpler for now since Flang doesn't support CUDA, HIP, OpenCL, OpenMP, etc. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + agozillon w

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! Would be great for somebody with a bit more experience with offloading to OK this as well :) @tschuett or perhaps @jhuber6 ? Commen

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @shafik - it's a bit early to review this patch, this was the first attempt to fix the issue related to the current behavior of clang::Sema::TemplateParameterListsAreEqual that causes Clang to mishandle out-of-line definitions involving constraints (and

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Herald added a subscriber: jplehr. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

pete accepted this revision. pete added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ https://reviews.llvm.org/D146255 ___ cfe

[PATCH] D146163: Experimental new python bindings for clang/llvm based on Cython

aeubanks resigned from this revision. aeubanks added a comment. not familiar enough with python, but there should probably be an RFC for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146163/new/ https://reviews.llvm.org/D146163 __

[PATCH] D146165: docs: add some documentation on Windows SDK search

hans added a comment. Nice, thanks for doing this! Comment at: clang/docs/UsersManual.rst:4537 + +TODO: This is not yet implemented. + But isn't this how clang-cl finds stuff when running in a "Visual Studio Command Prompt" / setenv / vcvars or whatever it

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17897 +if (SemaRef.FailedImmediateInvocations.contains(E)) + CurrentII->setInt(1); + } else { shafik wrote: > It is not obvious to me why this is correct, can you pleas

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

shafik added a comment. I also don't get what is going on here, either a more detailed summary or more inline comments should help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1303 +OldTemplate->getTemplateParameters(), false, TPL_TemplateMatch, +SourceLocation(), false /* PartialOrdering */); bool SameReturnType = Context.hasSameType(Old->getDeclaredReturnTy

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

rsmith added a comment. FYI: this attribute appears to not work on (at least) x86 and arm currently, because the backend also does some merging: https://godbolt.org/z/d43M83oax Comment at: clang/lib/CodeGen/CGExpr.cpp:3626-3627 } - + if (InNoMergeAttributedStmt) +TrapC

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

asb added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:153 + std::set TempSet(Cmp); + for (auto E : SupportedExtensions) +TempSet.insert(E); craig.topper wrote: > Question for the community. Should we maintain SupportedExtensions in the >

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa845aeb5d6c8: [Driver] Allow to collect `-save-stats` data to a file specified in the… (authored by vsapsai). Repository: rG LLVM Github Monorepo

[clang] a845aeb - [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

Author: Volodymyr Sapsai Date: 2023-03-16T11:57:59-07:00 New Revision: a845aeb5d6c869146fa24194a7d0182a4787cad8 URL: https://github.com/llvm/llvm-project/commit/a845aeb5d6c869146fa24194a7d0182a4787cad8 DIFF: https://github.com/llvm/llvm-project/commit/a845aeb5d6c869146fa24194a7d0182a4787cad8.di

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144981/new/ https://reviews.llvm.org/D144981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

srj added a comment. > (I certainly agree everyone should be using __atomic and not __sync.) Halide still uses the `__sync` builtins for 32-bit targets, for reasons I don't have at hand now (IIRC there were downstream users with tooling issues, I will re-check). (I don't think we are using `__s

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) agozillon wrote: > jhuber6 wrote: > > agoz

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dfaust added a comment. In D143967#4197288 , @eddyz87 wrote: > ... > I think there are two sides to this: > > - conceptual: is it ok to allow annotations for CVR modifiers? Maybe someone more an expert in DWARF could chime in whether this is problematic

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) jhuber6 wrote: > agozillon wrote: > > aw

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) agozillon wrote: > awarzynski wrote: > > a

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

shafik added a comment. Thank you for the fix. Comment at: clang/lib/Sema/SemaExpr.cpp:17897 +if (SemaRef.FailedImmediateInvocations.contains(E)) + CurrentII->setInt(1); + } else { It is not obvious to me why this is correct, can you pleas

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

taymonbeal created this revision. taymonbeal added reviewers: MyDeveloperDay, owenpan. Herald added a project: All. taymonbeal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The satisfies operator was added in TypeScript 4.9. Repository:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:2362 +const HelperExprs &Exprs) { + this->LoopDirCrParmV = new LoopDirCrParam(C, StartLoc, EndLoc, CollapsedNum, +Clauses, AssociatedStmt, Exprs);

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 505869. koops added a comment. Herald added subscribers: jplehr, sunshaoce. 1. formatting 2. Adding lit test 3. Removing bind clause from the set of clauses passed during bind(parallel) to the OMPForDirective and bind(teams) to the OMPDistributeDirective. CHA

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Please add the test cases requested, plus a Release Note. Otherwise LGTM. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + --

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[clang] 4c8ee1a - [Debugify] Use ModuleAnalysisManager in instrumentation

Author: Arthur Eubanks Date: 2023-03-16T09:49:59-07:00 New Revision: 4c8ee1ac8221ef2d66b7f62b848a76d94196d87a URL: https://github.com/llvm/llvm-project/commit/4c8ee1ac8221ef2d66b7f62b848a76d94196d87a DIFF: https://github.com/llvm/llvm-project/commit/4c8ee1ac8221ef2d66b7f62b848a76d94196d87a.diff

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. Deleted the clang test that was forwarding to Flang and merged with the omp-frontend-forwarding.f90 test where relevant. Second push was because I forgot to add a missing newline, which I seem to do frequently... Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon updated this revision to Diff 505844. agozillon added a comment. - Readd missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 Files: clang/lib/Driver/ToolChains/Flang.cpp clang/li

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch it was expected that if there was several immediate invocations they all belong to the same expression

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. In D145815#4199848 , @tschuett wrote: > Flang will also support OpenACC for offload. It is very similar to OpenMP. You are correct, thank you for reminding me! No idea how I forgot it, my apologies. Repository: rG LLVM Git

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

tschuett added a comment. Flang will also support OpenACC for offload. It is very similar to OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 ___ cfe-com

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon updated this revision to Diff 505842. agozillon added a comment. - [Flang][Driver] Try to fix failing omp-frontend-forwarding.f90 test - [Flang][Driver] Simplify omp-frontend-forwarding.f90 test - [Flang][Driver][Test] Delete flang-omp test from Clang and merge tests into omp-frontend-f

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) awarzynski wrote: > agozillon wrote: > >

[PATCH] D144976: [clangd] Add provider info on symbol hover.

hokein added a comment. Thanks, left some comments on the unittest, I think we can make it simpler. Comment at: clang-tools-extra/clangd/Hover.cpp:1107 +if (!Matches.empty()) { + // Pick the best-ranked included provider + Result = Matches[0]->quote(); ---

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:44 + + [[clang::nomerge]] __builtin_trap(); } hans wrote: > Maybe do __debugbreak() too since that's also mentioned on the debug. The `__debugbreak()` is also emitted from `EmitTrap

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu updated this revision to Diff 505837. zequanwu marked 3 inline comments as done. zequanwu added a comment. - Add test case for __debugbreak(). - Handle named trap instructions and add test case for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. In D144878#4199297 , @aaron.ballman wrote: > LGTM aside from a small formatting issue. Do you need someone to land this on > your behalf? If so, what name and email address would y

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

spaits added a comment. In D145069#4191046 , @xazax.hun wrote: > Do you plan to selectively enable warnings coming from the STL to catch > misuses of certain STL types? No. At first when we have found out that the Static Analyzer can reason about std::

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > erichkeane wrote: > > > > > erichkeane wrote: > > > >

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

shafik added a comment. Can we also add the test from the bug report as a regression test, it looks like the existing test are basically covering the same thing but I have seen stranger bugs so it would be good to explicitly cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

cor3ntin added subscribers: hubert.reinterpretcast, cor3ntin. cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Triple checking with @hubert.reinterpretcast for conformance but I'm pretty sure that's correct. Repository: rG LLVM

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

shafik added a comment. Can you add a summary, I realize folks can goto the release notes edit and see the bug report and then go look it up but at least a cursory summary is a little more reviewer friendly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) agozillon wrote: > awarzynski wrote: >

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

Tedlion updated this revision to Diff 505802. Tedlion edited the summary of this revision. Tedlion added a comment. Provide the full diff context instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146194/new/ https://reviews.llvm.org/D146194 F

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - ok, thanks a lot for the comments / help, I need a bit of time to play with the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

Tedlion accepted this revision. Tedlion added a comment. I argee that the different CSA behavior between C and C++ should be checked. In D146194#4199257 , @steakhal wrote: > As per your proposed change, I think we should do something like this: > > for

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4199263 , @erichkeane wrote: > After a night of sleeping on it, the use of a AdjustConstraintDepth::Diff and > AdjustConstraintDepth::Value feels like a hacky solution to SOMETHING here, > though I'm not sure what

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60bbf271b568: [ARM][NFC] Use FPUKind enum instead of unsigned (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 60bbf27 - [ARM][NFC] Use FPUKind enum instead of unsigned

Author: Michael Platings Date: 2023-03-16T13:38:10Z New Revision: 60bbf271b568ab85ef90c92ff6014e06786217b9 URL: https://github.com/llvm/llvm-project/commit/60bbf271b568ab85ef90c92ff6014e06786217b9 DIFF: https://github.com/llvm/llvm-project/commit/60bbf271b568ab85ef90c92ff6014e06786217b9.diff L

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:779 +// The depths calculated for the declarations can be equal but they still +// may differ from the depths of types inside OldConstr and NewConstr. +OldConstr = ---

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane , ok, let me think a bit a more about it / investigate further. It's unclear why we use AdjustConstraintDepth here in the first place, i.e. why the depth is incorrect in the first place. Regarding Diff/Value - TemplateDepth (despite its name)

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small formatting issue. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? ==

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

hans added a comment. Since we're touching SelectionDAG, does GlobalISel also need updating? Comment at: clang/test/CodeGen/attr-nomerge.cpp:44 + + [[clang::nomerge]] __builtin_trap(); } Maybe do __debugbreak() too since that's also mentioned on the debug.

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) awarzynski wrote: > What's the magic "1"

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added a comment. These changes will also need a release note at some point. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:662-665 +def err_type_definition_cannot_be_modified : Error< + "%0 type definition cannot be modified inside a scope containi

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. After a night of sleeping on it, the use of a AdjustConstraintDepth::Diff and AdjustConstraintDepth::Value feels like a hacky solution to SOMETHING here, though I'm not sure what yet. The depth of a template shouldn't change between the equality and constraint checki

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

steakhal added a comment. BTW we request full context for git patches. That way the reviewer can scroll and see the context around your hunks. You can request git to emit the full context by passing the `-U99` commandline option. See

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

steakhal added a comment. Okay, thanks for clarifying. So, it seems like it depends on the language flavor, but why does CSA behave differently in C and C++? This is necessary to understand if we need to fix that instead of patching this particular checker. I'd still add a test to the `clang/t

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + craig.topper wrote: > erichkeane wrote: > > craig.topper wrote: > > > erichkeane wrote: > > > > erichkeane wrote: > > > > > craig.topper wrote: > > > >

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3897-3899 + } else if (T->getVectorKind() == VectorType::RVVFixedLengthDataVector) { +mangleRISCVFixedRVVVectorType(T); +return; craig.topper wrote: > aaron.ballman wrote: >

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D131307#4197789 , @erichkeane wrote: > In D131307#4197767 , @rsmith wrote: > >>> Based on feedback we will provide users to the ability to downgrade this >>> this diagnostic to

[PATCH] D146187: [docs] Update the status for coroutines

aaron.ballman added a comment. Should we also be updating InitPreprocessor.cpp at the same time, for non-Windows targets? I see we define: // TS features. if (LangOpts.Coroutines) Builder.defineMacro("__cpp_coroutines", "201703L"); but we don't define `__cpp_­impl_­coroutine`: http://e

[PATCH] D146202: [clang] Fix a UsingTemplate regression after 3e78fa860235431323aaf08c8fa922d75a7cfffa

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5fdc22a26c: [clang] Fix a UsingTemplate regression after… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >