[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

Tedlion created this revision. Tedlion added a reviewer: clang. Tedlion added a project: clang. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. Tedlion requested review of this revision. Herald added a subscriber: cfe-commits. I found current

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:237-245 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos, Neg

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3293 +This builtin is converted to llvm.set.rounding intrinsic in LLVM IR level +and not all targets support this intrinsic, so only x86 and arm targets +support this builtin. Since this builtin change

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505691. francii added a comment. Add missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505689. francii added a comment. Add missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 created this revision. xiongji90 added reviewers: rjmccall, sepavloff, aaron.ballman, andrew.w.kaylor. Herald added a project: All. xiongji90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch aims to add necessary descrip

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, bruno, clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the discussion in https://discourse.ll

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu added a comment. In D144844#4197067 , @dblaikie wrote: > I don't think of this as a performance regression for users though - this > functionality's never really "shipped" so we get to choose what the baseline > is. > > And I think a reasonabl

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/test/SemaTemplate/concepts-out-of-line-def.cpp:143 +template <> +template +constexpr int S<1>::constrained_method() { return CONSTRAINED_METHOD_1; } Would also like tests with packs both at this function level,

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:500-508 +DirectEmit = [&]() { + auto *RVI = S.getReturnValueInit(); + if (!RVI || CGF.FnRetTy->isVoidType()) +return true; + auto GroType = RVI->getType(); + if (GroType

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > > > > erichkeane wrote: > > > >

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5dfec9d444: [Clang][LoongArch] Implement patchable function entry (authored by WANG Xuerui , committed by SixWeining). Changed prior to commit: https://reviews.llvm.org/D141785?vs=49

[clang] db5dfec - [Clang][LoongArch] Implement patchable function entry

Author: WANG Xuerui Date: 2023-03-16T09:33:58+08:00 New Revision: db5dfec9d4442c360e9712bbd71b3462cac427e9 URL: https://github.com/llvm/llvm-project/commit/db5dfec9d4442c360e9712bbd71b3462cac427e9 DIFF: https://github.com/llvm/llvm-project/commit/db5dfec9d4442c360e9712bbd71b3462cac427e9.diff L

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:153 + std::set TempSet(Cmp); + for (auto E : SupportedExtensions) +TempSet.insert(E); Question for the community. Should we maintain SupportedExtensions in the order we want

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:738 +public: + enum DepthAdjustmentKind { Diff, Value }; + I don't really get what you're getting at with "Diff" and "Value"? Those names don't really seem to make sense to me?

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + craig.topper wrote: > erichkeane wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > erichkeane wrote: > > > > > craig.topper wrote: > > > >

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4424 -if (Line.First->isOneOf(tok::kw_default, tok::kw_case)) - return Style.SpaceBeforeCaseColon; const FormatToken *Next = Right.getNextNonCommen

[clang] 7eaa7b0 - [clang] Use *{Map,Set}::contains (NFC)

Author: Kazu Hirata Date: 2023-03-15T18:06:34-07:00 New Revision: 7eaa7b055389799643cd6c2e992985f71de73ee5 URL: https://github.com/llvm/llvm-project/commit/7eaa7b055389799643cd6c2e992985f71de73ee5 DIFF: https://github.com/llvm/llvm-project/commit/7eaa7b055389799643cd6c2e992985f71de73ee5.diff L

[clang] c7c1d53 - [Lex] Use false instead of 0 (NFC)

Author: Kazu Hirata Date: 2023-03-15T18:06:31-07:00 New Revision: c7c1d531b9a77a735183f67a6d8b538691284f92 URL: https://github.com/llvm/llvm-project/commit/c7c1d531b9a77a735183f67a6d8b538691284f92 DIFF: https://github.com/llvm/llvm-project/commit/c7c1d531b9a77a735183f67a6d8b538691284f92.diff L

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4195992 , @DavidSpickett wrote: >> Since this is my first commit to such a large repository(and project), can >> you please guide me with this @DavidSpickett ! > > Sure, you'll want to make a commit that only has

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath abandoned this revision. mysterymath added a comment. Given that we didn't reach a consensus on this one, I'll abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505657. francii added a comment. Herald added a subscriber: jplehr. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: erichkeane, rsmith, aaron.ballman. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a proj

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac1d143b0ef9: [Clang][AIX][p] Manually Claim -p in front end (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ac1d143 - [Clang][AIX][p] Manually Claim -p in front end

Author: Michael Francis Date: 2023-03-15T23:26:48Z New Revision: ac1d143b0ef924cf2725bb36537f18ae2c7f9c4f URL: https://github.com/llvm/llvm-project/commit/ac1d143b0ef924cf2725bb36537f18ae2c7f9c4f DIFF: https://github.com/llvm/llvm-project/commit/ac1d143b0ef924cf2725bb36537f18ae2c7f9c4f.diff LO

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505653. francii added a comment. Rebase for push Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolC

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGExprAgg.cpp:535 CGM.getModule(), C->getType(), - CGM.isTypeConstant(ArrayQTy, /* ExcludeCtorDtor= */ true), +

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin added a comment. In D146156#4197289 , @shafik wrote: > Is there a way to test this? It was easier to reproduce on small test case than I thought, test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505644. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/l

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 505643. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin updated this revision to Diff 505642. DmitryPolukhin added a comment. Test added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146156/new/ https://reviews.llvm.org/D146156 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Preproc

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D131307#4197767 , @rsmith wrote: >> Based on feedback we will provide users to the ability to downgrade this >> this diagnostic to a waring to allow for a transition period. We expect to >> turn this diagnostic to an error

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:893 +errc::invalid_argument, +"'zvknhb' requires 'zve64x' extension to also be specified"); + For consistency with the Zvk* error, use `"'zvknhb' requires 'v' or 'z

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

reames added a comment. FYI, zvkb was discussed at the Architectural Review Committee this week and they've asked for some significant changes and expansions. See the notes shared here: https://lists.riscv.org/g/tech-unprivileged/message/450 I actively do not think we need to wait on landing t

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

rsmith added a comment. > Based on feedback we will provide users to the ability to downgrade this this > diagnostic to a waring to allow for a transition period. We expect to turn > this diagnostic to an error in the next release. Can we revert this now? Repository: rG LLVM Github Monorepo

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

This revision was automatically updated to reflect the committed changes. Closed by commit rG765d8a192180: [Clang][Sema] Fix incorrect deletion of default constructors for some unions (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D145851?vs=505620&id=505635#toc R

[clang] 765d8a1 - [Clang][Sema] Fix incorrect deletion of default constructors for some unions

Author: Roy Jacobson Date: 2023-03-15T23:55:52+02:00 New Revision: 765d8a192180f8f33618087b15c022fe758044af URL: https://github.com/llvm/llvm-project/commit/765d8a192180f8f33618087b15c022fe758044af DIFF: https://github.com/llvm/llvm-project/commit/765d8a192180f8f33618087b15c022fe758044af.diff

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7364 ReadingKindTracker ReadingKind(Read_Decl, *this); + Deserializing D(this); shafik wrote: > Curious, why do we need this here and below. I'm actually not sure how we got awa

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith updated this revision to Diff 505631. rsmith marked an inline comment as done. rsmith added a comment. - Add `=` to parameter name comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145737/new/ https://reviews.llvm.org/D145737 Files:

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3897-3899 + } else if (T->getVectorKind() == VectorType::RVVFixedLengthDataVector) { +mangleRISCVFixedRVVVectorType(T); +return; aaron.ballman wrote: > Should there be corres

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of the same array, +etc.). bruno w

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 505624. royjacobson added a comment. rebase + release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

erichkeane accepted this revision. erichkeane added a comment. Still LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 ___ cfe-commits mailing list cfe-comm

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146168 Files: clang/lib/Sema/SemaExprCXX.cpp c

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

iains added a comment. In D144844#4195633 , @ChuanqiXu wrote: >> However, "performance" also includes compilation speed in the 'no >> optimisation, debug' case - that is also considered very important. So, >> perhaps, the short-term approach should be (

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 505620. royjacobson marked an inline comment as done. royjacobson added a comment. slimmer codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: c

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers updated this revision to Diff 505615. bersbersbers added a comment. Made comment extraction more strict, made sure special comments not affected by formatting, added unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 File

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers marked an inline comment as done. bersbersbers added a comment. > The disadvantage is that it forces everyone else who needs to review or > maintain the file to deal with a style that's different from that of the > directory. "different", yes, but as explained, not necessarily inco

[clang] 6a6994c - Reland [StandardInstrumentations] Check function analysis invalidation in module passes as well

Author: Arthur Eubanks Date: 2023-03-15T13:29:21-07:00 New Revision: 6a6994cc9bc0327aaf8b005c650ff5eb29d2bcce URL: https://github.com/llvm/llvm-project/commit/6a6994cc9bc0327aaf8b005c650ff5eb29d2bcce DIFF: https://github.com/llvm/llvm-project/commit/6a6994cc9bc0327aaf8b005c650ff5eb29d2bcce.diff

[PATCH] D146165: docs: add some documentation on Windows SDK search

mstorsjo added a comment. Looks reasonable I guess - but I think it would be good to mention the env variables `INCLUDE` and `LIB` too, for alternative ways of finding the same things - even if it's not strictly the same as what this new section talks about. Repository: rG LLVM Github Monor

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson marked an inline comment as done. royjacobson added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; shafik wrote: > aaron.ballman wrote: > > I think there's one mor

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jplehr. Pretty sure this is what we discussed in the meeting. So it should be fine to remove the alignment requirement on the declaration since we don't handle it

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd created this revision. compnerd added reviewers: hans, rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add some documentation on the flags and the process by which clang identifies the headers and libraries for the Win

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20a7ea49f40e: [StandardInstrumentations] Verify function doesn't change if analyses are… (authored by aeubanks). Changed prior to commit: https://

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505602. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505601. francii added a comment. Don't claim when checking for object file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rG361cba22b201: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 361cba2 - [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

Author: Arthur Eubanks Date: 2023-03-15T13:07:55-07:00 New Revision: 361cba22b2013f66e5b18896ffcf2564b332ab7b URL: https://github.com/llvm/llvm-project/commit/361cba22b2013f66e5b18896ffcf2564b332ab7b DIFF: https://github.com/llvm/llvm-project/commit/361cba22b2013f66e5b18896ffcf2564b332ab7b.diff

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu created this revision. zequanwu added reviewers: hans, craig.topper. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. 1. It fixes

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper updated this revision to Diff 505596. craig.topper added a comment. Fix the same bug for noinline attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089 Files: clang/lib/Sema/SemaStmtAtt

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + erichkeane wrote: > erichkeane wrote: > > craig.topper wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > > > > erichkeane wrote: > > > >

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > erichkeane wrote: > > > > > Can you add a test that show

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:32 +int foo(int x) { +if constexpr (D > 1) +[[clang::always_inline]] return foo(x + 1); erichkeane wrote: > Also, I note the 'if constexpr' branch is unnecessary to

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146069/new/ https://reviews.llvm.org/D146069 ___ cfe

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:236 const Decl *Decl = CallExpr->getCalleeDecl(); if (Decl->hasAttr() || Decl->hasAttr()) S.Diag(St->getBeginLoc(), diag::warn_function_stmt_attribute_precedence) Same

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

bruno updated this revision to Diff 505588. bruno marked 2 inline comments as done. bruno added a comment. Update after reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145641/new/ https://reviews.llvm.org/D145641 Files: clang/inc

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

bruno marked 3 inline comments as done. bruno added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:483-499 +// The call to get_­return_­object is sequenced before the call to +// initial_­suspend and is invoked at most once, but there are caveats +// r

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > Can you add a test that shows that we warn on instantiation? This > > > shouldn'

[PATCH] D145970: [MSVC][PS][dllexport/dllimport] Propagate a dllexport/dllimport attribute to template baseclasses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG634430d5857e: [MSVC][dllexport/dllimport] Propagate a dllexport/dllimport attribute to… (authored by wolfgangp). Herald added a project: clang. Repo

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4179674 , @nickdesaulniers wrote: > Will work on that RFC though! RFC (PTAL): https://discourse.llvm.org/t/rfc-improving-clangs-middle-and-back-end-diagnostics/69261 Repository: rG LLVM Github Monorepo C

[clang] 634430d - [MSVC][dllexport/dllimport] Propagate a dllexport/dllimport attribute to template baseclass

Author: Wolfgang Pieb Date: 2023-03-15T11:47:54-07:00 New Revision: 634430d5857e395cff62534b11c460f51c6c846a URL: https://github.com/llvm/llvm-project/commit/634430d5857e395cff62534b11c460f51c6c846a DIFF: https://github.com/llvm/llvm-project/commit/634430d5857e395cff62534b11c460f51c6c846a.diff

[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

asb added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv64-abi.c:1909 - NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line: -// LP64F: {{.*}} kito-cheng wrote: > This seems removed accidentally, I saw

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of the same array, +etc.). Not necessarily a

[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

asb updated this revision to Diff 505575. asb added a comment. Herald added a subscriber: jobnoorman. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145074/new/ https://reviews.llvm.org/D145074 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/TargetInfo.cpp clang/test/

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Good catch, thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146156/new/ https://reviews.llvm.org/D146156 _

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

shafik added a comment. Is there a way to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146156/new/ https://reviews.llvm.org/D146156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. > ! In D143967#4197142 , @jemarch > wrote: > ... > In GCC we also translate from the internal DWARF structures into BTF. > So, for us, it would also imply to reoder (before generating the BTF > from the interal DWARF) in case

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + craig.topper wrote: > erichkeane wrote: > > Can you add a test that shows that we warn on instantiation? This > > shouldn't be a dependent declrefexpr

[PATCH] D145070: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7e13d6f1b49: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering (authored by asb). Herald added a subscriber: jobnoorman. Herald added a project: clang. Repository: rG LLVM Github Monorep

[clang] a7e13d6 - [clang][RISCV][test] Add test coverage for _Float16 ABI lowering

Author: Alex Bradbury Date: 2023-03-15T18:00:39Z New Revision: a7e13d6f1b49d72b59e9ec2252399eda717ea8f6 URL: https://github.com/llvm/llvm-project/commit/a7e13d6f1b49d72b59e9ec2252399eda717ea8f6 DIFF: https://github.com/llvm/llvm-project/commit/a7e13d6f1b49d72b59e9ec2252399eda717ea8f6.diff LOG:

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a comment. > > In D143967#4197041 , @dfaust wrote: > >> The way I see it both 'volatile' and the type tag are modifying >> 'int' type here, so the annotation DIE more properly fits as a child >> of 'int' rather than the 'volatile'. >> >> I

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + erichkeane wrote: > Can you add a test that shows that we warn on instantiation? This shouldn't > be a dependent declrefexpr when instantiated. > >

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thank you @bryanpkc, this LGTM Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:2 +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. Herald added a subscriber: jplehr. Needed to update this after landing with two quick patch fixes: [clang-offload-bundler] Fix test failures and document typo (65fb636bd462) [clang-offload-bundler] Fix error with regex in bundler test (f3b991202689) There were also

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: bruno, troyj, arphaman, vsapsai, jansvoboda11. DmitryPolukhin added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber:

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While it's apparently valid to place Bash redirections anywhere in a command-line, it is by far most frequently placed last.

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505560. francii added a comment. Fix segfault Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChai

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4197041 , @dfaust wrote: > The way I see it both 'volatile' and the type tag are modifying 'int' type > here, so the annotation DIE more properly fits as a child of 'int' rather > than the 'volatile'. > > I don't thin

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

aeubanks updated this revision to Diff 505558. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146069/new/ https://reviews.llvm.org/D146069 Files: clang/test/CodeGen/lto-newpm-pipeline.c llvm/lib/Passes/StandardI

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. In D125171#4195298 , @owenpan wrote: > In D125171#4193996 , @jrmolin wrote: > >> In D125171#4167866 , @owenpan >> wrote: >> >>> Please see >>> h

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dfaust added a comment. > in the final BTF, type tags have to precede CVR modifiers, e.g. TYPE_TAG > 'foo' -> CONST -> INT. Right now pahole does not do any reordering, so I > ended up putting the type tag annotations on the DIE with outermost modifier. > Will see if DI maintainers would be o

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

tschuett added a comment. Frontend is in the file name. Comment at: flang/lib/Frontend/FrontendActions.cpp:79 + llvm::StringRef inputFile, llvm::StringRef outputTag) { + if (!ci.getCodeGenOpts().SaveTempsDir.has_value()) { +return true; ---

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

On 3/15/23 09:17, Eduard Zingerman wrote: > On Wed, 2023-03-15 at 17:10 +0100, Jose E. Marchesi wrote: >>> Could you please take a look to verify that this implementation is on >>> the same page with what is planned for GCC? >> >> Sure. Can you please add David Faust as a subscriber as well? I

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

dblaikie added a comment. I don't think of this as a performance regression for users though - this functionality's never really "shipped" so we get to choose what the baseline is. And I think a reasonable baseline to compare to isn't this implementation we don't think is ideal (because of the

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

awarzynski added a comment. In D146075#4196998 , @tschuett wrote: > What is the policy on trivial braces in the frontend? What do you mean by the frontend? Different people have different understanding of what "the frontend" is. I try to follow https:

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dfaust added a comment. > Type tag for CVR modifier type > > C: > > volatile int __attribute__((btf_type_tag("__b"))) b; > > DWARF: > > 0x31: DW_TAG_variable > DW_AT_name ("b") > DW_AT_type (0x3c "volatile int") > > 0x3c: DW_TAG_volatile_type >

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5250 + if (Args.hasArg(options::OPT_mroptr) || Args.hasArg(options::OPT_mno_roptr)) { +bool HasRoptr = hubert.reinterpretcast wrote: > This only checks for `-m[no-]roptr`

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

tschuett added a comment. What is the policy on trivial braces in the frontend? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 ___ cfe-commits mailing list cfe

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. Hi @dfaust , Two head-ups, the following items turned out to be important when I tested using kernel BPF testsuite: - in the final BTF, type tags have to precede CVR modifiers, e.g. TYPE_TAG 'foo' -> CONST -> INT. Right now `pahole` does not do any reordering, so I en

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 marked 2 inline comments as done. jp4a50 added inline comments. Comment at: clang/lib/Format/Format.cpp:1372 LLVMStyle.DerivePointerAlignment = false; + LLVMStyle.DesignatedInitializerIndentWidth = 4; LLVMStyle.DisableFormat = false; jp4a50 wrote: >

  1   2   3   >