[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D143467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. Herald added a subscriber: PiotrZSL. Is there any new progress on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 ___ cfe-commi

[PATCH] D145656: [clang-format] Treat &/&& as reference when followed by requires clause

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the tok

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. Oh, de-refining is pretty nifty / evil. This patch has background: https://reviews.llvm.org/D18634 Since 2016, the optimizer is not allowed to do IPA on functions that can be de-refined (such as `linkonce_odr` functions). Here's a hypothetical problematic scenario fo

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:10 +// ROPTR-NOT: "-mroptr" +// ROPTR-NOT: "-bforceimprw" + hubert.reinterpretcast wrote: > w2yehia wrote: > > hubert.reinterpretcast wrote: > > > Do we pass the option throug

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Add more tests (those missing one), to make sure that this wont break proper cases. Refer to inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5250 + if (Args.hasArg(options::OPT_mroptr) || Args.hasArg(options::OPT_mno_roptr)) { +bool HasRoptr = This only checks for `-m[no-]roptr` when the front-end i

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL added a comment. There are 186 findings from this check in llvm repository, no false-positives. Example: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:2071:2: warning: preprocessor condition is always 'true', consider removing condition but leaving its contents [readability-av

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

wenlei added a comment. > I wonder if this is just a single example, where there could be various other > (header-related) peepholes that cause similar problems for stable output. > IIRC, the usual Clang approach is to make as-close-to-optimal IR up front, > but maybe in some situations it's de

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 503616. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Review comments fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files: clan

[PATCH] D145648: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. `-ffp-contract=fast-honor-pragmas` is a valid option recognized by clang -cc1 but it is missed by clang driver. https://reviews.l

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:231 + address values in the read-only data section. This option is intended to + be used with the ``-fdata-sections`` option. When ``-mroptr`` is in effect, + read-only data sections with rel

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. > (Also, can the backend safely optimize an `invoke` to a `linkonce_odr` > function that's `nounwind` to a `call`? I thought it couldn't, in case the > function is de-refined to a version that's not `nounwind`. But the frontend > can do it since it has access to the sourc

[clang] d4fcc69 - Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot

Author: jinge90 Date: 2023-03-09T13:14:36+08:00 New Revision: d4fcc692ee15b2c6d249daabe31208d6a5afa025 URL: https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025 DIFF: https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025.diff LOG:

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 updated this revision to Diff 503607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/avr-ld.c

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, inglorion, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes http

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ronlieb added a comment. had not heard back , so reverted it for now commit 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 (HEAD -> main, origin/main, origin/HEAD) Author: Ron Lieberman Date: Wed Mar 8 22:01:22 2023 -0600 Rev

[clang] 8cf85a0 - Revert "Add map info for dereference pointer."

Author: Ron Lieberman Date: 2023-03-08T22:05:31-06:00 New Revision: 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 URL: https://github.com/llvm/llvm-project/commit/8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 DIFF: https://github.com/llvm/llvm-project/commit/8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8.diff

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish created this revision. snehasish added reviewers: tejohnson, dblaikie. Herald added a subscriber: wenlei. Herald added a project: All. snehasish requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The memprof profile

[clang] 556a811 - [clang][nfc] Update some documentation referring to old clang flags

Author: Nathan Lanza Date: 2023-03-08T23:01:52-05:00 New Revision: 556a811d686ea5242d8c21b95a97b90aa1be7c56 URL: https://github.com/llvm/llvm-project/commit/556a811d686ea5242d8c21b95a97b90aa1be7c56 DIFF: https://github.com/llvm/llvm-project/commit/556a811d686ea5242d8c21b95a97b90aa1be7c56.diff

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:10 +// ROPTR-NOT: "-mroptr" +// ROPTR-NOT: "-bforceimprw" + w2yehia wrote: > hubert.reinterpretcast wrote: > > Do we pass the option through to the LTO codegen when `-fprofile

[PATCH] D144454: Add builtin for llvm set rounding

This revision was automatically updated to reflect the committed changes. Closed by commit rG24b823554acd: Add __builtin_set_flt_rounds (authored by xiongji90). Changed prior to commit: https://reviews.llvm.org/D144454?vs=502507&id=503602#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 24b8235 - Add __builtin_set_flt_rounds

Author: jinge90 Date: 2023-03-09T11:52:52+08:00 New Revision: 24b823554acd25009731b2519880aa18c7263550 URL: https://github.com/llvm/llvm-project/commit/24b823554acd25009731b2519880aa18c7263550 DIFF: https://github.com/llvm/llvm-project/commit/24b823554acd25009731b2519880aa18c7263550.diff LOG:

[PATCH] D145643: [clang][driver] Add option to manually control -disable-free in cc1

Chenbing.Zheng created this revision. Chenbing.Zheng added reviewers: aaron.ballman, lebedev.ri, benshi001. Chenbing.Zheng added a project: clang. Herald added subscribers: StephenFan, Anastasia. Herald added a project: All. Chenbing.Zheng requested review of this revision. Herald added subscribers

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The C++ grammar all

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

bruno created this revision. bruno added reviewers: ChuanqiXu, clang-language-wg. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - The cwg2563 issue is fixed

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

bruno created this revision. bruno added a reviewer: ChuanqiXu. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issue

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AvoidUnconditionalPreprocessorIfCheck.cpp:29 + return; +auto &SM = PP.getSourceManager(); +if (!isStatic(SM, PP.getLangOpts(), ConditionRange)) Please don't u

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ronlieb added a comment. seems to fail amdgpu buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/27692 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 __

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f2f37842582: Add map info for dereference pointer. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 0f2f378 - Add map info for dereference pointer.

Author: Jennifer Yu Date: 2023-03-08T17:43:43-08:00 New Revision: 0f2f378425821de77e50a0dcb67c4504389a56e8 URL: https://github.com/llvm/llvm-project/commit/0f2f378425821de77e50a0dcb67c4504389a56e8 DIFF: https://github.com/llvm/llvm-project/commit/0f2f378425821de77e50a0dcb67c4504389a56e8.diff L

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4179512 , @wlei wrote: > Hi @ahatanak > > We recently hit an issue of inconsistent codegen related with this > optimization. In one build, Clang frontend generates different llvm IRs for > the same function that is o

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov abandoned this revision. kstoimenov added a comment. I will send a different patch with LSAN_OPTIONS instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145451/new/ https://reviews.llvm.org/D145451 ___

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker marked 5 inline comments as done. collinbaker added a comment. Changed as requested. Again leaving it up to a committer to commit this Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503570. collinbaker edited the summary of this revision. collinbaker added a comment. Requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: c

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 503568. paulkirth added a comment. Herald added a reviewer: alexander-shaposhnikov. Minor update to tests. - drop yaml2obj in favor of using llc + objcopy - remove c files Note one tests now fails, though. For some reason w/ FatLTO the linker rewrites `x

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4100432 , @dblaikie wrote: > I guess my only other question (worth mentioning in the RFC, > perhaps)/direction would be that any of these "things that are expensive but > make backend diagnostics better" could

[PATCH] D145567: [Driver] Rename multilib flags to tags

MaskRay added a comment. Since the touched code is still in review, you need to merge the changes into the prior patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 _

[PATCH] D145435: Choose style (file) from within code for use in IDEs

owenpan added a comment. In D145435#4179308 , @bersbersbers wrote: > In D145435#4173875 , @owenpan wrote: > >> Please refer to D125171#4167866 >> to make the case that

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4179481 , @ldionne wrote: > In D129951#4179467 , @cjdb wrote: > >> I'm deeply disappointed that libc++ moved away from using `__function_like`: >> that was an important part of pr

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG124b46a897a7: [NFC][AArch64] Document and improve FMV code. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145538/new/ https://reviews.

[clang] 124b46a - [NFC][AArch64] Document and improve FMV code.

Author: Pavel Iliin Date: 2023-03-08T23:22:46Z New Revision: 124b46a897a7044be3cb49b9e0097d8cca47ba6b URL: https://github.com/llvm/llvm-project/commit/124b46a897a7044be3cb49b9e0097d8cca47ba6b DIFF: https://github.com/llvm/llvm-project/commit/124b46a897a7044be3cb49b9e0097d8cca47ba6b.diff LOG: [

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50cd2c257cb4: [LSAN] Disable leaks in test using environment variables instead of not running… (authored by kstoimenov). Repository: rG LLVM Githu

[clang] 50cd2c2 - [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

Author: Kirill Stoimenov Date: 2023-03-08T23:20:40Z New Revision: 50cd2c257cb4e5fc822e0fa5fc12d1838070fcf0 URL: https://github.com/llvm/llvm-project/commit/50cd2c257cb4e5fc822e0fa5fc12d1838070fcf0 DIFF: https://github.com/llvm/llvm-project/commit/50cd2c257cb4e5fc822e0fa5fc12d1838070fcf0.diff L

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

wlei added subscribers: modimo, hoy, wlei. wlei added a comment. Hi @ahatanak We recently hit an issue of inconsistent codegen related with this optimization. In one build, Clang frontend generates different llvm IRs for the same function that is originally from one header file. It turned out t

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a subscriber: ChuanqiXu. cor3ntin added a comment. In D124351#4178334 , @sammccall wrote: > Sorry for the delay, extracting the repro from the build system seems about > as much work as minimizing it :-) > F26749550: modrepo2.zip

[PATCH] D129951: adds `__disable_adl` attribute

ldionne added a comment. In D129951#4179467 , @cjdb wrote: > I'm deeply disappointed that libc++ moved away from using `__function_like`: > that was an important part of preventing niebloid misuse. It isn't conforming > to treat niebloids as function ob

[PATCH] D129951: adds `__disable_adl` attribute

ldionne added a comment. This is a really neat attribute! FWIW, I think we would most likely have used it in `` if it were available back then. Assuming that GCC implemented it, I think we could consider changing to use this attribute. However: 1. This would technically be an ABI break, but thi

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4178949 , @philnik wrote: > In D129951#4178844 , @cjdb wrote: > >> In D129951#4178154 , @philnik >> wrote: >> >>> I don't think libc++ ca

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

aqjune added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -o - |

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

aqjune added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -o - |

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 503529. PiotrZSL added a comment. Micro fixes in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files: clang-tools-extra/clang-tidy/readability/Avo

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Check flags always enab

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

NoQ added a comment. Looks great overall! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:156 + // 2. the operand of a cast-to-(Integer or Boolean) operation; or + // 3. the operand of a pointer subtraction operation; or + // 4. the operand of a pointer comparison opera

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

aqjune added a comment. In D143287#4179344 , @ManuelJBrito wrote: > In D143287#4179020 , @aqjune wrote: > >> H, is D104790 superseded by this patch? > > I don't think so we stil

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4179020 , @aqjune wrote: > H, is D104790 superseded by this patch? I don't think so we still need to fix the undefined intrinsics, right? Maybe I'm not understanding the questio

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

kstoimenov created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

bob80905 updated this revision to Diff 503511. bob80905 added a comment. - remove or to eliminate any ambiguity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270 Files: clang/docs/LanguageExtensions.rst

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. All, thanks for considering my patch! I'll answer all messages here, and will work on the patch over the weekend most probably. In D145435#4173875 , @owenpan wrote: > Please refer to D125171#4167866

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

malavikasamak added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:156 + // 2. the operand of a cast-to-(Integer or Boolean) operation; or + // 3. the operand of a pointer subtraction operation; or + // 4. the operand of a pointer comparison operation; o

[PATCH] D145509: [HIP] Fix temporary files

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Driver.h:630 // Creates a temp file with $Prefix-%%.$Suffix const char *CreateTempFile(Compilation &C, StringRef Prefix, Stri

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rG7335cd051370: [M68k] Add support for basic memory constraints in inline asm (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D143529?vs=495647&id=503509#toc Repository: rG LLVM

[clang] 7335cd0 - [M68k] Add support for basic memory constraints in inline asm

Author: Min-Yih Hsu Date: 2023-03-08T13:52:34-08:00 New Revision: 7335cd05137076c69ce4716ac8f30a99fc95c406 URL: https://github.com/llvm/llvm-project/commit/7335cd05137076c69ce4716ac8f30a99fc95c406 DIFF: https://github.com/llvm/llvm-project/commit/7335cd05137076c69ce4716ac8f30a99fc95c406.diff L

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503504. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/

[PATCH] D145509: [HIP] Fix temporary files

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:634 + StringRef BoundArch = {}, + Action::OffloadKind OFK = Action::OFK_None) const; t

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai added a comment. Adding folks involved with LTO. The problem is that stats emitted during the first round of compilation are likely to be overwritten by stats emitted during [Thin]LTO itself. Not touching it now to preserve the existing behavior. But wanted to inform you about this shor

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D144179#4166909 , @mgabka wrote: > In D144179#4146599 , @MaskRay wrote: > >> This looks like i

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a comment. How is this different from compiling a C++ file with opemnp directives in it? AFAICT neither clang nor gcc issue anywarnings: https://godbolt.org/z/5Me3dnTdr What makes the warnings necessary for HIP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai updated this revision to Diff 503488. vsapsai added a comment. Don't touch LTO pipeline to avoid breaking existing workflows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144981/new/ https://reviews.llvm.org/D144981 Files: clang/docs/Co

[PATCH] D145514: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfe5ae0b62a: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANG

[clang] 0cfe5ae - [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

Author: Alexey Bataev Date: 2023-03-08T13:06:53-08:00 New Revision: 0cfe5ae0b62a54cf76bb2f18eb60acb5e22fcc2d URL: https://github.com/llvm/llvm-project/commit/0cfe5ae0b62a54cf76bb2f18eb60acb5e22fcc2d DIFF: https://github.com/llvm/llvm-project/commit/0cfe5ae0b62a54cf76bb2f18eb60acb5e22fcc2d.diff

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai added inline comments. Comment at: clang/test/Driver/save-stats.c:26 // CHECK-LTO: "-plugin-opt=stats-file=save-stats.stats" +// CHECK-LTO: "-plugin-opt=-stats-file-append" ahatanak wrote: > ahatanak wrote: > > Doesn't this require `stats-file-append`

[PATCH] D145605: Revert two patches to fix GH58452 regression

erichkeane updated this revision to Diff 503479. erichkeane added a comment. Add tests from regression bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145605/new/ https://reviews.llvm.org/D145605 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal

[PATCH] D145605: Revert two patches to fix PR58452 regression

erichkeane added a comment. Going to add 1 more set of test beyond the revert, which is the tests from that regression report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145605/new/ https://reviews.llvm.org/D145605 ___ cfe-commits mailing

[PATCH] D145605: Revert two patches to fix PR58452 regression

erichkeane created this revision. erichkeane added reviewers: tstellar, aaron.ballman. Herald added a project: All. erichkeane requested review of this revision. PR58452 is a regression in the 16.0 release branch caused by both: b8a1b698afb2fc84819c7596090aabf4d826b436

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb added a comment. I don't see anything x86_64 specific for `OPT_fexceptions` handling in clang/lib/Driver/ToolChains/Clang.cpp. So perhaps "For most targets, this is enabled by default for C++." It's disabled for the ps4/ps5 toolchains and xcore, hence the "most targets" qualifier. CHANGES

[PATCH] D145509: [HIP] Fix temporary files

tra added a comment. In D145509#4176732 , @yaxunl wrote: > However, it seems the previous code using GetTemporaryDirectory was > intentional (https://reviews.llvm.org/D111269). My guess is that lipo using > some hash of input file name in the generated

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma added a comment. Something like that, sure. Is it actually on by default on x86-64? I don't think the default is target-specific, I think it's just on for default for C++ dialects, and off by default for non-C++ dialects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

aqjune added a comment. H, is D104790 superseded by this patch? I wonder what is the status of this patch as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 _

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

hans added a comment. In D145271#4178837 , @wolfgangp wrote: >> It still seems like the export/import there is an accident since >> `Base` can't really be referenced from outside the file anyway. >> >> Perhaps rather than giving `Base` external linkage t

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb added a comment. What do you think about e.g. "Allow exceptions to be thrown through Clang compiled stack frames (on many targets, this will enable unwind information for functions that might have an exception thrown through them. This is on by default in x86-64"? Or were you thinking of so

[clang] d2b768b - [C2x] Add test coverage for WG14 N2607

Author: Aaron Ballman Date: 2023-03-08T14:59:53-05:00 New Revision: d2b768bba301aa80e2874d3d935a721eb1148f29 URL: https://github.com/llvm/llvm-project/commit/d2b768bba301aa80e2874d3d935a721eb1148f29 DIFF: https://github.com/llvm/llvm-project/commit/d2b768bba301aa80e2874d3d935a721eb1148f29.diff

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

malavikasamak added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:156 + // 2. the operand of a cast-to-(Integer or Boolean) operation; or + // 3. the operand of a pointer subtraction operation; or + // 4. the operand of a pointer comparison operation; o

[PATCH] D129951: adds `__disable_adl` attribute

philnik added a comment. In D129951#4178844 , @cjdb wrote: > In D129951#4178154 , @philnik wrote: > >> I don't think libc++ can adopt this without having to essentially duplicate >> our code, since GCC doesn't su

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type support."

[PATCH] D145401: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting

kerbowa updated this revision to Diff 503461. kerbowa added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145401/new/ https://reviews.llvm.org/D145401

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145600/new/ https://reviews.llvm.org/D145600 _

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 503459. Leporacanthicus marked an inline comment as done. Leporacanthicus added a comment. Fix copied comment to reflect the new content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https:

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma added a comment. I'd prefer to focus the documentation more generically on exceptions, not unwind information specifically. -fexceptions makes code generation change in other ways, and "unwind information" doesn't exist on all targets where exception handling is relevant. CHANGES SI

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

ilinpv marked 5 inline comments as done. ilinpv added inline comments. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:567-568 + +// For given features returns a mask to check if CPU support them. The mask is +// used in Function Multi Versioning resolver conditi

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4178154 , @philnik wrote: > I don't think libc++ can adopt this without having to essentially duplicate > our code, since GCC doesn't support `__disable_adl` (and AFAICT there is no > coordination between GCC and Clang t

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

wolfgangp added a comment. > It still seems like the export/import there is an accident since > `Base` can't really be referenced from outside the file anyway. > > Perhaps rather than giving `Base` external linkage to allow it to > be imported/exported, the better fix would be to drop its dllimp

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

ilinpv updated this revision to Diff 503446. ilinpv added a comment. Rebasing and addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145538/new/ https://reviews.llvm.org/D145538 Files: clang/include/clang/Basic/TargetInfo.h cla

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

scchan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

DiggerLin added a comment. In D142484#4080202 , @Jake-Egan wrote: > In D142484#4079909 , @jhuber6 wrote: > >> In D142484#4079869 , @Jake-Egan >> wrote: >> >>> Hi, this ne

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503440. qiongsiwu1 added a comment. Update `-mroptr` cc1 option help text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503437. qiongsiwu1 added a comment. Addressing review comments - fixing typos, and updating the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: cla

[clang] 555b572 - Revert D118493 "Set rpath on openmp executables"

Author: Fangrui Song Date: 2023-03-08T10:18:40-08:00 New Revision: 555b572e3f407ac48b5f30fc06760cc4d0549977 URL: https://github.com/llvm/llvm-project/commit/555b572e3f407ac48b5f30fc06760cc4d0549977 DIFF: https://github.com/llvm/llvm-project/commit/555b572e3f407ac48b5f30fc06760cc4d0549977.diff

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

DiggerLin created this revision. DiggerLin added reviewers: jhenderson, Jake-Egan, daltenty. Herald added a project: All. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In patch https://reviews.llvm.org/D127864. we add a new opti

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 ___

  1   2   >