[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added a comment. In D144285#4176850 , @rupprecht wrote: > In D144285#4163004 , @cor3ntin > wrote: > >> If however we find this change to disruptive, we should inform WG21. > > Thanks for the explanation,

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type supp

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 503242. jchlanda added a comment. Simplify the check for half tys support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/include/clang/Basic/Builtin

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added a comment. @reames and I recently talked and we agreed that vector crypto is far enough along that we'd like to get something committed to LLVM in experimental state. We can do iterative refinement if the spec continues to change. I guess the question is whether we should upd

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added a subscriber: w2yehia. hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/aix-roptr.c:9-10 +// RUN: -S <%s 2>&1 | FileCheck %s --check-prefix=DATA_SECTION_ERR +// RUN: not %clang_cc1 -triple=powerpc64le-unknown-li

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ok, let me explain. PREVIOUSLY: When generating b

[PATCH] D145040: Add test for Flags.data_flow_trace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67f5b05cdcdc: Add test for Flags.data_flow_trace (authored by yingcong-wu, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145040: Add test for Flags.data_flow_trace

vitalybuka updated this revision to Diff 503231. vitalybuka added a comment. test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145040/new/ https://reviews.llvm.org/D145040 Files: compiler-rt/lib/fuzzer/FuzzerDriver.cpp compiler-rt/test/fuzzer

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:229-231 +- Introduced the ``-mroptr`` option to place constant objects with relocatable + address values in the ready-only data section. This option is intended to + be used with the ``-fdata-

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

rupprecht added a comment. In D144285#4163004 , @cor3ntin wrote: > If however we find this change to disruptive, we should inform WG21. Thanks for the explanation, I think I understand the issue now. I got totally thrown off by the title -- it's not abo

[PATCH] D145473: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78a` commit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb3283bf192c6: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78… (authored by akyrtzi). Rep

[clang] b3283bf - [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78a` commit

Author: Argyrios Kyrtzidis Date: 2023-03-07T20:23:07-08:00 New Revision: b3283bf192c6dbd6416b58e42f90ca443e8f005d URL: https://github.com/llvm/llvm-project/commit/b3283bf192c6dbd6416b58e42f90ca443e8f005d DIFF: https://github.com/llvm/llvm-project/commit/b3283bf192c6dbd6416b58e42f90ca443e8f005d.

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503218. yaxunl edited the summary of this revision. yaxunl added a reviewer: keith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D143496: [clangd] Add support for missing includes analysis.

thakis added a comment. Oh, that was reported a while ago already. Reverted in 2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[clang-tools-extra] 2eb5ac9 - Revert "[clangd] Add support for missing includes analysis."

Author: Nico Weber Date: 2023-03-07T22:14:11-05:00 New Revision: 2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd URL: https://github.com/llvm/llvm-project/commit/2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd DIFF: https://github.com/llvm/llvm-project/commit/2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd.diff LO

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

ilinpv created this revision. ilinpv added reviewers: tmatheson, danielkiss. Herald added a subscriber: kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. ilinpv requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-co

[PATCH] D145509: [HIP] Fix temporary files

yaxunl added a comment. In D145509#4175773 , @tra wrote: > LGTM, but we should probably get someone familiar with macos to chime in, > just in case there may be some reason behind macos using temp directories > here. > >> This change is OK for MacOS as

[PATCH] D143496: [clangd] Add support for missing includes analysis.

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/75486/step_9.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

rsmith added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:113-114 + if (TemplateParamLists.size() == 1) { +// FIXME: pick the correct template parameter list based on NNS, SS +// and getCurScope(). +TemplateParamete

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:663 +return stmt(isInUnspecifiedPointerContext(expr( + ignoringImpCasts(unaryOperator(isPreInc()).bind(UPCPreIncrementTag); + } NoQ wrote: > You're not check

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

ziqingluo-90 updated this revision to Diff 503193. ziqingluo-90 added a comment. Thanks for the valuable discussion about the philosophy on the ideal forms of fix-its. In this case, I think `&DRE.data()[any]` and `(DRE.data() + any)` are both straightforward enough for the user to tell what has

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

MaskRay added a comment. The inconsistency stem from the fact that with the default `.text`, the compiler may generate `.text.$suffix` if `-ffunction-sections` is specified or if a COMDAT is needed. While with an explicit section, there is no such suffix appending mechanism used together with `

[PATCH] D145514: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. This seems to pass our other tests, LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145514/new/ https://reviews.llvm.org/D145514 __

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:149-152 +// Matches a `UnaryOperator` whose operator is pre-increment: +AST_MATCHER(UnaryOperator, isPreInc) { + return Node.getOpcode() == UnaryOperator::Opcode::UO_PreInc; +} Oh in

[clang] f6e7a5c - [clang-format][NFC] Remove isCpp11AttributeSpecifier()

Author: Owen Pan Date: 2023-03-07T15:15:37-08:00 New Revision: f6e7a5c29221f445e4cbddc32667a1e12a1446db URL: https://github.com/llvm/llvm-project/commit/f6e7a5c29221f445e4cbddc32667a1e12a1446db DIFF: https://github.com/llvm/llvm-project/commit/f6e7a5c29221f445e4cbddc32667a1e12a1446db.diff LOG:

[PATCH] D145526: [clang][DependencyScanner] Cache modulemap stat failures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57c7750f703d: [clang][DependencyScanner] Cache modulemap stat failures (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 57c7750 - [clang][DependencyScanner] Cache modulemap stat failures

Author: Michael Spencer Date: 2023-03-07T15:13:55-08:00 New Revision: 57c7750f703ddee9025f819cdd01c9e97666e7ab URL: https://github.com/llvm/llvm-project/commit/57c7750f703ddee9025f819cdd01c9e97666e7ab DIFF: https://github.com/llvm/llvm-project/commit/57c7750f703ddee9025f819cdd01c9e97666e7ab.dif

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

phosek added a comment. In D145449#4175864 , @phosek wrote: >> LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to >> stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on >> two-stage builds. > > That shouldn't be the case, d

[PATCH] D145526: [clang][DependencyScanner] Cache modulemap stat failures

Bigcheese updated this revision to Diff 503164. Bigcheese added a comment. Also handle `module.map`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145526/new/ https://reviews.llvm.org/D145526 Files: clang/lib/Tooling/DependencyScanning/Dependenc

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

NoQ added a comment. In D143128#4167626 , @jkorous wrote: > This is an interesting topic. In the abstract I see the question as: "Should > the Fix-Its prioritize how the code will fit the desired end state > (presumably modern idiomatic C++) or carefull

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e9c55db3b6: [Fuchsia] Add LLDB options to stage 1 cmake. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145449/new/ https://revi

[clang] c0e9c55 - [Fuchsia] Add LLDB options to stage 1 cmake.

Author: Daniel Thornburgh Date: 2023-03-07T15:04:31-08:00 New Revision: c0e9c55db3b6a2a1287ba96ef3d378b97b72714a URL: https://github.com/llvm/llvm-project/commit/c0e9c55db3b6a2a1287ba96ef3d378b97b72714a DIFF: https://github.com/llvm/llvm-project/commit/c0e9c55db3b6a2a1287ba96ef3d378b97b72714a.d

[PATCH] D145526: [clang][DependencyScanner] Cache modulemap stat failures

Bigcheese updated this revision to Diff 503160. Bigcheese added a comment. Forgot that `Filename` is actually a path, so call `llvm::sys::path::filename`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145526/new/ https://reviews.llvm.org/D145526 F

[PATCH] D143680: [-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok I think this is good to go! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143680/new/ https://reviews.llvm.org/D143680 ___ cfe-commits mailin

[PATCH] D145526: [clang][DependencyScanner] Cache modulemap stat failures

Bigcheese created this revision. Bigcheese added reviewers: ributzka, benlangmuir, jansvoboda11. Bigcheese added a project: clang. Herald added a project: All. Bigcheese requested review of this revision. Herald added a subscriber: cfe-commits. Add `module.modulemap` as a file we cache stat failur

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith added a comment. In D130303#4175664 , @collinbaker wrote: > @dexonsmith can you weigh in? Introducing `clang_isBitFieldDecl` sounds like a clean/straightforward solution to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] bb70dac - [clang-format][NFC] Remove an obsolete case in parsing concepts

Author: Owen Pan Date: 2023-03-07T14:42:22-08:00 New Revision: bb70dacd60b54d39ca144cf91d47d6c04404b816 URL: https://github.com/llvm/llvm-project/commit/bb70dacd60b54d39ca144cf91d47d6c04404b816 DIFF: https://github.com/llvm/llvm-project/commit/bb70dacd60b54d39ca144cf91d47d6c04404b816.diff LOG:

[PATCH] D145435: Choose style (file) from within code for use in IDEs

owenpan added a comment. In D145435#4176109 , @HazardyKnusperkeks wrote: > I think this would be a great feature. I don't understand why anyone wants to do this. If I'm accustomed to a different style, I'd temporarily change the config file in the curr

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

ahatanak added inline comments. Comment at: clang/test/Driver/save-stats.c:26 // CHECK-LTO: "-plugin-opt=stats-file=save-stats.stats" +// CHECK-LTO: "-plugin-opt=-stats-file-append" ahatanak wrote: > Doesn't this require `stats-file-append` to be supported by

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

owenpan added a comment. In D145344#4174634 , @MyDeveloperDay wrote: > I would hazard a guess that this actually solves more issues than we realize. That would be icing on the cake. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

ahatanak added inline comments. Comment at: clang/test/Driver/save-stats.c:26 // CHECK-LTO: "-plugin-opt=stats-file=save-stats.stats" +// CHECK-LTO: "-plugin-opt=-stats-file-append" Doesn't this require `stats-file-append` to be supported by the plugin just l

[PATCH] D143496: [clangd] Add support for missing includes analysis.

PiotrZSL added a comment. This change broke regression, non-one read: "This revision was landed with ongoing or failed builds." ./ClangdTests.exe/IncludeCleaner/GenerateMissingHeaderDiags tests fails on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 503144. PiotrZSL added a comment. Rebase due to failed clangd tests on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-extra/clang-tidy/

[clang] ae05d2b - Update the C status page for WG14 N2844

Author: Aaron Ballman Date: 2023-03-07T16:13:06-05:00 New Revision: ae05d2b17dca399b3190e0ae1dba814aa3946002 URL: https://github.com/llvm/llvm-project/commit/ae05d2b17dca399b3190e0ae1dba814aa3946002 DIFF: https://github.com/llvm/llvm-project/commit/ae05d2b17dca399b3190e0ae1dba814aa3946002.diff

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + /// otherwise kiranchandramohan wrote: > TIFitis wrote: > >

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503137. TIFitis marked 3 inline comments as done. TIFitis added a comment. Addressed comments. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad added a comment. @emaste Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https://reviews.llvm.org/D144823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145435: Choose style (file) from within code for use in IDEs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3542 + +// Prefix found, and at start of file or preceded by white space? +if (PrefixPos != StringRef::npos && I understand the reasoning, but the check down below I think d

[PATCH] D145435: Choose style (file) from within code for use in IDEs

HazardyKnusperkeks added a comment. I think this would be a great feature. But I also think that it needs more documentation. You also need to make sure, that we don't change that comment, that is `SpacesInLineCommentPrefix` and `ColumnLimit` should have no effect on the comment. ==

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

nhaehnle added a comment. In D145441#4175428 , @krzysz00 wrote: > @foad I was trying to avoid sending in one mega-patch that has the entire > prototype. The best way to do this is to work on a branch that you rebase regularly. You can push the branch t

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 503122. PiotrZSL added a comment. Ready for review, added new check option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-extra/clang-tidy/mis

[PATCH] D145514: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

ABataev updated this revision to Diff 503114. ABataev added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145514/new/ https://reviews.llvm.org/D145514 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_non_re

[PATCH] D145519: [SanitizerBinaryMetadata] Do not add to GPU code

tra added a comment. LGTM for NVPTX. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp:134 assert(TargetTriple.isOSBinFormatELF() && "ELF only"); +assert((!TargetTriple.isNVPTX() && !TargetTriple.isAMDGPU()) && + "Device targets are

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. Hi, Aron. Just to make myself clear: What I need to do is that the clang dumps for C files are also accepted by GCC as input. Here is why I wanted to output the attribute on middle: https://godbolt.org/z/6aPc6aWcz As you can see, GCC complains of `__attribut

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 503109. francii added a comment. Test case nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolCha

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 503107. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145519: [SanitizerBinaryMetadata] Do not add to GPU code

melver created this revision. melver added a reviewer: dvyukov. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. SanitizerBinaryMetada

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added a comment. In D143418#4175628 , @aaron.ballman wrote: > Hmmm, don't relaxed loads and stores still have the potential to be racey? I > thought you needed a release on the store and an acquire on the load (or > sequential consistency), but t

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe002a38b20e3: [Flang][OpenMP][MLIR][Driver][bbc] Add -fopenmp-is-device flag to Flang -fc1 &… (authored by agozillon). Repository: rG LLVM Github

[clang] e002a38 - [Flang][OpenMP][MLIR][Driver][bbc] Add -fopenmp-is-device flag to Flang -fc1 & the bbc tool, and omp.is_device attribute

Author: Andrew Gozillon Date: 2023-03-07T12:57:58-06:00 New Revision: e002a38b20e3ac40aecbbfa0774f8ba7b9690b0c URL: https://github.com/llvm/llvm-project/commit/e002a38b20e3ac40aecbbfa0774f8ba7b9690b0c DIFF: https://github.com/llvm/llvm-project/commit/e002a38b20e3ac40aecbbfa0774f8ba7b9690b0c.dif

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

phosek added a comment. > LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to > stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on > two-stage builds. That shouldn't be the case, do you know where it's being passed through? Repository: rG LLVM Github Monorepo

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM, but please wait @phosek to approve it. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif()

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type support."

[clang-tools-extra] 284fcbb - [clang-tidy][NFC] Fix link in RelaseNotes

Author: Piotr Zegar Date: 2023-03-07T18:39:45Z New Revision: 284fcbb95a899228b99728e9d8960fc7a6c5c6ac URL: https://github.com/llvm/llvm-project/commit/284fcbb95a899228b99728e9d8960fc7a6c5c6ac DIFF: https://github.com/llvm/llvm-project/commit/284fcbb95a899228b99728e9d8960fc7a6c5c6ac.diff LOG: [

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL updated this revision to Diff 503092. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cla

[PATCH] D145514: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

jdoerfert added inline comments. Comment at: openmp/runtime/test/worksharing/for/omp_for_non_rectangular.c:33 + collapsed(N); + return test(N); +} should we test the count? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

mysterymath added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() haowei wrote: > You probably need a `string(REPLACE ";" "|" value > "${_FUCHSIA_ENABLE_PROJECTS}")

[PATCH] D145509: [HIP] Fix temporary files

tra added a comment. LGTM, but we should probably get someone familiar with macos to chime in, just in case there may be some reason behind macos using temp directories here. > This change is OK for MacOS as lipo does not requires specific I'm curious why lipo has been singled out. Is that the

[PATCH] D145517: MSVC: support version preference with search

compnerd created this revision. compnerd added reviewers: mstorsjo, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. compnerd requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang, LLVM. Extend the logic for the WinS

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 ___ cfe-commits mailing list cf

[clang] 9b28954 - Use explicit target in clang/test/Preprocessor/directives_asm.S

Author: John Brawn Date: 2023-03-07T18:06:41Z New Revision: 9b2895469badad470dca186801fe025c52f5364c URL: https://github.com/llvm/llvm-project/commit/9b2895469badad470dca186801fe025c52f5364c DIFF: https://github.com/llvm/llvm-project/commit/9b2895469badad470dca186801fe025c52f5364c.diff LOG: Us

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

PiotrZSL updated this revision to Diff 503082. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144206/new/ https://reviews.llvm.org/D144206 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.c

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

sammccall added a comment. We're seeing new clang crashes that bisect to this commit, with modules only. I have it mostly-reduced and will post shortly, trying to see if I can simplify any further (since modules reproducers are a pain). Meanwhile, the assert/stack in case it's already useful:

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. In D141714#4175263 , @giulianobelinassi wrote: > Hi, Alan. Thanks for your review again! > > With regard to middle, the patch sent in D145269 > may answer your questions. Basically > fun

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker added a comment. @dexonsmith can you weigh in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

erichkeane added inline comments. Comment at: clang/docs/LanguageExtensions.rst:642 T __builtin_elementwise_log10(T x) return the base 10 logarithm of x floating point types + T __builtin_elementwise_exp(T x)returns the base-

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

beanz added inline comments. Comment at: clang/docs/LanguageExtensions.rst:642 T __builtin_elementwise_log10(T x) return the base 10 logarithm of x floating point types + T __builtin_elementwise_exp(T x)returns the base-e exp

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

steakhal added a comment. As this resolves a crash, I'm backporting it: https://github.com/llvm/llvm-project/issues/61245 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144780/new/ https://reviews.llvm.org/D144780 _

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

erichkeane added a comment. Patch itself seems fine enough, but I want to give others a chance to poke at it. The name makes me grumbly, but if there is sufficient 'prior art' here, I'm ok with it. Comment at: clang/docs/LanguageExtensions.rst:642 T __builtin_elementwise_l

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. In D143418#4175381 , @vedgy wrote: > I am implementing the `StorePreamblesInMemory` bool option discussed earlier. > It would be nice to be able to modify it at any time, because it can be an > option in an IDE's UI and r

[PATCH] D145151: clang: Handle MatrixType in hasFloatingRepresentation

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145151/new/ https://reviews.llvm.org/D145151 ___ cfe-commits mailing list cfe-co

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2739f111d97: [clang] Treat function parameter scope as an immediate function context (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] a2739f1 - [clang] Treat function parameter scope as an immediate function context

Author: Mariya Podchishchaeva Date: 2023-03-07T11:46:26-05:00 New Revision: a2739f111d9795fe49109c26c2d816436f2143c3 URL: https://github.com/llvm/llvm-project/commit/a2739f111d9795fe49109c26c2d816436f2143c3 DIFF: https://github.com/llvm/llvm-project/commit/a2739f111d9795fe49109c26c2d816436f2143

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. Cleaned up the test, thank you both for teaching me more about the compiler and test infrastructure! If you're happy with the test changes @kiranchandramohan I'll commit the changes upstream to close out the review? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 503070. agozillon added a comment. - [Flang][Driver] Tidy up omp-is-device.f90 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files: clang/include/clang/Dri

[PATCH] D145514: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

ABataev created this revision. ABataev added reviewers: jdoerfert, Meinersbur, mikerice. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ABataev requested review of this revision. Herald added subscribers: openmp-commits, sstefan1. Herald added projects: clang, OpenMP. The

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1440bf6fd22: Driver: introduce GNU spellings to control MSVC paths (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] f1440bf - Driver: introduce GNU spellings to control MSVC paths

Author: Saleem Abdulrasool Date: 2023-03-07T08:41:35-08:00 New Revision: f1440bf6fd22ca0a5fc3594000e966201989fd48 URL: https://github.com/llvm/llvm-project/commit/f1440bf6fd22ca0a5fc3594000e966201989fd48 DIFF: https://github.com/llvm/llvm-project/commit/f1440bf6fd22ca0a5fc3594000e966201989fd48.

[PATCH] D145362: [clang] Update test according to P1937

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0db54e0dd32: [clang] Update test according to P1937 (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145362/new/ https://reviews.llvm

[clang] d0db54e - [clang] Update test according to P1937

Author: Mariya Podchishchaeva Date: 2023-03-07T11:30:25-05:00 New Revision: d0db54e0dd3272a044407a6394cae47c84cd3a70 URL: https://github.com/llvm/llvm-project/commit/d0db54e0dd3272a044407a6394cae47c84cd3a70 DIFF: https://github.com/llvm/llvm-project/commit/d0db54e0dd3272a044407a6394cae47c84cd3a

[clang] 128f7da - [Lex] Use line markers in preprocessed assembly predefines file

Author: John Brawn Date: 2023-03-07T16:20:43Z New Revision: 128f7dac82ea4b996ddfd0db86edfdac4013b1da URL: https://github.com/llvm/llvm-project/commit/128f7dac82ea4b996ddfd0db86edfdac4013b1da DIFF: https://github.com/llvm/llvm-project/commit/128f7dac82ea4b996ddfd0db86edfdac4013b1da.diff LOG: [L

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

This revision was automatically updated to reflect the committed changes. Closed by commit rG128f7dac82ea: [Lex] Use line markers in preprocessed assembly predefines file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D145397?vs=502680&id=503058#toc Repository: r

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski accepted this revision. awarzynski added a comment. In D144864#4175001 , @agozillon wrote: > And then provided @awarzynski is happy with the current state of the patch LGTM, thanks for the updates and for working on this! Repository: rG LL

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 added a comment. @foad I was trying to avoid sending in one mega-patch that has the entire prototype. As to your comments: - Why 256-bit alignment? It's the next power of 2, and using an alignment that isn't a power of 2 causes an assertion failure - Re not being allowed to use addres

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon added a comment. Filed https://github.com/llvm/llvm-project/issues/61243 to backport. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/ https://reviews.llvm.org/D145486 ___ cfe-commits

[PATCH] D145509: [HIP] Fix temporary files

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added a reviewer: JDevlieghere. Herald added a project: All. yaxunl requested review of this revision. Currently HIP toolchain uses Driver::GetTemporaryDirectory to create a temporary directory for some temporary files duri

[clang-tools-extra] 38b9fb5 - [clangd] Add support for missing includes analysis.

Author: Viktoriia Bakalova Date: 2023-03-07T16:07:19Z New Revision: 38b9fb5a129db3e086610d53b534833273c5b4d0 URL: https://github.com/llvm/llvm-project/commit/38b9fb5a129db3e086610d53b534833273c5b4d0 DIFF: https://github.com/llvm/llvm-project/commit/38b9fb5a129db3e086610d53b534833273c5b4d0.diff

[PATCH] D143496: [clangd] Add support for missing includes analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38b9fb5a129d: [clangd] Add support for missing includes analysis. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf682f0df83f: [clang] Fix single-element array initialization in constexpr (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/

[clang] af682f0 - [clang] Fix single-element array initialization in constexpr

Author: Mariya Podchishchaeva Date: 2023-03-07T10:57:35-05:00 New Revision: af682f0df83f3364dac7ab92f39c7209dfbce28a URL: https://github.com/llvm/llvm-project/commit/af682f0df83f3364dac7ab92f39c7209dfbce28a DIFF: https://github.com/llvm/llvm-project/commit/af682f0df83f3364dac7ab92f39c7209dfbce2

  1   2   >