[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

thesamesam added a comment. This is currently holding back further testing on our end which is concerning me a bit, especially as we approach the branch point. Could you revert this please if a fix isn't imminent? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 680993e - [clang][Interp][NFC] Fix header comment file name

Author: Timm Bäder Date: 2023-01-22T08:33:39+01:00 New Revision: 680993e90ba3201e46f3272ddb9a617a567194d3 URL: https://github.com/llvm/llvm-project/commit/680993e90ba3201e46f3272ddb9a617a567194d3 DIFF: https://github.com/llvm/llvm-project/commit/680993e90ba3201e46f3272ddb9a617a567194d3.diff LO

[clang] 8e7c1b9 - [clang][Interp][NFCI] Make InitMap::isInitialized() const

Author: Timm Bäder Date: 2023-01-22T08:33:40+01:00 New Revision: 8e7c1b9a3d5f08046261ca0b7e5d319a4c4c9b25 URL: https://github.com/llvm/llvm-project/commit/8e7c1b9a3d5f08046261ca0b7e5d319a4c4c9b25 DIFF: https://github.com/llvm/llvm-project/commit/8e7c1b9a3d5f08046261ca0b7e5d319a4c4c9b25.diff LO

[clang] b07399f - [clang][Interp][NFC] Forward-declare Boolean in PrimTypes.h

Author: Timm Bäder Date: 2023-01-22T08:33:39+01:00 New Revision: b07399f0fa177fc9b673a5c32fce94233e8f5643 URL: https://github.com/llvm/llvm-project/commit/b07399f0fa177fc9b673a5c32fce94233e8f5643 DIFF: https://github.com/llvm/llvm-project/commit/b07399f0fa177fc9b673a5c32fce94233e8f5643.diff LO

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

yonghong-song added a comment. @dyung I just pushed the fix to the 'main' branch (https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b). Please check it out. Thanks for reporting! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 183d075 - [BPF][Clang] Fix func argument pattern in bpf-stack-protector test

Author: Yonghong Song Date: 2023-01-21T22:33:15-08:00 New Revision: 183d075055c591dedead7ece972f1bdea611aa3b URL: https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b DIFF: https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b.diff

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 491127. ccotter added a comment. - Add fno-delayed-template-parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CM

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491125. ccotter added a comment. - Fix windows, fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMak

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491124. ccotter added a comment. - Fix windows, fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMak

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

dyung added a comment. Hi, our internal release build buildbot seems to have issues with this test. It seems you are expected the following function declaration in the emitted IR: define dso_local void @_Z5test1PKc(ptr noundef %msg) #0 !dbg !19 { But in a release build, it becomes: define

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan added a comment. In D141654#4053470 , @rymiel wrote: > This also made me wonder, is there an actual policy on deprecated options? As > in, when they are actually removed. We deprecate options only as a cleanup (as in this patch) or when adding n

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan added a comment. In D141654#4053551 , @HazardyKnusperkeks wrote: > In D141654#4053470 , @rymiel wrote: > >> This also made me wonder, is there an actual policy on deprecated options? >> As in, when they

[PATCH] D142296: [clang-format] Fix a bug in parsing C++20 import statements

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://gi

[clang] 915602e - [OpenMP][FIX] Add default clause to switch

Author: Johannes Doerfert Date: 2023-01-21T19:50:22-08:00 New Revision: 915602e096f2bb4abb53e00f07b90ee821a49963 URL: https://github.com/llvm/llvm-project/commit/915602e096f2bb4abb53e00f07b90ee821a49963 DIFF: https://github.com/llvm/llvm-project/commit/915602e096f2bb4abb53e00f07b90ee821a49963.d

[PATCH] D141232: [OpenMP] Modernize the kernel launching interface and APIs

jdoerfert added a comment. In D141232#4071310 , @ronlieb wrote: > hi, breaks our amdgpu buildbot, please fix ASAP , or revert and fix. thx > 3 patches: https://lab.llvm.org/buildbot/#/builders/193/builds/25299 > > i reverted locally and verified this pa

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. > What happens with code like this > > void foo(bar&& B) { > std::move(B); > } I raised https://github.com/isocpp/CppCoreGuidelines/issues/2026 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://revi

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson updated this revision to Diff 491102. royjacobson added a comment. fix the test after diag change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141775/new/ https://reviews.llvm.org/D141775 Files: clang/docs/LanguageExtensions.rst c

[clang] 366fc10 - [OpenMP][FIX] Remove version check lines in clang test

Author: Johannes Doerfert Date: 2023-01-21T13:25:24-08:00 New Revision: 366fc10f065dee6fdf94bcaddaecb048dab902e8 URL: https://github.com/llvm/llvm-project/commit/366fc10f065dee6fdf94bcaddaecb048dab902e8 DIFF: https://github.com/llvm/llvm-project/commit/366fc10f065dee6fdf94bcaddaecb048dab902e8.d

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491095. Hahnfeld added a comment. Add unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp clang/unittests/Lex/PPCal

[PATCH] D141232: [OpenMP] Modernize the kernel launching interface and APIs

ronlieb added a comment. hi, breaks our amdgpu buildbot, please fix ASAP , or revert and fix. thx 3 patches: https://lab.llvm.org/buildbot/#/builders/193/builds/25299 i reverted locally and verified this patch as the cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In D142123#4071099 , @njames93 wrote: > Can you just elaborate on what the registry is used for? Is the plan to > support potentially dynamically loading `HeaderGuardStyle` classes. Yes. > If thats the case, Then I'd ar

[clang] a93cb93 - [clang/driver] Make sure that `-gno-modules` by itself doesn't enable debug info

Author: Argyrios Kyrtzidis Date: 2023-01-21T11:33:30-08:00 New Revision: a93cb9302c1ac03f71d3a85de9405dc97c1bbc99 URL: https://github.com/llvm/llvm-project/commit/a93cb9302c1ac03f71d3a85de9405dc97c1bbc99 DIFF: https://github.com/llvm/llvm-project/commit/a93cb9302c1ac03f71d3a85de9405dc97c1bbc99.

[PATCH] D141232: [OpenMP] Modernize the kernel launching interface and APIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16a385ba21a9: [OpenMP] Modernize the kernel launching interface and APIs (authored by jdoerfert). Herald added projects: clang, OpenMP. Herald added

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

njames93 added a comment. Also this goes for all your PRs, can you please upload them in future with full context `git diff -U99` should do it. Makes revewing changes easier and removes those `Context not available` message on phab CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1421

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

njames93 added a comment. Can you just elaborate on what the registry is used for? Is the plan to support potentially dynamically loading `HeaderGuardStyle` classes. If thats the case, Then I'd argue we don't need the `HeaderGuardBase` check class, We can just create a `HeaderGuardCheck` class t

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff70e22f08d9: [C++20][Modules] Handle defaulted and deleted functions in header units. (authored by iains). Repository: rG LLVM Github Monorepo C

[clang] ff70e22 - [C++20][Modules] Handle defaulted and deleted functions in header units.

Author: Iain Sandoe Date: 2023-01-21T12:55:52Z New Revision: ff70e22f08d9a289c707ef192d7d4c5968e54b51 URL: https://github.com/llvm/llvm-project/commit/ff70e22f08d9a289c707ef192d7d4c5968e54b51 DIFF: https://github.com/llvm/llvm-project/commit/ff70e22f08d9a289c707ef192d7d4c5968e54b51.diff LOG: [

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt added a comment. I asked MSFT to comment, let's see if they can share the spec for this attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475

[PATCH] D142277: [clang][Interp] Clear metadata when destroying locals

tbaeder updated this revision to Diff 491060. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142277/new/ https://reviews.llvm.org/D142277 Files: clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/InterpFrame.cpp Index: clang/lib/AST/Interp/InterpFrame.cpp

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille added a comment. In D142181#4070881 , @nikic wrote: > In D142181#4070868 , > @serge-sans-paille wrote: > >> @nikic : I thought I fixed that with >> e8a163dc03e6913360beb305620104ba129c081c >>

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

serge-sans-paille added a comment. > Plausibly caused by this change -- I'm thinking that `MaximumDistance` is > initialized to `UINT_MAX - 1`, but then we cast that to a signed integer and > compare that, so it wraps to a large negative number. @nikic : I thought I fixed that with e8a163dc03

[PATCH] D142277: [clang][Interp] Clear metadata when destroying locals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've had problems with 5b54cf1a2892767fe949826a32d7

[clang] 3665da3 - Re-commit "[clang][Interp] Unify visiting variable declarations"

Author: Timm Bäder Date: 2023-01-21T10:23:53+01:00 New Revision: 3665da3d0091ab765d54ce643bd82d353c040631 URL: https://github.com/llvm/llvm-project/commit/3665da3d0091ab765d54ce643bd82d353c040631 DIFF: https://github.com/llvm/llvm-project/commit/3665da3d0091ab765d54ce643bd82d353c040631.diff LO

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

nridge added inline comments. Comment at: clang/test/SemaCXX/warn-unsequenced-coro.cpp:7 + +namespace std { + Consider including `"Inputs/std-coroutine.h"` instead, as in e.g. [this test](https://searchfox.org/llvm/rev/1495210914997bcd0ca6937be0ae3cd6809b5ef5/cl

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

nridge added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15186 + if (ChildExpr == CSE->getOperand()) +// Do not recurse over a CoroutineSuspendExpr's operand. +// The operand is also a subexpression of getCommonExpr(), and Ou

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

nikic added a comment. In D142181#4070868 , @serge-sans-paille wrote: > @nikic : I thought I fixed that with e8a163dc03e6913360beb305620104ba129c081c > ... is > it included in your b

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille added a comment. @nikic : I thought I fixed that with e8a163dc03e6913360beb305620104ba129c081c ... is it included in your build? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142181/new/ https://re