[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

MaskRay added a comment. pip3 install --user recommonmark sphinx # sphinx-automodapi for lldb cmake ... ninja ... docs-llvm-html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141750/new/ https://reviews.llvm.org/D141750 ___

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

SixWeining added a comment. In D141750#4053469 , @SixWeining wrote: > I'm not sure if there is any format issue. Is there any way to verify? e.g. > how to generate .html like https://llvm.org/docs/ReleaseNotes.html? Now I find it: `llvm/docs/README.txt

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

rymiel added a comment. This also made me wonder, is there an actual policy on deprecated options? As in, when they are actually removed. Is there even prior precedent for doing this? (I wouldn't know because I'm a very recent user) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

SixWeining added a comment. I'm not sure if there is any format issue. Is there any way to verify? e.g. how to generate .html like https://llvm.org/docs/ReleaseNotes.html? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141750/new/ https://reviews.l

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

SixWeining created this revision. SixWeining added reviewers: rengolin, MaskRay, tstellar, xen0n, xry111, wangleiat, lrzlin, tangyouling, lh03061238. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, cryptoad. Herald added a project: All. SixWeining requested review of this revision

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

sunho added a subscriber: Hahnfeld. sunho added a comment. Maybe @Hahnfeld knows something as he added riscv support to clang-repl recently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141380/new/ https://reviews.llvm.org/D141380 __

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

sunho added a comment. Do you have an exception support in your libc and it's dynamically linked? I believe if clang-repl was able to execute the program, it must have successfully linked to cxxthrow symbols and so exception handling works correctly. Repository: rG LLVM Github Monorepo CHA

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

Backl1ght updated this revision to Diff 489193. Backl1ght added a comment. 1. Update example for SUD_Never 2. Use capital letters for variables and arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141694/new/ https://reviews.llvm.org/D141694 Files: clang/docs/ClangFormatStyle

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG347028a4d8da: [clang] Report the on-disk paths for inputs to module compiles (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHAN

[clang] 347028a - [clang] Report the on-disk paths for inputs to module compiles

Author: Jan Svoboda Date: 2023-01-13T18:38:11-08:00 New Revision: 347028a4d8da8aa1ae311c95424999fcd31d98cb URL: https://github.com/llvm/llvm-project/commit/347028a4d8da8aa1ae311c95424999fcd31d98cb DIFF: https://github.com/llvm/llvm-project/commit/347028a4d8da8aa1ae311c95424999fcd31d98cb.diff L

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4053164 , @tra wrote: >> So are you suggesting that we complete the whole pipeline? So -S -emit-llvm >> gives host IR, but the device will go all the way to object? > > That would match my expectations and would solve

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 489177. haowei added a comment. Correct C, CXX flag issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmak

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 489176. paulkirth added a comment. Rebase. - fix test cases - improve code swaping branch weights in instruction.cpp - clean up some dead metadata types left over from an old version of this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 489174. ccotter added a comment. - Match unresolved calls to move Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguideli

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: rsmith, aaron.ballman, dblaikie. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a projec

[PATCH] D141741: Add some subdirectories to the list of Abseil paths.

suertreus created this revision. suertreus added a reviewer: ymandel. suertreus added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. suertreus requested review of this revision. Herald added a subscriber: cfe-c

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

vsapsai accepted this revision. vsapsai added a comment. Confirm that for me on macOS without the fix the test is failing every time, so the test seems to be totally sufficient. Comment at: clang/lib/Parse/ParseDecl.cpp:6997 + D2->getLocation().getRawEncoding(); +

[PATCH] D139686: [lsan] Add lsan support for loongarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a58e11961d8: [lsan] Add lsan support for loongarch64 (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13968

[clang] 3a58e11 - [lsan] Add lsan support for loongarch64

Author: Youling Tang Date: 2023-01-14T09:23:51+08:00 New Revision: 3a58e11961d873bd9de1023cd248a403926d URL: https://github.com/llvm/llvm-project/commit/3a58e11961d873bd9de1023cd248a403926d DIFF: https://github.com/llvm/llvm-project/commit/3a58e11961d873bd9de1023cd248a403926d.diff

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

nathanchance added a comment. For what it’s worth, this triggers a LOT in the Linux kernel for the pattern that @MaskRay pointed out: https://gist.github.com/nathanchance/a76c2ba0a22dda3251c4ec5ee9e3f285 $ rg -c -- -Wconstant-conversion $TMP_FOLDER/4c37671a7c946ac246b52fa44a6a649b89d6310b-bu

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. > So are you suggesting that we complete the whole pipeline? So -S -emit-llvm > gives host IR, but the device will go all the way to object? That would match my expectations and would solve the " it can't be handled by LTO or anything else." issue you've highlighted above.

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 489160. dzhidzhoev added a comment. Fixed crashes reported by @efriedma and @rupprecht. "Base subobject type" layout (e.g. type layout without suffix padding) is calculated for unions and final classes too here, in order to lay out fields with [[no_unique

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Work in progress. Initial work on bui

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

MaskRay added a comment. This will cause warnings for the common usage related to bitmask macros/enumerators. #include int main(void) { unsigned char other = 0x81; other &= ~STO_AARCH64_VARIANT_PCS; return other; } (enumerator) `llvm/tools/llvm-readobj/ELFDumper.cpp:3869:1

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu updated this revision to Diff 489150. steven_wu added a comment. @akyrtzi has the good idea. It is really hard to control `Decl*` to get values to get an unstable iteration order from the small tests, going beyond 32 decls to get out of SmallPtrSet's small model is much consistent. Add

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

suertreus added a comment. Thanks for reviewing. I don't have commit access; can someone who does please do the thing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140434/new/ https://reviews.llvm.org/D140434

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added a comment. In D131306#4052878 , @paulkirth wrote: > In D131306#4052782 , @tejohnson > wrote: > >> In D131306#4037037 , @paulkirth >> wrote: >> >>> @tejoh

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added a comment. Thanks. I have noticed I suggested re-typo. (I didn't amend it since I thought it was obvious) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 ___

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth marked 3 inline comments as done. paulkirth added a comment. @chapuni Thanks for the suggestion. It didn't occur to me that it could break the lines like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llv

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 489148. njames93 marked 6 inline comments as done. njames93 added a comment. Add IgnoreMacros options. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D1373

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489147. paulkirth added a comment. Use more flexible whitespace matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this. Before landing this, could you please fix new warnings in the current codebase, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f952255 - Revert "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator."

Author: NAKAMURA Takumi Date: 2023-01-14T08:53:00+09:00 New Revision: f952255907a5a10925a565948f2ca8a61a826d92 URL: https://github.com/llvm/llvm-project/commit/f952255907a5a10925a565948f2ca8a61a826d92 DIFF: https://github.com/llvm/llvm-project/commit/f952255907a5a10925a565948f2ca8a61a826d92.dif

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4052986 , @tra wrote: > In D141717#4052824 , @jhuber6 wrote: > >> For `-E` we don't embed anything, > > That was just an exaggerated example of top-level options affecting > su

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3eca3359402: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[clang] e3eca33 - [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

Author: Owen Pan Date: 2023-01-13T15:46:34-08:00 New Revision: e3eca335940251308c8990c8880341002e74b9c1 URL: https://github.com/llvm/llvm-project/commit/e3eca335940251308c8990c8880341002e74b9c1 DIFF: https://github.com/llvm/llvm-project/commit/e3eca335940251308c8990c8880341002e74b9c1.diff LOG:

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. In D141717#4052824 , @jhuber6 wrote: > For `-E` we don't embed anything, That was just an exaggerated example of top-level options affecting sub-compilation output where you can't magically tweak it to produce the kind of output yo

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan added a comment. In D141654#4050852 , @rymiel wrote: > I'm not sure what the strict //benefit// of squishing the two options > together is, but I support it See D108752 and the added table in the summary. CH

[PATCH] D141310: [clang] add -Wcompare-function-pointers

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< aaron.ballman wro

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan added a comment. In D141654#4052510 , @HazardyKnusperkeks wrote: > In D141654#4050852 , @rymiel wrote: > >> (This needs to run the updated dump script from D138446 >> )

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4052869 , @rsmith wrote: > In D141625#4052820 , @dblaikie > wrote: > >> Yeah, might be nice to document where the instability comes from - if it >> comes from a DenseMap or

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added inline comments. Comment at: clang/test/Frontend/stack-layout-remark.c:24 +// YAML: Name:StackLayout +// YAML: DebugLoc:{ File: '{{.*}}stack-layout-remark.c', Line: [[# @LINE + 24]], +// YAML: Function:foo chapuni wrote:

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 updated this revision to Diff 489136. ziqingluo-90 added a comment. Rebase the patch. Move the check of whether a node is in an opt-out region to an earlier stage---the AST matching stage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140179/new/ https://reviews.llvm.org/

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added a comment. This failed on some environments. See https://lab.llvm.org/buildbot/#/builders/109/builds/55534 Comment at: clang/test/Frontend/stack-layout-remark.c:24 +// YAML: Name:StackLayout +// YAML: DebugLoc:{ File: '{{.*}}stack-layout-remar

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:17 + +static const llvm::StringSet<> ValueTraits = { +"alignment_of", carlosgalvezp wrote: > I'm guessing this li

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

akyrtzi added a comment. Yeah, you mainly need more than 32 decls to exceed the small storage of `Scope::DeclSetTy`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D141625 __

[clang] fdc0bf6 - Revert "[codegen] Add StackFrameLayoutAnalysisPass"

Author: Paul Kirth Date: 2023-01-13T22:59:36Z New Revision: fdc0bf6adceeb7f800ec152486f26a6bed8d2ccb URL: https://github.com/llvm/llvm-project/commit/fdc0bf6adceeb7f800ec152486f26a6bed8d2ccb DIFF: https://github.com/llvm/llvm-project/commit/fdc0bf6adceeb7f800ec152486f26a6bed8d2ccb.diff LOG: Re

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#4052782 , @tejohnson wrote: > In D131306#4037037 , @paulkirth > wrote: > >> @tejohnson @xur I kind of dropped the ball on these patches, but what are >> your thoughts on thi

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1f4bfd2a8b0: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D141708: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b9a3974244: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141708/new/ ht

[clang] 52b9a39 - [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

Author: Joseph Huber Date: 2023-01-13T16:52:06-06:00 New Revision: 52b9a3974244183806ba862e161670d79885443a URL: https://github.com/llvm/llvm-project/commit/52b9a3974244183806ba862e161670d79885443a DIFF: https://github.com/llvm/llvm-project/commit/52b9a3974244183806ba862e161670d79885443a.diff

[clang] d1f4bfd - [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

Author: Joseph Huber Date: 2023-01-13T16:52:07-06:00 New Revision: d1f4bfd2a8b0b347aeaf6d486e4132af65b9ccf0 URL: https://github.com/llvm/llvm-project/commit/d1f4bfd2a8b0b347aeaf6d486e4132af65b9ccf0 DIFF: https://github.com/llvm/llvm-project/commit/d1f4bfd2a8b0b347aeaf6d486e4132af65b9ccf0.diff

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

rsmith added a comment. In D141625#4052820 , @dblaikie wrote: > Yeah, might be nice to document where the instability comes from - if it > comes from a DenseMap or similar, then a test that fails either in forward or > reverse iteration mode would be ni

[PATCH] D141708: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141708/new/ https://reviews.llvm.org/D141708 ___

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan updated this revision to Diff 489125. owenpan added a comment. Rebased and ran the latest `dump_format_style.py` to generate `ClangFormatStyleOptions.rst`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141654/new/ https://reviews.llvm.org/D141654 Files: clang/docs/ClangForma

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4052753 , @tra wrote: > In D141717#4052587 , @jhuber6 wrote: > >> Well you'll get textual output for the host output, but the device code >> embedded in the host module will be

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. Yeah, might be nice to document where the instability comes from - if it comes from a DenseMap or similar, then a test that fails either in forward or reverse iteration mode would be nice to have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

dblaikie added a comment. In D140423#4052540 , @erichkeane wrote: > A Class template instantiation SHOULD have its link back to the class > template, and should be able to calculate whether the template argument is > defaulted, right? For a normal/cla

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/37/builds/19499 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 ___ cfe-commits mailing lis

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added a comment. In D131306#4037037 , @paulkirth wrote: > @tejohnson @xur I kind of dropped the ball on these patches, but what are > your thoughts on this approach over the old(more invasive) change to the > profdata format I had prototyped b

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. In D141717#4052587 , @jhuber6 wrote: > Well you'll get textual output for the host output, but the device code > embedded in the host module will be bitcode instead. So the final output from > the compiler is still textual IR. It ju

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Is it impractical to add a test for this? Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Removing a `CMAKE_*_DEFAULT_*` makes me happy:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141723/new/ https://reviews.llvm.org/D141723 __

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

tschuett added a comment. Up right you will find `Edit Related Revisions...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141723/new/ https://reviews.llvm.org/D141723 ___ cfe-commits mailing list cfe-c

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield, MaskRay, mgorny, tstellar. Herald added subscribers: mattd, gchakrabarti, asavonic, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-comm

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole updated this revision to Diff 489109. adriandole added a comment. - More helpful diagnostic message. - Check variable and type names are printed in tests. - Enable `-Wordered-function-pointer-comparison` when this warning is enabled. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141563: [clang-format] Fix a bug in DerivePointerAlignment fallback

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2aa8bb6dea: [clang-format] Fix a bug in DerivePointerAlignment fallback (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 2e2aa8b - [clang-format] Fix a bug in DerivePointerAlignment fallback

Author: Owen Pan Date: 2023-01-13T12:58:33-08:00 New Revision: 2e2aa8bb6dea365e972528ad330f575b6b6e254b URL: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b DIFF: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b.diff LOG:

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a652c540556: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0a652c5 - [codegen] Add StackFrameLayoutAnalysisPass

Author: Paul Kirth Date: 2023-01-13T20:52:48Z New Revision: 0a652c540556a118bbd9386ed3ab7fd9e60a9754 URL: https://github.com/llvm/llvm-project/commit/0a652c540556a118bbd9386ed3ab7fd9e60a9754 DIFF: https://github.com/llvm/llvm-project/commit/0a652c540556a118bbd9386ed3ab7fd9e60a9754.diff LOG: [c

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 updated this revision to Diff 489105. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/nested_loop_codegen.cpp Index: clang/test/OpenMP/nested_loop_codegen.cpp

Re: [clang] 6809af1 - Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Fri, Jan 13, 2023 at 11:40 PM Dominik Adamski via cfe-commits wrote: > > > Author: Dominik Adamski > Date: 2023-01-13T14:38:17-06:00 > New Revision: 6809af1a232bc5ac71358e4b874759ddaae056a1 > > URL: >

[clang] 6809af1 - Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"

Author: Dominik Adamski Date: 2023-01-13T14:38:17-06:00 New Revision: 6809af1a232bc5ac71358e4b874759ddaae056a1 URL: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1 DIFF: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1.dif

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4052514 , @tra wrote: > Textual output for "-S -emit-llvm" is the canonical behavior, so I would > prefer it working that way in as many cases as possible and only override it > when necessary. > > Would it be possibl

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo updated this revision to Diff 489098. mstorsjo added a comment. Switched the macro to a function and changed the variables to cache variables, to allow setting them in the grandparent scope without being a macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

erichkeane added a comment. A Class template instantiation SHOULD have its link back to the class template, and should be able to calculate whether the template argument is defaulted, right? At least if it is the SAME as the default (that is, I'm not sure how well we can tell the difference be

[PATCH] D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend (authored by domada). Herald added projects: clang, LLDB. Heral

[clang] ed01de6 - [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-13T14:07:29-06:00 New Revision: ed01de67433174d3157e9d239d59dd465d52c6a5 URL: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5 DIFF: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5.dif

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

HazardyKnusperkeks added reviewers: owenpan, HazardyKnusperkeks. HazardyKnusperkeks added a comment. Looks ok for me. Comment at: clang/include/clang/Format/Format.h:3500 +/// \code +///using std::c; +///using std::b; You should use the same

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. Textual output for "-S -emit-llvm" is the canonical behavior, so I would prefer it working that way in as many cases as possible and only override it when necessary. Would it be possible to enforce binary IR generation in cases you need it? Or to prove that this is equival

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D141654#4050852 , @rymiel wrote: > (This needs to run the updated dump script from D138446 > ) > > I'm not sure what the strict //benefit/

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

sammccall added a comment. To offer the opposing argument: if DeclResult is just a bad idea, then using it consistently/right might be worse than using it as little as possible. FWIW, I find every piece of code that produces/consumes the `*Result` to be extremely confusing (the semantics of the

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset += align(primSize(Ty)); shafik wrote: > Where is `Params` used?

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139185/new/ https://reviews.llvm.org/D139185 ___ cfe-commits mailing lis

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have deleted the test in https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016. It is safe to delete as this is a brittle test trying to generate an invalid requirement using very deep templat

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D140423#4052271 , @dblaikie wrote: > In D140423#4051262 , @aaron.ballman > wrote: > >>>

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Thanks a lot for the review, by the way. I realize the patch wasn't up to snuff initially, but glad to get it in order with your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489086. seanptmaher added a comment. No need to include os anymore, I'm not checking number of cores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: clan

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. It's slightly hard to test this because it involves making a huge diff of a git repo. If you're willing to jump through the hoops of cloning chromium (honestly, this is a pain in the ass. It's too much hard drive space and you've got to install depot_tools. If you d

[PATCH] D141193: [clang][Interp] Implement __builtin_assume

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; I verified that constant expression evaluation ignores failed assumptions: http://eel.is/c++draft/expr.const#5.8 so this is in line with the C++2b feature. Repository:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489084. seanptmaher added a comment. Fix bug in -j implementation where proper waiting wasn't happening Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: c

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Currently, we embed dev

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4aa6c7a5f2: [cmake] Fix path to LLVMConfig.cmake for multi-config builds (authored by nhat-nguyen, committed by sebastian-ne). Repository: rG LL

[clang] eb4aa6c - [cmake] Fix path to LLVMConfig.cmake for multi-config builds

Author: Nhat Nguyen Date: 2023-01-13T20:32:59+01:00 New Revision: eb4aa6c7a5f22583e319e3f6ee73cbc5464a URL: https://github.com/llvm/llvm-project/commit/eb4aa6c7a5f22583e319e3f6ee73cbc5464a DIFF: https://github.com/llvm/llvm-project/commit/eb4aa6c7a5f22583e319e3f6ee73cbc5464a.diff L

[PATCH] D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Also adds uses of the new printin

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4052323 , @abhinavgaba wrote: >> In target data we already put a and b in use_device_addr. That indicates all >> use of a and b will be the corresponding device addresses. Therefore, in >> target directive, we

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

shafik added a comment. Makes sense to me as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/new/ https://reviews.llvm.org/D140838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] a3b632a - Remove brittle test introduced in D140547.

Author: Utkarsh Saxena Date: 2023-01-13T20:26:38+01:00 New Revision: a3b632ab8772237ae23638f702bdceda028b2016 URL: https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016 DIFF: https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016.diff

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. I cannot speak much about LLVM tests but the code looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141206/new/ https://reviews.llvm.org/D141206 ___ cfe-commits ma

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi created this revision. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously clang AST prints the following declaration: int fun_var_unused() { int x __attribute__((u

  1   2   3   >