[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder updated this revision to Diff 43. tbaeder added a comment. Add more tests and fix decomposition decls of reference type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llvm.org/D138802 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 42. carlosgalvezp added a comment. Add ExtraArgs and ExtraArgsBefore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/t

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 41. pmatos added a comment. Update mangling for Microsoft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/in

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2479-2483 +#define WASM_REF_TYPE(InternalName, MangledName, Id, SingletonId, AS) \ + case BuiltinType::Id: \ +Out << "PA";

[PATCH] D133574: [C2x] reject type definitions in offsetof

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe327b52766ed: [C2x] reject type definitions in offsetof (authored by inclyc). Changed prior to commit: https://reviews.llvm.org/D133574?vs=482719&

[clang] e327b52 - [C2x] reject type definitions in offsetof

Author: Yingchi Long Date: 2023-01-13T15:33:26+08:00 New Revision: e327b52766ed497e4779f4e652b9ad237dfda8e6 URL: https://github.com/llvm/llvm-project/commit/e327b52766ed497e4779f4e652b9ad237dfda8e6 DIFF: https://github.com/llvm/llvm-project/commit/e327b52766ed497e4779f4e652b9ad237dfda8e6.diff

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu added a comment. @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: error: unknown target 'libcxx-generate-files'`. The following off is my configuring command: cmake -G Ninja -S llvm -B build_libcxx_modules -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_ENABLE_RUNT

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f5eb3190cfc: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/

[clang-tools-extra] 0f5eb31 - [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

Author: Carlos Galvez Date: 2023-01-13T07:29:49Z New Revision: 0f5eb3190cfc09796b08648fac7e936ffdcfb8d7 URL: https://github.com/llvm/llvm-project/commit/0f5eb3190cfc09796b08648fac7e936ffdcfb8d7 DIFF: https://github.com/llvm/llvm-project/commit/0f5eb3190cfc09796b08648fac7e936ffdcfb8d7.diff LOG:

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 488873. ChuanqiXu added a comment. Herald added a subscriber: arichardson. After failed to reproduce the error locally, try to follow the instructions from @philnik to see if the CI-Bot will break. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/cxx17.cpp:7 + +struct F { int a; int b;}; +constexpr F getF() { shafik wrote: > It would also be good to test references, bit-fields, volatile and tuple-lik

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

owenpan added a comment. I will change `DeriveLineEnding: false` to `LineEnding: LF` after D141654 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098 __

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

hazohelet updated this revision to Diff 488863. hazohelet added a comment. I added the release note. > Also, do you need someone to commit on your behalf? If so, what name and > email address would you like used for patch attribution? I don't have commit access. Would you please land this patch

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil abandoned this revision. jankratochvil added a comment. Thanks for the reminder, I have todolisted it now for myself but for now I am abandoning it as I cannot promise anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D140724: [clang][Interp] Add back Run() call

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false; shafik wrote: > Why did you add these checks calling `checkingPotential

[PATCH] D141338: [WIP][-Wunsafe-buffer-usage] Filter out conflicting fix-its

NoQ added a comment. Looks awesome! Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:45-48 +// Tests if any two `FixItHint`s in `FixIts` conflict. Two `FixItHint`s +// conflict if they have overlapping source ranges. +bool anyConflict(const SourceManager &

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4047976 , @dblaikie wrote: > It seemed like the places where kdevelop would want to suppress the temp dir > cleanup would be enumerable/more within kdevelop's control than instances of > libraries kdevelop is using want

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

shafik added a comment. Is this PR still workable or does it need a major rework and should be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92733/new/ https://reviews.llvm.org/D92733 ___ cfe

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488 + // FIXME: The invoke isn't applying the right attributes either + llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs()); + KernelAttrs.addAttribute("enqueued-block"); ---

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. If this patch is okay to land, could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 _

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

thakis added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:141 -class WrapperOptTable : public opt::OptTable { +class WrapperOptTable : public opt::GenericOptTable { public: thakis wrote: > C …not sure what this was, plea

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

thakis added a comment. Thanks for this change :) Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:141 -class WrapperOptTable : public opt::OptTable { +class WrapperOptTable : public opt::GenericOptTable { public: C Comm

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

thakis added a comment. cb2f23a9b0de9c6747afb1efdc6e05b4691e0c50 did the trick. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.ll

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I really don't think this is the right thing to do - the Split DWARF code, for instance, has support for GPU bundling that's missing in the module file naming code, which seems likely to b

[clang] cb2f23a - [LinkerWrapper] Adjust test after a previous change in temp file names

Author: Joseph Huber Date: 2023-01-12T20:36:27-06:00 New Revision: cb2f23a9b0de9c6747afb1efdc6e05b4691e0c50 URL: https://github.com/llvm/llvm-project/commit/cb2f23a9b0de9c6747afb1efdc6e05b4691e0c50 DIFF: https://github.com/llvm/llvm-project/commit/cb2f23a9b0de9c6747afb1efdc6e05b4691e0c50.diff

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 added a comment. In D141543#4050174 , @thakis wrote: > Thanks! Still failing with that though: > http://45.33.8.238/win/73278/step_7.txt Hm, I'm unsure what would be causing that. I could always just disable the test on Windows. This program is

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

thakis added a comment. Thanks! Still failing with that though: http://45.33.8.238/win/73278/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 ___ cfe-

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. In D135488#4049075 , @thegameg wrote: > I would rather have a more generic mechanism for remarks or diagnostics in > general. Even if it uses `isFunctionInPrintList`, I'd rather have a real flag > that doesn't require `-mllvm`

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 488842. paulkirth marked 5 inline comments as done. paulkirth retitled this revision from "[codegen] Add a remarks based Stack Layout Analysis pass" to "[codegen] Add StackFrameLayoutAnalysisPass". paulkirth edited the summary of this revision. paulkirth add

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1feb7af04688: [clangd] support expanding `decltype(expr)` (authored by v1nh1shungry, committed by sammccall). Changed prior to commit: https://rev

[clang] 1feb7af - [clangd] support expanding `decltype(expr)`

Author: v1nh1shungry Date: 2023-01-13T03:26:33+01:00 New Revision: 1feb7af046889728233e67e3163ab30020207bb2 URL: https://github.com/llvm/llvm-project/commit/1feb7af046889728233e67e3163ab30020207bb2 DIFF: https://github.com/llvm/llvm-project/commit/1feb7af046889728233e67e3163ab30020207bb2.diff

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5736 + C.getArgs().hasArg(options::OPT_fmodule_output) && + C.getArgs().hasArg(options::OPT_o)) { +SmallString<128> OutputPath; h-ve

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 488836. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments: fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: clang/include/clang/Basic/DiagnosticD

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG485ba407a6a9: [clang][test] Remove unnecessary 'REQUIRES' (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 485ba40 - [clang][test] Remove unnecessary 'REQUIRES'

Author: Ben Shi Date: 2023-01-13T10:04:22+08:00 New Revision: 485ba407a6a903b2443a8b6b7912de234cc60ffd URL: https://github.com/llvm/llvm-project/commit/485ba407a6a903b2443a8b6b7912de234cc60ffd DIFF: https://github.com/llvm/llvm-project/commit/485ba407a6a903b2443a8b6b7912de234cc60ffd.diff LOG:

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488834. paulkirth added a comment. Fix documentation string, since it was invalid formatting for the rst file. Also since code blocks don't render correctly in the html, write the documentation so that its usable without the code examples Repository: r

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

MaskRay added a comment. `-fsanitize=alignment -c a.c -O[012]` no longer crashes for the test. From the comment that the problem was up the call chain, I think we can close this revision now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92001/new/ https://reviews.llvm.org/D92001 ___

[PATCH] D131858: [clang] Track the templated entity in type substitution.

rsmith added a comment. In D131858#3957630 , @arphaman wrote: > This change has caused a failure in Clang's stage 2 CI on the green dragon > Darwin CI: > https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. > > Assertion failed: (l

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added a comment. In D141627#4049085 , @tianshilei1992 wrote: > FWIW, I think `has_device_addr(b[0])` is not trying to take the value of > `b[0]` in this case. Instead, it's just to take the address of the first > element of `b`. Only pointe

[clang] 77d81d5 - [LinkerWrapper] Fix test on Windows

Author: Joseph Huber Date: 2023-01-12T19:57:34-06:00 New Revision: 77d81d593cb93d275794edf66caf0daa8d102d5f URL: https://github.com/llvm/llvm-project/commit/77d81d593cb93d275794edf66caf0daa8d102d5f DIFF: https://github.com/llvm/llvm-project/commit/77d81d593cb93d275794edf66caf0daa8d102d5f.diff

[clang] 2009f24 - Remove a bogus assertion.

Author: Richard Smith Date: 2023-01-12T17:57:14-08:00 New Revision: 2009f2450532450a99c1a03d5e2c30f478121839 URL: https://github.com/llvm/llvm-project/commit/2009f2450532450a99c1a03d5e2c30f478121839 DIFF: https://github.com/llvm/llvm-project/commit/2009f2450532450a99c1a03d5e2c30f478121839.diff

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 added a comment. In D141543#4050080 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/73276/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Yes, seems I forgot that `clang` is `

[PATCH] D141558: [MemProf] Collect access density statistics during profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee73d240ab1d: [MemProf] Collect access density statistics during profiling (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES S

[clang] ee73d24 - [MemProf] Collect access density statistics during profiling

Author: Teresa Johnson Date: 2023-01-12T17:53:23-08:00 New Revision: ee73d240ab1dc026f99e7e9062c921928d2b138c URL: https://github.com/llvm/llvm-project/commit/ee73d240ab1dc026f99e7e9062c921928d2b138c DIFF: https://github.com/llvm/llvm-project/commit/ee73d240ab1dc026f99e7e9062c921928d2b138c.diff

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/73276/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.ll

[PATCH] D141577: [WIP][4/N][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

eopXD updated this revision to Diff 488826. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141577/new/ https://reviews.llvm.org/D141577 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index: clang/lib/Support/RI

[PATCH] D141575: [WIP][3/N][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

eopXD updated this revision to Diff 488824. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141575/new/ https://reviews.llvm.org/D141575 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index: clang/lib/Support/RI

[PATCH] D141574: [WIP][2/N][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

eopXD updated this revision to Diff 488823. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141574/new/ https://reviews.llvm.org/D141574 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clang/lib/Support/R

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

MaskRay added a comment. Unless there is something weird, `-E` does not need llvm/lib/Target code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141647/new/ https://reviews.llvm.org/D141647 ___ cfe-commi

[PATCH] D141573: [WIP][1/N][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

eopXD updated this revision to Diff 488822. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141573/new/ https://reviews.llvm.org/D141573 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clang/lib/Sema/Sema

[PATCH] D141636: [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit`

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141636/new/ https://reviews.llvm.org/D141636 __

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. What's the status here? Should this be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D431

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

benshi001 created this revision. benshi001 added reviewers: aaron.ballman, MaskRay. Herald added subscribers: kosarev, tpr. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. The test 'Preproc

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D130209: [clang-tidy][NFC] Update tests to specify CheckOptions using new syntax

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D140686: [Clang][RISCV] Update operand order for vmerge and vcompress

This revision was automatically updated to reflect the committed changes. Closed by commit rG2532aa57665a: [Clang][RISCV] Update operand order for vmerge and vcompress (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ ht

[PATCH] D97204: [RFC] Clang 64-bit source locations

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to c

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: NoQ. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Gith

[PATCH] D121629: clang: also check alloc_alignment claims in return

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:37 +//* @param bar +//* @return +//*/ sammccall wrote: > I'm a bit concerned about people generating these `@param bar` and `@return` > and lea

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHA

[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository:

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D78028: move shebangs from python2 to python3

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: cfe-commits, llvm-commits, Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, StephenFan, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, stephenne

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7910ee7d8c6d: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty (authored by v1nh1shungry, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang-tools-extra] 7910ee7 - [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

Author: v1nh1shungry Date: 2023-01-13T01:14:51Z New Revision: 7910ee7d8c6dcb679200ba171fba5d8d5f237007 URL: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007 DIFF: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007.diff LOG:

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488815. paulkirth added a comment. Address comments - Take a stab a ReleaseNotes - Update -Wframe-larger-than documentation to reference this pass - Enable filtering output from this pass by function name Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D125272: [clang] Add -fcheck-new support

lebedev.ri resigned from this revision. lebedev.ri added a comment. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Reposit

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

h-vetinari added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5639-5640 + + // If we're emitting a module output with the speicifed option + // `-fmodule-output`. + if (!AtTopLevel && isa(JA) && Comment at: clang/lib/Driver/Driv

[PATCH] D115848: tidy-llvm

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review may be stuck/dead, consider abandoning if no longer relevant. Removin

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LuoYuanke commandeered this revision. LuoYuanke edited reviewers, added: LiuChen3; removed: LuoYuanke. LuoYuanke added a subscriber: lebedev.ri. LuoYuanke added a comment. In D99565#4049330 , @lebedev.ri wrote: > This review seems to be stuck/dead, conside

[PATCH] D96223: [clang-tidy] Simplify static assert check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG L

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. CHANGES SINCE LAST ACTION https:/

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D135636

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: Naghasan, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer rel

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Mon

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longe

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SIN

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan, mgehre. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, co

[PATCH] D50852: [clang-tidy] abseil-auto-make-unique

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: StephenFan, mgehre. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relev

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. @paulkirth please don't forget to update the commit description with that flag so that I don't have to read the contents of the commit to find this flag again. If you're using `arc diff` to upload the patch, the `--verbatim` flag will update the phab descriptio

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. In D135488#4049075 , @thegameg wrote: > You can easily... I'll just note that v1 of this patch IIRC was a note on the single individual instance of the `-Wframe-larger-than=` diagnostic. No additional flags for optimiz

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. FWIW, I think `has_device_addr(b[0])` is not trying to take the value of `b[0]` in this case. Instead, it's just to take the address of the first element of `b`. Only pointer arithmetic will be involved. It's not necessarily illegal to do it in that way. Reposi

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. In D135488#4049050 , @nickdesaulniers wrote: > In D135488#4049035 , @paulkirth > wrote: > >> Actually if we add >> >> if (!isFunctionInPrintList(MF.getName())) >>return false;

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. Sorry, mind adding the documentation, too? Comment at: clang/test/Frontend/stack-layout-remark.c:8 +// RUN: mkdir -p %t +// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu -target-cpu corei7 -Rpass-analysis=stack-frame-la

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D135488#4049035 , @paulkirth wrote: > Actually if we add > > if (!isFunctionInPrintList(MF.getName())) >return false; > > we can filter by name Does name mangling compl

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

dblaikie added a comment. In D141450#4049026 , @Bigcheese wrote: > In D141450#4044680 , @dblaikie > wrote: > >>> This is a problem because some existing ObjectiveC code is not compatible >>> with LSV >> >> Hmm,

  1   2   3   4   >