[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6acd0196b33: [Sema] Fix crash when evaluating nested call with value-dependent arg (authored by Pierre-vh). Repository: rG LLVM Github Monorepo

[clang] d6acd01 - [Sema] Fix crash when evaluating nested call with value-dependent arg

Author: Pierre van Houtryve Date: 2023-01-06T02:57:50-05:00 New Revision: d6acd0196b3378bdeb5193053e290d7194c4f72d URL: https://github.com/llvm/llvm-project/commit/d6acd0196b3378bdeb5193053e290d7194c4f72d DIFF: https://github.com/llvm/llvm-project/commit/d6acd0196b3378bdeb5193053e290d7194c4f72d

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added inline comments. Comment at: clang/tools/driver/driver.cpp:251 + std::string &OptFile) { + T OptVal = ::getenv(EnvOptSet); + if (OptVal) { SeanP wrote: > This change is not POSIX compliant. If T is char *, the next call to >

[clang] 34aa2e2 - Save the result of getenv() to a string

Author: Akira Hatanaka Date: 2023-01-05T22:59:07-08:00 New Revision: 34aa2e24c89ae39c0db4254d8aafcae0285dbe34 URL: https://github.com/llvm/llvm-project/commit/34aa2e24c89ae39c0db4254d8aafcae0285dbe34 DIFF: https://github.com/llvm/llvm-project/commit/34aa2e24c89ae39c0db4254d8aafcae0285dbe34.diff

[clang] 1ff3064 - [Driver] Simplify -fsanitize-memory-track-origins handling. NFC

Author: Fangrui Song Date: 2023-01-05T22:21:13-08:00 New Revision: 1ff3064c65b4d4440254311474efe176fd1c4e2c URL: https://github.com/llvm/llvm-project/commit/1ff3064c65b4d4440254311474efe176fd1c4e2c DIFF: https://github.com/llvm/llvm-project/commit/1ff3064c65b4d4440254311474efe176fd1c4e2c.diff

[clang] 22df454 - Revert "[Fix]"[-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations""

Author: ziqingluo-90 Date: 2023-01-05T22:06:46-08:00 New Revision: 22df4549a3718dcd8b387ba8246978349e4be50c URL: https://github.com/llvm/llvm-project/commit/22df4549a3718dcd8b387ba8246978349e4be50c DIFF: https://github.com/llvm/llvm-project/commit/22df4549a3718dcd8b387ba8246978349e4be50c.diff

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry created this revision. v1nh1shungry added reviewers: cjdb, hokein. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Herald added

[PATCH] D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG143ec502e985: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[clang] 143ec50 - [Sema] Fix a bug where clang doesn't detect uses of unavailable decls

Author: Akira Hatanaka Date: 2023-01-05T20:33:56-08:00 New Revision: 143ec502e9859141e9d340ed59046dad0fc4ee6f URL: https://github.com/llvm/llvm-project/commit/143ec502e9859141e9d340ed59046dad0fc4ee6f DIFF: https://github.com/llvm/llvm-project/commit/143ec502e9859141e9d340ed59046dad0fc4ee6f.diff

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea0cd51a4958: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C (authored by ahatanak). Repository: rG LLVM Github Monorepo CHAN

[clang] ea0cd51 - [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C

Author: Akira Hatanaka Date: 2023-01-05T19:48:25-08:00 New Revision: ea0cd51a495829ea35b7b8304b16784946598d19 URL: https://github.com/llvm/llvm-project/commit/ea0cd51a495829ea35b7b8304b16784946598d19 DIFF: https://github.com/llvm/llvm-project/commit/ea0cd51a495829ea35b7b8304b16784946598d19.diff

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a pro

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

jhuber6 updated this revision to Diff 486741. jhuber6 added a comment. Change error to use canonical arch string from the triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141078/new/ https://reviews.llvm.org/D141078 Files: clang/lib/Driver/

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

ahatanak added a comment. In D136639#4006953 , @rjmccall wrote: > Oh, I see. That's a really unfortunate way to end up emitting this code > pattern, since ignoring the result is so common. To fix that, we'd have to > either figure out the result was u

[PATCH] D140527: [LoongArch] Add intrinsics for CACOP instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e06d18c80e7: [LoongArch] Add intrinsics for CACOP instruction (authored by XiaodongLoong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140527/new/ https:

[clang] 9e06d18 - [LoongArch] Add intrinsics for CACOP instruction

Author: Xiaodong Liu Date: 2023-01-06T11:41:35+08:00 New Revision: 9e06d18c80e77383f0ecdda428e74fbc1df3dd99 URL: https://github.com/llvm/llvm-project/commit/9e06d18c80e77383f0ecdda428e74fbc1df3dd99 DIFF: https://github.com/llvm/llvm-project/commit/9e06d18c80e77383f0ecdda428e74fbc1df3dd99.diff

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 updated this revision to Diff 486739. jhuber6 added a comment. Change error to print canonical arch name from Triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141051/new/ https://reviews.llvm.org/D141051 Files: clang/include/clang/B

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

rymiel added a comment. The LLVM Coding Standard apparently doesn't mention line endings..? A quick grep does show a bunch of \r\n results, primarily in tests. I'd be in favor of forcing \n, but I think this is a wider matter..? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. >> In what mode will clang output #include information without erroring about >> missing .pcm files for import statements? -E -fdirectives-only perhaps? This >> further exacerbates the need for "fake" command lines and costs on platforms >> with expensive process exec

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9899501576e: [clang-format] Disallow decltype in the middle of constraints (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1eeec6177fa: [clang-format] Remove special logic for parsing concept definitions. (authored by rymiel). Repository: rG LLVM Github Monorepo CHAN

[clang] d989950 - [clang-format] Disallow decltype in the middle of constraints

Author: Emilia Dreamer Date: 2023-01-06T05:18:28+02:00 New Revision: d9899501576e7b3b8ec4a3f0f855a6bfe68cef88 URL: https://github.com/llvm/llvm-project/commit/d9899501576e7b3b8ec4a3f0f855a6bfe68cef88 DIFF: https://github.com/llvm/llvm-project/commit/d9899501576e7b3b8ec4a3f0f855a6bfe68cef88.diff

[clang] b1eeec6 - [clang-format] Remove special logic for parsing concept definitions.

Author: Emilia Dreamer Date: 2023-01-06T05:17:58+02:00 New Revision: b1eeec6177fafcc433d98c4f46f353b13c68aca0 URL: https://github.com/llvm/llvm-project/commit/b1eeec6177fafcc433d98c4f46f353b13c68aca0 DIFF: https://github.com/llvm/llvm-project/commit/b1eeec6177fafcc433d98c4f46f353b13c68aca0.diff

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 486732. abidmalikwaterloo added a comment. Added a pretty test for omp.distrubute in ops.mlir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 Files: mlir/

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23593-23594 - "template \n" - "concept DelayedCheck = static_cast(0) ||\n" - " requires(T t) { t.bar(); } && sizeof(T) <=

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG54fab18cedac: [clang-format] Require space before noexcept qualifier (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140767/new/ https:/

[clang] 54fab18 - [clang-format] Require space before noexcept qualifier

Author: Emilia Dreamer Date: 2023-01-06T05:03:56+02:00 New Revision: 54fab18cedace085344b674ab9de2c93b5fa479b URL: https://github.com/llvm/llvm-project/commit/54fab18cedace085344b674ab9de2c93b5fa479b DIFF: https://github.com/llvm/llvm-project/commit/54fab18cedace085344b674ab9de2c93b5fa479b.diff

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

kstoimenov added a comment. Is it possible these errors are due to your change: https://lab.llvm.org/buildbot/#/builders/5/builds/30522/steps/13/logs/stdio? If so please consider reverting/fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1383

[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result

v1nh1shungry marked 2 inline comments as done. v1nh1shungry added a comment. Thank you for reviewing and giving suggestions! @Eugene.Zelenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141058/new/ https://reviews.llvm.org/D141058 ___

[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result

v1nh1shungry updated this revision to Diff 486729. v1nh1shungry added a comment. don't use `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141058/new/ https://reviews.llvm.org/D141058 Files: clang-tools-extra/clang-tidy/bugprone/ImplicitWi

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. > IMO, this is not suitable; there must be *one* depfile for Ninja to work > (otherwise build tools will need to manually collate all of this into one for > ninja. Yeah, but the producer of the compilation database is able to create a compilation db with the same `-M

[clang] 7f56488 - Fix for tests on Windows buildbot

Author: Brad Smith Date: 2023-01-05T21:25:32-05:00 New Revision: 7f564882466787e5b93c9253d7dbcaf6ebd82f95 URL: https://github.com/llvm/llvm-project/commit/7f564882466787e5b93c9253d7dbcaf6ebd82f95 DIFF: https://github.com/llvm/llvm-project/commit/7f564882466787e5b93c9253d7dbcaf6ebd82f95.diff LO

[clang] 8fd279f - [Driver] move Fuchsia header search path management to the driver

Author: Brad Smith Date: 2023-01-05T21:21:08-05:00 New Revision: 8fd279f7d369d6acdea7c0bd60c40bbc8c6beb06 URL: https://github.com/llvm/llvm-project/commit/8fd279f7d369d6acdea7c0bd60c40bbc8c6beb06 DIFF: https://github.com/llvm/llvm-project/commit/8fd279f7d369d6acdea7c0bd60c40bbc8c6beb06.diff LO

[PATCH] D141073: [Driver] move Fuchsia header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fd279f7d369: [Driver] move Fuchsia header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D141073: [Driver] move Fuchsia header search path management to the driver

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141073/new/ https://reviews.llvm.org/D141073 ___

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. @dblaikie would you like to take a look at this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140927/new/ https://reviews.llvm.org/D140927

[PATCH] D140527: [LoongArch] Add intrinsics for CACOP instruction

XiaodongLoong updated this revision to Diff 486725. XiaodongLoong added a comment. rebase code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140527/new/ https://reviews.llvm.org/D140527 Files: clang/include/clang/Basic/BuiltinsLoongArch.def c

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), + hasMethod(cxxMethodDecl(hasN

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf70d17fc2c10: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] f70d17f - [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Author: Brad Smith Date: 2023-01-05T20:21:22-05:00 New Revision: f70d17fc2c10381682123c5f8766bd59c27dfbdd URL: https://github.com/llvm/llvm-project/commit/f70d17fc2c10381682123c5f8766bd59c27dfbdd DIFF: https://github.com/llvm/llvm-project/commit/f70d17fc2c10381682123c5f8766bd59c27dfbdd.diff LO

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), + hasMethod(cxxMethodDecl(hasN

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

SixWeining accepted this revision. SixWeining added a comment. This matches LoongArch gcc's behavior. So LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141070/new/ https://reviews.llvm.org/D141070 ___

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter updated this revision to Diff 486716. ccotter added a comment. - Match derived types in in modernize-loop-convert - fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 Files: clang-tools-ex

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

MaskRay added a comment. In D80392#4028011 , @wzssyqa wrote: > When link with ld.bfd, we get: > > ld/ld-new: .eh_frame_hdr entry overflow > ld/ld-new: final link failed: bad value > > It seems due to the `initial_loc` in the object from LLVM is quite b

[clang] 2b1a517 - Revert "[clang][dataflow] Only model struct fields that are used in the function being analyzed."

Author: Yitzhak Mandelbaum Date: 2023-01-06T01:07:28Z New Revision: 2b1a517a92bfdfa3b692a660e19a2bb22513a567 URL: https://github.com/llvm/llvm-project/commit/2b1a517a92bfdfa3b692a660e19a2bb22513a567 DIFF: https://github.com/llvm/llvm-project/commit/2b1a517a92bfdfa3b692a660e19a2bb22513a567.diff

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel added a comment. I'll revert now and take a look in the morning... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 ___ cfe-commits mailing list cfe-comm

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4030008 , @benlangmuir wrote: > Re-added a few of my minor comments that I think got lost on a specific > version of the diff. Otherwise LGTM. Sorry for missing these. I think I addressed all of them now. Repository:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 486711. friss added a comment. Fix Windows build (Thanks @ravi-ramaseshan) Address @benlangmuir comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139713/new/ https://reviews.llvm.org/D139713 _

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

MaskRay added a comment. For relands, you can just use `Differential Revision: https://reviews.llvm.org/D138321` instead of `Related differential revision: https://reviews.llvm.org/D138329`. `Revert "Revert ` can be replaced with `Reland` to emphasize that it is a reland (it can be omitted as w

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void updated this revision to Diff 486710. void added a comment. Put assert in correct place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 Files: clang-tools-extra/clangd/FindTarget.cpp clang/inclu

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added a comment. In D140584#4029607 , @aaron.ballman wrote: > Drive by comment (I'll give a more thorough review when I have a moment): > precommit CI seems to have found an issue to address. > > `Assertion failed: false && "Invalid accessor", file

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To prevent `\r\n

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572 + // case where a header file contains ObjC decls but no #imports. + Symbol::IncludeDirective Directive = preferredIncludeDirective( +

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486706. dgoldman added a comment. Respect ImportInsertions flag in IncludeFixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/AST

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

chewi added a comment. Apologies. I conceived this against 15.0.6, but have now noticed that the latest TableGen.cmake may have changed things. I'll retest tomorrow and adjust as necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

MaskRay accepted this revision. MaskRay added a comment. I don't think it is necessary to deprecate the old header then delete it after 16.0.0 is branched. llvm/Support/AArch64TargetParser.h has very few open-source out-of-tree uses. Perhaps only ldc `driver/targetmachine.cpp` uses the header. S

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

paulkirth added a comment. We're seeing a similar breakage on Linux in Fuchsia's Clang CI: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8792772367021497153/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman updated this revision to Diff 486700. dgoldman marked 2 inline comments as done. dgoldman added a comment. Update comment + default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139446/new/ https://reviews.llvm.org/D139446 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/52112/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D14069

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added a comment. In D141070#4030069 , @MaskRay wrote: > Wait for LoongArch folks:) Np :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141070/new/ https://reviews.llvm.org/D141070 __

[PATCH] D141035: [clang-format] Add an option to insert a newline at EOF if missing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c6ecc9db624: [clang-format] Add an option to insert a newline at EOF if missing (authored by owenpan). Changed prior to commit: https://reviews.l

[clang] 2c6ecc9 - [clang-format] Add an option to insert a newline at EOF if missing

Author: Owen Pan Date: 2023-01-05T15:25:51-08:00 New Revision: 2c6ecc9db624442dcc4c80ab02d15e0833c7f8a3 URL: https://github.com/llvm/llvm-project/commit/2c6ecc9db624442dcc4c80ab02d15e0833c7f8a3 DIFF: https://github.com/llvm/llvm-project/commit/2c6ecc9db624442dcc4c80ab02d15e0833c7f8a3.diff LOG:

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Wait for LoongArch folks:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141070/new/ https://reviews.llvm.org/D141070 ___

[PATCH] D141035: [clang-format] Add an option to insert a newline at EOF if missing

owenpan added a comment. In D141035#4028134 , @MyDeveloperDay wrote: > I think I've died an gone to heaven!! LGTM... Happy New Year! Happy New Year to you too! Thanks to your comment in D19031#1747112 , I remem

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

benlangmuir accepted this revision. benlangmuir added a comment. Re-added a few of my minor comments that I think got lost on a specific version of the diff. Otherwise LGTM. Comment at: llvm/include/llvm/Support/StatCacheFileSystem.h:23 +/// A ProxyFileSystem using cached info

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

chewi created this revision. chewi added a reviewer: MaskRay. chewi added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. chewi requested review of this revision. Herald added a subscriber: cfe-commits. clang-tblgen is required to cross-compile clang itself. T

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf8fd210a35c: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140868

[clang] cf8fd21 - [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

Author: Fangrui Song Date: 2023-01-05T14:36:36-08:00 New Revision: cf8fd210a35c8e93136cb8edc5c6a2e818dc1b1d URL: https://github.com/llvm/llvm-project/commit/cf8fd210a35c8e93136cb8edc5c6a2e818dc1b1d DIFF: https://github.com/llvm/llvm-project/commit/cf8fd210a35c8e93136cb8edc5c6a2e818dc1b1d.diff

[clang] c3ab645 - Add isInAnonymousNamespace() to the dynamic AST matchers

Author: Aaron Ballman Date: 2023-01-05T17:10:14-05:00 New Revision: c3ab6455e5ad24fa8e9310b94bcce4a94b8489aa URL: https://github.com/llvm/llvm-project/commit/c3ab6455e5ad24fa8e9310b94bcce4a94b8489aa DIFF: https://github.com/llvm/llvm-project/commit/c3ab6455e5ad24fa8e9310b94bcce4a94b8489aa.diff

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e8f597c2fed: [clang][dataflow] Only model struct fields that are used in the function being… (authored by ymandel). Repository: rG LLVM Github Mo

[clang] 5e8f597 - [clang][dataflow] Only model struct fields that are used in the function being analyzed.

Author: Yitzhak Mandelbaum Date: 2023-01-05T21:46:39Z New Revision: 5e8f597c2fedc740b71f07dfdb1ef3c2d348b193 URL: https://github.com/llvm/llvm-project/commit/5e8f597c2fedc740b71f07dfdb1ef3c2d348b193 DIFF: https://github.com/llvm/llvm-project/commit/5e8f597c2fedc740b71f07dfdb1ef3c2d348b193.diff

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson reopened this revision. royjacobson added a comment. This revision is now accepted and ready to land. So, I had a quick look at this. Turns out this fix changed the argument passing ABI for those classes on the Sony PS4. This is probably not acceptable :) Putting this behind an ABI c

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

aaron.ballman added a comment. Also, don't forget to add a release note for the fix. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140598/new/ https://reviews.llvm.org/D140598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:393 // reasonably apply this fallback for dependent nested-name-specifiers. -if (SS.getScopeRep()->getPrefix()) { +if (SS.isSet() && SS.getScopeRep()->getPrefix()) { if (ParsedType

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm closed this revision. arsenm added a comment. 81849497b42e1a865af8aff65ab768e56a301c87 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 __

[clang] 8184949 - clang/AMDGPU: Remove flat-address-space from feature map

Author: Matt Arsenault Date: 2023-01-05T16:35:04-05:00 New Revision: 81849497b42e1a865af8aff65ab768e56a301c87 URL: https://github.com/llvm/llvm-project/commit/81849497b42e1a865af8aff65ab768e56a301c87 DIFF: https://github.com/llvm/llvm-project/commit/81849497b42e1a865af8aff65ab768e56a301c87.diff

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad48e9669a80: [NFC] [Doc] Fix example for AnnotateTypeDocs (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] ad48e96 - [NFC] [Doc] Fix example for AnnotateTypeDocs

Author: Xiang Li Date: 2023-01-05T16:32:02-05:00 New Revision: ad48e9669a80e05c55e35970461b34f04dc0f117 URL: https://github.com/llvm/llvm-project/commit/ad48e9669a80e05c55e35970461b34f04dc0f117 DIFF: https://github.com/llvm/llvm-project/commit/ad48e9669a80e05c55e35970461b34f04dc0f117.diff LOG:

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

owenpan added a comment. In D140835#4028479 , @HazardyKnusperkeks wrote: > In D140835#4028274 , @owenpan wrote: > >> If `RemoveBracesLLVM` is false, the line is too long and will wrap. > > That's what I fail to s

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 48. ymandel added a comment. fix broken test (from rebase) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files: clang/include/clang/Analysis/FlowSensitive/Dat

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:30 * The version constants for the libclang API. * CINDEX_VERSION_MINOR should increase when there are API additions. * CINDEX_VERSION_MAJOR is intended for "major" source/ABI breaking changes. -

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://reviews.llvm.org/D139935 _

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

This revision was automatically updated to reflect the committed changes. Closed by commit rG5751c439be7d: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140835/new

[clang] 5751c43 - [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

Author: Owen Pan Date: 2023-01-05T13:23:23-08:00 New Revision: 5751c439be7d00427991e8503e618d0c27a56f89 URL: https://github.com/llvm/llvm-project/commit/5751c439be7d00427991e8503e618d0c27a56f89 DIFF: https://github.com/llvm/llvm-project/commit/5751c439be7d00427991e8503e618d0c27a56f89.diff LOG:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486659. ymandel marked an inline comment as done. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files: clang/include/clang/Analy

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel marked an inline comment as done. ymandel added a comment. In D140694#4026244 , @xazax.hun wrote: > This is a big improvement, I skimmed through it and looks good to me. There > might be some sneaky ways to change values of fields without mention

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486658. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486657. ymandel added a comment. rebase onto HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis

[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:107 << E->getSourceRange(); +auto LocForEndOfToken = +Lexer::getLocForEndOfToken(E->getEndLoc(), 0, SM, LangOpts);

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG179d24d764ac: Parse: handle another case of invalid handling for attributes (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/

[clang] 179d24d - Parse: handle another case of invalid handling for attributes

Author: Saleem Abdulrasool Date: 2023-01-05T20:53:52Z New Revision: 179d24d764ac68220047a8771e1bb06a7cb2a0da URL: https://github.com/llvm/llvm-project/commit/179d24d764ac68220047a8771e1bb06a7cb2a0da DIFF: https://github.com/llvm/llvm-project/commit/179d24d764ac68220047a8771e1bb06a7cb2a0da.diff

[PATCH] D140843: [clang-format] fix template closer followed by >

owenpan added a comment. In D140843#4028142 , @MyDeveloperDay wrote: > I'd like one of @owenpan, @HazardyKnusperkeks or @rymiel to comment before > commit, just to get another view. Perhaps clang-format should never insert a space in `>>`. CHANGES S

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

dblaikie added a comment. In D140860#4028089 , @hazohelet wrote: > As you point out, enhancement may be more accurate than bug fix. > There are rare cases where enabling a warning for missing parentheses in > `constexpr` logical expressions can be helpfu

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

aaron.ballman added a comment. Drive by comment (I'll give a more thorough review when I have a moment): precommit CI seems to have found an issue to address. `Assertion failed: false && "Invalid accessor", file C:\ws\w5\llvm-project\premerge-checks\clang\include\clang/AST/Designator.h, line 2

[clang] 8641687 - Revert "Revert "[-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations""

Author: ziqingluo-90 Date: 2023-01-05T12:04:13-08:00 New Revision: 8641687a4300ef3e9ef43eda46f6d2ea4e021dd9 URL: https://github.com/llvm/llvm-project/commit/8641687a4300ef3e9ef43eda46f6d2ea4e021dd9 DIFF: https://github.com/llvm/llvm-project/commit/8641687a4300ef3e9ef43eda46f6d2ea4e021dd9.diff

[clang] ef47a0a - [Fix]"[-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations"

Author: ziqingluo-90 Date: 2023-01-05T12:04:13-08:00 New Revision: ef47a0a711f12add401394f7af07a0b4d1635b56 URL: https://github.com/llvm/llvm-project/commit/ef47a0a711f12add401394f7af07a0b4d1635b56 DIFF: https://github.com/llvm/llvm-project/commit/ef47a0a711f12add401394f7af07a0b4d1635b56.diff

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

vvereschaka added a comment. Hi @brad , would you fix the tests https://lab.llvm.org/buildbot/#/builders/60/builds/10125 looks like the problem is here: // DRIVER-PASS-INCLUDES: "-internal-externc-isystem" "/usr/include" could be another path instead of "/usr/include". this one should

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm updated this revision to Diff 486643. arsenm added a comment. Return S.Diag CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140639/new/ https://reviews.llvm.org/D140639 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builtins-elementwise-math.c clang/test/Sema/buil

  1   2   3   >