[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

steakhal added a comment. About spellings. In the summary you used 'lesser', I think as a synonym for 'smaller' or something like that. Anyway, not important. Great stuff. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1642 +if (LHS.isUnsigned() != RH

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 483802. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder marked 5 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:607 +if (*LT == PT_Float) { + if (!this->emitAddf(getRoundingMode(E), E)) +return false; sepavloff wrote: > As discussed

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 added a subscriber: mizvekov. Origami404 added a comment. Hello, I am back now and will be available anytime next week, so if anyone has any idea on this topic, please at me! I haven't found a way that "feels right" to achieve consensus yet. But I do have something to share currently

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 updated this revision to Diff 483796. Origami404 added a comment. [clang] add -Wvla-stack-allocation and divide different VLA warning New behaviors: -Wvla-stack-allocation warns on use of a VLA that involves a stack allocation -Wvla-portability warns on any use of a VM type, ev

[PATCH] D140267: [clang-format] Allow line break between template closer and right paren

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows for `AlignAfterOpenBracket: BlockIndent` to w

[PATCH] D139485: Remove redundant .c_str() and .get() calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd22f050e15cb: Remove redundant .c_str() and .get() calls (authored by gAlfonso-bit, committed by MaskRay). Herald added a project: clang. Changed pr

[clang-tools-extra] d22f050 - Remove redundant .c_str() and .get() calls

Author: Gregory Alfonso Date: 2022-12-18T00:33:53Z New Revision: d22f050e15cb8c941d488d9674329db320ef1783 URL: https://github.com/llvm/llvm-project/commit/d22f050e15cb8c941d488d9674329db320ef1783 DIFF: https://github.com/llvm/llvm-project/commit/d22f050e15cb8c941d488d9674329db320ef1783.diff LO

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas updated this revision to Diff 483786. manas added a comment. Remove redundant branches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.c

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas marked 2 inline comments as done. manas added a comment. In D140086#3998426 , @steakhal wrote: > Thanks for going the extra mile to address this last thing. I really > appreciate it. > I've got only a few minor comments and suggestions. > > I'd rec

[clang-tools-extra] b57533d - [clang-tools-extra] llvm::Optional::value => operator*/operator->

Author: Fangrui Song Date: 2022-12-17T20:03:01Z New Revision: b57533d1d5a2fa6b9402aa6255cb67b2dd7529a4 URL: https://github.com/llvm/llvm-project/commit/b57533d1d5a2fa6b9402aa6255cb67b2dd7529a4 DIFF: https://github.com/llvm/llvm-project/commit/b57533d1d5a2fa6b9402aa6255cb67b2dd7529a4.diff LOG:

[clang] d1f4753 - [clang] llvm::Optional::value() && => operator*/operator->

Author: Fangrui Song Date: 2022-12-17T19:47:45Z New Revision: d1f475347518bdab387f21cda2281c0939a80f70 URL: https://github.com/llvm/llvm-project/commit/d1f475347518bdab387f21cda2281c0939a80f70 DIFF: https://github.com/llvm/llvm-project/commit/d1f475347518bdab387f21cda2281c0939a80f70.diff LOG:

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

iains updated this revision to Diff 483770. iains added a comment. rebased, amended a comment as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134589/new/ https://reviews.llvm.org/D134589 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. I'm +1 for the direction here; I took a brief look but will look closely either later tonight or tomorrow before I approve. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.l

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

craig.topper added a comment. In D139701#4003209 , @pengfei wrote: > In D139701#3993131 , @craig.topper > wrote: > >> I really think only X86 is using this. > > I'm still not sure of that. Please see the diff in

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin updated this revision to Diff 483757. cor3ntin added a comment. Fix fix-it tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Dec

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. I think this patch is ready for another review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 ___ cfe-commits mailing list c

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. I think this patch is ready for another review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 ___ cfe-commits mailing list c

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

iains created this revision. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. this came up during discussi

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

pengfei added a comment. In D139701#3993446 , @arsenm wrote: > TargetCodeGenInfo::setTargetAttributes already exists as a place for targets > to emit their custom attributes, x86 could emit it there It's an attractive suggestion. But it's not easy to mo

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry updated this revision to Diff 483749. v1nh1shungry added a comment. Note: Currently if there are user-defined literals, this patch will find them and get their `CompoundStmt` parents. If there is one, it will record the parent so that it can add the using-declaration in it later. If

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. In D138037#4003121 , @vabridgers wrote: > Hi @steakhal, thanks for the suggested change. > How we can help move this forward? From what I'm comprehending from the > notes, perhaps we could try running this change through our in

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. Thanks for taking a look. That' really useful feedback! Yes, the coloring can be expensive and we shouldn't run it more than once. and there's more places indeed until it either stops making changes or // no retain+release pair nesting is detected ==

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 483745. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944 Files: clang/test/

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f057e365f1f: [X86] AMD Zen 4 Initial enablement (authored by GGanesh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

vabridgers added a comment. Hi @steakhal, thanks for the suggested change. How we can help move this forward? From what I'm comprehending from the notes, perhaps we could try running this change through our internal systems level test and fuzzer. Unfortunately, I'd not be able to say more than "

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 483735. ychen added a comment. - update cxx_status.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/include/clang/AST/DeclBase.h clang/include/clan

[PATCH] D140218: [update_cc_test_checks] Default to --function-signature for new tests

arichardson added a comment. In D140218#4001835 , @jdoerfert wrote: > I don't understand why we would remove the flag for _cc_. I feel all these > patches are going exactly in the opposite direction I would think one would > go. The flag is not being r

[clang] 1e6adba - [clang] llvm::Optional::value => operator*/operator->

Author: Fangrui Song Date: 2022-12-17T08:10:45Z New Revision: 1e6adbadc77517037cb0723df26510fb7a8457ec URL: https://github.com/llvm/llvm-project/commit/1e6adbadc77517037cb0723df26510fb7a8457ec DIFF: https://github.com/llvm/llvm-project/commit/1e6adbadc77517037cb0723df26510fb7a8457ec.diff LOG: