[PATCH] D136176: Implement support for option 'fexcess-precision'.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/fexcess-precision.c:89 +// CHECK-EXT-NEXT:[[EXT1:%.*]] = fpext half [[TMP1]] to float +// CHECK-EXT-NEXT:[[MUL:%.*]] = fmul float [[EXT]], [[EXT1]] +// CHECK-EXT-NEXT:[[TMP2:%.*]] = load half, ptr [[C_A

[clang] aa00493 - [NFC] [C++20] [Modules] Add merge-records test for C++20 Modules

Author: Chuanqi Xu Date: 2022-12-15T15:32:46+08:00 New Revision: aa00493de2b3c3a1819497ad36b8262be12e40bb URL: https://github.com/llvm/llvm-project/commit/aa00493de2b3c3a1819497ad36b8262be12e40bb DIFF: https://github.com/llvm/llvm-project/commit/aa00493de2b3c3a1819497ad36b8262be12e40bb.diff LO

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu updated this revision to Diff 483083. ChuanqiXu added a comment. Rebase onto main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h clang/lib/Tooling/D

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

dblaikie added a comment. Sorry, should've caught this in review. The clang change needs test coverage in clang, but should verify the emitted it, rather than going all the way down to object code. The llvm functionality is already tested (since it's just the flag on a template parameter - it'

[clang-tools-extra] 7e937d0 - Don't include StringSwitch (NFC)

Author: Kazu Hirata Date: 2022-12-14T21:50:34-08:00 New Revision: 7e937d08e1348a0b0f543273ee1b997ea75cb8a0 URL: https://github.com/llvm/llvm-project/commit/7e937d08e1348a0b0f543273ee1b997ea75cb8a0 DIFF: https://github.com/llvm/llvm-project/commit/7e937d08e1348a0b0f543273ee1b997ea75cb8a0.diff L

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:131 + bool operator==(const Policy &Other) const { +return this->PolicyNone == Other.PolicyNone && this->TU == Other.TU && + this->TA == Other.TA && this->MU == Other

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

compnerd updated this revision to Diff 483081. compnerd retitled this revision from "Headers: make a couple of builtins non-static" to "Headers: use C++ inline semantics in C++ mode". compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:141 +// Just for maintain the old order for quick test. +return std::tie(this->MU, this->MA, this->TA, this->TU) < + std::tie(Other.MU, Other.MA, Other.TA, Other.T

[clang] 46b9d57 - Return early if FileID is invalid. NFC

Author: Akira Hatanaka Date: 2022-12-14T21:28:31-08:00 New Revision: 46b9d57976517f61d7478104cc95946d1bc03bf0 URL: https://github.com/llvm/llvm-project/commit/46b9d57976517f61d7478104cc95946d1bc03bf0 DIFF: https://github.com/llvm/llvm-project/commit/46b9d57976517f61d7478104cc95946d1bc03bf0.diff

[clang] 6eb0b0a - Don't include Optional.h

Author: Kazu Hirata Date: 2022-12-14T21:16:22-08:00 New Revision: 6eb0b0a0452a4c53ceb1156afd17764fbff5 URL: https://github.com/llvm/llvm-project/commit/6eb0b0a0452a4c53ceb1156afd17764fbff5 DIFF: https://github.com/llvm/llvm-project/commit/6eb0b0a0452a4c53ceb1156afd17764fbff5.diff L

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 483075. ChuanqiXu added a comment. Update since the dependent one changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp c

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + dblaikie wrote: > dblaikie w

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 483074. ChuanqiXu added a comment. Address comments: - Reuse the logic to compute object file for module file when `-o` is not specified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: clang/

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

BeMg added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:105 + : TU(_TU), TA(_TA), MU(_MU), MA(_MA) {} + Policy(bool _TU, bool _TA, bool _MU, bool _MA, bool _IntrinsicWithoutMU) + : TU(_TU), TA(_TA), MU(_MU), MA(_MA),

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

BeMg added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:140 +// Just for maintain the old order for quick test. +return std::tie(this->MU, this->MA, this->TA, this->TU) < + std::tie(Other.MU, Other.MA, Other.TA, Other.TU);

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG738bfbce09e7: [llvm][test] Split DW_AT_default_value check out of

[clang] 738bfbc - [llvm][test] Split DW_AT_default_value check out of clang/test/

Author: Michael Buch Date: 2022-12-15T02:57:08Z New Revision: 738bfbce09e700124dbcea55b2cfe7f499250b9c URL: https://github.com/llvm/llvm-project/commit/738bfbce09e700124dbcea55b2cfe7f499250b9c DIFF: https://github.com/llvm/llvm-project/commit/738bfbce09e700124dbcea55b2cfe7f499250b9c.diff LOG:

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

BeMg updated this revision to Diff 483068. BeMg added a comment. 1. Update policy constructor 2. use emplace_back 3. Fix miss WithoutIntrinsicMU in policy equal check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139995/new/ https://reviews.llvm.or

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

GGanesh added a comment. In D139073#3995741 , @RKSimon wrote: > @GGanesh reverse-ping @RKSimon Thanks a lot! We were trying to get the libpfm patch posted and subsequently enabling the zen4 scheduler model. Probably a week or two from there. The intel

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas created this revision. manas added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. manas requested review of th

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: kmitropoulou, Enna1, pmatos, asb, ormris, wenlei, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. vporpo requested review of this revision. Herald added subscribers: llvm-

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

Michael137 updated this revision to Diff 483065. Michael137 retitled this revision from "[llvm][test] Split DW_AT_default_value check out of clang/test/ Followup to D139953 to fix build failure on machines not configured for x86." to "[llvm][test] Split DW_AT_default_value check out of clang/tes

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s --check-prefixes=CHECK,

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/ Followup to D139953 to fix build failure on machines not configured for x86.

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie, chapuni. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 updated this revision to Diff 483060. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140080/new/ https://reviews.llvm.org/D140080 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp clang/test/Driver/ppc-cpus.c Index: clang/test/Driver/p

[clang-tools-extra] c8942c6 - [clang-tidy] Use llvm::transformOptional (NFC)

Author: Kazu Hirata Date: 2022-12-14T18:27:39-08:00 New Revision: c8942c643f7849e8f3aeeb1e6b0638ba7590 URL: https://github.com/llvm/llvm-project/commit/c8942c643f7849e8f3aeeb1e6b0638ba7590 DIFF: https://github.com/llvm/llvm-project/commit/c8942c643f7849e8f3aeeb1e6b0638ba7590.diff L

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 created this revision. qiongsiwu1 added a reviewer: nemanjai. qiongsiwu1 added projects: PowerPC, clang. Herald added subscribers: shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. The ClangBuilt

[clang] 67ddafa - [clang] Use llvm::transformOptional (NFC)

Author: Kazu Hirata Date: 2022-12-14T18:19:25-08:00 New Revision: 67ddafab30ccd3d8f87fd8b8d06198c426c6756e URL: https://github.com/llvm/llvm-project/commit/67ddafab30ccd3d8f87fd8b8d06198c426c6756e DIFF: https://github.com/llvm/llvm-project/commit/67ddafab30ccd3d8f87fd8b8d06198c426c6756e.diff L

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s --check-prefixes=CHECK,CXX

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s --check-prefixes=CHECK,CXX

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s --check-prefixes=CHECK,

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

emilio added a reviewer: aaron.ballman. emilio added a comment. (As in my previous commit, peeking based on git log, please review / forward as appropriate. Thanks again!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140075/new/ https://reviews.l

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

emilio created this revision. Herald added subscribers: arphaman, JDevlieghere. Herald added a project: All. emilio requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows tools like rust-bindgen to detect typedefs properly. See https:

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

emilio added a reviewer: aaron.ballman. emilio added a comment. Unclear to me who to request review from, so I'm peeking reviewer based on the git log. Please feel free to review or forward to someone else as appropriate. Thanks in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

emilio updated this revision to Diff 483048. emilio added a comment. Remove gratuitious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140074/new/ https://reviews.llvm.org/D140074 Files: clang/tools/libclang/CXType.cpp Index:

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

vsapsai abandoned this revision. vsapsai added a comment. Abandoning this change as now it is split between D124286 and D140073 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

vsapsai updated this revision to Diff 483047. vsapsai added a comment. Implement detecting and diagnosing duplicates during parsing based on ODR hash done during deserialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124286/new/ https://re

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

emilio created this revision. Herald added a project: All. emilio requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let the branch fall through the error path like other functions here do. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D124289: [modules] Proof of concept in using ODR hash to detect mismatching duplicate ObjCInterfaceDecl during deserialization.

vsapsai abandoned this revision. vsapsai added a comment. Superseded by D140073 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124289/new/ https://reviews.llvm.org/D124289

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added a comment. Ack, looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://reviews.llvm.org/D139953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, ChuanqiXu. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When two modules contain interfaces w

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Here's a well-formed reproducer: struct MyStringView { MyStringView(const char *); }; struct SourceLocation { static SourceLocation current(const char * = __builtin_FILE(), unsigned int = __builtin_LINE()); }; te

[PATCH] D136176: Implement support for option 'fexcess-precision'.

andrew.w.kaylor added inline comments. Comment at: clang/test/CodeGen/X86/fexcess-precision.c:89 +// CHECK-EXT-NEXT:[[EXT1:%.*]] = fpext half [[TMP1]] to float +// CHECK-EXT-NEXT:[[MUL:%.*]] = fmul float [[EXT]], [[EXT1]] +// CHECK-EXT-NEXT:[[TMP2:%.*]] = load half, p

[PATCH] D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert().

vporpo updated this revision to Diff 483032. vporpo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed a couple more files that were missing from the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

chapuni added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s --check-prefixes=CHECK,CXX

[clang] 8971fe2 - [RISCV] Remove Group from mcmodel_EQ_medlow/mcmodel_EQ_medany. NFCI

Author: Craig Topper Date: 2022-12-14T15:58:04-08:00 New Revision: 8971fe2b89793ea2c1c969882a539a04485c780c URL: https://github.com/llvm/llvm-project/commit/8971fe2b89793ea2c1c969882a539a04485c780c DIFF: https://github.com/llvm/llvm-project/commit/8971fe2b89793ea2c1c969882a539a04485c780c.diff

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder abandoned this revision. scott.linder added a comment. I'll open a new review as part of upstreaming all of the debug info work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978 _

[PATCH] D139768: [SPARC][clang] Add SPARC target feature flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0d1c29ca3a5: [SPARC][clang] Add SPARC target feature flags (authored by koakuma, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139768/ne

[clang] e0d1c29 - [SPARC][clang] Add SPARC target feature flags

Author: Koakuma Date: 2022-12-14T17:37:25-05:00 New Revision: e0d1c29ca3a52c87ecac96e00ebf236b578d8b41 URL: https://github.com/llvm/llvm-project/commit/e0d1c29ca3a52c87ecac96e00ebf236b578d8b41 DIFF: https://github.com/llvm/llvm-project/commit/e0d1c29ca3a52c87ecac96e00ebf236b578d8b41.diff LOG:

[PATCH] D140058: [clang-format][NFC] Turn on some code-changing options one by one

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the code-cha

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9861e5718f6: [llvm][DebugInfo] Backport DW_AT_default_value for template args (authored by Michael137). Repository: rG LLVM Github Monorepo CHAN

[clang] c9861e5 - [llvm][DebugInfo] Backport DW_AT_default_value for template args

Author: Michael Buch Date: 2022-12-14T22:31:46Z New Revision: c9861e5718f6352bb1ee9fe6b5c3e16a0e649360 URL: https://github.com/llvm/llvm-project/commit/c9861e5718f6352bb1ee9fe6b5c3e16a0e649360 DIFF: https://github.com/llvm/llvm-project/commit/c9861e5718f6352bb1ee9fe6b5c3e16a0e649360.diff LOG:

[clang] 5996ce1 - [clang][DebugInfo] Attach DW_AT_default_value to template arg metadata regardless of DwarfVersion

Author: Michael Buch Date: 2022-12-14T22:31:45Z New Revision: 5996ce17fb265e461b5d580c1873cb8e3ff8d62d URL: https://github.com/llvm/llvm-project/commit/5996ce17fb265e461b5d580c1873cb8e3ff8d62d DIFF: https://github.com/llvm/llvm-project/commit/5996ce17fb265e461b5d580c1873cb8e3ff8d62d.diff LOG:

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 updated this revision to Diff 482995. Michael137 added a comment. - Fix label name - Add check for end of block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://reviews.llvm.org/D139953 Files: clang/test/CodeGenCXX/de

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); andrew.w.kaylor wrote: > arsenm wrote: > > zahiraam wrote

[PATCH] D140055: [ODRHash] Detect mismatches in anonymous `RecordDecl`.

vsapsai added a comment. As I've mentioned `CXXRecordDecl::dataPtr`, the relevant code is https://github.com/llvm/llvm-project/blob/bc63a393262dd278d2f12153c30f8e6ea06a2450/clang/include/clang/AST/DeclCXX.h#L441-L442 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai added a comment. If anybody is curious about anonymous structs/unions, the relevant change is D140055 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 ___

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 ___

[PATCH] D140055: [ODRHash] Detect mismatches in anonymous `RecordDecl`.

vsapsai created this revision. vsapsai added reviewers: bruno, jansvoboda11, ChuanqiXu. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow completing a redeclarati

[PATCH] D139768: [SPARC][clang] Add SPARC target feature flags

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139768/new/ https://reviews.llvm.org/D139768

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai updated this revision to Diff 482981. vsapsai added a comment. Herald added a project: All. Rebase and use ODRDiagsEmitter. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 Files: c

[PATCH] D139742: [HLSL] Add trunc library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fbcb3f4baa8: [HLSL] Add trunc library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D

[clang] 6fbcb3f - [HLSL] Add trunc library function

Author: Joshua Batista Date: 2022-12-14T12:54:05-08:00 New Revision: 6fbcb3f4baa86e04c67cb0646312a648334700cb URL: https://github.com/llvm/llvm-project/commit/6fbcb3f4baa86e04c67cb0646312a648334700cb DIFF: https://github.com/llvm/llvm-project/commit/6fbcb3f4baa86e04c67cb0646312a648334700cb.diff

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + dblaikie wrote: > ChuanqiXu w

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + ChuanqiXu wrote: > dblaikie w

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira added a comment. >> Weirdly enough, I double-tested the behavior for -flto=thin + -mibt-seal; >> the kernel did boot fine on my setup, but when dumped/grep'ed for ENDBRs, it >> had ~500 less ENDBRs throughout the binary > > Did you confirm the issue with the reproducer in the CBL bug

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:184-185 + case tok::ampamp: + case tok::kw___declspec: + case tok::l_square: +return P.getLangOpts().CPlusPlus; aaron.ballman wrote: > Why are these pinned to C++? `__declspec` is use

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

shafik added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4760 + : Expr(CXXParenListInitExprClass, T, + T->isLValueReferenceType() ? VK_LValue + : T->isRValueReferenceType() ? VK_XValue It looks like we use this id

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

dblaikie accepted this revision. dblaikie added a comment. I think this is good - with some check after the template list to constrain the dag/not checks to only be within the intended tag, not accidentally skip past into some other tag. Comment at: clang/test/CodeGenCXX/debu

[PATCH] D139629: clang: Stop emitting "strictfp"

andrew.w.kaylor added a subscriber: erichkeane. andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs);

[PATCH] D140044: [CodeComplete] Complete members of dependent `auto` variables

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the initializer of an `auto` variable is dependent, clang doesn't give the Decl

[PATCH] D140037: [clang][dataflow] Remove old diagnoser API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ca1ae580b0c: [clang][dataflow] Remove old diagnoser API (authored by merrymeerkat, committed by gribozavr). Repository: rG LLVM Github Monorepo

[clang] 4ca1ae5 - [clang][dataflow] Remove old diagnoser API

Author: Dani Ferreira Franco Moura Date: 2022-12-14T20:45:48+01:00 New Revision: 4ca1ae580b0ce44c3a83992cf3abae45c3a229b4 URL: https://github.com/llvm/llvm-project/commit/4ca1ae580b0ce44c3a83992cf3abae45c3a229b4 DIFF: https://github.com/llvm/llvm-project/commit/4ca1ae580b0ce44c3a83992cf3abae45c

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a comment. Seems that this alone is insufficient as some build does run into issues, so I may need to refine this further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/ https://reviews.llvm.org/D139749 _

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 482950. dgoldman marked 5 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-ex

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { dang wrote: > zixuw wrote: > > Aren't these two lines su

[PATCH] D131858: [clang] Track the templated entity in type substitution.

steven_wu added a comment. The workaround in https://reviews.llvm.org/D139956 can get llvm-project bootstrap correctly, doesn't fix the underlying issue. The new failures is in building `SupportTests` where it issues a weird warning followed by missing symbol. It might be related to this commit

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

dblaikie added a comment. Partly feedback on D139989 too - if we could move this logic outside the switch, then it wouldn't need to be done in each different template parameter type? (& then D139989 I guess wouldn't be needed

[PATCH] D140037: [clang][dataflow] Remove old diagnoser API

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a clean up following the revision D139868

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2095-2097 +NamedDecl const *ND = Args.TList->getParam(i); +defaultParameter = TemplateUtils::isSubstitutedDefaultArgument( +CGM.getContext(), TA, ND, Args.Args, Args.TList->g

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon added a comment. @GGanesh reverse-ping Comment at: llvm/lib/Target/X86/X86.td:1619 ProcessorFeatures.ZN3Tuning>; +def : ProcModel<"znver4", Znver3Model, ProcessorFeatures.ZN4Features, +ProcessorFeatures.ZN4Tuning>; RKSim

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Actually, that assertion failure is pre-existing. However, this is newly failing in a no-asserts clang, so I wonder if something about this patch is just surfacing an existing bug in clang. Anyway, I hope to have a better repro by EOD. Repository: rG LLVM Github M

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > CHECK-LABEL doesn't have to match a line in the file uniquely. I mean, it's good practice if they do match uniquely; that way you don't get excessively confusing results when the output changes, and things start matching where you didn't expect. But it's not a requ

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

samitolvanen added a comment. In D140035#3995703 , @joaomoreira wrote: > Regarding https://github.com/ClangBuiltLinux/linux/issues/1737: > > Weirdly enough, I double-tested the behavior for -flto=thin + -mibt-seal; the > kernel did boot fine on my setup

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { zixuw wrote: > Aren't these two lines supposed to do this

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira added a comment. Regarding https://github.com/ClangBuiltLinux/linux/issues/1737: Weirdly enough, I double-tested the behavior for -flto=thin + -mibt-seal; the kernel did boot fine on my setup, but when dumped/grep'ed for ENDBRs, it had ~500 less ENDBRs throughout the binary. Conside

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > IIUC the labels have to match a line in the file uniquely, which the DW_TAGs > wouldn't CHECK-LABEL doesn't have to match a line in the file uniquely. What happens is that all the -LABEL directives are processed first, in order, subdividing the input text into regi

[PATCH] D140029: [CodeComplete] Provide designated-init completions in (const) reference context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd672e2fc038: [CodeComplete] Provide designated-init completions in (const) reference context (authored by sammccall). Repository: rG LLVM Github

[clang] bd672e2 - [CodeComplete] Provide designated-init completions in (const) reference context

Author: Sam McCall Date: 2022-12-14T19:41:25+01:00 New Revision: bd672e2fc03823e536866da6721b9f053cfd586b URL: https://github.com/llvm/llvm-project/commit/bd672e2fc03823e536866da6721b9f053cfd586b DIFF: https://github.com/llvm/llvm-project/commit/bd672e2fc03823e536866da6721b9f053cfd586b.diff LO

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira created this revision. joaomoreira added reviewers: samitolvanen, nickdesaulniers, xiangzhangllvm, pengfei, aaron.ballman, pcc, gftg85. joaomoreira added a project: LLVM. Herald added a subscriber: inglorion. Herald added a project: All. joaomoreira requested review of this revision. H

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Perhaps give the other reviewers a couple days to take a look in case I've missed anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { Aren't these two lines supposed to do this? Repository

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:105 + : TU(_TU), TA(_TA), MU(_MU), MA(_MA) {} + Policy(bool _TU, bool _TA, bool _MU, bool _MA, bool _IntrinsicWithoutMU) + : TU(_TU), TA(_TA), MU(_MU), MA(_MA), -

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Ugh, I left cvise running overnight and forgot to include the validity check by building with a previous clang, so my reduction is invalid. I'm going to run it again, but here's the invalid crasher in the meantime: struct SourceLocation { static SourceLocation c

[PATCH] D139999: [clang-format][NFC] Don't run any passes if Environment::make fails

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e89f1cca495: [clang-format][NFC] Don't run any passes if Environment::make fails (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[clang] 0e89f1c - [clang-format][NFC] Don't run any passes if Environment::make fails

Author: Owen Pan Date: 2022-12-14T10:27:05-08:00 New Revision: 0e89f1cca495055795d97b17cb38d43d0c9a7ec1 URL: https://github.com/llvm/llvm-project/commit/0e89f1cca495055795d97b17cb38d43d0c9a7ec1 DIFF: https://github.com/llvm/llvm-project/commit/0e89f1cca495055795d97b17cb38d43d0c9a7ec1.diff LOG:

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

dblaikie added inline comments. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by aprantl wrote: > It looks like all the other namesp

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added a comment. > Is there a plan to enable ModelPOSIX by default, at least on POSIX-compliant > target triples? Yes, this would be more convenient. But all other modeled functions (not only in the ModelPOSIX part of the code) must be checked if they are POSIX compliant. The function

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

aprantl added a comment. Seems fine to me, I just have one inline comment about the name of the namespace. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be pr

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks nicer than the old code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139988/new/ https://reviews.llvm.org/D139988 __

  1   2   >