[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added a comment. Hi @aaron.ballman seems we are failing on recent change 2fc5a3410087c209567c7e4a2c457b6896c127a3 /* The DR asked a question about whether defining a new type within offsetof * is allowed. C2x N235

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

carlosgalvezp updated this revision to Diff 482722. carlosgalvezp added a comment. Wrap to 80 chars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139966/new/ https://reviews.llvm.org/D139966 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

HazardyKnusperkeks added a comment. In D139937#3993641 , @Backl1ght wrote: > In D139937#3992987 , > @HazardyKnusperkeks wrote: > >> In D139937#3992098 , @Backl1ght >> wr

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

carlosgalvezp updated this revision to Diff 482721. carlosgalvezp added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139966/new/ https://reviews.llvm.org/D139966 Files: clang-tools-extra/clang-tidy/add_new_check.py

[clang] b0de363 - [clang] Remove uses of ::testing::Matcher

Author: Fangrui Song Date: 2022-12-14T06:42:35Z New Revision: b0de3630249aedb6910b4ec287ba152b32fd7f19 URL: https://github.com/llvm/llvm-project/commit/b0de3630249aedb6910b4ec287ba152b32fd7f19 DIFF: https://github.com/llvm/llvm-project/commit/b0de3630249aedb6910b4ec287ba152b32fd7f19.diff LOG:

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 482719. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabu

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 482708. rcvalle added a comment. Added KCFI support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersMan

[clang] e2d75f9 - [OpenMP][NFC] Remove more unused code, eliminate warning

Author: Johannes Doerfert Date: 2022-12-13T20:53:45-08:00 New Revision: e2d75f9b6ba58940d82a2e1ef92e8270d6793788 URL: https://github.com/llvm/llvm-project/commit/e2d75f9b6ba58940d82a2e1ef92e8270d6793788 DIFF: https://github.com/llvm/llvm-project/commit/e2d75f9b6ba58940d82a2e1ef92e8270d6793788.d

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 482699. rcvalle added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersManual.r

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 482697. calebzulawski added a comment. Update diff for upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/lib/Driver/ToolChains/Dar

[clang] edb3b44 - [NFC] [C++20] [Modules] Add more lambda tests

Author: Chuanqi Xu Date: 2022-12-14T11:30:12+08:00 New Revision: edb3b44e7d7ca34b7e7a880a15411678d057e039 URL: https://github.com/llvm/llvm-project/commit/edb3b44e7d7ca34b7e7a880a15411678d057e039 DIFF: https://github.com/llvm/llvm-project/commit/edb3b44e7d7ca34b7e7a880a15411678d057e039.diff LO

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added a comment. Committed as https://github.com/llvm/llvm-project/commit/5f68c4111ab9c79b902723df3986dd1033813c01 `ppc-float-abi-warning.cpp` would fail when testing on machine with glibc older than 2.32 but `PPC_LINUX_DEFAULT_IEEELONGDOUBLE` enabled, which is known failure even before

[PATCH] D139450: Warn about unsupported ibmlongdouble

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f68c4111ab9: Warn about unsupported ibmlongdouble (authored by tuliom, committed by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139450/new/ https

[clang] 5f68c41 - Warn about unsupported ibmlongdouble

Author: Tulio Magno Quites Machado Filho Date: 2022-12-14T11:13:54+08:00 New Revision: 5f68c4111ab9c79b902723df3986dd1033813c01 URL: https://github.com/llvm/llvm-project/commit/5f68c4111ab9c79b902723df3986dd1033813c01 DIFF: https://github.com/llvm/llvm-project/commit/5f68c4111ab9c79b902723df398

[PATCH] D136903: [OpenMP][NFCI] Remove effectively dead code from clang and the runtime

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90609fb68f05: [OpenMP][NFCI] Remove effectively dead code in clang and the runtime (authored by jdoerfert). Herald added projects: clang, OpenMP. Her

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne added a comment. You should make sure that the CI is passing before merging! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 ___ cfe-commits mailing lis

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added a comment. In D139737#3991699 , @ymandel wrote: > 2. We (google) have a tool for changing the type of a variable which takes > into account all cascading changes to other declarations that result from > that type change. It is built on Transfo

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Looks like the latest reland still has some issue remaining. With asserts enabled, I get: `assert.h assertion failed at clang/include/clang/AST/Type.h:752 in const ExtQualsTypeCommonBase *clang::QualType::getCommonPtr() const: !isNull() && "Cannot retrieve a NULL typ

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. After this patc

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DWARFv5 added support for labelling template parameters with DW_AT_defa

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A use-case has come up in DWARF CodeGen where we want to determine whether a par

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. ping @Bigcheese @jansvoboda11 would you take a look at this if it will affect the existing users and the development? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 _

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

Backl1ght added a comment. In D139937#3992987 , @HazardyKnusperkeks wrote: > In D139937#3992098 , @Backl1ght > wrote: > >> OMG! I just looked into git history and last edition of this line happened >> about 4 y

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 updated this revision to Diff 482664. Michael137 added a comment. - Use `CHECK-DAG` for attributes - Also compile with non-strict DWARFv4 - Widen the `STRICT-NOT` checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://r

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM. If you could put up a PR after to fix the use of `sys::fs::make_absolute` that would be appreciated 🙇. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c llvm/include/llvm/Su

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482658. haowei added a comment. Rebased the change to solve the merge conflicts on the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/In

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_value (true) +// DWARF-DUMP: DW_TAG_template_value_parameter +// DWARF-DUMP-NEXT:DW_AT_type({{.*}} "bool") --

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_value (true) +// DWARF-DUMP: DW_TAG_template_value_parameter +// DWARF-DUMP-NEXT:DW_AT_type({{.*}} "bool") --

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto lambda2 = [] {}; // expected-error {{default

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3993471 , @craig.topper wrote: > If the caller or callee calculate have different values and one of them is > less than the width of the vector argument it will cause an ABI break. The > type legalizer in SelectionDAG

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. I changed some comments and add more details. If there is no objection, can I get an approval on this change so I can land it? It will unblock our development on Windows cross compilation support. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1933-

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

craig.topper added a comment. In D139627#3993440 , @arsenm wrote: > In D139627#3983718 , @pengfei wrote: > >>> It also doesn't mean that, because the IR doesn't have to be consistent >>> with the attribute. The I

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3993440 , @arsenm wrote: > In D139627#3983718 , @pengfei wrote: > >>> It also doesn't mean that, because the IR doesn't have to be consistent >>> with the attribute. The IR exis

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 482650. calebzulawski added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/te

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

arsenm added a comment. TargetCodeGenInfo::setTargetAttributes already exists as a place for targets to emit their custom attributes, x86 could emit it there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D13970

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3983718 , @pengfei wrote: >> It also doesn't mean that, because the IR doesn't have to be consistent with >> the attribute. The IR exists independent of the attribute, and the attribute >> can only provide performance

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, but please make sure the `.rst` file builds with `sphinx`. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482644. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c llvm/include/llvm/Su

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); zahiraam wrote: > I think it would better to fix this fun

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost added a comment. In that case, when someone has free time, could you commit on my behalf (name: Micah Weston, email: micahswes...@gmail.com). Thank you all for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139801/new/ ht

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

NoQ added a comment. Also, similarly to `getenv()`, in these cases domain-specific knowledge may help suppress some unwanted reports. Eg., if a file has been opened successfully, this doesn't technically mean that it'll be open successfully again, but it makes it more likely, and the user does

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

NoQ added a comment. I like where this is going. Is there a plan to enable `ModelPOSIX` by default, at least on POSIX-compliant target triples? I'm somewhat worried that some users may find null dereference warnings on `fopen()` more annoying than useful (though they're definitely more valuable

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne created this revision. sebastian-ne added reviewers: jloser, MaskRay, dblaikie, jsilvanus. Herald added subscribers: ormris, StephenFan, wenlei, hiraditya. Herald added a project: All. sebastian-ne requested review of this revision. Herald added projects: clang, LLDB, LLVM. Herald adde

[clang] bcd51aa - Don't try to look up a name containing a dependent type.

Author: Richard Smith Date: 2022-12-13T14:42:51-08:00 New Revision: bcd51aaaf8bde4b0ae7a4155d9ce3dec78fe2598 URL: https://github.com/llvm/llvm-project/commit/bcd51aaaf8bde4b0ae7a4155d9ce3dec78fe2598 DIFF: https://github.com/llvm/llvm-project/commit/bcd51aaaf8bde4b0ae7a4155d9ce3dec78fe2598.diff

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Folks, I'm glad you caught it! This is a classic mistake to make with `addTransition()` APIs. I wish we had better APIs that don't have this problem, but instead make it very clear how many executi

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:204 +- Change to Python 3 in the shebang of `add_new_check.py` and `rename_check.py`, as the existing + code is not compatible with Python 2. Should be at the beginning

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 482620. python3kgae added a comment. Rebase and remove the counter in resource metadata to match clang change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Fil

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

craig.topper added a comment. I really think only X86 is using this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D139701 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma added inline comments. Comment at: clang/include/clang/AST/Decl.h:3063 + /// Determine if this field is a potentially-overlapping, that is, + /// subobject with the [[no_unique_address]] attribute + bool isPotentiallyOverlapping() const; Maybe clarify

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.llvm.org/D139302 ___

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

carlosgalvezp updated this revision to Diff 482611. carlosgalvezp added a comment. Mention change in the Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139966/new/ https://reviews.llvm.org/D139966 Files: clang-tools-extra/clang-tid

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

carlosgalvezp updated this revision to Diff 482609. carlosgalvezp added a comment. Revert format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139966/new/ https://reviews.llvm.org/D139966 Files: clang-tools-extra/clang-tidy/add_new_chec

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes #58782 Repository:

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; MyDeve

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3990050 , @ayzhao wrote: > In D129531#3988996 , @ilya-biryukov > wrote: > >> Since the errors only shows up in modular builds, I would look closely for >> bugs inside `ASTReade

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D139937#3992098 , @Backl1ght wrote: > OMG! I just looked into git history and last edition of this line happened > about 4 years ago. Am I doing it wrong? Why? We have lam

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - maybe minor optional tweaks to the test. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_v

[PATCH] D139928: [clang][DebugInfo] Attach DW_AT_default_value to template arg metadata regardless of DwarfVersion

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 _

[PATCH] D139910: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadfb23c607ce: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required. (authored by vporpo). Repository: rG LLVM Github Monorepo CH

[clang] adfb23c - [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

Author: Vasileios Porpodas Date: 2022-12-13T11:46:29-08:00 New Revision: adfb23c607ce35f090cf3e29fba9d382b22c3a50 URL: https://github.com/llvm/llvm-project/commit/adfb23c607ce35f090cf3e29fba9d382b22c3a50 DIFF: https://github.com/llvm/llvm-project/commit/adfb23c607ce35f090cf3e29fba9d382b22c3a50.

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff added inline comments. Comment at: clang/test/CodeGen/strictfp_builtins.c:160 +// CHECK-NEXT:[[TMP1:%.*]] = call double @llvm.fabs.f64(double [[TMP0]]) #[[ATTR5]] +// CHECK-NEXT:[[ISINF:%.*]] = call i1 @llvm.experimental.constrained.fcmp.f64(double [[TMP1]], d

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 482566. ayzhao added a comment. fix memory access issues identified by UBSan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

kpn added inline comments. Comment at: clang/test/CodeGen/strictfp_builtins.c:160 +// CHECK-NEXT:[[TMP1:%.*]] = call double @llvm.fabs.f64(double [[TMP0]]) #[[ATTR5]] +// CHECK-NEXT:[[ISINF:%.*]] = call i1 @llvm.experimental.constrained.fcmp.f64(double [[TMP1]], double

[PATCH] D139956: Workaround an assertion failure during module build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77e14ecf17b: Workaround an assertion failure during module build (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139956: Workaround an assertion failure during module build

steven_wu created this revision. steven_wu added reviewers: mizvekov, arphaman. Herald added a subscriber: ributzka. Herald added a project: All. steven_wu requested review of this revision. Herald added a project: LLVM. After the change in https://reviews.llvm.org/D131858, clang cannot bootstrap

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

paquette added a comment. GISel part LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/ https://reviews.llvm.org/D139938 __

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#3987963 , @MaskRay wrote: >> This change is breaking internal builds. We use the -Xfoo pattern but can >> now no longer manage whether we allow an unused -Xfoo option to pass as a >> warning or promote it to an error.

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 added a comment. In D139928#3992233 , @dblaikie wrote: > (This should be committed in two parts - the LLVM part first, then the Clang > part - since they can be separated, they should be - but happy to review it > altogether) Split the revie

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. **Summary** St

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 updated this revision to Diff 482533. Michael137 added a comment. - Split clang and llvm changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp cla

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

Backl1ght updated this revision to Diff 482530. Backl1ght retitled this revision from "[clang-format] fix typo in doc for SLS_Inline" to "[clang-format] make doc for SLS_Inline more clearly". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 File

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

Backl1ght added a comment. Seems like I have misunderstood it, after some test I'm sure that it means merge if its an argument of a function. I think there are something todo to make the doc more clearly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

MyDeveloperDay added a comment. ditto my concerns with D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine as to if we should have a Leave option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139786/new/ https://reviews.llvm.org/D13978

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; Backl1ght

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I'm not sure if that is correct, as that doesn't fit the example (unless the example is wrong) It feels like its saying merge if its an argument of a function (sort i

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann added a comment. This has already been merged, but I'm commenting just to note (continued) approval of the most recent changes. Looks great, Corentin! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno added a comment. Thank you for your comments. Unfortunately I won't be able to implement these changes because of time constraints in the current project, sorry if I've wasted your time. On the bright side I feel like I've learned something so thank you for that. I hope I can make a prop

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

dblaikie added a comment. (This should be committed in two parts - the LLVM part first, then the Clang part - since they can be separated, they should be - but happy to review it altogether) Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1856 + +bool DwarfUnit::shouldE

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. Some reports can be found here (if the link works and the data does not expire), the runs stored on 2022-12-09. Results appeared only projects "postgres" and "curl" (from memcached,tmux,curl,twin,vim,op

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

tom-anders added a comment. Thanks for the detailed feedback! Unfortunately, I’m sick right now, so I probably won’t be able to give a detailed answer until after Christmas. In D134130#3992116 , @kadircet wrote: > Happy to move the discussion to some ot

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) && ---

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added a comment. This worked for CMake in a previous version, so is good enough on the functionality front. I'll retry with the current state to verify. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 _

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

steakhal added a comment. The `StaticAnalyzer` portion looks good to me AFAICT. Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39 ento::CallDescription::CallDescription(CallDescriptionFlags Flags, - ArrayRef QualifiedName, +

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked an inline comment as done. tuliom added a comment. Thanks @qiucf ! I don't have commit access yet. Could you land this patch for me, please? Please use “Tulio Magno Quites Machado Filho tul...@redhat.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

kadircet added a comment. Hi! Sorry for letting these series of patches sit around without any comments. We were having some discussions internally to both understand the value proposition and its implications on the infrastructure. So it'd help a lot if you can provide some more information fo

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

Backl1ght added a comment. OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 _

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added reviewers: paquette, aemerson. lenary added a comment. Adding Jessica and Amara as this affects GlobalISel for AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary updated this revision to Diff 482489. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/arm_acle.c clan

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) && ---

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

arichardson added a comment. As this is a rather simple cleanup, I'll go ahead and merge this next week unless there is any objection until then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 _

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

ldionne created this revision. ldionne added a reviewer: arphaman. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously, we would be passing down -stdlib=libc++ from the Driver to CC1 whene

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

tahonermann added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto lambda2 = [] {}; // expected-error {{def

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a subscriber: STL_MSFT. compnerd added a comment. @fsb4000 is my reading correct that MSVC will look into trying to handle `static inline` even though it is a GNUism? I wonder if we should consider limiting the use of `static inline` to C mode rather than including C++. I also

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp:40 + + diag(Lambda->getBeginLoc(), "found capturing coroutine lambda"); +} carlosgalvezp wrote: > Perhaps it would be good wi

  1   2   >