[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

2022-11-26 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noticed in GH58962, we should only diagnose illegal overloads of member functions when the ref qualifiers don't

[clang] e2138ec - [clang] Use std::size (NFC)

2022-11-26 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-11-26T13:58:48-08:00 New Revision: e2138ecc72a99cb04fc7d02e57fadcc2b7c85ad9 URL: https://github.com/llvm/llvm-project/commit/e2138ecc72a99cb04fc7d02e57fadcc2b7c85ad9 DIFF: https://github.com/llvm/llvm-project/commit/e2138ecc72a99cb04fc7d02e57fadcc2b7c85ad9.diff L

[PATCH] D119138: [clang-format] Further improve support for requires expressions

2022-11-26 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D119138#3951850 , @klimek wrote: > I changed it in 49aca00d63e14df8bc68fc4329e6cbc9c9805eb8 > . > > "We" is the people working on clang-format :)

[clang] 25f01d5 - Revert "[SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes (take 2)"

2022-11-26 Thread Roman Lebedev via cfe-commits
Author: Roman Lebedev Date: 2022-11-27T00:00:06+03:00 New Revision: 25f01d593ce296078f57e872778b77d074ae5888 URL: https://github.com/llvm/llvm-project/commit/25f01d593ce296078f57e872778b77d074ae5888 DIFF: https://github.com/llvm/llvm-project/commit/25f01d593ce296078f57e872778b77d074ae5888.diff

[clang] 3c4d2a0 - [SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes (take 2)

2022-11-26 Thread Roman Lebedev via cfe-commits
Author: Roman Lebedev Date: 2022-11-26T23:19:15+03:00 New Revision: 3c4d2a03968ccf5889bacffe02d6fa2443b0260f URL: https://github.com/llvm/llvm-project/commit/3c4d2a03968ccf5889bacffe02d6fa2443b0260f DIFF: https://github.com/llvm/llvm-project/commit/3c4d2a03968ccf5889bacffe02d6fa2443b0260f.diff

[PATCH] D119138: [clang-format] Further improve support for requires expressions

2022-11-26 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added a comment. I changed it in 49aca00d63e14df8bc68fc4329e6cbc9c9805eb8 . "We" is the people working on clang-format :) I hope that we have a common goal of making clang-format as easy to maintain as we can. FWIW, I

[clang] 49aca00 - [NFC] Remove peekNextToken(int).

2022-11-26 Thread Manuel Klimek via cfe-commits
Author: Manuel Klimek Date: 2022-11-26T18:23:42Z New Revision: 49aca00d63e14df8bc68fc4329e6cbc9c9805eb8 URL: https://github.com/llvm/llvm-project/commit/49aca00d63e14df8bc68fc4329e6cbc9c9805eb8 DIFF: https://github.com/llvm/llvm-project/commit/49aca00d63e14df8bc68fc4329e6cbc9c9805eb8.diff LOG:

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-26 Thread Amir Ayupov via Phabricator via cfe-commits
Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" thevinster wrote: > Were you p

[PATCH] D138746: [clang-format] Add .inc extension to git-clang-format

2022-11-26 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea created this revision. aganea added a reviewer: clang-format. Herald added a project: All. aganea requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The .inc extension isn't picked up for formatting when doing `git clang-format` on the

[PATCH] D119138: [clang-format] Further improve support for requires expressions

2022-11-26 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D119138#3951749 , @klimek wrote: > Generally, why do we need to have that much information? I.e. why do we need > to know the exact type of the "requires" keyword? > I do understand we need to know the brace type, b

[PATCH] D119138: [clang-format] Further improve support for requires expressions

2022-11-26 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added a comment. Generally, why do we need to have that much information? I.e. why do we need to know the exact type of the "requires" keyword? I do understand we need to know the brace type, but that seems like it would be easier to figure out in the TokenAnnotator (where we already pars