[PATCH] D137768: [opt][clang] Enable using -module-summary with -S / -emit-llvm

alexander-shaposhnikov updated this revision to Diff 474922. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/split-lto-unit.c llvm/include/l

[PATCH] D137768: [opt][clang] Enable using -module-summary with -S / -emit-llvm

alexander-shaposhnikov updated this revision to Diff 474921. alexander-shaposhnikov retitled this revision from "[opt] Enable using -module-summary with -S" to "[opt][clang] Enable using -module-summary with -S / -emit-llvm". Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] e588d23 - Add back single quotes when dontcall attribute was split into dontcall-error/dontcall-warn

Author: Fangrui Song Date: 2022-11-11T22:59:51-08:00 New Revision: e588d23a91fd28cd4218995a33c2a46fe721ff62 URL: https://github.com/llvm/llvm-project/commit/e588d23a91fd28cd4218995a33c2a46fe721ff62 DIFF: https://github.com/llvm/llvm-project/commit/e588d23a91fd28cd4218995a33c2a46fe721ff62.diff

[PATCH] D137883: [clang-format][NFC] Improve documentation of FixNamespaceComments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

Re: How can Autoconf help with the transition to stricter compilation defaults?

Florian Weimer writes: > based on a limited attempt to get this fixed about three years > ago, I expect that many of the problematic packages have not had their > configure scripts regenerated using autoconf for a decade or more. This > means that as an autoconf maintainer, you unfortunately won'

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3921948 , @jhuber6 wrote: > @dhruvachak Do you still need help updating the LLVM tests? If you go a few messages back, there are some llvm tests that @jdoerfert said were not updated properly. Can someone help upda

[PATCH] D137876: Dummy change to test the Clang/libc++ CI

ldionne abandoned this revision. ldionne added a comment. libc++ CI passed. So I think this is working. Nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137876/new/ https://reviews.llvm.org/D137876 __

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare marked an inline comment as done. gedare added a comment. I've added unit tests and confirmed (1) the new tests fail on current `main` and (2) all unit tests pass with this revision applied. [100%] Running lit suite /llvm-project/clang/test/Unit Testing Time: 250.49s Skipped:

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474901. gedare added a comment. - fixup typo in unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp clang/li

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson added a comment. Sorry, for some reason I hadn’t received any emails about this so I only noticed now. I’ll look into the issues and come back once the issues are resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https:

[PATCH] D137876: Dummy change to test the Clang/libc++ CI

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Pinging some folks just for awareness, I'll abandon this if CI passes. Repository: rG LLVM Github Monorepo http

[clang] 76db4e3 - clang: Fix unnecessary truncation of resource limit values

Author: Matt Arsenault Date: 2022-11-11T16:38:51-08:00 New Revision: 76db4e3c439e6bc2921690e501ba025998f4599d URL: https://github.com/llvm/llvm-project/commit/76db4e3c439e6bc2921690e501ba025998f4599d DIFF: https://github.com/llvm/llvm-project/commit/76db4e3c439e6bc2921690e501ba025998f4599d.diff

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added a comment. In D136998#3906881 , @efriedma wrote: > Might also be worth considering if we can avoid cloning here. It should be > possible to emit the lambda body into a separate function with a calling > convention of your choice, and make

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 474889. akhuang marked an inline comment as done. akhuang added a comment. Move cloning code into a function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files:

[PATCH] D137875: clang/AMDGPU: Drop volatile from builtin_atomic* pointers

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The codegen takes the volatileness from the used val

[PATCH] D137874: clang/AMDGPU: Use Support's wrapper around getenv

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: MaskRay, wdng. This does some extra stuff for Windows, so m

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474881. gedare added a comment. Refactor horrible to read logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp cl

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

arsenm added a comment. Herald added subscribers: kosarev, StephenFan. Herald added a project: All. Is this still relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84743/new/ https://reviews.llvm.org/D84743 __

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474876. gedare added a comment. add unit tests for BlockIndent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp cla

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 474874. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/A

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137872 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/C

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:102 .Default(OMPC_ATOMIC_DEFAULT_MEM_ORDER_unknown); + case OMPC_at: + return llvm::StringSwitch(Str) I run git-clang-format I don't see any change. I don't know where has prob

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare marked 2 inline comments as done. gedare added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5006-5010 +return !((Previous && (Previous->is(tok::kw_for) || Previous->isIf())) || + (Right.Next && + (Right.Next->is(tok::l_paren

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple template

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks updated this revision to Diff 474850. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lld

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks updated this revision to Diff 474848. aeubanks added a comment. use getNameForDiagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemC

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: rymiel, MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, minor nits. Nice cleanup. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729 + const llvm::StringRef &Na

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale updated this revision to Diff 474828. michele.scandale added a comment. Rebase on top of compiler driver changes for `-funsafe-math-optimizations` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136786/new/ https://reviews.llvm.org/D

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev wrote: > Make it private Thanks. Yes. Changed Co

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 474826. jyu2 added a comment. Herald added a project: Flang. Thanks Alexey, for the review. This is addressing his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks added a comment. In D137762#3919092 , @MyDeveloperDay wrote: > Definitely needs tests Could you please add tests in the `clang/unittests/Format/FormatTest.cpp` file? Comment at: clang/lib/Format/TokenAnnotator.cpp:

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost marked an inline comment as done. red1bluelost added a comment. I noticed that the Premerge seemed ran into an issue with 'InsertBraces'. It looks to me that it is unrelated and probably due to the pre-merge machine using a pre-15 clang-format (I ran into similar issue on my local m

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. I intend to base this patch on D137838 once it goes through the major refactoring of bridging the header files. For the sake of simplicity, for now I'll keep it on top of D137516 . Repository:

[clang] 88aac16 - [LinkerWrapper] Fix -Wpessimizing-move

Author: Fangrui Song Date: 2022-11-11T11:53:06-08:00 New Revision: 88aac163241ac8eaec5274b4ead0107aeb1102b3 URL: https://github.com/llvm/llvm-project/commit/88aac163241ac8eaec5274b4ead0107aeb1102b3 DIFF: https://github.com/llvm/llvm-project/commit/88aac163241ac8eaec5274b4ead0107aeb1102b3.diff

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f7e8631547a: [LinkerWrapper] Perform device linking steps in parallel (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ http

[clang] 0f7e863 - [LinkerWrapper] Perform device linking steps in parallel

Author: Joseph Huber Date: 2022-11-11T13:46:33-06:00 New Revision: 0f7e8631547ad2cbbe5bcf1933e1353e58f58406 URL: https://github.com/llvm/llvm-project/commit/0f7e8631547ad2cbbe5bcf1933e1353e58f58406 DIFF: https://github.com/llvm/llvm-project/commit/0f7e8631547ad2cbbe5bcf1933e1353e58f58406.diff

[clang] 28e0798 - Revert "[Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms."

Author: Alex Brachet Date: 2022-11-11T19:40:08Z New Revision: 28e07984c3427908c9b423c7ed0cf6ac3064c5d8 URL: https://github.com/llvm/llvm-project/commit/28e07984c3427908c9b423c7ed0cf6ac3064c5d8 DIFF: https://github.com/llvm/llvm-project/commit/28e07984c3427908c9b423c7ed0cf6ac3064c5d8.diff LOG:

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added a comment. I think this is a move in the right direction, and generally is probably pretty close. The new bool for `ArgsHasSubstitutionFailure` isn't something I get the need for yet though. we also need release notes. Comment at: clang/include/clang/AST/Ex

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders updated this revision to Diff 474818. tom-anders added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137040/new/ https://reviews.llvm.org/D137040 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 474817. fpetrogalli added a comment. I have applied the chaged suggested by @jrtc27: 1. The classes `RISCVProcessorModelPROC` and `RISCVProcessorModelTUNE_PROC` now are derived from `ProcessorModel`; 2. The `Enum` field is removed from both classes. What

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474814. gedare added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474812. gedare added a comment. Run tests and fix bad breaks. Fix comment style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/TokenAnnotat

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay added a comment. Moving target-specific parsers outside LLVMSupport LGTM. I even objected a bit when more stuff of this kind was introduced into LLVMSupport. +1 for adding temporary forwarding headers for now to avoid update all `#include` users. Repository: rG LLVM Github Monorepo

[PATCH] D137714: Do not merge traps in functions annotated optnone

hnrklssn marked 2 inline comments as done. hnrklssn added a comment. Made changes in line with what @fcloutier suggested. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5321 + SetLLVMFunctionAttributesForDefinition(D, Fn); CodeGenFunction(*this).GenerateCode(GD, Fn, FI);

[PATCH] D137714: Do not merge traps in functions annotated optnone

hnrklssn updated this revision to Diff 474811. hnrklssn added a comment. No longer reorders annotations to occur before codegen. Instead EmitTrapCheck checks the function declaration for OptimizeNoneAttr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @tom-anders Thank you for reviewing and giving suggestions! Hope I use the `llvm::StringSet` correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 _

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry updated this revision to Diff 474808. v1nh1shungry added a comment. Apply the review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 Files: clang-tools-extra/clangd/refactor/twe

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added a comment. > Yes, this probably would become untenable with really large sizes. I think that horse had left the barn long ago. Vast majority of NVIDIA GPU cycles these days spent in libraries shipped by NVIDIA and those are huge (O(1GB)), numerous (cuDNN, TensorRT, cuBLAS, cuSPARSE, c

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added a comment. @dhruvachak Do you still need help updating the LLVM tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing lis

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

FabioLuporini added a comment. Hi, any chance this will be completed any time soon? We are very keen to resurrect our clang-based OpenMP offloading pipeline at https://github.com/devitocodes/devito :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 33d848b - Fix typo; NFC

Author: Aaron Ballman Date: 2022-11-11T13:02:41-05:00 New Revision: 33d848b992ee1d3a6b39b3b6f1a42b46d583bf72 URL: https://github.com/llvm/llvm-project/commit/33d848b992ee1d3a6b39b3b6f1a42b46d583bf72 DIFF: https://github.com/llvm/llvm-project/commit/33d848b992ee1d3a6b39b3b6f1a42b46d583bf72.diff

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. @stella.stamenova Any updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

tom-anders added a comment. This looks really cool :) Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:133 + std::string Directives; + for (auto &Using : UsingToAdd) +Directives += llvm::formatv("using namespace {0};\n", Using); -

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

erichkeane added a comment. I haven't dealt much with the loop hint attributes, but two of my coworkers have done extensive work in our downstream (@jyu2 and @mikerice), and likely have feedback about how this affects downstream feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. Hi @lenary - thank you for working on this! The patch is reasonable to me. I agree on the suggestion of using forwarding headers or the first iteration of the change, it will make it easier to review. I'll adapt the auto-get patch at D137517

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

shafik added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:319 + }; + // There are 7 categories of loop hints attributes: vectorize, interleave, + // unroll, unroll_and_jam, pipeline, distribute, and vectorize predicate. Can you break up this co

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + Make it private Comment at: clang/include/clang/Parse/P

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. In D137838#3921828 , @thakis wrote: > This is a gigantic diff. I'd recommend keeping the .h files in the old place > for v0 and make them just forwarding headers that include the header at the > new location. That way, you don't

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:447 +SmallString<128> CanonicalPath = FE.getNameAsRequested(); +ModMapInfo.canonicalizeModuleMapPath(CanonicalPath); +MD.ModuleMapFileDeps.emplace_ba

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Her

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

thakis added a comment. This is a gigantic diff. I'd recommend keeping the .h files in the old place for v0 and make them just forwarding headers that include the header at the new location. That way, you don't have to update oodles of include lines in this patch, and it makes it a bit easier t

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1 +//===- unittest/Format/ConfiParseTest.cpp - Config parsing unit tests -===// +// rymiel wrote: > typo (Co

[PATCH] D137154: Adding nvvm_reflect clang builtin

jhuber6 added a comment. In D137154#3918949 , @bader wrote: > Is binary size a concern here? NVIDIA, AMD and Intel GPUs are already have ~ > 20 different architectures each, so I want my app/library to run on any GPU > from these vendors (which is quite

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 474782. reames added a comment. Address comments from @craig.topper CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

tmatheson added a comment. Makes sense since it is so similar to `get_cpus()` and is only used in Threading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 __

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

tmatheson accepted this revision. tmatheson added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:47 #include "llvm/Option/ArgList.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h"

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

to268 accepted this revision. to268 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 474770. cor3ntin added a comment. Address Shafik's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h clang/include/cl

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. I've trimmed the failing code down to #include #include #include template struct SO { void a() { struct SI { std::vector v; }; SI s; SI m(std::move(s)); } void g() { std::vector v{"a"}; } }; in

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing list cfe-commits@l

[clang] 91628f0 - The handling of 'funsafe-math-optimizations' doesn't update the 'MathErrno'

Author: Zahira Ammarguellat Date: 2022-11-11T10:24:12-05:00 New Revision: 91628f0616ca5203945afb56b3d8a27522b99808 URL: https://github.com/llvm/llvm-project/commit/91628f0616ca5203945afb56b3d8a27522b99808 DIFF: https://github.com/llvm/llvm-project/commit/91628f0616ca5203945afb56b3d8a27522b99808

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91628f0616ca: The handling of 'funsafe-math-optimizations' doesn't update the 'MathErrno' (authored by zahiraam). Changed prior to commit: https:

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. In D137516#3912900 , @fpetrogalli wrote: > In D137516#3912842 , @lenary wrote: > >> In D137516#3912751 , @fpetrogalli >> wrote: >> >>> @arsenm @f

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, Nov 10, 2022 at 4:05 PM Paul Eggert wrote: > > On 2022-11-10 10:19, Aaron Ballman wrote: > > In terms of the Clang side of things, I don't think we've formed any > > sort of official stance on how to handle that yet. It's UB (you can > > declare the C standard library interface without UB

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. Herald added a subscriber: Michael137. Apologies to everyone who has automatically been marked as a reviewer for this change. There is more context for it here: https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419/4?u=lenary Repositor

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

inclyc created this revision. Herald added a project: All. inclyc added a reviewer: aaron.ballman. inclyc published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds InitListExpr case in format string checks. e.g. int sprintf(char *__restrict

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein updated this revision to Diff 474751. hokein marked an inline comment as done. hokein added a comment. use FileEntry in the API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 Files: clang-tools

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary created this revision. Herald added subscribers: kadircet, arphaman, hiraditya, krytarowski. Herald added a project: All. lenary requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. This change is focussed on

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This should live with the Arm targets, given th

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder marked an inline comment as done. tbaeder added a comment. Can't push this without https://reviews.llvm.org/D135750, since the variables in the test functions are used without being initialized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

sammccall updated this revision to Diff 474738. sammccall added a comment. - hover card follows the internal data model: symbol -> location -> header (->include, later) - don't use public API, so we can get at internal details Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderAnalysis.h:28 +/// dont-include-me pattern heuristically. +bool isSelfContainedHeader(FileID FID, const SourceManager &SM, + HeaderSearch &HeaderInfo); -

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 __

[clang-tools-extra] e000c2b - [include-cleaner] NFC, move the macro location fixme to findHeaders.

Author: Haojian Wu Date: 2022-11-11T14:55:29+01:00 New Revision: e000c2bce75ec59782e1a2459c4db6d7a996590c URL: https://github.com/llvm/llvm-project/commit/e000c2bce75ec59782e1a2459c4db6d7a996590c DIFF: https://github.com/llvm/llvm-project/commit/e000c2bce75ec59782e1a2459c4db6d7a996590c.diff LO

[clang-tools-extra] 15b2702 - [include-cleaner] NFC, correct a comment in

Author: Haojian Wu Date: 2022-11-11T14:40:08+01:00 New Revision: 15b2702e83fa1e99e56b51a4254e8dc4f331ca9d URL: https://github.com/llvm/llvm-project/commit/15b2702e83fa1e99e56b51a4254e8dc4f331ca9d DIFF: https://github.com/llvm/llvm-project/commit/15b2702e83fa1e99e56b51a4254e8dc4f331ca9d.diff LO

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/Header.h:21 +/// +/// A header is considered self-contained if either it has a proper header guard +/// or it doesn't has dont-include-me-similar pattern. kadircet wrote: > kadircet

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein updated this revision to Diff 474735. hokein added a comment. getBufferData => getMemoryBufferForFileOrNone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 Files: clang-tools-extra/clangd/Headers

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This seems reasonable to me, but I'll leave the final sign-off to Erich. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:331-332 const LoopHintAttr *NumericAttr; - } HintAttrs[] = {{nullptr, nullptr},

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

rymiel added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1 +//===- unittest/Format/ConfiParseTest.cpp - Config parsing unit tests -===// +// typo (Confi) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D137531: [clang] Add the check of decltype in derived templates for issue #58674

lime updated this revision to Diff 474731. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/SemaCXX/decltype.cpp =

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Header.cpp:64 + // particular preprocessor state, usually set up by another header. + return !isDontIncludeMeHeader(SM.getBufferData(SM.translateFile(FE))); +} sammccall wrote: > kadircet

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7943169273b2: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders (authored by sammccall). Repository: rG LLVM Github Monor

[clang-tools-extra] 7943169 - [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

Author: Sam McCall Date: 2022-11-11T13:41:54+01:00 New Revision: 7943169273b22f61a0322cb2d38ff75845e52628 URL: https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628 DIFF: https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628.diff LO

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

sammccall added inline comments. Comment at: clang/lib/Tooling/Inclusions/Header.cpp:64 + // particular preprocessor state, usually set up by another header. + return !isDontIncludeMeHeader(SM.getBufferData(SM.translateFile(FE))); +} kadircet wrote: > sammccall

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137825/new/ https://reviews.llvm.org/D137825

[clang] 1da74ee - [Clang][LoongArch] Remove duplicate declaration. NFC

Author: wanglei Date: 2022-11-11T20:36:18+08:00 New Revision: 1da74eeb0e1b6cb0d427148d9ed05afb3a1e01bc URL: https://github.com/llvm/llvm-project/commit/1da74eeb0e1b6cb0d427148d9ed05afb3a1e01bc DIFF: https://github.com/llvm/llvm-project/commit/1da74eeb0e1b6cb0d427148d9ed05afb3a1e01bc.diff LOG:

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

sammccall added a comment. In D137825#3921273 , @tschuett wrote: > You could: > > static_assert(std::variant_size_v<> == 2); > > Kind kind() const { if (std::holds_alternative(Storage)) > return Kind::Physical; return Kind::Standard; } > > an

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/Header.h:21 +/// +/// A header is considered self-contained if either it has a proper header guard +/// or it doesn't has dont-include-me-similar pattern. kadircet wrote: > let's

  1   2   >